Re: [Intel-gfx] [PATCH v2 09/11] drm/i915/gen9+: Program watermarks as a separate step during evasion, v2.

2016-10-27 Thread Maarten Lankhorst
Op 27-10-16 om 01:24 schreef Matt Roper: > On Wed, Oct 26, 2016 at 03:41:37PM +0200, Maarten Lankhorst wrote: >> The watermark updates for SKL style watermarks are no longer done >> in the plane callbacks, but are now called in a separate watermark >> update function that's called during the same

Re: [Intel-gfx] [PATCH v2 09/11] drm/i915/gen9+: Program watermarks as a separate step during evasion, v2.

2016-10-26 Thread Matt Roper
On Wed, Oct 26, 2016 at 03:41:37PM +0200, Maarten Lankhorst wrote: > The watermark updates for SKL style watermarks are no longer done > in the plane callbacks, but are now called in a separate watermark > update function that's called during the same vblank evasion, > before the plane updates. >

Re: [Intel-gfx] [PATCH v2 09/11] drm/i915/gen9+: Program watermarks as a separate step during evasion, v2.

2016-10-26 Thread Lyude Paul
This approach is perfect :). Reviewed-by: Lyude On Wed, 2016-10-26 at 15:41 +0200, Maarten Lankhorst wrote: > The watermark updates for SKL style watermarks are no longer done > in the plane callbacks, but are now called in a separate watermark > update function that's called

[Intel-gfx] [PATCH v2 09/11] drm/i915/gen9+: Program watermarks as a separate step during evasion, v2.

2016-10-26 Thread Maarten Lankhorst
The watermark updates for SKL style watermarks are no longer done in the plane callbacks, but are now called in a separate watermark update function that's called during the same vblank evasion, before the plane updates. This also gets rid of the global skl_results, which was required for keeping