Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Cleanup i915_gem_restore_gtt_mappings()

2016-11-28 Thread David Weinehall
On Mon, Nov 21, 2016 at 12:30:01PM +, Chris Wilson wrote: > > I was looking at how we get out of the pm_runtime mess. In part, we hurt > ourselves because we are using wakeref_count to disable asserts, but it > also seems that pushing the optimisation to pm_runtime is the right > thing to do.

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Cleanup i915_gem_restore_gtt_mappings()

2016-11-21 Thread Chris Wilson
On Mon, Nov 21, 2016 at 02:21:39PM +0200, David Weinehall wrote: > On Fri, Nov 18, 2016 at 01:58:35PM +, Chris Wilson wrote: > > On Fri, Nov 18, 2016 at 03:36:45PM +0200, David Weinehall wrote: > > > On resume we unbind+bind our VMA-mappings. This patch simplifies > > > this a bit by

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Cleanup i915_gem_restore_gtt_mappings()

2016-11-18 Thread Chris Wilson
On Fri, Nov 18, 2016 at 03:36:45PM +0200, David Weinehall wrote: > On resume we unbind+bind our VMA-mappings. This patch simplifies > this a bit by introducing a restore_vma() helper. As a nice side-effect > this also makes the resume callgraph self-documenting. > > v2: move the helper to

[Intel-gfx] [PATCH v2 1/3] drm/i915: Cleanup i915_gem_restore_gtt_mappings()

2016-11-18 Thread David Weinehall
On resume we unbind+bind our VMA-mappings. This patch simplifies this a bit by introducing a restore_vma() helper. As a nice side-effect this also makes the resume callgraph self-documenting. v2: move the helper to i915_gem_gtt.c since it's only used by i915_gem_restore_gtt_mappings(),