Re: [Intel-gfx] [PATCH v2 11/11] drm/i915: Extract i915_module.c

2021-08-25 Thread Jani Nikula
On Tue, 27 Jul 2021, Daniel Vetter wrote: > +static void __exit i915_exit(void) > +{ > + int i; > + > + for (i = init_progress - 1; i >= 0; i--) { > + GEM_BUG_ON(i >= ARRAY_SIZE(init_funcs)); Not introduced by you, but it's kind of silly we're using GEM_BUG_ON() in generic

Re: [Intel-gfx] [PATCH v2 11/11] drm/i915: Extract i915_module.c

2021-08-23 Thread Jani Nikula
On Mon, 23 Aug 2021, Guenter Roeck wrote: > On Tue, Jul 27, 2021 at 02:10:37PM +0200, Daniel Vetter wrote: >> The module init code is somewhat misplaced in i915_pci.c, since it >> needs to pull in init/exit functions from every part of the driver and >> pollutes the include list a lot. >> >>

Re: [Intel-gfx] [PATCH v2 11/11] drm/i915: Extract i915_module.c

2021-08-23 Thread Guenter Roeck
On Tue, Jul 27, 2021 at 02:10:37PM +0200, Daniel Vetter wrote: > The module init code is somewhat misplaced in i915_pci.c, since it > needs to pull in init/exit functions from every part of the driver and > pollutes the include list a lot. > > Extract an i915_module.c file which pulls all the

Re: [Intel-gfx] [PATCH v2 11/11] drm/i915: Extract i915_module.c

2021-07-27 Thread Jason Ekstrand
On Tue, Jul 27, 2021 at 9:44 AM Tvrtko Ursulin wrote: > > > On 27/07/2021 13:10, Daniel Vetter wrote: > > The module init code is somewhat misplaced in i915_pci.c, since it > > needs to pull in init/exit functions from every part of the driver and > > pollutes the include list a lot. > > > >

Re: [Intel-gfx] [PATCH v2 11/11] drm/i915: Extract i915_module.c

2021-07-27 Thread Tvrtko Ursulin
On 27/07/2021 13:10, Daniel Vetter wrote: The module init code is somewhat misplaced in i915_pci.c, since it needs to pull in init/exit functions from every part of the driver and pollutes the include list a lot. Extract an i915_module.c file which pulls all the bits together, and allows us to

[Intel-gfx] [PATCH v2 11/11] drm/i915: Extract i915_module.c

2021-07-27 Thread Daniel Vetter
The module init code is somewhat misplaced in i915_pci.c, since it needs to pull in init/exit functions from every part of the driver and pollutes the include list a lot. Extract an i915_module.c file which pulls all the bits together, and allows us to massively trim the include list of