Re: [Intel-gfx] [PATCH v3 01/14] drm/i915: Give each sw_fence its own lockclass

2016-11-14 Thread Chris Wilson
On Mon, Nov 14, 2016 at 04:48:00PM +0200, Joonas Lahtinen wrote: > On ma, 2016-11-14 at 08:56 +, Chris Wilson wrote: > > + static struct lock_class_key __key; \ > > When lockdep is disabled, this becomes zero size. We might still get > rid of the #fence strings, with

Re: [Intel-gfx] [PATCH v3 01/14] drm/i915: Give each sw_fence its own lockclass

2016-11-14 Thread Joonas Lahtinen
On ma, 2016-11-14 at 08:56 +, Chris Wilson wrote: > Localise the static struct lock_class_key to the caller of > i915_sw_fence_init() so that we create a lock_class instance for each > unique sw_fence rather than all sw_fences sharing the same > lock_class. This eliminate some lockdep false

Re: [Intel-gfx] [PATCH v3 01/14] drm/i915: Give each sw_fence its own lockclass

2016-11-14 Thread Tvrtko Ursulin
On 14/11/2016 08:56, Chris Wilson wrote: Localise the static struct lock_class_key to the caller of i915_sw_fence_init() so that we create a lock_class instance for each unique sw_fence rather than all sw_fences sharing the same lock_class. This eliminate some lockdep false positive when using

Re: [Intel-gfx] [PATCH v3 01/14] drm/i915: Give each sw_fence its own lockclass

2016-11-14 Thread Chris Wilson
On Mon, Nov 14, 2016 at 09:01:00AM +, Tvrtko Ursulin wrote: > > On 14/11/2016 08:56, Chris Wilson wrote: > >Localise the static struct lock_class_key to the caller of > >i915_sw_fence_init() so that we create a lock_class instance for each > >unique sw_fence rather than all sw_fences sharing

Re: [Intel-gfx] [PATCH v3 01/14] drm/i915: Give each sw_fence its own lockclass

2016-11-14 Thread Tvrtko Ursulin
On 14/11/2016 08:56, Chris Wilson wrote: Localise the static struct lock_class_key to the caller of i915_sw_fence_init() so that we create a lock_class instance for each unique sw_fence rather than all sw_fences sharing the same lock_class. This eliminate some lockdep false positive when using

[Intel-gfx] [PATCH v3 01/14] drm/i915: Give each sw_fence its own lockclass

2016-11-14 Thread Chris Wilson
Localise the static struct lock_class_key to the caller of i915_sw_fence_init() so that we create a lock_class instance for each unique sw_fence rather than all sw_fences sharing the same lock_class. This eliminate some lockdep false positive when using fences from within fence callbacks.