Re: [Intel-gfx] [PATCH v3 12/14] drm/i915/dp: localize link rate index variable more

2017-04-04 Thread Manasi Navare
On Wed, Mar 29, 2017 at 10:22:32AM +0300, Jani Nikula wrote: > On Wed, 29 Mar 2017, Manasi Navare wrote: > > Why not squash this with patch 08/14? and call it cleanup for obtaining the > > rate index using intel_dp_rate_index() > > Just a thought.. > > Again, usually

Re: [Intel-gfx] [PATCH v3 12/14] drm/i915/dp: localize link rate index variable more

2017-03-29 Thread Jani Nikula
On Wed, 29 Mar 2017, Manasi Navare wrote: > Why not squash this with patch 08/14? and call it cleanup for obtaining the > rate index using intel_dp_rate_index() > Just a thought.. Again, usually too big patches are the problem, not the other way around. BR, Jani. > >

Re: [Intel-gfx] [PATCH v3 12/14] drm/i915/dp: localize link rate index variable more

2017-03-28 Thread Manasi Navare
Why not squash this with patch 08/14? and call it cleanup for obtaining the rate index using intel_dp_rate_index() Just a thought.. Regards Manasi On Tue, Mar 28, 2017 at 05:59:12PM +0300, Jani Nikula wrote: > Localize link_rate_index to the if block, and rename to just index to > reduce indent.

[Intel-gfx] [PATCH v3 12/14] drm/i915/dp: localize link rate index variable more

2017-03-28 Thread Jani Nikula
Localize link_rate_index to the if block, and rename to just index to reduce indent. Cc: Manasi Navare Cc: Ville Syrjälä Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_dp.c | 13 +++-- 1 file