Re: [Intel-gfx] [PATCH v3 2/5] drm/i915/wopcm: Check WOPCM layout separately from calculations

2019-08-16 Thread Michal Wajdeczko
On Fri, 16 Aug 2019 13:21:03 +0200, Chris Wilson wrote: Quoting Michal Wajdeczko (2019-08-16 11:54:58) +static inline bool __check_layout(struct drm_i915_private *i915, u32 wopcm_size, + u32 guc_wopcm_base, u32 guc_wopcm_size, +

Re: [Intel-gfx] [PATCH v3 2/5] drm/i915/wopcm: Check WOPCM layout separately from calculations

2019-08-16 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-08-16 11:54:58) > +static inline bool __check_layout(struct drm_i915_private *i915, u32 > wopcm_size, > + u32 guc_wopcm_base, u32 guc_wopcm_size, > + u32 guc_fw_size, u32 huc_fw_size) > +{ > + cons

[Intel-gfx] [PATCH v3 2/5] drm/i915/wopcm: Check WOPCM layout separately from calculations

2019-08-16 Thread Michal Wajdeczko
We can do WOPCM partitioning using rough estimates and limits and perform detailed check as separate step. v2: oops! s/max/min v3: consolidate overflow checks (Daniele) Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Cc: Chris Wilson --- drivers/gpu/drm/i915/intel_wopcm.c | 97