Re: [Intel-gfx] [PATCH v3 5/7] drm/i915: Convert i915_ggtt_view to use an anonymous union

2017-01-13 Thread Joonas Lahtinen
On pe, 2017-01-13 at 10:33 +, Chris Wilson wrote: > Reading the ggtt_views is much more pleasant without the extra > characters from specifying the union (i.e. ggtt_view.partial rather than > ggtt_view.params.partial). To make this work inside i915_vma_compare() > with only a single memcmp

Re: [Intel-gfx] [PATCH v3 5/7] drm/i915: Convert i915_ggtt_view to use an anonymous union

2017-01-13 Thread Tvrtko Ursulin
On 13/01/2017 10:33, Chris Wilson wrote: Reading the ggtt_views is much more pleasant without the extra characters from specifying the union (i.e. ggtt_view.partial rather than ggtt_view.params.partial). To make this work inside i915_vma_compare() with only a single memcmp requires us to ensure

[Intel-gfx] [PATCH v3 5/7] drm/i915: Convert i915_ggtt_view to use an anonymous union

2017-01-13 Thread Chris Wilson
Reading the ggtt_views is much more pleasant without the extra characters from specifying the union (i.e. ggtt_view.partial rather than ggtt_view.params.partial). To make this work inside i915_vma_compare() with only a single memcmp requires us to ensure that there are no uninitialised bytes