Re: [Intel-gfx] [PATCH v4] x86/quirks: Replace QFLAG_APPLY_ONCE with static locals

2022-01-13 Thread Rodrigo Vivi
On Wed, Jan 12, 2022 at 05:28:29PM -0800, Lucas De Marchi wrote: > On Wed, Jan 12, 2022 at 07:06:45PM -0600, Bjorn Helgaas wrote: > > On Wed, Jan 12, 2022 at 04:21:28PM -0800, Lucas De Marchi wrote: > > > On Wed, Jan 12, 2022 at 06:08:05PM -0600, Bjorn Helgaas wrote: > > > > On Wed, Jan 12, 2022

Re: [Intel-gfx] [PATCH v4] x86/quirks: Replace QFLAG_APPLY_ONCE with static locals

2022-01-12 Thread Lucas De Marchi
On Wed, Jan 12, 2022 at 07:06:45PM -0600, Bjorn Helgaas wrote: On Wed, Jan 12, 2022 at 04:21:28PM -0800, Lucas De Marchi wrote: On Wed, Jan 12, 2022 at 06:08:05PM -0600, Bjorn Helgaas wrote: > On Wed, Jan 12, 2022 at 03:30:43PM -0800, Lucas De Marchi wrote: > > The flags are only used to mark a

Re: [Intel-gfx] [PATCH v4] x86/quirks: Replace QFLAG_APPLY_ONCE with static locals

2022-01-12 Thread Bjorn Helgaas
On Wed, Jan 12, 2022 at 04:21:28PM -0800, Lucas De Marchi wrote: > On Wed, Jan 12, 2022 at 06:08:05PM -0600, Bjorn Helgaas wrote: > > On Wed, Jan 12, 2022 at 03:30:43PM -0800, Lucas De Marchi wrote: > > > The flags are only used to mark a quirk to be called once and nothing > > > else. Also, that

Re: [Intel-gfx] [PATCH v4] x86/quirks: Replace QFLAG_APPLY_ONCE with static locals

2022-01-12 Thread Lucas De Marchi
On Wed, Jan 12, 2022 at 06:08:05PM -0600, Bjorn Helgaas wrote: On Wed, Jan 12, 2022 at 03:30:43PM -0800, Lucas De Marchi wrote: The flags are only used to mark a quirk to be called once and nothing else. Also, that logic may not be appropriate if the quirk wants to do additional filtering and

Re: [Intel-gfx] [PATCH v4] x86/quirks: Replace QFLAG_APPLY_ONCE with static locals

2022-01-12 Thread Bjorn Helgaas
On Wed, Jan 12, 2022 at 03:30:43PM -0800, Lucas De Marchi wrote: > The flags are only used to mark a quirk to be called once and nothing > else. Also, that logic may not be appropriate if the quirk wants to > do additional filtering and set quirk as applied by itself. > > So replace the uses of

[Intel-gfx] [PATCH v4] x86/quirks: Replace QFLAG_APPLY_ONCE with static locals

2022-01-12 Thread Lucas De Marchi
The flags are only used to mark a quirk to be called once and nothing else. Also, that logic may not be appropriate if the quirk wants to do additional filtering and set quirk as applied by itself. So replace the uses of QFLAG_APPLY_ONCE with static local variables in the few quirks that use this