Re: [Intel-gfx] [PATCH v7] drm/i915/execlists: Move WA_TAIL_DWORDS to callee

2016-08-19 Thread Dave Gordon
On 19/08/16 14:39, Chris Wilson wrote: On Fri, Aug 19, 2016 at 02:31:15PM +0100, Dave Gordon wrote: @@ -654,6 +680,14 @@ int intel_logical_ring_alloc_request_extras(struct drm_i915_gem_request *request */ request->reserved_space += EXECLISTS_REQUEST_SIZE; + /* +

Re: [Intel-gfx] [PATCH v7] drm/i915/execlists: Move WA_TAIL_DWORDS to callee

2016-08-19 Thread Chris Wilson
On Fri, Aug 19, 2016 at 02:31:15PM +0100, Dave Gordon wrote: > @@ -654,6 +680,14 @@ int intel_logical_ring_alloc_request_extras(struct > drm_i915_gem_request *request >*/ > request->reserved_space += EXECLISTS_REQUEST_SIZE; > > + /* > + * WA_TAIL_DWORDS is specific to the

[Intel-gfx] [PATCH v7] drm/i915/execlists: Move WA_TAIL_DWORDS to callee

2016-08-19 Thread Dave Gordon
Currently the execlist-specific emit-request functions start writing to the ring and reserve space for a workaround to be emitted later whilst submitting the request. It is easier to read if the caller only allocates sufficient space for its own accesses (then the reader can quickly verify that