Re: [Intel-gfx] [PATCH v7 06/11] drm/i915: Enable i915 perf stream for Haswell OA unit

2016-10-27 Thread Chris Wilson
On Wed, Oct 26, 2016 at 12:05:44AM +0100, Chris Wilson wrote: > On Tue, Oct 25, 2016 at 12:19:29AM +0100, Robert Bragg wrote: > > + /* So that we don't have to worry about updating the context ID > > +* in OACONTOL on the fly we make sure to pin the context > > +* upfront for the

Re: [Intel-gfx] [PATCH v7 06/11] drm/i915: Enable i915 perf stream for Haswell OA unit

2016-10-26 Thread Robert Bragg
On Wed, Oct 26, 2016 at 4:03 PM, Robert Bragg wrote: > On 26 Oct 2016 11:08 a.m., "Matthew Auld" > wrote: > > > > On 26 October 2016 at 00:51, Robert Bragg wrote: > > > > > > > > > On Tue, Oct 25, 2016 at 10:35 PM,

Re: [Intel-gfx] [PATCH v7 06/11] drm/i915: Enable i915 perf stream for Haswell OA unit

2016-10-26 Thread Robert Bragg
On 26 Oct 2016 5:54 p.m., "Ville Syrjälä" wrote: > > On Wed, Oct 26, 2016 at 05:42:23PM +0100, Robert Bragg wrote: > > On Wed, Oct 26, 2016 at 4:37 PM, Ville Syrjälä < > > ville.syrj...@linux.intel.com> wrote: > > > > > On Wed, Oct 26, 2016 at 04:17:45PM +0100,

Re: [Intel-gfx] [PATCH v7 06/11] drm/i915: Enable i915 perf stream for Haswell OA unit

2016-10-26 Thread Ville Syrjälä
On Wed, Oct 26, 2016 at 05:42:23PM +0100, Robert Bragg wrote: > On Wed, Oct 26, 2016 at 4:37 PM, Ville Syrjälä < > ville.syrj...@linux.intel.com> wrote: > > > On Wed, Oct 26, 2016 at 04:17:45PM +0100, Robert Bragg wrote: > > > On 26 Oct 2016 9:54 a.m., "Chris Wilson" >

Re: [Intel-gfx] [PATCH v7 06/11] drm/i915: Enable i915 perf stream for Haswell OA unit

2016-10-26 Thread Daniel Vetter
On Wed, Oct 26, 2016 at 05:42:23PM +0100, Robert Bragg wrote: > On Wed, Oct 26, 2016 at 4:37 PM, Ville Syrjälä < > ville.syrj...@linux.intel.com> wrote: > > > On Wed, Oct 26, 2016 at 04:17:45PM +0100, Robert Bragg wrote: > > > On 26 Oct 2016 9:54 a.m., "Chris Wilson" >

Re: [Intel-gfx] [PATCH v7 06/11] drm/i915: Enable i915 perf stream for Haswell OA unit

2016-10-26 Thread Robert Bragg
On Wed, Oct 26, 2016 at 4:37 PM, Ville Syrjälä < ville.syrj...@linux.intel.com> wrote: > On Wed, Oct 26, 2016 at 04:17:45PM +0100, Robert Bragg wrote: > > On 26 Oct 2016 9:54 a.m., "Chris Wilson" > wrote: > > > > > > On Wed, Oct 26, 2016 at 12:51:58AM +0100, Robert

Re: [Intel-gfx] [PATCH v7 06/11] drm/i915: Enable i915 perf stream for Haswell OA unit

2016-10-26 Thread Ville Syrjälä
On Wed, Oct 26, 2016 at 04:17:45PM +0100, Robert Bragg wrote: > On 26 Oct 2016 9:54 a.m., "Chris Wilson" wrote: > > > > On Wed, Oct 26, 2016 at 12:51:58AM +0100, Robert Bragg wrote: > > >On Tue, Oct 25, 2016 at 10:35 PM, Matthew Auld > > >

Re: [Intel-gfx] [PATCH v7 06/11] drm/i915: Enable i915 perf stream for Haswell OA unit

2016-10-26 Thread Robert Bragg
On 26 Oct 2016 9:54 a.m., "Chris Wilson" wrote: > > On Wed, Oct 26, 2016 at 12:51:58AM +0100, Robert Bragg wrote: > >On Tue, Oct 25, 2016 at 10:35 PM, Matthew Auld > ><[1]matthew.william.a...@gmail.com> wrote: > > > > On 25 October 2016 at 00:19, Robert

Re: [Intel-gfx] [PATCH v7 06/11] drm/i915: Enable i915 perf stream for Haswell OA unit

2016-10-26 Thread Robert Bragg
On 26 Oct 2016 11:08 a.m., "Matthew Auld" wrote: > > On 26 October 2016 at 00:51, Robert Bragg wrote: > > > > > > On Tue, Oct 25, 2016 at 10:35 PM, Matthew Auld > > wrote: > >> > >> On 25 October 2016 at

Re: [Intel-gfx] [PATCH v7 06/11] drm/i915: Enable i915 perf stream for Haswell OA unit

2016-10-26 Thread Matthew Auld
On 26 October 2016 at 00:51, Robert Bragg wrote: > > > On Tue, Oct 25, 2016 at 10:35 PM, Matthew Auld > wrote: >> >> On 25 October 2016 at 00:19, Robert Bragg wrote: > > >> >> >> > diff --git

Re: [Intel-gfx] [PATCH v7 06/11] drm/i915: Enable i915 perf stream for Haswell OA unit

2016-10-26 Thread Chris Wilson
On Wed, Oct 26, 2016 at 12:51:58AM +0100, Robert Bragg wrote: >On Tue, Oct 25, 2016 at 10:35 PM, Matthew Auld ><[1]matthew.william.a...@gmail.com> wrote: > > On 25 October 2016 at 00:19, Robert Bragg <[2]rob...@sixbynine.org> > wrote: > >  > > > diff --git

Re: [Intel-gfx] [PATCH v7 06/11] drm/i915: Enable i915 perf stream for Haswell OA unit

2016-10-25 Thread Robert Bragg
On Tue, Oct 25, 2016 at 10:35 PM, Matthew Auld < matthew.william.a...@gmail.com> wrote: > On 25 October 2016 at 00:19, Robert Bragg wrote: > > > diff --git a/drivers/gpu/drm/i915/i915_drv.h > b/drivers/gpu/drm/i915/i915_drv.h > > index 3448d05..ea24814 100644 > > ---

Re: [Intel-gfx] [PATCH v7 06/11] drm/i915: Enable i915 perf stream for Haswell OA unit

2016-10-25 Thread Chris Wilson
On Tue, Oct 25, 2016 at 12:19:29AM +0100, Robert Bragg wrote: > +static int claim_specific_ctx(struct i915_perf_stream *stream) > +{ > + struct drm_i915_private *dev_priv = stream->dev_priv; > + struct i915_vma *vma; > + int ret; > + > + ret =

Re: [Intel-gfx] [PATCH v7 06/11] drm/i915: Enable i915 perf stream for Haswell OA unit

2016-10-25 Thread Matthew Auld
On 25 October 2016 at 00:19, Robert Bragg wrote: > Gen graphics hardware can be set up to periodically write snapshots of > performance counters into a circular buffer via its Observation > Architecture and this patch exposes that capability to userspace via the > i915 perf

[Intel-gfx] [PATCH v7 06/11] drm/i915: Enable i915 perf stream for Haswell OA unit

2016-10-24 Thread Robert Bragg
Gen graphics hardware can be set up to periodically write snapshots of performance counters into a circular buffer via its Observation Architecture and this patch exposes that capability to userspace via the i915 perf interface. v2: Make sure to initialize ->specific_ctx_id when opening,