Re: [Intel-gfx] [PATCH v9 06/25] kvm/vfio: Accept vfio device file from userspace

2023-04-07 Thread Liu, Yi L
Hi Eric, > From: Eric Auger > Sent: Friday, April 7, 2023 4:57 PM > > Hi Yi, > > On 4/7/23 05:42, Liu, Yi L wrote: > >> From: Alex Williamson > >> Sent: Friday, April 7, 2023 2:58 AM > You don't say anything about potential restriction, ie. what if the user > calls >

Re: [Intel-gfx] [PATCH v9 06/25] kvm/vfio: Accept vfio device file from userspace

2023-04-07 Thread Eric Auger
Hi Yi, On 4/7/23 05:42, Liu, Yi L wrote: >> From: Alex Williamson >> Sent: Friday, April 7, 2023 2:58 AM You don't say anything about potential restriction, ie. what if the user calls KVM_DEV_VFIO_FILE with device fds while it has been using legacy >> container/group API?

Re: [Intel-gfx] [PATCH v9 06/25] kvm/vfio: Accept vfio device file from userspace

2023-04-06 Thread Liu, Yi L
> From: Alex Williamson > Sent: Friday, April 7, 2023 2:58 AM > > > > > > You don't say anything about potential restriction, ie. what if the user > > > calls > > > KVM_DEV_VFIO_FILE with device fds while it has been using legacy > container/group > > > API? > > > > legacy container/group path

Re: [Intel-gfx] [PATCH v9 06/25] kvm/vfio: Accept vfio device file from userspace

2023-04-06 Thread Alex Williamson
On Thu, 6 Apr 2023 10:49:45 + "Liu, Yi L" wrote: > Hi Eric, > > > From: Eric Auger > > Sent: Thursday, April 6, 2023 5:47 PM > > > > Hi Yi, > > > > On 4/1/23 17:18, Yi Liu wrote: > > > This defines KVM_DEV_VFIO_FILE* and make alias with KVM_DEV_VFIO_GROUP*. > > > Old userspace uses

Re: [Intel-gfx] [PATCH v9 06/25] kvm/vfio: Accept vfio device file from userspace

2023-04-06 Thread Liu, Yi L
Hi Eric, > From: Eric Auger > Sent: Thursday, April 6, 2023 5:47 PM > > Hi Yi, > > On 4/1/23 17:18, Yi Liu wrote: > > This defines KVM_DEV_VFIO_FILE* and make alias with KVM_DEV_VFIO_GROUP*. > > Old userspace uses KVM_DEV_VFIO_GROUP* works as well. > > > > Reviewed-by: Jason Gunthorpe > >

Re: [Intel-gfx] [PATCH v9 06/25] kvm/vfio: Accept vfio device file from userspace

2023-04-06 Thread Eric Auger
Hi Yi, On 4/1/23 17:18, Yi Liu wrote: > This defines KVM_DEV_VFIO_FILE* and make alias with KVM_DEV_VFIO_GROUP*. > Old userspace uses KVM_DEV_VFIO_GROUP* works as well. > > Reviewed-by: Jason Gunthorpe > Reviewed-by: Kevin Tian > Tested-by: Terrence Xu > Tested-by: Nicolin Chen > Tested-by:

[Intel-gfx] [PATCH v9 06/25] kvm/vfio: Accept vfio device file from userspace

2023-04-01 Thread Yi Liu
This defines KVM_DEV_VFIO_FILE* and make alias with KVM_DEV_VFIO_GROUP*. Old userspace uses KVM_DEV_VFIO_GROUP* works as well. Reviewed-by: Jason Gunthorpe Reviewed-by: Kevin Tian Tested-by: Terrence Xu Tested-by: Nicolin Chen Tested-by: Matthew Rosato Tested-by: Yanting Jiang