Re: [Intel-gfx] [RFC PATCH] drm/i915: Debugfs statistics interface for psr

2022-05-20 Thread Hogander, Jouni
Hello Jose, Thank you for your comments, see my response below. On Thu, 2022-05-19 at 13:47 +, Souza, Jose wrote: > On Thu, 2022-05-19 at 12:17 +, Hogander, Jouni wrote: > > On Wed, 2022-05-18 at 20:00 +, Souza, Jose wrote: > > > On Wed, 2022-05-18 at 10:45 +0300, Jouni Högander wrot

Re: [Intel-gfx] [RFC PATCH] drm/i915: Debugfs statistics interface for psr

2022-05-19 Thread Souza, Jose
On Thu, 2022-05-19 at 12:17 +, Hogander, Jouni wrote: > On Wed, 2022-05-18 at 20:00 +, Souza, Jose wrote: > > On Wed, 2022-05-18 at 10:45 +0300, Jouni Högander wrote: > > > Currently there is no mean to get understanding how psr is > > > utilized. > > > E.g. How much psr is actually enabled

Re: [Intel-gfx] [RFC PATCH] drm/i915: Debugfs statistics interface for psr

2022-05-19 Thread Hogander, Jouni
On Wed, 2022-05-18 at 20:00 +, Souza, Jose wrote: > On Wed, 2022-05-18 at 10:45 +0300, Jouni Högander wrote: > > Currently there is no mean to get understanding how psr is > > utilized. > > E.g. How much psr is actually enabled or how often driver falls > > back > > to full update. > > But wit

Re: [Intel-gfx] [RFC PATCH] drm/i915: Debugfs statistics interface for psr

2022-05-18 Thread Souza, Jose
On Wed, 2022-05-18 at 10:45 +0300, Jouni Högander wrote: > Currently there is no mean to get understanding how psr is utilized. > E.g. How much psr is actually enabled or how often driver falls back > to full update. But with this information what can you do? I don't see much value on it. We have

Re: [Intel-gfx] [RFC PATCH] drm/i915: Debugfs statistics interface for psr

2022-05-18 Thread Jani Nikula
On Wed, 18 May 2022, Jouni Högander wrote: > Currently there is no mean to get understanding how psr is utilized. > E.g. How much psr is actually enabled or how often driver falls back > to full update. > > This patch addresses this by adding new debugfs interface > i915_edp_psr_stats. Statistics

[Intel-gfx] [RFC PATCH] drm/i915: Debugfs statistics interface for psr

2022-05-18 Thread Jouni Högander
Currently there is no mean to get understanding how psr is utilized. E.g. How much psr is actually enabled or how often driver falls back to full update. This patch addresses this by adding new debugfs interface i915_edp_psr_stats. Statistics gathering is started by writing 1/y/Y and stopped by wr