Re: [Intel-gfx] [RFC v3] drm/i915: Eliminate devid sprinkle

2018-02-26 Thread Jani Nikula
On Mon, 26 Feb 2018, Chris Wilson wrote: > Quoting Jani Nikula (2018-02-26 14:00:37) >> On Thu, 22 Feb 2018, Tvrtko Ursulin wrote: >> > From: Tvrtko Ursulin >> > >> > Introduce subplatform mask to eliminate throughout the code devid checking >> > sprinkle, mostly courtesy of IS_*_UL[TX] macros.

Re: [Intel-gfx] [RFC v3] drm/i915: Eliminate devid sprinkle

2018-02-26 Thread Chris Wilson
Quoting Jani Nikula (2018-02-26 14:00:37) > On Thu, 22 Feb 2018, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > > > Introduce subplatform mask to eliminate throughout the code devid checking > > sprinkle, mostly courtesy of IS_*_UL[TX] macros. > > > > Subplatform mask initialization is moved

Re: [Intel-gfx] [RFC v3] drm/i915: Eliminate devid sprinkle

2018-02-26 Thread Jani Nikula
On Thu, 22 Feb 2018, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Introduce subplatform mask to eliminate throughout the code devid checking > sprinkle, mostly courtesy of IS_*_UL[TX] macros. > > Subplatform mask initialization is moved either to static tables (Ironlake > M) or runtime device

Re: [Intel-gfx] [RFC v3] drm/i915: Eliminate devid sprinkle

2018-02-22 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-02-22 10:15:04) > +void intel_device_info_subplatform_init(struct intel_device_info *info) > +{ > + struct drm_i915_private *i915 = > + container_of(info, struct drm_i915_private, info); > + u16 devid = INTEL_DEVID(i915); > + > + if (IS_P

Re: [Intel-gfx] [RFC v3] drm/i915: Eliminate devid sprinkle

2018-02-22 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-02-22 10:15:04) > +#define INTEL_SUBPLATFORM_IRONLAKE_M (0) > + > +#define INTEL_SUBPLATFORM_PINEVIEW_G (0) > +#define INTEL_SUBPLATFORM_PINEVIEW_M (1) Looking at these, we can reduce these to IS_MOBILE. Clearer before or after this conversion? Pretty orthogonal I thin

[Intel-gfx] [RFC v3] drm/i915: Eliminate devid sprinkle

2018-02-22 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Introduce subplatform mask to eliminate throughout the code devid checking sprinkle, mostly courtesy of IS_*_UL[TX] macros. Subplatform mask initialization is moved either to static tables (Ironlake M) or runtime device info init (Pineview, Haswell, Broadwell, Skylake, Kabyl