Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 2/2] intel-ci: Skip module reloads

[Chris Wilson]

Quoting Petri Latvala (2018-08-10 10:55:06)
> On Fri, Aug 10, 2018 at 10:41:45AM +0100, Chris Wilson wrote:
> > Reloading the module may impact subsequent tests by destabilising the
> > system. As we do for BAT, if we want to test reloads, it should be
> > handled explicitly at the end of the run, rather than placed at random
> > in the middle of the test list.
> > 
> > v2: Commentary
> > 
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=106539
> > Signed-off-by: Chris Wilson 
> > Cc: Tomi Sarvela 
> 
> 
> The series is
> 
> Acked-by: Petri Latvala 

I've pushed this to see if this does indeed stabilise our test results
as currently we have random failures that change on every shardlist
rebuild.

I think we need an explicit test list to check after reload. I think
BAT?
-Chris
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 2/2] intel-ci: Skip module reloads

[Petri Latvala]

On Fri, Aug 10, 2018 at 10:41:45AM +0100, Chris Wilson wrote:
> Reloading the module may impact subsequent tests by destabilising the
> system. As we do for BAT, if we want to test reloads, it should be
> handled explicitly at the end of the run, rather than placed at random
> in the middle of the test list.
> 
> v2: Commentary
> 
> References: https://bugs.freedesktop.org/show_bug.cgi?id=106539
> Signed-off-by: Chris Wilson 
> Cc: Tomi Sarvela 


The series is

Acked-by: Petri Latvala 



> ---
>  tests/intel-ci/blacklist.txt | 9 +
>  1 file changed, 9 insertions(+)
> 
> diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt
> index 7700a60b7..c93554a37 100644
> --- a/tests/intel-ci/blacklist.txt
> +++ b/tests/intel-ci/blacklist.txt
> @@ -5,6 +5,15 @@ igt@meta_test(@.*)?
>  igt@drv_selftest(@.*)?
>  igt@drm_mm(@.*)?
>  ###
> +# Handle module reloads with great care!
> +#
> +# Reloading a module is more likely to leave
> +# the machine in an unexpected state than other
> +# self-contained tests, leading to random
> +# failures in tests run afterwards.
> +###
> +igt@drv_module_reload(@.*)?
> +###
>  # GEM
>  ###
>  igt@gem_busy@(?!.*basic).*hang.*
> -- 
> 2.18.0
> 
> ___
> igt-dev mailing list
> igt-...@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx