Re: [Intel-gfx] missing acpi backlight bisected to 9661e92c10

2011-08-12 Thread Matthew Garrett
On Mon, Aug 22, 2011 at 10:25:24AM +0430, Ali Gholami Rudi wrote: Yet, /sys/devices/virtual/backlight/acpi_video0/brightness only appears after the revert. Seems something changes its behavior if new_bd-dev.parent is not NULL in backlight_device_register(). Well, yes, if it has a parent it

Re: [Intel-gfx] missing acpi backlight bisected to 9661e92c10

2011-08-11 Thread Matthew Garrett
Well, that all looks fine. And I also can't see any way that this commit could cause the backlight not to appear - all it does is set the parent if it's present. There's no new path that could cause it to return early. Does reverting this patch really make things work? -- Matthew Garrett |