Re: [Intel-gfx] v5.11-rc5 BUG kmalloc-1k (Not tainted): Redzone overwritten

2021-02-01 Thread Chris Wilson
Quoting Jani Nikula (2021-01-28 13:23:48)
> 
> A number of our CI systems are hitting redzone overwritten errors after
> s2idle, with the errors introduced between v5.11-rc4 and v5.11-rc5. See
> snippet below, full logs for one affected machine at [1].
> 
> Known issue?

Fwiw, I think this should be fixed by

commit 08d60e5999540110576e7c1346d486220751b7f9
Author: John Ogness 
Date:   Sun Jan 24 21:33:28 2021 +0106

printk: fix string termination for record_print_text()

Commit f0e386ee0c0b ("printk: fix buffer overflow potential for
print_text()") added string termination in record_print_text().
However it used the wrong base pointer for adding the terminator.
This led to a 0-byte being written somewhere beyond the buffer.

Use the correct base pointer when adding the terminator.

Fixes: f0e386ee0c0b ("printk: fix buffer overflow potential for 
print_text()")
Reported-by: Sven Schnelle 
Signed-off-by: John Ogness 
Signed-off-by: Petr Mladek 
Link: 
https://lore.kernel.org/r/20210124202728.4718-1-john.ogn...@linutronix.de

din should be rolled forward, but there's yet another regression in rc6
breaking suspend on all machines.
-Chris
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx


[Intel-gfx] v5.11-rc5 BUG kmalloc-1k (Not tainted): Redzone overwritten

2021-01-28 Thread Jani Nikula


A number of our CI systems are hitting redzone overwritten errors after
s2idle, with the errors introduced between v5.11-rc4 and v5.11-rc5. See
snippet below, full logs for one affected machine at [1].

Known issue?

BR,
Jani.


[1] 
https://intel-gfx-ci.01.org/tree/drm-intel-fixes/CI_DIF_549/fi-tgl-u2/igt@gem_exec_susp...@basic-s0.html


<6> [71.947160] Restarting tasks ... done.
<3> [71.948035] 
=
<3> [71.948545] BUG kmalloc-1k (Not tainted): Redzone overwritten
<3> [71.948577] 
-
<4> [71.948625] Disabling lock debugging due to kernel taint
<3> [71.948626] INFO: 0xde6e27d6-0xeaa949e9 @offset=29696. 
First byte 0x0 instead of 0xcc
<3> [71.948633] INFO: Allocated in syslog_print+0x39/0x200 age=1 cpu=6 pid=427
<3> [71.948642] __slab_alloc.isra.86.constprop.94+0x7e/0x90
<3> [71.948647] kmem_cache_alloc_trace+0x337/0x420
<3> [71.948651] syslog_print+0x39/0x200
<3> [71.948654] do_syslog.part.23+0x31a/0x480
<3> [71.948658] kmsg_read+0x3c/0x50
<3> [71.948663] vfs_read+0xa8/0x1b0
<3> [71.948667] ksys_read+0x5a/0xd0
<3> [71.948670] do_syscall_64+0x33/0x80
<3> [71.948674] entry_SYSCALL_64_after_hwframe+0x44/0xa9
<3> [71.948679] INFO: Freed in kfree_rcu_work+0x2ef/0x320 age=658 cpu=3 pid=195
<3> [71.948685] kmem_cache_free_bulk+0xbeb/0xcb0
<3> [71.948689] kfree_rcu_work+0x2ef/0x320
<3> [71.948693] process_one_work+0x270/0x5c0
<3> [71.948697] worker_thread+0x37/0x380
<3> [71.948701] kthread+0x146/0x170
<3> [71.948705] ret_from_fork+0x1f/0x30
<3> [71.948709] INFO: Slab 0x97533187 objects=10 used=9 
fp=0x2183a6cf flags=0x80010201
<3> [71.948714] INFO: Object 0xb43421a9 @offset=28672 
fp=0x
<3> [71.948720] Redzone 34747f33: cc cc cc cc cc cc cc cc cc cc cc cc 
cc cc cc cc  
<3> [71.948726] Redzone 1c57bf27: cc cc cc cc cc cc cc cc cc cc cc cc 
cc cc cc cc  
<3> [71.948731] Redzone 6763eea0: cc cc cc cc cc cc cc cc cc cc cc cc 
cc cc cc cc  
<3> [71.948736] Redzone 28c40de8: cc cc cc cc cc cc cc cc cc cc cc cc 
cc cc cc cc  
<3> [71.948742] Redzone c8e197cc: cc cc cc cc cc cc cc cc cc cc cc cc 
cc cc cc cc  
<3> [71.948747] Redzone 8b77f05a: cc cc cc cc cc cc cc cc cc cc cc cc 
cc cc cc cc  
<3> [71.948752] Redzone 3e1a5f65: cc cc cc cc cc cc cc cc cc cc cc cc 
cc cc cc cc  
<3> [71.948757] Redzone 568b4b04: cc cc cc cc cc cc cc cc cc cc cc cc 
cc cc cc cc  
<3> [71.948762] Redzone 183f376e: cc cc cc cc cc cc cc cc cc cc cc cc 
cc cc cc cc  
<3> [71.948767] Redzone 3aafec8b: cc cc cc cc cc cc cc cc cc cc cc cc 
cc cc cc cc  
<3> [71.948773] Redzone ec8d8c96: cc cc cc cc cc cc cc cc cc cc cc cc 
cc cc cc cc  
<3> [71.948779] Redzone 54f062b1: cc cc cc cc cc cc cc cc cc cc cc cc 
cc cc cc cc  
<3> [71.948784] Redzone 44f67988: cc cc cc cc cc cc cc cc cc cc cc cc 
cc cc cc cc  
<3> [71.948790] Redzone f7a07bd6: cc cc cc cc cc cc cc cc cc cc cc cc 
cc cc cc cc  
<3> [71.948796] Redzone 4719a4f1: cc cc cc cc cc cc cc cc cc cc cc cc 
cc cc cc cc  
<3> [71.948801] Redzone 06a35936: cc cc cc cc cc cc cc cc cc cc cc cc 
cc cc cc cc  
<3> [71.948807] Redzone f8aefa64: cc cc cc cc cc cc cc cc cc cc cc cc 
cc cc cc cc  
<3> [71.948812] Redzone 8550e102: cc cc cc cc cc cc cc cc cc cc cc cc 
cc cc cc cc  
<3> [71.948817] Redzone 9189a7a1: cc cc cc cc cc cc cc cc cc cc cc cc 
cc cc cc cc  
<3> [71.948823] Redzone 7a3b9eea: cc cc cc cc cc cc cc cc cc cc cc cc 
cc cc cc cc  
<3> [71.948828] Redzone ab035e44: cc cc cc cc cc cc cc cc cc cc cc cc 
cc cc cc cc  
<3> [71.948834] Redzone 01d5ee40: cc cc cc cc cc cc cc cc cc cc cc cc 
cc cc cc cc  
<3> [71.948840] Redzone 9c676a9c: cc cc cc cc cc cc cc cc cc cc cc cc 
cc cc cc cc  
<3> [71.948845] Redzone 309ce2cf: cc cc cc cc cc cc cc cc cc cc cc cc 
cc cc cc cc  
<3> [71.948850] Redzone f620b753: cc cc cc cc cc cc cc cc cc cc cc cc 
cc cc cc cc  
<3> [71.948855] Redzone 082c33d0: cc cc cc cc cc cc cc cc cc cc cc cc 
cc cc cc cc  
<3> [71.948860] Redzone 498e33d7: cc cc cc cc cc cc cc cc cc cc cc cc 
cc cc cc cc  
<3> [71.948866] Redzone 3d9447fb: cc cc cc cc cc cc cc cc cc cc cc cc 
cc cc cc cc  
<3>