Re: [PATCH 01/10] drm/i915/display: convert inner wakeref get towards get_if_in_use

2024-03-15 Thread Ville Syrjälä
On Thu, Mar 07, 2024 at 09:46:22AM -0500, Rodrigo Vivi wrote: > On Thu, Mar 07, 2024 at 02:30:46AM +0200, Ville Syrjälä wrote: > > On Wed, Mar 06, 2024 at 07:15:45PM -0500, Rodrigo Vivi wrote: > > > This patch brings no functional change. Since at this point of > > > the code we are already

Re: [PATCH 01/10] drm/i915/display: convert inner wakeref get towards get_if_in_use

2024-03-11 Thread Rodrigo Vivi
On Mon, Mar 11, 2024 at 05:06:32PM +0200, Imre Deak wrote: > On Fri, Mar 08, 2024 at 10:19:58AM -0500, Rodrigo Vivi wrote: > > [...] > > > > > > The difference between a wakeref (aka wakelock) and a raw-wakeref is > > > that the former is required for accessing the HW, which is asserted when > >

Re: [PATCH 01/10] drm/i915/display: convert inner wakeref get towards get_if_in_use

2024-03-11 Thread Imre Deak
On Fri, Mar 08, 2024 at 10:19:58AM -0500, Rodrigo Vivi wrote: > [...] > > > > The difference between a wakeref (aka wakelock) and a raw-wakeref is > > that the former is required for accessing the HW, which is asserted when > > reading/writing a register. A raw-wakeref is not enough for this and

Re: [PATCH 01/10] drm/i915/display: convert inner wakeref get towards get_if_in_use

2024-03-08 Thread Rodrigo Vivi
On Thu, Mar 07, 2024 at 10:14:12PM +0200, Imre Deak wrote: > On Thu, Mar 07, 2024 at 09:46:22AM -0500, Rodrigo Vivi wrote: > > On Thu, Mar 07, 2024 at 02:30:46AM +0200, Ville Syrjälä wrote: > > > On Wed, Mar 06, 2024 at 07:15:45PM -0500, Rodrigo Vivi wrote: > > > > This patch brings no functional

Re: [PATCH 01/10] drm/i915/display: convert inner wakeref get towards get_if_in_use

2024-03-07 Thread Imre Deak
On Thu, Mar 07, 2024 at 09:46:22AM -0500, Rodrigo Vivi wrote: > On Thu, Mar 07, 2024 at 02:30:46AM +0200, Ville Syrjälä wrote: > > On Wed, Mar 06, 2024 at 07:15:45PM -0500, Rodrigo Vivi wrote: > > > This patch brings no functional change. Since at this point of > > > the code we are already

[PATCH 01/10] drm/i915/display: convert inner wakeref get towards get_if_in_use

2024-03-07 Thread Rodrigo Vivi
This patch brings no functional change. Since at this point of the code we are already asserting a wakeref was held, it means that we are with runtime_pm 'in_use' and in practical terms we are only bumping the pm_runtime usage counter and moving on. However, xe driver has a lockdep annotation

Re: [PATCH 01/10] drm/i915/display: convert inner wakeref get towards get_if_in_use

2024-03-07 Thread Rodrigo Vivi
On Thu, Mar 07, 2024 at 02:30:46AM +0200, Ville Syrjälä wrote: > On Wed, Mar 06, 2024 at 07:15:45PM -0500, Rodrigo Vivi wrote: > > This patch brings no functional change. Since at this point of > > the code we are already asserting a wakeref was held, it means > > that we are with runtime_pm