Re: [Intel-gfx] [PATCH 1/3] drm/i915: Unbind the bo if the user requests a different alignment

2010-04-12 Thread Chris Wilson
On Mon, 12 Apr 2010 10:10:22 -0700, Eric Anholt e...@anholt.net wrote: On Sun, 4 Apr 2010 22:35:19 +0100, Chris Wilson ch...@chris-wilson.co.uk wrote: If the buffer is currently bound and does not meet the requested alignment, then unbind it and repin. Do we have any users legitimately

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Unbind the bo if the user requests a different alignment

2010-04-14 Thread Chris Wilson
On Tue, 13 Apr 2010 16:49:46 -0700, Eric Anholt e...@anholt.net wrote: On Mon, 12 Apr 2010 18:23:22 +0100, Chris Wilson ch...@chris-wilson.co.uk wrote: On Mon, 12 Apr 2010 10:10:22 -0700, Eric Anholt e...@anholt.net wrote: On Sun, 4 Apr 2010 22:35:19 +0100, Chris Wilson ch...@chris

Re: [Intel-gfx] [PATCH] drm/i915: fix tiling limits for i915 class hw

2010-04-15 Thread Chris Wilson
the max pitch value is 16 for 512 byte wide tiles. -ickle -- Chris Wilson, Intel Open Source Technology Centre ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 1/2] drm/i915: check execbuffer for validity earlier to save on work.

2010-04-22 Thread Chris Wilson
. Ainsworth o...@openbsd.org Minor comment inline. Reviewed-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/i915_gem.c | 42 ++ 1 files changed, 16 insertions(+), 26 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Remove the bind in mmap_gtt_ioctl

2010-04-22 Thread Chris Wilson
as it would on the ioctl being called. Discussed with danvet and jbarnes. Signed-Off-By: Owain G. Ainsworth o...@openbsd.org Acked-by: Chris Wilson ch...@chris-wilson.co.uk -ickle -- Chris Wilson, Intel Open Source Technology Centre ___ Intel-gfx mailing

[Intel-gfx] [PATCH] drm/i915: Mark the object as dirty when setting to the CPU write domain.

2010-05-09 Thread Chris Wilson
Or else we may not write back the written pages upon unbind. For example the contents of a batch buffer written using a simple mmap or using shmmem pwrite may be discarded if we are forced to evict everything whilst pinning the objects for execbuffer. Signed-off-by: Chris Wilson ch...@chris

Re: [Intel-gfx] [PATCH] drm/i915: Mark the object as dirty when setting to the CPU write domain.

2010-05-09 Thread Chris Wilson
On Sun, 9 May 2010 21:42:00 +0100, Chris Wilson ch...@chris-wilson.co.uk wrote: Or else we may not write back the written pages upon unbind. For example the contents of a batch buffer written using a simple mmap or using shmmem pwrite may be discarded if we are forced to evict everything

[Intel-gfx] [PATCH] drm/i915: Protect mmaped buffers from casual eviction.

2010-05-11 Thread Chris Wilson
://bugs.freedesktop.org/show_bug.cgi?id=24369 Bug 15911 - Intermittent X crash (freeze) https://bugzilla.kernel.org/show_bug.cgi?id=15911 Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Tested-by: Christian von Schultz ker...@vonschultz.se --- drivers/gpu/drm/i915/i915_drv.h | 13

Re: [Intel-gfx] [PATCH] drm/i915: Record error batch buffers using iomem

2010-05-11 Thread Chris Wilson
On Tue, 11 May 2010 11:37:22 -0400, Andrew Morton a...@linux-foundation.org wrote: On Tue, 11 May 2010 19:22:14 +0100 Chris Wilson ch...@chris-wilson.co.uk wrote: + reloc_offset = src_priv-gtt_offset; for (page = 0; page page_count; page++) { - void *s, *d = kmalloc

Re: [Intel-gfx] [PATCH] drm/i915: Protect mmaped buffers from casual eviction.

2010-05-11 Thread Chris Wilson
at which we have to mmap buffers should reduce as well... -ickle -- Chris Wilson, Intel Open Source Technology Centre ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] drm/i915: Reject bind_to_gtt() early if object aperture

2010-05-13 Thread Chris Wilson
If the object is bigger than the entire aperture, reject it early before evicting everything in a vain attempt to find space. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: sta...@kernel.org --- drivers/gpu/drm/i915/i915_gem.c |8 1 files changed, 8 insertions(+), 0

[Intel-gfx] [PATCH] drm/i915: Fail to load driver if KMS request without GEM

2010-05-17 Thread Chris Wilson
[a0207589] drm_mm_search_free+0x49/0x90 [drm] RSP 8800699f3af8 CR2: Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/i915_dma.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_dma.c

[Intel-gfx] [PATCH] agp/intel: Restrict GTT mapping to valid range on i915 and i945

2010-05-18 Thread Chris Wilson
. So we must careful to map and fill the appropriate range depending on chipset. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/char/agp/intel-gtt.c | 45 +++-- 1 files changed, 38 insertions(+), 7 deletions(-) diff --git a/drivers/char/agp

Re: [Intel-gfx] [PATCH 0/9] [RFC] fair-lru eviction

2010-05-19 Thread Chris Wilson
On Tue, 18 May 2010 23:11:42 +0200, Daniel Vetter daniel.vet...@ffwll.ch wrote: Hi all, This patch series implements the fair-lru eviction Chris Wilson already posted with a twist. It's essentially the same idea algorithm. Differnences versus his patch: - Doesn't do any allocations while

Re: [Intel-gfx] 945gm: xrandr crashes X

2010-05-25 Thread Chris Wilson
a new bug on fd.o bugzilla? commit 9f54107f866a25cf670f81f7c52b8c108728c6a5 Author: Chris Wilson ch...@chris-wilson.co.uk Date: Tue May 11 14:55:16 2010 +0100 dri2: Handle reference counting across page flipping 1. Instead of swapping bos, swap the entire private structure. 2. If we

[Intel-gfx] [PATCH] drm/i915: Return the error code from init_hws()

2010-05-26 Thread Chris Wilson
Otherwise we indicate success in the event of failure and this will lead to an eventual OOPS. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/i915_gem.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b

[Intel-gfx] A compendium of trivial patches.

2010-05-27 Thread Chris Wilson
Hi Eric, just a few outstanding trivial patches for you to read on your commute. :) -ickle ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 01/11] drm/i915: Only print an message if there was an error

2010-05-27 Thread Chris Wilson
Only report an error if the GPU has actually detected one, otherwise we are just hung. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/i915_irq.c | 38 -- 1 files changed, 24 insertions(+), 14 deletions(-) diff --git a/drivers

[Intel-gfx] [PATCH 02/11] drm/i915: Hold the spinlock whilst resetting unpin_work along error path

2010-05-27 Thread Chris Wilson
Delay taking the mutex until we need to and ensure that we hold the spinlock when resetting unpin_work on the error path. Also defer the debugging print messages until after we have released the spinlock. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Jesse Barnes jbar

[Intel-gfx] [PATCH 03/11] drm/i915: Avoid nesting of domain changes when setting display plane

2010-05-27 Thread Chris Wilson
Nesting domain changes will cause confusion when trying to interpret the tracepoints describing the sequence of changes for the object, as well as obscuring the order of operations for the reader of the code. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915

[Intel-gfx] [PATCH 04/11] drm/i915: Propagate error from unbinding an unfenceable object.

2010-05-27 Thread Chris Wilson
Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/i915_gem.c | 10 +++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 1c65f0b

[Intel-gfx] [PATCH 05/11] drm/i915: Only print nothing to do debug message as required.

2010-05-27 Thread Chris Wilson
If the FBC is already disabled, then we do not even attempt to disable FBC and so there is no point emitting a debug statement at that point, having already emitted one saying why we are disabling FBC. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/intel_display.c

[Intel-gfx] [PATCH 07/11] drm/i915: Rebind bo if currently bound with incorrect alignment.

2010-05-27 Thread Chris Wilson
/show_bug.cgi?id=27070 Bug 15502 - render error detected, EIR: 0x0010 https://bugzilla.kernel.org/show_bug.cgi?id=15502 Bug 13844 - i915 error: render error detected https://bugzilla.kernel.org/show_bug.cgi?id=13844 Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: sta

[Intel-gfx] [PATCH 09/11] drm/i915: Check error code whilst moving buffer to GTT domain.

2010-05-27 Thread Chris Wilson
Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/intel_fb.c |6 +- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_fb.c b/drivers/gpu/drm/i915/intel_fb.c index 6f53cf7..f8c76e6 100644 --- a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 10/11] drm/i915: Reject bind_to_gtt() early if object aperture

2010-05-27 Thread Chris Wilson
If the object is bigger than the entire aperture, reject it early before evicting everything in a vain attempt to find space. v2: Use E2BIG as suggested by Owain G. Ainsworth. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: sta...@kernel.org --- drivers/gpu/drm/i915/i915_gem.c |8

[Intel-gfx] [PATCH 11/11] drm/i915: Cleanup after failed initialization of ringbuffers

2010-05-27 Thread Chris Wilson
The callers expect us to cleanup any partially initialised structures before reporting the error. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/i915_gem.c | 19 ++- 1 files changed, 18 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm

[Intel-gfx] [PATCH 2/2] drm/i915: Fix up address spaces in slow_kernel_write()

2010-05-27 Thread Chris Wilson
Since we now get_user_pages() outside of the mutex prior to performing the copy, we kmap() the page inside the copy routine and so need to perform an ordinary memcpy() and not copy_from_user(). Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/i915_gem.c | 42

[Intel-gfx] [PATCH] drm/i915: Avoid moving from CPU domain during pwrite

2010-05-27 Thread Chris Wilson
to the execution when profiling. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/i915_gem.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 528ff7d..c10bf39 100644

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Fix up address spaces in slow_kernel_write()

2010-05-28 Thread Chris Wilson
On Fri, 28 May 2010 11:28:50 +0200, Daniel Vetter dan...@ffwll.ch wrote: On Thu, May 27, 2010 at 02:15:35PM +0100, Chris Wilson wrote: Since we now get_user_pages() outside of the mutex prior to performing the copy, we kmap() the page inside the copy routine and so need to perform

[Intel-gfx] [PATCH] drm/i915: Include instdone[1] in hangcheck

2010-06-06 Thread Chris Wilson
References: Bug 26691 - Spurious hangcheck whilst executing a long shader over a large vertex buffer https://bugs.freedesktop.org/show_bug.cgi?id=26691 Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/i915_drv.h |2 ++ drivers/gpu/drm/i915

[Intel-gfx] [PATCH] drm/i915: Remove the WARN when failing to set tiling.

2010-06-06 Thread Chris Wilson
We generally issue an error message at the point of failure, and so this warning with a fairly pointless stacktrace is superfluous and ugly. Needless to say, the common trigger for this WARN happens to be EIO where this is pure noise. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk

[Intel-gfx] [PATCH 6/7] drm/i915: Sparse warning about invalid value for burst_ena in tv_modes

2010-06-06 Thread Chris Wilson
drivers/gpu/drm/i915/intel_tv.c|479 col 16| warning: cast truncates bits from constant value (8 becomes 0) Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/intel_tv.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 7/7] drm/i915: Return boolean status not error code from intel_crtc_mode_fixup()

2010-06-06 Thread Chris Wilson
drivers/gpu/drm/i915/intel_display.c|2357 col 11| warning: cast truncates bits from constant value (f becomes 1) but the correct error code is 0. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/intel_display.c |2 +- 1 files changed, 1 insertions(+), 1

[Intel-gfx] [PATCH 1/7] drm/i915: Silence sparse complaints over insufficient bitfield int types.

2010-06-06 Thread Chris Wilson
drivers/gpu/drm/i915/i915_drv.h|676 col 19| warning: dubious bitfield without explicit `signed' or `unsigned' drivers/gpu/drm/i915/i915_drv.h|712 col 19| warning: dubious bitfield without explicit `signed' or `unsigned' Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm

[Intel-gfx] [PATCH 1/3] drm/i915: Propagate error from drm_install_irq() during EnterVT

2010-06-07 Thread Chris Wilson
Simple fix for error propagation along the old UMS path. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/i915_gem.c | 12 +++- 1 files changed, 11 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c

[Intel-gfx] [PATCH 2/3] drm/i915: Propagate error from drm_vblank_get() during page-flipping.

2010-06-07 Thread Chris Wilson
Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/intel_display.c | 35 - 1 files changed, 21 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index bee7512

[Intel-gfx] [PATCH 3/3] drm/i915: Propagate error from i915_gem_object_flush_gpu_write_domain()

2010-06-07 Thread Chris Wilson
Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/i915_drv.h |2 +- drivers/gpu/drm/i915/i915_gem.c | 43 - drivers/gpu/drm/i915/intel_display.c |4 ++- 3 files changed, 35 insertions(+), 14 deletions(-) diff --git

Re: [Intel-gfx] [PATCH] intel: Stop using sized buckets for the BO cache.

2010-06-07 Thread Chris Wilson
poppler 8865.63 (8889.82 0.52%) - 10942.57 (10972.90 0.47%): 1.23x slowdown Even with -fno-omit-frame-pointer, perf is not providing usuable insights into the difference on the 64bit g45 system. -ickle -- Chris Wilson, Intel Open Source Technology Centre

Re: [Intel-gfx] [PATCH] Allocate a correctly sized framebuffer when tiling by using libdrm support.

2010-06-07 Thread Chris Wilson
= tiled_pitch * height instead of size = tiled_pitch * tile_aligned_height. Hmm, something is fishy after applying the patch. The framebuffer pitch for the 1920x1080 external display looks to be off by 2. -ickle -- Chris Wilson, Intel Open Source Technology Centre

Re: [Intel-gfx] [PATCH] Allocate a correctly sized framebuffer when tiling by using libdrm support.

2010-06-07 Thread Chris Wilson
); - drm_intel_bo_unreference(front_buffer); return NULL; } -- Chris Wilson, Intel Open Source Technology Centre ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel

[Intel-gfx] [PATCH] drm/i915: Explosion following OOM in do_execbuffer.

2010-06-09 Thread Chris Wilson
50 89 45 bc 8b 45 a0 8b 52 38 89 55 d0 31 d2 f6 40 20 01 74 0d 8b 55 bc f6 42 69 30 0f 95 c2 0f b6 d2 8b 45 d0 c7 45 d4 00 00 00 00 89 EIP: [c11a4a02] i915_gem_do_execbuffer+0x71f/0xbb6 SS:ESP 0068:f6508dd4 CR2: 0069 ---[ end trace 3f1d514b34d39381 ]--- Signed-off-by: Chris Wilson ch

Re: [Intel-gfx] [PATCH 1/7 resend] drm/i915: Add the support of eDP on DP-D for Ibex/CPT

2010-06-12 Thread Chris Wilson
; intel_reduce_ratio(m_n-gmch_m, m_n-gmch_n); m_n-link_m = pixel_clock; This rounds the gmch_m down. Is this correct? And how close to overflow is pixel_clock today? -ickle -- Chris Wilson, Intel Open Source Technology Centre ___ Intel-gfx

Re: [Intel-gfx] [PATCH] fix some intel_ring_begin size

2010-06-12 Thread Chris Wilson
to remember to convert it into bytes... -ickle -- Chris Wilson, Intel Open Source Technology Centre ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] convert intel_ring_begin count to dword

2010-06-12 Thread Chris Wilson
@@ void intel_fill_struct(struct drm_device *dev, { unsigned int *virt = ring-virtual_start + ring-tail; BUG_ON((len~(4-1)) != 0); - intel_ring_begin(dev, ring, len); + intel_ring_begin(dev, ring, len/4); Admittedly this is the fly in the ointment. -ickle -- Chris Wilson

Re: [Intel-gfx] [ANNOUNCE] xf86-video-intel 2.11.901

2010-06-15 Thread Chris Wilson
and if there remains any? Now to understand why. Thanks, -ickle -- Chris Wilson, Intel Open Source Technology Centre ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [ANNOUNCE] xf86-video-intel 2.11.901

2010-06-16 Thread Chris Wilson
-- Chris Wilson, Intel Open Source Technology Centre ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] CUDA port for intel graphics

2010-06-23 Thread Chris Wilson
you to do so. Hope this helps, and you have a lot of fun programming with the GPU directly. -- Chris Wilson, Intel Open Source Technology Centre ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo

Re: [Intel-gfx] Intel 2010Q2 release

2010-06-27 Thread Chris Wilson
is stable again. Can you please file a bug as detailed above? Getting the i915_error_state and Xorg.log would be most useful. Are you using XRender or OpenGL desktop effects? Thanks. -- Chris Wilson, Intel Open Source Technology Centre ___ Intel-gfx mailing

Re: [Intel-gfx] Intel 2010Q2 release

2010-06-27 Thread Chris Wilson
726210f87d558d558022f35bc8c839e798a19f0c Author: Chris Wilson ch...@chris-wilson.co.uk Date: Thu Jun 24 11:38:00 2010 +0100 intel: Limit tiled pitches to 8192 on pre-i965. Fixes: Bug 28515 - Failed to allocate framebuffer when exceed 2048 width https

Re: [Intel-gfx] [PATCH] drm/i915: Selectively enable self-reclaim

2010-06-30 Thread Chris Wilson
where we are trying to do a large allocation and our shrinker would be prevented from running (due to contention on struct_mutex). I do not know how this causes memory corruption across hibernate and would appreciate any insights. -- Chris Wilson, Intel Open Source Technology Centre

Re: [Intel-gfx] [PATCH] drm/i915: Selectively enable self-reclaim

2010-07-01 Thread Chris Wilson
broke with the introduction of GEM. * turns to his trusty copy of LDD to explain the various meanings of gfp_t... -- Chris Wilson, Intel Open Source Technology Centre ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org

Re: [Intel-gfx] System freeze with 2.12 + 2.6.34

2010-07-01 Thread Chris Wilson
high resolution flash videos. Any idea what the problem could be? All depends upon the system. Jesse is working on a couple of patches that address the change in handling of the vblank interrupt in some revisions of the i945/i965 chipsets. That's the known failure mode... -- Chris Wilson, Intel

[Intel-gfx] [PATCH 1/2] [RFC] drm/i915: Restore LRU evict order, with a twist!

2010-07-01 Thread Chris Wilson
HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS + * IN THE SOFTWARE. + * + * Authors: + *Eric Anholt e...@anholt.net + *Chris Wilson

[Intel-gfx] [PATCH 2/2] drm/i915: Maintain LRU order of inactive objects upon access by CPU

2010-07-01 Thread Chris Wilson
the CPU objects from casual eviction, preferring to keep the GPU active for as long as possible. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/i915_gem.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b

Re: [Intel-gfx] [PATCH 1/2] [RFC] drm/i915: Restore LRU evict order, with a twist!

2010-07-01 Thread Chris Wilson
On Thu, 01 Jul 2010 12:49:33 -0700, Eric Anholt e...@anholt.net wrote: On Thu, 1 Jul 2010 17:53:44 +0100, Chris Wilson ch...@chris-wilson.co.uk wrote: +static int +i915_gem_eviction_roster_add(struct i915_gem_eviction_roster *roster, +struct drm_i915_gem_object

[Intel-gfx] [PATCH] drm/i915: Explosion following OOM in do_execbuffer.

2010-07-02 Thread Chris Wilson
50 89 45 bc 8b 45 a0 8b 52 38 89 55 d0 31 d2 f6 40 20 01 74 0d 8b 55 bc f6 42 69 30 0f 95 c2 0f b6 d2 8b 45 d0 c7 45 d4 00 00 00 00 89 EIP: [c11a4a02] i915_gem_do_execbuffer+0x71f/0xbb6 SS:ESP 0068:f6508dd4 CR2: 0069 ---[ end trace 3f1d514b34d39381 ]--- Signed-off-by: Chris Wilson ch

Re: [Intel-gfx] [PATCH] Destroy screen pixmap on screen close.

2010-07-02 Thread Chris Wilson
it not be fbCloseScreen that calls miCloseScreen, since fb has taken over the management of the mi interface? -- Chris Wilson, Intel Open Source Technology Centre ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org

[Intel-gfx] Fair eviction for i915, based on Daniel's drm_mm scanner

2010-07-02 Thread Chris Wilson
This is a resend of Daniel Vetter's drm mm work to provide a basis for performing fair eviction in i915. I've taken the liberty of attaching the acks and review comments from the previous round, so please look over and check that they still hold true. drivers/gpu/drm/drm_mm.c|

[Intel-gfx] [PATCH 01/11] drm: use list_for_each_entry in drm_mm.c

2010-07-02 Thread Chris Wilson
From: Daniel Vetter daniel.vet...@ffwll.ch Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Acked-by: Thomas Hellstrom thellst...@vmwgfx.com --- drivers/gpu/drm/drm_mm.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions

[Intel-gfx] [PATCH 02/11] drm: kill drm_mm_node-private

2010-07-02 Thread Chris Wilson
From: Daniel Vetter daniel.vet...@ffwll.ch Only ever assigned, never used. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch [glisse: I will re-add if needed for range-restricted allocations] Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/i915_gem.c |4

[Intel-gfx] [PATCH 03/11] drm: kill dead code in drm_mm.c

2010-07-02 Thread Chris Wilson
From: Daniel Vetter daniel.vet...@ffwll.ch Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch Acked-by: Thomas Hellstrom thellst...@vmwgfx.com Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/drm_mm.c | 45 - 1 files changed

[Intel-gfx] [PATCH 04/11] drm: sane naming for drm_mm.c

2010-07-02 Thread Chris Wilson
From: Daniel Vetter daniel.vet...@ffwll.ch Yeah, I've kinda noticed that fl_entry is the free stack. Still give it (and the memory node list ml_entry) decent names. Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch Acked-by: Thomas Hellstrom thellst...@vmwgfx.com Signed-off-by: Chris Wilson ch

[Intel-gfx] [PATCH 07/11] drm/i915: prepare for fair lru eviction

2010-07-02 Thread Chris Wilson
From: Daniel Vetter daniel.vet...@ffwll.ch This does two little changes: - Add an alignment parameter for evict_something. It's not really great to whack a carefully sized hole into the gtt with the wrong alignment. Especially since the fallback path is a full evict. - With the inactive

[Intel-gfx] [PATCH 08/11] drm/i915: Use a common seqno for all rings.

2010-07-02 Thread Chris Wilson
This will be used by the eviction logic to maintain fairness between the rings. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/i915_drv.h |3 +- drivers/gpu/drm/i915/i915_gem.c |2 + drivers/gpu/drm/i915/intel_ringbuffer.c | 46

[Intel-gfx] [PATCH 09/11] drm/i915: Move the eviction logic to its own file.

2010-07-02 Thread Chris Wilson
The eviction code is the gnarly underbelly of memory management, and is clearer if kept separated from the normal domain management in GEM. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/Makefile |1 + drivers/gpu/drm/i915/i915_drv.h |6

[Intel-gfx] [PATCH 11/11] drm/i915: Maintain LRU order of inactive objects upon access by CPU

2010-07-02 Thread Chris Wilson
the CPU objects from casual eviction, preferring to keep the GPU active for as long as possible. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/i915_gem.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b

Re: [Intel-gfx] [PATCH] Destroy screen pixmap on screen close.

2010-07-02 Thread Chris Wilson
On Fri, 02 Jul 2010 11:54:44 -0400, Keith Packard kei...@keithp.com wrote: On Fri, 02 Jul 2010 09:24:07 +0100, Chris Wilson ch...@chris-wilson.co.uk wrote: This looks like the responsibility of miCloseScreen(). Are we failing to chain up properly? I don't think miCloseScreen

[Intel-gfx] [PATCH] drm/i915: Use 128k alignment for untiled display surface on i965

2010-07-05 Thread Chris Wilson
the impact of this should be slight as on i965 we should be using a tiled frontbuffer for anything up to a 4096x4096 display. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/i915_drv.c |4 ++-- drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH] drm/i915: Use 128k alignment for untiled display surface on i965

2010-07-05 Thread Chris Wilson
On Mon, 05 Jul 2010 09:22:30 -0700, Eric Anholt e...@anholt.net wrote: On Mon, 5 Jul 2010 10:25:57 +0100, Chris Wilson ch...@chris-wilson.co.uk wrote: The original i965 requires an alignment of 128K for the display surface with linear memory, so increase the requirement from 64k

[Intel-gfx] [PATCH 1/2] drm/i915: Use 128k alignment for untiled display surface on i965 (v2)

2010-07-05 Thread Chris Wilson
performing asynchronous flips.) Note the impact of this should be slight as on i965 we should be using a tiled frontbuffer for anything up to a 4096x4096 display. v2: compilation fixes and note that the docs do not exclude the G35 from the extra alignment. Signed-off-by: Chris Wilson ch...@chris

[Intel-gfx] [PATCH 2/2] drm/i915: Include any alternate names by which the device is known.

2010-07-05 Thread Chris Wilson
When trying to keep track of features between the kernel, the 2D driver, mesa and the specs, it helps to list any other name by which the device is referred to. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/i915_drv.c | 52

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Include any alternate names by which the device is known.

2010-07-05 Thread Chris Wilson
On Mon, 5 Jul 2010 18:01:47 +0100, Chris Wilson ch...@chris-wilson.co.uk wrote: When trying to keep track of features between the kernel, the 2D driver, mesa and the specs, it helps to list any other name by which the device is referred to. In adding this list it became apparent that the 2D

[Intel-gfx] [PATCH] drm/i915: Unset cursor if out-of-bounds upon mode change (v3)

2010-07-08 Thread Chris Wilson
registers if they change. v3: Fix the unsigned comparision of x,y against width,height. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Reported-by: Christian Eggers cegg...@gmx.de Cc: Christopher James Halse Rogers chalserog...@gmail.com Tested-by: Christopher James Halse Rogers chalserog

[Intel-gfx] [PATCH] drm/i915: Unset mmap_offset on failure path.

2010-07-10 Thread Chris Wilson
If we fail to correctly setup the mapping for an object, make sure that we nullify the pointer within the object after tearing down. Otherwise, we may later attempt to reuse the invalid pointer... Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: sta...@kernel.org --- drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH] drm/i915: Unset mmap_offset on failure path.

2010-07-10 Thread Chris Wilson
On Sat, 10 Jul 2010 08:58:55 +0100, Chris Wilson ch...@chris-wilson.co.uk wrote: If we fail to correctly setup the mapping for an object, make sure that we nullify the pointer within the object after tearing down. Otherwise, we may later attempt to reuse the invalid pointer... False alarm

[Intel-gfx] [PATCH] drm/i915: Check overlay stride errata for i830 and i845

2010-07-12 Thread Chris Wilson
Apparently i830 and i845 cannot handle any stride that is not a multiple of 256, unlike their brethren which do support 64 byte aligned strides. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: sta...@kernel.org --- drivers/gpu/drm/i915/intel_overlay.c |7 +-- 1 files changed, 5

[Intel-gfx] [PATCH] drm/i915: Typo in (unused) register mask for overlay.

2010-07-13 Thread Chris Wilson
Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/intel_overlay.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_overlay.c b/drivers/gpu/drm/i915/intel_overlay.c index 88a9ee8..5ba3b48 100644 --- a/drivers/gpu/drm

[Intel-gfx] [PATCH] drm/i915: Fix panel fitting regression since 734b4157

2010-07-17 Thread Chris Wilson
-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_display.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 68dcf36..77e1c75

[Intel-gfx] [PATCH 1/2] drm/i915: Remove the redundant check for a fixed_panel_mode

2010-07-17 Thread Chris Wilson
We already checked just a couple of lines above that we have found a fixed_panel_mode for the LVDS, so remove the surplus check. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/intel_lvds.c | 32 +++- 1 files changed, 15 insertions

[Intel-gfx] [PATCH 2/2] drm/i915: Refactor panel fitting on the LVDS.

2010-07-17 Thread Chris Wilson
insertions(+), 194 deletions(-) Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Jesse Barnes jbar...@virtuousgeek.org --- drivers/gpu/drm/i915/intel_lvds.c | 322 +++-- 1 files changed, 128 insertions(+), 194 deletions(-) diff --git a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 1/2] drm: Return EBUSY if the framebuffer is unbound when flipping.

2010-07-17 Thread Chris Wilson
] intel_crtc_page_flip+0xc9/0x39c [i915] RSP 880114927cc8 CR2: 0058 References: Bug 28811 - [page-flipping] GPU hang when modeset after unplugging another monitor (under compiz) https://bugs.freedesktop.org/show_bug.cgi?id=28811 Signed-off-by: Chris Wilson ch...@chris

[Intel-gfx] [PATCH 2/2] drm/i915: Remove extraneous variables from intel_crtc_page_flip()

2010-07-17 Thread Chris Wilson
Reduce the number of variables used and improve readability by scoping. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/intel_display.c | 31 +++ 1 files changed, 15 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Refactor panel fitting on the LVDS.

2010-07-18 Thread Chris Wilson
divisible by 2 in ganged mode, etc). If you're feeling adventurous anyway. :) Sounds like a useful task, both for verification of the code and for forcing me to read the documentation closely ;-) /me adds to his todo list. -- Chris Wilson, Intel Open Source Technology Centre

Re: [Intel-gfx] KMS broken from 2.6.33 up to 2.6.35-rc5????

2010-07-18 Thread Chris Wilson
initialize the framebuffer. Excellent, as you have managed to reproduce this with a minimal kernel, can you do a bisect between 2.6.33.16 and 2.6.33.6 and see which patch causes the regression? It should only take a couple of hours. My bet is one of the Arrandale enabling patches... -- Chris Wilson

[Intel-gfx] [PATCH 1/4] drm/i915: Add fixed panel mode parsed from EDID for eDP without fixed mode in VBT

2010-07-19 Thread Chris Wilson
From: Zhao Yakui yakui.z...@intel.com Signed-off-by: Zhao Yakui yakui.z...@intel.com Reviewed-by: Chris Wilson ch...@chris-wilson.co.uk Cc: sta...@kernel.org --- drivers/gpu/drm/i915/intel_dp.c | 16 +++- 1 files changed, 15 insertions(+), 1 deletions(-) diff --git a/drivers/gpu

[Intel-gfx] [PATCH 3/7] drm/i915/sdvo: Propagate errors from reading/writing control bus.

2010-07-19 Thread Chris Wilson
Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/intel_sdvo.c | 930 +--- drivers/gpu/drm/i915/intel_sdvo_regs.h |2 +- 2 files changed, 380 insertions(+), 552 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b

[Intel-gfx] [PATCH 4/7] drm/i915/sdvo: Use an integer mapping for supported tv format modes

2010-07-19 Thread Chris Wilson
Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/intel_sdvo.c | 34 +++--- 1 files changed, 11 insertions(+), 23 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c index ba50755..a30d751

[Intel-gfx] [PATCH 5/7] drm/i915/sdvo: Check for allocation failure when constructing properties

2010-07-19 Thread Chris Wilson
Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/intel_sdvo.c | 40 +++- 1 files changed, 38 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c index a30d751..d5f1b27

[Intel-gfx] [PATCH 6/7] drm/i915/sdvo: Add missing TV filters

2010-07-19 Thread Chris Wilson
Reference: Bug 28634 - missing TV parameter Flicker Filter https://bugs.freedesktop.org/show_bug.cgi?id=28634 Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/intel_sdvo.c | 644 ++-- drivers/gpu/drm/i915/intel_sdvo_regs.h

[Intel-gfx] [PATCH 7/7] drm/i915/sdvo: Add dot crawl property

2010-07-19 Thread Chris Wilson
This property is slightly unusual in that it is a boolean and so has no GET_MAX command. Reference: Bug 28636 - missing TV parameter Dot Crawl freeze https://bugs.freedesktop.org/show_bug.cgi?id=28636 Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915

[Intel-gfx] [PATCH] drm/i915: Enable aspect/centering panel fitting for Ironlake.

2010-07-21 Thread Chris Wilson
Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/i915_drv.h |2 + drivers/gpu/drm/i915/intel_display.c | 16 +++ drivers/gpu/drm/i915/intel_lvds.c| 70 -- 3 files changed, 75 insertions(+), 13 deletions(-) diff

Re: [Intel-gfx] Fwd: State of 10 bits/channel?

2010-07-23 Thread Chris Wilson
, but there's no direct rendering (seems to be disabled because DRI is disabled because it runs only at depths 16 and 24) title bars on gnome-terminal draw incorrectly. Hmm, the render paths should work on 10bpc surfaces. Please do file bugs for the failures. -- Chris Wilson, Intel Open Source Technology

[Intel-gfx] [PATCH] drm/i915: Repeat unbinding during free if interrupted

2010-07-23 Thread Chris Wilson
upon the various lists exposing us to memory corruption. I think this is the cause behind the use-after-free, such as Bug 15664 - Graphics hang and kernel backtrace when starting Azureus with Compiz enabled https://bugzilla.kernel.org/show_bug.cgi?id=15664 Signed-off-by: Chris

[Intel-gfx] [PATCH] drm/i915: Repeat unbinding during free if interrupted (v2)

2010-07-23 Thread Chris Wilson
reminded me that kernel space programming is never easy. We cannot simply spin to clear the pending signal and so must deferred the freeing of the object until later. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: sta...@kernel.org --- drivers/gpu/drm/i915/i915_drv.h |8

[Intel-gfx] [PATCH] drm/i915: Repeat unbinding during free if interrupted (v3)

2010-07-23 Thread Chris Wilson
reminded me that kernel space programming is never easy. We cannot simply spin to clear the pending signal and so must deferred the freeing of the object until later. v3: Run from the top level retire requests. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: sta...@kernel.org --- drivers

[Intel-gfx] [PATCH] drm/i915: Repeat unbinding during free if interrupted (v4)

2010-07-23 Thread Chris Wilson
-by: Chris Wilson ch...@chris-wilson.co.uk Cc: sta...@kernel.org Reviewed-by: Daniel Vetter dan...@ffwll.ch --- drivers/gpu/drm/i915/i915_drv.h |8 + drivers/gpu/drm/i915/i915_gem.c | 57 -- 2 files changed, 50 insertions(+), 15 deletions(-) diff --git

[Intel-gfx] [PATCH] drm/i915: Repeat unbinding during free if interrupted (v5)

2010-07-23 Thread Chris Wilson
against Eric's for-linus tree. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: sta...@kernel.org Cc: Daniel Vetter dan...@ffwll.ch --- drivers/gpu/drm/i915/i915_drv.c |2 +- drivers/gpu/drm/i915/i915_drv.h | 11 - drivers/gpu/drm/i915/i915_gem.c | 96

[Intel-gfx] [PATCH 1/3] drm/i915: Refactor i915_gem_retire_requests()

2010-07-23 Thread Chris Wilson
Combine the iteration over active render rings into a common function. This is in preparation for reusing the idle function to also retire deferred free requests. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/i915_drv.c |2 +- drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [PATCH 2/3] drm/i915: Repeat unbinding during free if interrupted (v6)

2010-07-23 Thread Chris Wilson
against Eric's for-linus tree. v6: Refactor, split and add a comment about avoiding unbounded recursion. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Daniel Vetter dan...@ffwll.ch --- drivers/gpu/drm/i915/i915_drv.h |8 ++ drivers/gpu/drm/i915/i915_gem.c | 51

[Intel-gfx] [PATCH 3/3] drm/i915: Attempt to uncouple object after catastrophic failure in unbind

2010-07-23 Thread Chris Wilson
of two evils, since in order to recover from the hung GPU we need to completely reset it, those pending writes should never happen. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/i915_gem.c | 11 ++- 1 files changed, 6 insertions(+), 5 deletions(-) diff

  1   2   3   4   5   6   7   8   9   10   >