Re: [Intel-gfx] [PATCH igt] intel-ci: Add multiple ringfill for execlists

2017-01-31 Thread Petri Latvala
On Tue, Jan 24, 2017 at 01:02:23PM +0200, Petri Latvala wrote: > On Tue, Jan 24, 2017 at 09:31:39AM +, Chris Wilson wrote: > > On Wed, Jan 18, 2017 at 08:54:10PM +, Chris Wilson wrote: > > > Execlists introduces a new wrinkle to filling rings, in that each > > >

Re: [Intel-gfx] [PATCH igt] intel-ci: Minimal exercise of explicit fencing

2017-01-31 Thread Petri Latvala
etting their $favoritefeatureoftheday into BAT, I'm being a little more lenient than I should with allowing more tests into fast-feedback at this time. As soon as we can deploy Ezbench-driven extended testing (not far now btw), fast-feedback will go on a diet. -- Petri Latvala ___

Re: [Intel-gfx] [PATCH igt] intel-ci: Move start of gvt tests last

2017-02-01 Thread Petri Latvala
k> Indeed. Acked-by: Petri Latvala <petri.latv...@intel.com> > --- > tests/intel-ci/fast-feedback.testlist | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tests/intel-ci/fast-feedback.testlist > b/tests/intel-ci/fast-feedback.testlist > ind

[Intel-gfx] [PATCH i-g-t] tests/chamelium: Adapt to dynamic number of planes changes

2017-02-01 Thread Petri Latvala
CC: Robert Foss <robert.f...@collabora.com> CC: Lyude <ly...@redhat.com> Signed-off-by: Petri Latvala <petri.latv...@intel.com> --- tests/chamelium.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/tests/chamelium.c b/tests/chamelium.c index d914d

[Intel-gfx] [PATCH i-g-t] tests/drv_suspend: Skip */crc/* in debugfs-reader

2017-02-06 Thread Petri Latvala
Reading the CRC files in debugfs will never terminate. drv_suspend/debugfs-reader will leave a cat process around which blocks all other access to the device until manually killed if CRC files are not omitted. Signed-off-by: Petri Latvala <petri.latv...@intel.com> --- tests/drv_suspend

[Intel-gfx] [PATCH i-g-t] tests/gem_exec_reloc: Don't call igt_(dis)allow_hang outside fixtures

2017-02-06 Thread Petri Latvala
gem_exec_reloc --list-subtests breaks otherwise. v2: use igt_subtest_group (Chris) CC: Chris Wilson <ch...@chris-wilson.co.uk> Signed-off-by: Petri Latvala <petri.latv...@intel.com> --- tests/gem_exec_reloc.c | 30 ++ 1 file changed, 18 insertions(+),

[Intel-gfx] [PATCH i-g-t] tests/gem_exec_reloc: Call igt_(dis)allow_hang inside subtest block

2017-02-06 Thread Petri Latvala
gem_exec_reloc --list-subtests breaks otherwise. CC: Chris Wilson <ch...@chris-wilson.co.uk> Signed-off-by: Petri Latvala <petri.latv...@intel.com> --- tests/gem_exec_reloc.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/tests/gem_exec_rel

Re: [Intel-gfx] [PATCH i-g-t] tests: Clean up shell scripts

2017-02-03 Thread Petri Latvala
On Mon, Jan 30, 2017 at 01:07:12PM +0200, Joonas Lahtinen wrote: > delete mode 100755 tests/test_rte_check Remove test_rte_check also from tests/Makefile.sources. With that, Reviewed-by: Petri Latvala <petri.latv...@intel.com> ___ Intel-gf

Re: [Intel-gfx] [PATCH igt] intel-ci: Minimal exercise of explicit fencing

2017-02-03 Thread Petri Latvala
On Fri, Jan 27, 2017 at 09:36:23PM +, Chris Wilson wrote: > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> > Cc: Petri Latvala <petri.latv...@intel.com> > --- > tests/intel-ci/fast-feedback.testlist | 5 + > 1 file changed, 5 insertions(+) > >

Re: [Intel-gfx] [PATCH i-g-t v1 04/32] lib/igt_kms: Implement dynamic plane count support

2017-01-24 Thread Petri Latvala
this by moving the removal of the enum until after all of the > tests have had their dependency on the enum fixed. This is how it's done. No deliberately broken commits please. -- Petri Latvala > > Another solution is just to collapse all of the test fixes into this patch. > Whic

Re: [Intel-gfx] [PATCH i-g-t v4] tools: Add intel_dp_compliance for DisplayPort 1.2 compliance automation

2017-01-24 Thread Petri Latvala
Just one more nitpick (in two parts) below. With that, you can consider this now to be Reviewed-by: Petri Latvala <petri.latv...@intel.com> This patch can be pushed when the kernel changes that contain "must be kept in sync" numbers in intel_dp_compliance.c have landed (and

Re: [Intel-gfx] [PATCH igt] intel-ci: Add multiple ringfill for execlists

2017-01-24 Thread Petri Latvala
> filling multiple execlist rings (for the same engine) to BAT. > > > > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> > > Cc: Petri Latvala <petri.latv...@intel.com> > > Ping? This provides coverage of some hairy paths on execlists/guc that > curre

Re: [Intel-gfx] [PATCH i-g-t 2/2] aubdump: support new ioctl

2017-01-30 Thread Petri Latvala
if (device_override) > return 0; libdrm version check in configure.ac needs to be bumped to a version containing that ioctl token. -- Petri Latvala ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH i-g-t] lib/drmtest: make DRIVER_ANY match any driver

2017-01-30 Thread Petri Latvala
NAK. DRIVER_VGEM is omitted from DRIVER_ANY intentionally. Vgem is unable to modeset, unable to render, practically it only supports the vgem-specific tests. See also: lib/drmtest.c, __drm_open_driver(). -- Petri Latvala ___ Intel-gfx mailing list

Re: [Intel-gfx] [PATCH i-g-t] kms_atomic_transition: Initialize pipe_crcs to avoid segfault

2017-02-20 Thread Petri Latvala
cessing garbage pointers on > non-Intel devices. > > Signed-off-by: Brian Starkey <brian.star...@arm.com> Reviewed-by: Petri Latvala <petri.latv...@intel.com> Pushed, thanks. > --- > tests/kms_atomic_transition.c |2 +- > 1 file changed, 1 insert

Re: [Intel-gfx] [PATCH igt] intel-ci: Test wait ioctl on a queued request

2017-02-20 Thread Petri Latvala
On Thu, Feb 09, 2017 at 08:20:58AM +, Chris Wilson wrote: > Another bug found first in the wild... > > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> > Cc: Petri Latvala <petri.latv...@intel.com> Behaviour on farm2 looks alright. Acked-by: Petri Latvala

Re: [Intel-gfx] [PATCH v2] Add the new tool for create GVT-g Linux guest based on KVMGT

2017-02-24 Thread Petri Latvala
uot;h"; > + > +static void print_help(void) > +{ > +igt_info("\n [options]\n" > + "-h, --help display usage\n" > + "-q, --qemu the qemu path\n" > + "-a, --hda the hda raw image / qco

[Intel-gfx] IGT, CI and more testing

2017-02-09 Thread Petri Latvala
lly for the test list that has been used in the proof-of-concept setup (attached). The list runs in a hair under three hours on SNB at this time, and has been collected with the sophisticated method of "take everything, then throw bathwater out, ignore babies". Naturally the list is not s

Re: [Intel-gfx] [PATCH i-g-t v2] gitignore: Add files starting with .

2017-02-16 Thread Petri Latvala
On 02/15/2017 08:24 PM, Michel Thierry wrote: I cant be the only one that have added .tags by mistake. v2: Do not ignore .gitignore Cc: Petri Latvala <petri.latv...@intel.com> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Michel Thierry <michel.th

Re: [Intel-gfx] [PATCH i-g-t v3] gitignore: Add files starting with .

2017-02-17 Thread Petri Latvala
On 02/16/2017 09:34 PM, Michel Thierry wrote: I cant be the only one that have added .tags by mistake. v2: Do not ignore .gitignore v3: Move !.gitignore at the end, otherwise it'll ignore new .gitignore files in another directory (Petri) Cc: Petri Latvala <petri.latv...@intel.com> Cc:

Re: [Intel-gfx] [PATCH igt] intel-ci: Add all driver selftests to BAT

2017-02-17 Thread Petri Latvala
NAK on these with the current drv_selftest code. The subtest enumeration on IGT's side needs to contain these subtests even if the running kernel doesn't have selftests, or these particular subtests. -- Petri Latvala On Thu, Feb 02, 2017 at 09:18:00AM +, Chris Wilson wrote

Re: [Intel-gfx] [PATCH igt 1/2] intel-ci: Do module reload last

2017-01-18 Thread Petri Latvala
On Wed, Jan 18, 2017 at 10:21:47AM +, Chris Wilson wrote: > On Wed, Jan 18, 2017 at 12:14:00PM +0200, Petri Latvala wrote: > > Thanks for the reminder about this ordering change. > > > > The crash from disable_display use will cause $stuff in CI, its > > ab

Re: [Intel-gfx] [PATCH igt 1/2] intel-ci: Do module reload last

2017-01-18 Thread Petri Latvala
Thanks for the reminder about this ordering change. The crash from disable_display use will cause $stuff in CI, its ability to recover and resume is not quite there yet. But as it's at the end, we can live with it until a fix lands. Series is Acked-by: Petri Latvala <petri.latv...@intel.

Re: [Intel-gfx] [PATCH i-g-t v1 0/6] Memory allocation fixes

2017-01-20 Thread Petri Latvala
Patches 1-4 and 6 are Reviewed-by: Petri Latvala <petri.latv...@intel.com> On Thu, Jan 19, 2017 at 11:35:00AM -0500, Robert Foss wrote: > This series contains a few separate fixes mostly for memory allocations > but also some small unrelated small fixes. > > This series

Re: [Intel-gfx] [PATCH v2] Add the new tool for create GVT-g Linux guest based on KVMGT

2017-02-27 Thread Petri Latvala
I was a bit confused there and there are other cases where root rights are required. Assuming root privileges is fine, especially if you're nice and warn the user if proper rights are not active. Can the tool be used as a normal user at all? -- Petri Latvala ___ In

Re: [Intel-gfx] [PATCH v2 1/2] drm/prime: Passing the right owner through to dma_buf_export()

2016-09-30 Thread Petri Latvala
The series is Tested-by: Petri Latvala <petri.latv...@intel.com> On 09/30/2016 02:44 PM, Chris Wilson wrote: dma_buf_export() adds a reference to the owning module to the dmabuf (to prevent the driver from being unloaded whilst a third party still refers to the dmabuf). H

[Intel-gfx] [PATCH i-g-t RFC] tests: Add explicit test lists for CI use.

2016-10-06 Thread Petri Latvala
See tests/intel-ci/README for rationale and explanation. Signed-off-by: Petri Latvala <petri.latv...@intel.com> --- The plans for CI are to use explicit test lists in the future, as laid out in this commit. Comments, acks, nacks, flames, etc would be very welcome. The only list

Re: [Intel-gfx] [PATCH i-g-t 1/2] aubdump: remove already handled -o

2016-10-06 Thread Petri Latvala
On Wed, Oct 05, 2016 at 11:48:26PM +0100, Lionel Landwerlin wrote: > - -o*) > - file=${1##-o} > - shift > - ;; This breaks using -ofilename without spaces. -- Petri Latvala ___ Intel-gfx mailing li

Re: [Intel-gfx] [PATCH v2 i-g-t 2/2] aubdump: add --command option to stream aubdump to another program

2016-10-06 Thread Petri Latvala
s a nonrepresentable character present. > > while true; do >case "$1" in > @@ -38,6 +54,14 @@ while true; do > file=${1##--output=} > shift > ;; > + -c) > + build_command &

[Intel-gfx] [PATCH i-g-t v2] tests: Add explicit test lists for CI use.

2016-10-06 Thread Petri Latvala
See tests/intel-ci/README for rationale and explanation. v2: Use the current BAT set for fast-feedback.testlist first Signed-off-by: Petri Latvala <petri.latv...@intel.com> --- Thanks for the feedback. This commit only contains the current test set, extended test suites are left for

Re: [Intel-gfx] [PATCH v4 1/3] drm/prime: Pass the right module owner through to dma_buf_export()

2016-10-05 Thread Petri Latvala
For the series: Reviewed-by: Petri Latvala <petri.latv...@intel.com> On 10/05/2016 03:21 PM, Chris Wilson wrote: dma_buf_export() adds a reference to the owning module to the dmabuf (to prevent the driver from being unloaded whilst a third party still refers to the dmabuf). H

[Intel-gfx] [PATCH i-g-t] lib: Do two writes to /proc/sys/vm/drop_caches again

2016-09-27 Thread Petri Latvala
The drop_caches sysctl has a max value of 4, so writing 7 to it just fails. Avoid the earlier two-writes problem by opening the fd twice. v2: Don't lseek(), open() twice. (Chris) Signed-off-by: Petri Latvala <petri.latv...@intel.com> --- lib/intel_os.c | 13 +++-- 1 file chang

[Intel-gfx] [PATCH i-g-t] Update MAINTAINERS file

2016-10-03 Thread Petri Latvala
Add myself, remove Daniel by request. Signed-off-by: Petri Latvala <petri.latv...@intel.com> --- For the record. Daniel requested to be removed from the list (Daniel, please confirm, that's how I understood), and I'm going to be maintaining IGT with Marius until Marius steps down. MAINT

[Intel-gfx] [PATCH i-g-t] lib: Do two writes to /proc/sys/vm/drop_caches again

2016-09-27 Thread Petri Latvala
The drop_caches sysctl has a max value of 4, so writing 7 to it just fails. Avoid the earlier two-writes problem by seeking to the beginning between writes. Signed-off-by: Petri Latvala <petri.latv...@intel.com> --- lib/intel_os.c | 9 +++-- 1 file changed, 7 insertions(+), 2 del

Re: [Intel-gfx] [PATCH v4] tools/intel_guc_logger: Utility for capturing GuC firmware logs in a file

2016-10-27 Thread Petri Latvala
This patch is now pushed, thanks. -- Petri Latvala On Wed, Oct 12, 2016 at 02:32:17PM +0100, Tvrtko Ursulin wrote: > > On 10/10/2016 15:31, Goel, Akash wrote: > > > > > > On 10/10/2016 7:22 PM, Tvrtko Ursulin wrote: > > > > > > On 10/10/2016 11:59

Re: [Intel-gfx] [PATCH igt] igt: drop gem_storedw_loop from BAT

2016-10-27 Thread Petri Latvala
On Tue, Oct 25, 2016 at 01:07:25PM +0300, Petri Latvala wrote: > Am I understanding correctly that gem folks don't object to > gem_storedw_loop being removed from BAT? Interpreting silence as a yes. Acked-by: Petri Latvala <petri.latv...@intel.com> Please push this. -- P

Re: [Intel-gfx] [PATCH igt] igt/gem_exec_reloc: Check we write the full 64bit relocation

2016-11-08 Thread Petri Latvala
pov. Oh well. Don't do that. -- Petri Latvala ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH igt] igt/kms_frontbuffer_tracking: Drop unsynchronized pageflip test

2016-11-10 Thread Petri Latvala
;params->fb.fb->fb_id, >DRM_MODE_PAGE_FLIP_EVENT, NULL); > igt_assert_eq(rc, 0); This makes FLIP_PAGEFLIP pass DRM_MODE_PAGE_FLIP_EVENT. Is that intentional? -- Petri Latvala ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH igt] igt/kms_frontbuffer_tracking: Drop unsynchronized pageflip test

2016-11-10 Thread Petri Latvala
On Thu, Nov 10, 2016 at 10:43:27AM +, Chris Wilson wrote: > On Thu, Nov 10, 2016 at 12:20:51PM +0200, Petri Latvala wrote: > > On Thu, Nov 10, 2016 at 08:05:19AM +, Chris Wilson wrote: > > > A raw pageflip is nonblocking and asynchronous, but > > > kms_fr

Re: [Intel-gfx] [PATCH] intel-ci: Add gem_exec_suspend/basic-S3/S4-devices to BAT

2016-10-18 Thread Petri Latvala
73 igt@kms_flip@basic-plain-flip 10.33 igt@gem_sync@basic-store-each 10.29 igt@gem_sync@basic-store-all 10.11 igt@gem_sync@basic-each 10.08 igt@gem_sync@basic-all Does any of these strike as a low-hanging fruit? -- Petri Latvala ___ Intel-gfx mailing

[Intel-gfx] [PATCH i-g-t] tests/vgem_basic: Retry the initial module unload in unload test

2016-10-18 Thread Petri Latvala
If executed too soon after prime_vgem tests, the vgem unload test fails due to its execbuffers still being handled in the kernel. Retry the unload three times with sleeps before reporting a skip. When tested on HSW, one 1s sleep wasn't enough, 3s was. Signed-off-by: Petri Latvala <petri.l

Re: [Intel-gfx] [PATCH igt] igt: drop gem_storedw_loop from BAT

2016-10-20 Thread Petri Latvala
dundant, should it be removed altogether? -- Petri Latvala > > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> > --- > tests/gem_storedw_loop.c | 6 +++--- > tests/intel-ci/fast-feedback.testlist | 7 --- > 2 files changed, 3 insertions(+), 10 de

Re: [Intel-gfx] [i-g-t PATCH 1/3] tests: add more checks for finding the debugfs in script based tests

2016-10-14 Thread Petri Latvala
e > + skip "debugfs not found" > fi Would parsing the output of `mount -t debugfs` be an option? -- Petri Latvala > > -if [ -d /sys/kernel/debug/dri ] ; then > - debugfs_path=/sys/kernel/debug/dri > +if [ ! -d $debugfs_path/dri ]; then > + skip &qu

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Allocate intel_engine_cs structure only for the enabled engines (rev3)

2016-10-14 Thread Petri Latvala
and sleeping. We can also order vgem unload test to be first (along with drv_module_reload) depending on whether we want to catch those stray module leaks. Comments on that tradeoff? Comments in the test list: Not yet. Piglit patch for them just sent to piglit mailing list. Petri Latvala

[Intel-gfx] [PATCH i-g-t] intel-ci: Reorder tests to have vgem-basic@unload tested first

2016-10-17 Thread Petri Latvala
Signed-off-by: Petri Latvala <petri.latv...@intel.com> CC: Chris Wilson <ch...@chris-wilson.co.uk> --- (Possible duplicate, I didn't see this arrive on the mailing list myself) To match Chris's intention. The test itself will receive fixes later, and another module loading test w

Re: [Intel-gfx] [PATCH i-g-t] tests/vgem_basic: Retry the initial module unload in unload test

2016-10-18 Thread Petri Latvala
l references to the vgem.ko's object (via dma-buf) will only > exist if they were constructed by the test and if they were, e.g. i915, > they too should be will be flushed by igt in its exithandlers. > > Other drivers may have similar bridges to cross ofc. > -Chris Ok, ex

Re: [Intel-gfx] [PATCH i-g-t] tests/vgem_basic: Retry the initial module unload in unload test

2016-10-18 Thread Petri Latvala
On 10/18/2016 02:36 PM, Chris Wilson wrote: On Tue, Oct 18, 2016 at 02:25:21PM +0300, Petri Latvala wrote: If executed too soon after prime_vgem tests, the vgem unload test fails due to its execbuffers still being handled in the kernel. Retry the unload three times with sleeps before

[Intel-gfx] IGT contributions and reviews

2016-10-18 Thread Petri Latvala
nchmarks, tools, tests, CI test sets, lib) The goal with this discussion is to reach a suitable tradeoff between stability from CI point of view and fruitful use of programmer time. -- Petri Latvala ___ Intel-gfx mailing list Intel-gfx@lists

Re: [Intel-gfx] [PATCH igt] igt: drop gem_storedw_loop from BAT

2016-10-25 Thread Petri Latvala
54:33AM +0100, Chris Wilson wrote: > > > > > On Thu, Oct 20, 2016 at 11:45:47AM +0300, Petri Latvala wrote: > > > > > > On Wed, Oct 19, 2016 at 08:26:17PM +0100, Chris Wilson wrote: > > > > > > > The inter-engine synchronisation (with and without se

Re: [Intel-gfx] [PATCH v3] Idleness DRRS test

2016-11-14 Thread Petri Latvala
Chris, happy with this revision? On Fri, Oct 21, 2016 at 09:22:13AM +0530, Nautiyal Ankit wrote: > From: Ramalingam C > > Idleness DRRS: > By default the DRRS state will be at DRRS_HIGH_RR. When a Display > content is Idle for more than 1Sec Idleness will be

Re: [Intel-gfx] [PATCH] intel-ci: Add gem_exec_suspend/basic-S3/S4-devices to BAT

2016-11-25 Thread Petri Latvala
igt@gem_flink_basic@basic I pushed this commit, but without adding basic-s3-devices. The needed kernel config changes will be deployed after CI is using IGT builds with this commit in, next week. -- Petri Latvala ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH igt 2/2] intel_ci: Add gem_exec_reloc/basic-softpin to BAT

2016-11-25 Thread Petri Latvala
On Thu, Nov 17, 2016 at 01:48:36PM +, Chris Wilson wrote: > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> > Cc: Petri Latvala <petri.latv...@intel.com> > --- > tests/intel-ci/fast-feedback.testlist | 1 + > 1 file changed, 1 insertion(+) > >

Re: [Intel-gfx] [PATCH igt 2/2] intel_ci: Add gem_exec_reloc/basic-softpin to BAT

2016-11-25 Thread Petri Latvala
On Fri, Nov 25, 2016 at 12:00:43PM +0200, Petri Latvala wrote: > On Thu, Nov 17, 2016 at 01:48:36PM +, Chris Wilson wrote: > > Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk> > > Cc: Petri Latvala <petri.latv...@intel.com> > > --- > > tests/intel

Re: [Intel-gfx] [PATCH i-g-t 3/4 v5] tests/drv_module_reload: Convert sh script to C version.

2016-11-16 Thread Petri Latvala
ded gem_alive and gem_exec_store into test (Chris Wilson) > > - int main() to igt_main (Chris Wilson) > > - moved tests/gem_alive -> tools/gem_info (Chris Wilson) > > - added to intel-ci/fast-feedback.testlist (Petri Latvala) > > - added hda_dynamic_debug() (Petri Latvala) >

[Intel-gfx] [PATCH i-g-t] lib: Add missing include for sync()

2016-11-15 Thread Petri Latvala
Commit 721d8747e3a2 added sync() calls to igt_main and igt_simple_main, making self-tests fail to build. #including unistd.h in igt_core.h fixes that. Fixes: 721d8747e3a2 ("igt: Add a test for reordering execbufs") CC: Chris Wilson <ch...@chris-wilson.co.uk> Signed-off-b

Re: [Intel-gfx] [PATCH i-g-t] lib: Add missing include for sync()

2016-11-15 Thread Petri Latvala
On Tue, Nov 15, 2016 at 01:00:14PM +, Chris Wilson wrote: > Reviewed-by: Chris Wilson <ch...@chris-wilson.co.uk> > -Chris > Thanks, pushed. -- Petri Latvala ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.

Re: [Intel-gfx] [PATCH i-g-t 2/3] tests/drv_module_reload_basic: Convert sh script to C version.

2016-10-21 Thread Petri Latvala
) { + if ((err = reload(NULL))) + igt_fail(err); + } + + igt_subtest("basic-exec") { + dir = dirname(prg); + finish_load(dir); + } + + igt_subtest("basic-reload-inject") { + for (i = 0; i <

Re: [Intel-gfx] [i-g-t PATCH] tests: debug log lsmod on module unload failure

2016-10-21 Thread Petri Latvala
unds scary but LGTM. Reviewed-by: Petri Latvala <petri.latv...@intel.com> > --- > tests/drv_module_reload_basic | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/tests/drv_module_reload_basic b/tests/drv_module_reload_basic >

[Intel-gfx] [PATCH i-g-t 1/2] tools: Add intel_guc_logger to .gitignore

2016-10-28 Thread Petri Latvala
Also re-sort the file. Signed-off-by: Petri Latvala <petri.latv...@intel.com> --- tools/.gitignore | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/.gitignore b/tools/.gitignore index 6ca6fbe..b19c908 100644 --- a/tools/.gitignore +++ b/tools/.gitignore @@

[Intel-gfx] [PATCH i-g-t 2/2] benchmarks: Add prime_lookup to .gitignore

2016-10-28 Thread Petri Latvala
Also re-sort the file. Signed-off-by: Petri Latvala <petri.latv...@intel.com> --- benchmarks/.gitignore | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/benchmarks/.gitignore b/benchmarks/.gitignore index 5332406..fa7f8ed 100644 --- a/benchmarks/.gitignore +++ b/benc

Re: [Intel-gfx] [PATCH igt] intel-ci: CI is missing any wait tests in BAT

2016-10-28 Thread Petri Latvala
ceed the time budget. - Tests must pass on current kernels, on some platform. This will be documented when we can get CI do the testing for us on multiple platforms and properly know what kind of requirements can actually be tested. For these tests, manual testing was done on IVB, HSW, and BYT. Stable, fast and pa

Re: [Intel-gfx] [PATCH i-g-t] lib/chipset: Properly skip on non-Intel

2016-10-11 Thread Petri Latvala
tor_destroy(iter); > } > - if (pci_dev == NULL) > - errx(1, "Couldn't find graphics card"); > + igt_require_f(pci_dev, "Couldn't find Intel graphics card\n"); > > error = pci_device_probe(pci_dev); > igt_fail_on_f(error !=

[Intel-gfx] [PATCH i-g-t] intel-ci: Remove kms_psr_sink_crc@psr_basic from BAT

2016-10-12 Thread Petri Latvala
The test is producing a lot of CI noise. Signed-off-by: Petri Latvala <petri.latv...@intel.com> --- Will be pushed shortly. Visible in CI results tomorrow-ish. tests/intel-ci/fast-feedback.testlist | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/intel-ci/fast-feedback.testl

Re: [Intel-gfx] [i-g-t PATCH 1/3] tests: add more checks for finding the debugfs in script based tests

2016-10-14 Thread Petri Latvala
On Fri, Oct 14, 2016 at 02:50:49PM +0300, Jani Nikula wrote: > On Fri, 14 Oct 2016, Petri Latvala <petri.latv...@intel.com> wrote: > > On Thu, Oct 13, 2016 at 03:59:55PM +0300, Jani Nikula wrote: > >> While at it, make debugfs_path point at the debugfs root, not &g

Re: [Intel-gfx] [PATCH igt] intel-ci: Do module loads first + last

2016-12-09 Thread Petri Latvala
tests run in a usual configuration, and as a nice side-effect, with the admin-specified global module parameters (kernel cmdline, module config in /etc...). Those are currently ignored because of the reload (oopsie). Chris, Jani, comments on moving all reloads to the bottom? -- Petri Latvala ___

Re: [Intel-gfx] [PATCH v2 i-g-t] tools: Add intel_dp_compliance for DisplayPort 1.2 compliance automation

2016-12-16 Thread Petri Latvala
> v2: > * Add mode unset on hotplug uevent on disconnect (Manasi Navare) > > Cc: Petri Latvala <petri.latv...@intel.com> > Cc: Marius Vlad <marius.c.v...@intel.com> > Cc: Daniel Vetter <daniel.vet...@ffwll.ch> > Signed-off-by: Manasi Navare <manasi.d.nav...

Re: [Intel-gfx] [PATCH i-g-t v10 17/21] lib/sw_sync: Add igt_require_sw_sync to enable skipping on no sw_sync support

2016-12-07 Thread Petri Latvala
("/sbin/modprobe -s r sw_sync")); > + > + err = false; > + if (access(DEVFS_SW_SYNC, R_OK | W_OK) < 0) { > + char buf[128]; > + > + snprintf(buf, sizeof(buf), "%s/sw_sync", igt_debugfs_mount());

Re: [Intel-gfx] [PATCH i-g-t v3] tools: Add intel_dp_compliance for DisplayPort 1.2 compliance automation

2017-01-11 Thread Petri Latvala
Hi The copyright statements still need the year corrected. intel_dp_compliance needs to be added to tools/.gitignore Some new comments also: - Why do some of the prints have \r\n? - Building intel_dp_compliance should actually be made conditional upon HAVE_UDEV -- Petri Latvala On Fri

[Intel-gfx] [ANNOUNCE] intel-gpu-tools 1.17

2016-12-02 Thread Petri Latvala
for measuring fence wakeup latencies. (Chris Wilson) - prime_lookup: New microbenchmark for stressing prime_fd_to_handle and prime_handle_to_fd. (Chris Wilson) Test changes: - Multiple new tests. - Added an explicit list of tests used for Intel CI. (Petri Latvala) - Converted multiple shell

Re: [Intel-gfx] [PATCH i-g-t 0/4 v7] Convert sh scripts to C variants.

2016-12-02 Thread Petri Latvala
on farm2. -- Petri Latvala ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH i-g-t 1/2] lib/i915_pciids.h: Update to latest version wich includes GLK ids

2017-01-03 Thread Petri Latvala
On Mon, Jan 02, 2017 at 04:33:03PM +0200, Ander Conselvan De Oliveira wrote: > Hi Petri, > > I'm not sure what are the i-g-t rules regarding R-b tags nowadays. Does this > require one or can I push it? The series is Reviewed-by: Petri Latvala <petri.latv...@intel.com> Some o

Re: [Intel-gfx] [PATCH igt 4/6] kms_frontbuffer_tracking: refactor sink CRC reliability handling

2017-01-05 Thread Petri Latvala
ot eDP\n"); + sink_crc.supported = false; return; } Paulo? -- Petri Latvala On Thu, Dec 22, 2016 at 06:42:06PM -0200, Paulo Zanoni wrote: > What I'm currently seeing is that sometimes the first check during > setup_sink_crc() returns valid sink CRC, but then the

Re: [Intel-gfx] [i-g-t PATCH] README: add libkmod-dev and libprocps3-dev to dependencies

2017-01-02 Thread Petri Latvala
ibpciaccess-dev > + libprocps3-dev > libunwind-dev > python-docutils > x11proto-dri2-dev > -- > 2.1.4 s/libprocps3-dev/libprocps-dev/ procps package name on Debian is just libprocps-dev. Ubuntu has libprocps3-dev but only on 14.04, and even there the package

Re: [Intel-gfx] [i-g-t PATCH v4] tests/kms_hdmi_inject: Add test for HDMI injection capabilities.

2017-03-30 Thread Petri Latvala
s, run by 'make [dist]check'. -- Petri Latvala ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH i-g-t 2/3] igt_command_line.sh: Actually check things during distcheck

2017-03-21 Thread Petri Latvala
check" checks everything "make check" does, as does executing the script by hand. Signed-off-by: Petri Latvala <petri.latv...@intel.com> --- tests/igt_command_line.sh | 45 + 1 file changed, 29 insertions(+), 16 deletions(-) diff --git a

[Intel-gfx] [PATCH i-g-t 3/3] lib/igt_kmod: Don't call igt_assert or igt_require without a fixture

2017-03-21 Thread Petri Latvala
for the same reason. Signed-off-by: Petri Latvala <petri.latv...@intel.com> CC: Chris Wilson <ch...@chris-wilson.co.uk> --- lib/igt_kmod.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/igt_kmod.c b/lib/igt_kmod.c index 4b8ea81..b366ade 100644 --- a/li

[Intel-gfx] [PATCH i-g-t 1/3] igt_command_line.sh: Handle the special cases of drv_selftest and drm_mm

2017-03-21 Thread Petri Latvala
Kernel selftest launchers use dynamic subtest enumeration. When running on a kernel without selftests, they output nothing from --list-subtests and exit with 0. Handle this specialty in the checker. Signed-off-by: Petri Latvala <petri.latv...@intel.com> --- tests/igt_command_line.

[Intel-gfx] [PATCH i-g-t 3/4] intel-ci: Build-time check for testlists

2017-03-17 Thread Petri Latvala
Test at check and distcheck that testlist files only contain tests that are still present. Signed-off-by: Petri Latvala <petri.latv...@intel.com> --- configure.ac | 1 + tests/Makefile.am | 2 ++ tests/intel-ci/.gitignore | 1 + tests/in

[Intel-gfx] [PATCH i-g-t 2/4] tests/Makefile.am: Only ignore generated gitignore in gitignore

2017-03-17 Thread Petri Latvala
When generating the .gitignore file, use /.gitignore instead of .gitignore to not have it apply to subdirectories. Signed-off-by: Petri Latvala <petri.latv...@intel.com> --- tests/Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/Makefile.am b

[Intel-gfx] [PATCH i-g-t 1/4] intel-ci: Add comments on test order to fast-feedback.testlist

2017-03-17 Thread Petri Latvala
Document the test ordering choices in fast-feedback.testlist. For comments in testlists, piglit commit commit 0c535186d624071098c10003fdafe8f475ed9ae7 Author: Petri Latvala <petri.latv...@intel.com> Date: Wed Feb 1 12:57:45 2017 +0200 framework/programs/run.py: Allow comments i

[Intel-gfx] [PATCH i-g-t 0/4] Testlist changes

2017-03-17 Thread Petri Latvala
This series introduces a build-time checker for testlists, the test list for extended testing, and as an added bonus, introduces the ability to comment test lists. Petri Latvala (4): intel-ci: Add comments on test order to fast-feedback.testlist tests/Makefile.am: Only ignore generated

[Intel-gfx] [PATCH i-g-t 4/4] intel-ci: Add extended.testlist for wider testing

2017-03-17 Thread Petri Latvala
Test list with wider coverage and longer full runtime. Signed-off-by: Petri Latvala <petri.latv...@intel.com> CC: Tomi Sarvela <tomi.p.sarv...@intel.com> --- This is a preliminary testlist for extended testing. Tomi has been running it semi-manually in CI already. I think I have

Re: [Intel-gfx] [PATCH] aubinator: Define DRM_IOCTL_I915_GEM_EXECBUFFER2_WR if unavailable

2017-03-16 Thread Petri Latvala
ECBUFFER2_WR is not there, neither is DRM_I915_GEM_EXECBUFFER2_WR. -- Petri Latvala ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH igt] tests/kms_*: Use correct DRM context version

2017-04-07 Thread Petri Latvala
rsion checks. Thanks, pushed. -- Petri Latvala ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH i-g-t 4/4] assembler/gen8_disasm.c: Remove unused m_mask_ctrl

2017-03-08 Thread Petri Latvala
Signed-off-by: Petri Latvala <petri.latv...@intel.com> --- assembler/gen8_disasm.c | 5 - 1 file changed, 5 deletions(-) diff --git a/assembler/gen8_disasm.c b/assembler/gen8_disasm.c index 7fc7a65..68bc033 100644 --- a/assembler/gen8_disasm.c +++ b/assembler/gen8_disasm.c @@ -138,11

[Intel-gfx] [PATCH i-g-t 2/4] tools/intel_vbt_decode: Remove unused code

2017-03-08 Thread Petri Latvala
efp_conn() and related have been unused since 86a546f6f798 ("tools/intel_bios_reader: Dump out more information from the child device structure") Signed-off-by: Petri Latvala <petri.latv...@intel.com> --- tools/intel_vbt_decode.c | 22 -- 1 file changed, 22 de

Re: [Intel-gfx] [PATCH i-g-t v3] Add the new tool for create GVT-g Linux guest based on KVMGT

2017-03-09 Thread Petri Latvala
os path\n\n" > + "[example]\n" > + " ./intel_gvtg_test -q /usr/bin/qemu-system-x86_64 -a " > + "/home/img/ubuntu-16.04.img -b /usr/bin/bios.bin\n" > + ); > +} > + > +static void arg_mismatch(char *arg) > +{ > +igt_info("argument mismatch: %s\n", arg); > +} > + > +int main(int argc, char *argv[]) > +{ > +int opt = -1; > +const char *optstring = "hq:a:b:"; > +static struct option long_options[] = { > +{"help", 0, NULL, 'h'}, > +{"qemu", 1, NULL, 'q'}, > +{"hda", 1, NULL, 'a'}, > +{"bios", 1, NULL, 'b'}, > +{0, 0, 0, 0} > +}; > + > +int ret = 0; > +int flag_cnt = 0; > +int h_flag = 0; > +int q_flag = 0; > +int a_flag = 0; > +int b_flag = 0; > + > +if (check_gvtg_support() == 1) { > +igt_skip("GVT-g technology is not supported in your system.\n"); > +} > + > +if (check_tools() == 1) { > +igt_skip("Please install the \"uuid-runtime\" tool.\n"); > +} else if (check_tools() == 2) { > +igt_skip("Please install the \"arp-scan\" tool.\n"); > +} else if (check_tools() == 3) { > +igt_skip("Please prepare the \"qemu-ifup\" script.\n"); > +} > + The pattern if (something) { igt_skip("text"); } can be written as igt_skip_on_f(something, "text") but that's not a huge deal. Calling check_tools() multiple times is a bit wasteful. Also not a huge deal. Otherwise looks good to me. -- Petri Latvala ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH i-g-t 0/4] Removal of unused code

2017-03-08 Thread Petri Latvala
These four removals are ones the compiler was yelling at me for the loudest. Petri Latvala (4): lib/intel_device_info: Remove unused whitney definition tools/intel_vbt_decode: Remove unused code tests/testdisplay: Remove unused SPRITE_COLOR_KEY assembler/gen8_disasm.c: Remove unused

[Intel-gfx] [PATCH i-g-t 1/4] lib/intel_device_info: Remove unused whitney definition

2017-03-08 Thread Petri Latvala
Signed-off-by: Petri Latvala <petri.latv...@intel.com> --- lib/intel_device_info.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c index db4f383..41d94b5 100644 --- a/lib/intel_device_info.c +++ b/lib/intel_device_info.c @@ -9,1

[Intel-gfx] [PATCH i-g-t 3/4] tests/testdisplay: Remove unused SPRITE_COLOR_KEY

2017-03-08 Thread Petri Latvala
Unused since 99bdf4f0ff3e ("tests/testdisplay: Use cairo helpers to draw to plane") Signed-off-by: Petri Latvala <petri.latv...@intel.com> --- tests/testdisplay.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/testdisplay.c b/tests/testdisplay.c index a974f42

[Intel-gfx] [PATCH i-g-t v2 0/2] Kernel selftest plumbing

2017-03-13 Thread Petri Latvala
headers copied from the kernel sources, but we can live with that. Generating static testlists for CI use is now possible, and running new selftests without IGT changes stays possible. Petri Latvala (2): lib: Add i915 and drm-mm selftest headers from the kernel Always expose IGT subtests

[Intel-gfx] [PATCH i-g-t v2 1/2] lib: Add i915 and drm-mm selftest headers from the kernel

2017-03-13 Thread Petri Latvala
unning kernel does not support selftests. v2: Also add them to Makefile.sources Signed-off-by: Petri Latvala <petri.latv...@intel.com> --- lib/Makefile.sources | 3 +++ lib/drm_mm_selftests.h| 24 lib/i915_live_selftests.h | 19

[Intel-gfx] [PATCH i-g-t v2 2/2] Always expose IGT subtests for known kernel selftests

2017-03-13 Thread Petri Latvala
and rebuilding IGT. v2: Use correct names for the testcases Signed-off-by: Petri Latvala <petri.latv...@intel.com> --- lib/igt_kmod.c | 52 ++-- lib/igt_kmod.h | 8 +++- tests/drm_mm.c | 17 - tests/drv_selftest.

Re: [Intel-gfx] [PATCH i-g-t v2 0/2] Kernel selftest plumbing

2017-03-13 Thread Petri Latvala
ich wasn't possible before. It doesn't change behaviour from before when run with selftests enabled. It makes other machinery work again, the ones that expect subtest enumeration to work regardless of the runtime environment. Changing _that_ rule with the kselftest runners is the one change that is without

[Intel-gfx] [PATCH i-g-t] Update MAINTAINERS file

2017-03-13 Thread Petri Latvala
Signed-off-by: Petri Latvala <petri.latv...@intel.com> --- Marius has stepped down from being a maintainer a while ago, it's time to make the file match reality. I'd like to take this opportunity to thank Marius for his work and wish him the best in his new endeavours. MAINTAINERS |

Re: [Intel-gfx] [PATCH i-g-t v2 0/2] Kernel selftest plumbing

2017-03-13 Thread Petri Latvala
On Mon, Mar 13, 2017 at 02:15:34PM +, Chris Wilson wrote: > On Mon, Mar 13, 2017 at 01:02:04PM +0200, Petri Latvala wrote: > > On Mon, Mar 13, 2017 at 10:50:04AM +, Chris Wilson wrote: > > > Still completely lacking justification. The above is a non sequitur; >

[Intel-gfx] [ANNOUNCE] intel-gpu-tools 1.18

2017-03-13 Thread Petri Latvala
code to get_sink_crc() kms_frontbuffer_tracking: refactor sink CRC reliability handling kms_frontbuffer_tracking: destroy all FBs from all formats kms_frontbuffer_tracking: fix compression checking Petri Latvala (12): kms_frontbuffer_tracking: fix sink CRC detection regression intel-ci: Rem

Re: [Intel-gfx] [PATCH i-g-t v2 0/2] Kernel selftest plumbing

2017-03-13 Thread Petri Latvala
For the record, I pushed this series so I could get the IGT release out. I'm sure there are various ways this functionality can be improved, so constructive suggestions are still definitely welcome. -- Petri Latvala ___ Intel-gfx mailing list Intel

[Intel-gfx] [PATCH i-g-t 2/2] Always expose IGT subtests for known kernel selftests

2017-03-10 Thread Petri Latvala
and rebuilding IGT. Signed-off-by: Petri Latvala <petri.latv...@intel.com> --- lib/igt_kmod.c | 52 ++-- lib/igt_kmod.h | 8 +++- tests/drm_mm.c | 17 - tests/drv_selftest.c | 25 +++-- 4 files c

[Intel-gfx] [PATCH i-g-t 0/2] Kernel selftest plumbing

2017-03-10 Thread Petri Latvala
, but we can live with that. Generating static testlists for CI use is now possible, and running new selftests without IGT changes stays possible. Petri Latvala (2): lib: Add i915 and drm-mm selftest headers from the kernel Always expose IGT subtests for known kernel selftests lib

  1   2   3   >