[Intel-gfx] [PATCH v2 3/6] drm/i915: abstract get config for cpu transcoder

2016-03-19 Thread Jani Nikula
Makes it neater to add the same for DSI transcoder. No functional changes. v2: rename to hsw_get_transcoder_state and add a comment about grabbing power reference (Ville) Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_display.c | 87

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Use GPLL ref clock to calculate GPU freqs on VLV/CHV

2016-03-19 Thread Imre Deak
On Wed, 2016-03-16 at 19:47 +0200, Ville Syrjälä wrote: > On Wed, Mar 16, 2016 at 07:17:51PM +0200, Imre Deak wrote: > > On Fri, 2016-03-04 at 21:43 +0200, ville.syrj...@linux.intel.com > > wrote: > > > From: Ville Syrjälä > > > > > > Extract the GPLL reference

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Rename local struct intel_ringbuffer variables

2016-03-19 Thread Tvrtko Ursulin
On 16/03/16 16:00, Chris Wilson wrote: On Wed, Mar 16, 2016 at 03:40:54PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Majority of the code calls these ringbuf so fix up a few places which use something else to be consistent. I absolutely detest ringbuf as a

Re: [Intel-gfx] Information about Intel_GPU_TOP tool

2016-03-19 Thread Sanchez, AdolfoX
Thanks for your suggestion I will take a look at this tool. Regards, Adolfo From: Martinez Rodriguez, Sergio Sent: Friday, March 18, 2016 10:32 AM To: intel-gfx@lists.freedesktop.org Cc: Sanchez, AdolfoX ; Bragg, Robert Subject: RE:

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bxt: Fix off-by-one error in Broxton PLL IDs (rev3)

2016-03-19 Thread Tomi Sarvela
On Wednesday 16 March 2016 10:48:43 Imre Deak wrote: > Tomi, noticed two things that maybe infrastructure related, see below: > > > Test drv_module_reload_basic: > > skip -> PASS (bdw-nuci7) > > Test gem_ringfill: > > Subgroup basic-default-s3: > >

[Intel-gfx] [PATCH v2] drm/i915: Fix eDP low vswing for Broadwell

2016-03-19 Thread Mika Kahola
It was noticed on bug #94087 that module parameter i915.edp_vswing=2 that should override the VBT setting to use default voltage swing (400 mV) was not applied for Broadwell. This patch provides a fix for this by checking if default i.e. higher voltage swing is requested to be used and applies

[Intel-gfx] [PATCH igt] lib/igt_aux: Framework for measuring latency in raising signals

2016-03-19 Thread Chris Wilson
Not sure how best to put this to use yet, we need a set of benchmarks to track changes as well as a few hard fail criteria. But at least this is a start towards measuring how long we block signals whilst in the driver. Any ideas on how to stop the -lrt prolifieration? -Chris ---

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: add another virtual PCH bridge for passthrough support

2016-03-19 Thread Patchwork
== Series Details == Series: drm/i915: add another virtual PCH bridge for passthrough support URL : https://patchwork.freedesktop.org/series/4539/ State : warning == Summary == Series 4539v1 drm/i915: add another virtual PCH bridge for passthrough support

[Intel-gfx] [PATCH] drm/i915: Tune down init error message due to failure injection

2016-03-19 Thread Imre Deak
Atm, in case failure injection forces an error a subsequent error messages will make automated tests (CI) report this event as a breakage, even though the event is expected. To fix this print the error message with debug log level in this case. While at it print the error message for any init

Re: [Intel-gfx] [RFC PATCH 05/10] drm/i915: split get/set pipe timings to pipe and transcoder parts

2016-03-19 Thread Ville Syrjälä
On Tue, Mar 15, 2016 at 09:51:13PM +0200, Jani Nikula wrote: > Prep work for DSI transcoders. No functional changes. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/intel_display.c | 27 +++ > 1 file changed, 23 insertions(+), 4

[Intel-gfx] [PATCH] drm/i915: simplify bind_to_vm init code

2016-03-19 Thread Matthew Auld
No functional change, just makes the code easier to follow. Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/i915_gem.c | 41 +++-- 1 file changed, 11 insertions(+), 30 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c

Re: [Intel-gfx] [PATCH v2 (rebased) 3/4] drm/i915: Move pll power state to crtc power domains.

2016-03-19 Thread Ander Conselvan De Oliveira
On Mon, 2016-03-14 at 09:27 +0100, Maarten Lankhorst wrote: > Signed-off-by: Maarten Lankhorst Reviewed-by: Ander Conselvan de Oliveira > --- > drivers/gpu/drm/i915/intel_display.c | 6 +++--- > drivers/gpu/drm/i915/intel_dpll_mgr.c |

Re: [Intel-gfx] [PATCH v2] dim: Avoid false positives with BUG detection

2016-03-19 Thread Jani Nikula
On Thu, 17 Mar 2016, Tvrtko Ursulin wrote: > [ text/plain ] > > > On 11/03/16 15:31, Tvrtko Ursulin wrote: >> From: Tvrtko Ursulin >> >> Makes sure that the diff line adding the BUG is not immediately >> preceded by the diff line removing

[Intel-gfx] [PATCH 08/10] drm/i915: Support for pread/pwrite from/to non shmem backed objects

2016-03-19 Thread ankitprasad . r . sharma
From: Ankitprasad Sharma This patch adds support for extending the pread/pwrite functionality for objects not backed by shmem. The access will be made through gtt interface. This will cover objects backed by stolen memory as well as other non-shmem backed objects.

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bxt: Fix off-by-one error in Broxton PLL IDs (rev3)

2016-03-19 Thread Takashi Iwai
On Fri, 18 Mar 2016 09:12:53 +0100, Tomi Sarvela wrote: > > On Friday 18 March 2016 09:00:13 Takashi Iwai wrote: > > On Fri, 18 Mar 2016 08:36:27 +0100, > > > > Do you have the commit of the last working kernel? > > > > > The unit tests that hang quite reliably on first run are > > >

[Intel-gfx] [PATCH v2 6/6] drm/i915/bxt: allow dsi on any pipe

2016-03-19 Thread Jani Nikula
BXT isn't as limited as BYT and CHT regarding DSI pipes and ports. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_dsi.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dsi.c

Re: [Intel-gfx] [PATCH v2] drm/i915: Tune down init error message due to failure injection

2016-03-19 Thread Imre Deak
On Thu, 2016-03-17 at 21:48 +, Chris Wilson wrote: > On Thu, Mar 17, 2016 at 11:10:42PM +0200, Imre Deak wrote: > > Well, I can follow-up on an export patch for that, but getting that > > merged may take a while, so could we go with the current version > > until > > that? > > What's the

Re: [Intel-gfx] [PATCH] drm/i915: Release power ref after updating wm

2016-03-19 Thread Imre Deak
Matt has a similar fix already on the list, Matt/Ville what's the plan with that? Could we have a stop-gap solution? --Imre On Wed, 2016-03-16 at 17:11 +0200, Gabriel Feceoru wrote: > On HSW/BDW there are random dmesg-warn errors while running kms > tests, like: > > [90587.867077] Call Trace: >

Re: [Intel-gfx] [PATCH] drm/i915: Restrict usage of live status check

2016-03-19 Thread Jani Nikula
On Thu, 17 Mar 2016, Shashank Sharma wrote: > [ text/plain ] > This patch restricts usage of live status check for HDMI detection. > While testing certain (monitor + cable) combinations with various > intel platforms, it seems that live status register is not reliable

Re: [Intel-gfx] [PATCH v3] drm/i915: Move CSB MMIO reads out of the execlists lock

2016-03-19 Thread Chris Wilson
On Thu, Mar 17, 2016 at 12:59:46PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > By reading the CSB (slow MMIO accesses) into a temporary local > buffer we can decrease the duration of holding the execlist > lock. > > Main advantage is that during heavy batch

Re: [Intel-gfx] [PATCH 1/3] drm/i915/tdr: Initialize hangcheck struct for each engine

2016-03-19 Thread Chris Wilson
On Fri, Mar 18, 2016 at 08:07:54PM +, Arun Siluvery wrote: > From: Tomas Elf > > Initialize hangcheck struct during driver load. Since we do the same after > recovering from a reset, this is extracted into a helper function. > > Cc: Mika Kuoppala

[Intel-gfx] [PATCH] drm/i915: Modify reset func to handle per engine resets

2016-03-19 Thread Mika Kuoppala
In full gpu reset we prime all engines and reset domains corresponding to each engine. Per engine reset is just a special case of this process wherein only a single engine is reset. This change is aimed to modify relevant functions to achieve this. There are some other steps we carry out in case

Re: [Intel-gfx] [PATCH] drm/i915/userptr: Replace get_user_pages()

2016-03-19 Thread Tvrtko Ursulin
On 17/03/16 09:37, Chris Wilson wrote: Although the long term future of get_user_pages_locked() itself is doubtful, the kernel currently recommends: /* get_user_pages should be phased out in favor of * get_user_pages_locked|unlocked or get_user_pages_fast. Nothing * should use

Re: [Intel-gfx] [PATCH] drm/i915: fix sparse warning for using false as NULL

2016-03-19 Thread Ville Syrjälä
On Wed, Mar 16, 2016 at 06:06:58PM +0200, Jani Nikula wrote: > drivers/gpu/drm/i915/intel_dpll_mgr.c:1200:32: warning: Using plain integer > as NULL pointer > > Fixes: 304b65cbdc8d ("drm/i915: Move SKL/KLB pll selection logic to > intel_dpll_mgr.c") > Signed-off-by: Jani Nikula

Re: [Intel-gfx] [PATCH v5] igt/gem_trtt: Exercise the TRTT hardware

2016-03-19 Thread Michel Thierry
On 3/11/2016 11:48 AM, akash.g...@intel.com wrote: From: Akash Goel This patch provides the testcase to exercise the TRTT hardware. Some platforms have an additional address translation hardware support in form of Tiled Resource Translation Table (TR-TT) which provides

Re: [Intel-gfx] [PATCH] drm/i915: Restrict usage of live status check

2016-03-19 Thread Ville Syrjälä
On Fri, Mar 18, 2016 at 08:51:29AM +0530, Sharma, Shashank wrote: > Regards > Shashank > > On 3/17/2016 10:17 PM, Ville Syrjälä wrote: > > On Thu, Mar 17, 2016 at 10:03:04PM +0530, Sharma, Shashank wrote: > >> Hey Chris, > >> I added comments for both Ville and you, please help me to understand

[Intel-gfx] [PATCH] drm/i915: simplify bind_to_vm init code

2016-03-19 Thread Matthew Auld
No functional change, just makes the code easier to follow. v2: - Remove local fence_size variable (Tvrtko Ursulin) - Remove redundant NULL ggtt_view check - Reuse size variable v3: (Chris Wilson) - Keep start, end computation separate - Simplify alignment Signed-off-by:

Re: [Intel-gfx] [PATCH v3] drm/i915: Name all intel_ringbuffer instances ring

2016-03-19 Thread Chris Wilson
On Thu, Mar 17, 2016 at 05:10:36PM +, Tvrtko Ursulin wrote: > diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.h > b/drivers/gpu/drm/i915/intel_ringbuffer.h > index 3e40f7bf2147..ce7337b0aa14 100644 > --- a/drivers/gpu/drm/i915/intel_ringbuffer.h > +++

[Intel-gfx] [PATCH] drm/i915: fix sparse warning for using false as NULL

2016-03-19 Thread Jani Nikula
drivers/gpu/drm/i915/intel_dpll_mgr.c:1200:32: warning: Using plain integer as NULL pointer Fixes: 304b65cbdc8d ("drm/i915: Move SKL/KLB pll selection logic to intel_dpll_mgr.c") Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_dpll_mgr.c | 2 +- 1 file

Re: [Intel-gfx] FW: [PATCH] drm/i915: Restrict usage of live status check

2016-03-19 Thread Jani Nikula
On Thu, 17 Mar 2016, "Sharma, Shashank" wrote: > +intel-gfx Please repost the patch to intel-gfx, just adding cc: makes the patch painful to review and apply, and CI won't pick it up. BR, Jani. > > Regards > Shashank > -Original Message- > From: Sharma,

[Intel-gfx] [PATCH i-g-t 4/6] lib: add crc comparison function without an assert

2016-03-19 Thread Lionel Landwerlin
Signed-off-by: Lionel Landwerlin --- lib/igt_debugfs.c | 17 + lib/igt_debugfs.h | 1 + 2 files changed, 18 insertions(+) diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c index c291ef3..a32ed78 100644 --- a/lib/igt_debugfs.c +++

[Intel-gfx] [PATCH 06/10] drm/i915: Propagating correct error codes to the userspace

2016-03-19 Thread ankitprasad . r . sharma
From: Ankitprasad Sharma Propagating correct error codes to userspace by using ERR_PTR and PTR_ERR macros for stolen memory based object allocation. We generally return -ENOMEM to the user whenever there is a failure in object allocation. This patch helps user to

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gen9: add WaClearFlowControlGpgpuContextSave (rev3)

2016-03-19 Thread Patchwork
== Series Details == Series: drm/i915/gen9: add WaClearFlowControlGpgpuContextSave (rev3) URL : https://patchwork.freedesktop.org/series/4272/ State : failure == Summary == Series 4272v3 drm/i915/gen9: add WaClearFlowControlGpgpuContextSave

Re: [Intel-gfx] [PATCH v2 3/6] drm/i915: abstract get config for cpu transcoder

2016-03-19 Thread Ville Syrjälä
On Fri, Mar 18, 2016 at 05:05:41PM +0200, Jani Nikula wrote: > Makes it neater to add the same for DSI transcoder. No functional > changes. > > v2: rename to hsw_get_transcoder_state and add a comment about grabbing > power reference (Ville) > > Signed-off-by: Jani Nikula

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Use GPLL ref clock to calculate GPU freqs on VLV/CHV

2016-03-19 Thread Ville Syrjälä
On Wed, Mar 16, 2016 at 07:17:51PM +0200, Imre Deak wrote: > On Fri, 2016-03-04 at 21:43 +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Extract the GPLL reference frequency from CCK and use it in the > > GPU freq<->opcode conversions on

[Intel-gfx] [PATCH 02/10] drm/i915: Introduce i915_gem_object_get_dma_address()

2016-03-19 Thread ankitprasad . r . sharma
From: Chris Wilson This utility function is a companion to i915_gem_object_get_page() that uses the same cached iterator for the scatterlist to perform fast sequential lookup of the dma address associated with any page within the object. Signed-off-by: Chris Wilson

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for Split driver init step to phases (rev3)

2016-03-19 Thread Imre Deak
On Thu, 2016-03-17 at 14:23 +0200, Imre Deak wrote: > On Thu, 2016-03-17 at 11:32 +, Patchwork wrote: > > == Series Details == > > > > Series: Split driver init step to phases (rev3) > > URL   : https://patchwork.freedesktop.org/series/4509/ > > State : warning > > > > == Summary == > > > >

[Intel-gfx] [PATCH 04/10] drm/i915: Clearing buffer objects via CPU/GTT

2016-03-19 Thread ankitprasad . r . sharma
From: Ankitprasad Sharma This patch adds support for clearing buffer objects via CPU/GTT. This is particularly useful for clearing out the non shmem backed objects. Currently intend to use this only for buffers allocated from stolen region. v2: Added kernel doc

Re: [Intel-gfx] [PATCH RESEND 4/7] drm/i915: move VBT based DSI presence check to intel_bios.c

2016-03-19 Thread Daniel Vetter
On Wed, Mar 16, 2016 at 12:43:32PM +0200, Jani Nikula wrote: > Hide knowledge about VBT child devices in intel_bios.c. > > v2: Move port check to intel_bios.c (Sivakumar) > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/i915_drv.h | 2 +- >

Re: [Intel-gfx] [PATCH v3] prime_mmap_coherency: Add return error tests for prime sync ioctl

2016-03-19 Thread Tiago Vignatti
On 03/18/2016 03:11 PM, Daniel Vetter wrote: On Fri, Mar 18, 2016 at 03:08:56PM -0300, Tiago Vignatti wrote: This patch adds ioctl-errors subtest to be used for exercising prime sync ioctl errors. The subtest constantly interrupts via signals a function doing concurrent blit to stress out the

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Modify reset func to handle per engine resets (rev3)

2016-03-19 Thread Patchwork
== Series Details == Series: drm/i915: Modify reset func to handle per engine resets (rev3) URL : https://patchwork.freedesktop.org/series/4510/ State : failure == Summary == Series 4510v3 drm/i915: Modify reset func to handle per engine resets

[Intel-gfx] [PATCH] drm/i915: Release power ref after updating wm

2016-03-19 Thread Gabriel Feceoru
On HSW/BDW there are random dmesg-warn errors while running kms tests, like: [90587.867077] Call Trace: [90587.867085] [] dump_stack+0x67/0x99 [90587.867094] [] warn_slowpath_common+0x81/0xc0 [90587.867099] [] warn_slowpath_fmt+0x47/0x50 [90587.867150] [] hsw_write32+0x280/0x290 [i915]

[Intel-gfx] [PATCH 07/10] drm/i915: Add support for stealing purgable stolen pages

2016-03-19 Thread ankitprasad . r . sharma
From: Chris Wilson If we run out of stolen memory when trying to allocate an object, see if we can reap enough purgeable objects to free up enough contiguous free space for the allocation. This is in principle very much like evicting objects to free up enough contiguous space in the vma when

Re: [Intel-gfx] [PATCH v3] drm/i915: Move CSB MMIO reads out of the execlists lock

2016-03-19 Thread Tvrtko Ursulin
On 17/03/16 13:14, Chris Wilson wrote: On Thu, Mar 17, 2016 at 12:59:46PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin By reading the CSB (slow MMIO accesses) into a temporary local buffer we can decrease the duration of holding the execlist lock. Main

Re: [Intel-gfx] [RFC PATCH 03/10] drm/i915/dsi: refactor dsi get hw state readout

2016-03-19 Thread Ville Syrjälä
On Tue, Mar 15, 2016 at 09:51:11PM +0200, Jani Nikula wrote: > Make the code easier to read and update. No functional changes. > > Signed-off-by: Jani Nikula The logic looks intact Reviewed-by: Ville Syrjälä > --- >

[Intel-gfx] [PATCH v2 8/9] drm/i915/dsi: add support for gpio elements on CHV

2016-03-19 Thread Jani Nikula
From: Yogesh Mohan Marimuthu Add support for CHV gpio programming in DSI gpio elements. XXX: I'd like to have a gpio table for chv as well as others. [Rewritten by Jani, based on earlier work by Yogesh and Deepak.] Signed-off-by: Yogesh Mohan Marimuthu

Re: [Intel-gfx] [PATCH] drm/i915: simplify bind_to_vm init code

2016-03-19 Thread Matthew Auld
Hi, If we don't do any of the fence business for !i915_is_gtt, then will this not change the following code: if (alignment == 0) alignment = flags & PIN_MAPPABLE ? fence_alignment : unfenced_alignment; Or am I missing something? Regards, Matt ___

[Intel-gfx] [PATCH i-g-t 2/6] lib: kms: add helpers for color management properties on pipes

2016-03-19 Thread Lionel Landwerlin
v2: Rename CTM_MATRIX property to CTM v3: Add support for atomic commits Signed-off-by: Lionel Landwerlin --- lib/igt_kms.c | 87 +-- lib/igt_kms.h | 20 +- 2 files changed, 104 insertions(+), 3

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bxt: Fix off-by-one error in Broxton PLL IDs (rev3)

2016-03-19 Thread Takashi Iwai
On Wed, 16 Mar 2016 16:37:06 +0100, Daniel Vetter wrote: > > On Wed, Mar 16, 2016 at 02:37:24PM +0200, Tomi Sarvela wrote: > > On Wednesday 16 March 2016 10:48:43 Imre Deak wrote: > > > Tomi, noticed two things that maybe infrastructure related, see below: > > > > > > > Test

[Intel-gfx] [PATCH v2 3/4] drm/i915/gtt: Clean up GGTT probing code

2016-03-19 Thread Joonas Lahtinen
Use less pointers with the probing code, making it much less confusing to read. Cc: Mika Kuoppala Reviewed-by: Chris Wilson Signed-off-by: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_gem_gtt.c | 100

[Intel-gfx] [PATCH 2/2] igt/gem_stolen: No support for stolen backed objects if Intel RST present

2016-03-19 Thread ankitprasad . r . sharma
From: Ankitprasad Sharma Skip gem_stolen and pread/pwrite on stolen backed objects if Intel RST device is present. Signed-off-by: Ankitprasad Sharma --- lib/ioctl_wrappers.c | 14 +- tests/gem_pread.c| 3 +++

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix eDP low vswing for Broadwell

2016-03-19 Thread Ville Syrjälä
On Thu, Mar 17, 2016 at 12:23:10PM +0200, Mika Kahola wrote: > It was noticed on bug #94087 that module parameter > i915.edp_vswing=2 that should override the VBT setting > to use default voltage swing (400 mV) was not applied > for Broadwell. > > This patch provides a fix for this by checking if

[Intel-gfx] [PATCH i-g-t 1/2] lib: Add igt_subtest_group

2016-03-19 Thread Daniel Vetter
Useful for creating common setup code in igt_fixture which is only needed by a subset of tests. And since I'm a good citizen it comes with a library testcase/example included. v2: Make testcase nastier to ensure a subtest group SKIPS when it's parent is skipping already. I accidentally got this

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Set GPU freq to idle_freq initially

2016-03-19 Thread Imre Deak
On Fri, 2016-03-04 at 21:43 +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Currently we set the initial GPU frequency to min_freq_softlimit > on gen9, and to efficient_freq on VLV/CHV. On all the other platforms > we set it to idle_freq.

[Intel-gfx] [PATCH v3 13/19] drm/i915: Move unload time opregion unregistration earlier

2016-03-19 Thread Imre Deak
Move the opregion unregistration earlier to match its corresponding registration order. Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/i915_dma.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_dma.c

[Intel-gfx] [PATCH i-g-t 2/2] tests/gem_concurrent_blt|all: Use igt_subtest_group

2016-03-19 Thread Daniel Vetter
Looks tidy again, and doesn't break igt assumptions. Signed-off-by: Daniel Vetter --- tests/gem_concurrent_all.c | 67 +- 1 file changed, 30 insertions(+), 37 deletions(-) diff --git a/tests/gem_concurrent_all.c

[Intel-gfx] [PATCH 2/3] drm/i915: Rename dev_priv->gtt to dev_priv->ggtt

2016-03-19 Thread Joonas Lahtinen
Refer to Global GTT consistencly as GGTT, thus rename dev_priv->gtt to dev_priv->ggtt and struct i915_gtt to struct i915_ggtt. Fix a couple of whitespace problems while at it. Signed-off-by: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_debugfs.c| 8

Re: [Intel-gfx] [PATCH v3 00/19] Split driver init step to phases

2016-03-19 Thread Chris Wilson
On Wed, Mar 16, 2016 at 01:38:49PM +0200, Imre Deak wrote: > This is v3 of [1]. It includes now the fault injection patches Chris > requested and addresses comments from Daniel and Joonas. Since IGT has > by now an updated drv_module_reload_basic too using load failure > injection, CI hopefully

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/5] drm/i915: Rename local struct intel_engine_cs variables

2016-03-19 Thread Tvrtko Ursulin
On 16/03/16 15:40, Ville Syrjälä wrote: On Wed, Mar 16, 2016 at 03:35:13PM +, Tvrtko Ursulin wrote: On 16/03/16 15:01, Patchwork wrote: == Series Details == Series: series starting with [1/5] drm/i915: Rename local struct intel_engine_cs variables URL :

[Intel-gfx] [PATCH 4/6] drm/i915: Use to_i915() instead of guc_to_i915()

2016-03-19 Thread Chris Wilson
The convenience of saving a few characters by using a consistent interface to obtain our drm_i915_private struct from intel_guc. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_drv.h| 4 +++- drivers/gpu/drm/i915/i915_guc_submission.c | 23

Re: [Intel-gfx] [PATCH v2] drm/i915: Tune down init error message due to failure injection

2016-03-19 Thread Chris Wilson
On Thu, Mar 17, 2016 at 06:08:05PM +0200, Imre Deak wrote: > On Thu, 2016-03-17 at 15:55 +, Chris Wilson wrote: > > 80cols rules still apply to messages :) > > > > "Device initialization failed (%d). " > > "Please file a bug at https://bugs.freedesktop.org/enter_bug.cgi " > > "against

[Intel-gfx] [PATCH 1/4] drm/i915: Remove unused variable in i915_gem_request_add_to_client

2016-03-19 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gem.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 31652c1da761..9c4d9c186d91

Re: [Intel-gfx] [PATCH] drm/i915: Release power ref after updating wm

2016-03-19 Thread Matt Roper
On Wed, Mar 16, 2016 at 05:15:31PM +0200, Imre Deak wrote: > Matt has a similar fix already on the list, Matt/Ville what's the plan > with that? Could we have a stop-gap solution? > > --Imre Yeah, I wrote two separate patches that would both be fixes for that issue. One of them moved the PM

Re: [Intel-gfx] [PATCH v2] drm/i915: Tune down init error message due to failure injection

2016-03-19 Thread Imre Deak
On Thu, 2016-03-17 at 19:41 +, Chris Wilson wrote: > On Thu, Mar 17, 2016 at 06:08:05PM +0200, Imre Deak wrote: > > On Thu, 2016-03-17 at 15:55 +, Chris Wilson wrote: > > > 80cols rules still apply to messages :) > > > > > > "Device initialization failed (%d). " > > > "Please file a bug

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gen9: add WaClearFlowControlGpgpuContextSave (rev3)

2016-03-19 Thread Gore, Tim
Tim Gore  Intel Corporation (UK) Ltd. - Co. Reg. #1134945 - Pipers Way, Swindon SN3 1RJ > -Original Message- > From: Patchwork [mailto:patchw...@emeril.freedesktop.org] > Sent: Thursday, March 17, 2016 9:36 AM > To: Gore, Tim > Cc: intel-gfx@lists.freedesktop.org > Subject: ✗ Fi.CI.BAT:

[Intel-gfx] [PATCH] prime_mmap_coherency: Add return error tests for prime sync ioctl

2016-03-19 Thread Tiago Vignatti
This patch adds ioctl-errors subtest to be used for exercising prime sync ioctl errors. The subtest constantly interrupts via signals a function doing concurrent blit to stress out the right usage of prime_sync_*, making sure these ioctl errors are handled accordingly. Important to note that in

Re: [Intel-gfx] [PATCH RESEND 1/7] drm/i915: move VBT based TV presence check to intel_bios.c

2016-03-19 Thread Daniel Vetter
On Wed, Mar 16, 2016 at 12:43:29PM +0200, Jani Nikula wrote: > Hide knowledge about VBT child devices in intel_bios.c. > > v2: also move int_tv_support check to intel_bios.c (Sivakumar) > > Signed-off-by: Jani Nikula Reviewed-by: Daniel Vetter >

[Intel-gfx] [PATCH i-g-t 1/2] lib: Fix some doc warnings

2016-03-19 Thread Daniel Vetter
Cc: Marius Vlad Signed-off-by: Daniel Vetter --- lib/igt_core.c | 2 ++ lib/igt_kms.c | 5 +++-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/igt_core.c b/lib/igt_core.c index 947a9ca37690..1f9be7d0688e 100644 ---

[Intel-gfx] [PATCH i-g-t 2/2] lib/tests: More igt_subtest_group checks

2016-03-19 Thread Daniel Vetter
... for some cases discussed with Chris on irc. We seem to get them all right. Signed-off-by: Daniel Vetter --- lib/tests/igt_subtest_group.c | 20 1 file changed, 20 insertions(+) diff --git a/lib/tests/igt_subtest_group.c

Re: [Intel-gfx] [PATCH] drm/i915: Modify reset func to handle per engine resets

2016-03-19 Thread Mika Kuoppala
Mika Kuoppala writes: > [ text/plain ] > In full gpu reset we prime all engines and reset domains corresponding to > each engine. Per engine reset is just a special case of this process > wherein only a single engine is reset. This change is aimed to modify >

Re: [Intel-gfx] [RFC PATCH 07/10] drm/i915: abstract get config for cpu transcoder

2016-03-19 Thread Ville Syrjälä
On Wed, Mar 16, 2016 at 05:26:24PM +0200, Jani Nikula wrote: > On Wed, 16 Mar 2016, Ville Syrjälä wrote: > > [ text/plain ] > > On Tue, Mar 15, 2016 at 09:51:15PM +0200, Jani Nikula wrote: > >> Makes it neater to add the same for DSI transcoder. No functional > >>

Re: [Intel-gfx] [PATCH v2 4/4] drm/i915: Codify our assumption that the Global GTT is <= 4GiB

2016-03-19 Thread Chris Wilson
On Fri, Mar 18, 2016 at 10:56:55AM +, Tvrtko Ursulin wrote: > > On 18/03/16 08:42, Joonas Lahtinen wrote: > >From: Chris Wilson > > > >Throughout the code base, we use u32 for offsets into the global GTT. If > >we ever see any hardware with a larger GGTT, then we

Re: [Intel-gfx] [PATCH] drm/i915: Fix race condition in intel_dp_destroy_mst_connector()

2016-03-19 Thread Ville Syrjälä
On Wed, Mar 16, 2016 at 03:44:37PM -0400, Lyude Paul wrote: > On Wed, 2016-03-16 at 21:39 +0200, Ville Syrjälä wrote: > > On Wed, Mar 16, 2016 at 03:18:04PM -0400, Lyude wrote: > > > > > > After unplugging a DP MST display from the system, we have to go through > > > and destroy all of the DRM

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Remove unused variable in i915_gem_request_add_to_client

2016-03-19 Thread Chris Wilson
On Wed, Mar 16, 2016 at 03:40:52PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Signed-off-by: Tvrtko Ursulin This function is horrible, this is slightly better but not much. Reviewed-by: Chris Wilson

Re: [Intel-gfx] [PATCH v3] prime_mmap_coherency: Add return error tests for prime sync ioctl

2016-03-19 Thread Daniel Vetter
On Fri, Mar 18, 2016 at 03:08:56PM -0300, Tiago Vignatti wrote: > This patch adds ioctl-errors subtest to be used for exercising prime sync > ioctl > errors. > > The subtest constantly interrupts via signals a function doing concurrent blit > to stress out the right usage of prime_sync_*, making

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bxt: Fix off-by-one error in Broxton PLL IDs (rev3)

2016-03-19 Thread Takashi Iwai
On Fri, 18 Mar 2016 08:36:27 +0100, Tomi Sarvela wrote: > > On Thursday 17 March 2016 18:00:52 Takashi Iwai wrote: > ... > > > > CI_DRM_1147 git://anongit.freedesktop.org/drm-intel > > > dbbc6d276864d7b7a3a1edb04f0511153f9c3852 > > > > > > Note that drm-intel-nightly history changes, so the

Re: [Intel-gfx] [PATCH V11] drm/i915/skl: SKL CDCLK change on modeset tracking VCO

2016-03-19 Thread Rodrigo Vivi
On Wed, Mar 16, 2016 at 4:33 PM Clint Taylor wrote: > On 03/16/2016 12:27 AM, Daniel Vetter wrote: > > On Tue, Mar 15, 2016 at 02:34:05PM -0700, clinton.a.tay...@intel.com > wrote: > >> From: Clint Taylor > >> > >> WARNING: Using ChromeOS

[Intel-gfx] [PATCH v3 00/19] Split driver init step to phases

2016-03-19 Thread Imre Deak
This is v3 of [1]. It includes now the fault injection patches Chris requested and addresses comments from Daniel and Joonas. Since IGT has by now an updated drv_module_reload_basic too using load failure injection, CI hopefully catches any problems introduced by this patchset. CC: Chris Wilson

Re: [Intel-gfx] [PATCH] dma-buf, drm, ion: Propagate error code from dma_buf_start_cpu_access()

2016-03-19 Thread Daniel Vetter
On Fri, Mar 18, 2016 at 08:02:39PM +, Chris Wilson wrote: > Drivers, especially i915.ko, can fail during the initial migration of a > dma-buf for CPU access. However, the error code from the driver was not > being propagated back to ioctl and so userspace was blissfully ignorant > of the

[Intel-gfx] [maintainer-tools PATCH] dim: turn commit-add-tag into a proper dim subcommand

2016-03-19 Thread Jani Nikula
This lets you add e.g. review tags to a commit on the command line: $ dim commit-add-tag "Reviewed-by: Ville Syrjälä " This could be used as a building block for further scripting. Signed-off-by: Jani Nikula --- dim | 19

Re: [Intel-gfx] Intel Atom SoC Bay/Cherry Trail - HDMI Audio

2016-03-19 Thread poma
... meanwhile ... $ modinfo hdmi_audio filename: /lib/modules/4.5.0-301.fc22.x86_64/kernel/sound/hdmi_audio/hdmi_audio.ko.xz version:0.01.003 license:GPL v2 description:Intel HDMI Audio driver author: Vaibhav Agarwal author:

[Intel-gfx] [PATCH v3] drm/i915: Move CSB MMIO reads out of the execlists lock

2016-03-19 Thread Tvrtko Ursulin
From: Tvrtko Ursulin By reading the CSB (slow MMIO accesses) into a temporary local buffer we can decrease the duration of holding the execlist lock. Main advantage is that during heavy batch buffer submission we reduce the execlist lock contention, which should

Re: [Intel-gfx] [PATCH v2 (rebased) 1/4] drm/i915: Use a crtc mask instead of a refcount for dpll functions, v2.

2016-03-19 Thread Ander Conselvan De Oliveira
On Mon, 2016-03-14 at 09:27 +0100, Maarten Lankhorst wrote: > This makes it easier to verify correct dpll setup with only a single crtc. > It is also useful to detect double dpll enable/disable. > > Changes since v1: > - Rebase on top of Ander's dpll rework. > - Change debugfs active to a mask. >

Re: [Intel-gfx] [PATCH v3 19/19] drm/i915: Add fault injection support

2016-03-19 Thread Imre Deak
On Wed, 2016-03-16 at 12:44 +, Chris Wilson wrote: > On Wed, Mar 16, 2016 at 02:12:35PM +0200, Imre Deak wrote: > > On Wed, 2016-03-16 at 12:00 +, Chris Wilson wrote: > > > On Wed, Mar 16, 2016 at 01:39:08PM +0200, Imre Deak wrote: > > > > Add support for forcing an error at selected

[Intel-gfx] [PATCH v3 06/19] drm/i915: Move load time runtime device info init earlier

2016-03-19 Thread Imre Deak
This init step accesses the device, but doesn't have any device specific side effect. It also sets up some platform specific attributes that may be required early, so move it earlier. Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/i915_dma.c | 4 ++-- 1 file changed, 2

Re: [Intel-gfx] [PATCH v2 1/4] drm/i915/gtt: Reference mappable_end variable from pointer

2016-03-19 Thread Tvrtko Ursulin
On 18/03/16 08:42, Joonas Lahtinen wrote: Reference variable value from pointer, not assumed pointer destination. Since: commit c44ef60e437019b8ca1dab8b4d2e8761fd4ce1e9 Author: Mika Kuoppala Date: Thu Jun 25 18:35:05 2015 +0300 drm/i915/gtt: Allow >=

Re: [Intel-gfx] [PATCH v2] mm/vmap: Add a notifier for when we run out of vmap address space

2016-03-19 Thread Chris Wilson
On Thu, Mar 17, 2016 at 01:34:59PM +, Chris Wilson wrote: > vmaps are temporary kernel mappings that may be of long duration. > Reusing a vmap on an object is preferrable for a driver as the cost of > setting up the vmap can otherwise dominate the operation on the object. > However, the vmap

Re: [Intel-gfx] [PATCH v2] drm/i915: Tune down init error message due to failure injection

2016-03-19 Thread Chris Wilson
On Thu, Mar 17, 2016 at 05:46:11PM +0200, Imre Deak wrote: > Atm, in case failure injection forces an error the subsequent > "*ERROR* failed to init modeset" error message will make automated > tests (CI) report this event as a breakage even though the event is > expected. To fix this print the

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/csr: Allow matching unknown HW steppings with generic firmware

2016-03-19 Thread Imre Deak
On Wed, 2016-03-16 at 17:45 +0200, Imre Deak wrote: > On Mon, 2016-03-07 at 16:24 +, Patchwork wrote: > > == Series Details == > > > > Series: drm/i915/csr: Allow matching unknown HW steppings with > > generic firmware > > URL   : https://patchwork.freedesktop.org/series/4173/ > > State :

[Intel-gfx] [PATCH v2] drm/i915: Tune down init error message due to failure injection

2016-03-19 Thread Imre Deak
Atm, in case failure injection forces an error the subsequent "*ERROR* failed to init modeset" error message will make automated tests (CI) report this event as a breakage even though the event is expected. To fix this print the error message with debug log level in this case. While at it print

Re: [Intel-gfx] [PATCH 2/8] drm/i915/dsi: add support for DSI sequence block v2 gpio element

2016-03-19 Thread Ville Syrjälä
On Thu, Mar 17, 2016 at 05:04:40PM +0200, Jani Nikula wrote: > In sequence block v2, and only in v2, the gpio source (i.e. IOSF port) > is specified separately. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 21 + >

[Intel-gfx] [PATCH v3 11/19] drm/i915: Move unload time display power domain uninit later

2016-03-19 Thread Imre Deak
Move the power domain uninitialization later so that it matches its corresponding init order. Since we access the HW during the later unitialization steps keep a wake reference until after the last such step. Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/i915_dma.c | 7

[Intel-gfx] [PATCH v2 6/9] drm/i915/dsi: add support for sequence block v3 gpio for VLV

2016-03-19 Thread Jani Nikula
Just put the iosf port in the gpio table. The table might include some duplication, but this approach keeps the code the cleanest. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_dsi_panel_vbt.c | 28 ++-- 1 file changed, 14

Re: [Intel-gfx] [PATCH RESEND 5/7] drm/i915/panel: setup pwm backlight based on connector type

2016-03-19 Thread Daniel Vetter
On Wed, Mar 16, 2016 at 12:43:33PM +0200, Jani Nikula wrote: > Use the connector type instead of VBT directly to decide which backlight > mechanism to use on VLV/CHV. (Indirectly, this is the same thing, but > hides the VBT use.) > > Signed-off-by: Jani Nikula

[Intel-gfx] [PATCH v2] mm/vmap: Add a notifier for when we run out of vmap address space

2016-03-19 Thread Chris Wilson
vmaps are temporary kernel mappings that may be of long duration. Reusing a vmap on an object is preferrable for a driver as the cost of setting up the vmap can otherwise dominate the operation on the object. However, the vmap address space is rather limited on 32bit systems and so we add a

Re: [Intel-gfx] [PATCH] drm/i915: Restrict usage of live status check

2016-03-19 Thread Sharma, Shashank
Regards Shashank On 3/17/2016 2:55 PM, Jani Nikula wrote: On Thu, 17 Mar 2016, Shashank Sharma wrote: [ text/plain ] This patch restricts usage of live status check for HDMI detection. While testing certain (monitor + cable) combinations with various intel

Re: [Intel-gfx] [PATCH v2] drm/i915: Tune down init error message due to failure injection

2016-03-19 Thread Imre Deak
On Thu, 2016-03-17 at 20:44 +, Chris Wilson wrote: > On Thu, Mar 17, 2016 at 09:50:19PM +0200, Imre Deak wrote: > > On Thu, 2016-03-17 at 19:41 +, Chris Wilson wrote: > > > On Thu, Mar 17, 2016 at 06:08:05PM +0200, Imre Deak wrote: > > > > On Thu, 2016-03-17 at 15:55 +, Chris Wilson

Re: [Intel-gfx] [PATCH v3] drm/i915: add module param "enable_dp_mst"

2016-03-19 Thread Daniel Vetter
On Tue, Mar 15, 2016 at 10:14:05AM -0500, Nathan Schulte wrote: > Adds an (unsafe; auto-kernel-tainting) boolean module parameter to the i915 > drm driver: "enable_dp_mst", which is enabled by default. Disabling the > parameter forces newly connected DisplayPort sinks to report as not >

Re: [Intel-gfx] [PATCH] drm/i915: Restrict usage of live status check

2016-03-19 Thread Sharma, Shashank
Regards Shashank On 3/17/2016 9:31 PM, Ville Syrjälä wrote: On Thu, Mar 17, 2016 at 09:15:39PM +0530, Sharma, Shashank wrote: Regards Shashank On 3/17/2016 6:34 PM, Ville Syrjälä wrote: On Thu, Mar 17, 2016 at 01:29:25PM +0530, Shashank Sharma wrote: This patch restricts usage of live

Re: [Intel-gfx] [PATCH v2] drm/i915: Tune down init error message due to failure injection

2016-03-19 Thread Imre Deak
On Fri, 2016-03-18 at 10:59 +0200, Joonas Lahtinen wrote: > On pe, 2016-03-18 at 00:18 +0200, Imre Deak wrote: > > On Thu, 2016-03-17 at 22:14 +, Chris Wilson wrote: > > > > > > On Fri, Mar 18, 2016 at 12:09:30AM +0200, Imre Deak wrote: > > > > > > > > On Thu, 2016-03-17 at 21:48 +,

  1   2   3   4   >