[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/guc: Sanitory checks for platform that dont have GuC

== Series Details == Series: drm/i915/guc: Sanitory checks for platform that dont have GuC URL : https://patchwork.freedesktop.org/series/13358/ State : failure == Summary == Series 13358v1 drm/i915/guc: Sanitory checks for platform that dont have GuC

Re: [Intel-gfx] [PATCH 2/2] drm/i915: KBL - Recommended buffer translation programming for DisplayPort

On Tue, 2016-10-04 at 10:05 +0300, Jani Nikula wrote: > On Tue, 04 Oct 2016, "Vivi, Rodrigo" wrote: > > On Mon, 2016-10-03 at 13:50 +0300, Jani Nikula wrote: > >> On Fri, 30 Sep 2016, Rodrigo Vivi wrote: > >> > According to spec: "KBL re-uses SKL

Re: [Intel-gfx] [PATCH] drm/i915: Don't try to handle GuC when GuC is not supported.

Hi Daniel, So, can we close https://bugs.freedesktop.org/show_bug.cgi?id=97573 with wontfix or notabug? I don't have a strong side on that actually, but Jani was against it it seems. Thanks, Rodrigo. On Wed, 2016-10-05 at 15:50 +0200, Daniel Vetter wrote: > On Thu, Sep 22, 2016 at 04:55:07PM

[Intel-gfx] [PATCH] drm/i915/guc: Sanitory checks for platform that dont have GuC

i915.enable_guc_loading/submission=2 forces the usage of GuC. For platforms that do not have a GuC, asking the kernel to use a GuC should not result in an error state. Do extra checks to see if the platform even has a GuC or not, regardless of the kernel parameter. Cc: Zanoni Paulo

Re: [Intel-gfx] [PATCH 5/6] drm/i915/gen9: Get rid of redundant watermark values

On Wed, Oct 05, 2016 at 06:44:04PM -0300, Paulo Zanoni wrote: > Em Qua, 2016-10-05 às 11:33 -0400, Lyude escreveu: > > diff --git a/drivers/gpu/drm/i915/intel_display.c > > b/drivers/gpu/drm/i915/intel_display.c > > index dd15ae2..c580d3d 100644 > > --- a/drivers/gpu/drm/i915/intel_display.c > >

[Intel-gfx] [PATCH i-g-t 1/2] aubdump: remove already handled -o

From: Lionel Landwerlin Signed-off-by: Lionel Landwerlin Cc: Sirisha Gandikota --- tools/intel_aubdump.in | 4 1 file changed, 4 deletions(-) diff --git a/tools/intel_aubdump.in b/tools/intel_aubdump.in index

[Intel-gfx] [PATCH v2 i-g-t 2/2] aubdump: add --command option to stream aubdump to another program

This comes handy if you want to look at your application output without having to save it into a file. For example, use this with aubinator from Mesa : $ intel_aubdump -c '/path/to/aubinator --gen=hsw' my_gl_app v2: Fix handling empty command line option Signed-off-by: Lionel Landwerlin

[Intel-gfx] ✗ Fi.CI.BAT: warning for i915/GuC: Make GuC loads default

== Series Details == Series: i915/GuC: Make GuC loads default URL : https://patchwork.freedesktop.org/series/13356/ State : warning == Summary == Series 13356v1 i915/GuC: Make GuC loads default https://patchwork.freedesktop.org/api/1.0/series/13356/revisions/1/mbox/ Test

Re: [Intel-gfx] [PATCH 5/6] drm/i915/gen9: Get rid of redundant watermark values

Em Qua, 2016-10-05 às 11:33 -0400, Lyude escreveu: > Now that we've make skl_wm_levels make a little more sense, we can > remove all of the redundant wm information. Up until now we'd been > storing two copies of all of the skl watermarks: one being the > skl_pipe_wm structs, the other being the

[Intel-gfx] [PATCH] i915/GuC: Make GuC loads default

Proper functioning of HuC requires GuC to be loaded. Make GuC loads default so that HuC works seemlessly. Also, note that GuC submission is not made default and still needs to be given as a kernel parameter. Once the issues around GuC submission is resolved it is intended to make it default as

[Intel-gfx] [PATCH v2 1/2] drm/i915: Reduce trickery in DEV_INFO_FOR_EACH_FLAG

Get rid of SEP_SEMICOLON and SEP_BLANK in DEV_INFO_FOR_EACH_FLAG. Consolidate the debug output so that instead of one huge line with "cap1,cap2,capN" each capability is split to own line and displayed as "capN: [yes|no]" to make the dumps more historically informative. v2: - Do not break

[Intel-gfx] [PATCH v2 2/2] drm/i915: Sort DEV_INFO_FOR_EACH_FLAG

Sort DEV_INFO_FOR_EACH_FLAG to alphabetical order (except is_*). v2: - Add comments in the hope of maintaining order (Chris) Cc: Chris Wilson Reviewed-by: Chris Wilson Signed-off-by: Joonas Lahtinen ---

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [v2,1/2] drm/i915: Reduce trickery in DEV_INFO_FOR_EACH_FLAG

== Series Details == Series: series starting with [v2,1/2] drm/i915: Reduce trickery in DEV_INFO_FOR_EACH_FLAG URL : https://patchwork.freedesktop.org/series/13319/ State : warning == Summary == Series 13319v1 Series without cover letter

[Intel-gfx] [PATCH 9/9] drm/i915: Address broxton phy registers based on phy and channel number

The port registers related to the phys in broxton map to different channels and specific phys. Make that mapping explicit. Signed-off-by: Ander Conselvan de Oliveira --- drivers/gpu/drm/i915/i915_drv.h | 2 + drivers/gpu/drm/i915/i915_reg.h

[Intel-gfx] [PATCH 6/9] drm/i915: Move broxton vswing sequence to intel_dpio_phy.c

The vswing sequence is related to the DPIO phy, so move it closer to the rest of DPIO phy related code. Signed-off-by: Ander Conselvan de Oliveira --- drivers/gpu/drm/i915/i915_drv.h | 3 +++ drivers/gpu/drm/i915/intel_ddi.c | 38

[Intel-gfx] [PATCH 4/9] drm/i915: Move broxton phy code to intel_dpio_phy.c

The phy in broxton is also a dpio phy, similar to cherryview but with programming through MMIO. So move the code together with the other similar phys. Signed-off-by: Ander Conselvan de Oliveira --- drivers/gpu/drm/i915/i915_drv.h | 12 ++

[Intel-gfx] [PATCH 1/9] drm/i915: Rename struct i915_power_well field data to id

Calling it data seems to imply arbitrary data can be associated with the power well. However, that field is used for look ups and expected to be unique, so rename it. Signed-off-by: Ander Conselvan de Oliveira --- drivers/gpu/drm/i915/i915_drv.h |

[Intel-gfx] [PATCH 3/9] drm/i915: Pass lane count to bxt_ddi_phy_calc_lane_optmin_mask()

Pass lane count to bxt_ddi_phy_calc_lane_optmin_mask() instead of having it extract that number from a pipe_config to decouple the phy code from intel_crtc_state. Signed-off-by: Ander Conselvan de Oliveira --- drivers/gpu/drm/i915/intel_ddi.c | 8

[Intel-gfx] [PULL] topic/drm-misc

Hi Dave, Another attempt, this time rebased and without the pipe crc patches: - display_info cleanups from Ville - make prime/gem lookups faster with rbtrees (Chris) - misc stuff all over Cheers, Daniel The following changes since commit c2cbc38b9715bd8318062e600668fc30e5a3fbfa: drm:

Re: [Intel-gfx] [PATCH igt 2/2] tests/gem_exec_suspend: Add basic s4-devices subtest

On ke, 2016-10-05 at 10:22 +0100, Chris Wilson wrote: > On Wed, Oct 05, 2016 at 12:04:53PM +0300, Imre Deak wrote: > > Add a new subtest that performs suspend-to-disk, but instead of > > doing > > the full sequence it suspends/resumes only devices. A failed s4 > > subtest > > and a successful

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Move long hpd handling into the hotplug work

On Mon, Oct 03, 2016 at 02:39:16PM +0300, Ander Conselvan De Oliveira wrote: > On Mon, 2016-10-03 at 10:55 +0300, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > We can't rely on connector->status in the detect() hook if the long hpd > > was

[Intel-gfx] [PATCH 8/9] drm/i915: Add location of the Rcomp resistor to bxt_ddi_phy_info

Use struct bxt_ddi_phy_info to hold information of where the Rcomp resistor is located, instead of hard coding it in the init sequence. Note that this moves the enabling of the phy with the Rcomp resistor out of the power well enable code. That should be safe since bxt_ddi_phy_init() is called

[Intel-gfx] [PATCH 7/9] drm/i915: Create a struct to hold information about the broxton phys

Information about which phy is dual channel is hardcoded in the phy init sequence. Split that to a separate struct so the init sequence is more generic. Signed-off-by: Ander Conselvan de Oliveira --- drivers/gpu/drm/i915/i915_reg.h | 9 +++--

[Intel-gfx] [PATCH 0/9] Broxton ddi phy refactoring

Hi, This is a small refactoring of the broxton ddi phy code that splits the knowledge of each phy's configuration from the code itself and makes the connection between the ports and the channels in the phy more obvious. I took the oppurtunity to move the code to intel_dpio_phy.c, since there are

[Intel-gfx] [PATCH 5/9] drm/i915: Move DPIO phy documentation section to intel_dpio_phy.c

Move the DPIO phy documentation section to intel_dpio_phy.c, since that is a more suitable place now that there is a source file dedicated for those phys. Signed-off-by: Ander Conselvan de Oliveira --- Documentation/gpu/i915.rst| 2 +-

[Intel-gfx] [PATCH 2/9] drm/i915: Explicitly map broxton DPIO power wells to phys

The mapping from the BXT_DPIO_CMN_* power wells to their respective phys required a detour implemented in the bxt_power_well_to_phy() function. Instead, embed that information directly into the power_well struct, by resurrecting the data field. Signed-off-by: Ander Conselvan de Oliveira

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gtt: Free unused lower-level page tables

On Wed, Oct 05, 2016 at 09:40:48AM +0300, Joonas Lahtinen wrote: > On ti, 2016-10-04 at 15:54 +0200, Michał Winiarski wrote: > > Since "Dynamic page table allocations" were introduced, our page tables > > can grow (being dynamically allocated) with address space range usage. > > Unfortunately,

Re: [Intel-gfx] [PATCH v3] drm/i915/bxt: Broxton decoupled MMIO

Hi Chris, On Wednesday 05 October 2016 01:26 AM, Chris Wilson wrote: On Tue, Oct 04, 2016 at 09:16:06PM +0530, Praveen Paneri wrote: +#define HAS_DECOUPLED_MMIO(dev) (INTEL_INFO(dev)->has_decoupled_mmio \ + && IS_BXT_REVID(dev, BXT_REVID_C0, REVID_FOREVER)) Edit

Re: [Intel-gfx] [PATCH igt 2/2] tests/gem_exec_suspend: Add basic s4-devices subtest

On Wed, Oct 05, 2016 at 12:04:53PM +0300, Imre Deak wrote: > Add a new subtest that performs suspend-to-disk, but instead of doing > the full sequence it suspends/resumes only devices. A failed s4 subtest > and a successful s4-devices subtest would indicate a kernel core or BIOS > problem as

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gtt: Free unused lower-level page tables

On ti, 2016-10-04 at 15:54 +0200, Michał Winiarski wrote: > Since "Dynamic page table allocations" were introduced, our page tables > can grow (being dynamically allocated) with address space range usage. > Unfortunately, their lifetime is bound to vm. This is not a huge problem > when we're not

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Remove unused "valid" parameter from pte_encode

Michał Winiarski writes: > We're no longer using any invalid PTEs - everything that's not used > should be pointing to scratch. > I was about to suggest this before patch 2/3 to make it simpler. For historical context: https://patchwork.kernel.org/patch/9135411/ I

[Intel-gfx] [PATCH igt 2/2] tests/gem_exec_suspend: Add basic s4-devices subtest

Add a new subtest that performs suspend-to-disk, but instead of doing the full sequence it suspends/resumes only devices. A failed s4 subtest and a successful s4-devices subtest would indicate a kernel core or BIOS problem as opposed to some issue in the driver. Signed-off-by: Imre Deak

[Intel-gfx] [PATCH igt 1/2] lib/igt_aux: Add support for various system suspend/resume options

To have a more accurate idea about any suspend/resume issues we can perform the s/r until various phases in the s/r sequence. This way we can isolate the given problem as being a device driver, kernel core or BIOS related issue. Actual subtests using these new s/r phases will be added as

[Intel-gfx] [PATCH 21/22] drm/i915: Make INTEL_GEN only take dev_priv

From: Tvrtko Ursulin Saves 968 bytes of .rodata strings. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/i915_gem_render_state.c | 6 +++--- drivers/gpu/drm/i915/intel_display.c

[Intel-gfx] [PATCH 18/22] drm/i915: Make IS_G4X only take dev_priv

From: Tvrtko Ursulin Saves 472 bytes of .rodata strings. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.h| 2 +- drivers/gpu/drm/i915/i915_gem_stolen.c | 5 +++-- drivers/gpu/drm/i915/i915_suspend.c| 4 ++--

[Intel-gfx] [PATCH 08/22] drm/i915: Do not use INTEL_INFO(dev_priv)->ring_mask inside WARNs

From: Tvrtko Ursulin Saves 1520 bytes of .rodata strings. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_engine_cs.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git

[Intel-gfx] [PATCH 22/22] drm/i915: Make IS_GEN macros only take dev_priv

From: Tvrtko Ursulin Saves 1416 bytes of .rodata strings. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_debugfs.c| 4 +- drivers/gpu/drm/i915/i915_drv.c| 6 +-- drivers/gpu/drm/i915/i915_drv.h|

[Intel-gfx] [PATCH 02/22] drm/i915: Shrink sdvo_cmd_names

From: Tvrtko Ursulin Pack the struct _sdvo_cmd_name to save 736 bytes of .rodata. This is fine since the name pointers are used only for debug. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_sdvo.c | 2 +- 1 file changed, 1

[Intel-gfx] [PATCH 20/22] drm/i915: Make IS_VALLEYVIEW only take dev_priv

From: Tvrtko Ursulin Saves 944 bytes of .rodata strings and 128 bytes of .text. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/i915_gem_fence.c | 2 +-

[Intel-gfx] [PATCH 16/22] drm/i915: Make IS_BROXTON only take dev_priv

From: Tvrtko Ursulin Saves 1392 bytes of .rodata strings. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.c | 2 +- drivers/gpu/drm/i915/i915_drv.h | 5 +++-- drivers/gpu/drm/i915/i915_gem_gtt.c | 40

[Intel-gfx] [PATCH 17/22] drm/i915: Make HAS_L3_DPF only take dev_priv

From: Tvrtko Ursulin Saves 472 bytes of .rodata strings. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/i915_irq.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[Intel-gfx] [PATCH 10/22] drm/i915: Make INTEL_DEVID only take dev_priv

From: Tvrtko Ursulin Saves 4472 bytes of .rodata strings. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.c| 14 +++-- drivers/gpu/drm/i915/i915_drv.h| 111 +

[Intel-gfx] [PATCH 09/22] drm/i915: Make IS_GEN-range macro only take dev_priv

From: Tvrtko Ursulin Saves 944 bytes of .rodata strings. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [PATCH 07/22] drm/i915: Make HAS_RUNTIME_PM only take dev_priv

From: Tvrtko Ursulin Saves 960 bytes of .rodata strings. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.c | 4 ++-- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/intel_runtime_pm.c | 3 +-- 3

[Intel-gfx] [PATCH 11/22] drm/i915: Make IS_IVYBRIDGE only take dev_priv

From: Tvrtko Ursulin Saves 848 bytes of .rodata strings. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.c | 19 +++ drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/i915_gem.c

[Intel-gfx] [PATCH 19/22] drm/i915: Make IS_CHERRYVIEW only take dev_priv

From: Tvrtko Ursulin Saves 864 bytes of .rodata strings and ~100 of .text. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.c | 2 +- drivers/gpu/drm/i915/i915_drv.h | 8 ++--

[Intel-gfx] [PATCH 12/22] drm/i915: Make IS_BROADWELL only take dev_priv

From: Tvrtko Ursulin Saves 1808 bytes of .rodata strings. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.c | 6 -- drivers/gpu/drm/i915/i915_drv.h | 6 +++--- drivers/gpu/drm/i915/i915_gem.c |

[Intel-gfx] [PATCH 03/22] drm/i915: Shrink per-platform watermark configuration

From: Tvrtko Ursulin Use types of more appropriate size in struct intel_watermark_params to save 512 bytes of .rodata. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_drv.h | 10 +- drivers/gpu/drm/i915/intel_pm.c | 4

[Intel-gfx] [PATCH 15/22] drm/i915: Make IS_SKYLAKE only take dev_priv

From: Tvrtko Ursulin Saves 1016 bytes of .rodata strings and couple hundred of .text. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/i915_gem_gtt.c | 2 +-

[Intel-gfx] [PATCH 04/22] drm/i915: Make HAS_DDI and HAS_PCH_LPT_LP only take dev_priv

From: Tvrtko Ursulin This saves 3248 bytes of .rodata strings. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.h | 8 +++--- drivers/gpu/drm/i915/intel_crt.c | 10 +++ drivers/gpu/drm/i915/intel_display.c |

Re: [Intel-gfx] [PATCH v4 1/3] drm/prime: Pass the right module owner through to dma_buf_export()

For the series: Reviewed-by: Petri Latvala On 10/05/2016 03:21 PM, Chris Wilson wrote: dma_buf_export() adds a reference to the owning module to the dmabuf (to prevent the driver from being unloaded whilst a third party still refers to the dmabuf). However,

Re: [Intel-gfx] xrandr fails after resume from hibernation in kernels 4.7.4 and 4.8.0

On Wed, Oct 05, 2016 at 07:23:23AM +0200, Greg KH wrote: > On Tue, Oct 04, 2016 at 08:43:03PM -0300, Gaston Gonzalez wrote: > > Hi, > > > > After hibernation I get the following error when I tried to connect to > > monitor > > through hdmi: > > > > $ xrandr --output LVDS1 --off --output HDMI1

Re: [Intel-gfx] [PATCH v3] drm/i915/bxt: Broxton decoupled MMIO

On 04/10/2016 16:46, Praveen Paneri wrote: Decoupled MMIO is an alternative way to access forcewake domain registers, which requires less cycles for a single read/write and avoids frequent software forcewake. This certainly gives advantage over the forcewake as this new mechanism “decouples”

[Intel-gfx] [PATCH 14/22] drm/i915: Make IS_KABYLAKE only take dev_priv

From: Tvrtko Ursulin Saves 1320 bytes of .rodata strings. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.c | 10 +- drivers/gpu/drm/i915/i915_drv.h | 6 +++--- drivers/gpu/drm/i915/i915_gem_stolen.c

[Intel-gfx] [PATCH 06/22] drm/i915: Make HAS_GMCH_DISPLAY only take dev_priv

From: Tvrtko Ursulin More .rodata string saving by avoid __I915__ magic inside WARNs. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.h| 2 +- drivers/gpu/drm/i915/intel_color.c | 6 +++---

[Intel-gfx] [PATCH 05/22] drm/i915: Make INTEL_PCH_TYPE & co only take dev_priv

From: Tvrtko Ursulin This saves 1872 bytes of .rodata strings. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.h | 16 ++-- drivers/gpu/drm/i915/i915_gem.c | 2 +- drivers/gpu/drm/i915/i915_gpu_error.c |

[Intel-gfx] [PATCH 13/22] drm/i915: Make IS_HASWELL only take dev_priv

From: Tvrtko Ursulin Saves 2432 bytes of .rodata strings. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/i915_gem.c | 2 +- drivers/gpu/drm/i915/i915_gem_gtt.c | 4 ++--

[Intel-gfx] [PATCH 00/22] .rodata diet

From: Tvrtko Ursulin Dynamic typing in __I915__ (INTEL_INFO) has and unfortuante consequence that for every time it is called under a WARN it generates a very verbose string placed into the appropriate .rodata section. Each instance of that can can several hundred

[Intel-gfx] [PATCH 01/22] drm/i915: Shrink cxsr_latency_table

From: Tvrtko Ursulin unsigned long is too wide - use smaller types in struct cxsr_latency to save 800-something bytes of .rodata. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_drv.h | 16

Re: [Intel-gfx] [PATCH v3 3/3] drm/vgem: Keep a reference to the dmabuf when mmaped

On Wed, Oct 05, 2016 at 03:11:00PM +0200, Daniel Vetter wrote: > On Fri, Sep 30, 2016 at 02:59:59PM +0100, Chris Wilson wrote: > > In order to keep the dmabuf alive whilst the mmap is, we need to hold a > > reference to the dmabuf and not the backing object. This is important as > > the dmabuf not

Re: [Intel-gfx] [PATCH 00/22] .rodata diet

On 05/10/2016 14:01, Jani Nikula wrote: On Wed, 05 Oct 2016, Tvrtko Ursulin wrote: Dynamic typing in __I915__ (INTEL_INFO) has and unfortuante consequence that for every time it is called under a WARN it generates a very verbose string placed into the appropriate

[Intel-gfx] [PATCH v4 2/3] drm/prime: Take a ref on the drm_dev when exporting a dma_buf

dma_buf may live a long time, longer than the last direct user of the driver. We already hold a reference to the owner module (that prevents the object code from disappearing), but there is no reference to the drm_dev - so the pointers to the driver backend themselves may vanish. v2: Resist

[Intel-gfx] [PATCH v4 1/3] drm/prime: Pass the right module owner through to dma_buf_export()

dma_buf_export() adds a reference to the owning module to the dmabuf (to prevent the driver from being unloaded whilst a third party still refers to the dmabuf). However, drm_gem_prime_export() was passing its own THIS_MODULE (i.e. drm.ko) rather than the driver. Extract the right owner from the

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [v2,1/2] drm/i915: Reduce trickery in DEV_INFO_FOR_EACH_FLAG

On ke, 2016-10-05 at 11:19 +, Patchwork wrote: > Test kms_pipe_crc_basic: > Subgroup nonblocking-crc-pipe-a: > pass   -> DMESG-WARN (fi-skl-6700k) [drm:intel_cpu_fifo_underrun_irq_handler [i915]] *ERROR* CPU pipe B FIFO underrun Existing bug;

[Intel-gfx] [PATCH v4 3/3] drm/vgem: Keep a reference to the dmabuf when mmaped

In order to keep the dmabuf alive whilst the mmap is, we need to hold a reference to the dmabuf and not the backing object. This is important as the dmabuf not only keeps the object alive, but also the device so that dmabuf = vgem_create_dmabuf(); ptr = mmap(... dmabuf ...);

[Intel-gfx] ✗ Fi.CI.BAT: warning for Broxton ddi phy refactoring

== Series Details == Series: Broxton ddi phy refactoring URL : https://patchwork.freedesktop.org/series/13320/ State : warning == Summary == Series 13320v1 Broxton ddi phy refactoring https://patchwork.freedesktop.org/api/1.0/series/13320/revisions/1/mbox/ Test kms_pipe_crc_basic:

Re: [Intel-gfx] [Regression report] Weekly regression report WW40

On Mon, 03 Oct 2016, Jairo Miramontes wrote: > This week regressions In the past we used "regression", "bisect_pending", and "bisected" in the bugzilla "Keywords" field. Can we start using those again, please? BR, Jani. -- Jani Nikula, Intel

Re: [Intel-gfx] [PATCH v3 3/3] drm/vgem: Keep a reference to the dmabuf when mmaped

On Fri, Sep 30, 2016 at 02:59:59PM +0100, Chris Wilson wrote: > In order to keep the dmabuf alive whilst the mmap is, we need to hold a > reference to the dmabuf and not the backing object. This is important as > the dmabuf not only keeps the object alive, but also the device so that > >

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [v4,1/3] drm/prime: Pass the right module owner through to dma_buf_export()

== Series Details == Series: series starting with [v4,1/3] drm/prime: Pass the right module owner through to dma_buf_export() URL : https://patchwork.freedesktop.org/series/13322/ State : warning == Summary == Series 13322v1 Series without cover letter

Re: [Intel-gfx] [PATCH] drm/i915: Don't try to handle GuC when GuC is not supported.

On Thu, Sep 22, 2016 at 04:55:07PM +, Vivi, Rodrigo wrote: > On Wed, 2016-09-21 at 18:00 -0300, Paulo Zanoni wrote: > > Em Qua, 2016-09-21 às 11:22 -0700, Rodrigo Vivi escreveu: > > > Avoid any kind of GuC handling if GuC is not supported > > > on a giving platform. > > > > > > Besides being

Re: [Intel-gfx] [PATCH 1/3] Revert "Skip intel_crt_init for Dell XPS 8700"

On Mon, Sep 26, 2016 at 12:20:44PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > This reverts commit 10b6ee4a87811a110cb01eaca01eb04da6801baf. > > According to [1] Dell XPS8700 VBT says 'int_crt_support 0', so thanks > to commit

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [v2,1/2] drm/i915: Reduce trickery in DEV_INFO_FOR_EACH_FLAG

On ke, 2016-10-05 at 15:22 +0300, Joonas Lahtinen wrote: > So nothing related to the series, good to merge unless there's a > direct > Nack. Jani? Not-Ncked on IRC, so merged, thanks for the review! Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation

Re: [Intel-gfx] [PATCH v3 3/3] drm/vgem: Keep a reference to the dmabuf when mmaped

On Wed, Oct 05, 2016 at 02:40:09PM +0100, Chris Wilson wrote: > On Wed, Oct 05, 2016 at 03:11:00PM +0200, Daniel Vetter wrote: > > On Fri, Sep 30, 2016 at 02:59:59PM +0100, Chris Wilson wrote: > > > In order to keep the dmabuf alive whilst the mmap is, we need to hold a > > > reference to the

Re: [Intel-gfx] [PATCH 00/22] .rodata diet

On Wed, Oct 05, 2016 at 02:39:16PM +0100, Tvrtko Ursulin wrote: > > On 05/10/2016 14:01, Jani Nikula wrote: > > >On Wed, 05 Oct 2016, Tvrtko Ursulin wrote: > >>Dynamic typing in __I915__ (INTEL_INFO) has and unfortuante consequence that > >>for every time it is called

Re: [Intel-gfx] [PATCH 00/22] .rodata diet

On Wed, 05 Oct 2016, Tvrtko Ursulin wrote: > Dynamic typing in __I915__ (INTEL_INFO) has and unfortuante consequence that > for every time it is called under a WARN it generates a very verbose string > placed into the appropriate .rodata section. AFAIK the idea all along

Re: [Intel-gfx] [PATCH 08/22] drm/i915: Do not use INTEL_INFO(dev_priv)->ring_mask inside WARNs

On ke, 2016-10-05 at 13:33 +0100, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > Saves 1520 bytes of .rodata strings. > Reviewed-by: Joonas Lahtinen Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel

Re: [Intel-gfx] [PATCH 01/11] drm/amdgpu: Remove call to reservation_object_test_signaled_rcu before wait

Hi Alex, On 23 September 2016 at 18:24, Daniel Vetter wrote: > On Mon, Aug 29, 2016 at 08:08:24AM +0100, Chris Wilson wrote: >> Since fence_wait_timeout_reservation_object_wait_timeout_rcu() with a >> timeout of 0 becomes reservation_object_test_signaled_rcu(), we do not >> need

Re: [Intel-gfx] [PATCH 04/11] drm/nouveau: Remove call to reservation_object_test_signaled_rcu before wait

Hi Ben, On 23 September 2016 at 18:25, Daniel Vetter wrote: > On Mon, Aug 29, 2016 at 08:08:27AM +0100, Chris Wilson wrote: >> Since fence_wait_timeout_reservation_object_wait_timeout_rcu() with a >> timeout of 0 becomes reservation_object_test_signaled_rcu(), we do not >> need

Re: [Intel-gfx] [PATCH 03/22] drm/i915: Shrink per-platform watermark configuration

On Wed, Oct 05, 2016 at 01:33:30PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Use types of more appropriate size in struct > intel_watermark_params to save 512 bytes of .rodata. > > Signed-off-by: Tvrtko Ursulin > --- >

Re: [Intel-gfx] [PATCH 02/11] drm/etnaviv: Remove manual call to reservation_object_test_signaled_rcu before wait

Hi Lucas, On 23 September 2016 at 18:25, Daniel Vetter wrote: > On Mon, Aug 29, 2016 at 08:08:25AM +0100, Chris Wilson wrote: >> Since fence_wait_timeout_reservation_object_wait_timeout_rcu() with a >> timeout of 0 becomes reservation_object_test_signaled_rcu(), we do not >>

Re: [Intel-gfx] [PATCH 01/22] drm/i915: Shrink cxsr_latency_table

On Wed, Oct 05, 2016 at 01:33:28PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > unsigned long is too wide - use smaller types in > struct cxsr_latency to save 800-something bytes of .rodata. > > Signed-off-by: Tvrtko Ursulin > ---

Re: [Intel-gfx] [PATCH 05/11] drm/vmwgfx: Remove call to reservation_object_test_signaled_rcu before wait

Hi Thomas, Sinclair, On 23 September 2016 at 18:26, Daniel Vetter wrote: > On Mon, Aug 29, 2016 at 08:08:28AM +0100, Chris Wilson wrote: >> Since fence_wait_timeout_reservation_object_wait_timeout_rcu() with a >> timeout of 0 becomes reservation_object_test_signaled_rcu(), we do

Re: [Intel-gfx] [PATCH 03/22] drm/i915: Shrink per-platform watermark configuration

On 05/10/2016 16:07, Joonas Lahtinen wrote: On ke, 2016-10-05 at 13:33 +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Use types of more appropriate size in struct intel_watermark_params to save 512 bytes of .rodata. Signed-off-by: Tvrtko Ursulin

Re: [Intel-gfx] [PATCH 03/22] drm/i915: Shrink per-platform watermark configuration

On 05/10/2016 17:50, Tvrtko Ursulin wrote: On 05/10/2016 16:07, Joonas Lahtinen wrote: On ke, 2016-10-05 at 13:33 +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Use types of more appropriate size in struct intel_watermark_params to save 512 bytes of .rodata.

Re: [Intel-gfx] [PATCH 05/11] drm/vmwgfx: Remove call to reservation_object_test_signaled_rcu before wait

Hi, I'm preparing a fixes pull request, and I'll include this one if it hasn't been applied by others already. Sinclair On Wed, Oct 05, 2016 at 09:41:22PM +0530, Sumit Semwal wrote: > Hi Thomas, Sinclair, > > On 23 September 2016 at 18:26, Daniel Vetter wrote: > > On Mon,

[Intel-gfx] ✗ Fi.CI.BAT: warning for Start of skl watermark cleanup

== Series Details == Series: Start of skl watermark cleanup URL : https://patchwork.freedesktop.org/series/1/ State : warning == Summary == Series 1v1 Start of skl watermark cleanup https://patchwork.freedesktop.org/api/1.0/series/1/revisions/1/mbox/ Test gem_exec_flush:

Re: [Intel-gfx] [PATCH 03/22] drm/i915: Shrink per-platform watermark configuration

On ke, 2016-10-05 at 13:33 +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Use types of more appropriate size in struct > intel_watermark_params to save 512 bytes of .rodata. > > Signed-off-by: Tvrtko Ursulin The code does seem to

Re: [Intel-gfx] [Regression report] Weekly regression report WW40

> > On Mon, 03 Oct 2016, Jairo Miramontes > wrote: > > This week regressions > > In the past we used "regression", "bisect_pending", and "bisected" in > the bugzilla "Keywords" field. Can we start using those again, please? I think this is a very

[Intel-gfx] [PATCH 4/6] drm/i915/gen9: Make skl_wm_level per-plane

Having skl_wm_level contain all of the watermarks for each plane is annoying since it prevents us from having any sort of object to represent a single watermark level, something we take advantage of in the next commit to cut down on all of the copy paste code in here. Signed-off-by: Lyude

Re: [Intel-gfx] [PATCH 7/9] drm/i915: Create a struct to hold information about the broxton phys

On ke, 2016-10-05 at 15:09 +0300, Ander Conselvan de Oliveira wrote: > Information about which phy is dual channel is hardcoded in the phy init > sequence. Split that to a separate struct so the init sequence is more > generic. > > Signed-off-by: Ander Conselvan de Oliveira > --- >  

Re: [Intel-gfx] [PATCH 8/9] drm/i915: Add location of the Rcomp resistor to bxt_ddi_phy_info

On ke, 2016-10-05 at 15:09 +0300, Ander Conselvan de Oliveira wrote: > Use struct bxt_ddi_phy_info to hold information of where the Rcomp > resistor is located, instead of hard coding it in the init sequence. > > Note that this moves the enabling of the phy with the Rcomp resistor out > of the

[Intel-gfx] ✗ Fi.CI.BAT: warning for .rodata diet

== Series Details == Series: .rodata diet URL : https://patchwork.freedesktop.org/series/13323/ State : warning == Summary == Series 13323v1 .rodata diet https://patchwork.freedesktop.org/api/1.0/series/13323/revisions/1/mbox/ Test kms_pipe_crc_basic: Subgroup

[Intel-gfx] [PATCH 2/6] drm/i915/skl: Remove linetime from skl_wm_values

Next part of cleaning up the watermark code for skl. This is easy, since it seems that we never actually needed to keep track of the linetime in the skl_wm_values struct anyway. Signed-off-by: Lyude Cc: Maarten Lankhorst Cc: Ville Syrjälä

[Intel-gfx] [PATCH 1/6] drm/i915/skl: Move per-pipe ddb allocations into crtc states

First part of cleaning up all of the skl watermark code. This moves the structures for storing the ddb allocations of each pipe into intel_crtc_state, along with moving the structures for storing the current ddb allocations active on hardware into intel_crtc. Signed-off-by: Lyude

[Intel-gfx] [PATCH 0/6] Start of skl watermark cleanup

While it (mostly) works, the code for handling watermarks on Skylake has been kind of ugly for a while. As well a lot of it isn't that friendly to atomic transactions, Lots of copy paste, redundant wm values, etc. While this isn't a full cleanup, it's a good start. As well, we add a couple of

[Intel-gfx] [PATCH 3/6] drm/i915: Add enable_sagv option

This option allows us to manually control the SAGV at module load time. This can be useful in situations such as trying to debug watermark changes, since enabled SAGV + incorrect watermarks = total GPU annihilation. Signed-off-by: Lyude Cc: Maarten Lankhorst

[Intel-gfx] [PATCH 6/6] drm/i915/gen9: Add ddb changes to atomic debug output

Finally, add some debugging output for ddb changes in the atomic debug output. This makes it a lot easier to spot bugs from incorrect ddb allocations. Signed-off-by: Lyude Cc: Maarten Lankhorst Cc: Ville Syrjälä

[Intel-gfx] [PATCH 5/6] drm/i915/gen9: Get rid of redundant watermark values

Now that we've make skl_wm_levels make a little more sense, we can remove all of the redundant wm information. Up until now we'd been storing two copies of all of the skl watermarks: one being the skl_pipe_wm structs, the other being the global wm struct in drm_i915_private containing the raw

Re: [Intel-gfx] [Regression report] Weekly regression report WW40

> > On Mon, 03 Oct 2016, Jairo Miramontes > > wrote: > > > This week regressions > > > > In the past we used "regression", "bisect_pending", and "bisected" in > > the bugzilla "Keywords" field. Can we start using those again, please? > > I think

Re: [Intel-gfx] [PATCH 04/22] drm/i915: Make HAS_DDI and HAS_PCH_LPT_LP only take dev_priv

On Wed, Oct 05, 2016 at 01:33:31PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > This saves 3248 bytes of .rodata strings. > > Signed-off-by: Tvrtko Ursulin > --- > drivers/gpu/drm/i915/i915_drv.h | 8 +++--- >

  1   2   >