Re: [Intel-gfx] [PATCH v7 03/11] drm/i915: return EACCES for check_cmd() failures

On 25 October 2016 at 00:19, Robert Bragg wrote: > check_cmd() is checking whether a command adheres to certain > restrictions that ensure it's safe to execute within a privileged batch > buffer. Returning false implies a privilege problem, not that the > command is invalid.

Re: [Intel-gfx] [PATCH 1/5] drm: Add atomic helper to redo a modeset on current mode

On Tue, Oct 25, 2016 at 03:09:39PM +0300, Jani Nikula wrote: > On Sat, 22 Oct 2016, Manasi Navare wrote: > > This function provides a way for the driver to redo a > > modeset on the current mode and retry the link training > > at a lower link rate/lane count/bpp. This

Re: [Intel-gfx] [PATCH i-g-t 1/3 v2] lib/{igt_sysfs, igt_aux}: Make available to other users kick_fbcon() (unbind_fbcon()), and added helpers to igt_aux.

On Tue, Oct 25, 2016 at 11:44:36PM +0300, Marius Vlad wrote: > +int > +igt_pkill(int sig, const char *comm) > +{ > + int err = 0; > + PROCTAB *proc; > + proc_t *proc_info; > + > + proc = openproc(PROC_FILLCOM | PROC_FILLSTAT | PROC_FILLARG); > + igt_assert(proc != NULL); > + >

Re: [Intel-gfx] [PATCH v7 06/11] drm/i915: Enable i915 perf stream for Haswell OA unit

On 25 October 2016 at 00:19, Robert Bragg wrote: > Gen graphics hardware can be set up to periodically write snapshots of > performance counters into a circular buffer via its Observation > Architecture and this patch exposes that capability to userspace via the > i915 perf

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Release reference from blob lookup after replacing property

== Series Details == Series: drm: Release reference from blob lookup after replacing property URL : https://patchwork.freedesktop.org/series/14357/ State : success == Summary == Series 14357v1 drm: Release reference from blob lookup after replacing property

Re: [Intel-gfx] [PATCH] drm: Release reference from blob lookup after replacing property

On Tue, Oct 25, 2016 at 3:46 PM, Chris Wilson wrote: > drm_property_lookup_blob() returns a reference to the returned blob, and > drm_atomic_replace_property_blob() takes a references to the blob it > stores, so afterwards we are left owning a reference to the new_blob

Re: [Intel-gfx] [PATCH v2] drm/i915/guc: WA to address the Ringbuffer coherency issue

On Tue, Oct 25, 2016 at 10:05:23PM +0530, akash.g...@intel.com wrote: > From: Akash Goel > > Driver accesses the ringbuffer pages, via GMADR BAR, if the pages are > pinned in mappable aperture portion of GGTT and for ringbuffer pages > allocated from Stolen memory, access

[Intel-gfx] [PATCH v2] drm: Release reference from blob lookup after replacing property

From: Felix Monninger drm_property_lookup_blob() returns a reference to the returned blob, and drm_atomic_replace_property_blob() takes a references to the blob it stores, so afterwards we are left owning a reference to the new_blob that we never release, and thus leak

Re: [Intel-gfx] [PATCH 4/8] drm/i915/huc: Add debugfs for HuC loading status check

Tested with HuC version 1.07.1398 on SKL. Reviewed-by: Carlos Santa Tested-by: Carlos Santa On Mon, 2016-10-03 at 11:42 -0700, Anusha Srivatsa wrote: > From: Peter Antoine > > Add debugfs entry for HuC loading status

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915: Rotated view does not need a fence

On Tue, Oct 25, 2016 at 05:40:35PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > We do not need to set up a fence for the rotated view. > > Display does not need it and no one can access it. > > v2: Move code to __i915_vma_set_map_and_fenceable. (Chris

Re: [Intel-gfx] [PATCH] drm: Release reference from blob lookup after replacing property

On Tue, Oct 25, 2016 at 05:27:21PM -0400, Sean Paul wrote: > On Tue, Oct 25, 2016 at 3:46 PM, Chris Wilson > wrote: > > drm_property_lookup_blob() returns a reference to the returned blob, and > > drm_atomic_replace_property_blob() takes a references to the blob it > >

[Intel-gfx] [PATCH] drm: Release reference from blob lookup after replacing property

drm_property_lookup_blob() returns a reference to the returned blob, and drm_atomic_replace_property_blob() takes a references to the blob it stores, so afterwards we are left owning a reference to the new_blob that we never release, and thus leak memory every time we update a property such as

Re: [Intel-gfx] [PATCH v2] drm/i915: fix comment on I915_{READ, WRITE}_FW

On Tue, Oct 25, 2016 at 02:48:02PM +0200, Arkadiusz Hiler wrote: > Comment mentioned use of intel_uncore_forcewake_irq{unlock, lock} > functions which are nonexistent (and never were). > > The description was also incomplete and could cause confusion. Updated > comment is more elaborate on usage

[Intel-gfx] [PATCH v2] drm/i915/dp: Debug log MST active links explicitly

From: "Pandiyan, Dhinakaran" No functional change. Just printing the number of active links without stating what the number means is not very useful. So, add relevant text. v2: Included connector info (Chris) Signed-off-by: Dhinakaran Pandiyan

[Intel-gfx] [PATCH i-g-t 0/3 v2] Convert sh scripts to C variants.

This series adds some library support to help converting sh scripts to C version. Based on that I've converted drv_module_reload_basic and kms_sysfs_edid_timing. Other tests should follow. drv_module_reload requires the most boilerplate code. The reason for so many changes is the fact that some

[Intel-gfx] [PATCH i-g-t 2/3 v2] tests/drv_module_reload: Convert sh script to C version.

v2: - embedded gem_alive and gem_exec_store into test (Chris Wilson) - int main() to igt_main (Chris Wilson) - moved tests/gem_alive -> tools/gem_info (Chris Wilson) - added to intel-ci/fast-feedback.testlist (Petri Latvala) - added hda_dynamic_debug() (Petri Latvala) - renamed from

[Intel-gfx] [PATCH i-g-t 3/3 v3] tests/kms_sysfs_edid_timing: Convert sh to C version.

v2: - don't read cached values (Chris Wilson) - warn on per connector, and fail per mean (Chris Wilson) These are synthetic: 5us per connector, and 600us for all (as threshold). Signed-off-by: Marius Vlad --- tests/Makefile.sources| 2 +-

[Intel-gfx] [PATCH i-g-t 1/3 v2] lib/{igt_sysfs, igt_aux}: Make available to other users kick_fbcon() (unbind_fbcon()), and added helpers to igt_aux.

Previously under unbind_fbcon(), to disable/enable framebuffer console. lib/igt_aux: Added helpers to help convert sh scripts to C version. libkmod and procps interface. v2: - Renamed libkmod helpers (Chris Wilson) - Removed SIGTERM/SIGKILL case where we repeatedly tried to terminate the

Re: [Intel-gfx] [PATCH v7 04/11] drm/i915: don't whitelist oacontrol in cmd parser

On 25 October 2016 at 00:19, Robert Bragg wrote: > Being able to program OACONTROL from a non-privileged batch buffer is > not sufficient to be able to configure the OA unit. This was originally > allowed to help enable Mesa to expose OA counters via the >

[Intel-gfx] [PATCH v3 2/2] drm/i915/dp: BDW cdclk fix for DP audio

According to BSpec, cdclk has to be not less than 432 MHz with DP audio enabled, port width x4, and link rate HBR2 (5.4 GHz) Having a lower cdclk triggers pipe underruns, which then lead to displays continuously cycling off and on. This is essential for DP MST audio as the link is trained at HBR2

[Intel-gfx] [PATCH v3] kms_atomic : Added subtest for Single Pipe DBUF validation

Existing DDB algorithm divide the DDB wrt data rate, hence the planes with the less height but same width will be allocated less blocks and watermark are based on width which requires more DDB. With this data the flip may fail. In new DDB algorithm, the DDB is divided based on watermark

Re: [Intel-gfx] [PATCH v2] drm/i915/dp: Debug log MST active links explicitly

Jim, Please let me know if the R-B is still good. -DK On Tue, 2016-10-25 at 21:37 -0700, Dhinakaran Pandiyan wrote: > From: "Pandiyan, Dhinakaran" > > No functional change. Just printing the number of active links without > stating what the number means is not

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dp: Debug log MST active links explicitly (rev3)

== Series Details == Series: drm/i915/dp: Debug log MST active links explicitly (rev3) URL : https://patchwork.freedesktop.org/series/13627/ State : failure == Summary == Series 13627v3 drm/i915/dp: Debug log MST active links explicitly

Re: [Intel-gfx] [PATCH 1/2] drm: Add a new connector property for link status

On Tue, Oct 25, 2016 at 06:16:34PM -0700, Manasi Navare wrote: > A new optional connector property is added for keeping > track of whether the link is good (link training passed) or > link is bad (link training failed). If the link status property > is Bad, then userspace should fire off a new

[Intel-gfx] [PATCH v3 1/2] drm/i915/dp: Enable DP audio stall fix for gen9 platforms

Enabling DP audio stall fix is necessary to play audio over DP HBR2. So, let's set this bit right before enabling the audio codec. Playing audio without setting this bit results in pipe FIFO underruns. This workaround is applicable only for audio sample rates up to 96kHz. For frequencies above

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/dp: BDW cdclk fix for DP audio

On Tue, 2016-10-25 at 18:19 +, Pandiyan, Dhinakaran wrote: > On Tue, 2016-10-25 at 12:14 +0300, Jani Nikula wrote: > > On Tue, 25 Oct 2016, Jani Nikula wrote: > > > On Tue, 25 Oct 2016, Dhinakaran Pandiyan > > > wrote: > > >> According

[Intel-gfx] fail to build on 32-bit x86 report

http://kisskb.ellerman.id.au/kisskb/buildresult/12840554/ Since the GVT stuff it looks like some divide should be a do_div. Dave. ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 1/2] drm: Add a new connector property for link status

A new optional connector property is added for keeping track of whether the link is good (link training passed) or link is bad (link training failed). If the link status property is Bad, then userspace should fire off a new modeset at the current mode even if there have not been any changes in

[Intel-gfx] [PATCH 2/2] drm/i915: Set link status property for DP connector

The link status connector property is attached to the drm object in DP initialization. This also defines a helper function to set the property value. This will be used to set the link sttaus to Bad in case of link training failures. Cc: dri-de...@lists.freedesktop.org Cc: Jani Nikula

Re: [Intel-gfx] [PATCH v7 06/11] drm/i915: Enable i915 perf stream for Haswell OA unit

On Tue, Oct 25, 2016 at 10:35 PM, Matthew Auld < matthew.william.a...@gmail.com> wrote: > On 25 October 2016 at 00:19, Robert Bragg wrote: > > > diff --git a/drivers/gpu/drm/i915/i915_drv.h > b/drivers/gpu/drm/i915/i915_drv.h > > index 3448d05..ea24814 100644 > > ---

[Intel-gfx] ✓ Fi.CI.BAT: success for DP audio fixes (rev4)

== Series Details == Series: DP audio fixes (rev4) URL : https://patchwork.freedesktop.org/series/14314/ State : success == Summary == Series 14314v4 DP audio fixes https://patchwork.freedesktop.org/api/1.0/series/14314/revisions/4/mbox/ fi-bdw-5557u total:246 pass:231 dwarn:0

Re: [Intel-gfx] [PATCH 5/8] drm/i915/huc: Support HuC authentication

On Mon, 2016-10-03 at 11:42 -0700, Anusha Srivatsa wrote: > From: Peter Antoine > > The HuC authentication is done by host2guc call. The HuC RSA keys > are sent to GuC for authentication. > > v2: rebased on top of drm-intel-nightly. > changed name format and upped

Re: [Intel-gfx] [PATCH 1/2] drm: Add a new connector property for link status

Chris, Would you be able to make the necessary changes in the suerspace driver so I can do some testing tomorrow? Manasi On Tue, Oct 25, 2016 at 06:16:34PM -0700, Manasi Navare wrote: > A new optional connector property is added for keeping > track of whether the link is good (link training

Re: [Intel-gfx] [PATCH v7 06/11] drm/i915: Enable i915 perf stream for Haswell OA unit

On Tue, Oct 25, 2016 at 12:19:29AM +0100, Robert Bragg wrote: > +static int claim_specific_ctx(struct i915_perf_stream *stream) > +{ > + struct drm_i915_private *dev_priv = stream->dev_priv; > + struct i915_vma *vma; > + int ret; > + > + ret =

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915/dp: Enable DP audio stall fix for gen9 platforms

Mixing up git rebase and reset was not a good idea, will send the corrected patch. Please ignore this. On Tue, 2016-10-25 at 16:42 -0700, Dhinakaran Pandiyan wrote: > Enabling DP audio stall fix is necessary to play audio over DP HBR2. So, > let's set this bit right before enabling the audio

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm: Add a new connector property for link status

== Series Details == Series: series starting with [1/2] drm: Add a new connector property for link status URL : https://patchwork.freedesktop.org/series/14374/ State : failure == Summary == Series 14374v1 Series without cover letter

Re: [Intel-gfx] [PATCH 1/5] drm: Add atomic helper to redo a modeset on current mode

On Tue, Oct 25, 2016 at 5:09 AM, Jani Nikula wrote: > On Sat, 22 Oct 2016, Manasi Navare wrote: >> This function provides a way for the driver to redo a >> modeset on the current mode and retry the link training >> at a lower link rate/lane

Re: [Intel-gfx] [PATCH 1/5] drm: Add atomic helper to redo a modeset on current mode

On Mon, Oct 24, 2016 at 02:38:17PM -0400, Sean Paul wrote: > On Mon, Oct 24, 2016 at 3:12 AM, Daniel Vetter wrote: > > On Mon, Oct 24, 2016 at 9:00 AM, Manasi Navare > > wrote: > >>> I guess we just need to do some additional work on top to make sure

Re: [Intel-gfx] [PATCH 2/5] drm: Define a work struct for scheduling a uevent for modeset retry

On Mon, 2016-10-24 at 23:28 -0700, Manasi Navare wrote: > On Sat, Oct 22, 2016 at 10:48:13AM +0200, Daniel Vetter wrote: > > On Fri, Oct 21, 2016 at 04:45:40PM -0700, Manasi Navare wrote: > > > This work struct will be used to schedule a uevent on a separate > > > thread. This will be scheduled

Re: [Intel-gfx] [PATCH] drm/i915: Fix SKL+ 90/270 degree rotated plane coordinate computation

On Mon, Oct 24, 2016 at 07:13:04PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Pass the framebuffer size in .16 fixed point coordinates to > drm_rect_rotate() since that's what the source coordinates are as well > at this stage. We used to

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Link Rate fallback on Link training failure

On Fri, 2016-10-21 at 16:45 -0700, Manasi Navare wrote: > If link training at a link rate optimal for a particular > mode fails during modeset's atomic commit phase, then we > let the modeset complete and then retry. We save the link rate > value at which link training failed and use a lower link

Re: [Intel-gfx] [PATCH v2 1/8] drm/dp: Factor out helper to distinguish between branch and sink devices

On Mon, Oct 24, 2016 at 08:10:46PM +0300, Jani Nikula wrote: > On Mon, 24 Oct 2016, Imre Deak wrote: > > This check is open-coded in a few places, so it makes sense to simplify > > things by having a helper for it similar to the rest of DPCD feature > > helpers. > > > > v2:

Re: [Intel-gfx] [PATCH 2/5] drm: Define a work struct for scheduling a uevent for modeset retry

On Sat, Oct 22, 2016 at 10:48:13AM +0200, Daniel Vetter wrote: > On Fri, Oct 21, 2016 at 04:45:40PM -0700, Manasi Navare wrote: > > This work struct will be used to schedule a uevent on a separate > > thread. This will be scheduled after a link train failure during modeset > > to indicate a

Re: [Intel-gfx] [PATCH 2/5] drm: Define a work struct for scheduling a uevent for modeset retry

On Tue, Oct 25, 2016 at 06:30:29AM +, Pandiyan, Dhinakaran wrote: > On Mon, 2016-10-24 at 23:28 -0700, Manasi Navare wrote: > > On Sat, Oct 22, 2016 at 10:48:13AM +0200, Daniel Vetter wrote: > > > On Fri, Oct 21, 2016 at 04:45:40PM -0700, Manasi Navare wrote: > > > > This work struct will be

Re: [Intel-gfx] [PATCH 1/4] igt_fb: Add Y-tiling support

On Tue, Oct 25, 2016 at 09:06:26AM +0100, Tvrtko Ursulin wrote: > > On 24/10/2016 17:55, Praveen Paneri wrote: > >This adds Y-tiling check in igt_create_fb_with_bo_size as > >now we should also be able to create Y-tiled FBs. > > > >Signed-off-by: Praveen Paneri > >--- >

Re: [Intel-gfx] [PATCH 1/4] igt_fb: Add Y-tiling support

On Tue, Oct 25, 2016 at 09:20:31AM +0100, Tvrtko Ursulin wrote: > > > On 25/10/2016 09:18, Chris Wilson wrote: > >On Tue, Oct 25, 2016 at 09:06:26AM +0100, Tvrtko Ursulin wrote: > >> > >>On 24/10/2016 17:55, Praveen Paneri wrote: > >>>This adds Y-tiling check in igt_create_fb_with_bo_size as >

Re: [Intel-gfx] [PATCH] drm/i915: Fix SKL+ 90/270 degree rotated plane coordinate computation

On Tue, Oct 25, 2016 at 12:39:43PM +0300, Ville Syrjälä wrote: > On Tue, Oct 25, 2016 at 08:20:46AM +0100, Chris Wilson wrote: > > On Mon, Oct 24, 2016 at 07:13:04PM +0300, ville.syrj...@linux.intel.com > > wrote: > > > From: Ville Syrjälä > > > > > > Pass the

Re: [Intel-gfx] [PATCH 1/4] igt_fb: Add Y-tiling support

On 25/10/2016 09:18, Chris Wilson wrote: On Tue, Oct 25, 2016 at 09:06:26AM +0100, Tvrtko Ursulin wrote: On 24/10/2016 17:55, Praveen Paneri wrote: This adds Y-tiling check in igt_create_fb_with_bo_size as now we should also be able to create Y-tiled FBs. Signed-off-by: Praveen Paneri

Re: [Intel-gfx] [PATCH 2/4] lib/igt_draw: Add Y-tiling support

On 24/10/2016 17:55, Praveen Paneri wrote: This patch adds Y-tiling support for igt_draw_rect function. Change-Id: I139e9773b7df286febe9ffa3dce358df079dac14 You can remove (and should) remove Gerrit tags when sending stuff upstream. Regards, Tvrtko Signed-off-by: Praveen Paneri

Re: [Intel-gfx] [PATCH igt] igt: drop gem_storedw_loop from BAT

On Thu, Oct 20, 2016 at 03:18:00PM +0100, Tvrtko Ursulin wrote: > > On 20/10/2016 15:02, Chris Wilson wrote: > > On Thu, Oct 20, 2016 at 02:55:42PM +0100, Tvrtko Ursulin wrote: > > > On 20/10/2016 10:16, Daniel Vetter wrote: > > > > On Thu, Oct 20, 2016 at 09:54:33AM +0100, Chris Wilson wrote: >

Re: [Intel-gfx] [PATCH 1/4] igt_fb: Add Y-tiling support

On 24/10/2016 17:55, Praveen Paneri wrote: This adds Y-tiling check in igt_create_fb_with_bo_size as now we should also be able to create Y-tiled FBs. Signed-off-by: Praveen Paneri --- lib/igt_fb.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[Intel-gfx] [PATCH] drm/i915: Include the kernel uptime in the error state

As well as knowing when the error occurred, it is more interesting to me to know how long after booting the error occurred, and for good measure record the time since last hw initialisation. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_drv.h | 4

Re: [Intel-gfx] [PATCH v2 1/8] drm/dp: Factor out helper to distinguish between branch and sink devices

On Tue, Oct 25, 2016 at 10:46:44AM +0300, Jani Nikula wrote: > On Tue, 25 Oct 2016, Daniel Vetter wrote: > > On Mon, Oct 24, 2016 at 08:10:46PM +0300, Jani Nikula wrote: > >> On Mon, 24 Oct 2016, Imre Deak wrote: > >> > This check is open-coded in a few

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for Support for sustained capturing of GuC firmware logs (rev11)

On 13/10/2016 08:48, Tvrtko Ursulin wrote: On 12/10/2016 19:36, Saarinen, Jani wrote: == Series Details == Series: Support for sustained capturing of GuC firmware logs (rev11) URL : https://patchwork.freedesktop.org/series/7910/ State : warning == Summary == Series 7910v11 Support for

Re: [Intel-gfx] [PATCH] drm/i915: Fix SKL+ 90/270 degree rotated plane coordinate computation

On Tue, Oct 25, 2016 at 08:20:46AM +0100, Chris Wilson wrote: > On Mon, Oct 24, 2016 at 07:13:04PM +0300, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Pass the framebuffer size in .16 fixed point coordinates to > > drm_rect_rotate() since

Re: [Intel-gfx] [PATCH v2 4/8] drm/i915/dp: Print full branch/sink descriptor

On ti, 2016-10-25 at 12:28 +0300, Jani Nikula wrote: > On Mon, 24 Oct 2016, Imre Deak wrote: > > On Mon, 2016-10-24 at 22:10 +0300, Jani Nikula wrote: > > > On Mon, 24 Oct 2016, Imre Deak wrote: > > > > On Mon, 2016-10-24 at 21:14 +0300, Jani Nikula

Re: [Intel-gfx] [PATCH v2 1/8] drm/dp: Factor out helper to distinguish between branch and sink devices

On Tue, 25 Oct 2016, Daniel Vetter wrote: > On Mon, Oct 24, 2016 at 08:10:46PM +0300, Jani Nikula wrote: >> On Mon, 24 Oct 2016, Imre Deak wrote: >> > This check is open-coded in a few places, so it makes sense to simplify >> > things by having a helper for

Re: [Intel-gfx] drm/i915: WARN_ON_ONCE(!crtc_clock || cdclk < crtc_clock)

On Mon, 24 Oct 2016, Paul Bolle wrote: > [Detailed post, but please give it a quick scan.] Please file the information in the bug you filed. Please attach dmesg (again, on the bug) with drm.debug=14 and running your patch. BR, Jani. > > On Wed, 2016-10-12 at 14:06 +0200,

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/dp: BDW cdclk fix for DP audio

On Tue, 25 Oct 2016, Jani Nikula wrote: > On Tue, 25 Oct 2016, Dhinakaran Pandiyan > wrote: >> According to BSpec, cdclk has to be not less than 432 MHz with DP audio >> enabled, port width x4, and link rate HBR2 (5.4 GHz) >> >> Having a

Re: [Intel-gfx] [PATCH v2 4/8] drm/i915/dp: Print full branch/sink descriptor

On Mon, 24 Oct 2016, Imre Deak wrote: > On Mon, 2016-10-24 at 22:10 +0300, Jani Nikula wrote: >> On Mon, 24 Oct 2016, Imre Deak wrote: >> > On Mon, 2016-10-24 at 21:14 +0300, Jani Nikula wrote: >> > > On Mon, 24 Oct 2016, Imre Deak

[Intel-gfx] ✗ Fi.CI.BAT: warning for dma-buf: Rename struct fence to dma_fence

== Series Details == Series: dma-buf: Rename struct fence to dma_fence URL : https://patchwork.freedesktop.org/series/14324/ State : warning == Summary == Series 14324v1 dma-buf: Rename struct fence to dma_fence https://patchwork.freedesktop.org/api/1.0/series/14324/revisions/1/mbox/ Test

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/dp: Enable DP audio stall fix for gen9 platforms

On Tue, 25 Oct 2016, Dhinakaran Pandiyan wrote: > Enabling DP audio stall fix is necessary to play audio over DP HBR2. So, > let's set this bit right before enabling the audio codec. Playing audio > without setting this bit results in pipe FIFO underruns. > >

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/dp: BDW cdclk fix for DP audio

On Mon, Oct 24, 2016 at 09:18:37PM -0700, Dhinakaran Pandiyan wrote: > According to BSpec, cdclk has to be not less than 432 MHz with DP audio > enabled, port width x4, and link rate HBR2 (5.4 GHz) > > Having a lower cdclk triggers pipe underruns, which then lead to displays > continuously

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/dp: BDW cdclk fix for DP audio

On Tue, 25 Oct 2016, Dhinakaran Pandiyan wrote: > According to BSpec, cdclk has to be not less than 432 MHz with DP audio > enabled, port width x4, and link rate HBR2 (5.4 GHz) > > Having a lower cdclk triggers pipe underruns, which then lead to displays >

[Intel-gfx] [PATCH v2] kms_atomic : Added subtest for Single Pipe DBUF validation

Existing DDB algorithm divide the DDB wrt data rate, hence the planes with the less height but same width will be allocated less blocks and watermark are based on width which requires more DDB. With this data the flip may fail. In new DDB algorithm, the DDB is divided based on watermark

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Include the kernel uptime in the error state

== Series Details == Series: drm/i915: Include the kernel uptime in the error state URL : https://patchwork.freedesktop.org/series/14320/ State : failure == Summary == Series 14320v1 drm/i915: Include the kernel uptime in the error state

Re: [Intel-gfx] [PATCH v2] kms_atomic : Added subtest for Single Pipe DBUF validation

On Tue, Oct 25, 2016 at 02:40:00PM +0530, meghanelogal wrote: > + igt_subtest("validate_dbuf") { > + int gen; > + > + gen = intel_gen(intel_get_drm_devid(desc.fd)); > + igt_require(gen >= 9); > + > + struct kms_atomic_state *scratch =

[Intel-gfx] External intel-gfx-ci results site http://intel-gfx-ci.01.org/CI/

Sending behalf of Tomi. --- Hello all, History of CI i-g-t runs for drm-intel-nightly is now available at https://intel-gfx-ci.01.org/CI/ The full results for Patchwork / Trybot CI runs are also available. Text summary will still be uploaded to patchwork for projects

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Remove two invalid warns

On Tue, Oct 25, 2016 at 03:12:51PM +0100, Tvrtko Ursulin wrote: > > On 25/10/2016 15:09, Chris Wilson wrote: > >On Tue, Oct 25, 2016 at 03:00:24PM +0100, Tvrtko Ursulin wrote: > >>From: Tvrtko Ursulin > >> > >>Objects can have multiple VMAs used for display in which >

Re: [Intel-gfx] [PATCH v3 4/8] drm/i915/dp: Print full branch/sink descriptor

On Tue, 25 Oct 2016, Imre Deak wrote: > Extend the branch/sink descriptor info with the missing device ID > field. While at it also read out all the descriptor registers in one > transfer and make the debug print more compact. > > v2: (Jani) > - Cache the descriptor in

Re: [Intel-gfx] [PATCH] drm/i915: Include the kernel uptime in the error state

On 25 October 2016 at 09:16, Chris Wilson wrote: > As well as knowing when the error occurred, it is more interesting to me > to know how long after booting the error occurred, and for good measure > record the time since last hw initialisation. > > Signed-off-by: Chris

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Link Rate fallback on Link training failure

On Sat, 22 Oct 2016, Manasi Navare wrote: > If link training at a link rate optimal for a particular > mode fails during modeset's atomic commit phase, then we > let the modeset complete and then retry. We save the link rate > value at which link training failed and use

[Intel-gfx] ✓ Fi.CI.BAT: success for dma-buf: Rename struct fence to dma_fence (rev2)

== Series Details == Series: dma-buf: Rename struct fence to dma_fence (rev2) URL : https://patchwork.freedesktop.org/series/14324/ State : success == Summary == Series 14324v2 dma-buf: Rename struct fence to dma_fence https://patchwork.freedesktop.org/api/1.0/series/14324/revisions/2/mbox/

[Intel-gfx] [PATCH v3 4/8] drm/i915/dp: Print full branch/sink descriptor

Extend the branch/sink descriptor info with the missing device ID field. While at it also read out all the descriptor registers in one transfer and make the debug print more compact. v2: (Jani) - Cache the descriptor in intel_dp. - Split out this change into a separate patch. v3: (Jani) - Fix

[Intel-gfx] [PATCH 1/2] drm/i915: Rotated view does not need a fence

From: Tvrtko Ursulin We do not need to set up a fence for the rotated view. Display does not need it and no one can access it. Signed-off-by: Tvrtko Ursulin Cc: Chris Wilson Cc: Joonas Lahtinen

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: fix comment on I915_{READ,WRITE}_FW (rev2)

> == Series Details == > > Series: drm/i915: fix comment on I915_{READ,WRITE}_FW (rev2) > URL : https://patchwork.freedesktop.org/series/14334/ > State : failure > > == Summary == > > Series 14334v2 drm/i915: fix comment on I915_{READ,WRITE}_FW >

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Remove two invalid warns

On 25/10/2016 15:09, Chris Wilson wrote: On Tue, Oct 25, 2016 at 03:00:24PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Objects can have multiple VMAs used for display in which case assertion that objects must not be pinned for display more times than their

[Intel-gfx] drm/i915/audio: m/n value fixes

Remaining patch from https://patchwork.freedesktop.org/series/12754/ plus a cleanup. BR, Jani. ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 1/2] drm/i915/audio: drop extra crtc clock check from HDMI audio N lookup

The array contains the crtc clock, rely on that. While at it, debug log the HDMI N value or automatic mode. Cc: Ville Syrjälä Cc: "Lin, Mengdong" Cc: Libin Yang Signed-off-by: Jani Nikula

[Intel-gfx] [PATCH 2/2] drm/i915: Remove two invalid warns

From: Tvrtko Ursulin Objects can have multiple VMAs used for display in which case assertion that objects must not be pinned for display more times than their single display related VMA is incorrect. Signed-off-by: Tvrtko Ursulin Cc: Chris

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Remove two invalid warns

On Tue, Oct 25, 2016 at 03:00:24PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Objects can have multiple VMAs used for display in which > case assertion that objects must not be pinned for display > more times than their single display related VMA is

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Remove two invalid warns

On 25/10/2016 15:12, Tvrtko Ursulin wrote: On 25/10/2016 15:09, Chris Wilson wrote: On Tue, Oct 25, 2016 at 03:00:24PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Objects can have multiple VMAs used for display in which case assertion that objects must not

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Rotated view does not need a fence

On 25/10/2016 15:12, Ville Syrjälä wrote: On Tue, Oct 25, 2016 at 03:00:23PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin We do not need to set up a fence for the rotated view. Display does not need it and no one can access it. Signed-off-by: Tvrtko Ursulin

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/lspcon: Work around resume failure (rev2)

== Series Details == Series: drm/i915/lspcon: Work around resume failure (rev2) URL : https://patchwork.freedesktop.org/series/14280/ State : warning == Summary == Series 14280v2 drm/i915/lspcon: Work around resume failure

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Rotated view does not need a fence

On Tue, Oct 25, 2016 at 03:00:23PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > We do not need to set up a fence for the rotated view. > > Display does not need it and no one can access it. See __i915_vma_set_map_and_fenceable. Stop the bit at source. And

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Rotated view does not need a fence

On Tue, Oct 25, 2016 at 03:17:09PM +0100, Chris Wilson wrote: > On Tue, Oct 25, 2016 at 05:12:22PM +0300, Ville Syrjälä wrote: > > On Tue, Oct 25, 2016 at 03:00:23PM +0100, Tvrtko Ursulin wrote: > > > From: Tvrtko Ursulin > > > > > > We do not need to set up a fence for

[Intel-gfx] [PATCH 2/2] drm/i915/audio: set proper N/M in modeset

From: Libin Yang When modeset occurs and the LS_CLK is set to some special values in DP mode, the N/M need to be set manually if audio is playing. Otherwise the first several seconds may be silent in audio playback. The relationship of Maud and Naud is expressed in

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: fix comment on I915_{READ,WRITE}_FW (rev2)

On Tue, Oct 25, 2016 at 04:27:26PM +0200, Saarinen, Jani wrote: > > == Series Details == > > > > Series: drm/i915: fix comment on I915_{READ,WRITE}_FW (rev2) > > URL : https://patchwork.freedesktop.org/series/14334/ > > State : failure > > > > == Summary == > > > > Series 14334v2 drm/i915:

Re: [Intel-gfx] [PATCH 1/4] igt_fb: Add Y-tiling support

> So when you say that all Y tiling tests fail without this kernel hack, which > tests you are referring to? If I revert this IGT patch and do not make below kernel change, kms_draw_crc (ytiled cases, last patch in this series) fail with following error. Test assertion failure function

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: fix comment on I915_{READ,WRITE}_FW (rev2)

== Series Details == Series: drm/i915: fix comment on I915_{READ,WRITE}_FW (rev2) URL : https://patchwork.freedesktop.org/series/14334/ State : failure == Summary == Series 14334v2 drm/i915: fix comment on I915_{READ,WRITE}_FW

Re: [Intel-gfx] [PATCH] drm/i915: Fix SKL+ 90/270 degree rotated plane coordinate computation

On 24/10/2016 17:13, ville.syrj...@linux.intel.com wrote: From: Ville Syrjälä Pass the framebuffer size in .16 fixed point coordinates to drm_rect_rotate() since that's what the source coordinates are as well at this stage. We used to do this part of the

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Rotated view does not need a fence

On Tue, Oct 25, 2016 at 03:00:23PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > We do not need to set up a fence for the rotated view. > > Display does not need it and no one can access it. > > Signed-off-by: Tvrtko Ursulin > Cc:

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Rotated view does not need a fence

On Tue, Oct 25, 2016 at 05:12:22PM +0300, Ville Syrjälä wrote: > On Tue, Oct 25, 2016 at 03:00:23PM +0100, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > > > We do not need to set up a fence for the rotated view. > > > > Display does not need it and no one can

Re: [Intel-gfx] [PATCH v2 4/8] drm/i915/dp: Print full branch/sink descriptor

On Tue, 25 Oct 2016, Imre Deak wrote: > On ti, 2016-10-25 at 12:28 +0300, Jani Nikula wrote: >> On Mon, 24 Oct 2016, Imre Deak wrote: >> > On Mon, 2016-10-24 at 22:10 +0300, Jani Nikula wrote: >> > > On Mon, 24 Oct 2016, Imre Deak

Re: [Intel-gfx] [PATCH 1/5] drm: Add atomic helper to redo a modeset on current mode

On Sat, 22 Oct 2016, Manasi Navare wrote: > This function provides a way for the driver to redo a > modeset on the current mode and retry the link training > at a lower link rate/lane count/bpp. This will get called > incase the link training fails during the current

[Intel-gfx] [CI] drm/i915: Include the kernel uptime in the error state

As well as knowing when the error occurred, it is more interesting to me to know how long after booting the error occurred, and for good measure record the time since last hw initialisation. Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld

[Intel-gfx] [PATCH] drm/i915: fix comment on I915_{READ,WRITE}_FW

Comment mentioned use of intel_uncore_forcewake_irq{unlock, lock} functions which are nonexistent (and never were). The description was also incomplete and could cause confusion. Updated comment is more elaborate on usage and caveats. Cc: Chris Wilson Cc: Matthew Auld

Re: [Intel-gfx] [RESEND PATCH 2/6] drm/i915: Pass atomic state to intel_audio_codec_enable

Op 24-10-16 om 13:41 schreef Ville Syrjälä: > On Mon, Oct 24, 2016 at 12:47:21PM +0200, Maarten Lankhorst wrote: >> Op 24-10-16 om 12:17 schreef Ville Syrjälä: >>> On Mon, Oct 24, 2016 at 12:12:59PM +0200, Maarten Lankhorst wrote: Op 24-10-16 om 12:04 schreef Ville Syrjälä: > On Mon, Oct

Re: [Intel-gfx] [PATCH] drm/i915: fix comment on I915_{READ, WRITE}_FW

On Tue, Oct 25, 2016 at 02:15:23PM +0200, Arkadiusz Hiler wrote: > Comment mentioned use of intel_uncore_forcewake_irq{unlock, lock} > functions which are nonexistent (and never were). > > The description was also incomplete and could cause confusion. Updated > comment is more elaborate on usage

Re: [Intel-gfx] [PATCH] drm/i915: fix comment referencing imaginary functions

> These are untraced mmio-accessors that are only valid to be used inside > critical sections inside IRQ handlers where forcewake is explicitly > controlled. > > Think twice, and think again, before using these. > > Those possibly should be used between: > > spin_lock_irq(_priv->uncore.lock); >

  1   2   >