Re: [Intel-gfx] [PATCH 3/8] drm/i915/huc: Add HuC fw loading support

2016-12-01 Thread Tvrtko Ursulin
Hi, On 30/11/2016 23:31, Anusha Srivatsa wrote: The HuC loading process is similar to GuC. The intel_uc_fw_fetch() is used for both cases. HuC loading needs to be before GuC loading. The WOPCM setting must be done early before loading any of them. v2: rebased on-top of drm-intel-nightly.

[Intel-gfx] [PATCH v7 7/8] drm/i915: Decode system memory bandwidth

2016-12-01 Thread Mahesh Kumar
This patch adds support to decode system memory bandwidth which will be used for arbitrated display memory percentage calculation in GEN9 based system. Changes from v1: - Address comments from Paulo - implement decode function for SKL/KBL also Changes from v2: - Rewrite the code as per HW team

[Intel-gfx] [PATCH v7 5/8] drm/i915/skl+: change WM calc to fixed point 16.16

2016-12-01 Thread Mahesh Kumar
This patch changes Watermak calculation to fixed point calculation. Problem with current calculation is during plane_blocks_per_line calculation we divide intermediate blocks with min_scanlines and takes floor of the result because of integer operation. hence we end-up assigning less blocks than

[Intel-gfx] [PATCH v7 4/8] drm/i915/bxt: Enable IPC support

2016-12-01 Thread Mahesh Kumar
This patch adds IPC support for platforms. This patch enables IPC only for BXT/KBL platform as for SKL recommendation is to keep is disabled. IPC (Isochronous Priority Control) is the hardware feature, which dynamically controles the memory read priority of Display. When IPC is enabled, plane

[Intel-gfx] [PATCH v7 0/8] GEN-9 Arbitrated Bandwidth WM WA's & IPC

2016-12-01 Thread Mahesh Kumar
This series implements following set of functionality Implement IPC WA's for Broxton/KBL Enable IPC in supported platforms Convert WM calculation to fixed point calculation Calculation of System memory Bandwidth for SKL/KBL/BXT Implementation of Arbitrated

[Intel-gfx] [PATCH v7 1/8] drm/i915/skl: Add variables to check x_tile and y_tile

2016-12-01 Thread Mahesh Kumar
This patch adds variable to check for X_tiled & y_tiled planes, instead of always checking against framebuffer-modifiers. Changes: - Created separate patch as per Paulo's comment - Added x_tiled variable as well Changes since V2: - Incorporate Paulo's comments - Rebase Signed-off-by: Mahesh

[Intel-gfx] [PATCH i-g-t 3/3] tests/gem_reset_stats: Add test to check client bans

2016-12-01 Thread Mika Kuoppala
Client will get banned from creating new context if it has managed to get > 3 context banned. Signed-off-by: Mika Kuoppala --- tests/gem_reset_stats.c | 47 ++- 1 file changed, 42 insertions(+), 5 deletions(-) diff --git

[Intel-gfx] [PATCH i-g-t 1/3] tests/gem_reset_stats: Change pending/active assertions

2016-12-01 Thread Mika Kuoppala
Now that we replay the non guilty contexts and always replay the default ctx, even when guilty, the assumptions of how many active and pending batches there was in the time of reset has changed. Driver doesn't increment pending counts for contexts that it considered unaffected by reset. Because

[Intel-gfx] [PATCH i-g-t 2/3] tests/gem_reset_stats: test no progress detection

2016-12-01 Thread Mika Kuoppala
If seqno is not incrementing but head is moving, we declare hang but much slower. Add test to check that this mechanism is working properly. Signed-off-by: Mika Kuoppala --- tests/gem_reset_stats.c | 75 + 1 file changed,

Re: [Intel-gfx] [PATCH i-g-t 3/3] tests/gem_reset_stats: Add test to check client bans

2016-12-01 Thread Chris Wilson
On Thu, Dec 01, 2016 at 03:31:45PM +0200, Mika Kuoppala wrote: > Client will get banned from creating new context > if it has managed to get > 3 context banned. I'm not thrilled about baking that magic number into an ABI requirement. Just make it N bans, test timing out after say 120s of

Re: [Intel-gfx] [PATCH 11/15] drm/i915: Protect DSPARB registers with a spinlock

2016-12-01 Thread Maarten Lankhorst
Op 01-12-16 om 14:13 schreef Ville Syrjälä: > On Thu, Dec 01, 2016 at 12:56:16PM +0100, Maarten Lankhorst wrote: >> Op 28-11-16 om 18:37 schreef ville.syrj...@linux.intel.com: >>> From: Ville Syrjälä >>> >>> Each DSPARB register can house bits for two separate

[Intel-gfx] ✗ Fi.CI.BAT: warning for GEM object create and driver init dev_priv cleanups (rev2)

2016-12-01 Thread Patchwork
== Series Details == Series: GEM object create and driver init dev_priv cleanups (rev2) URL : https://patchwork.freedesktop.org/series/16162/ State : warning == Summary == Series 16162v2 GEM object create and driver init dev_priv cleanups

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/lspcon: Enable AUX interrupts for resume time initialization (rev2)

2016-12-01 Thread Imre Deak
On ti, 2016-11-29 at 21:53 +, Patchwork wrote: > == Series Details == > > Series: drm/i915/lspcon: Enable AUX interrupts for resume time initialization > (rev2) > URL   : https://patchwork.freedesktop.org/series/16106/ > State : success > > == Summary == > > Series 16106v2 drm/i915/lspcon:

[Intel-gfx] [PATCH v7 2/8] drm/i915/bxt: IPC WA for Broxton

2016-12-01 Thread Mahesh Kumar
Display Workarounds #1135 If IPC is enabled in BXT, display underruns are observed. WA: The Line Time programmed in the WM_LINETIME register should be half of the actual calculated Line Time. Programmed Line Time = 1/2*Calculated Line Time Changes since V1: - Add Workaround number in commit &

[Intel-gfx] [PATCH v7 6/8] drm/i915: Add intel_atomic_get_existing_crtc_state function

2016-12-01 Thread Mahesh Kumar
This patch Adds a function to extract intel_crtc_state from the atomic_state, if not available it returns NULL. Signed-off-by: Mahesh Kumar Reviewed-by: Paulo Zanoni --- drivers/gpu/drm/i915/intel_drv.h | 14 ++ 1 file changed, 14

[Intel-gfx] [PATCH v7 8/8] drm/i915/gen9: WM memory bandwidth related workaround

2016-12-01 Thread Mahesh Kumar
This patch implemnets Workariunds related to display arbitrated memory bandwidth. These WA are applicabe for all gen-9 based platforms. Changes since v1: - Rebase on top of Paulo's patch series Changes since v2: - Address review comments - Rebase/rework as per other patch changes in series

[Intel-gfx] [PATCH v7 3/8] drm/i915/kbl: IPC workaround for kabylake

2016-12-01 Thread Mahesh Kumar
Display Workarounds #1141 IPC (Isoch Priority Control) may cause underflows. KBL WA: When IPC is enabled, watermark latency values must be increased by 4us across all levels. This brings level 0 up to 6us. Changes since V1: - Add Workaround number in commit & code Signed-off-by: Mahesh Kumar

[Intel-gfx] [PATCH 02/10] drm/i915: Make GEM object create and create from data take dev_priv

2016-12-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Makes all GEM object constructors consistent. v2: Fix compilation in GVT code. Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson (v1) Reviewed-by: Joonas Lahtinen

[Intel-gfx] [PATCH 01/10] drm/i915: Make GEM object alloc/free and stolen created take dev_priv

2016-12-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Where it is more appropriate and also to be consistent with the direction of the driver. v2: Leave out object alloc/free inlining. (Joonas Lahtinen) Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson

[Intel-gfx] [PATCH v2 00/10] GEM object create and driver init dev_priv cleanups

2016-12-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Autumn of churn continues. :) This series tidies GEM object construction to take dev_priv instead of dev in all cases and also does a bit of random tidy in the driver load/init code. Basically functions which only need dev_priv are changed to take

[Intel-gfx] [PATCH 07/10] drm/i915: Make gmbus setup take dev_priv

2016-12-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Simplify the code by passing the right argument in. v2: Commit message. (Joonas Lahtinen) Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson Reviewed-by: Joonas Lahtinen

[Intel-gfx] [PATCH 04/10] drm/i915: More GEM init dev_priv cleanup

2016-12-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Simplifies the code to pass the right parameter in. v2: Commit message. (Joonas Lahtinen) Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson Reviewed-by: Joonas Lahtinen

Re: [Intel-gfx] [PATCH 1/2] drm/i915/dsi: Fix swapping of MIPI_SEQ_DEASSERT_RESET / MIPI_SEQ_ASSERT_RESET

2016-12-01 Thread Hans de Goede
Hi, On 29-11-16 14:06, Hans de Goede wrote: p.s. I'm also trying to come up with some patches which properly integrate pwm-lpss with the i915 driver instead of it throwing a "Failed to own the pwm chip" error. But as soon as I hook up things so that pwm_get() returns the pwm-lpss pwm0 I

[Intel-gfx] [PATCH 09/10] drm/i915: Make i915_save/restore_state and intel_i2c_reset take dev_priv

2016-12-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin dev_priv is more appropriate since it is used much more in these. v2: Commit message and keep the local pdev variable. (Joonas Lahtinen) Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson

Re: [Intel-gfx] [PATCH i-g-t 2/3] tests/gem_reset_stats: test no progress detection

2016-12-01 Thread Chris Wilson
On Thu, Dec 01, 2016 at 03:31:44PM +0200, Mika Kuoppala wrote: > If seqno is not incrementing but head is moving, > we declare hang but much slower. Add test to check > that this mechanism is working properly. > > Signed-off-by: Mika Kuoppala > --- >

Re: [Intel-gfx] [PATCH 12/15] drm/i915: Zero out HOWM registers before writing new WM/HOWM register values

2016-12-01 Thread Maarten Lankhorst
Op 28-11-16 om 18:37 schreef ville.syrj...@linux.intel.com: > From: Ville Syrjälä > > On VLV/CHV some of the watermark values are split across two registers: > low order bits in one, and high order bits in another. So we may not be > able to update a single

[Intel-gfx] [PATCH] drm/i915/dsi: Do not clear DPOUNIT_CLOCK_GATE_DISABLE from vlv_init_display_clock_gating

2016-12-01 Thread Hans de Goede
On my Cherrytrail CUBE iwork8 Air tablet PIPE-A would get stuck on loading i915 at boot 1 out of every 3 boots, resulting in a non functional LCD. Once the i915 driver has successfully loaded, the panel can be disabled / enabled without hitting this issue. The getting stuck is caused by

[Intel-gfx] [PATCH 05/10] drm/i915: dev_priv cleanup in bridge/bar/mmio init code

2016-12-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin dev_priv is more appropriate for these so converting saves some lines of source. v2: Commit message and keep the pdev local variable. (Joonas Lahtinen) Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson

Re: [Intel-gfx] [PATCH i-g-t 1/3] tests/gem_reset_stats: Change pending/active assertions

2016-12-01 Thread Chris Wilson
How about a patch 0 to enable hang testing contexts on all rings now? Then exploration of how one ring affects another... You will want to use busy batches to load the engines without hanging, that will be tricky... On Thu, Dec 01, 2016 at 03:31:43PM +0200, Mika Kuoppala wrote: > Now that we

[Intel-gfx] [PATCH 10/10] drm/i915: Make intel_pm_setup take dev_priv

2016-12-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Function actually wants dev_priv so give it to it. v2: Commit message. (Joonas Lahtinen) Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson Reviewed-by: Joonas Lahtinen

[Intel-gfx] [PATCH 03/10] drm/i915: Make various init functions take dev_priv

2016-12-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Like GEM init, GUC init, MOCS init and context creation. Enables them to lose dev_priv locals. Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson Reviewed-by: Joonas Lahtinen

[Intel-gfx] [PATCH 08/10] drm/i915: Make i915_destroy_error_state take dev_priv

2016-12-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Since it does not need dev at all. Also change the stored pointer in struct i915_error_state_file_priv to i915. Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson Reviewed-by: Joonas

[Intel-gfx] [PATCH 06/10] drm/i915: Unexport VGA switcheroo functions

2016-12-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin They are only used in i915_drv.c so a forward declaration is enough. Signed-off-by: Tvrtko Ursulin Reviewed-by: Chris Wilson Reviewed-by: Joonas Lahtinen ---

Re: [Intel-gfx] [PATCH 15/15] drm/i915: Pass crtc state to vlv_compute_wm_level()

2016-12-01 Thread Maarten Lankhorst
Op 28-11-16 om 18:37 schreef ville.syrj...@linux.intel.com: > From: Ville Syrjälä > > Rather than accessing crtc->config in vlv_compute_wm_level() let's > pass in the crtc state explicitly. One step closer to atomic. > > Signed-off-by: Ville Syrjälä

Re: [Intel-gfx] 4.8.6, NULL pointer in __wake_up_common / drm / i915

2016-12-01 Thread Olaf Hering
On Wed, Nov 16, Olaf Hering wrote: > During boot into a current openSUSE Tumbleweed 20161108 this laptop > starts to hang sometimes with 4.8.x. Today I was able to catch this > crash in __wake_up_common caused by i915 or drm or whatever: > > ... > [ 69.851635] BUG: unable to handle kernel

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Enable dynamic debug for DRM_[DEV]_DEBUG*

2016-12-01 Thread Patchwork
== Series Details == Series: drm: Enable dynamic debug for DRM_[DEV]_DEBUG* URL : https://patchwork.freedesktop.org/series/16235/ State : success == Summary == Series 16235v1 drm: Enable dynamic debug for DRM_[DEV]_DEBUG*

[Intel-gfx] ✓ Fi.CI.BAT: success for GEN-9 Arbitrated Bandwidth WM WA's & IPC (rev3)

2016-12-01 Thread Patchwork
== Series Details == Series: GEN-9 Arbitrated Bandwidth WM WA's & IPC (rev3) URL : https://patchwork.freedesktop.org/series/15562/ State : success == Summary == Series 15562v3 GEN-9 Arbitrated Bandwidth WM WA's & IPC https://patchwork.freedesktop.org/api/1.0/series/15562/revisions/3/mbox/

Re: [Intel-gfx] [PATCH 02/10] drm/i915: Make GEM object create and create from data take dev_priv

2016-12-01 Thread Chris Wilson
On Thu, Dec 01, 2016 at 02:16:37PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Makes all GEM object constructors consistent. > > v2: Fix compilation in GVT code. > > Signed-off-by: Tvrtko Ursulin > Reviewed-by: Chris Wilson

Re: [Intel-gfx] [PATCH 05/10] drm/i915: dev_priv cleanup in bridge/bar/mmio init code

2016-12-01 Thread Chris Wilson
On Thu, Dec 01, 2016 at 02:16:40PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > dev_priv is more appropriate for these so converting saves > some lines of source. > > v2: Commit message and keep the pdev local variable. (Joonas Lahtinen) > > Signed-off-by:

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for GEM object create and driver init dev_priv cleanups (rev2)

2016-12-01 Thread Tvrtko Ursulin
On 01/12/2016 14:45, Patchwork wrote: == Series Details == Series: GEM object create and driver init dev_priv cleanups (rev2) URL : https://patchwork.freedesktop.org/series/16162/ State : warning == Summary == Series 16162v2 GEM object create and driver init dev_priv cleanups

[Intel-gfx] [PATCH] drm/i915/perf: use DRM_DEBUG for userspace issues

2016-12-01 Thread Robert Bragg
Avoid using DRM_ERROR for conditions userspace can trigger with a bad config when opening a stream or from not reading data in a timely fashion (whereby the OA buffer fills up). These conditions are tested by i-g-t which treats error messages as failures if using the test runner. This wasn't an

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/perf: use DRM_DEBUG for userspace issues

2016-12-01 Thread Patchwork
== Series Details == Series: drm/i915/perf: use DRM_DEBUG for userspace issues URL : https://patchwork.freedesktop.org/series/16236/ State : success == Summary == Series 16236v1 drm/i915/perf: use DRM_DEBUG for userspace issues

[Intel-gfx] [RFC] drm: Enable dynamic debug for DRM_[DEV]_DEBUG*

2016-12-01 Thread Robert Bragg
I'm currently considering the use of DRM_ERROR in i915 perf for steam config validation errors (i.e. userspace misconfigurations) that should be changed so that i-g-t tests aren't treated as failures when triggering these. I initially proposed changing these to DRM_INFO messages and intentionally

Re: [Intel-gfx] [PATCH 1/3] drm: Add a new connector atomic property for link status

2016-12-01 Thread Manasi Navare
Sean, could you please review this patch, I have tried to address all the comments from you. Regards Manasi On Tue, Nov 29, 2016 at 11:30:31PM -0800, Manasi Navare wrote: > At the time userspace does setcrtc, we've already promised the mode > would work. The promise is based on the theoretical

Re: [Intel-gfx] [PATCH 1/3] drm: Add a new connector atomic property for link status

2016-12-01 Thread Sean Paul
On Thu, Dec 1, 2016 at 1:58 PM, Manasi Navare wrote: > Sean, could you please review this patch, I have tried to address > all the comments from you. > Comments look good to me. Reviewed-by: Sean Paul Sean > Regards > Manasi > > On Tue, Nov

[Intel-gfx] [drm-intel:drm-intel-next-queued 3/10] htmldocs: drivers/gpu/drm/i915/intel_guc_loader.c:779: warning: No description found for parameter 'dev_priv'

2016-12-01 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm-intel drm-intel-next-queued head: 192aa18142b28fdcb63b12984e02466ced382a54 commit: bf9e8429ab9747f584e692bad52a7a9f1787a4da [3/10] drm/i915: Make various init functions take dev_priv reproduce: make htmldocs All warnings (new ones prefixed by >>):

[Intel-gfx] [PATCH 07/18] drm/i915/dsi: Move intel_dsi_clear_device_ready()

2016-12-01 Thread Hans de Goede
Move the intel_dsi_clear_device_ready() function to higher up in intel_dsi.c this pairs it with intel_dsi_device_ready(); and pairs intel_dsi_*enable* with intel_dsi_*disable without intel_dsi_clear_device_ready() sitting in the middle of them. This commit purely moves code around, it does not

[Intel-gfx] [PATCH 09/18] drm/i915/dsi: Make intel_dsi_enable/disable directly exec VBT sequences

2016-12-01 Thread Hans de Goede
The drm_panel_enable/disable and drm_panel_prepare/unprepare calls are not fine grained enough to abstract all the different steps we need to take (and VBT sequences we need to exec) properly. So simply remove the panel _enable/disable and prepare/unprepare callbacks and instead export

[Intel-gfx] [PATCH 04/18] drm/i915/dsi: Merge intel_dsi_disable/enable into their respective callers

2016-12-01 Thread Hans de Goede
intel_dsi_disable/enable only have one caller, merge them into their respective callers. Change msleep(2) into usleep_range(2000, 5000) to make checkpatch happy, otherwise no funtional changes. The main advantage of this change is that it makes it easier to follow all the steps of the panel

[Intel-gfx] [PATCH 05/18] drm/i915/dsi: Add intel_dsi_unprepare() helper

2016-12-01 Thread Hans de Goede
The enable path has an intel_dsi_prepare() helper which prepares various registers for the mode-set. Move the function undoing this to a new intel_dsi_unprepare() helper for better symmetry between the enable and disable paths. No functional changes. Signed-off-by: Hans de Goede

Re: [Intel-gfx] linux-next: problems fetching the drm-intel, etc trees

2016-12-01 Thread Stephen Rothwell
Hi Daniel, On Thu, 01 Dec 2016 11:02:26 + Daniel Stone wrote: > > On Nov 30 2016, at 10:49 pm, Rob Clark wrote: > > > yeah, {cgit,anongit}.fd.o have been having problems all day.. (the ssh > git urls for folks who have push access work

[Intel-gfx] [PATCH 11/18] drm/i915/dsi: Move MIPI_SEQ_POWER_ON/OFF calls together with pmic gpio calls

2016-12-01 Thread Hans de Goede
Now that we are no longer bound to the drm_panel_ callbacks, call MIPI_SEQ_POWER_ON/OFF at the proper place. Signed-off-by: Hans de Goede --- drivers/gpu/drm/i915/intel_dsi.c | 10 -- 1 file changed, 4 insertions(+), 6 deletions(-) diff --git

[Intel-gfx] [PATCH 06/18] drm/i915/dsi: Move disable pll call outside of clear_device_ready()

2016-12-01 Thread Hans de Goede
On enable intel_dsi_enable() directly calls intel_enable_dsi_pll(), make intel_dsi_disable() also directly call intel_disable_dsi_pll(), rather then hiding the call in intel_dsi_clear_device_ready(), no functional changes. Signed-off-by: Hans de Goede ---

[Intel-gfx] [PATCH 10/18] drm/i915/dsi: Drop bogus MIPI_SEQ_ASSERT_RESET before POWER_ON

2016-12-01 Thread Hans de Goede
MIPI_SEQ_ASSERT_RESET before POWER_ON is not necessary for 2 reasons: 1) The reset should already be asserted before intel_dsi_pre_enable() gets called 2) Most (some?) VBTs will ensure reset was asserted in their MIPI_SEQ_DEASSERT_RESET themselves Signed-off-by: Hans de Goede

[Intel-gfx] [PATCH 12/18] drm/i915/dsi: Group DPOunit clock gate workaround with PLL enable

2016-12-01 Thread Hans de Goede
Move the DPOunit clock gate workaround to directly after the PLL enable. The exact location of the workaround does not matter and there are 2 reasons to group it with the PLL enable: 1) This moves it out of the middle of the init sequence from the spec, making it easier to follow the init

[Intel-gfx] [PATCH 15/18] drm/i915/dsi: Document always using v3 SHUTDOWN / MIPI_SEQ_DISPLAY_OFF order

2016-12-01 Thread Hans de Goede
According to the spec for v2 VBTs we should call MIPI_SEQ_DISPLAY_OFF before sending SHUTDOWN, where as for v3 VBTs we should send SHUTDOWN first. Since the v2 order has known issues, we use the v3 order everywhere, add a comment documenting this. Signed-off-by: Hans de Goede

[Intel-gfx] [PATCH 17/18] drm/i915/dsi: Call MIPI_SEQ_TEAR_ON and DISPLAY_ON for cmd-mode (untested)

2016-12-01 Thread Hans de Goede
According to the spec we should call MIPI_SEQ_TEAR_ON and DISPLAY_ON on enable for cmd-mode, just like we already call their counterparts on disable. Note: untested, my panel is a vid-mode panel. Signed-off-by: Hans de Goede --- drivers/gpu/drm/i915/intel_dsi.c | 2 ++ 1

[Intel-gfx] [PATCH 16/18] drm/i915/dsi: Execute MIPI_SEQ_TEAR_OFF from intel_dsi_post_disable

2016-12-01 Thread Hans de Goede
For v3 VBTs we should call MIPI_SEQ_TEAR_OFF before MIPI_SEQ_DISPLAY_OFF, for non v3 VBTs this is a nop. Signed-off-by: Hans de Goede --- drivers/gpu/drm/i915/intel_dsi.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/i915/intel_dsi.c

[Intel-gfx] [PATCH 14/18] drm/i915/dsi: Group MIPI_SEQ_BACKLIGHT_ON/OFF with panel_[en|dis]able_backlight

2016-12-01 Thread Hans de Goede
Execute the MIPI_SEQ_BACKLIGHT_ON/OFF VBT sequences at the same time as we call intel_panel_enable_backlight() / intel_panel_disable_backlight(). Signed-off-by: Hans de Goede --- drivers/gpu/drm/i915/intel_dsi.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-)

Re: [Intel-gfx] linux-next: problems fetching the drm-intel, etc trees

2016-12-01 Thread Daniel Stone
Hi Stephen, On 1 December 2016 at 20:45, Stephen Rothwell wrote: > On Thu, 01 Dec 2016 11:02:26 + Daniel Stone wrote: >> Sorry about this, it is quite bad. I think having mirrors for the key DRM >> trees on GitHub is a good idea though, and I

[Intel-gfx] [PATCH 13/18] drm/i915/dsi: Execute MIPI_SEQ_DEASSERT_RESET before calling device_ready()

2016-12-01 Thread Hans de Goede
Execute MIPI_SEQ_DEASSERT_RESET before putting the device in ready state (LP-11), this is the sequence in which things should be done according to the spec. Signed-off-by: Hans de Goede --- drivers/gpu/drm/i915/intel_dsi.c | 9 +++-- 1 file changed, 7 insertions(+), 2

[Intel-gfx] [PATCH 18/18] drm/i915/dsi: Skip delays for v3 VBTs in vid-mode

2016-12-01 Thread Hans de Goede
For v3 VBTs in vid-mode the delays are part of the VBT sequences, so we should not also delay ourselves otherwise we get double delays. Signed-off-by: Hans de Goede --- drivers/gpu/drm/i915/intel_dsi.c | 19 +++ 1 file changed, 15 insertions(+), 4

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for GEM object create and driver init dev_priv cleanups (rev2)

2016-12-01 Thread Chris Wilson
On Thu, Dec 01, 2016 at 06:08:25PM +, Tvrtko Ursulin wrote: > Merged to dinq. Thanks for the review! (And for spotting all the > places where it is needed.) :) Oops, better run make htmldocs and catch the important information that intel_guc_fini() takes dev_priv. -Chris -- Chris Wilson,

[Intel-gfx] [PATCH 00/18] drm/i915/dsi: Fix / cleanup dsi enable / disable sequences

2016-12-01 Thread Hans de Goede
Hi All, So while trying to fix my cherrytrail tablet's screen sometimes not initializing properly (*) I started working on this series to cleanup / (minor) refactor the dsi enable / disable code, with as goal to then change it to match the enable / disable sequences which Ville Syrjälä recently

[Intel-gfx] [PATCH 01/18] drm/i915/dsi: Fix swapping of MIPI_SEQ_DEASSERT_RESET / MIPI_SEQ_ASSERT_RESET

2016-12-01 Thread Hans de Goede
Looking at the ADF code from the Android kernel sources for a cherrytrail tablet I noticed that it is calling the MIPI_SEQ_ASSERT_RESET sequence from the panel prepare hook. Until commit b1cb1bd29189 ("drm/i915/dsi: update reset and power sequences in panel prepare/unprepare hooks") the mainline

[Intel-gfx] [PATCH 02/18] drm/i915/dsi: Fix chv_exec_gpio disabling the GPIOs it is setting

2016-12-01 Thread Hans de Goede
Set the CHV_GPIO_GPIOEN bit when updating GPIOs from chv_exec_gpio. Fixes: a0a6d4ffd2ad ("drm/i915/dsi: add support for gpio elements on CHV") Cc: sta...@vger.kernel.org Cc: Jani Nikula Cc: Ville Syrjälä Signed-off-by: Hans de Goede

[Intel-gfx] [PATCH 03/18] drm/i915/dsi: Move calling of wait_for_dsi_fifo_empty to mipi_exec_send_packet

2016-12-01 Thread Hans de Goede
Instead of calling wait_for_dsi_fifo_empty on all dsi ports after calling a drm_panel_foo helper which calls VBT sequences, move it to the VBT mipi_exec_send_packet helper, which is the one VBT instruction which actually puts data in the fifo. This results in a nice cleanup making it clearer what

[Intel-gfx] [PATCH 08/18] drm/i915/dsi: Document the panel enable / disable sequences from the spec

2016-12-01 Thread Hans de Goede
Document the DSI panel enable / disable sequences from the spec, for easy comparison between the code and the spec. Signed-off-by: Hans de Goede --- drivers/gpu/drm/i915/intel_dsi.c | 64 1 file changed, 64 insertions(+) diff --git

Re: [Intel-gfx] [PATCH 15/15] drm/i915/glk: Configure number of sprite planes properly

2016-12-01 Thread Rodrigo Vivi
Reviewed-by: Rodrigo Vivi On Thu, Nov 10, 2016 at 05:23:20PM +0200, Ander Conselvan de Oliveira wrote: > Geminilake has 4 planes (3 sprites) per pipe. > > Signed-off-by: Ander Conselvan de Oliveira > > --- >

Re: [Intel-gfx] [RFC] drm/i915: Provide a hook for selftests

2016-12-01 Thread Chris Wilson
On Thu, Dec 01, 2016 at 11:32:44PM +, Chris Wilson wrote: > To facilitate integration with igt, any parameter beginning with > i915.subtest__ is interpreted as a selftest subtest executable > independently via igt/drv_selftest. > > +#define selftest(name, func) \ >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Provide a hook for selftests

2016-12-01 Thread Patchwork
== Series Details == Series: drm/i915: Provide a hook for selftests URL : https://patchwork.freedesktop.org/series/16246/ State : success == Summary == Series 16246v1 drm/i915: Provide a hook for selftests https://patchwork.freedesktop.org/api/1.0/series/16246/revisions/1/mbox/ Test

Re: [Intel-gfx] [PATCH i-g-t 0/4 v7] Convert sh scripts to C variants.

2016-12-01 Thread Chris Wilson
On Thu, Dec 01, 2016 at 02:23:54PM +0200, Marius Vlad wrote: > Latest changes include addressing comments from previous version and include > some notes about driver loading/unloading when using in combination to > drm_open_driver(). Pushed the first 2 since I had an ulterior motive in writing a

Re: [Intel-gfx] [PATCH 14/15] drm/i915/glk: Implement core display init/uninit sequence for geminilake

2016-12-01 Thread Rodrigo Vivi
Reviewed-by: Rodrigo Vivi On Thu, Nov 10, 2016 at 05:23:19PM +0200, Ander Conselvan de Oliveira wrote: > The sequence is pretty much the same as broxton, except that bspec > requires the AUX domains to be enabled. But since those can't be enabled > before the phys are

Re: [Intel-gfx] [PATCH 13/15] drm/i915/glk: Allow dotclock up to 2 * cdclk on geminilake

2016-12-01 Thread Rodrigo Vivi
Reviewed-by: Rodrigo Vivi On Thu, Nov 10, 2016 at 05:23:18PM +0200, Ander Conselvan de Oliveira wrote: > Geminilake has double wide pipes so it can output two pixels per CD > clock. > > Signed-off-by: Ander Conselvan de Oliveira >

[Intel-gfx] [RFC] drm/i915: Provide a hook for selftests

2016-12-01 Thread Chris Wilson
Some pieces of code are independent of hardware but are very tricky to exercise through the normal userspace ABI or via debugfs hooks. Being able to create mock unit tests and execute them through CI is vital. Start by adding a central point where we can execute unit tests from and a parameter to

Re: [Intel-gfx] [PATCH 3/8] drm/i915/huc: Add HuC fw loading support

2016-12-01 Thread Srivatsa, Anusha
>-Original Message- >From: Tvrtko Ursulin [mailto:tvrtko.ursu...@linux.intel.com] >Sent: Thursday, December 1, 2016 5:24 AM >To: Srivatsa, Anusha ; intel- >g...@lists.freedesktop.org >Subject: Re: [Intel-gfx] [PATCH 3/8] drm/i915/huc: Add HuC fw loading support

Re: [Intel-gfx] [PATCH 2/8] drm/i915/huc: Unified css_header struct for GuC and HuC

2016-12-01 Thread Srivatsa, Anusha
>-Original Message- >From: Hiler, Arkadiusz >Sent: Thursday, December 1, 2016 4:23 AM >To: Srivatsa, Anusha >Cc: intel-gfx@lists.freedesktop.org; Mcgee, Jeff ; >Kamble, Sagar A >Subject: Re: [Intel-gfx] [PATCH

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Calculate common rates and max lane count in Long pulse handler

2016-12-01 Thread Patchwork
== Series Details == Series: drm/i915: Calculate common rates and max lane count in Long pulse handler URL : https://patchwork.freedesktop.org/series/16250/ State : warning == Summary == Series 16250v1 drm/i915: Calculate common rates and max lane count in Long pulse handler

[Intel-gfx] [PATCH] drm/i915: Calculate common rates and max lane count in Long pulse handler

2016-12-01 Thread Manasi Navare
Supported link rate common to source and sink as well as the maximum supported lane count based on source and sink capabilities should be set only once on hotplug and then used anytime they are requested. This patch creates and array of common rates and max lane count as the intel_dp member. It

Re: [Intel-gfx] [PATCH 08/15] drm/i915/glk: Add power wells for Geminilake

2016-12-01 Thread Rodrigo Vivi
Reviewed-by: Rodrigo Vivi On Thu, Nov 10, 2016 at 05:23:13PM +0200, Ander Conselvan de Oliveira wrote: > Geminilake has power wells are similar to SKL, but with the misc IO well > being split into separate AUX IO wells. > > Signed-off-by: Ander Conselvan de Oliveira >

Re: [Intel-gfx] [PATCH 07/15] drm/i915/glk: Set DDI PHY lane lane optimization for Geminilake too

2016-12-01 Thread Rodrigo Vivi
This could be squashed to the other bit patch with s/broxton/gen9_lp... but anyway Reviewed-by: Rodrigo Vivi On Thu, Nov 10, 2016 at 05:23:12PM +0200, Ander Conselvan de Oliveira wrote: > Geminilake uses the same lane latency optimization masks and registers > as

Re: [Intel-gfx] [PATCH 06/15] drm/i915/glk: Force DDI initialization.

2016-12-01 Thread Rodrigo Vivi
This could also be squashed or reviewed-by you... either works for me, I just cannot review the patch that I'm listed as author ;) On Thu, Nov 10, 2016 at 05:23:11PM +0200, Ander Conselvan de Oliveira wrote: > From: Rodrigo Vivi > > As for BXT, GLK doesn't support port

Re: [Intel-gfx] [PATCH 12/15] drm/i915/glk: Reuse broxton's cdclk code for GLK

2016-12-01 Thread Rodrigo Vivi
Reviewed-by: Rodrigo Vivi On Thu, Nov 10, 2016 at 05:23:17PM +0200, Ander Conselvan de Oliveira wrote: > Geminilake has the same register layout, reference clock and programming > sequence as broxton. The difference is that it doesn't support the 1.5 > divider and has

Re: [Intel-gfx] [PATCH 11/15] drm/i915/glk: Update Port PLL enable sequence for Geminilkae

2016-12-01 Thread Rodrigo Vivi
Reviewed-by: Rodrigo Vivi On Thu, Nov 10, 2016 at 05:23:16PM +0200, Ander Conselvan de Oliveira wrote: > From: Madhav Chauhan > > Add steps for enabling and disabling Port PLL as per bspec. > > Signed-off-by: Madhav Chauhan

Re: [Intel-gfx] [PATCH v3] drm/i915/glk: Reuse broxton code for geminilake

2016-12-01 Thread Rodrigo Vivi
A reviewed backwards because I was willing to check if all ifs were in place. I missed the ones from i915_drv.c *** i915_drv.c: i915_drm_suspend_late[1500]fw_csr = !IS_GEN9_LP(dev_priv) && i915_drm_suspend_late[1513]if (IS_GEN9_LP(dev_priv)) i915_drm_resume_early[1721]if

Re: [Intel-gfx] [RFC 2/3] drm: Register drmfs filesystem from drm init

2016-12-01 Thread Daniel Vetter
On Thu, Dec 01, 2016 at 01:44:16PM +0530, swati.dhin...@intel.com wrote: > From: Swati Dhingra > > During drm module initialization, drm_core_init initializes the drmfs > filesystem and register this with kernel. A driver specific directory is > created > inside drmfs

Re: [Intel-gfx] [PATCH] drm/i915: Fix intel_psr_init() kerneldoc

2016-12-01 Thread Conselvan De Oliveira, Ander
On Tue, 2016-11-29 at 13:48 +0200, Ander Conselvan de Oliveira wrote: > In commit c39055b072f8 ("drm/i915: Pass dev_priv to > intel_setup_outputs()"), I forgot to update the kerneldoc for > intel_psr_init() init, leading to warnings when building the > documentation: > >

Re: [Intel-gfx] [RFC 1/3] fs: Introduce drmfs pseudo filesystem interfaces

2016-12-01 Thread Daniel Vetter
On Thu, Dec 01, 2016 at 01:44:15PM +0530, swati.dhin...@intel.com wrote: > From: Swati Dhingra > > The patch introduces a new pseudo filesystem type, named 'drmfs' which is > intended to house the files for the data generated by drm subsystem that > cannot be

Re: [Intel-gfx] [RFC 0/3] Introduce drmfs pseudo filesystem for drm subsystem

2016-12-01 Thread Daniel Vetter
On Thu, Dec 01, 2016 at 01:44:14PM +0530, swati.dhin...@intel.com wrote: > From: Swati Dhingra > > Currently, for the purpose of providing output debug/loggging/crc and various > other kinds of data from DRM layer to userspace, we don't have a standard > filesystem,

Re: [Intel-gfx] [PATCH 3/6] drm/i915: rename BROADWATER and CRESTLINE to I965G and I965GM, respectively

2016-12-01 Thread Joonas Lahtinen
On ke, 2016-11-30 at 17:43 +0200, Jani Nikula wrote: > Add more consistency to our naming. Pineview remains the outlier. Keep > using code names for gen5+. > > Signed-off-by: Jani Nikula Reviewed-by: Joonas Lahtinen Regards, Joonas --

Re: [Intel-gfx] [RFC 1/3] fs: Introduce drmfs pseudo filesystem interfaces

2016-12-01 Thread sourab gupta
On Thu, 2016-12-01 at 00:07 -0800, Chris Wilson wrote: > On Thu, Dec 01, 2016 at 12:32:31PM +0530, swati.dhin...@intel.com wrote: > > +int drmfs_init(void) > > +{ > > + int retval; > > + > > + retval = sysfs_create_mount_point(kernel_kobj, "drm"); > > + if (retval) > > + return

Re: [Intel-gfx] [PATCH]i915: use WARN_ON_ONCE in intel_dp_aux_transfer

2016-12-01 Thread Dave Young
On 11/30/16 at 03:25pm, Ville Syrjälä wrote: > On Thu, Nov 24, 2016 at 05:03:20PM +0800, Dave Young wrote: > > On 11/24/16 at 10:53am, Jani Nikula wrote: > > > On Thu, 24 Nov 2016, Dave Young wrote: > > > > I see a lot of below warning: > > > > > > No, we must not hide this

Re: [Intel-gfx] [RFC 1/3] fs: Introduce drmfs pseudo filesystem interfaces

2016-12-01 Thread Chris Wilson
On Thu, Dec 01, 2016 at 12:32:31PM +0530, swati.dhin...@intel.com wrote: > +int drmfs_init(void) > +{ > + int retval; > + > + retval = sysfs_create_mount_point(kernel_kobj, "drm"); > + if (retval) > + return -EINVAL; > + > + retval = register_filesystem(_fs_type); > +

[Intel-gfx] [RFC 1/3] fs: Introduce drmfs pseudo filesystem interfaces

2016-12-01 Thread swati . dhingra
From: Swati Dhingra The patch introduces a new pseudo filesystem type, named 'drmfs' which is intended to house the files for the data generated by drm subsystem that cannot be accommodated by any of the existing filesystems. The filesystem is modelled on the lines of

[Intel-gfx] [RFC 0/3] Introduce drmfs pseudo filesystem for drm subsystem

2016-12-01 Thread swati . dhingra
From: Swati Dhingra Currently, for the purpose of providing output debug/loggging/crc and various other kinds of data from DRM layer to userspace, we don't have a standard filesystem, which would suffice for all the usecases. The filesystems used currently such as

[Intel-gfx] [RFC 2/3] drm: Register drmfs filesystem from drm init

2016-12-01 Thread swati . dhingra
From: Swati Dhingra During drm module initialization, drm_core_init initializes the drmfs filesystem and register this with kernel. A driver specific directory is created inside drmfs root, and dentry of this directory is saved for subsequent use by the driver (e.g.

[Intel-gfx] [RFC 3/3] drm/i915: Creating guc log file in drmfs instead of debugfs

2016-12-01 Thread swati . dhingra
From: Swati Dhingra In the current scenario, the relay API fit well only with debugfs, due to availability of parent dentry. Any other existing filesystem was not feasible for holding guc logs, due to incompatibility with relay. But this makes the guc_log file

Re: [Intel-gfx] drm-intel split-up and new dim script

2016-12-01 Thread Daniel Vetter
Ok, transition is over, old drm-intel-nightly and rerere-cache is removed. I hope that's enough of a hint to everyone else who missed the memo ;-) -Daniel On Thu, Nov 24, 2016 at 11:48:47AM +0100, Daniel Vetter wrote: > Hi all, > > So it's finally done, drm-misc is split out into a separate

Re: [Intel-gfx] [RFC 1/3] fs: Introduce drmfs pseudo filesystem interfaces

2016-12-01 Thread Chris Wilson
On Thu, Dec 01, 2016 at 12:32:31PM +0530, swati.dhin...@intel.com wrote: > diff --git a/fs/Kconfig b/fs/Kconfig > index 4bd03a2..7d0ac20 100644 > --- a/fs/Kconfig > +++ b/fs/Kconfig > @@ -200,6 +200,15 @@ config HUGETLBFS > config HUGETLB_PAGE > def_bool HUGETLBFS > > +config DRMFS > +

Re: [Intel-gfx] [RFC 1/3] fs: Introduce drmfs pseudo filesystem interfaces

2016-12-01 Thread sourab gupta
On Thu, 2016-12-01 at 00:11 -0800, Chris Wilson wrote: > On Thu, Dec 01, 2016 at 12:32:31PM +0530, swati.dhin...@intel.com wrote: > > diff --git a/fs/Kconfig b/fs/Kconfig > > index 4bd03a2..7d0ac20 100644 > > --- a/fs/Kconfig > > +++ b/fs/Kconfig > > @@ -200,6 +200,15 @@ config HUGETLBFS > >

  1   2   >