Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: make i915_suspend_switcheroo static

On 02/12/2016 11:15, Patchwork wrote: == Series Details == Series: drm/i915: make i915_suspend_switcheroo static URL : https://patchwork.freedesktop.org/series/16269/ State : success == Summary == Series 16269v1 drm/i915: make i915_suspend_switcheroo static

Re: [Intel-gfx] [PATCH v5 4/8] drm/i915/bxt: Enable IPC support

Hi, On Tuesday 22 November 2016 08:15 PM, Paulo Zanoni wrote: Em Ter, 2016-11-22 às 19:05 +0530, Mahesh Kumar escreveu: Hi, On Tuesday 22 November 2016 12:16 AM, Paulo Zanoni wrote: Em Sex, 2016-11-18 às 20:39 +0530, Mahesh Kumar escreveu: This patch adds IPC support for platforms. This

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [RFCv2,1/3] drm/i915: Provide a hook for selftests

== Series Details == Series: series starting with [RFCv2,1/3] drm/i915: Provide a hook for selftests URL : https://patchwork.freedesktop.org/series/16276/ State : success == Summary == Series 16276v1 Series without cover letter

Re: [Intel-gfx] [PATCH 1/2] drm/i915: introduce GEM_WARN_ON

On Fri, Dec 02, 2016 at 01:23:13PM +, Matthew Auld wrote: > In a similar spirit to GEM_BUG_ON we now also have GEM_WARN_ON, this > will enable us to freely add warnings which our CI will hopefully catch > but without fear of impacting production machines. > > Suggested-by: Chris Wilson

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: give gen8_setup_page_directory or more accurate name

== Series Details == Series: series starting with [1/2] drm/i915: give gen8_setup_page_directory or more accurate name URL : https://patchwork.freedesktop.org/series/16270/ State : success == Summary == Series 16270v1 Series without cover letter

Re: [Intel-gfx] [PATCH] drm/i915/dsi: Do not clear DPOUNIT_CLOCK_GATE_DISABLE from vlv_init_display_clock_gating

On Thu, Dec 01, 2016 at 04:39:57PM +0100, Hans de Goede wrote: > On my Cherrytrail CUBE iwork8 Air tablet PIPE-A would get stuck on loading > i915 at boot 1 out of every 3 boots, resulting in a non functional LCD. > Once the i915 driver has successfully loaded, the panel can be disabled / >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: make i915_suspend_switcheroo static

== Series Details == Series: drm/i915: make i915_suspend_switcheroo static URL : https://patchwork.freedesktop.org/series/16269/ State : success == Summary == Series 16269v1 drm/i915: make i915_suspend_switcheroo static https://patchwork.freedesktop.org/api/1.0/series/16269/revisions/1/mbox/

Re: [Intel-gfx] [PATCH] drm/i915: remove redundant warnings

On Fri, Dec 02, 2016 at 10:58:38AM +, Matthew Auld wrote: > If we've gotten this far then we must have already checked if the > vma can fit into the vm when we inserted the mm node, and in turn > must have also checked for the overflow. > > Cc: Chris Wilson >

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Calculate common rates and max lane count in Long pulse handler

> == Series Details == > > Series: drm/i915: Calculate common rates and max lane count in Long pulse > handler > URL : https://patchwork.freedesktop.org/series/16250/ > State : warning > > == Summary == > > Series 16250v1 drm/i915: Calculate common rates and max lane count in > Long pulse

[Intel-gfx] [RFCv2 2/3] drm/i915: Add unit tests for the breadcrumb rbtree, insert/remove

First retroactive test, make sure that the waiters are in global seqno order after random inserts and removals. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_selftests.h| 1 + drivers/gpu/drm/i915/intel_breadcrumbs.c | 197

[Intel-gfx] [RFCv2 1/3] drm/i915: Provide a hook for selftests

Some pieces of code are independent of hardware but are very tricky to exercise through the normal userspace ABI or via debugfs hooks. Being able to create mock unit tests and execute them through CI is vital. Start by adding a central point where we can execute unit tests from and a parameter to

[Intel-gfx] [RFCv2 3/3] drm/i915: Add unit tests for the breadcrumb rbtree, completion

Second retroactive test, make sure that the waiters are removed from the global wait-tree when their seqno completes. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_breadcrumbs.c | 79 1 file changed, 79 insertions(+) diff

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: remove redundant warnings

== Series Details == Series: drm/i915: remove redundant warnings URL : https://patchwork.freedesktop.org/series/16273/ State : success == Summary == Series 16273v1 drm/i915: remove redundant warnings https://patchwork.freedesktop.org/api/1.0/series/16273/revisions/1/mbox/ fi-bdw-5557u

[Intel-gfx] [PATCH 1/2] drm/i915: introduce GEM_WARN_ON

In a similar spirit to GEM_BUG_ON we now also have GEM_WARN_ON, this will enable us to freely add warnings which our CI will hopefully catch but without fear of impacting production machines. Suggested-by: Chris Wilson Signed-off-by: Matthew Auld

[Intel-gfx] [PATCH 2/2] drm/i915: move vma sanity checking into i915_vma_bind

If we move the sanity checking from gen8_alloc_va_range_3lvl and gen6_alloc_va_range into i915_vma_bind, we will increase our coverage to now both callbacks. We also convert each WARN_ON over to a GEM_WARN_ON. Suggested-by: Chris Wilson Signed-off-by: Matthew Auld

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: s/gen8_setup_page_directory/gen8_setup_pdpe/

== Series Details == Series: series starting with [1/2] drm/i915: s/gen8_setup_page_directory/gen8_setup_pdpe/ URL : https://patchwork.freedesktop.org/series/16274/ State : success == Summary == Series 16274v1 Series without cover letter

Re: [Intel-gfx] [PATCH 01/18] drm/i915/dsi: Fix swapping of MIPI_SEQ_DEASSERT_RESET / MIPI_SEQ_ASSERT_RESET

On Fri, Dec 02, 2016 at 02:34:01PM +0100, Hans de Goede wrote: > Hi, > > On 02-12-16 13:37, Ville Syrjälä wrote: > > On Thu, Dec 01, 2016 at 09:29:08PM +0100, Hans de Goede wrote: > >> Looking at the ADF code from the Android kernel sources for a > >> cherrytrail tablet I noticed that it is

Re: [Intel-gfx] [PATCH 09/18] drm/i915/dsi: Make intel_dsi_enable/disable directly exec VBT sequences

Hi, On 02-12-16 11:31, Jani Nikula wrote: On Thu, 01 Dec 2016, Hans de Goede wrote: The drm_panel_enable/disable and drm_panel_prepare/unprepare calls are not fine grained enough to abstract all the different steps we need to take (and VBT sequences we need to exec)

Re: [Intel-gfx] [PATCH 09/18] drm/i915/dsi: Make intel_dsi_enable/disable directly exec VBT sequences

On Fri, 02 Dec 2016, Hans de Goede wrote: > Hi, > > On 02-12-16 11:31, Jani Nikula wrote: >> On Thu, 01 Dec 2016, Hans de Goede wrote: >>> The drm_panel_enable/disable and drm_panel_prepare/unprepare calls are >>> not fine grained enough to abstract all

Re: [Intel-gfx] [PATCH] drm/i915/dsi: Do not clear DPOUNIT_CLOCK_GATE_DISABLE from vlv_init_display_clock_gating

On Fri, Dec 02, 2016 at 02:27:43PM +0100, Hans de Goede wrote: > Hi, > > On 02-12-16 13:40, Ville Syrjälä wrote: > > On Thu, Dec 01, 2016 at 04:39:57PM +0100, Hans de Goede wrote: > >> On my Cherrytrail CUBE iwork8 Air tablet PIPE-A would get stuck on loading > >> i915 at boot 1 out of every 3

[Intel-gfx] [PATCH 1/2] drm/i915: s/gen8_setup_page_directory/gen8_setup_pdpe/

The function name gen8_setup_page_directory is misleading, and only serves to confuse the reader, it's not setting up a pd, but rather encoding a specific pdpe with a given pd. Signed-off-by: Matthew Auld Reviewed-by: Chris Wilson ---

[Intel-gfx] [PATCH 2/2] drm/i915: s/gen8_setup_page_directory_pointer/gen8_setup_pml4e/

The function name gen8_setup_page_directory_pointer is misleading, and only serves to confuse the reader, it's not setting up a pdp, but rather encoding a specific pml4e with a given pdp. Signed-off-by: Matthew Auld Reviewed-by: Chris Wilson ---

Re: [Intel-gfx] [PATCH 01/18] drm/i915/dsi: Fix swapping of MIPI_SEQ_DEASSERT_RESET / MIPI_SEQ_ASSERT_RESET

On Thu, Dec 01, 2016 at 09:29:08PM +0100, Hans de Goede wrote: > Looking at the ADF code from the Android kernel sources for a > cherrytrail tablet I noticed that it is calling the > MIPI_SEQ_ASSERT_RESET sequence from the panel prepare hook. > > Until commit b1cb1bd29189 ("drm/i915/dsi: update

Re: [Intel-gfx] [PATCH alternative #1] drm/i915/bxt: add bxt dsi gpio element support

On Thu, 01 Dec 2016, Mika Kahola wrote: > On Tue, 2016-11-15 at 14:08 +0200, Jani Nikula wrote: >> Request the GPIO by index through the consumer API. For now, use a >> quick >> hack to store the already requested ones, simply because I have no >> idea >> whether this

Re: [Intel-gfx] [PATCH 15/15] drm/i915: Pass crtc state to vlv_compute_wm_level()

On Thu, Dec 01, 2016 at 03:47:55PM +0100, Maarten Lankhorst wrote: > Op 28-11-16 om 18:37 schreef ville.syrj...@linux.intel.com: > > From: Ville Syrjälä > > > > Rather than accessing crtc->config in vlv_compute_wm_level() let's > > pass in the crtc state explicitly.

Re: [Intel-gfx] [PATCH] drm/i915/dsi: Do not clear DPOUNIT_CLOCK_GATE_DISABLE from vlv_init_display_clock_gating

Hi, On 02-12-16 13:40, Ville Syrjälä wrote: On Thu, Dec 01, 2016 at 04:39:57PM +0100, Hans de Goede wrote: On my Cherrytrail CUBE iwork8 Air tablet PIPE-A would get stuck on loading i915 at boot 1 out of every 3 boots, resulting in a non functional LCD. Once the i915 driver has successfully

Re: [Intel-gfx] [PATCH 1/2] drm/i915: introduce GEM_WARN_ON

On Fri, Dec 02, 2016 at 01:23:13PM +, Matthew Auld wrote: > In a similar spirit to GEM_BUG_ON we now also have GEM_WARN_ON, this > will enable us to freely add warnings which our CI will hopefully catch > but without fear of impacting production machines. Impacting performance? > >

Re: [Intel-gfx] [PATCH 01/18] drm/i915/dsi: Fix swapping of MIPI_SEQ_DEASSERT_RESET / MIPI_SEQ_ASSERT_RESET

Hi, On 02-12-16 13:37, Ville Syrjälä wrote: On Thu, Dec 01, 2016 at 09:29:08PM +0100, Hans de Goede wrote: Looking at the ADF code from the Android kernel sources for a cherrytrail tablet I noticed that it is calling the MIPI_SEQ_ASSERT_RESET sequence from the panel prepare hook. Until commit

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [1/2] drm/i915: introduce GEM_WARN_ON

== Series Details == Series: series starting with [1/2] drm/i915: introduce GEM_WARN_ON URL : https://patchwork.freedesktop.org/series/16278/ State : warning == Summary == Series 16278v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/16278/revisions/1/mbox/ Test

Re: [Intel-gfx] [PATCH 06/15] drm/i915/glk: Force DDI initialization.

On Thu, 2016-12-01 at 16:52 -0800, Rodrigo Vivi wrote: > This could also be squashed or reviewed-by you... > either works for me, I just cannot review the patch that I'm listed as author > ;) I had a vague recollection of editing this patch, hence why I didn't add my own R-b. But it was just a

[Intel-gfx] [PATCH 1/9] drm/i915/glk: Reuse broxton code for geminilake

Geminilake is mostly backwards compatible with broxton, so change most of the IS_BROXTON() checks to IS_GEN9_LP(). Differences between the platforms will be implemented in follow-up patches. v2: Don't reuse broxton's path in intel_update_max_cdclk(). Don't set plane count as in broxton. v3:

Re: [Intel-gfx] [RFC 1/3] fs: Introduce drmfs pseudo filesystem interfaces

On Thu, 2016-12-01 at 23:53 -0800, Daniel Vetter wrote: > On Thu, Dec 01, 2016 at 01:44:15PM +0530, swati.dhin...@intel.com wrote: > > From: Swati Dhingra > > > > The patch introduces a new pseudo filesystem type, named 'drmfs' which is > > intended to house the files

[Intel-gfx] [PATCH 4/9] drm/i915/glk: Set DCC delay range 2 in PLL enable sequence

Follow the PLL enable sequence updated in bspec, which requires the DCC delay range 2 bit to be set. v2: Moved from DDI init sequence to PLL enable. v3: Don't read value from GRP register. (Rodrido) Cc: Rodrigo Vivi Signed-off-by: Ander Conselvan De Oliveira

[Intel-gfx] [PATCH 2/9] drm/i915/glk: Add power wells for Geminilake

Geminilake has power wells are similar to SKL, but with the misc IO well being split into separate AUX IO wells. Signed-off-by: Ander Conselvan de Oliveira Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_reg.h |

[Intel-gfx] [PATCH 6/9] drm/i915/glk: Reuse broxton's cdclk code for GLK

Geminilake has the same register layout, reference clock and programming sequence as broxton. The difference is that it doesn't support the 1.5 divider and has different ratios, but a lot of code can be shared between the two platforms. v2: Rebase (s/broxton/bxt). v3: Fix vco calculation in

[Intel-gfx] [PATCH] drm/i915: Fix kerneldoc for intel_guc_fini

From: Tvrtko Ursulin Recent refactoring forgot to update this one. Signed-off-by: Tvrtko Ursulin Fixes: bf9e8429ab97 ("drm/i915: Make various init functions take dev_priv") Cc: Tvrtko Ursulin Cc: Chris Wilson

Re: [Intel-gfx] [PATCH 11/15] drm/i915: Protect DSPARB registers with a spinlock

On Thu, Dec 01, 2016 at 03:45:35PM +0100, Maarten Lankhorst wrote: > Op 01-12-16 om 14:13 schreef Ville Syrjälä: > > On Thu, Dec 01, 2016 at 12:56:16PM +0100, Maarten Lankhorst wrote: > >> Op 28-11-16 om 18:37 schreef ville.syrj...@linux.intel.com: > >>> From: Ville Syrjälä

[Intel-gfx] [PATCH] drm/i915: make i915_suspend_switcheroo static

Looks like this was missed when unexporting, so let's keep sparse happy. Cc: Tvrtko Ursulin Fixes: 7f26cb88014a ("drm/i915: Unexport VGA switcheroo functions") Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/i915_drv.c | 2 +- 1 file

Re: [Intel-gfx] [PATCH 1/2] pwm: lpss: Make builtin and add lookup-table so that i915 can find the pwm_backlight

On Fri, 02 Dec 2016, Hans de Goede wrote: > The primary consumer of the lpss pwm is the i915 kms driver, but > currently that driver cannot get the pwm because i915 platforms are > not using devicetree and pwm-lpss does not call pwm_add_table. > > Another problem is that i915

[Intel-gfx] [PATCH 5/9] drm/i915/glk: Update Port PLL enable sequence for Geminilkae

From: Madhav Chauhan Add steps for enabling and disabling Port PLL as per bspec. Signed-off-by: Madhav Chauhan Signed-off-by: Ander Conselvan de Oliveira Reviewed-by: Rodrigo Vivi

[Intel-gfx] [PATCH 3/9] drm/i915/glk: Implement Geminilake DDI init sequence

Implement the DDI initsequence and add information about the different phys in GLK. v2: Rebase on the move of phys to be power wells. v3: Rebase on addition of struct bxt_ddi_phy_info. Signed-off-by: Ander Conselvan de Oliveira Reviewed-by: Rodrigo Vivi

[Intel-gfx] [PATCH 9/9] drm/i915/glk: Configure number of sprite planes properly

Geminilake has 4 planes (3 sprites) per pipe. Signed-off-by: Ander Conselvan de Oliveira Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_device_info.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[Intel-gfx] [PATCH 8/9] drm/i915/glk: Implement core display init/uninit sequence for geminilake

The sequence is pretty much the same as broxton, except that bspec requires the AUX domains to be enabled. But since those can't be enabled before the phys are initialized, we just use the same sequence as broxton. v2: Don't manually enable AUX domains. (Ander) Signed-off-by: Ander Conselvan de

[Intel-gfx] [PATCH 0/9] Geminilake enabling

Remaining glk enabling patches, with some of the patches squashed. All have R-bs already. Ander Conselvan de Oliveira (8): drm/i915/glk: Reuse broxton code for geminilake drm/i915/glk: Add power wells for Geminilake drm/i915/glk: Implement Geminilake DDI init sequence drm/i915/glk: Set

[Intel-gfx] [PATCH 7/9] drm/i915/glk: Allow dotclock up to 2 * cdclk on geminilake

Geminilake has double wide pipes so it can output two pixels per CD clock. Signed-off-by: Ander Conselvan de Oliveira Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_display.c | 10 ++ 1 file changed, 6

Re: [Intel-gfx] [PATCH 15/15] drm/i915: Pass crtc state to vlv_compute_wm_level()

On Thu, Dec 01, 2016 at 03:47:55PM +0100, Maarten Lankhorst wrote: > Op 28-11-16 om 18:37 schreef ville.syrj...@linux.intel.com: > > From: Ville Syrjälä > > > > Rather than accessing crtc->config in vlv_compute_wm_level() let's > > pass in the crtc state explicitly.

Re: [Intel-gfx] [PATCH] drm/i915/perf: use DRM_DEBUG for userspace issues

On Thu, Dec 01, 2016 at 05:21:52PM +, Robert Bragg wrote: > Avoid using DRM_ERROR for conditions userspace can trigger with a bad > config when opening a stream or from not reading data in a timely > fashion (whereby the OA buffer fills up). These conditions are tested > by i-g-t which treats

[Intel-gfx] [PATCH] drm/i915: Add some unit tests for the breadcrumb rbtree

First retroactive test, make sure that the waiters are in global seqno order after random inserts and removals. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_selftests.h| 1 + drivers/gpu/drm/i915/intel_breadcrumbs.c | 161

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix kerneldoc for intel_guc_fini

== Series Details == Series: drm/i915: Fix kerneldoc for intel_guc_fini URL : https://patchwork.freedesktop.org/series/16264/ State : success == Summary == Series 16264v1 drm/i915: Fix kerneldoc for intel_guc_fini https://patchwork.freedesktop.org/api/1.0/series/16264/revisions/1/mbox/

Re: [Intel-gfx] [PATCH 2/2] drm/i915: give gen8_setup_page_directory_pointer or more accurate name

On Fri, Dec 02, 2016 at 10:30:21AM +, Matthew Auld wrote: > The function name gen8_setup_page_directory_pointer is misleading, and only > serves to confuse the reader, it's not setting up a pdp, but > rather encoding a specific pml4e with a given pdp. > > Signed-off-by: Matthew Auld

[Intel-gfx] [PATCH] drm/i915: remove redundant warnings

If we've gotten this far then we must have already checked if the vma can fit into the vm when we inserted the mm node, and in turn must have also checked for the overflow. Cc: Chris Wilson Signed-off-by: Matthew Auld ---

[Intel-gfx] [RFC PATCH v4 5/7] ALSA: x86: hdmi: Improve position reporting

Use a hw register to calculate sub-period position reports. This makes PulseAudio happier. Signed-off-by: David Henningsson Signed-off-by: Pierre-Louis Bossart Signed-off-by: Jerome Anand ---

Re: [Intel-gfx] [PATCH 12/15] drm/i915: Zero out HOWM registers before writing new WM/HOWM register values

On Thu, Dec 01, 2016 at 03:43:07PM +0100, Maarten Lankhorst wrote: > Op 28-11-16 om 18:37 schreef ville.syrj...@linux.intel.com: > > From: Ville Syrjälä > > > > On VLV/CHV some of the watermark values are split across two registers: > > low order bits in one, and

[Intel-gfx] [RFC PATCH v4 6/7] ALSA: x86: hdmi: Fixup some monitor

This change was given to Canonical apparently to fix an issue with on some monitor brand. It's not clear what this patch does but it doesn't seem to have side effects. Signed-off-by: David Henningsson Signed-off-by: Pierre-Louis Bossart

[Intel-gfx] [RFC PATCH v4 7/7] ALSA: x86: hdmi: continue playback even when display resolution changes

When the display resolution changes, the drm disables the display pipes due to which audio rendering stops. At this time, we need to ensure the existing audio pointers and buffers are cleared out so that the playback can restarted once the display pipe is enabled with a different N/CTS values

Re: [Intel-gfx] [PATCH v3] drm/i915/glk: Reuse broxton code for geminilake

On Thu, 2016-12-01 at 17:06 -0800, Rodrigo Vivi wrote: > A reviewed backwards because I was willing to check if all ifs were in place. > > I missed the ones from i915_drv.c > > *** i915_drv.c: > i915_drm_suspend_late[1500]fw_csr = !IS_GEN9_LP(dev_priv) && > i915_drm_suspend_late[1513]if

[Intel-gfx] [PATCH 1/2] pwm: lpss: Make builtin and add lookup-table so that i915 can find the pwm_backlight

The primary consumer of the lpss pwm is the i915 kms driver, but currently that driver cannot get the pwm because i915 platforms are not using devicetree and pwm-lpss does not call pwm_add_table. Another problem is that i915 does not support get_pwm returning -EPROBE_DEFER and i915's init is very

[Intel-gfx] [PATCH 2/2] pwm: lpss: Add get_state callback

Add a get_state callback so that the initial state correctly reflects the actual hardware state. Signed-off-by: Hans de Goede --- drivers/pwm/pwm-lpss.c | 28 1 file changed, 28 insertions(+) diff --git a/drivers/pwm/pwm-lpss.c

[Intel-gfx] [RFC PATCH v4 4/7] ALSA: x86: hdmi: Add audio support for BYT and CHT

Hdmi audio driver based on the child platform device created by gfx driver is implemented. This audio driver is derived from legacy intel hdmi audio driver. The interfaces for interaction between gfx and audio are updated and the driver implementation updated to derive interrupts in its own

[Intel-gfx] [RFC PATCH v4 3/7] ALSA: add shell for Intel HDMI LPE audio driver

On Baytrail and Cherrytrail, HDaudio may be fused out or disabled by the BIOS. This driver enables an alternate path to the i915 display registers and DMA. Although there is no hardware path between i915 display and LPE/SST audio clusters, this HDMI capability is referred to in the documentation

Re: [Intel-gfx] [RFC] drm: Enable dynamic debug for DRM_[DEV]_DEBUG*

On Thu, Dec 01, 2016 at 05:18:00PM +, Robert Bragg wrote: > I'm currently considering the use of DRM_ERROR in i915 perf for steam > config validation errors (i.e. userspace misconfigurations) that should > be changed so that i-g-t tests aren't treated as failures when > triggering these. > >

[Intel-gfx] [RFC PATCH v4 1/7] drm/i915: setup bridge for HDMI LPE audio driver

Enable support for HDMI LPE audio mode on Baytrail and Cherrytrail when HDaudio controller is not detected Setup minimum required resources during i915_driver_load: 1. Create a platform device to share MMIO/IRQ resources 2. Make the platform device child of i915 device for runtime PM. 3. Create

[Intel-gfx] [RFC PATCH v4 2/7] drm/i915: Add support for audio driver notifications

Notifiations like mode change, hot plug and edid to the audio driver are added. This is inturn used by the audio driver for its functionality. A new interface file capturing the notifications needed by the audio driver is added Signed-off-by: Pierre-Louis Bossart

[Intel-gfx] ✗ Fi.CI.BAT: warning for Geminilake enabling (rev9)

== Series Details == Series: Geminilake enabling (rev9) URL : https://patchwork.freedesktop.org/series/15118/ State : warning == Summary == Series 15118v9 Geminilake enabling https://patchwork.freedesktop.org/api/1.0/series/15118/revisions/9/mbox/ Test kms_pipe_crc_basic: Subgroup

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix kerneldoc for intel_guc_fini

On 02/12/2016 09:45, Patchwork wrote: == Series Details == Series: drm/i915: Fix kerneldoc for intel_guc_fini URL : https://patchwork.freedesktop.org/series/16264/ State : success == Summary == Series 16264v1 drm/i915: Fix kerneldoc for intel_guc_fini

Re: [Intel-gfx] [PATCH] drm/i915: make i915_suspend_switcheroo static

On 02/12/2016 10:24, Matthew Auld wrote: Looks like this was missed when unexporting, so let's keep sparse happy. Cc: Tvrtko Ursulin Fixes: 7f26cb88014a ("drm/i915: Unexport VGA switcheroo functions") Signed-off-by: Matthew Auld ---

[Intel-gfx] [RFC PATCH v4 0/7] Add support for Legacy HDMI audio drivers

Legacy (CherryTrail/ Baytrail) HDMI audio drivers added Legacy hdmi audio-Gfx interaction/ interfacing is updated to use irq chip framework Jerome Anand (7): drm/i915: setup bridge for HDMI LPE audio driver drm/i915: Add support for audio driver notifications ALSA: add shell for Intel HDMI

[Intel-gfx] [PATCH 2/2] drm/i915: give gen8_setup_page_directory_pointer or more accurate name

The function name gen8_setup_page_directory_pointer is misleading, and only serves to confuse the reader, it's not setting up a pdp, but rather encoding a specific pml4e with a given pdp. Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/i915_gem_gtt.c | 10 +-

[Intel-gfx] [PATCH 1/2] drm/i915: give gen8_setup_page_directory or more accurate name

The function name gen8_setup_page_directory is misleading, and only serves to confuse the reader, it's not setting up a pd, but rather encoding a specific pdpe with a given pd. Signed-off-by: Matthew Auld --- drivers/gpu/drm/i915/i915_gem_gtt.c | 10 +- 1 file

Re: [Intel-gfx] [RFC 2/3] drm: Register drmfs filesystem from drm init

On Thu, 2016-12-01 at 23:57 -0800, Daniel Vetter wrote: > On Thu, Dec 01, 2016 at 01:44:16PM +0530, swati.dhin...@intel.com wrote: > > From: Swati Dhingra > > > > During drm module initialization, drm_core_init initializes the drmfs > > filesystem and register this with

Re: [Intel-gfx] [PATCH] drm/i915: Fix kerneldoc for intel_guc_fini

On Fri, Dec 02, 2016 at 08:43:53AM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Recent refactoring forgot to update this one. > > Signed-off-by: Tvrtko Ursulin > Fixes: bf9e8429ab97 ("drm/i915: Make various init functions take

Re: [Intel-gfx] [PATCH 08/18] drm/i915/dsi: Document the panel enable / disable sequences from the spec

On Thu, 01 Dec 2016, Hans de Goede wrote: > Document the DSI panel enable / disable sequences from the spec, > for easy comparison between the code and the spec. > > Signed-off-by: Hans de Goede I haven't done a proper review, but patches 1-8 are

Re: [Intel-gfx] [PATCH 09/18] drm/i915/dsi: Make intel_dsi_enable/disable directly exec VBT sequences

On Thu, 01 Dec 2016, Hans de Goede wrote: > The drm_panel_enable/disable and drm_panel_prepare/unprepare calls are > not fine grained enough to abstract all the different steps we need to > take (and VBT sequences we need to exec) properly. So simply remove the > panel

Re: [Intel-gfx] [PATCH] drm/i915: Remove instructions to file a bug report.

On Fri, Dec 2, 2016 at 5:03 PM, Matt Turner wrote: > From these instructions, users assume that /sys/class/drm/card0/error > contains all the information a developer needs to diagnose and fix a GPU > hang. > > In fact it doesn't, and we have no tools for solving them (other

Re: [Intel-gfx] [RFC 1/3] fs: Introduce drmfs pseudo filesystem interfaces

On Thu, Dec 01, 2016 at 01:44:15PM +0530, swati.dhin...@intel.com wrote: > From: Swati Dhingra > > The patch introduces a new pseudo filesystem type, named 'drmfs' which is > intended to house the files for the data generated by drm subsystem that > cannot be

Re: [Intel-gfx] [RFC 1/3] fs: Introduce drmfs pseudo filesystem interfaces

On Fri, 2016-12-02 at 14:40 -0800, Roper, Matthew D wrote: > On Thu, Dec 01, 2016 at 01:44:15PM +0530, swati.dhin...@intel.com wrote: > > From: Swati Dhingra > > > > The patch introduces a new pseudo filesystem type, named 'drmfs' which is > > intended to house the files

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Introduce IS_GEN9_BC for Skylake and Kabylake.

== Series Details == Series: drm/i915: Introduce IS_GEN9_BC for Skylake and Kabylake. URL : https://patchwork.freedesktop.org/series/16307/ State : warning == Summary == Series 16307v1 drm/i915: Introduce IS_GEN9_BC for Skylake and Kabylake.

[Intel-gfx] [PATCH] drm/i915: Remove instructions to file a bug report.

From these instructions, users assume that /sys/class/drm/card0/error contains all the information a developer needs to diagnose and fix a GPU hang. In fact it doesn't, and we have no tools for solving them (other than stabbing in the dark). Most of the time the error state itself isn't even

[Intel-gfx] [PATCH] drm/i915: Introduce IS_GEN9_BC for Skylake and Kabylake.

Along with GLK it was introduced the .is_lp and IS_GEN9_LP. So, following the same simplification standard we can put Skylake and Kabylake under the same bucket for most of the things. So let's add the IS_GEN9_BC for "Big Core" (non Atom based platforms). The i915_drv.c was let out of this patch

Re: [Intel-gfx] [PATCH] drm/i915/perf: More documentation hooked to i915.rst

On Thu, Dec 1, 2016 at 12:12 PM, Jani Nikula wrote: > On Wed, 30 Nov 2016, Daniel Vetter wrote: > > On Tue, Nov 29, 2016 at 05:00:55PM +, Robert Bragg wrote: > >> +.. kernel-doc:: drivers/gpu/drm/i915/i915_perf.c > >> + :functions:

[Intel-gfx] [ANNOUNCE] intel-gpu-tools 1.17

A new intel-gpu-tools quarterly release is available with the following changes: Library changes: - Added an iterator that generate primes for creating input data that should not fall into any patterns that may be optimised by the drivers. (Chris Wilson) - Crashes in fixture blocks now

Re: [Intel-gfx] [PATCH 1/3] drm: Add a new connector atomic property for link status

On Tue, Nov 29, 2016 at 11:30:31PM -0800, Manasi Navare wrote: > At the time userspace does setcrtc, we've already promised the mode > would work. The promise is based on the theoretical capabilities of > the link, but it's possible we can't reach this in practice. The DP > spec describes how the

Re: [Intel-gfx] [ANNOUNCE] intel-gpu-tools 1.17

Awesome. Looks good to me and Thanks! On Fri, Dec 02, 2016 at 06:19:40PM +0200, Petri Latvala wrote: > A new intel-gpu-tools quarterly release is available with the > following changes: > > Library changes: > > - Added an iterator that generate primes for creating input data that > should not

[Intel-gfx] [PATCH] drm/i915: Add I2C and DP-AUX char devices to debug kconfig

These char devices exposing the driver's I2C and DP-AUX adapters for user space tools are useful to debug display output related issues. Enable them with the rest of additional driver debug options. Suggested-by: Chris Wilson Signed-off-by: Imre Deak

Re: [Intel-gfx] [PATCH 2/2] drm/i915/audio: extend audio sync rate support for DP MST

On Fri, 02 Dec 2016, "Yang, Libin" wrote: > Any comments? Thanks. Both pushed to dinq, thanks for the patches. Libin and/or Dhinakaran, please improve the documentation of struct i915_audio_component_ops to describe the parameters of sync_audio_rate and get_eld hooks. For

Re: [Intel-gfx] [PULL] GVT-g device model fix

On Wed, 30 Nov 2016, Daniel Vetter wrote: > On Wed, Nov 30, 2016 at 04:23:02PM +0800, Zhenyu Wang wrote: >> >> Hi, >> >> Here's current left GVT-g device model bug fixes for pull. > > Since 4.10 feature freeze is already done, this needs to go into > drm-intel-next-fixes. Jani,

[Intel-gfx] [PATCH v2] drm/i915/dsi: Fix swapping of MIPI_SEQ_DEASSERT_RESET / MIPI_SEQ_ASSERT_RESET

Looking at the ADF code from the Android kernel sources for a cherrytrail tablet I noticed that it is calling the MIPI_SEQ_ASSERT_RESET sequence from the panel prepare hook. Until commit b1cb1bd29189 ("drm/i915/dsi: update reset and power sequences in panel prepare/unprepare hooks") the mainline

Re: [Intel-gfx] [PATCH 1/2] drm/i915: introduce GEM_WARN_ON

On Fri, Dec 02, 2016 at 03:11:05PM +, Matthew Auld wrote: > On 2 December 2016 at 13:54, Chris Wilson wrote: > > On Fri, Dec 02, 2016 at 01:23:13PM +, Matthew Auld wrote: > >> In a similar spirit to GEM_BUG_ON we now also have GEM_WARN_ON, this > >> will enable

[Intel-gfx] [PATCH v2] drm/i915/dsi: Do not clear DPOUNIT_CLOCK_GATE_DISABLE from vlv_init_display_clock_gating

On my Cherrytrail CUBE iwork8 Air tablet PIPE-A would get stuck on loading i915 at boot 1 out of every 3 boots, resulting in a non functional LCD. Once the i915 driver has successfully loaded, the panel can be disabled / enabled without hitting this issue. The getting stuck is caused by

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v4,1/3] drm/i915/gen6+: Clear upper data byte during PCODE write (rev2)

On ma, 2016-11-28 at 17:15 +, Patchwork wrote: > == Series Details == > > Series: series starting with [v4,1/3] drm/i915/gen6+: Clear upper data byte > during PCODE write (rev2) > URL   : https://patchwork.freedesktop.org/series/16046/ > State : success > > == Summary == > > Series 16046v2

Re: [Intel-gfx] [PATCH] drm/i915/perf: More documentation hooked to i915.rst

On Nov 30, 2016 19:41, "Daniel Vetter" wrote: > > On Tue, Nov 29, 2016 at 05:00:55PM +, Robert Bragg wrote: > > This adds a 'Perf' section to i915.rst with the following sub sections: > > - Overview > > - Comparison with Core Perf > > - i915 Driver Entry Points > > - i915

Re: [Intel-gfx] [PATCH 1/2] drm/i915: introduce GEM_WARN_ON

On 2 December 2016 at 13:54, Chris Wilson wrote: > On Fri, Dec 02, 2016 at 01:23:13PM +, Matthew Auld wrote: >> In a similar spirit to GEM_BUG_ON we now also have GEM_WARN_ON, this >> will enable us to freely add warnings which our CI will hopefully catch >> but

Re: [Intel-gfx] [PATCH] drm/i915: Always load guc by default.

>-Original Message- >From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] >Sent: Thursday, November 24, 2016 12:41 AM >To: Tvrtko Ursulin >Cc: Srivatsa, Anusha ; intel- >g...@lists.freedesktop.org; Mcgee, Jeff

[Intel-gfx] [PATCH] drm/i915: allow GEM_BUG_ON expr checking with !DEBUG_GEM

Use BUILD_BUG_ON_INVALID(expr) in GEM_BUG_ON when building without DEBUG_GEM. This means the compiler can now check the validity of expr without generating any code, in turn preventing us from inadvertently breaking the build when DEBUG_GEM is not enabled. Cc: Chris Wilson

Re: [Intel-gfx] [PATCH] drm/i915: Calculate common rates and max lane count in Long pulse handler

Jani, This patch is in response to your feedback previously on the fallback link rate patch. You had mentioned that we should in the long run move the common rates array and max lane count to intel_dp so that it gets computed only once on hotplug and then gets used whenever it is requested.

Re: [Intel-gfx] [PATCH 1/3] drm: Add a new connector atomic property for link status

On Fri, Dec 02, 2016 at 05:26:35PM +0100, Daniel Vetter wrote: > On Tue, Nov 29, 2016 at 11:30:31PM -0800, Manasi Navare wrote: > > At the time userspace does setcrtc, we've already promised the mode > > would work. The promise is based on the theoretical capabilities of > > the link, but it's

Re: [Intel-gfx] [PATCH v3] drm/i915/glk: Reuse broxton code for geminilake

On Fri, 2016-12-02 at 10:27 +0200, Ander Conselvan De Oliveira wrote: > On Thu, 2016-12-01 at 17:06 -0800, Rodrigo Vivi wrote: > > A reviewed backwards because I was willing to check if all ifs were in > > place. > > > > I missed the ones from i915_drv.c > > > > *** i915_drv.c: > >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add I2C and DP-AUX char devices to debug kconfig

== Series Details == Series: drm/i915: Add I2C and DP-AUX char devices to debug kconfig URL : https://patchwork.freedesktop.org/series/16295/ State : success == Summary == Series 16295v1 drm/i915: Add I2C and DP-AUX char devices to debug kconfig

Re: [Intel-gfx] [PATCH i-g-t] tools: Add intel_dp_compliance for DisplayPort 1.2 compliance automation

On Wed, Nov 23, 2016 at 03:59:52PM +0200, Jani Nikula wrote: > On Tue, 22 Nov 2016, Manasi Navare wrote: > > + > > +static void get_test_videopattern_data(void) > > +{ > > + int count = 0; > > + uint16_t video_pattern_value[3]; > > + char

Re: [Intel-gfx] [PATCH i-g-t] tools: Add intel_dp_compliance for DisplayPort 1.2 compliance automation

Petri and Marius, could you please review this patch when you have time? This tool has been evolved through the DPR-120 compliance testing. It has been fully verified using DPR-120 and it addresses the comments and concerns that Marius had few months ago on the older version of this tool. Regards

  1   2   >