Re: [Intel-gfx] [PATCH 2/2] drm/i915: Silence smatch for cmdparser

On Fri, Jan 20, 2017 at 09:45:30PM +, Chris Wilson wrote: > drivers/gpu/drm/i915/i915_cmd_parser.c:808:23: error: not an lvalue > drivers/gpu/drm/i915/i915_cmd_parser.c:811:23: error: not an lvalue > drivers/gpu/drm/i915/i915_cmd_parser.c:814:23: error: not an lvalue >

Re: [Intel-gfx] [PATCH i-g-t v2 02/33] lib/igt_kms: Avoid depencency on static plane count

Reviewed-by: Mika Kahola On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Rework kmstest_crtc and kmstest_plane structs and their usage > to not depend on a static plane count. > > Signed-off-by: Robert Foss > --- >  lib/igt_kms.c | 47

Re: [Intel-gfx] [PATCH 02/15] drm/bridge: Use recommened kerneldoc for struct member refs

On 01/25/2017 11:56 AM, Daniel Vetter wrote: I just learned that _name.member_name works and looks pretty even. It doesn't (yet) link to the member directly though, which would be really good for big structures or vfunc tables (where the per-member kerneldoc tends to be long). Also some minor

Re: [Intel-gfx] [PATCH 4/4] drm: Resurrect atomic rmfb code, v2

Op 25-01-17 om 09:09 schreef Thomas Hellstrom: > On 01/25/2017 05:54 AM, Daniel Vetter wrote: >> On Tue, Jan 24, 2017 at 01:44:54PM -0800, Matt Roper wrote: >>> On Wed, Jan 11, 2017 at 05:15:47PM +0100, Daniel Vetter wrote: On Thu, Dec 15, 2016 at 03:29:45PM +0100, Maarten Lankhorst wrote:

Re: [Intel-gfx] [PATCH i-g-t v2 03/33] lib/igt_kms: Rename kmstest properties nplanes and plane

Reviewed-by: Mika Kahola On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Rename these properties to have them use the same naming convention > as the igt_*_t structs. > > Signed-off-by: Robert Foss > --- >  lib/igt_kms.c| 16

Re: [Intel-gfx] [PATCH 4/4] drm: Resurrect atomic rmfb code, v2

On 01/25/2017 05:54 AM, Daniel Vetter wrote: > On Tue, Jan 24, 2017 at 01:44:54PM -0800, Matt Roper wrote: >> On Wed, Jan 11, 2017 at 05:15:47PM +0100, Daniel Vetter wrote: >>> On Thu, Dec 15, 2016 at 03:29:45PM +0100, Maarten Lankhorst wrote: From: Daniel Vetter

Re: [Intel-gfx] [PATCH i-g-t v2 01/33] lib/igt_kms: Add index property to kmstest_plane struct

Reviewed-by: Mika Kahola On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add an index property which helps accessing the corresponding > igt_plane_t structure through the igt_*_get_plane() functions. > > Signed-off-by: Robert Foss > ---

Re: [Intel-gfx] [PATCH 1/3] [v2] drm: Add new DRM_IOCTL_MODE_GETPLANE2

On Tue, Jan 24, 2017 at 09:20:49PM -0800, Ben Widawsky wrote: > Originally based off of a patch by Kristian. > > This new ioctl extends DRM_IOCTL_MODE_GETPLANE, by returning information > about the modifiers that will work with each format. > > It's modified from Kristian's patch in that the

[Intel-gfx] [PATCH] drm/i915: Add MIPI_IO WA and program DSI regulators

From: Uma Shankar Enable MIPI IO WA for BXT DSI as per bspec and program the DSI regulators. v2: Moved IO enable to pre-enable as per Mika's review comments. Also reused the existing register definition for BXT_P_CR_GT_DISP_PWRON. v3: Added Programming the DSI regulators

Re: [Intel-gfx] [PATCH v2 3/3] drm/i915: clean up unused vgpu_read/write

On Wed, Jan 25, 2017 at 09:44:52PM +0800, Weinan Li wrote: Having converted the force_wake_get/_put routines for a vGPU to be no-op, we can use the common mmio accessors and remove our specialised routines that simply skipped the calls to control force_wake. > Signed-off-by: Weinan Li

Re: [Intel-gfx] [PATCH v2 34/38] drm/i915: Live testing for context execution

On to, 2017-01-19 at 11:41 +, Chris Wilson wrote: > Check we can create and execution within a context. > > Signed-off-by: Chris Wilson > +static struct i915_vma * > +gpu_fill_pages(struct i915_vma *vma, u64 offset, unsigned long count, u32 > value) > +{ It

Re: [Intel-gfx] [PATCH] drm: Don't race connector registration

On 01/24/2017 10:21 PM, Daniel Vetter wrote: > Hi Dave, > > Still waiting for your testing results on this one here ... It's definitely stable with that patch applied. No more crashes. But, it's also definitely having difficulty re-probing to find the monitor that's attached to the dock in

Re: [Intel-gfx] [PATCH 06/15] drm/doc: Clarify connector overview

On Wed, Jan 25, 2017 at 10:57:17AM -0200, Gustavo Padovan wrote: > Hi Daniel, > > 2017-01-25 Daniel Vetter : > > > There was a bit of mix-up between initialization and registering. > > > > Signed-off-by: Daniel Vetter > > --- > >

Re: [Intel-gfx] [PATCH v5 0/5] Add support for Legacy HDMI audio drivers

On Wed, 25 Jan 2017 15:45:05 +0100, Jani Nikula wrote: > > On Wed, 25 Jan 2017, Takashi Iwai wrote: > > On Tue, 24 Jan 2017 23:57:48 +0100, > > Jerome Anand wrote: > >> > >> Legacy (CherryTrail/ Baytrail) HDMI audio drivers added > >> Legacy hdmi audio-Gfx interaction/

Re: [Intel-gfx] [PATCH i-g-t v2 04/33] lib/igt_kms: Implement dynamic plane count support

On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > In upcoming drm-misc-next changes, the number of planes per pipe has > been increased as more than one primary plane can be associated with > a pipe. > > The simple fix for this would be to simply bump hardcoded value for > number of frames

Re: [Intel-gfx] [PATCH] x86/gpu: GLK uses the same GMS values as SKL

* Jani Nikula wrote: > On Wed, 25 Jan 2017, Jani Nikula wrote: > > On Wed, 25 Jan 2017, Ingo Molnar wrote: > >> * Paulo Zanoni wrote: > >> > >>> So don't forget to reserve its stolen memory

Re: [Intel-gfx] [PATCH i-g-t v2 16/33] tests/kms_mmio_vs_cs_flip: Add support for dynamic number of planes

Reviewed-by: Mika Kahola On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss > --- >  tests/kms_mmio_vs_cs_flip.c | 6 +++--- >  1

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [1/2] drm/i915: Report the failure to write to the punit

== Series Details == Series: series starting with [1/2] drm/i915: Report the failure to write to the punit URL : https://patchwork.freedesktop.org/series/18549/ State : warning == Summary == Series 18549v1 Series without cover letter

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add MIPI_IO WA and program DSI regulators (rev2)

== Series Details == Series: drm/i915: Add MIPI_IO WA and program DSI regulators (rev2) URL : https://patchwork.freedesktop.org/series/18223/ State : success == Summary == Series 18223v2 drm/i915: Add MIPI_IO WA and program DSI regulators

Re: [Intel-gfx] [PATCH 01/15] drm/kms-helpers: Use recommened kerneldoc for struct member refs

On Wed, Jan 25, 2017 at 10:48:53AM -0200, Gustavo Padovan wrote: > Otherwise looks good to me: Nice catches, fixed them all and applied it. > > Rewiewed-by: Gustavo Padovan Thanks for your review. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation

Re: [Intel-gfx] [PATCH v5 0/5] Add support for Legacy HDMI audio drivers

On Wed, 25 Jan 2017, Takashi Iwai wrote: > On Tue, 24 Jan 2017 23:57:48 +0100, > Jerome Anand wrote: >> >> Legacy (CherryTrail/ Baytrail) HDMI audio drivers added >> Legacy hdmi audio-Gfx interaction/ interfacing is updated to use >> irq chip framework >> >> This patch series

Re: [Intel-gfx] [PATCH 05/15] drm/core: Use recommened kerneldoc for struct member refs

On Wed, Jan 25, 2017 at 10:55:21AM -0200, Gustavo Padovan wrote: > Otherwise looks good: Fixed up all and applied > Reviewed-by: Gustavo Padovan and thanks for your review. -Daniel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch

Re: [Intel-gfx] [PATCH 15/15] drm: Update kerneldoc for drm_crtc.[hc]

On Wednesday, 2017-01-25 07:26:57 +0100, Daniel Vetter wrote: > After going through all the trouble of splitting out parts from > drm_crtc.[hc] and then properly documenting each I've entirely > forgotten to show the same TLC for CRTCs themselves! > > Let's make amends asap. > > Signed-off-by:

[Intel-gfx] [PATCH 2/3] drm: kselftest for drm_mm and bottom-up allocation

Check that if we request bottom-up allocation from drm_mm_insert_node() we receive the next available hole from the bottom. Signed-off-by: Chris Wilson Reviewed-by: Joonas Lahtinen --- drivers/gpu/drm/selftests/drm_mm_selftests.h | 1

[Intel-gfx] [PATCH 3/3] drm/i915: Build DRM range manager selftests for CI

Build the struct drm_mm selftests so that we can trivially run them within our CI. "Enable debug, become developer." - Joonas Lahtinen Signed-off-by: Chris Wilson Reviewed-by: Joonas Lahtinen --- drivers/gpu/drm/i915/Kconfig.debug | 1

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm: Improve drm_mm search (and fix topdown allocation) with rbtrees

== Series Details == Series: series starting with [1/3] drm: Improve drm_mm search (and fix topdown allocation) with rbtrees URL : https://patchwork.freedesktop.org/series/18539/ State : success == Summary == Series 18539v1 Series without cover letter

Re: [Intel-gfx] [PATCH] MAINTAINERS: update new mail list for intel gvt driver

On Wed, 25 Jan 2017, Jani Nikula wrote: > On Wed, 25 Jan 2017, Zhenyu Wang wrote: >> We've moved to lists.freedesktop.org from lists.01.org. >> Update info in MAINTAINERS. > > We should probably get this in v4.10. ...and you'd already

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Squelch smatch warning for statement with no effect

On Fri, 20 Jan 2017, Chris Wilson wrote: > The sgt iterators cause an > > drivers/gpu/drm/i915/i915_gpu_error.c:846 i915_error_object_create() warn: > statement has no effect 7 > > everywhere they are used. If we change the code slightly, we can achieve > the same

Re: [Intel-gfx] [PATCH i-g-t v2 08/33] tests/kms_crtc_background_color: Add support for dynamic number of planes

Reviewed-by: Mika Kahola On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss > --- >  tests/kms_crtc_background_color.c | 2 +- >  

Re: [Intel-gfx] [PATCH i-g-t v2 09/33] tests/kms_cursor_crc: Add support for dynamic number of planes

Reviewed-by: Mika Kahola On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss > --- >  tests/kms_cursor_crc.c | 12 ++-- >  

Re: [Intel-gfx] [PATCH i-g-t v2 07/33] tests/kms_chv_cursor_fail: Add support for dynamic number of planes

Reviewed-by: Mika Kahola   On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss > --- >  tests/kms_chv_cursor_fail.c | 6 +++--- >  

Re: [Intel-gfx] [PATCH v2 02/38] drm/i915: Provide a hook for selftests

On to, 2017-01-19 at 11:41 +, Chris Wilson wrote: > Some pieces of code are independent of hardware but are very tricky to > exercise through the normal userspace ABI or via debugfs hooks. Being > able to create mock unit tests and execute them through CI is vital. > Start by adding a central

Re: [Intel-gfx] [PATCH 2/2] drm/i915: ignore forcewake get/put when using vgpu

> -Original Message- > From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] > Sent: Wednesday, January 25, 2017 3:17 PM > To: Li, Weinan Z > Cc: intel-gfx@lists.freedesktop.org; intel-gvt-...@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915:

Re: [Intel-gfx] [PATCH i-g-t v2 18/33] tests/kms_pipe_color: Add support for dynamic number of planes

Reviewed-by: Mika Kahola On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss > --- >  tests/kms_pipe_color.c | 4 ++-- >  1 file

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/byt: Avoid tweaking evaluation thresholds

== Series Details == Series: drm/i915/byt: Avoid tweaking evaluation thresholds URL : https://patchwork.freedesktop.org/series/18543/ State : success == Summary == Series 18543v1 drm/i915/byt: Avoid tweaking evaluation thresholds

Re: [Intel-gfx] [PATCH v2 37/38] drm/i915: Add mock exercise for i915_gem_gtt_insert

On to, 2017-01-19 at 11:41 +, Chris Wilson wrote: > i915_gem_gtt_insert should allocate from the available free space in the > GTT, evicting as necessary to create space. > > Signed-off-by: Chris Wilson > + list_add(>batch_pool_link, ); Still dislike

Re: [Intel-gfx] [PATCH 04/14] drm/i915: Clean up the .get_cdclk() assignment if ladder

On Tue, Jan 24, 2017 at 02:29:00PM +0200, David Weinehall wrote: > On Fri, Jan 20, 2017 at 08:21:55PM +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Let's clean up the mess we have in the if ladder that assigns the > > .get_cdclk()

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915: noop forcewake get/put when vgpu activated

On Wed, Jan 25, 2017 at 09:44:51PM +0800, Weinan Li wrote: > Host maintian the hardware's forcewake state, guest don't need and also > can't control it. Although vgpu_read/write bypass forcewake_get/put in MMIO > read/write, but still have separate path called by > "intel_uncore_forcewake_get/put"

[Intel-gfx] [PATCH 1/3] drm: Improve drm_mm search (and fix topdown allocation) with rbtrees

The drm_mm range manager claimed to support top-down insertion, but it was neither searching for the top-most hole that could fit the allocation request nor fitting the request to the hole correctly. In order to search the range efficiently, we create a secondary index for the holes using either

[Intel-gfx] [PATCH] drm/i915/byt: Avoid tweaking evaluation thresholds

Certain Baytrails, namely the 4 cpu core variants, have been plaqued by spurious system hangs, mostly occurring with light loads. Multiple bisects by various people point to a commit which changes the reclocking strategy for Baytrail to follow its bigger brethen: commit 8fb55197e64d ("drm/i915:

Re: [Intel-gfx] [PATCH i-g-t v2 15/33] tests/kms_mmap_write_crc: Add support for dynamic number of planes

Reviewed-by: Mika Kahola On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss > --- >  tests/kms_mmap_write_crc.c | 2 +- >  1 file

[Intel-gfx] Broken DPMS with DisplayPort on CHV (also BYT?)

Hi, we've got a bug report about the blank monitor on Cherry Trail machines. And, Intel team (Cc'ed) spotted out that this seems triggered by DPMS transition. A patch like below actually fixes the problem. Of course it doesn't look like a right "fix". Do you guys have any hint for further

Re: [Intel-gfx] [PATCH 06/15] drm/doc: Clarify connector overview

Hi Daniel, 2017-01-25 Daniel Vetter : > There was a bit of mix-up between initialization and registering. > > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/drm_connector.c | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-)

Re: [Intel-gfx] [PATCH] drm/i915/byt: Avoid tweaking evaluation thresholds

Chris Wilson writes: > On Wed, Jan 25, 2017 at 02:31:08PM +0200, Mika Kuoppala wrote: >> Certain Baytrails, namely the 4 cpu core variants, have been >> plaqued by spurious system hangs, mostly occurring with light loads. >> >> Multiple bisects by various people point

Re: [Intel-gfx] [PATCH v2 36/38] drm/i915: Add mock exercise for i915_gem_gtt_reserve

On to, 2017-01-19 at 11:41 +, Chris Wilson wrote: > i915_gem_gtt_reserve should put the node exactly as requested in the > GTT, evicting as required. > > Signed-off-by: Chris Wilson I might de-magic 2*I915_GTT_PAGE_SIZE and couple of expect helpers, but regardless;

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Silence smatch for cmdparser

On Fri, 20 Jan 2017, Chris Wilson wrote: > drivers/gpu/drm/i915/i915_cmd_parser.c:808:23: error: not an lvalue > drivers/gpu/drm/i915/i915_cmd_parser.c:811:23: error: not an lvalue > drivers/gpu/drm/i915/i915_cmd_parser.c:814:23: error: not an lvalue >

Re: [Intel-gfx] [PATCH v2 01/38] drm: Provide a driver hook for drm_dev_release()

On Wed, Jan 25, 2017 at 01:12:21PM +0200, Joonas Lahtinen wrote: > On to, 2017-01-19 at 11:41 +, Chris Wilson wrote: > > Some state is coupled into the device lifetime outside of the > > load/unload timeframe and requires teardown during final unreference > > from drm_dev_release(). For

Re: [Intel-gfx] [PATCH] x86/gpu: GLK uses the same GMS values as SKL

On Wed, 25 Jan 2017, Ingo Molnar wrote: > * Paulo Zanoni wrote: > >> So don't forget to reserve its stolen memory bits. >> >> Cc: Ingo Molnar >> Cc: H. Peter Anvin >> Cc: Ander Conselvan de Oliveira

Re: [Intel-gfx] [PATCH 01/15] drm/kms-helpers: Use recommened kerneldoc for struct member refs

Hi Daniel, 2017-01-25 Daniel Vetter : > I just learned that _name.member_name works and looks pretty > even. It doesn't (yet) link to the member directly though, which would > be really good for big structures or vfunc tables (where the > per-member kerneldoc tends to be

Re: [Intel-gfx] [PATCH] drm/i915/byt: Avoid tweaking evaluation thresholds

Chris Wilson writes: > On Wed, Jan 25, 2017 at 03:09:04PM +0200, Mika Kuoppala wrote: >> Chris Wilson writes: >> >> > On Wed, Jan 25, 2017 at 02:31:08PM +0200, Mika Kuoppala wrote: >> >> Certain Baytrails, namely the 4 cpu core variants, have

Re: [Intel-gfx] [PATCH 03/15] drm/kms-core: Use recommened kerneldoc for struct member refs

On Wednesday, 2017-01-25 07:26:45 +0100, Daniel Vetter wrote: > I just learned that _name.member_name works and looks pretty > even. It doesn't (yet) link to the member directly though, which would > be really good for big structures or vfunc tables (where the > per-member kerneldoc tends to be

[Intel-gfx] [REGRESSION] Black screen after switching desktop session (was: Re: Linux 4.10-rc5)

Am Sonntag, 22. Januar 2017, 13:32:08 CET schrieb Linus Torvalds: > Things seem to be calming down a bit, and everything looks nominal. > > There's only been about 250 changes (not counting merges) in the last > week, and the diffstat touches less than 300 files (with drivers and > architecture

Re: [Intel-gfx] [PATCH i-g-t v2 11/33] tests/kms_fbc_crc: Add support for dynamic number of planes

On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss > --- >  tests/kms_fbc_crc.c | 9 + >  1 file changed, 5 insertions(+), 4 deletions(-) > >

Re: [Intel-gfx] [PATCH i-g-t v2 14/33] tests/kms_legacy_colorkey: Add support for dynamic number of planes

Reviewed-by: Mika Kahola On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss > --- >  tests/kms_legacy_colorkey.c | 4 +++- >  1

Re: [Intel-gfx] [PATCH] drm/i915/byt: Avoid tweaking evaluation thresholds

On Wed, Jan 25, 2017 at 02:31:08PM +0200, Mika Kuoppala wrote: > Certain Baytrails, namely the 4 cpu core variants, have been > plaqued by spurious system hangs, mostly occurring with light loads. > > Multiple bisects by various people point to a commit which changes the > reclocking strategy for

Re: [Intel-gfx] [PATCH i-g-t v2 19/33] tests/kms_plane: Add support for dynamic number of planes

On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss > --- >  tests/kms_plane.c | 94 ++--- > -- >  1 file

[Intel-gfx] [PATCH v2 3/3] drm/i915: clean up unused vgpu_read/write

Signed-off-by: Weinan Li --- drivers/gpu/drm/i915/intel_uncore.c | 58 - 1 file changed, 58 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c index 9fad4de..e9046fa 100644 ---

[Intel-gfx] [PATCH v2 2/3] drm/i915: noop forcewake get/put when vgpu activated

Host maintian the hardware's forcewake state, guest don't need and also can't control it. Although vgpu_read/write bypass forcewake_get/put in MMIO read/write, but still have separate path called by "intel_uncore_forcewake_get/put" and "intel_uncore_forcewake_get/put__locked". Unnecessary MMIO

Re: [Intel-gfx] [PATCH v2 01/38] drm: Provide a driver hook for drm_dev_release()

On to, 2017-01-19 at 11:41 +, Chris Wilson wrote: > Some state is coupled into the device lifetime outside of the > load/unload timeframe and requires teardown during final unreference > from drm_dev_release(). For example, dmabufs hold both a device and > module reference and may live longer

Re: [Intel-gfx] [PATCH] x86/gpu: GLK uses the same GMS values as SKL

(Now without the typo in Daniel's address; apologies for the extra noise.) On Wed, 25 Jan 2017, Jani Nikula wrote: > On Wed, 25 Jan 2017, Ingo Molnar wrote: >> * Paulo Zanoni wrote: >> >>> So don't forget to reserve its

Re: [Intel-gfx] [PATCH] drm/i915: Add MIPI_IO WA and program DSI regulators

>-Original Message- >From: Nikula, Jani >Sent: Thursday, January 19, 2017 4:34 PM >To: Srinivas, Vidya ; intel- >g...@lists.freedesktop.org >Cc: Shankar, Uma ; Syrjala, Ville > >Subject: Re: [PATCH] drm/i915: Add

[Intel-gfx] [PATCH 1/2] drm/i915: Report the failure to write to the punit

The write to the punit may fail, so propagate the error code back to its callers. Of particular interest are the RPS writes, so add appropriate user error codes and logging. Signed-off-by: Chris Wilson Cc: Mika Kuoppala ---

[Intel-gfx] [PATCH 2/2] drm/i915: Also clear the punit's PDATA sideband register

As the previous punit i/o may have failed, the contents of the PDATA are undefined. Always clear it to 0 prior to sending the command. Signed-off-by: Chris Wilson Cc: Mika Kuoppala --- drivers/gpu/drm/i915/intel_sideband.c | 4 +--- 1 file

Re: [Intel-gfx] [PATCH] MAINTAINERS: update new mail list for intel gvt driver

On Wed, 25 Jan 2017, Zhenyu Wang wrote: > We've moved to lists.freedesktop.org from lists.01.org. > Update info in MAINTAINERS. We should probably get this in v4.10. Fixes: 66a46e9df043 ("MAINTAINERS: Add new Intel GVT-g driver maintainer") Side note, in the admin

[Intel-gfx] [PATCH v3 4/4] drm: Resurrect atomic rmfb code, v3

This was somehow lost between v3 and the merged version in Maarten's patch merged as: commit f2d580b9a8149735cbc4b59c4a8df60173658140 Author: Maarten Lankhorst Date: Wed May 4 14:38:26 2016 +0200 drm/core: Do not preserve framebuffer on rmfb, v4. This

Re: [Intel-gfx] [PATCH i-g-t v2 12/33] tests/kms_fence_pin_leak: Add support for dynamic number of planes

Reviewed-by: Mika Kahola On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss > --- >  tests/kms_fence_pin_leak.c | 2 +- >  1 file

Re: [Intel-gfx] [PATCH i-g-t v2 13/33] tests/kms_flip_event_leak: Add support for dynamic number of planes

Reviewed-by: Mika Kahola On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss > --- >  tests/kms_flip_event_leak.c | 2 +- >  1

Re: [Intel-gfx] [PATCH 02/15] drm/bridge: Use recommened kerneldoc for struct member refs

On Wed, Jan 25, 2017 at 03:03:42PM +0530, Archit Taneja wrote: > > > On 01/25/2017 11:56 AM, Daniel Vetter wrote: > > I just learned that _name.member_name works and looks pretty > > even. It doesn't (yet) link to the member directly though, which would > > be really good for big structures or

Re: [Intel-gfx] [PATCH 04/15] drm/gem|prime|mm: Use recommened kerneldoc for struct member refs

Hi Daniel, 2017-01-25 Daniel Vetter : > I just learned that _name.member_name works and looks pretty > even. It doesn't (yet) link to the member directly though, which would > be really good for big structures or vfunc tables (where the > per-member kerneldoc tends to be

Re: [Intel-gfx] [PATCH 07/15] drm/gma500: Nuke device_is_agp callback

Hi Daniel, 2017-01-25 Daniel Vetter : > Returning 0 for an on-chip gpu doesn't change anything at all. > > Cc: Patrik Jakobsson > Signed-off-by: Daniel Vetter > --- > drivers/gpu/drm/gma500/psb_drv.c | 6 -- >

Re: [Intel-gfx] [PATCH] drm/i915/byt: Avoid tweaking evaluation thresholds

On Wed, Jan 25, 2017 at 03:09:04PM +0200, Mika Kuoppala wrote: > Chris Wilson writes: > > > On Wed, Jan 25, 2017 at 02:31:08PM +0200, Mika Kuoppala wrote: > >> Certain Baytrails, namely the 4 cpu core variants, have been > >> plaqued by spurious system hangs, mostly

Re: [Intel-gfx] [PATCH v5 0/5] Add support for Legacy HDMI audio drivers

On Tue, 24 Jan 2017 23:57:48 +0100, Jerome Anand wrote: > > Legacy (CherryTrail/ Baytrail) HDMI audio drivers added > Legacy hdmi audio-Gfx interaction/ interfacing is updated to use > irq chip framework > > This patch series has only been tested on hardware with > a single HDMI connector/pipe

Re: [Intel-gfx] [GIT PULL] GVT-g fixes for 4.10-rc6

On Wed, 25 Jan 2017, Zhenyu Wang wrote: > Hi, > > This is gvt fixes for rc6 including shadow batch buffer re-enable > which was falsely turned off during initial upstream merge, which is a > security issue, Tina re-enabled and verified with Chris's patch too. > Also

Re: [Intel-gfx] [PATCH i-g-t v2 05/33] tests/kms_atomic_transition: Add support for dynamic number of planes

Reviewed-by: Mika Kahola On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss > --- >  tests/kms_atomic_transition.c | 27

Re: [Intel-gfx] [PATCH i-g-t v2 06/33] tests/kms_busy: Add support for dynamic number of planes

Reviewed-by: Mika Kahola On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss > --- >  tests/kms_busy.c | 2 +- >  1 file changed,

Re: [Intel-gfx] [PATCH i-g-t v2 17/33] tests/kms_panel_fitting: Add support for dynamic number of planes

Reviewed-by: Mika Kahola On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss > --- >  tests/kms_panel_fitting.c | 16

Re: [Intel-gfx] [PATCH 05/15] drm/core: Use recommened kerneldoc for struct member refs

Hi Daniel, 2017-01-25 Daniel Vetter : > I just learned that _name.member_name works and looks pretty > even. It doesn't (yet) link to the member directly though, which would > be really good for big structures or vfunc tables (where the > per-member kerneldoc tends to be

Re: [Intel-gfx] DP Aux interfaces inquiry

On Tue, Jan 24, 2017 at 07:51:28PM +, mario.limoncie...@dell.com wrote: > Hi, > > Recently Synaptics collaborated with Dell on a plugin [1] for fwupd that > allows flashing Synaptics MST hubs using the DP aux interface to manipulate > the DPCD [2]. > Currently the plugin hardcodes the max

Re: [Intel-gfx] [PATCH 15/15] drm: Update kerneldoc for drm_crtc.[hc]

On Wed, Jan 25, 2017 at 02:26:09PM +, Eric Engestrom wrote: > On Wednesday, 2017-01-25 07:26:57 +0100, Daniel Vetter wrote: > > After going through all the trouble of splitting out parts from > > drm_crtc.[hc] and then properly documenting each I've entirely > > forgotten to show the same TLC

Re: [Intel-gfx] [PATCH 1/5] drm/i915/perf: fix gen7_append_oa_reports comment

On 24 January 2017 at 01:25, Robert Bragg wrote: > If I'm going to complain about a back-to-front convention then the least > I can do is not muddle the comment up too. > > Signed-off-by: Robert Bragg Reviewed-by: Matthew Auld

Re: [Intel-gfx] [PATCH 4/5] drm/i915/perf: no head/tail ref in gen7_oa_read

On 24 January 2017 at 01:25, Robert Bragg wrote: > This avoids redundantly passing an (inout) head and tail pointer to > gen7_append_oa_reports() from gen7_oa_read which doesn't need to > reference either itself. > > Moving the head/tail reads and writes into

Re: [Intel-gfx] [PATCH 5/5] drm/i915/perf: improve tail race workaround

On 24 January 2017 at 01:25, Robert Bragg wrote: > There's a HW race condition between OA unit tail pointer register > updates and writes to memory whereby the tail pointer can sometimes get > ahead of what's been written out to the OA buffer so far (in terms of > what's

Re: [Intel-gfx] DP Aux interfaces inquiry

Thanks for your comments. Some nested below. > -Original Message- > From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > Sent: Wednesday, January 25, 2017 9:57 AM > To: Limonciello, Mario > Cc: intel-gfx@lists.freedesktop.org > Subject: Re:

Re: [Intel-gfx] [PATCH] drm: Don't race connector registration

On Wed, Jan 25, 2017 at 07:20:45AM -0800, Dave Hansen wrote: > On 01/24/2017 10:21 PM, Daniel Vetter wrote: > > Hi Dave, > > > > Still waiting for your testing results on this one here ... > > It's definitely stable with that patch applied. No more crashes. > > But, it's also definitely having

Re: [Intel-gfx] [PATCH 2/5] drm/i915/perf: avoid poll, read, EAGAIN busy loops

On 24 January 2017 at 01:25, Robert Bragg wrote: > If the function for checking whether there is OA buffer data available > (during a poll or blocking read) has false positives then we want to > avoid a situation where the subsequent read() returns EAGAIN (after > a more

Re: [Intel-gfx] [PATCH 3/5] drm/i915/perf: avoid read back of head register

On 24 January 2017 at 01:25, Robert Bragg wrote: > There's no need for the driver to keep reading back the head pointer > from hardware since the hardware doesn't update it automatically. This > way we can treat any invalid head pointer value as a software/driver > bug

Re: [Intel-gfx] [PATCH v2] drm/dp/mst: fix kernel oops when turning off secondary monitor

I tested this patch in dinq on a KBL system and it fixed the bug. The system doesn't crash on disconnecting or powering off the second monitor in the DP-MST chain. I also replied to the Bugzilla issue. Tested-by: Nathan D Ciobanu On 12/05/2016 01:49 PM,

Re: [Intel-gfx] [PATCH 07/15] drm/gma500: Nuke device_is_agp callback

On Wed, Jan 25, 2017 at 7:26 AM, Daniel Vetter wrote: > Returning 0 for an on-chip gpu doesn't change anything at all. > > Cc: Patrik Jakobsson > Signed-off-by: Daniel Vetter Acked-by: Patrik Jakobsson

Re: [Intel-gfx] [PATCH 14/15] drm: s/drm_crtc_get_hv_timings/drm_mode_get_hv_timings/

On Wed, Jan 25, 2017 at 1:26 AM, Daniel Vetter wrote: > The function operates on modes, not CRTCs. Also move it into > drm_modes.[hc]. Spotted while reviewing CRTC docs. > > Signed-off-by: Daniel Vetter Reviewed-by: Alex Deucher

Re: [Intel-gfx] DP Aux interfaces inquiry

On Wed, Jan 25, 2017 at 09:13:44AM -0800, Rafael Antognolli wrote: > Hi Mario, please see below... > > On Wed, Jan 25, 2017 at 04:43:58PM +, mario.limoncie...@dell.com wrote: > > Thanks for your comments. Some nested below. > > > > > -Original Message- > > > From: Ville Syrjälä

Re: [Intel-gfx] [PATCH 12/15] drm/moc: Mark legacy fields in drm_driver as such

On Wed, Jan 25, 2017 at 1:26 AM, Daniel Vetter wrote: > No point in documenting these, they only confuse. > > Signed-off-by: Daniel Vetter Reviewed-by: Alex Deucher > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c |

Re: [Intel-gfx] DP Aux interfaces inquiry

Hi Mario, please see below... On Wed, Jan 25, 2017 at 04:43:58PM +, mario.limoncie...@dell.com wrote: > Thanks for your comments. Some nested below. > > > -Original Message- > > From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > > Sent: Wednesday, January 25, 2017 9:57 AM

[Intel-gfx] [PATCH] drm/i915: Remove early pre-production RPS workarounds for BXT

Remove WaGsvDisableTurbo and WaRsUseTimeoutMode as these were only for pre-production Broxton devices, and this code is now defunct. Signed-off-by: Chris Wilson Cc: Mika Kuoppala Cc: Joonas Lahtinen ---

Re: [Intel-gfx] [PATCH 09/15] drm/mga: remove device_is_agp callback

On Wed, Jan 25, 2017 at 1:26 AM, Daniel Vetter wrote: > It's only for a device quirk, and we might as well do that in the load > callback. > > Signed-off-by: Daniel Vetter Acked-by: Alex Deucher > --- >

Re: [Intel-gfx] [PATCH 08/15] drm/i810: drop device_is_agp callback

On Wed, Jan 25, 2017 at 1:26 AM, Daniel Vetter wrote: > Use the same trick we used for i915 when we still had ums support: > Just initialize the agp support unconditionally in the driver load > function. > > Unfortunately that means we need to export drm_agp_init again,

Re: [Intel-gfx] [PATCH 10/15] drm: remove device_is_agp callback

On Wed, Jan 25, 2017 at 1:26 AM, Daniel Vetter wrote: > With that the drm_pci_device_is_agp function becomes trivial, so > inline that too. And while at it, move the drm_pci_agp_destroy > declaration into drm-internal.h, since it's not used by drivers. > > Cc: Alex Deucher

Re: [Intel-gfx] [PATCH v2 4/9] drm: Add driver private objects to atomic state

On 2017-01-25 12:59 AM, Daniel Vetter wrote: > On Tue, Jan 24, 2017 at 03:49:32PM -0800, Dhinakaran Pandiyan wrote: >> It is necessary to track states for objects other than connector, crtc >> and plane for atomic modesets. But adding objects like DP MST link >> bandwidth to drm_atomic_state would

Re: [Intel-gfx] [PATCH v5 0/5] Add support for Legacy HDMI audio drivers

On 1/25/17 3:21 PM, Takashi Iwai wrote: On Tue, 24 Jan 2017 23:57:48 +0100, Jerome Anand wrote: This patch series has only been tested on hardware with a single HDMI connector/pipe and additional work may be needed for newer machines with 2 connectors BTW, I have such a machine, CHV with two

Re: [Intel-gfx] [PATCH v2] drm/dp/mst: fix kernel oops when turning off secondary monitor

I tested this on a KBL using 01-25-2017 dinq and it fixed the bug. Tested-by: Nathan D Ciobanu On 12/05/2016 01:49 PM, Pierre-Louis Bossart wrote: 100% reproducible issue found on SKL SkullCanyon NUC with two external DP daisy-chained monitors in DP/MST

[Intel-gfx] [bug report] drm/i915/gvt/kvmgt: add vfio/mdev support to KVMGT

Hello Jike Song, The patch 659643f7d814: "drm/i915/gvt/kvmgt: add vfio/mdev support to KVMGT" from Dec 8, 2016, leads to the following static checker warning: drivers/gpu/drm/i915/gvt/kvmgt.c:969 intel_vgpu_ioctl() warn: calling kfree() when 'caps.buf' is always NULL.

  1   2   >