Re: [Intel-gfx] [PATCH i-g-t] i915_pciids: Change a KBL pci id to GT2 from GT1.5

On Thu, Sep 21, 2017 at 2:58 PM, Rodrigo Vivi wrote: > In sync with 41693fd52373 ("drm/i915/kbl: Change a KBL pci id > to GT2 from GT1.5") > > "See Mesa commit 9c588ff" > > Cc: Anuj Phogat > Signed-off-by: Rodrigo Vivi > ---

Re: [Intel-gfx] [PATCH v5 5/7] drm/i915/guc: Fix GuC cleanup in unload path

On Thu, 21 Sep 2017 19:38:49 +0200, Sagar Arun Kamble wrote: We ensure that GuC is completely suspended and client is destroyed in i915_gem_suspend during i915_driver_unload. So now intel_uc_fini_hw should just take care of cleanup, hence

Re: [Intel-gfx] [PATCH v4 4/9] drm/i915/guc: Update suspend functionality in intel_uc_suspend path

On Thu, Sep 21, 2017 at 10:25:50PM +0530, Sagar Arun Kamble wrote: [SNIP] > > > + ret = intel_uc_runtime_suspend(dev_priv); > > > + if (ret) > > > + return ret; > > return intel_guc_runtime_suspend(dev_priv); > Did you really mean intel_*guc*_runtime_suspend here or was typo? Typo -

Re: [Intel-gfx] [igt] igt/kms_psr_sink_crc: Fix regression in psr_drrs subtest

> -Original Message- > From: Vivi, Rodrigo > Sent: Thursday, September 21, 2017 7:54 AM > To: Sripada, Radhakrishna > Cc: intel-gfx@lists.freedesktop.org; Pandiyan, Dhinakaran > > Subject: Re: [igt] igt/kms_psr_sink_crc:

[Intel-gfx] [PATCH i-g-t] i915_pciids: Change a KBL pci id to GT2 from GT1.5

In sync with 41693fd52373 ("drm/i915/kbl: Change a KBL pci id to GT2 from GT1.5") "See Mesa commit 9c588ff" Cc: Anuj Phogat Signed-off-by: Rodrigo Vivi --- lib/i915_pciids.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Intel-gfx] [PATCH] drm/i915: Confirm request->global_seqno after spin completion

After we see our target seqno has been completed by the hw, we need to confirm that it still matches the request (as it may have been preempted before the spin completes). If the request no longer matches the target seqno, we need to restart the wait to reacquire that seqno. Signed-off-by: Chris

Re: [Intel-gfx] [PATCH i-g-t] i915_pciids: Change a KBL pci id to GT2 from GT1.5

On Thu, Sep 21, 2017 at 10:03:48PM +, Anuj Phogat wrote: > On Thu, Sep 21, 2017 at 2:58 PM, Rodrigo Vivi wrote: > > In sync with 41693fd52373 ("drm/i915/kbl: Change a KBL pci id > > to GT2 from GT1.5") > > > > "See Mesa commit 9c588ff" > > > > Cc: Anuj Phogat

[Intel-gfx] [PATCH] drm/i915/cnl: Add Gen10 LRC size

The total size of the context has decreased with the removal of the URB_ATOMIC section. BSpec indicates 16750 DWORDs (17 pages), plus one page for PPHWSP, and I'm throwing an extra page for precaution. Signed-off-by: Oscar Mateo Cc: Rodrigo Vivi

Re: [Intel-gfx] [PATCH libdrm V2 2/2] intel: Change a KBL pci id to GT2 from GT1.5

On Wed, Sep 20, 2017 at 2:35 PM, Rodrigo Vivi wrote: > On Wed, Sep 20, 2017 at 07:11:03PM +, Anuj Phogat wrote: >> See Mesa commit 9c588ff >> >> Cc: Matt Turner >> Cc: Rodrigo Vivi >> Signed-off-by: Anuj Phogat

Re: [Intel-gfx] [PATCH] drm/i915: Confirm request->global_seqno after spin completion

On Thu, Sep 21, 2017 at 10:09:03PM +0100, Chris Wilson wrote: > After we see our target seqno has been completed by the hw, we need to > confirm that it still matches the request (as it may have been preempted > before the spin completes). If the request no longer matches the target > seqno, we

Re: [Intel-gfx] [PATCH 08/10] drm/i915/guc: Fix GuC HW/SW state cleanup in unload path

This was reply to older series hence I replied patch there. Will update w.r.t new series. On 9/22/2017 12:03 AM, Oscar Mateo wrote: On 09/17/2017 05:17 AM, Sagar Arun Kamble wrote: Teardown of GuC HW/SW state was not properly done in unload path. guc_submission_disable was called as part

Re: [Intel-gfx] [igt v2] igt/kms_psr_sink_crc: Fix the bug in psr_drrs subtest

Reviewed-by: Rodrigo Vivi I'll merge this and DK's one you reviewed as soon as I recharge my laptop! :) > On Sep 21, 2017, at 5:19 PM, Sripada, Radhakrishna > wrote: > > The substring to be matched is "DRRS Supported: Yes" and not >

[Intel-gfx] [PATCH v6 4/7] drm/i915/guc: Disable GuC submission and suspend it prior to i915 reset

Before i915 reset, we need to disable GuC submission and suspend GuC operations as it is recreated during intel_uc_init_hw. We can't reuse the intel_uc_suspend functionality as reset path already holds struct_mutex. v2: Rebase w.r.t removal of GuC code restructuring. Updated reset_prepare

[Intel-gfx] [PATCH v6 6/7] drm/i915/guc: Enable default/critical logging in GuC by default from GuC v9

With GuC v9, new type of Default/critical logging in GuC to enable capturing minimal important logs in production systems efficiently. This patch enables this logging in GuC by default always. It should be noted that streaming support with half-full interrupt mechanism that is present for normal

[Intel-gfx] [PATCH v6 7/7] drm/i915: Reorganize HuC authentication

Prepared intel_auth_huc to separate HuC specific functionality from GuC send action. Created new header intel_huc.h to group HuC specific declarations. v2: Changed argument preparation for AUTHENTICATE_HUC. s/intel_auth_huc/intel_huc_auth. Deferred creation of intel_huc.h to later patch. v3:

[Intel-gfx] [PATCH v6 1/7] drm/i915: Create uc runtime and system suspend/resume helpers

Prepared generic helpers intel_uc_suspend, intel_uc_resume, intel_uc_runtime_suspend, intel_uc_runtime_resume. Added error handling to all the calls for suspend/resume. v2: Rebase w.r.t removal of GuC code restructuring. Cc: Michal Wajdeczko Cc: Michał Winiarski

[Intel-gfx] [PATCH v6 0/7] GuC Fixes, HuC auth. reorg and v9+ logging change

Updated patch 3 and patch 5. Sagar Arun Kamble (7): drm/i915: Create uc runtime and system suspend/resume helpers drm/i915/guc: Update GuC ggtt.invalidate/interrupts/communication across RPM suspend/resume drm/i915/guc: Update GuC suspend functionality in intel_uc_suspend path

[Intel-gfx] [PATCH v6 5/7] drm/i915/guc: Fix GuC cleanup in unload path

We ensure that GuC is completely suspended and client is destroyed in i915_gem_suspend during i915_driver_unload. So now intel_uc_fini_hw should just take care of cleanup, hence s/intel_uc_fini_hw/intel_uc_cleanup. Correspondingly we also updated as

Re: [Intel-gfx] [PATCH v4 7/9] drm/i915/guc: Remove i915_guc_log_unregister

On Thu, 21 Sep 2017 19:40:04 +0200, Sagar Arun Kamble wrote: On 9/21/2017 11:01 PM, Sagar Arun Kamble wrote: On 9/21/2017 2:28 AM, Michal Wajdeczko wrote: On Wed, 20 Sep 2017 19:38:22 +0200, Sagar Arun Kamble wrote: Functionality

Re: [Intel-gfx] [PATCH libdrm V2 2/2] intel: Change a KBL pci id to GT2 from GT1.5

On Thu, Sep 21, 2017 at 08:42:59PM +, Anuj Phogat wrote: > On Wed, Sep 20, 2017 at 2:35 PM, Rodrigo Vivi wrote: > > On Wed, Sep 20, 2017 at 07:11:03PM +, Anuj Phogat wrote: > >> See Mesa commit 9c588ff > >> > >> Cc: Matt Turner > >> Cc: Rodrigo

[Intel-gfx] [igt v2] igt/kms_psr_sink_crc: Fix the bug in psr_drrs subtest

The substring to be matched is "DRRS Supported: Yes" and not "DRRS Support: No". The kernel prints the DRRS status for all active CRTC's. Matching for No support gives a false positive when multiple CRTC's are active. Fixes: 33355210a43e (igt/kms_psr_sink_crc: Add psr_drrs subtest) Cc: C.

Re: [Intel-gfx] [PATCH igt] igt/kms_cursor_legacy: Use common spinbatch

On Thu, Sep 14, 2017 at 02:19:34PM +0100, Chris Wilson wrote: > Remove the local recursive spinner in favour of igt_spin_t. > > Signed-off-by: Chris Wilson Reviewed-by: Ville Syrjälä > --- > tests/kms_cursor_legacy.c | 103 >

Re: [Intel-gfx] [GIT PULL] gvt-next pull

On Fri, 08 Sep 2017, Zhenyu Wang wrote: > Hi, > > This is an earlier request for gvt-next pull which is mainly > for required PCI config changes on OVMF support for Redhat and > also contains massive error handling improvement on workload > submission. Both are targeted

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Eliminate DDI encoder->type frobbery redux (rev3)

== Series Details == Series: drm/i915: Eliminate DDI encoder->type frobbery redux (rev3) URL : https://patchwork.freedesktop.org/series/30548/ State : failure == Summary == Series 30548v3 drm/i915: Eliminate DDI encoder->type frobbery redux

Re: [Intel-gfx] [PATCH] dim: Accept author x signed-off based on email.

On Thu, Sep 21, 2017 at 11:12:52AM +, Jani Nikula wrote: > On Wed, 20 Sep 2017, Rodrigo Vivi wrote: > > It seems Patchwork or SMTP servers are messing some patches > > and changing the original git's author name on git per "Last, First". > > So we end up with a

Re: [Intel-gfx] [PATCH v6 3/3] drm/i915: Make i915_modparams members const

On Wed, 20 Sep 2017, Joonas Lahtinen wrote: > On Wed, 2017-09-20 at 15:01 +0300, Jani Nikula wrote: >> On Wed, 20 Sep 2017, Joonas Lahtinen wrote: >> > On Tue, 2017-09-19 at 19:38 +, Michal Wajdeczko wrote: >> > > We should

Re: [Intel-gfx] [PATCH igt] igt/prime_vgem: Split out the fine-grain coherency check

On Thu, Sep 21, 2017 at 11:59:29AM +0100, Chris Wilson wrote: > Quoting Michał Winiarski (2017-09-20 11:48:54) > > On Tue, Sep 19, 2017 at 01:21:08PM +0100, Chris Wilson wrote: > > > Quoting Chris Wilson (2017-09-07 15:30:55) > > > > We don't expect every machine to be able to pass the WC/GTT

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [v6,1/3] drm/i915: Rename global i915 to i915_modparams

== Series Details == Series: series starting with [v6,1/3] drm/i915: Rename global i915 to i915_modparams URL : https://patchwork.freedesktop.org/series/30621/ State : warning == Summary == Series 30621v1 series starting with [v6,1/3] drm/i915: Rename global i915 to i915_modparams

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Make own struct for execlist items

Quoting Mika Kuoppala (2017-09-20 15:36:58) > Engine's execlist related items have been increasing to > a point where a separate struct is warranted. Carve execlist > specific items to a dedicated struct to add clarity. > > v2: add kerneldoc and fix whitespace (Joonas, Chris) > v3: csb_mmio

Re: [Intel-gfx] [PATCH 8/8] drm/i915: Improve GuC request coalescing

On Wed, Sep 20, 2017 at 05:37:05PM +0300, Mika Kuoppala wrote: > Now that we can keep track of what ports we have > dequeued, coalesce only those ports instead of iterating > through all ports. s/coalesce/submit. By coalescing I meant that we're no longer have a 1:1 relationship between a

Re: [Intel-gfx] [PATCH 16/31] drm/i915/slpc: Lay out SLPC init/enable/disable/cleanup helpers

On Tue, 19 Sep 2017 19:41:52 +0200, Sagar Arun Kamble wrote: SLPC operates based on parameters setup in shared data between i915 and GuC SLPC. This is to be created/initialized in intel_slpc_init. From there onwards i915 can control the SLPC operations by Enabling,

[Intel-gfx] [PATCH] drm/i915: Document the split in internal and public execbuf flags

Since we reuse the same field for the user passing in their control flags, and for the kernel to track a couple of bits of state, document and check that those do not overlap. Suggested-by: Tvrtko Ursulin Signed-off-by: Chris Wilson Cc: Tvrtko

[Intel-gfx] [PATCH v2 25/29] drm/i915: Stop frobbing with DDI encoder->type

From: Ville Syrjälä Currently the DDI encoder->type will change at runtime depending on what kind of hotplugs we've processed. That's quite bad since we can't really trust that that current value of encoder->type actually matches the type of signal we're trying to

Re: [Intel-gfx] [PATCH i-g-t] igt/kms_rotation_crc : Fix flip tests for sprite plane

Thanks Maarten, Tested-by: Marta Lofstedt Acked-by: Marta Lofstedt > -Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf > Of Maarten Lankhorst > Sent: Thursday, September 21, 2017 9:38 AM >

Re: [Intel-gfx] [PATCH 3/8] drm/i915: Wrap port cancellation into a function

On Wed, Sep 20, 2017 at 05:37:00PM +0300, Mika Kuoppala wrote: > On reset and wedged path, we want to release the requests > that are tied to ports and then mark the ports to be unset. > Introduce a function for this. > > v2: rebase > > Cc: Chris Wilson >

Re: [Intel-gfx] [PATCH 7/8] drm/i915: Keep track of reserved execlist ports

Quoting Mika Kuoppala (2017-09-20 15:37:04) > To further enchance port processing, keep track of > reserved ports. This way we can iterate only the used subset > of port space. Note that we lift the responsibility of > execlists_submit_request() to inspect hw availability and > always do

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Document the split in internal and public execbuf flags

== Series Details == Series: drm/i915: Document the split in internal and public execbuf flags URL : https://patchwork.freedesktop.org/series/30696/ State : warning == Summary == Series 30696v1 drm/i915: Document the split in internal and public execbuf flags

[Intel-gfx] [PATCH 2/2] drm/i915/lrc: Skip no-op per-bb buffer on gen9

Since we inherited the context image setup from gen8 which needed a per-bb workaround (for GPGPU), we are submitting an empty per-bb buffer on gen9. Now that we can skip adding the buffer to the context image, remove the dangling per-bb. This slightly improves execution latency, most notably on an

Re: [Intel-gfx] [PATCH 21/31] drm/i915/slpc: Send RESET event to enable SLPC during Load/TDR

On Tue, 19 Sep 2017 19:41:57 +0200, Sagar Arun Kamble wrote: Send host2guc SLPC reset event to GuC post GuC load. Post this, i915 can ascertain if SLPC has started running successfully through shared data. This check is done during intel_init_gt_powersave. This

[Intel-gfx] [PATCH v2] drm/i915/bios: ignore HDMI on port A

The hardware state readout oopses after several warnings when trying to use HDMI on port A, if such a combination is configured in VBT. Filter the combo out already at the VBT parsing phase. v2: also ignore DVI (Ville) Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102889 Cc:

Re: [Intel-gfx] force yuv 4:2:0 output

Done. https://bugs.freedesktop.org/show_bug.cgi?id=102928 Let me know if I miss anything or you need me to do more tests. BR, Wolfgang Jani Nikula schrieb am Do., 21. Sep. 2017 um 10:14 Uhr: > > On Wed, 20 Sep 2017, Wolfgang Haupt wrote:

[Intel-gfx] [PATCH i-g-t 3/6] lib/igt_fb: Add igt_cairo_image_surface_create_from_png()

From: Ville Syrjälä Raw usage of cairo_image_surface_create_from_png() doesn't work since it doesn't know about IGT_DATADIR and IGT_SRCDIR. Let's extract the helper from igt_paint_image() that uses igt_fopen_data() + cairo_image_surface_create_from_png_stream() and

[Intel-gfx] [PATCH i-g-t 6/6] tests/kms_draw_crc: Skip tests for unsupported formats

From: Ville Syrjälä 10bpc formats aren't supported on all platforms, so skip the test when we can't create the framebuffer. Signed-off-by: Ville Syrjälä --- tests/kms_draw_crc.c | 23 --- 1 file changed, 20

[Intel-gfx] [PATCH i-g-t 1/6] lib/igt_kms: Don't assert on non-existent plane

From: Ville Syrjälä Skip when a test can't find a plane by the index. Previously in commit 5426dc0a889a ("lib/kms: Skip rather than fail when a suitable plane can't be found") we added similar handling for tests trying to find a non-existent plane by type. Saves

Re: [Intel-gfx] [PATCH 4/8] drm/i915: Add execlist_port_complete

Quoting Mika Kuoppala (2017-09-20 15:37:01) > When first execlist entry is processed, we move the port (contents). > Introduce function for this as execlist and guc use this common > operation. > > v2: rebase. s/GEM_DEBUG_BUG/GEM_BUG (Chris) > > Signed-off-by: Mika Kuoppala

Re: [Intel-gfx] [PATCH 5/8] drm/i915: Make execlist port count variable

Quoting Mika Kuoppala (2017-09-20 15:37:02) > As we emulate execlists on top of the GuC workqueue, it is not > restricted to just 2 ports and we can increase that number arbitrarily > to trade-off queue depth (i.e. scheduling latency) against pipeline > bubbles. > > v2: rebase. better commit msg

Re: [Intel-gfx] [PATCH 8/8] drm/i915: Improve GuC request coalescing

Quoting Mika Kuoppala (2017-09-20 15:37:05) > -static void i915_guc_submit(struct intel_engine_cs *engine) > +static void i915_guc_submit(struct intel_engine_cs *engine, > + const unsigned int first) > { > struct drm_i915_private *dev_priv = engine->i915; >

Re: [Intel-gfx] [PATCH] drm/i915/bios: ignore HDMI on port A

On Thu, Sep 21, 2017 at 04:11:49PM +0300, Jani Nikula wrote: > The hardware state readout oopses after several warnings when trying to > use HDMI on port A, if such a combination is configured in VBT. Filter > the combo out already at the VBT parsing phase. > > Bugzilla:

Re: [Intel-gfx] [PATCH 20/31] drm/i915/slpc: Add parameter set/unset/get, task control/status functions

On Tue, 19 Sep 2017 19:41:56 +0200, Sagar Arun Kamble wrote: SLPC behavior can be changed through set of parameters. These parameters can be updated and queried from i915 though Host to GuC SLPC events. This patch adds parameter update events for

[Intel-gfx] [PATCH 1/2] drm/i915/lrc: Only enable per-context and per-bb buffers if set

The per-context and per-batch workaround buffers are optional, yet we tell the GPU to execute them even if they contain no instructions. Doing so incurs the dispatch latency, which we can avoid if we don't ask the GPU to execute the no-op buffers. Allow ourselves to skip setup of empty buffer, and

Re: [Intel-gfx] [PATCH 3/8] drm/i915: Wrap port cancellation into a function

Michał Winiarski writes: > On Wed, Sep 20, 2017 at 05:37:00PM +0300, Mika Kuoppala wrote: >> On reset and wedged path, we want to release the requests >> that are tied to ports and then mark the ports to be unset. >> Introduce a function for this. >> >> v2: rebase >>

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/bios: ignore HDMI on port A

== Series Details == Series: drm/i915/bios: ignore HDMI on port A URL : https://patchwork.freedesktop.org/series/30700/ State : success == Summary == Series 30700v1 drm/i915/bios: ignore HDMI on port A https://patchwork.freedesktop.org/api/1.0/series/30700/revisions/1/mbox/ Test chamelium:

Re: [Intel-gfx] [PATCH i-g-t 3/9] tests/perf: Add testcase to verify ctx id

On Wed, Sep 13, 2017 at 04:22:02PM +0530, Sagar Arun Kamble wrote: > This subtest verifies that the CS perf samples contains > proper HW context ID as captured through CONTEXT_PARAM_HW_ID. > > v2: Updated property enum names. > > Signed-off-by: Sagar Arun Kamble

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v6,1/3] drm/i915: Rename global i915 to i915_modparams

== Series Details == Series: series starting with [v6,1/3] drm/i915: Rename global i915 to i915_modparams URL : https://patchwork.freedesktop.org/series/30621/ State : success == Summary == Series 30621v1 series starting with [v6,1/3] drm/i915: Rename global i915 to i915_modparams

Re: [Intel-gfx] [PATCH][drm-next] drm/i915/gvt: ensure -ve return value is handled correctly

On Thu, 2017-09-21 at 06:44 +0800, Zhenyu Wang wrote: > On 2017.09.19 19:35:23 -0700, Joe Perches wrote: > > On Wed, 2017-09-20 at 05:46 +0800, Zhenyu Wang wrote: > > > On 2017.09.19 16:55:34 +0100, Colin King wrote: > > > > From: Colin Ian King > > > > > > > > An

[Intel-gfx] [PATCH i-g-t 5/6] tests/kms_panel_fitting: Skip sprite test if we exceed sprite scaling limits

From: Ville Syrjälä g4x-bdw surface isn't allowed to exceed 2kx2k pixels when scaling, and the stride must not exceed 4k bytes. The test tries to scale a 1920x1080 32bpp image which exceeds the sprite's stride limitations. Let's make the test a bit more tolerant

[Intel-gfx] [PATCH i-g-t 2/6] tests/kms_mmio_vs_cs_flip: Reduce blit width

From: Ville Syrjälä The blit stride is a two's complement 16 bit number, so trying to use a stride of 32k would in fact give us -32k. Not sure how this ever worked on anything, but my 945gm sure doesn't like it. The machine dies pretty much instantly. Let's reduce

[Intel-gfx] [PATCH i-g-t 4/6] tests/kms_panel_fitting: Use igt_cairo_image_surface_create_from_png_file()

From: Ville Syrjälä Switch to using igt_cairo_image_surface_create_from_png_file() over the raw cairo version so that the test can actually find the image file no matter where we run it from. Signed-off-by: Ville Syrjälä ---

Re: [Intel-gfx] [PATCH i-g-t 7/9] tests/perf: Add testcase to verify mmio

On Wed, Sep 13, 2017 at 04:22:06PM +0530, Sagar Arun Kamble wrote: > v2: Updated the check for RC6 register value. > Updated property enum names. Defined local_I915_PERF_MMIO_NUM_MAX > and local_drm_i915_perf_mmio_list for local use. > > Signed-off-by: Sagar Arun Kamble

Re: [Intel-gfx] [PATCH 6/8] drm/i915: Introduce execlist_port_* accessors

Chris Wilson writes: > Quoting Mika Kuoppala (2017-09-20 15:37:03) >> Instead of trusting that first available port is at index 0, >> use accessor to hide this. This is a preparation for a >> following patches where head can be at arbitrary location >> in the port

Re: [Intel-gfx] [igt] igt/kms_psr_sink_crc: Fix regression in psr_drrs subtest

On Thu, Sep 21, 2017 at 01:37:31AM +, Radhakrishna Sripada wrote: > The substring to be matched is modified to reflect kernel code. Well, technically it is not a regression on psr_drrs because it has this bug since the beginning ;) Also this commit message doesn't explain the false positive

Re: [Intel-gfx] [PATCH 26/31] drm/i915/slpc: Add i915_slpc_info to debugfs

On Tue, 19 Sep 2017 19:42:02 +0200, Sagar Arun Kamble wrote: From: Tom O'Rourke i915_slpc_info shows the contents of SLPC shared data parsed into text format. v1: Reformat slpc info (Radek) squashed query task state info in slpc

Re: [Intel-gfx] [PATCH 01/31] drm/i915/debugfs: Create generic string tokenize function and update CRC control parsing

On Tue, 19 Sep 2017 19:41:37 +0200, Sagar Arun Kamble wrote: Input string parsing used in CRC control parameter parsing is generic and can be reused for other debugfs interfaces. Hence name it as buffer_tokenize instead of tieing to display_crc. Also fix the

Re: [Intel-gfx] [PATCH 2/2] drm/i915/lrc: Skip no-op per-bb buffer on gen9

On 21/09/2017 14:54, Chris Wilson wrote: Since we inherited the context image setup from gen8 which needed a per-bb workaround (for GPGPU), we are submitting an empty per-bb buffer on gen9. Now that we can skip adding the buffer to the context image, remove the dangling per-bb. This slightly

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v6,1/3] drm/i915: Rename global i915 to i915_modparams

== Series Details == Series: series starting with [v6,1/3] drm/i915: Rename global i915 to i915_modparams URL : https://patchwork.freedesktop.org/series/30621/ State : failure == Summary == Test perf: Subgroup polling: fail -> PASS (shard-hsw) fdo#102252

Re: [Intel-gfx] [PATCH 1/2] drm/dp: Add defines for latency in sink

On Wed, Sep 20, 2017 at 02:32:34PM +, vathsala nagaraju wrote: > Add defines for dpcd register 2009 (synchronization latency > in sink). > > Cc: Rodrigo Vivi > CC: Puthikorn Voravootivat > Signed-off-by: Vathsala Nagaraju

Re: [Intel-gfx] [PATCH 1/2] drm/i915/lrc: Only enable per-context and per-bb buffers if set

On 21/09/2017 14:54, Chris Wilson wrote: The per-context and per-batch workaround buffers are optional, yet we tell the GPU to execute them even if they contain no instructions. Doing so incurs the dispatch latency, which we can avoid if we don't ask the GPU to execute the no-op buffers. Allow

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Eliminate DDI encoder->type frobbery redux (rev4)

== Series Details == Series: drm/i915: Eliminate DDI encoder->type frobbery redux (rev4) URL : https://patchwork.freedesktop.org/series/30548/ State : success == Summary == Series 30548v4 drm/i915: Eliminate DDI encoder->type frobbery redux

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/lrc: Only enable per-context and per-bb buffers if set

== Series Details == Series: series starting with [1/2] drm/i915/lrc: Only enable per-context and per-bb buffers if set URL : https://patchwork.freedesktop.org/series/30701/ State : success == Summary == Series 30701v1 series starting with [1/2] drm/i915/lrc: Only enable per-context and

Re: [Intel-gfx] [PATCH 24/31] drm/i915/slpc: Add debugfs support to read/write/revert the parameters

On Tue, 19 Sep 2017 19:42:00 +0200, Sagar Arun Kamble wrote: This patch adds two debugfs interfaces: 1. i915_slpc_paramlist: List of all parameters that Host can configure. Currently listing id and description of each. 2. i915_slpc_param_ctl: This allows to

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/bios: ignore HDMI on port A (rev2)

== Series Details == Series: drm/i915/bios: ignore HDMI on port A (rev2) URL : https://patchwork.freedesktop.org/series/30700/ State : success == Summary == Series 30700v2 drm/i915/bios: ignore HDMI on port A https://patchwork.freedesktop.org/api/1.0/series/30700/revisions/2/mbox/

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [1/6] lib/igt_kms: Don't assert on non-existent plane

== Series Details == Series: series starting with [1/6] lib/igt_kms: Don't assert on non-existent plane URL : https://patchwork.freedesktop.org/series/30706/ State : warning == Summary == IGT patchset tested on top of latest successful build f86dc17cfc81f53f3bf216009ffda1ac05208bcc

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Document the split in internal and public execbuf flags

Quoting Patchwork (2017-09-21 13:57:48) > == Series Details == > > Series: drm/i915: Document the split in internal and public execbuf flags > URL : https://patchwork.freedesktop.org/series/30696/ > State : warning > > == Summary == > > Series 30696v1 drm/i915: Document the split in internal

[Intel-gfx] [PATCH v3 25/29] drm/i915: Stop frobbing with DDI encoder->type

From: Ville Syrjälä Currently the DDI encoder->type will change at runtime depending on what kind of hotplugs we've processed. That's quite bad since we can't really trust that that current value of encoder->type actually matches the type of signal we're trying to

Re: [Intel-gfx] [PATCH 2/2] drm/i915/lrc: Skip no-op per-bb buffer on gen9

Quoting Tvrtko Ursulin (2017-09-21 16:12:21) > > On 21/09/2017 14:54, Chris Wilson wrote: > > Since we inherited the context image setup from gen8 which needed a > > per-bb workaround (for GPGPU), we are submitting an empty per-bb buffer > > on gen9. Now that we can skip adding the buffer to the

Re: [Intel-gfx] [PATCH][drm-next] drm/i915/gvt: ensure -ve return value is handled correctly

Hi Joonas: Thanks for the introduction. I have been thinking about the possibility of introducing GEM_BUG_ON into GVT-g recently and investigating on it. I'm just a bit confused about the usage between GEM_BUG_ON and WARN_ON. GEM_BUG_ON is only enabled when kernel debug is enabled, which

Re: [Intel-gfx] [PATCH v2] drm/i915/bios: ignore HDMI on port A

On Thu, Sep 21, 2017 at 05:19:20PM +0300, Jani Nikula wrote: > The hardware state readout oopses after several warnings when trying to > use HDMI on port A, if such a combination is configured in VBT. Filter > the combo out already at the VBT parsing phase. > > v2: also ignore DVI (Ville) > >

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Make own struct for execlist items

On Wed, 2017-09-20 at 17:36 +0300, Mika Kuoppala wrote: > Engine's execlist related items have been increasing to > a point where a separate struct is warranted. Carve execlist > specific items to a dedicated struct to add clarity. > > v2: add kerneldoc and fix whitespace (Joonas, Chris) > v3:

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] tools_test: Clean up and fix sysfs_l3_parity

== Series Details == Series: series starting with [1/2] tools_test: Clean up and fix sysfs_l3_parity URL : https://patchwork.freedesktop.org/series/30699/ State : success == Summary == IGT patchset tested on top of latest successful build f86dc17cfc81f53f3bf216009ffda1ac05208bcc

Re: [Intel-gfx] igt/kms_rotation_crc: Add horizontal flip subtest.

On Wed, Sep 20, 2017 at 08:50:37PM -0700, Joseph Garvey wrote: > Test that horizontal flip works with supported rotations. Includes > a fix for the unrotated fb which was not being positioned correctly > with portrait and landscape rectangles. > > Signed-off-by: Joseph Garvey

Re: [Intel-gfx] [PATCH] drm/i915: Document the split in internal and public execbuf flags

On 21/09/2017 12:01, Chris Wilson wrote: Since we reuse the same field for the user passing in their control flags, and for the kernel to track a couple of bits of state, document and check that those do not overlap. Suggested-by: Tvrtko Ursulin Signed-off-by: Chris

Re: [Intel-gfx] [PATCH 6/8] drm/i915: Introduce execlist_port_* accessors

Quoting Mika Kuoppala (2017-09-20 15:37:03) > Instead of trusting that first available port is at index 0, > use accessor to hide this. This is a preparation for a > following patches where head can be at arbitrary location > in the port array. > > v2: improved commit message, elsp_ready

[Intel-gfx] [PATCH i-g-t 1/2] tools_test: Clean up and fix sysfs_l3_parity

Multiple misunderstandings of the expectations of the test and some missed parts of the shell-to-c conversion caused a couple of issues to remain. First, we need to actually disable a subbank before we check that a subbank is disabled (invoke the tool with -d). Second, the original pipe to wc -l

[Intel-gfx] [PATCH i-g-t 2/2] igt_core: Rework igt_system()

Instead of redirecting output to pipes and forking, redirect after forking to avoid having to carefully unredirect before logging anything. igt@tools_test@sysfs_l3_parity had a racy condition where it prints the output of intel_l3_parity prepended by [cmd], but that ended up being printed again

Re: [Intel-gfx] [PATCH] dim: Accept author x signed-off based on email.

On Wed, 20 Sep 2017, Rodrigo Vivi wrote: > It seems Patchwork or SMTP servers are messing some patches > and changing the original git's author name on git per "Last, First". > So we end up with a mismatch were signed-off uses one name format > and author is using another

Re: [Intel-gfx] [PATCH 3/8] drm/i915: Wrap port cancellation into a function

Quoting Mika Kuoppala (2017-09-20 15:37:00) > On reset and wedged path, we want to release the requests > that are tied to ports and then mark the ports to be unset. > Introduce a function for this. > > v2: rebase > > Cc: Chris Wilson > Signed-off-by: Mika Kuoppala

Re: [Intel-gfx] [PATCH 2/8] drm/i915: Move execlist initialization into intel_engine_cs.c

Quoting Mika Kuoppala (2017-09-20 15:36:59) > Move execlist init into a common engine setup. As it is > common to both guc and hw execlists. > > v2: rebase with csb changes > > Signed-off-by: Mika Kuoppala Reviewed-by: Chris Wilson -Chris

Re: [Intel-gfx] [PATCH 15/31] drm/i915/slpc: Sanitize GuC version

On Tue, 19 Sep 2017 19:41:51 +0200, Sagar Arun Kamble wrote: From: Tom O'Rourke The SLPC interface is dependent on GuC version. Only GuC versions known to be compatible are supported here. SLPC with GuC firmware v9 is supported with this

[Intel-gfx] [PATCH] drm/i915/bios: ignore HDMI on port A

The hardware state readout oopses after several warnings when trying to use HDMI on port A, if such a combination is configured in VBT. Filter the combo out already at the VBT parsing phase. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102889 Cc: sta...@vger.kernel.org Cc: Imre Deak

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/kbl: Change a KBL pci id to GT2 from GT1.5

On Wed, Sep 20, 2017 at 09:43:38PM +, Anuj Phogat wrote: > On Wed, Sep 20, 2017 at 2:34 PM, Rodrigo Vivi wrote: > > On Wed, Sep 20, 2017 at 08:31:26PM +, Anuj Phogat wrote: > >> See Mesa commit 9c588ff > >> > >> Cc: Matt Turner > >> Cc: Rodrigo

Re: [Intel-gfx] [PATCH igt] igt/prime_vgem: Split out the fine-grain coherency check

Quoting Michał Winiarski (2017-09-20 11:48:54) > On Tue, Sep 19, 2017 at 01:21:08PM +0100, Chris Wilson wrote: > > Quoting Chris Wilson (2017-09-07 15:30:55) > > > We don't expect every machine to be able to pass the WC/GTT coherency > > > check, see > > > > > > kernel commit

Re: [Intel-gfx] [PATCH] drm/i915: Remove use_mmio_flip modparm

On Thu, 21 Sep 2017, Chris Wilson wrote: > Quoting Maarten Lankhorst (2017-09-21 09:18:55) >> This has been unused since commit afa8ce5b3080 >> ("drm/i915: Nuke legacy flip queueing code"). >> >> Cc: Chris Wilson >> Signed-off-by: Maarten

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Make own struct for execlist items

On Wed, Sep 20, 2017 at 05:36:58PM +0300, Mika Kuoppala wrote: > Engine's execlist related items have been increasing to > a point where a separate struct is warranted. Carve execlist > specific items to a dedicated struct to add clarity. > > v2: add kerneldoc and fix whitespace (Joonas, Chris) >

Re: [Intel-gfx] [PATCH 7/8] drm/i915: Keep track of reserved execlist ports

Mika Kuoppala writes: > To further enchance port processing, keep track of > reserved ports. This way we can iterate only the used subset > of port space. Note that we lift the responsibility of > execlists_submit_request() to inspect hw availability and

Re: [Intel-gfx] [PATCH i-g-t] scripts/run-tests.sh: Look for test-lists.txt in 'build' as well

On Wed, 20 Sep 2017, Ville Syrjala wrote: > From: Ville Syrjälä > > Meson always uses a separate build directotry. Adjust the assumptions > in run-tests.sh to work in that environment. For now I'll just hardcode > it to look for a

Re: [Intel-gfx] [PATCH 18/31] drm/i915/slpc: Add SLPC communication interfaces

On Tue, 19 Sep 2017 19:41:54 +0200, Sagar Arun Kamble wrote: Communication with SLPC is via Host to GuC interrupt through shared data and parameters. This patch defines the structure of shared data, parameters, data structure to be passed as input and received as

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Check waiter->seqno carefully in case of preemption

On Tue, Sep 19, 2017 at 11:07:43AM +0100, Chris Wilson wrote: > Quoting Tvrtko Ursulin (2017-09-19 10:28:42) > > > > On 18/09/2017 17:27, Chris Wilson wrote: > > > If preemption occurs at precisely the right moment, we may decide that > > > the wait is complete even though the wait's request is

Re: [Intel-gfx] [PATCH i-g-t 2/9] tests/perf: Test i915 assisted command stream based perf metrics capture

On Wed, Sep 13, 2017 at 04:22:01PM +0530, Sagar Arun Kamble wrote: > This tests different performance metrics being streamed by i915 driver. > This feature in i915 also referred as Driver Assisted Performance > Capture (DAPC) provides userspace an ability to sample the OA reports > at execbuf

[Intel-gfx] ✓ Fi.CI.BAT: success for igt/kms_rotation_crc : Remove flip tests for sprite plane (rev3)

== Series Details == Series: igt/kms_rotation_crc : Remove flip tests for sprite plane (rev3) URL : https://patchwork.freedesktop.org/series/30588/ State : success == Summary == IGT patchset tested on top of latest successful build 6e2622564dc85875ee9e2f22874f9607cf0cdd9c meson: share the

[Intel-gfx] [PATCH i-g-t] igt/kms_rotation_crc : Fix flip tests for sprite plane

This test was flipping the primary plane instead of the sprite plane. Flip the correct plane to make the test pass properly. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=102691 Signed-off-by: Maarten Lankhorst --- Resend for CI.

  1   2   >