Re: [Intel-gfx] [PATCH] drm/i915: Don't sanitize frame start delay if the pipe is off

On Wed, Nov 15, 2017 at 09:13:28PM +, Chris Wilson wrote: > Quoting Ville Syrjala (2017-11-15 20:04:42) > > From: Ville Syrjälä > > > > Avoid touching PIPECONF in intel_sanitize_crtc() unless the pipe is > > actually on. Should cure some unclaimed register

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix init_clock_gating for resume

Quoting Ville Syrjala (2017-11-16 16:02:15) > From: Ville Syrjälä > > Moving the init_clock_gating() call from intel_modeset_init_hw() to > intel_modeset_gem_init() had an unintended effect of not applying > some workarounds on resume. This, for example, cause some

[Intel-gfx] [PATCH i-g-t] tests/kms_cursor_legacy: Rework the 2x tests.

Instead of strictly measuring vblanks, we try to see if a page flip is queued on the next vblank if we run legacy cursor updates to the pipe and another pipe in the background. Signed-off-by: Maarten Lankhorst Bugzilla:

[Intel-gfx] [PATCH i-g-t 4/4] tests: Rename chamelium to kms_chamelium.

Signed-off-by: Maarten Lankhorst --- tests/Makefile.am | 6 +++--- tests/intel-ci/fast-feedback.testlist | 18 +- tests/{chamelium.c => kms_chamelium.c} | 0 tests/meson.build | 2 +- 4 files

[Intel-gfx] [PATCH i-g-t 1/4] lib/igt_kms: Add igt_display_reset function.

A lot of code duplicates this, but it should be handled in the core. Add it and use it after igt_display_init(), the tests have to be converted one by one. Signed-off-by: Maarten Lankhorst --- lib/igt_kms.c | 162

[Intel-gfx] [PATCH i-g-t 3/4] tests/chamelium: Only initialize igt_display once

Instead of first calling kmstest_unset_all_crtcs, and calling igt_display_init for each test, use igt_display_reset to reset igt_display between tests, and use atomic commit to disable all unused crtcs in enable_output(). Signed-off-by: Maarten Lankhorst ---

[Intel-gfx] [PATCH i-g-t 2/4] lib/igt_kms: Make igt_output_from_connector probe all outputs

igt_output_from_connector should be used for disconnected outputs too, this is useful for chamelium testing, where disconnected outputs may reappear. Signed-off-by: Maarten Lankhorst --- lib/igt_kms.c | 8 ++-- 1 file changed, 6 insertions(+), 2

[Intel-gfx] [PATCH igt v2] tools/error_decode: Print ASCII user buffers

Look at the first 16 characters of the user buffer and if they are all printable, assume that user buffer contains ASCII data (e.g. a debug log) that we want to simply print out. Otherwise, we treat it as a binary data and hexdump as before. Tvrtko: you know you could just write this as a printf

[Intel-gfx] ✗ Fi.CI.IGT: warning for GuC submission functions/struct name/prototype update (rev3)

== Series Details == Series: GuC submission functions/struct name/prototype update (rev3) URL : https://patchwork.freedesktop.org/series/33679/ State : warning == Summary == Test kms_setmode: Subgroup basic: fail -> PASS (shard-hsw) fdo#99912 Test kms_flip:

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with lib/igt_kms: Add igt_display_reset function, v2. (rev2)

== Series Details == Series: series starting with lib/igt_kms: Add igt_display_reset function, v2. (rev2) URL : https://patchwork.freedesktop.org/series/33934/ State : failure == Summary == IGT patchset build failed on latest successful build 936b97165308e179880fc0f218192881953f2544 lib:

[Intel-gfx] [PATCH] drm/i915/cnl: Extend HDMI 2.0 support to CNL.

Starting on GLK we support HDMI 2.0. So this patch only extend the work Shashank has made to GLK to CNL. v2: The version that compiles :/ v3: Invert order to newer || older platforms check. (Ville). Cc: Ville Syrjälä Cc: Paulo Zanoni Cc:

Re: [Intel-gfx] [PATCH] drm/i915: Don't sanitize frame start delay if the pipe is off

On Wed, Nov 15, 2017 at 08:17:21PM +, Chris Wilson wrote: > Quoting Ville Syrjala (2017-11-15 20:04:42) > > From: Ville Syrjälä > > > > Avoid touching PIPECONF in intel_sanitize_crtc() unless the pipe is > > actually on. Should cure some unclaimed register

Re: [Intel-gfx] [PATCH AUTOSEL for 4.9 36/56] drm/i915: Fix the level 0 max_wm hack on VLV/CHV

On Wed, Nov 15, 2017 at 04:44:54PM +, alexander.le...@verizon.com wrote: > On Wed, Nov 15, 2017 at 01:08:05PM +0200, Ville Syrjälä wrote: > >On Wed, Nov 15, 2017 at 02:45:43AM +, alexander.le...@verizon.com wrote: > >> From: Ville Syrjälä > >> > >> [

Re: [Intel-gfx] [PATCH v2 02/10] drm/uapi: Validate the mode flags/type

On Wed, Nov 15, 2017 at 06:02:59PM +, Jose Abreu wrote: > Hi Ville, > > On 15-11-2017 15:49, Ville Syrjala wrote: > > > > +#define DRM_MODE_FLAG_ALL (DRM_MODE_FLAG_PHSYNC | \ > > +DRM_MODE_FLAG_NHSYNC | \ > > +

Re: [Intel-gfx] [PATCH 06/10] drm/edid: Fix cea mode aspect ratio handling

On Thu, Nov 16, 2017 at 08:21:44PM +0530, Sharma, Shashank wrote: > Regards > > Shashank > > > On 11/13/2017 10:34 PM, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > commit 6dffd431e229 ("drm: Add aspect ratio parsing in DRM layer") > > cause us to not send

[Intel-gfx] [PATCH 2/4] drm/i915/debugfs: reuse max slice/subslices already stored in sseu

Now that we have that information in topology fields, let's just reused it. Signed-off-by: Lionel Landwerlin --- drivers/gpu/drm/i915/i915_debugfs.c | 26 ++ 1 file changed, 10 insertions(+), 16 deletions(-) diff --git

[Intel-gfx] [PATCH 0/4] drm/i915: Expose more GPU properties through sysfs

Hi all, Based on feedback on previous series by Tvrtko & myself, here is a series that exposes EU topology & engines availability through sysfs. Cheers, Lionel Landwerlin (4): drm/i915: store all subslice masks drm/i915/debugfs: reuse max slice/subslices already stored in sseu drm/i915:

[Intel-gfx] [PATCH 1/4] drm/i915: store all subslice masks

Up to now, subslice mask was assumed to be uniform across slices. But starting with Cannonlake, slices can be asymetric (for example slice0 has different number of subslices as slice1+). This change stores all subslices masks for all slices rather than having a single mask that applies to all

[Intel-gfx] [PATCH 3/4] drm/i915: expose EU topology through sysfs

With the introduction of asymetric slices in CNL, we cannot rely on the previous SUBSLICE_MASK getparam. Here we introduce a more detailed way of querying the Gen's GPU topology that doesn't aggregate numbers. This is essential for monitoring parts of the GPU with the OA unit, because signals

[Intel-gfx] [PATCH 4/4] drm/i915: expose engine availability through sysfs

This enables userspace to discover the engines available on the GPU. Here is the layout : /sys/devices/pci:00/:00:02.0/drm/card0/engines ├── bcs0 │   ├── class │   └── instance ├── rcs0 │   ├── class │   └── instance ├── vcs0 │   ├── class │   ├── hevc │   └── instance ├── vcs1 │   ├──

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix init_clock_gating for resume (rev2)

== Series Details == Series: drm/i915: Fix init_clock_gating for resume (rev2) URL : https://patchwork.freedesktop.org/series/33718/ State : success == Summary == Series 33718v2 drm/i915: Fix init_clock_gating for resume https://patchwork.freedesktop.org/api/1.0/series/33718/revisions/2/mbox/

Re: [Intel-gfx] [PATCH] drm/i915/selftests: exercise_ggtt may have nothing to do

Quoting Chris Wilson (2017-11-15 15:25:58) > When operating on the live_ggtt we have to find a usuable hole for our > test. It is possible for there to be no hole we can use, so initialise > the err to 0 for the early exit. > > Signed-off-by: Chris Wilson > --- >

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Expose more GPU properties through sysfs

== Series Details == Series: drm/i915: Expose more GPU properties through sysfs URL : https://patchwork.freedesktop.org/series/33950/ State : failure == Summary == CHK include/config/kernel.release CHK include/generated/uapi/linux/version.h CHK include/generated/utsrelease.h

[Intel-gfx] [PATCH i-g-t] lib/igt_kms: Add igt_display_reset function, v2.

A lot of code duplicates this, but it should be handled in the core. Add it and use it after igt_display_init(), the tests have to be converted one by one. Changes since v1: - Merely reset rotation to HW value. Signed-off-by: Maarten Lankhorst ---

Re: [Intel-gfx] [PATCH 07/10] drm/edid: Don't send bogus aspect ratios in AVI infoframes

On Thu, Nov 16, 2017 at 08:31:36PM +0530, Sharma, Shashank wrote: > Regards > > Shashank > > > On 11/13/2017 10:34 PM, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > If the user mode would specify an aspect ratio other than 4:3 or 16:9 > > we now silently

[Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915: Fix init_clock_gating for resume (rev2)

== Series Details == Series: drm/i915: Fix init_clock_gating for resume (rev2) URL : https://patchwork.freedesktop.org/series/33718/ State : warning == Summary == Test drv_selftest: Subgroup mock_sanitycheck: pass -> DMESG-WARN (shard-snb) fdo#103717 Test

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Don't sanitize frame start delay if the pipe is off

On Wed, Nov 15, 2017 at 09:17:01PM -, Patchwork wrote: > == Series Details == > > Series: drm/i915: Don't sanitize frame start delay if the pipe is off > URL : https://patchwork.freedesktop.org/series/33901/ > State : success > > == Summary == > > Test kms_busy: > Subgroup

Re: [Intel-gfx] [PATCH v4 1/3] drm/i915/selftests: Add a GuC doorbells selftest

Quoting Michel Thierry (2017-11-15 18:30:27) > The first test aims to check guc_init_doorbell_hw, changing the existing > guc clients and doorbells state before calling it. > > The second test tries to create as many clients as it is currently possible > (currently limited to max number of

Re: [Intel-gfx] ✗ Fi.CI.IGT: warning for GuC submission functions/struct name/prototype update (rev3)

Quoting Patchwork (2017-11-16 14:56:50) > == Series Details == > > Series: GuC submission functions/struct name/prototype update (rev3) > URL : https://patchwork.freedesktop.org/series/33679/ > State : warning > > == Summary == > > Test kms_setmode: > Subgroup basic: >

Re: [Intel-gfx] [PATCH 01/10] video/hdmi: Allow "empty" HDMI infoframes

On Thu, Nov 16, 2017 at 08:06:18PM +0530, Sharma, Shashank wrote: > Regards > > Shashank > > > On 11/13/2017 10:34 PM, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > HDMI 2.0 Appendix F suggest that we should keep sending the infoframe > > when switching

Re: [Intel-gfx] [PATCH v2 2/6] drm/i915/guc: Update names of submission related static functions

On Thu, 16 Nov 2017 10:53:51 +0100, Sagar Arun Kamble wrote: i915_guc_submit, i915_guc_dequeue, i915_guc_submission_park and i915_guc_submission_upark are functions internal to GuC submission hence remove "i915_" prefix. Suggested-by: Michal Wajdeczko

Re: [Intel-gfx] [PATCH 02/10] drm/edid: Allow HDMI infoframe without VIC or S3D

On Thu, Nov 16, 2017 at 08:10:55PM +0530, Sharma, Shashank wrote: > Regards > > Shashank > > > On 11/13/2017 10:34 PM, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Appedix F of HDMI 2.0 says that some HDMI sink may fail to switch from > > 3D to 2D mode in

[Intel-gfx] ✓ Fi.CI.BAT: success for WRPLL fixes for HDMI 2.0 on Cannonlake. (rev4)

== Series Details == Series: WRPLL fixes for HDMI 2.0 on Cannonlake. (rev4) URL : https://patchwork.freedesktop.org/series/33823/ State : success == Summary == Series 33823v4 WRPLL fixes for HDMI 2.0 on Cannonlake. https://patchwork.freedesktop.org/api/1.0/series/33823/revisions/4/mbox/

[Intel-gfx] [PATCH v2] drm/i915: Fix init_clock_gating for resume

From: Ville Syrjälä Moving the init_clock_gating() call from intel_modeset_init_hw() to intel_modeset_gem_init() had an unintended effect of not applying some workarounds on resume. This, for example, cause some kind of corruption to appear at the top of my IVB

Re: [Intel-gfx] [PATCH 02/10] drm/edid: Allow HDMI infoframe without VIC or S3D

Regards Shashank On 11/13/2017 10:34 PM, Ville Syrjala wrote: From: Ville Syrjälä Appedix F of HDMI 2.0 says that some HDMI sink may fail to switch from 3D to 2D mode in a timely fashion if the source simply stops sending the HDMI infoframe. The suggested

[Intel-gfx] ✗ Fi.CI.IGT: warning for tests/kms_cursor_legacy: Rework the 2x tests.

== Series Details == Series: tests/kms_cursor_legacy: Rework the 2x tests. URL : https://patchwork.freedesktop.org/series/33933/ State : warning == Summary == Test kms_chv_cursor_fail: Subgroup pipe-c-128x128-bottom-edge: skip -> PASS (shard-hsw)

Re: [Intel-gfx] [PATCH v6] drm/i915: Prevent overflow of execbuf.buffer_count and num_cliprects

Quoting Tvrtko Ursulin (2017-11-16 14:00:50) > > On 16/11/2017 10:50, Chris Wilson wrote: > > We check whether the multiplies will overflow prior to calling > > kmalloc_array so that we can respond with -EINVAL for the invalid user > > arguments rather than treating it as an -ENOMEM that would

Re: [Intel-gfx] [PATCH igt] lib: Dump /sys/kernel/debug/suspend_stats after suspend failure

On Tue, Nov 14, 2017 at 01:19:01PM +, Chris Wilson wrote: > I noticed that dpm was storing some information about which phase of > suspend failed inside suspend_stats. That will be useful to help debug > such failures, so automatically dump it after suspend fails. > > Signed-off-by: Chris

Re: [Intel-gfx] [PATCH 01/10] video/hdmi: Allow "empty" HDMI infoframes

Regards Shashank On 11/13/2017 10:34 PM, Ville Syrjala wrote: From: Ville Syrjälä HDMI 2.0 Appendix F suggest that we should keep sending the infoframe when switching from 3D to 2D mode, even if the infoframe isn't strictly necessary (ie. not needed to

Re: [Intel-gfx] [PATCH 07/10] drm/edid: Don't send bogus aspect ratios in AVI infoframes

Regards Shashank On 11/13/2017 10:34 PM, Ville Syrjala wrote: From: Ville Syrjälä If the user mode would specify an aspect ratio other than 4:3 or 16:9 we now silently ignore it. Maybe a better apporoach is to return an error? Let's try that. Also we must be

Re: [Intel-gfx] [PATCH 6/8] drm/i915: Disable semaphores on Sandybridge

On Tue, 2017-11-14 at 21:30 +, Chris Wilson wrote: > I should have admitted defeat long ago as there has been a rare but > persistent error on Sandybridge where semaphore signaling did not > propagate to the waiter, leading to a GPU hang. > > With the work on fence signaling for v4.9, the

Re: [Intel-gfx] [PATCH v3 1/6] drm/i915: Update execlists tasklet naming

On Thu, 16 Nov 2017 14:32:37 +0100, Sagar Arun Kamble wrote: intel_lrc_irq_handler and i915_guc_irq_handler are HW submission related tasklet functions. Name them with "submission_tasklet" suffix and remove intel/i915 prefix as they are static. Also rename

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Prevent overflow of execbuf.buffer_count and num_cliprects (rev5)

== Series Details == Series: drm/i915: Prevent overflow of execbuf.buffer_count and num_cliprects (rev5) URL : https://patchwork.freedesktop.org/series/33840/ State : success == Summary == Test kms_vblank: Subgroup wait-busy: skip -> PASS (shard-hsw) Test

Re: [Intel-gfx] [PATCH] drm/i915/cnl: Fix wrpll math for higher freqs.

On Tue, Nov 14, 2017 at 03:42:23PM -0800, Rodrigo Vivi wrote: > Spec describe all values in MHz. We handle our > clocks in KHz. This includes the best_dco_centrality that was > forgot in the same unity as spec. Consequently we couldn't > get a good divider for high frequenies. Hence HDMI 2.0

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] lib/igt_kms: Add igt_display_reset function.

== Series Details == Series: series starting with [1/4] lib/igt_kms: Add igt_display_reset function. URL : https://patchwork.freedesktop.org/series/33934/ State : failure == Summary == IGT patchset tested on top of latest successful build 88d6550795fad3974d77e4db2f563c5e2e8872e1 Revert

Re: [Intel-gfx] [RFC 2/3] drm/i915/guc: Omit guc_init_doorbell_hw during driver load

On 15/11/17 10:30, Michel Thierry wrote: During driver load we create the GuC clients and allocate their doorbells just before executing guc_init_doorbell_hw; but since we just created these doorbells, how can they be out of sync? This code has had more than enough refactoring (2 more still in

Re: [Intel-gfx] [PATCH 1/1] drm/i915/cnl: Extend HDMI 2.0 support to CNL.

On Mon, Nov 13, 2017 at 10:47:44AM -0800, Rodrigo Vivi wrote: > On Sat, Nov 11, 2017 at 09:43:44AM +, Sharma, Shashank wrote: > > Regards > > > > Shashank > > > > > > On 11/11/2017 3:56 AM, Rodrigo Vivi wrote: > > > Starting on GLK we support HDMI 2.0. So this patch only > > > extend the

Re: [Intel-gfx] [PATCH 2/3] drm/i915/: Initialise trans_min for skl_compute_transition_wm()

On Wed, Nov 15, 2017 at 10:50:35AM +, Chris Wilson wrote: > clang spots > > drivers/gpu/drm/i915/intel_pm.c:4655:6: warning: variable 'trans_min' is used > uninitialized whenever 'if' condition is false [-Wsometimes-uninitialized] > if (INTEL_GEN(dev_priv) >= 10) > > but fortunately

Re: [Intel-gfx] [RFC 2/3] drm/i915/guc: Omit guc_init_doorbell_hw during driver load

On 11/16/2017 12:00 AM, Michel Thierry wrote: During driver load we create the GuC clients and allocate their doorbells just before executing guc_init_doorbell_hw; but since we just created these doorbells, how can they be out of sync? This code has had more than enough refactoring (2 more

Re: [Intel-gfx] [PATCH 2/8] drm/i915: Make request's wait-for-space explicit

Chris Wilson writes: > Quoting Mika Kuoppala (2017-11-15 13:51:13) >> Chris Wilson writes: >> >> > At the start of building a request, we would wait for roughly enough >> > space to fit the average request (to reduce the likelihood of having

Re: [Intel-gfx] [RFC 4/4] drm/i915/perf: Send system clock monotonic time in perf samples

On 11/15/2017 6:01 PM, Chris Wilson wrote: Quoting Sagar Arun Kamble (2017-11-15 12:13:54) From: Sourab Gupta Currently, we have the ability to only forward the GPU timestamps in the samples (which are generated via OA reports). This limits the ability to correlate

Re: [Intel-gfx] [PATCH igt 1/2] lib/gt: Mark up engine classes

On 15/11/2017 13:32, Chris Wilson wrote: Quoting Tvrtko Ursulin (2017-11-15 13:26:09) On 14/11/2017 13:19, Chris Wilson wrote: We introduce the concept of classes that each engine may belong to. There may be more than one engine available in each class, but each engine only belongs to one

Re: [Intel-gfx] [PATCH v3 1/6] drm/i915: Update execlists tasklet naming

Quoting Sagar Arun Kamble (2017-11-16 13:32:37) > intel_lrc_irq_handler and i915_guc_irq_handler are HW submission related > tasklet functions. Name them with "submission_tasklet" suffix and > remove intel/i915 prefix as they are static. Also rename irq_tasklet > as just tasklet for clarity. > >

Re: [Intel-gfx] [PATCH v2 1/6] drm/i915: Update execlists tasklet naming

On 11/16/2017 3:38 PM, Chris Wilson wrote: Quoting Sagar Arun Kamble (2017-11-16 09:53:50) intel_lrc_irq_handler and i915_guc_irq_handler are HW submission related bh functions. Name them with submission_bh suffix and remove intel/i915 prefix as they are static. Also rename irq_tasklet as

Re: [Intel-gfx] [PATCH 7/8] drm/i915: Move debugfs/i915_semaphore_status to i915_engine_info

On Tue, 2017-11-14 at 21:30 +, Chris Wilson wrote: > As the semaphores is just part of the engine, include it with the > general pretty printer universally used for debugging. > > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen

Re: [Intel-gfx] [PATCH 8/8] drm/i915: Remove i915.semaphores modparam

On Tue, 2017-11-14 at 21:30 +, Chris Wilson wrote: > Having disabled the broken semaphores on Sandybridge, there is no need > for a modparam any more, so remove it in favour of a simple > HAS_LEGACY_SEMAPHORES() guard. > > Signed-off-by: Chris Wilson > Cc: Joonas

[Intel-gfx] [PATCH v3 5/6] drm/i915/guc: Rename i915_guc_submission.c|h to intel_guc_submission.c|h

With all component structures and functions named appropriately, change the names of GuC submission source files. There were bunch of style issues in guc_submission.c that are highlighted now by checkpatch. Fix those. Update name in Documentation/gpu. (Joonas) v2: Rebase. v3: Rebase.

[Intel-gfx] [PATCH v3 6/6] HAX enable GuC submission for CI

Also revert ("drm/i915/guc: Assert that we switch between known ggtt->invalidate functions") --- drivers/gpu/drm/i915/i915_gem_gtt.c | 8 ++-- drivers/gpu/drm/i915/i915_params.h | 4 ++-- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c

[Intel-gfx] [PATCH v3 2/6] drm/i915/guc: Update names of submission related static functions

i915_guc_submit, i915_guc_dequeue, i915_guc_submission_park and i915_guc_submission_upark are functions internal to GuC submission hence remove "i915_" prefix. Suggested-by: Michal Wajdeczko Signed-off-by: Sagar Arun Kamble Cc: Michal

[Intel-gfx] [PATCH v3 3/6] drm/i915/guc: Update name and prototype of GuC submission interface functions

i915 GuC submission is hardware interface and GuC APIs that are not user facing should be named intel_guc* hence we change GuC submission related functions name prefix to intel_guc. Also changed the parameter to these functions to intel_guc struct. v2: Using local guc variable in

[Intel-gfx] [PATCH v3 4/6] drm/i915/guc: Rename i915_guc_client struct to intel_guc_client

GuC submission clients are currently being used in kernel only hence update the structure name to intel_guc_client. Signed-off-by: Sagar Arun Kamble Cc: Michal Wajdeczko Cc: Michal Winiarski Cc: Chris Wilson

[Intel-gfx] [PATCH v3 1/6] drm/i915: Update execlists tasklet naming

intel_lrc_irq_handler and i915_guc_irq_handler are HW submission related tasklet functions. Name them with "submission_tasklet" suffix and remove intel/i915 prefix as they are static. Also rename irq_tasklet as just tasklet for clarity. v2: s/_bh/_tasklet (Chris) Suggested-by: Michal Wajdeczko

[Intel-gfx] [PATCH v3 0/6] GuC submission functions/struct name/prototype update

We want to have consistent function/structure/file naming and function parameter semantics. Suggestion from Michal Wajdeczko about using "genx_" prefix (or better _genx" suffix for all hw related structures types, offsets), "i915_" prefix for driver entry calls and "intel_" in all other seems to

Re: [Intel-gfx] [PATCH 3/8] drm/i915: Automatic i915_switch_context for legacy

Chris Wilson writes: > During request construction, after pinning the context we know whether > or not we have to emit a context switch. So move this common operation > from every caller into i915_gem_request_alloc() itself. > > v2: Always submit the request if we

Re: [Intel-gfx] [PATCH v6] drm/i915: Prevent overflow of execbuf.buffer_count and num_cliprects

On 16/11/2017 10:50, Chris Wilson wrote: We check whether the multiplies will overflow prior to calling kmalloc_array so that we can respond with -EINVAL for the invalid user arguments rather than treating it as an -ENOMEM that would otherwise occur. However, as Dan Carpenter pointed out, we

Re: [Intel-gfx] [PATCH] drm/i915: Clear breadcrumb node when cancelling signaling

Quoting Joonas Lahtinen (2017-11-16 11:08:18) > On Wed, 2017-11-15 at 12:14 +, Chris Wilson wrote: > > When we call intel_engine_cancel_signaling() to stop reporting whether > > or not a request is completed via an asynchronous signal, we remove that > > request from the breadcrumb wait queue.

[Intel-gfx] ✓ Fi.CI.BAT: success for tests/kms_cursor_legacy: Rework the 2x tests.

== Series Details == Series: tests/kms_cursor_legacy: Rework the 2x tests. URL : https://patchwork.freedesktop.org/series/33933/ State : success == Summary == IGT patchset tested on top of latest successful build 88d6550795fad3974d77e4db2f563c5e2e8872e1 Revert "tests/kms_flip: Make

[Intel-gfx] ✓ Fi.CI.BAT: success for GuC submission functions/struct name/prototype update (rev3)

== Series Details == Series: GuC submission functions/struct name/prototype update (rev3) URL : https://patchwork.freedesktop.org/series/33679/ State : success == Summary == Series 33679v3 GuC submission functions/struct name/prototype update

Re: [Intel-gfx] [PATCH igt] lib: Dump /sys/kernel/debug/suspend_stats after suspend failure

Quoting Arkadiusz Hiler (2017-11-16 14:31:03) > On Tue, Nov 14, 2017 at 01:19:01PM +, Chris Wilson wrote: > > I noticed that dpm was storing some information about which phase of > > suspend failed inside suspend_stats. That will be useful to help debug > > such failures, so automatically dump

Re: [Intel-gfx] [PATCH 06/10] drm/edid: Fix cea mode aspect ratio handling

Regards Shashank On 11/13/2017 10:34 PM, Ville Syrjala wrote: From: Ville Syrjälä commit 6dffd431e229 ("drm: Add aspect ratio parsing in DRM layer") cause us to not send out any VICs in the AVI infoframes. That commit was since reverted, but if and when we add

Re: [Intel-gfx] [PATCH 1/3] drm/i915/selftests: Increase size for mock ringbuffer

On Tue, 2017-11-14 at 11:41 +, Chris Wilson wrote: > We don't actually emit any commands into the ringbuffer, so we set it > very small. However, an upcoming change centralises the wait-for-space > into i915_gem_request_alloc() and that imposes a minimum size upon all > ringbuffers (mock or

Re: [Intel-gfx] [PATCH 3/8] drm/i915: Automatic i915_switch_context for legacy

Quoting Mika Kuoppala (2017-11-16 14:00:13) > Chris Wilson writes: > > > During request construction, after pinning the context we know whether > > or not we have to emit a context switch. So move this common operation > > from every caller into i915_gem_request_alloc()

Re: [Intel-gfx] [PATCH igt v2] tools/error_decode: Print ASCII user buffers

On 16/11/2017 14:35, Chris Wilson wrote: Look at the first 16 characters of the user buffer and if they are all printable, assume that user buffer contains ASCII data (e.g. a debug log) that we want to simply print out. Otherwise, we treat it as a binary data and hexdump as before. Tvrtko: you

Re: [Intel-gfx] [PATCH] drm/i915: Remove pre-production pooled-EU w/a for Broxton

On Thu, 16 Nov 2017, Rodrigo Vivi wrote: > On Thu, Nov 16, 2017 at 09:22:23AM +, Jani Nikula wrote: >> On Wed, 15 Nov 2017, Chris Wilson wrote: >> > Quoting David Weinehall (2017-11-15 18:01:41) >> >> On Tue, Nov 14, 2017 at 01:51:16PM +,

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/5] drm/i915: Always pin the fence for scanout on gen2/3 and primary planes

== Series Details == Series: series starting with [1/5] drm/i915: Always pin the fence for scanout on gen2/3 and primary planes URL : https://patchwork.freedesktop.org/series/33960/ State : failure == Summary == Series 33960v1 series starting with [1/5] drm/i915: Always pin the fence for

Re: [Intel-gfx] [PATCH 0/7] WRPLL fixes for HDMI 2.0 on Cannonlake.

Merged to dinq. Thanks for all reviews and comments. On Tue, Nov 14, 2017 at 07:47:52PM +, Rodrigo Vivi wrote: > With these fixes and clean-ups around wrpll plus > extending HDMI 2.0 from GLK to CNL we could finally > get a functional HDMI 2.0 display with 4k60Hz. > > Thanks, > Rodrigo. >

Re: [Intel-gfx] [PATCH] drm/i915: Enable runtime pm

On Wed, Nov 08, 2017 at 04:25:42PM +0200, David Weinehall wrote: > On Tue, Nov 07, 2017 at 05:18:21PM +0100, Daniel Vetter wrote: > > Now that we have CI, and that pm_rpm fully passes (I guess the audio > > folks have implemented proper runtime pm for snd-hda, hooray, pls > > confirm) it's time to

[Intel-gfx] [PATCH i-g-t] lib/igt_kms: Add igt_display_reset function, v3.

A lot of code duplicates this, but it should be handled in the core. Add it and use it after igt_display_init(), the tests have to be converted one by one. Changes since v1: - Merely reset rotation to HW value. Changes since v2: - Compile. Signed-off-by: Maarten Lankhorst

[Intel-gfx] ✓ Fi.CI.IGT: success for WRPLL fixes for HDMI 2.0 on Cannonlake. (rev4)

== Series Details == Series: WRPLL fixes for HDMI 2.0 on Cannonlake. (rev4) URL : https://patchwork.freedesktop.org/series/33823/ State : success == Summary == Test drv_selftest: Subgroup mock_sanitycheck: pass -> DMESG-WARN (shard-snb) fdo#103717 Test

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with lib/igt_kms: Add igt_display_reset function, v3. (rev3)

== Series Details == Series: series starting with lib/igt_kms: Add igt_display_reset function, v3. (rev3) URL : https://patchwork.freedesktop.org/series/33934/ State : success == Summary == IGT patchset tested on top of latest successful build 936b97165308e179880fc0f218192881953f2544 lib:

[Intel-gfx] [PATCH 4/5] drm/i915: Add a FIXME about FBC vs. fence. 90/270 degree rotation

From: Ville Syrjälä Currently we're pinning the fence for the rotated GTT view. That doesn't acually make any sense since the fence is used only for the FBC GTT tracking. For that we would want the fence for the normal GTT view instead of the rotated view. Too lazy

[Intel-gfx] [PATCH 2/5] drm/i915: Clean up fbc vs. plane checks

From: Ville Syrjälä Let's record the information whether a plane can do fbc or not under struct inte_plane. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/intel_display.c | 36

[Intel-gfx] [PATCH 3/5] drm/i915: Require fence only for FBC capable planes

From: Ville Syrjälä Since only a subset of primary planes are FBC capable there's no need to waste fences on all of them. So let's skip the fence if the plane isn't even fbc capable. In the future we might extend this to skip the fence even for FBC capable planes

[Intel-gfx] [PATCH 1/5] drm/i915: Always pin the fence for scanout on gen2/3 and primary planes

From: Ville Syrjälä The current code is trying to be lazy with fences on scanout buffers. That looks broken for several reasons: * gen2/3 always need a fence for tiled scanout * the unpin doesn't know whether we pinned the fence or not so it may unpin something

[Intel-gfx] [PATCH 5/5] drm/i915: Extract intel_plane_{pin, unpin}_fb()

From: Ville Syrjälä We've replicated the fb pin/unpin code in a few places. Pull it into convenint helpers. This results in a slight change in behaviour on account of the cursor path now dropping struct_mutex and reacquiring it later. Signed-off-by: Ville Syrjälä

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [v5,1/2] drm/i915/selftests: Add a GuC doorbells selftest

== Series Details == Series: series starting with [v5,1/2] drm/i915/selftests: Add a GuC doorbells selftest URL : https://patchwork.freedesktop.org/series/33964/ State : warning == Summary == Series 33964v1 series starting with [v5,1/2] drm/i915/selftests: Add a GuC doorbells selftest

Re: [Intel-gfx] [PATCH v5 03/10] drm/i915: s/enum plane/enum i9xx_plane_id/

On Mon, Oct 23, 2017 at 05:50:32PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Rename enum plane to enum i9xx_plane_id to make it clear that it only > applies to pre-SKL platforms. > > enum i9xx_plane_id is a global identifier, whereas enum plane_id is >

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Skip a lite-restore immediately prior to a context-completion

Quoting Chris Wilson (2017-11-16 22:11:30) > If we are about to do another context-switch in the near future skip > doing performing a lite-restore now. (Forcing a lite-restore just before > a context-switch effectively doubles the cost of that context-switch, so > long as we can handle the

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/execlists: Skip a lite-restore immediately prior to a context-completion

== Series Details == Series: drm/i915/execlists: Skip a lite-restore immediately prior to a context-completion URL : https://patchwork.freedesktop.org/series/33965/ State : failure == Summary == Series 33965v1 drm/i915/execlists: Skip a lite-restore immediately prior to a context-completion

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Skip a lite-restore immediately prior to a context-completion

Quoting Chris Wilson (2017-11-16 22:25:45) > Quoting Chris Wilson (2017-11-16 22:11:30) > > If we are about to do another context-switch in the near future skip > > doing performing a lite-restore now. (Forcing a lite-restore just before > > a context-switch effectively doubles the cost of that

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915: Impletments dynamic WOPCM partitioning.

On 11/17/2017 3:17 AM, Michal Wajdeczko wrote: On Thu, 16 Nov 2017 08:34:01 +0100, Sagar Arun Kamble wrote: Typo in the subject. GLK showing failure to load GuC with this approach on CI. On 11/15/2017 10:47 PM, Jackie Li wrote: Static WOPCM partitioning will

Re: [Intel-gfx] [PATCH 4/7] drm/i915/cnl: Fix wrpll math for higher freqs.

On Wed, 2017-11-15 at 10:04 -0800, Rodrigo Vivi wrote: > On Wed, Nov 15, 2017 at 08:06:16AM +, Mika Kahola wrote: > > > > On Tue, 2017-11-14 at 11:47 -0800, Rodrigo Vivi wrote: > > > > > > Spec describe all values in MHz. We handle our > > > clocks in KHz. This includes the

[Intel-gfx] [PATCH v6] drm/i915: Prevent overflow of execbuf.buffer_count and num_cliprects

We check whether the multiplies will overflow prior to calling kmalloc_array so that we can respond with -EINVAL for the invalid user arguments rather than treating it as an -ENOMEM that would otherwise occur. However, as Dan Carpenter pointed out, we did an addition on the unsigned int prior to

[Intel-gfx] ✗ Fi.CI.IGT: warning for GuC submission functions/struct name/prototype update (rev2)

== Series Details == Series: GuC submission functions/struct name/prototype update (rev2) URL : https://patchwork.freedesktop.org/series/33679/ State : warning == Summary == Test perf: Subgroup oa-exponents: pass -> FAIL (shard-hsw) fdo#102254 Test

Re: [Intel-gfx] [PATCH] drm/i915: Clear breadcrumb node when cancelling signaling

On Wed, 2017-11-15 at 12:14 +, Chris Wilson wrote: > When we call intel_engine_cancel_signaling() to stop reporting whether > or not a request is completed via an asynchronous signal, we remove that > request from the breadcrumb wait queue. However, we may be concurrently > processing that

Re: [Intel-gfx] [PATCH v2 3/6] drm/i915/guc: Update name and prototype of GuC submission interface functions

On Thu, 16 Nov 2017 10:53:52 +0100, Sagar Arun Kamble wrote: i915 GuC submission is hardware interface and GuC APIs that are not user facing should be named intel_guc* hence we change GuC submission related functions name prefix to intel_guc. Also changed the

Re: [Intel-gfx] [PATCH] drm/i915: Remove pre-production pooled-EU w/a for Broxton

On Wed, Nov 15, 2017 at 06:06:53PM +, Chris Wilson wrote: > Quoting David Weinehall (2017-11-15 18:01:41) > > On Tue, Nov 14, 2017 at 01:51:16PM +, Chris Wilson wrote: > > > WaEnablePooledEuFor2x6 only applies to preproduction models, unsupported > > > since commit 0102ba1fd8af ("drm/i915:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Prevent overflow of execbuf.buffer_count and num_cliprects (rev5)

== Series Details == Series: drm/i915: Prevent overflow of execbuf.buffer_count and num_cliprects (rev5) URL : https://patchwork.freedesktop.org/series/33840/ State : success == Summary == Series 33840v5 drm/i915: Prevent overflow of execbuf.buffer_count and num_cliprects

Re: [Intel-gfx] [PATCH v4 1/3] drm/i915/selftests: Add a GuC doorbells selftest

Quoting Michel Thierry (2017-11-15 18:30:27) > The first test aims to check guc_init_doorbell_hw, changing the existing > guc clients and doorbells state before calling it. > > The second test tries to create as many clients as it is currently possible > (currently limited to max number of

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Remove temporary allocation of dma addresses when rotating

Quoting Joonas Lahtinen (2017-11-16 10:43:42) > On Tue, 2017-11-14 at 19:11 +, Chris Wilson wrote: > > The object already stores (computed on the fly) the index to dma address > > so use it instead of reallocating a large temporary array every time we > > bind a rotated framebuffer. > > > >

  1   2   >