Re: [Intel-gfx] [PATCH 2/5] drm: Allow determining if current task is output poll worker

2018-02-14 Thread Lukas Wunner
On Mon, Feb 12, 2018 at 12:46:11PM -0500, Lyude Paul wrote: > On Sun, 2018-02-11 at 10:38 +0100, Lukas Wunner wrote: > > Introduce a helper to determine if the current task is an output poll > > worker. > > > > This allows us to fix a long-standing deadlock in several DRM drivers > > wherein the

Re: [Intel-gfx] [PATCH 0/5] Fix deadlock on runtime suspend in DRM drivers

2018-02-14 Thread Lukas Wunner
Dear drm-misc maintainers, On Sun, Feb 11, 2018 at 10:38:28AM +0100, Lukas Wunner wrote: > Fix a deadlock on hybrid graphics laptops that's been present since 2013: This series has been reviewed, consent has been expressed by the most interested parties, patch [1/5] which touches files outside

Re: [Intel-gfx] [PATCH 04/16] drm/i915/skl+: support verification of DDB HW state for NV12

2018-02-14 Thread Sharma, Shashank
Reviewed-by: Shashank Sharma Regards Shashank On 2/14/2018 10:27 AM, Vidya Srinivas wrote: From: Mahesh Kumar For YUV 420 Planar formats like NV12, buffer allocation is done for Y and UV surfaces separately. For NV12 plane formats, the UV

Re: [Intel-gfx] [PATCH 1/5] drm/i915: add and enable DP AUX CH mutex

2018-02-14 Thread Jani Nikula
On Tue, 13 Feb 2018, José Roberto de Souza wrote: > When PSR/PSR2 is enabled hardware can do AUX transactions by it self, so > lets use the mutex register that is available in gen9+ to avoid concurrent > access by hardware and driver. > > Reference: >

Re: [Intel-gfx] [PATCH 3/3] just some guess work to findout the culprit. If this breaks then we know what do.

2018-02-14 Thread Takashi Iwai
On Wed, 14 Feb 2018 10:06:19 +0100, Kumar, Abhijeet wrote: > > > > On 2/14/2018 2:17 PM, Chris Wilson wrote: > > Quoting Kumar, Abhijeet (2018-02-14 04:53:57) > >> > >> On 2/14/2018 9:36 AM, abhijeet.ku...@intel.com wrote: > >> > >> From: Abhijeet Kumar > >> > >>

[Intel-gfx] Adding a couple of DSI panel fixes to drm-intel-fixes

2018-02-14 Thread Hans de Goede
Hi All, I would like to a add a couple of DSI panel fixes from dinq to drm-intel-fixes (with the purpose of getting them into 4.16). What is the correct way to do this? Should I just do: dim checkout-branch drm-intel-fixes git pull git cherry-pick git cherry-pick dim push-branch

Re: [Intel-gfx] [PATCH 1/5] drm/i915: add and enable DP AUX CH mutex

2018-02-14 Thread Ville Syrjälä
On Tue, Feb 13, 2018 at 05:30:29PM -0800, Rodrigo Vivi wrote: > José Roberto de Souza writes: > > > When PSR/PSR2 is enabled hardware can do AUX transactions by it self, so > > lets use the mutex register that is available in gen9+ to avoid concurrent > > access by hardware

Re: [Intel-gfx] [PULL] drm/i915: Add HDCP support to i915

2018-02-14 Thread Sean Paul
On Wed, Feb 14, 2018 at 02:48:29PM +0100, Hans Verkuil wrote: > On 14/02/18 14:44, Sean Paul wrote: > > On Wed, Feb 14, 2018 at 3:33 AM, Hans Verkuil wrote: > >> Hi Sean, > >> > >> On 13/02/18 21:18, Sean Paul wrote: > >>> > >>> Hi Dave, > >>> Here's the pull request for HDCP.

[Intel-gfx] [PATCH 05/19] drm/i915/icl: Interrupt handling

2018-02-14 Thread Mika Kuoppala
From: Tvrtko Ursulin v2: Rebase. v3: * Remove DPF, it has been removed from SKL+. * Fix -internal rebase wrt. execlists interrupt handling. v4: Rebase. v5: * Updated for POR changes. (Daniele Ceraolo Spurio) * Merged with irq handling fixes by Daniele Ceraolo

Re: [Intel-gfx] [PATCH 0/3] PSR lag fixes

2018-02-14 Thread Hans de Goede
Hi, On 12-02-18 18:42, Pandiyan, Dhinakaran wrote: On Mon, 2018-02-12 at 09:45 +0100, Hans de Goede wrote: Hi, On 12-02-18 07:08, Dhinakaran Pandiyan wrote: PSR currently when enabled results in semi-permanent freezes or noticeable cursor lags.

Re: [Intel-gfx] [PULL] drm/i915: Add HDCP support to i915

2018-02-14 Thread Hans Verkuil
Hi Sean, On 13/02/18 21:18, Sean Paul wrote: > > Hi Dave, > Here's the pull request for HDCP. Hopefully no surprises since it's been > baking > in drm-tip for a while now. > > topic/hdcp-2018-02-13: > Add HDCP support to i915 drm driver. > > Cheers, Sean > > > The following changes since

Re: [Intel-gfx] [PATCH 3/3] just some guess work to findout the culprit. If this breaks then we know what do.

2018-02-14 Thread Kumar, Abhijeet
On 2/14/2018 2:17 PM, Chris Wilson wrote: Quoting Kumar, Abhijeet (2018-02-14 04:53:57) On 2/14/2018 9:36 AM, abhijeet.ku...@intel.com wrote: From: Abhijeet Kumar --- sound/pci/hda/hda_codec.c | 2 +- 1 file changed, 1 insertion(+), 1

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/tv: Cleanup up obsolete comments

2018-02-14 Thread Patchwork
== Series Details == Series: drm/i915/tv: Cleanup up obsolete comments URL : https://patchwork.freedesktop.org/series/38228/ State : success == Summary == Series 38228v1 drm/i915/tv: Cleanup up obsolete comments https://patchwork.freedesktop.org/api/1.0/series/38228/revisions/1/mbox/ Test

Re: [Intel-gfx] [PATCH 1/2] drm/i915/panel: Add missing parameters to kerneldoc

2018-02-14 Thread Jani Nikula
On Wed, 14 Feb 2018, Chris Wilson wrote: > drivers/gpu/drm/i915/intel_sdvo.c:223: warning: Function parameter or member > 'intel_sdvo' not described in 'intel_sdvo_write_sdvox' > drivers/gpu/drm/i915/intel_sdvo.c:223: warning: Function parameter or member > 'val' not

Re: [Intel-gfx] [PATCH 1/2] drm/i915/panel: Add missing parameters to kerneldoc

2018-02-14 Thread Chris Wilson
Quoting Jani Nikula (2018-02-14 10:22:46) > On Wed, 14 Feb 2018, Chris Wilson wrote: > > drivers/gpu/drm/i915/intel_sdvo.c:223: warning: Function parameter or > > member 'intel_sdvo' not described in 'intel_sdvo_write_sdvox' > > drivers/gpu/drm/i915/intel_sdvo.c:223:

[Intel-gfx] [PATCH 03/20] drm/i915/icl: Show interrupt registers in debugfs

2018-02-14 Thread Mika Kuoppala
From: Tvrtko Ursulin Show GEN11 specific interrupt registers in debugfs v2: Update for POR changes. (Daniele Ceraolo Spurio) v3: get runtime pm ref. unify common parts with gen8 (Daniele) Cc: Ceraolo Spurio, Daniele Signed-off-by:

Re: [Intel-gfx] [PATCH 1/2] drm/i915/panel: Add missing parameters to kerneldoc

2018-02-14 Thread Jani Nikula
On Wed, 14 Feb 2018, Chris Wilson wrote: > Quoting Jani Nikula (2018-02-14 10:22:46) >> On Wed, 14 Feb 2018, Chris Wilson wrote: >> > drivers/gpu/drm/i915/intel_sdvo.c:223: warning: Function parameter or >> > member 'intel_sdvo' not described

Re: [Intel-gfx] Adding a couple of DSI panel fixes to drm-intel-fixes

2018-02-14 Thread Jani Nikula
On Wed, 14 Feb 2018, Hans de Goede wrote: > Hi All, > > I would like to a add a couple of DSI panel fixes from > dinq to drm-intel-fixes (with the purpose of getting them > into 4.16). > > What is the correct way to do this? Should I just do: > > dim checkout-branch

[Intel-gfx] ✓ Fi.CI.BAT: success for Adding NV12 support (rev10)

2018-02-14 Thread Patchwork
== Series Details == Series: Adding NV12 support (rev10) URL : https://patchwork.freedesktop.org/series/28103/ State : success == Summary == Series 28103v10 Adding NV12 support https://patchwork.freedesktop.org/api/1.0/series/28103/revisions/10/mbox/ Test prime_vgem: Subgroup

Re: [Intel-gfx] [PATCH 3/3] just some guess work to findout the culprit. If this breaks then we know what do.

2018-02-14 Thread Kumar, Abhijeet
On 2/14/2018 4:48 PM, Takashi Iwai wrote: On Wed, 14 Feb 2018 10:06:19 +0100, Kumar, Abhijeet wrote: On 2/14/2018 2:17 PM, Chris Wilson wrote: Quoting Kumar, Abhijeet (2018-02-14 04:53:57) On 2/14/2018 9:36 AM, abhijeet.ku...@intel.com wrote: From: Abhijeet Kumar

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fixup kerneldoc for intel_uc_fw_upload() (rev2)

2018-02-14 Thread Chris Wilson
Quoting Patchwork (2018-02-14 13:26:26) > == Series Details == > > Series: drm/i915: Fixup kerneldoc for intel_uc_fw_upload() (rev2) > URL : https://patchwork.freedesktop.org/series/38236/ > State : success > > == Summary == > > Series 38236v2 drm/i915: Fixup kerneldoc for

Re: [Intel-gfx] [PULL] drm/i915: Add HDCP support to i915

2018-02-14 Thread Hans Verkuil
On 14/02/18 14:44, Sean Paul wrote: > On Wed, Feb 14, 2018 at 3:33 AM, Hans Verkuil wrote: >> Hi Sean, >> >> On 13/02/18 21:18, Sean Paul wrote: >>> >>> Hi Dave, >>> Here's the pull request for HDCP. Hopefully no surprises since it's been >>> baking >>> in drm-tip for a while

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Adding NV12 support (rev10)

2018-02-14 Thread Patchwork
== Series Details == Series: Adding NV12 support (rev10) URL : https://patchwork.freedesktop.org/series/28103/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6e8ea1c042eb drm/i915/skl+: rename skl_wm_values struct to skl_ddb_values -:65: CHECK: Alignment should match open

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915/crt: Remove obsolete kerneldoc-esque comment

2018-02-14 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/crt: Remove obsolete kerneldoc-esque comment URL : https://patchwork.freedesktop.org/series/38231/ State : failure == Summary == Series 38231v1 series starting with [1/4] drm/i915/crt: Remove obsolete kerneldoc-esque comment

Re: [Intel-gfx] [PATCH] drm: Add DPCD definitions for DP 1.4 FEC feature

2018-02-14 Thread Jani Nikula
On Tue, 13 Feb 2018, Anusha Srivatsa wrote: > Forward Error Correction is supported on DP 1.4. > This patch adds corresponding DPCD register definitions. > > v2: Add dri-devel mailing list to the CC list(Jani) > > v3: Change names, add missing masks (Manasi) > > v4: Add

[Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915/tv: Cleanup up obsolete comments

2018-02-14 Thread Patchwork
== Series Details == Series: drm/i915/tv: Cleanup up obsolete comments URL : https://patchwork.freedesktop.org/series/38228/ State : warning == Summary == Test gem_eio: Subgroup in-flight: pass -> DMESG-WARN (shard-snb) fdo#104058 Test perf: Subgroup

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Adding NV12 support (rev10)

2018-02-14 Thread Patchwork
== Series Details == Series: Adding NV12 support (rev10) URL : https://patchwork.freedesktop.org/series/28103/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915/skl+: rename skl_wm_values struct to skl_ddb_values Okay! Commit: drm/i915/skl+: refactor WM calculation

Re: [Intel-gfx] Adding a couple of DSI panel fixes to drm-intel-fixes

2018-02-14 Thread Hans de Goede
Hi, On 14-02-18 13:35, Jani Nikula wrote: On Wed, 14 Feb 2018, Hans de Goede wrote: Hi All, I would like to a add a couple of DSI panel fixes from dinq to drm-intel-fixes (with the purpose of getting them into 4.16). What is the correct way to do this? Should I just

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for ICL GEM enabling (v2) (rev2)

2018-02-14 Thread Patchwork
== Series Details == Series: ICL GEM enabling (v2) (rev2) URL : https://patchwork.freedesktop.org/series/38174/ State : warning == Summary == $ dim checkpatch origin/drm-tip e3d750591349 drm/i915/icl: Add the ICL PCI IDs -:47: ERROR: Macros with complex values should be enclosed in

Re: [Intel-gfx] [PULL] drm/i915: Add HDCP support to i915

2018-02-14 Thread Sean Paul
On Wed, Feb 14, 2018 at 3:33 AM, Hans Verkuil wrote: > Hi Sean, > > On 13/02/18 21:18, Sean Paul wrote: >> >> Hi Dave, >> Here's the pull request for HDCP. Hopefully no surprises since it's been >> baking >> in drm-tip for a while now. >> >> topic/hdcp-2018-02-13: >> Add HDCP

Re: [Intel-gfx] [PATCH 0/5] Fix deadlock on runtime suspend in DRM drivers

2018-02-14 Thread Sean Paul
On Wed, Feb 14, 2018 at 10:26:35AM +0100, Maarten Lankhorst wrote: > Op 14-02-18 om 09:46 schreef Lukas Wunner: > > Dear drm-misc maintainers, > > > > On Sun, Feb 11, 2018 at 10:38:28AM +0100, Lukas Wunner wrote: > >> Fix a deadlock on hybrid graphics laptops that's been present since 2013: > >

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/panel: Add missing parameters to kerneldoc

2018-02-14 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/panel: Add missing parameters to kerneldoc URL : https://patchwork.freedesktop.org/series/38230/ State : success == Summary == Series 38230v1 series starting with [1/2] drm/i915/panel: Add missing parameters to kerneldoc

Re: [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Adding NV12 support (rev10)

2018-02-14 Thread Maarten Lankhorst
Op 14-02-18 om 13:37 schreef Patchwork: > == Series Details == > > Series: Adding NV12 support (rev10) > URL : https://patchwork.freedesktop.org/series/28103/ > State : warning > > == Summary == > > $ dim sparse origin/drm-tip > Commit: drm/i915/skl+: rename skl_wm_values struct to

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add missing kerneldoc parameters for huc_ucode_xfer

2018-02-14 Thread Patchwork
== Series Details == Series: drm/i915: Add missing kerneldoc parameters for huc_ucode_xfer URL : https://patchwork.freedesktop.org/series/38235/ State : success == Summary == Series 38235v1 drm/i915: Add missing kerneldoc parameters for huc_ucode_xfer

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fixup kerneldoc for intel_uc_fw_upload() (rev2)

2018-02-14 Thread Patchwork
== Series Details == Series: drm/i915: Fixup kerneldoc for intel_uc_fw_upload() (rev2) URL : https://patchwork.freedesktop.org/series/38236/ State : success == Summary == Series 38236v2 drm/i915: Fixup kerneldoc for intel_uc_fw_upload()

Re: [Intel-gfx] [PATCH 05/20] drm/i915/icl: Interrupt handling

2018-02-14 Thread Mika Kuoppala
Mika Kuoppala writes: > From: Tvrtko Ursulin > > v2: Rebase. > > v3: > * Remove DPF, it has been removed from SKL+. > * Fix -internal rebase wrt. execlists interrupt handling. > > v4: Rebase. > > v5: > * Updated for POR changes.

Re: [Intel-gfx] [PATCH 0/5] Fix deadlock on runtime suspend in DRM drivers

2018-02-14 Thread Lukas Wunner
On Tue, Feb 13, 2018 at 03:46:08PM +, Liviu Dudau wrote: > On Tue, Feb 13, 2018 at 12:52:06PM +0100, Lukas Wunner wrote: > > On Tue, Feb 13, 2018 at 10:55:06AM +, Liviu Dudau wrote: > > > On Sun, Feb 11, 2018 at 10:38:28AM +0100, Lukas Wunner wrote: > > > > DRM drivers poll connectors in

[Intel-gfx] [PATCH] drm/i915: Fixup kerneldoc for intel_pm.c

2018-02-14 Thread Chris Wilson
drivers/gpu/drm/i915/intel_pm.c:750: warning: Function parameter or member 'fifo_size' not described in 'intel_calculate_wm' drivers/gpu/drm/i915/intel_pm.c:5900: warning: Function parameter or member 'crtc' not described in 'intel_update_watermarks' Signed-off-by: Chris Wilson

Re: [Intel-gfx] ✗ Fi.CI.SPARSE: warning for Adding NV12 support (rev10)

2018-02-14 Thread Arkadiusz Hiler
On Wed, Feb 14, 2018 at 02:07:49PM +0100, Maarten Lankhorst wrote: > Op 14-02-18 om 13:37 schreef Patchwork: > > == Series Details == > > > > Series: Adding NV12 support (rev10) > > URL : https://patchwork.freedesktop.org/series/28103/ > > State : warning > > > > == Summary == > > > > $ dim

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Make use of unused variable in hsw_write_infoframe()

2018-02-14 Thread Chris Wilson
Quoting Ville Syrjälä (2018-02-14 13:33:03) > On Tue, Feb 13, 2018 at 04:29:17PM -0800, José Roberto de Souza wrote: > > data_reg was not being used but it can be used to reduce the number of > > calls to hsw_dip_data_reg() and just increment the reg by the size of > > uint32. > > > >

[Intel-gfx] ✓ Fi.CI.BAT: success for ICL GEM enabling (v2) (rev2)

2018-02-14 Thread Patchwork
== Series Details == Series: ICL GEM enabling (v2) (rev2) URL : https://patchwork.freedesktop.org/series/38174/ State : success == Summary == Series 38174v2 ICL GEM enabling (v2) https://patchwork.freedesktop.org/api/1.0/series/38174/revisions/2/mbox/ fi-bdw-5557u total:288 pass:267

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: Add DPCD definitions for DP 1.4 FEC feature (rev4)

2018-02-14 Thread Patchwork
== Series Details == Series: drm: Add DPCD definitions for DP 1.4 FEC feature (rev4) URL : https://patchwork.freedesktop.org/series/34259/ State : success == Summary == Series 34259v4 drm: Add DPCD definitions for DP 1.4 FEC feature

Re: [Intel-gfx] [PATCH 3/3] just some guess work to findout the culprit. If this breaks then we know what do.

2018-02-14 Thread Chris Wilson
Quoting Kumar, Abhijeet (2018-02-14 04:53:57) > > > On 2/14/2018 9:36 AM, abhijeet.ku...@intel.com wrote: > > From: Abhijeet Kumar > > --- > sound/pci/hda/hda_codec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Intel-gfx] [igt-dev] [PATCH igt] igt/gem_exec_schedule: Trim max number of contexts used

2018-02-14 Thread Chris Wilson
Quoting Antonio Argenziano (2018-02-13 23:51:00) > > > On 13/02/18 15:10, Chris Wilson wrote: > > Quoting Antonio Argenziano (2018-02-13 22:47:35) > >> > >> > >> On 13/02/18 01:26, Chris Wilson wrote: > >>> icl offers a much reduced context space, and in its simplest setup we > >>> cannot

[Intel-gfx] [PATCH] drm/i915/sdvo: Tidy up commentary

2018-02-14 Thread Chris Wilson
Drop the kerneldoc markup from the non-kerneldoc comments and convert the multi-line comments to the canonical format. drivers/gpu/drm/i915/intel_sdvo.c:223: warning: Function parameter or member 'intel_sdvo' not described in 'intel_sdvo_write_sdvox' drivers/gpu/drm/i915/intel_sdvo.c:223:

[Intel-gfx] ✓ Fi.CI.IGT: success for Forward Error Correction is supported on DP 1.4. This patch adds corresponding DPCD register definitions.

2018-02-14 Thread Patchwork
== Series Details == Series: Forward Error Correction is supported on DP 1.4. This patch adds corresponding DPCD register definitions. URL : https://patchwork.freedesktop.org/series/38219/ State : success == Summary == Test perf: Subgroup oa-exponents: fail ->

Re: [Intel-gfx] [PATCH 0/5] Fix deadlock on runtime suspend in DRM drivers

2018-02-14 Thread Maarten Lankhorst
Op 14-02-18 om 09:46 schreef Lukas Wunner: > Dear drm-misc maintainers, > > On Sun, Feb 11, 2018 at 10:38:28AM +0100, Lukas Wunner wrote: >> Fix a deadlock on hybrid graphics laptops that's been present since 2013: > This series has been reviewed, consent has been expressed by the most >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/sdvo: Tidy up commentary

2018-02-14 Thread Patchwork
== Series Details == Series: drm/i915/sdvo: Tidy up commentary URL : https://patchwork.freedesktop.org/series/38229/ State : success == Summary == Series 38229v1 drm/i915/sdvo: Tidy up commentary https://patchwork.freedesktop.org/api/1.0/series/38229/revisions/1/mbox/ Test gem_mmap_gtt:

Re: [Intel-gfx] [PATCH] drm/i915: Add missing kerneldoc parameters for huc_ucode_xfer

2018-02-14 Thread Michal Wajdeczko
On Wed, 14 Feb 2018 11:40:40 +0100, Chris Wilson wrote: During the recent upheaval to uc, the parameters to huc_ucode_xfer were changed, but the kerneldoc left behind. drivers/gpu/drm/i915/intel_huc.c:128: warning: Function parameter or member 'huc_fw' not

[Intel-gfx] ✗ Fi.CI.IGT: warning for drm: Add DPCD definitions for DP 1.4 FEC feature (rev4)

2018-02-14 Thread Patchwork
== Series Details == Series: drm: Add DPCD definitions for DP 1.4 FEC feature (rev4) URL : https://patchwork.freedesktop.org/series/34259/ State : warning == Summary == Test kms_vblank: Subgroup pipe-c-ts-continuation-dpms-rpm: fail -> PASS (shard-hsw)

Re: [Intel-gfx] [PATCH] drm/i915/tv: Cleanup up obsolete comments

2018-02-14 Thread Jani Nikula
On Wed, 14 Feb 2018, Chris Wilson wrote: > The ages old kerneldoc-esque comments still refer to the original sutbs "Sutbs" sounds like a profanity that should have an urban dictionary definition. As it doesn't (not yet at least!) I presume it's just a boring typo for

Re: [Intel-gfx] [PATCH 3/4] drm/i915/dvo: Fixup commentary

2018-02-14 Thread Jani Nikula
On Wed, 14 Feb 2018, Chris Wilson wrote: > Remove the kerneldoc markup applied to non-kerneldoc comments and > convert the multiline comments to the canonical style. > > drivers/gpu/drm/i915/intel_dvo.c:303: warning: Function parameter or member > 'connector' not

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v5,1/3] drm/i915: Add intel_bios_cleanup() function

2018-02-14 Thread Patchwork
== Series Details == Series: series starting with [v5,1/3] drm/i915: Add intel_bios_cleanup() function URL : https://patchwork.freedesktop.org/series/38223/ State : success == Summary == Series 38223v1 series starting with [v5,1/3] drm/i915: Add intel_bios_cleanup() function

[Intel-gfx] [PATCH 2/4] drm/i915/dvo: Remove incorrect kerneldoc markups

2018-02-14 Thread Chris Wilson
Regular comments where being marked up for kerneldoc, but were not formatted properly. Remove the markup to remove the warnings. drivers/gpu/drm/i915/dvo_ivch.c:192: warning: Function parameter or member 'dvo' not described in 'ivch_read' drivers/gpu/drm/i915/dvo_ivch.c:192: warning: Function

[Intel-gfx] [PATCH 1/4] drm/i915/crt: Remove obsolete kerneldoc-esque comment

2018-02-14 Thread Chris Wilson
The code describes what it is doing quite well; and that is now much more complex than what the old comment would let you believe. drivers/gpu/drm/i915/intel_crt.c:486: warning: Function parameter or member 'connector' not described in 'intel_crt_detect_hotplug' Signed-off-by: Chris Wilson

[Intel-gfx] [PATCH 4/4] drm/i915/lvds: Fixup commentary

2018-02-14 Thread Chris Wilson
Remove the kerneldoc markup applied to non-kerneldoc comments and convert the multiline comments to the canonical style. drivers/gpu/drm/i915/intel_lvds.c:313: warning: Function parameter or member 'encoder' not described in 'intel_enable_lvds' drivers/gpu/drm/i915/intel_lvds.c:313: warning:

[Intel-gfx] [PATCH 3/4] drm/i915/dvo: Fixup commentary

2018-02-14 Thread Chris Wilson
Remove the kerneldoc markup applied to non-kerneldoc comments and convert the multiline comments to the canonical style. drivers/gpu/drm/i915/intel_dvo.c:303: warning: Function parameter or member 'connector' not described in 'intel_dvo_detect' drivers/gpu/drm/i915/intel_dvo.c:303: warning:

[Intel-gfx] [PATCH igt] igt/gem_exec_schedule: Trim max number of contexts used

2018-02-14 Thread Chris Wilson
icl offers a much reduced context space, and in its simplest setup we cannot allocate one context per priority level, so trim the number and reuse the same context for multiple priority requests. v2: Bump the MAX to 1024 (still lower than the ~4096 previously in use) Signed-off-by: Chris Wilson

[Intel-gfx] ✓ Fi.CI.BAT: success for Forward Error Correction is supported on DP 1.4. This patch adds corresponding DPCD register definitions.

2018-02-14 Thread Patchwork
== Series Details == Series: Forward Error Correction is supported on DP 1.4. This patch adds corresponding DPCD register definitions. URL : https://patchwork.freedesktop.org/series/38219/ State : success == Summary == Series 38219v1 Forward Error Correction is supported on DP 1.4. This

[Intel-gfx] [PULL] drm-intel-next

2018-02-14 Thread Joonas Lahtinen
Hi Dave, CI has been really effective in catching problems before users have reported them to us. All Bugzillas closed from this tag are from our CI reports! Due to FOSDEM prep and travel, there's quite a hunk of patches, I've tried to highlight the ones with most impact on the top. Regards,

[Intel-gfx] [PATCH] drm/i915: Fixup kerneldoc for intel_uc_fw_upload()

2018-02-14 Thread Chris Wilson
Just a parameter name change that was lost to kerneldoc. drivers/gpu/drm/i915/intel_uc_fw.c:209: warning: Function parameter or member 'xfer' not described in 'intel_uc_fw_upload' drivers/gpu/drm/i915/intel_uc_fw.c:209: warning: Excess function parameter 'loader' description in

[Intel-gfx] [PATCH v2] drm/i915: Fixup kerneldoc for intel_uc_fw_upload()

2018-02-14 Thread Chris Wilson
Just a parameter name change that was lost to kerneldoc. drivers/gpu/drm/i915/intel_uc_fw.c:209: warning: Function parameter or member 'xfer' not described in 'intel_uc_fw_upload' drivers/gpu/drm/i915/intel_uc_fw.c:209: warning: Excess function parameter 'loader' description in

Re: [Intel-gfx] [PATCH v4 1/3] drm/i915: Add intel_bios_cleanup() function

2018-02-14 Thread Hans de Goede
Hi, On 12-02-18 20:45, Ville Syrjälä wrote: On Tue, Feb 06, 2018 at 03:12:37PM +0100, Hans de Goede wrote: Add an intel_bios_cleanup() function to act as counterpart of intel_bios_init() and move the cleanup of vbt related resources there, putting it in the same file as the allocation.

[Intel-gfx] [PATCH] drm/i915/tv: Cleanup up obsolete comments

2018-02-14 Thread Chris Wilson
The ages old kerneldoc-esque comments still refer to the original sutbs and not the more complete functions. As they were only describing the external entry points (or at least thought themselves to be, they had drifted!), they don't provide any commentary for the code flow.

Re: [Intel-gfx] [PATCH 08/16] drm/i915/skl+: nv12 workaround disable WM level 1-7

2018-02-14 Thread Sharma, Shashank
Reviewed-by: Shashank Sharma Regards Shashank On 2/14/2018 10:27 AM, Vidya Srinivas wrote: From: Mahesh Kumar Display Workaround #0826 (SKL:ALL BXT:ALL) & #1059(CNL:A) Hardware sometimes fails to wake memory from pkg C states fetching the

Re: [Intel-gfx] [PATCH] drm/i915/sdvo: Tidy up commentary

2018-02-14 Thread Jani Nikula
On Wed, 14 Feb 2018, Chris Wilson wrote: > Drop the kerneldoc markup from the non-kerneldoc comments and convert > the multi-line comments to the canonical format. > > drivers/gpu/drm/i915/intel_sdvo.c:223: warning: Function parameter or member > 'intel_sdvo' not

[Intel-gfx] [PATCH] drm/i915: Add missing kerneldoc parameters for huc_ucode_xfer

2018-02-14 Thread Chris Wilson
During the recent upheaval to uc, the parameters to huc_ucode_xfer were changed, but the kerneldoc left behind. drivers/gpu/drm/i915/intel_huc.c:128: warning: Function parameter or member 'huc_fw' not described in 'huc_ucode_xfer' drivers/gpu/drm/i915/intel_huc.c:128: warning: Function parameter

Re: [Intel-gfx] [PATCH 00/16] Adding NV12 support

2018-02-14 Thread Srinivas, Vidya
> -Original Message- > From: Kristian Høgsberg [mailto:hoegsb...@gmail.com] > Sent: Wednesday, February 14, 2018 10:54 AM > To: Srinivas, Vidya > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH 00/16] Adding NV12 support > > On Tue, Feb

[Intel-gfx] [PATCH 2/2] drm/i915/panel: Split range scaling calculation for readiblity

2018-02-14 Thread Chris Wilson
Split the 64b multiplication from the division so that it doesn't sprawl across a couple of lines and use mul_u32_u32() instead of open-coding the 64b conversion. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_panel.c | 5 +++-- 1 file changed, 3

[Intel-gfx] [PATCH 1/2] drm/i915/panel: Add missing parameters to kerneldoc

2018-02-14 Thread Chris Wilson
drivers/gpu/drm/i915/intel_sdvo.c:223: warning: Function parameter or member 'intel_sdvo' not described in 'intel_sdvo_write_sdvox' drivers/gpu/drm/i915/intel_sdvo.c:223: warning: Function parameter or member 'val' not described in 'intel_sdvo_write_sdvox' drivers/gpu/drm/i915/intel_sdvo.c:653:

Re: [Intel-gfx] [PATCH 03/20] drm/i915/icl: Show interrupt registers in debugfs

2018-02-14 Thread Mika Kuoppala
Daniele Ceraolo Spurio writes: > On 13/02/18 08:37, Mika Kuoppala wrote: >> From: Tvrtko Ursulin >> >> v2: Update for POR changes. (Daniele Ceraolo Spurio) >> >> Signed-off-by: Tvrtko Ursulin >>

Re: [Intel-gfx] [PATCH 2/4] drm/i915/dvo: Remove incorrect kerneldoc markups

2018-02-14 Thread Jani Nikula
On Wed, 14 Feb 2018, Chris Wilson wrote: > Regular comments where being marked up for kerneldoc, but were not > formatted properly. Remove the markup to remove the warnings. > > drivers/gpu/drm/i915/dvo_ivch.c:192: warning: Function parameter or member > 'dvo' not

Re: [Intel-gfx] [PATCH 4/4] drm/i915/lvds: Fixup commentary

2018-02-14 Thread Jani Nikula
On Wed, 14 Feb 2018, Chris Wilson wrote: > Remove the kerneldoc markup applied to non-kerneldoc comments and > convert the multiline comments to the canonical style. > > drivers/gpu/drm/i915/intel_lvds.c:313: warning: Function parameter or member > 'encoder' not

Re: [Intel-gfx] [PATCH 1/4] drm/i915/crt: Remove obsolete kerneldoc-esque comment

2018-02-14 Thread Jani Nikula
On Wed, 14 Feb 2018, Chris Wilson wrote: > The code describes what it is doing quite well; and that is now much > more complex than what the old comment would let you believe. > > drivers/gpu/drm/i915/intel_crt.c:486: warning: Function parameter or member > 'connector'

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v5,1/3] drm/i915: Add intel_bios_cleanup() function

2018-02-14 Thread Patchwork
== Series Details == Series: series starting with [v5,1/3] drm/i915: Add intel_bios_cleanup() function URL : https://patchwork.freedesktop.org/series/38223/ State : success == Summary == Test kms_vblank: Subgroup pipe-c-ts-continuation-dpms-rpm: fail -> PASS

[Intel-gfx] [PATCH] drm: Add DPCD definitions for DP 1.4 FEC feature

2018-02-14 Thread Anusha Srivatsa
Forward Error Correction is supported on DP 1.4. This patch adds corresponding DPCD register definitions. v2: Add dri-devel mailing list to the CC list(Jani) v3: Change names, add missing masks (Manasi) v4: Add missing shifts to mask (Manasi) v5: Arrange the definitions in ascending order of

[Intel-gfx] [PATCH v5 1/3] drm/i915: Add intel_bios_cleanup() function

2018-02-14 Thread Hans de Goede
Add an intel_bios_cleanup() function to act as counterpart of intel_bios_init() and move the cleanup of vbt related resources there, putting it in the same file as the allocation. Changed in v2: -While touching the code anyways, remove the unnecessary: if (dev_priv->vbt.child_dev) done before

[Intel-gfx] [PATCH v5 2/3] drm/i915: Free memdup-ed DSI VBT data structures on driver_unload

2018-02-14 Thread Hans de Goede
Make intel_bios_cleanup function free the DSI VBT data structures which are memdup-ed by parse_mipi_config() and parse_mipi_sequence(). Reviewed-by: Ville Syrjälä Signed-off-by: Hans de Goede --- drivers/gpu/drm/i915/intel_bios.c | 6 ++

[Intel-gfx] [PATCH v5 3/3] drm/i915: Fix DSI panels with v1 MIPI sequences without a DEASSERT sequence v3

2018-02-14 Thread Hans de Goede
So far models of the Dell Venue 8 Pro, with a panel with MIPI panel index = 3, one of which has been kindly provided to me by Jan Brummer, where not working with the i915 driver, giving a black screen on the first modeset. The problem with at least these Dells is that their VBT defines a MIPI

Re: [Intel-gfx] [PATCH 05/16] drm/i915/skl+: NV12 related changes for WM

2018-02-14 Thread Sharma, Shashank
Ideal case would have been an enum for nv12 planes with y and uv parameters, to indicate in code, but I will at least prefer the plane_num variable should be replaced by plane_id, as plane_number 0 and 1 confuses. With that change, feel free to use: Reviewed-by: Shashank Sharma

Re: [Intel-gfx] [PATCH 09/16] drm/i915/skl: split skl_compute_ddb function

2018-02-14 Thread Sharma, Shashank
Reviewed-by: Shashank Sharma Regards Shashank On 2/14/2018 10:27 AM, Vidya Srinivas wrote: From: Mahesh Kumar This patch splits skl_compute_wm/ddb functions into two parts. One adds all affected pipes after the commit to atomic_state

Re: [Intel-gfx] [PATCH 2/4] drm/i915/dvo: Remove incorrect kerneldoc markups

2018-02-14 Thread Chris Wilson
Quoting Jani Nikula (2018-02-14 10:25:06) > On Wed, 14 Feb 2018, Chris Wilson wrote: > > Regular comments where being marked up for kerneldoc, but were not > > formatted properly. Remove the markup to remove the warnings. > > > > drivers/gpu/drm/i915/dvo_ivch.c:192:

Re: [Intel-gfx] [PATCH 1/2] drm/i915/panel: Add missing parameters to kerneldoc

2018-02-14 Thread Chris Wilson
Quoting Chris Wilson (2018-02-14 09:17:46) > drivers/gpu/drm/i915/intel_sdvo.c:223: warning: Function parameter or member > 'intel_sdvo' not described in 'intel_sdvo_write_sdvox' > drivers/gpu/drm/i915/intel_sdvo.c:223: warning: Function parameter or member > 'val' not described in

Re: [Intel-gfx] [PATCH] drm/i915: Fixup kerneldoc for intel_uc_fw_upload()

2018-02-14 Thread Michal Wajdeczko
On Wed, 14 Feb 2018 11:41:54 +0100, Chris Wilson wrote: Just a parameter name change that was lost to kerneldoc. drivers/gpu/drm/i915/intel_uc_fw.c:209: warning: Function parameter or member 'xfer' not described in 'intel_uc_fw_upload'

[Intel-gfx] [PATCH 21/43] misc/mei/hdcp: Closing wired HDCP2.2 Tx Session

2018-02-14 Thread Ramalingam C
Request the ME to terminate the HDCP2.2 session for a port. On Success, ME FW will mark the intel port as Deauthenticated and terminate the wired HDCP2.2 Tx session started due to the cmd WIRED_INITIATE_HDCP2_SESSION. Signed-off-by: Ramalingam C ---

[Intel-gfx] [PATCH 24/43] drm/i915: wait for cp_irq

2018-02-14 Thread Ramalingam C
DP HDCP asserts the CP_IRQ to indicate the msg availability and auth state change at the panel. Implements a completion structure to communicate the cp_irq assertion and provides a function to wait for cp_irq with a timeout. This can be used for implementation of both HDCP1.4 and HDCP2.2

[Intel-gfx] [PATCH 26/43] drm/i915: Define Intel HDCP2.2 registers

2018-02-14 Thread Ramalingam C
Intel HDCP2.2 registers are defined with addr offsets and bit details. Macros are defined for referencing the register offsets based on the port index. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/i915_reg.h | 120 1 file

[Intel-gfx] [PATCH 27/43] drm/i915: Wrappers for mei HDCP2.2 services

2018-02-14 Thread Ramalingam C
Adds the wrapper for all mei hdcp2.2 service functions. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/intel_hdcp.c | 189 ++ 1 file changed, 189 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_hdcp.c

[Intel-gfx] [PATCH 29/43] drm/i915: Implement HDCP2.2 repeater authentication

2018-02-14 Thread Ramalingam C
Implements the HDCP2.2 repeaters authentication steps such as verifying the downstream topology and sending stream management information. Signed-off-by: Ramalingam C --- drivers/gpu/drm/i915/intel_hdcp.c | 133 ++ 1 file changed, 133

[Intel-gfx] [PATCH 05/43] misc/mei/hdcp: Client driver for HDCP application

2018-02-14 Thread Ramalingam C
ME FW is contributes a vital role in HDCP2.2 authentication. HDCP2.2 driver needs to communicate to ME FW for each step of the HDCP2.2 authentication. ME FW prepare and HDCP2.2 authentication parameters and encrypt them as per spec. With such parameter Driver prepares HDCP2.2 auth messages and

[Intel-gfx] [PATCH 07/43] misc/mei/hdcp: Verify mei client device status

2018-02-14 Thread Ramalingam C
Checks whether mei client device for hdcp2.2 is enabled? Signed-off-by: Ramalingam C --- drivers/misc/mei/mei_hdcp.c | 12 1 file changed, 12 insertions(+) diff --git a/drivers/misc/mei/mei_hdcp.c b/drivers/misc/mei/mei_hdcp.c index

[Intel-gfx] [PATCH 09/43] misc/mei/hdcp: Define ME FW interface for HDCP2.2

2018-02-14 Thread Ramalingam C
Defines the HDCP specific ME FW interfaces such as Request CMDs, payload structure for CMDs and their response status codes. This patch defines payload size(Excluding the Header)for each WIRED HDCP2.2 CMDs. Signed-off-by: Ramalingam C --- drivers/misc/mei/mei_hdcp.h |

[Intel-gfx] [PATCH 04/43] mei: me: add gemini lake devices ids

2018-02-14 Thread Ramalingam C
From: Tomas Winkler Signed-off-by: Tomas Winkler --- drivers/misc/mei/hw-me-regs.h | 2 ++ drivers/misc/mei/pci-me.c | 2 ++ 2 files changed, 4 insertions(+) diff --git a/drivers/misc/mei/hw-me-regs.h b/drivers/misc/mei/hw-me-regs.h index

[Intel-gfx] [PATCH 18/43] misc/mei/hdcp: Repeater topology verifcation and ack

2018-02-14 Thread Ramalingam C
Request ot ME to verify the downatream topology information received. ME FW will validate the Repeaters receiver id list and downstream topology. On Success ME FW will provide the Least Significant 128bits of VPrime, which forms the repeater ack. Signed-off-by: Ramalingam C

[Intel-gfx] [PATCH 19/43] misc/mei/hdcp: Verify M_prime

2018-02-14 Thread Ramalingam C
Request to ME to verify the M_Prime received from the HDCP sink. ME FW will calculate the M and compare with M_prime received as part of RepeaterAuth_Stream_Ready, which is HDCP2.2 protocol msg. On successful completion of this stage, downstream propagation of the stream management info is

[Intel-gfx] [PATCH 17/43] misc/mei/hdcp: Prepare Session Key

2018-02-14 Thread Ramalingam C
Request to ME to prepare the encrypted session key. On Success, ME provides Encrypted session key. Functions populates the HDCP2.2 authentication msg SKE_Send_Eks. Signed-off-by: Ramalingam C --- drivers/misc/mei/mei_hdcp.c | 68

[Intel-gfx] [PATCH 12/43] misc/mei/hdcp: Verify Receiver Cert and prepare km

2018-02-14 Thread Ramalingam C
Requests for verification for receiver certification and also the preparation for next AKE auth message with km. On Success ME FW validate the HDCP2.2 receivers certificate and do the revocation check on the receiver ID. AKE_Stored_Km will be prepared if the receiver is already paired, else

[Intel-gfx] [PATCH 11/43] misc/mei/hdcp: Initiate Wired HDCP2.2 Tx Session

2018-02-14 Thread Ramalingam C
Request ME FW to start the HDCP2.2 session for a intel port. Prepares payloads for command WIRED_INITIATE_HDCP2_SESSION and sent to ME FW. On Success, ME FW will start a HDCP2.2 session for the port and provides the content for HDCP2.2 AKE_Init message. Signed-off-by: Ramalingam C

[Intel-gfx] [PATCH 10/43] linux/mei: Header for mei_hdcp driver interface

2018-02-14 Thread Ramalingam C
Data structures and Enum for the I915-MEI_HDCP interface are defined at Signed-off-by: Ramalingam C --- include/linux/mei_hdcp.h | 71 1 file changed, 71 insertions(+) diff --git a/include/linux/mei_hdcp.h

[Intel-gfx] [PATCH 13/43] misc/mei/hdcp: Verify H_prime

2018-02-14 Thread Ramalingam C
Requests for the verifcation of AKE_Send_H_prime. ME will calculation the H and comparing it with received H_Prime. Here AKE_Send_H_prime is a HDCP2.2 Authentication msg. Signed-off-by: Ramalingam C --- drivers/misc/mei/mei_hdcp.c | 65

  1   2   3   4   >