[Intel-gfx] [PATCH] drm/i915/pmu: Inspect runtime PM state more carefully while estimating RC6

2018-04-10 Thread Tvrtko Ursulin
From: Tvrtko Ursulin While thinking about sporadic failures of perf_pmu/rc6-runtime-pm* tests on some CI machines I have concluded that: a) the PMU readout of RC6 can race against runtime PM transitions, and b) there are other reasons than being runtime suspended which

Re: [Intel-gfx] [PATCH] drm/i915/psr: Chase psr.enabled only under the psr.lock

2018-04-10 Thread Chris Wilson
Quoting Souza, Jose (2018-04-06 19:12:27) > On Thu, 2018-04-05 at 12:49 +0100, Chris Wilson wrote: > > Inside the psr work function, we want to wait for PSR to idle first > > and > > wish to do so without blocking the normal modeset path, so we do so > > without holding the PSR lock. However, we

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/bios: remove duplicated code

2018-04-10 Thread Patchwork
== Series Details == Series: drm/i915/bios: remove duplicated code URL : https://patchwork.freedesktop.org/series/41448/ State : success == Summary == Known issues: Test kms_cursor_legacy: Subgroup flip-vs-cursor-varying-size: pass -> FAIL (shard-hsw)

Re: [Intel-gfx] [PATCH] drm/i915/guc: Replace %phn with %phN

2018-04-10 Thread Michal Wajdeczko
On Tue, 10 Apr 2018 11:14:35 +0200, Chris Wilson wrote: %phn is not a valid specifier, Well, implementation allows that as alias for default separator ;) switch (fmt[1]) { case 'C': separator = ':'; break;

[Intel-gfx] [PATCH] drm/i915/guc: Replace %phn with %phN

2018-04-10 Thread Chris Wilson
%phn is not a valid specifier, so I presume %phN was meant for an encoded hex string with no separator (and not that the hex string should be followed by the letter 'n'!). drivers/gpu/drm/i915/intel_guc_ct.c:616 ctb_read() warn: '%ph' cannot be followed by 'n'

Re: [Intel-gfx] [PATCH] drm/i915/guc: Check that the breadcrumb irq is enabled

2018-04-10 Thread Chris Wilson
Quoting Chris Wilson (2018-04-09 15:49:22) > Quoting Michal Wajdeczko (2018-04-09 15:08:40) > > On Mon, 09 Apr 2018 14:42:19 +0200, Chris Wilson > > wrote: > > > > > Our execlists emulation for GuC requires use of the breadcrumb following > > > every request as a

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gen9_lp: Increase DDI PHY0 power well enabling timeout

2018-04-10 Thread Imre Deak
On Mon, Apr 09, 2018 at 04:17:43PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/gen9_lp: Increase DDI PHY0 power well enabling timeout > URL : https://patchwork.freedesktop.org/series/41366/ > State : success Pushed to -dinq, thanks for the review. > > == Summary == >

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/pmu: Inspect runtime PM state more carefully while estimating RC6

2018-04-10 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Inspect runtime PM state more carefully while estimating RC6 URL : https://patchwork.freedesktop.org/series/41453/ State : warning == Summary == Series 41453v1 drm/i915/pmu: Inspect runtime PM state more carefully while estimating RC6

Re: [Intel-gfx] [PATCH 1/1] drm/i915: move audio component intialization before audio driver use it

2018-04-10 Thread Jani Nikula
On Tue, 10 Apr 2018, "Shi, Yang A" wrote: >>On Tue, 10 Apr 2018, "Shi, Yang A" wrote: >>> issue: snd_soc_skl meet "failed to add i915 component master (-19)" >>> when platform don't connect any display output. >>> >>> i915 do initialization before than

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/guc: Replace %phn with %phN

2018-04-10 Thread Patchwork
== Series Details == Series: drm/i915/guc: Replace %phn with %phN URL : https://patchwork.freedesktop.org/series/41452/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4038_full -> Patchwork_8652_full = == Summary - SUCCESS == No regressions found, the changes are of

Re: [Intel-gfx] [PATCH 4/7] drm/i915/icl: Add Voltage swing table for MG PHY DDI Buffer

2018-04-10 Thread Chris Wilson
Quoting Paulo Zanoni (2018-03-23 17:24:16) > From: Manasi Navare > > This table is used for voltage swing programming sequence during DDI > Buffer initialization for MG PHY DDI Buffers on Icelake. Except it is not used at all...

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/bios: remove duplicated code

2018-04-10 Thread Patchwork
== Series Details == Series: drm/i915/bios: remove duplicated code URL : https://patchwork.freedesktop.org/series/41448/ State : success == Summary == Series 41448v1 drm/i915/bios: remove duplicated code https://patchwork.freedesktop.org/api/1.0/series/41448/revisions/1/mbox/ Known

Re: [Intel-gfx] [PATCH] drm/i915/psr: Chase psr.enabled only under the psr.lock

2018-04-10 Thread Chris Wilson
Quoting Rodrigo Vivi (2018-04-09 20:14:32) > On Sat, Apr 07, 2018 at 10:05:25AM +0100, Chris Wilson wrote: > > Quoting Rodrigo Vivi (2018-04-06 23:18:16) > > > On Fri, Apr 06, 2018 at 11:12:27AM -0700, Souza, Jose wrote: > > > > On Thu, 2018-04-05 at 12:49 +0100, Chris Wilson wrote: > > > > > +

Re: [Intel-gfx] [PATCH v2] drm/i915: set minimum CD clock to twice the BCLK.

2018-04-10 Thread Jani Nikula
On Tue, 10 Apr 2018, Jani Nikula wrote: > On Mon, 09 Apr 2018, "Kumar, Abhay" wrote: >> Dynamic cdclk is disabled in BIOS/GOP hence gop makes it to highest >> clock i.e 316.8. Will attach logs with drm debug enabled in bug. >> I am also inclined

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [v8,01/12] drm/i915: Park before resetting the submission backend

2018-04-10 Thread Chris Wilson
Quoting Sagar Arun Kamble (2018-04-10 06:32:29) > > > On 4/9/2018 9:02 PM, Michal Wajdeczko wrote: > > On Mon, 09 Apr 2018 17:09:18 +0200, Patchwork > > wrote: > > > >> == Series Details == > >> > >> Series: series starting with [v8,01/12] drm/i915: Park

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Inspect runtime PM state more carefully while estimating RC6

2018-04-10 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-04-10 10:23:28) > From: Tvrtko Ursulin > > While thinking about sporadic failures of perf_pmu/rc6-runtime-pm* tests > on some CI machines I have concluded that: a) the PMU readout of RC6 can > race against runtime PM transitions, and b)

[Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915/bios: remove duplicated code

2018-04-10 Thread Patchwork
== Series Details == Series: drm/i915/bios: remove duplicated code URL : https://patchwork.freedesktop.org/series/41448/ State : warning == Summary == = CI Bug Log - changes from CI_DRM_4038_full -> Patchwork_8651_full = == Summary - WARNING == Minor unknown changes coming with

[Intel-gfx] [PATCH v2] drm/i915/guc: Replace %phn with %ph

2018-04-10 Thread Chris Wilson
%phn is not a valid specifier, and the trailing 'n' is being eaten by the format-specifier and defaulting to the ' ' separator. Avoid angering smatch by using the unknown specifier, and use the default we expect. drivers/gpu/drm/i915/intel_guc_ct.c:616 ctb_read() warn: '%ph' cannot be followed

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Inspect runtime PM state more carefully while estimating RC6

2018-04-10 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-04-10 11:22:55) > > On 10/04/2018 10:57, Chris Wilson wrote: > > But I'm not understanding the failure -- why is the estimate bad? At the > > very least we still ensure that it is monotonic? Is it just the jitter > > you are worrying about? (If the estimate is bad

Re: [Intel-gfx] [PATCH] drm/i915/guc: Replace %phn with %phN

2018-04-10 Thread Chris Wilson
Quoting Michal Wajdeczko (2018-04-10 11:57:03) > On Tue, 10 Apr 2018 11:14:35 +0200, Chris Wilson > wrote: > > > %phn is not a valid specifier, > > Well, implementation allows that as alias for default separator ;) > > switch (fmt[1]) { > case 'C': >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Replace %phn with %phN

2018-04-10 Thread Patchwork
== Series Details == Series: drm/i915/guc: Replace %phn with %phN URL : https://patchwork.freedesktop.org/series/41452/ State : success == Summary == Series 41452v1 drm/i915/guc: Replace %phn with %phN https://patchwork.freedesktop.org/api/1.0/series/41452/revisions/1/mbox/ Known

Re: [Intel-gfx] [PATCH] drm/i915/audio: Fix audio detection issue on GLK

2018-04-10 Thread Jani Nikula
On Mon, 09 Apr 2018, "Kumar, Abhay" wrote: > On 4/9/2018 4:20 PM, Pandiyan, Dhinakaran wrote: >> >> >> On Mon, 2018-04-09 at 12:18 -0700, Kumar, Abhay wrote: >>> On 4/9/2018 12:10 PM, Rodrigo Vivi wrote: On Mon, Apr 09, 2018 at 05:07:31PM +0300, Jani Nikula wrote:

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Inspect runtime PM state more carefully while estimating RC6

2018-04-10 Thread Tvrtko Ursulin
On 10/04/2018 10:57, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-04-10 10:23:28) From: Tvrtko Ursulin While thinking about sporadic failures of perf_pmu/rc6-runtime-pm* tests on some CI machines I have concluded that: a) the PMU readout of RC6 can race against

[Intel-gfx] [PATCH v2] drm/i915/pmu: Inspect runtime PM state more carefully while estimating RC6

2018-04-10 Thread Tvrtko Ursulin
From: Tvrtko Ursulin While thinking about sporadic failures of perf_pmu/rc6-runtime-pm* tests on some CI machines I have concluded that: a) the PMU readout of RC6 can race against runtime PM transitions, and b) there are other reasons than being runtime suspended which

Re: [Intel-gfx] [PATCH v2] drm/i915/pmu: Inspect runtime PM state more carefully while estimating RC6

2018-04-10 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-04-10 11:34:40) > From: Tvrtko Ursulin > > While thinking about sporadic failures of perf_pmu/rc6-runtime-pm* tests > on some CI machines I have concluded that: a) the PMU readout of RC6 can > race against runtime PM transitions, and b)

[Intel-gfx] [PATCH] drm/i915/bios: remove duplicated code

2018-04-10 Thread Jani Nikula
Apparently caused by a merge fail at some point. Due to the nature of the duplicated block, the second one will have no effect, and there's no need to backport. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_bios.c | 7 --- 1 file changed, 7 deletions(-)

Re: [Intel-gfx] [PATCH] drm/i915/pmu: Inspect runtime PM state more carefully while estimating RC6

2018-04-10 Thread Tvrtko Ursulin
On 10/04/2018 11:34, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-04-10 11:22:55) On 10/04/2018 10:57, Chris Wilson wrote: But I'm not understanding the failure -- why is the estimate bad? At the very least we still ensure that it is monotonic? Is it just the jitter you are worrying

[Intel-gfx] [PATCH v3] drm/i915/pmu: Inspect runtime PM state more carefully while estimating RC6

2018-04-10 Thread Tvrtko Ursulin
From: Tvrtko Ursulin While thinking about sporadic failures of perf_pmu/rc6-runtime-pm* tests on some CI machines I have concluded that: a) the PMU readout of RC6 can race against runtime PM transitions, and b) there are other reasons than being runtime suspended which

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915/guc: Check that the breadcrumb irq is enabled

2018-04-10 Thread Chris Wilson
Quoting Patchwork (2018-04-10 00:57:45) > == Series Details == > > Series: series starting with [1/2] drm/i915/guc: Check that the breadcrumb > irq is enabled > URL : https://patchwork.freedesktop.org/series/41396/ > State : failure > > == Summary == > > Possible new issues: > > Test

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/guc: Replace %phn with %phN

2018-04-10 Thread Patchwork
== Series Details == Series: drm/i915/guc: Replace %phn with %phN URL : https://patchwork.freedesktop.org/series/41452/ State : failure == Summary == Possible new issues: Test kms_frontbuffer_tracking: Subgroup fbc-rgb565-draw-mmap-gtt: pass -> FAIL

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Replace %phn with %phN (rev2)

2018-04-10 Thread Patchwork
== Series Details == Series: drm/i915/guc: Replace %phn with %phN (rev2) URL : https://patchwork.freedesktop.org/series/41452/ State : success == Summary == Series 41452v2 drm/i915/guc: Replace %phn with %phN https://patchwork.freedesktop.org/api/1.0/series/41452/revisions/2/mbox/

Re: [Intel-gfx] [PATCH 27/36] drm/i915: Split control of rps and rc6

2018-04-10 Thread Chris Wilson
Quoting Sagar Arun Kamble (2018-03-16 13:03:03) > > > On 3/16/2018 2:22 PM, Sagar Arun Kamble wrote: > > > > > > On 3/14/2018 3:07 PM, Chris Wilson wrote: > >> Allow ourselves to individually toggle rps or rc6. This will be used > >> later when we want to enable rps/rc6 at different phases

[Intel-gfx] [CI] drm/i915: Don't fiddle with rps/rc6 across GPU reset

2018-04-10 Thread Chris Wilson
Resetting the GPU doesn't affect the RPS/RC6 state, so we can stop forcibly reloading the registers. Ville suggested this many moons ago, I said at that time that sanitizing was no harm and meant that our bookkeeping was kept consistent with the HW. However, in a forthcoming series, we want to

Re: [Intel-gfx] [PATCH 01/18] drm/i915/execlists: Set queue priority from secondary port

2018-04-10 Thread Tvrtko Ursulin
On 09/04/2018 12:13, Chris Wilson wrote: We can refine our current execlists->queue_priority if we inspect ELSP[1] rather than the head of the unsubmitted queue. Currently, we use the unsubmitted queue and say that if a subsequent request is more than important than the current queue, we will

[Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915/gvt: fix memory leak of a cmd_entry struct on error exit path

2018-04-10 Thread Patchwork
== Series Details == Series: drm/i915/gvt: fix memory leak of a cmd_entry struct on error exit path URL : https://patchwork.freedesktop.org/series/41469/ State : warning == Summary == = CI Bug Log - changes from CI_DRM_4040_full -> Patchwork_8656_full = == Summary - WARNING == Minor

Re: [Intel-gfx] [PATCH] drm/i915: Add debugfs file to clear FIFO underruns.

2018-04-10 Thread Maarten Lankhorst
Op 09-04-18 om 21:48 schreef Rodrigo Vivi: > On Wed, Mar 28, 2018 at 06:20:26PM +0200, Maarten Lankhorst wrote: >> Op 28-03-18 om 12:21 schreef Jani Nikula: >>> On Wed, 28 Mar 2018, Maarten Lankhorst >>> wrote: Adding a i915_fifo_underrun_reset debugfs

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gvt: fix memory leak of a cmd_entry struct on error exit path

2018-04-10 Thread Patchwork
== Series Details == Series: drm/i915/gvt: fix memory leak of a cmd_entry struct on error exit path URL : https://patchwork.freedesktop.org/series/41469/ State : success == Summary == Series 41469v1 drm/i915/gvt: fix memory leak of a cmd_entry struct on error exit path

Re: [Intel-gfx] [PATCH 01/18] drm/i915/execlists: Set queue priority from secondary port

2018-04-10 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-04-10 15:42:07) > > On 10/04/2018 15:24, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2018-04-10 15:05:33) > >> > >> On 09/04/2018 12:13, Chris Wilson wrote: > >>> We can refine our current execlists->queue_priority if we inspect > >>> ELSP[1] rather than the head

Re: [Intel-gfx] [PATCH] drm/i915/gvt: fix memory leak of a cmd_entry struct on error exit path

2018-04-10 Thread Chris Wilson
Quoting Colin King (2018-04-10 13:33:12) > From: Colin Ian King > > The error exit path when a duplicate is found does not kfree and cmd_entry > struct and hence there is a small memory leak. Fix this by kfree'ing it. > > Detected by CoverityScan, CID#1370198

Re: [Intel-gfx] [PATCH 1/1] drm/i915: move audio component intialization before audio driver use it

2018-04-10 Thread Jani Nikula
On Tue, 10 Apr 2018, Jani Nikula wrote: > On Tue, 10 Apr 2018, "Shi, Yang A" wrote: >>>On Tue, 10 Apr 2018, "Shi, Yang A" wrote: issue: snd_soc_skl meet "failed to add i915 component master (-19)" when platform

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Don't fiddle with rps/rc6 across GPU reset

2018-04-10 Thread Patchwork
== Series Details == Series: drm/i915: Don't fiddle with rps/rc6 across GPU reset URL : https://patchwork.freedesktop.org/series/41474/ State : success == Summary == Series 41474v1 drm/i915: Don't fiddle with rps/rc6 across GPU reset

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] tools/aubdump: Fix ISO C90 forbids mixed declarations and code warning

2018-04-10 Thread Scott D Phillips
Tvrtko Ursulin writes: > On 09/04/2018 18:03, Scott D Phillips wrote: >> Tvrtko Ursulin writes: >> >>> From: Tvrtko Ursulin >>> >>> Back to a clean build with no warnings, at least for me. >> >> Why c90? If

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pmu: Inspect runtime PM state more carefully while estimating RC6 (rev3)

2018-04-10 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Inspect runtime PM state more carefully while estimating RC6 (rev3) URL : https://patchwork.freedesktop.org/series/41453/ State : success == Summary == Series 41453v3 drm/i915/pmu: Inspect runtime PM state more carefully while estimating RC6

Re: [Intel-gfx] [PATCH 01/18] drm/i915/execlists: Set queue priority from secondary port

2018-04-10 Thread Chris Wilson
Quoting Chris Wilson (2018-04-10 15:56:03) > Quoting Tvrtko Ursulin (2018-04-10 15:42:07) > > > > On 10/04/2018 15:24, Chris Wilson wrote: > > > Quoting Tvrtko Ursulin (2018-04-10 15:05:33) > > >> Although I failed to understand what do we do in both cases if a new > > >> request arrives of

Re: [Intel-gfx] [PATCH 30/36] drm/i915: Refactor frequency bounds computation

2018-04-10 Thread Chris Wilson
Quoting Sagar Arun Kamble (2018-03-17 15:10:08) > > > On 3/14/2018 3:07 PM, Chris Wilson wrote: > > When choosing the initial frequency in intel_gt_pm_busy() we also need > > to calculate the current min/max bounds. As this calculation is going to > > become more complex with the intersection of

[Intel-gfx] [PATCH] drm/i915/gvt: fix memory leak of a cmd_entry struct on error exit path

2018-04-10 Thread Colin King
From: Colin Ian King The error exit path when a duplicate is found does not kfree and cmd_entry struct and hence there is a small memory leak. Fix this by kfree'ing it. Detected by CoverityScan, CID#1370198 ("Resource Leak") Fixes: be1da7070aea ("drm/i915/gvt: vGPU

Re: [Intel-gfx] [PATCH] [v2]drm/i915: move audio component initialization before audio driver use it

2018-04-10 Thread Jani Nikula
On Tue, 10 Apr 2018, Yang wrote: > From: Yang Shi > > issue: snd_soc_skl meet "failed to add i915 component master (-19)" when > platform don't connect any display output. > > i915 do initialization before than skl_probe, but if there is no display >

Re: [Intel-gfx] [PATCH 36/36] drm/i915: Support per-context user requests for GPU frequency control

2018-04-10 Thread Chris Wilson
Quoting Sagar Arun Kamble (2018-03-19 09:51:08) > > > On 3/14/2018 3:07 PM, Chris Wilson wrote: > > @@ -757,8 +767,10 @@ static void guc_submission_tasklet(unsigned long data) > > > > rq = port_request([0]); > > } > > - if (!rq) > > + if (!rq) { > >

[Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915/guc: Replace %phn with %phN (rev2)

2018-04-10 Thread Patchwork
== Series Details == Series: drm/i915/guc: Replace %phn with %phN (rev2) URL : https://patchwork.freedesktop.org/series/41452/ State : warning == Summary == = CI Bug Log - changes from CI_DRM_4040_full -> Patchwork_8654_full = == Summary - WARNING == Minor unknown changes coming with

[Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915/pmu: Inspect runtime PM state more carefully while estimating RC6 (rev3)

2018-04-10 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Inspect runtime PM state more carefully while estimating RC6 (rev3) URL : https://patchwork.freedesktop.org/series/41453/ State : warning == Summary == = CI Bug Log - changes from CI_DRM_4040_full -> Patchwork_8655_full = == Summary - WARNING ==

Re: [Intel-gfx] [PATCH 01/18] drm/i915/execlists: Set queue priority from secondary port

2018-04-10 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-04-10 15:05:33) > > On 09/04/2018 12:13, Chris Wilson wrote: > > We can refine our current execlists->queue_priority if we inspect > > ELSP[1] rather than the head of the unsubmitted queue. Currently, we use > > the unsubmitted queue and say that if a subsequent

[Intel-gfx] [PATCH] drm/i915: Replace use of pipe_crc->lock with an atomic

2018-04-10 Thread Maarten Lankhorst
pipe_crc->lock only protects pipe_crc->skipped. Replace the lock with atomic operations instead, it should work just as well, without the spinlock. In the case we don't skip CRC in the irq, the fastpath is only a single atomic_read(). Signed-off-by: Maarten Lankhorst

Re: [Intel-gfx] [PATCH v6 1/2] drm/i915/cnl: Implement WaProgramMgsrForCorrectSliceSpecificMmioReads

2018-04-10 Thread Zhang, Yunwei
Hi All, I see the latest BAT test failed but the only thing I changed in this new patchset is comment. It should be false alarm, not sure if this is halting the further review. Please see if the code needs more change. Thanks, Yunwei On 3/29/2018 8:44 AM, Yunwei Zhang wrote:

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Move a bunch of workaround-related code to its own file

2018-04-10 Thread Chris Wilson
Quoting Oscar Mateo (2018-04-10 17:12:46) > This has grown to be a sizable amount of code, so move it to > its own file before we try to refactor anything. For the moment, > we are leaving behind the WA BB code and the WAs that get applied > (incorrectly) in init_clock_gating, but we will deal

[Intel-gfx] [PATCH 2/2] drm/i915: Split out functions for different kinds of workarounds

2018-04-10 Thread Oscar Mateo
There are different kind of workarounds (those that modify registers that live in the context image, those that modify global registers, those that whitelist registers, etc...) and they have different requirements in terms of where they are applied and how. Also, by splitting them apart, it should

[Intel-gfx] [PATCH 1/2] drm/i915: Move a bunch of workaround-related code to its own file

2018-04-10 Thread Oscar Mateo
This has grown to be a sizable amount of code, so move it to its own file before we try to refactor anything. For the moment, we are leaving behind the WA BB code and the WAs that get applied (incorrectly) in init_clock_gating, but we will deal with it later. v2: Use intel_ prefix for code that

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Replace use of pipe_crc->lock with an atomic

2018-04-10 Thread Patchwork
== Series Details == Series: drm/i915: Replace use of pipe_crc->lock with an atomic URL : https://patchwork.freedesktop.org/series/41485/ State : failure == Summary == Applying: drm/i915: Replace use of pipe_crc->lock with an atomic error: sha1 information is lacking or useless

Re: [Intel-gfx] [PATCH] drm/i915: Disable LVDS on Radiant P845

2018-04-10 Thread Ondrej Zary
Hello, any news about this patch? The bug is rotting here: https://bugs.freedesktop.org/show_bug.cgi?id=105468 On Monday 12 March 2018 08:25:34 Jani Nikula wrote: > On Fri, 09 Mar 2018, Ondrej Zary wrote: > > Radiant P845 does not have LVDS, only VGA. > > Hi, thanks

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: Move a bunch of workaround-related code to its own file

2018-04-10 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Move a bunch of workaround-related code to its own file URL : https://patchwork.freedesktop.org/series/41491/ State : warning == Summary == $ dim checkpatch origin/drm-tip 18b0bd9fdeb1 drm/i915: Move a bunch of

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Move a bunch of workaround-related code to its own file

2018-04-10 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Move a bunch of workaround-related code to its own file URL : https://patchwork.freedesktop.org/series/41491/ State : success == Summary == Series 41491v1 series starting with [1/2] drm/i915: Move a bunch of

Re: [Intel-gfx] [PATCH] drm/i915/psr: Chase psr.enabled only under the psr.lock

2018-04-10 Thread Rodrigo Vivi
On Tue, Apr 10, 2018 at 12:00:26PM +0100, Chris Wilson wrote: > Quoting Rodrigo Vivi (2018-04-09 20:14:32) > > On Sat, Apr 07, 2018 at 10:05:25AM +0100, Chris Wilson wrote: > > > Quoting Rodrigo Vivi (2018-04-06 23:18:16) > > > > On Fri, Apr 06, 2018 at 11:12:27AM -0700, Souza, Jose wrote: > > > >

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915: Move a bunch of workaround-related code to its own file

2018-04-10 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Move a bunch of workaround-related code to its own file URL : https://patchwork.freedesktop.org/series/41486/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915: Move a bunch of workaround-related code

Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v4] drm/i915: Enable edp psr error interrupts on hsw (rev3)

2018-04-10 Thread Dhinakaran Pandiyan
On Tue, 2018-04-10 at 10:59 -0700, Rodrigo Vivi wrote: > On Tue, Apr 10, 2018 at 12:49:25AM -, Patchwork wrote: > > == Series Details == > > > > Series: series starting with [v4] drm/i915: Enable edp psr error interrupts > > on hsw (rev3) > > URL :

Re: [Intel-gfx] [PATCH 28/36] drm/i915: Enabling rc6 and rps have different requirements, so separate them

2018-04-10 Thread Chris Wilson
Quoting Sagar Arun Kamble (2018-03-16 14:01:22) > > > On 3/14/2018 3:07 PM, Chris Wilson wrote: > > diff --git a/drivers/gpu/drm/i915/i915_gem.c > > b/drivers/gpu/drm/i915/i915_gem.c > > index b9c7b21e5cc8..8a5bf1e26515 100644 > > --- a/drivers/gpu/drm/i915/i915_gem.c > > +++

Re: [Intel-gfx] [PATCH 29/36] drm/i915: Simplify rc6/rps enabling

2018-04-10 Thread Chris Wilson
Quoting Sagar Arun Kamble (2018-03-16 14:28:27) > > > On 3/14/2018 3:07 PM, Chris Wilson wrote: > > void intel_gt_pm_irq_handler(struct drm_i915_private *dev_priv, u32 > > pm_iir) > > { > > struct intel_rps *rps = _priv->gt_pm.rps; > > > > - if (pm_iir & rps->pm_events) { > > +

Re: [Intel-gfx] [PATCH 01/18] drm/i915/execlists: Set queue priority from secondary port

2018-04-10 Thread Tvrtko Ursulin
On 10/04/2018 15:24, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-04-10 15:05:33) On 09/04/2018 12:13, Chris Wilson wrote: We can refine our current execlists->queue_priority if we inspect ELSP[1] rather than the head of the unsubmitted queue. Currently, we use the unsubmitted queue and

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Move a bunch of workaround-related code to its own file

2018-04-10 Thread Oscar Mateo
On 4/10/2018 9:16 AM, Chris Wilson wrote: Quoting Oscar Mateo (2018-04-10 17:12:46) This has grown to be a sizable amount of code, so move it to its own file before we try to refactor anything. For the moment, we are leaving behind the WA BB code and the WAs that get applied (incorrectly) in

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: Move a bunch of workaround-related code to its own file

2018-04-10 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Move a bunch of workaround-related code to its own file URL : https://patchwork.freedesktop.org/series/41486/ State : warning == Summary == $ dim checkpatch origin/drm-tip 8044c5a3e8e3 drm/i915: Move a bunch of

Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v4] drm/i915: Enable edp psr error interrupts on hsw (rev3)

2018-04-10 Thread Rodrigo Vivi
On Tue, Apr 10, 2018 at 12:49:25AM -, Patchwork wrote: > == Series Details == > > Series: series starting with [v4] drm/i915: Enable edp psr error interrupts > on hsw (rev3) > URL : https://patchwork.freedesktop.org/series/41095/ > State : warning > > == Summary == > > $ dim checkpatch

[Intel-gfx] ✗ Fi.CI.IGT: warning for series starting with [1/2] drm/i915: Move a bunch of workaround-related code to its own file

2018-04-10 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Move a bunch of workaround-related code to its own file URL : https://patchwork.freedesktop.org/series/41491/ State : warning == Summary == = CI Bug Log - changes from CI_DRM_4041_full -> Patchwork_8660_full = == Summary -

[Intel-gfx] [PATCH] drm/i915/edp: Only use alternate fixed mode when requested

2018-04-10 Thread clinton . a . taylor
From: Clint Taylor In commit dc911f5bd8aa ("drm/i915/edp: Allow alternate fixed mode for eDP if available."), the patch was always selecting the alternate refresh rate even though user space was asking for the higher rate. This patch adds a check for vrefresh rate as

[Intel-gfx] ✗ Fi.CI.IGT: warning for series starting with [1/2] drm/i915: Move a bunch of workaround-related code to its own file

2018-04-10 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Move a bunch of workaround-related code to its own file URL : https://patchwork.freedesktop.org/series/41486/ State : warning == Summary == = CI Bug Log - changes from CI_DRM_4041_full -> Patchwork_8659_full = == Summary -

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/edp: Only use alternate fixed mode when requested

2018-04-10 Thread Patchwork
== Series Details == Series: drm/i915/edp: Only use alternate fixed mode when requested URL : https://patchwork.freedesktop.org/series/41492/ State : warning == Summary == Series 41492v1 drm/i915/edp: Only use alternate fixed mode when requested

[Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915: Don't fiddle with rps/rc6 across GPU reset

2018-04-10 Thread Patchwork
== Series Details == Series: drm/i915: Don't fiddle with rps/rc6 across GPU reset URL : https://patchwork.freedesktop.org/series/41474/ State : warning == Summary == = CI Bug Log - changes from CI_DRM_4040_full -> Patchwork_8657_full = == Summary - WARNING == Minor unknown changes coming

[Intel-gfx] [PATCH 2/2] drm/i915: Split out functions for different kinds of workarounds

2018-04-10 Thread Oscar Mateo
There are different kind of workarounds (those that modify registers that live in the context image, those that modify global registers, those that whitelist registers, etc...) and they have different requirements in terms of where they are applied and how. Also, by splitting them apart, it should

[Intel-gfx] [PATCH 1/2] drm/i915: Move a bunch of workaround-related code to its own file

2018-04-10 Thread Oscar Mateo
This has grown to be a sizable amount of code, so move it to its own file before we try to refactor anything. For the moment, we are leaving behind the WA BB code and the WAs that get applied (incorrectly) in init_clock_gating, but we will deal with it later. v2: Use intel_ prefix for code that

Re: [Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915: Don't fiddle with rps/rc6 across GPU reset

2018-04-10 Thread Chris Wilson
Quoting Patchwork (2018-04-10 16:46:06) > == Series Details == > > Series: drm/i915: Don't fiddle with rps/rc6 across GPU reset > URL : https://patchwork.freedesktop.org/series/41474/ > State : warning > > == Summary == > > = CI Bug Log - changes from CI_DRM_4040_full -> Patchwork_8657_full =

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Move a bunch of workaround-related code to its own file

2018-04-10 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Move a bunch of workaround-related code to its own file URL : https://patchwork.freedesktop.org/series/41486/ State : success == Summary == Series 41486v1 series starting with [1/2] drm/i915: Move a bunch of

Re: [Intel-gfx] [PATCH v2] drm/i915/guc: Replace %phn with %ph

2018-04-10 Thread Chris Wilson
Quoting Chris Wilson (2018-04-10 12:14:17) > %phn is not a valid specifier, and the trailing 'n' is being eaten by > the format-specifier and defaulting to the ' ' separator. Avoid angering > smatch by using the unknown specifier, and use the default we expect. > >

Re: [Intel-gfx] [PATCH 0/9] GPU-bound energy efficiency improvements for the intel_pstate driver.

2018-04-10 Thread Francisco Jerez
Francisco Jerez writes: > This series attempts to solve an energy efficiency problem of the > current active-mode non-HWP governor of the intel_pstate driver used > for the most part on low-power platforms. Under heavy IO load the > current controller tends to increase

Re: [Intel-gfx] [PATCH] drm/i915/edp: Only use alternate fixed mode when requested

2018-04-10 Thread Chris Wilson
Quoting clinton.a.tay...@intel.com (2018-04-10 19:33:36) > From: Clint Taylor > > In commit dc911f5bd8aa ("drm/i915/edp: Allow alternate fixed mode for eDP > if available."), the patch was always selecting the alternate refresh rate > even though user space was asking

Re: [Intel-gfx] [PATCH 4/7] drm/i915/icl: Add Voltage swing table for MG PHY DDI Buffer

2018-04-10 Thread Chris Wilson
Quoting Paulo Zanoni (2018-04-10 21:39:31) > Em Ter, 2018-04-10 às 09:51 +0100, Chris Wilson escreveu: > > Quoting Paulo Zanoni (2018-03-23 17:24:16) > > > From: Manasi Navare > > > > > > This table is used for voltage swing programming sequence during > > > DDI > > >

Re: [Intel-gfx] [PATCH] drm/i915/bios: remove duplicated code

2018-04-10 Thread Paulo Zanoni
Em Ter, 2018-04-10 às 12:12 +0300, Jani Nikula escreveu: > Apparently caused by a merge fail at some point. Due to the nature of > the duplicated block, the second one will have no effect, and there's > no > need to backport. > > Signed-off-by: Jani Nikula Reviewed-by:

Re: [Intel-gfx] [PATCH 4/7] drm/i915/icl: Add Voltage swing table for MG PHY DDI Buffer

2018-04-10 Thread Paulo Zanoni
Em Ter, 2018-04-10 às 09:51 +0100, Chris Wilson escreveu: > Quoting Paulo Zanoni (2018-03-23 17:24:16) > > From: Manasi Navare > > > > This table is used for voltage swing programming sequence during > > DDI > > Buffer initialization for MG PHY DDI Buffers on Icelake.

Re: [Intel-gfx] [PATCH 4/7] drm/i915/icl: Add Voltage swing table for MG PHY DDI Buffer

2018-04-10 Thread Chris Wilson
Quoting Chris Wilson (2018-04-10 22:01:33) > Quoting Paulo Zanoni (2018-04-10 21:39:31) > > Em Ter, 2018-04-10 às 09:51 +0100, Chris Wilson escreveu: > > > Quoting Paulo Zanoni (2018-03-23 17:24:16) > > > > From: Manasi Navare > > > > > > > > This table is used for

Re: [Intel-gfx] [PATCH 4/7] drm/i915/icl: Add Voltage swing table for MG PHY DDI Buffer

2018-04-10 Thread Paulo Zanoni
Em Ter, 2018-04-10 às 22:01 +0100, Chris Wilson escreveu: > Quoting Paulo Zanoni (2018-04-10 21:39:31) > > Em Ter, 2018-04-10 às 09:51 +0100, Chris Wilson escreveu: > > > Quoting Paulo Zanoni (2018-03-23 17:24:16) > > > > From: Manasi Navare > > > > > > > > This table

[Intel-gfx] ✗ Fi.CI.IGT: warning for drm/i915/edp: Only use alternate fixed mode when requested

2018-04-10 Thread Patchwork
== Series Details == Series: drm/i915/edp: Only use alternate fixed mode when requested URL : https://patchwork.freedesktop.org/series/41492/ State : warning == Summary == = CI Bug Log - changes from CI_DRM_4041_full -> Patchwork_8661_full = == Summary - WARNING == Minor unknown changes

Re: [Intel-gfx] [PATCH 4/7] drm/i915/icl: Add Voltage swing table for MG PHY DDI Buffer

2018-04-10 Thread Paulo Zanoni
Em Ter, 2018-04-10 às 22:07 +0100, Chris Wilson escreveu: > Quoting Chris Wilson (2018-04-10 22:01:33) > > Quoting Paulo Zanoni (2018-04-10 21:39:31) > > > Em Ter, 2018-04-10 às 09:51 +0100, Chris Wilson escreveu: > > > > Quoting Paulo Zanoni (2018-03-23 17:24:16) > > > > > From: Manasi Navare

Re: [Intel-gfx] [PATCH 1/1] drm/i915: move audio component intialization before audio driver use it

2018-04-10 Thread Shi, Yang A
>-Original Message- >From: Jani Nikula [mailto:jani.nik...@linux.intel.com] >Sent: Tuesday, April 10, 2018 3:57 PM >To: Shi, Yang A ; Chris Wilson >; >intel-gfx@lists.freedesktop.org >Cc: He, Bo >Subject: RE: [Intel-gfx]

Re: [Intel-gfx] [PATCH v2] drm/i915: set minimum CD clock to twice the BCLK.

2018-04-10 Thread Ville Syrjälä
On Tue, Apr 10, 2018 at 08:00:10PM -0700, Kumar, Abhay wrote: > > > On 4/10/2018 1:49 AM, Nikula, Jani wrote: > > On Tue, 10 Apr 2018, Jani Nikula wrote: > >> On Mon, 09 Apr 2018, "Kumar, Abhay" wrote: > >>> Dynamic cdclk is disabled in BIOS/GOP

Re: [Intel-gfx] [PATCH v2] drm/i915: set minimum CD clock to twice the BCLK.

2018-04-10 Thread Ville Syrjälä
On Mon, Apr 09, 2018 at 03:11:38PM -0700, Kumar, Abhay wrote: > > > On 4/9/2018 3:33 AM, Ville Syrjälä wrote: > > On Fri, Apr 06, 2018 at 04:47:08PM +0300, Jani Nikula wrote: > >> On Thu, 05 Apr 2018, Abhay Kumar wrote: > >>> In glk when device boots with 1366x768 panel,

Re: [Intel-gfx] [PATCH v1 00/14] Preparation patches for NV12

2018-04-10 Thread Maarten Lankhorst
Op 10-04-18 om 04:37 schreef Srinivas, Vidya: > >> -Original Message- >> From: Maarten Lankhorst [mailto:maarten.lankho...@linux.intel.com] >> Sent: Monday, April 9, 2018 5:15 PM >> To: Srinivas, Vidya ; intel- >> g...@lists.freedesktop.org >> Cc: Kamath, Sunil

Re: [Intel-gfx] [PATCH 1/1] drm/i915: move audio component intialization before audio driver use it

2018-04-10 Thread Shi, Yang A
>-Original Message- >From: Jani Nikula [mailto:jani.nik...@linux.intel.com] >Sent: Thursday, March 29, 2018 9:16 PM >To: Chris Wilson ; Shi, Yang A >; >intel-gfx@lists.freedesktop.org >Cc: Shi, Yang A ; He, Bo

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: move audio component initialization before audio driver use it

2018-04-10 Thread Patchwork
== Series Details == Series: drm/i915: move audio component initialization before audio driver use it URL : https://patchwork.freedesktop.org/series/41428/ State : failure == Summary == Series 41428v1 drm/i915: move audio component initialization before audio driver use it

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] tools/aubdump: Fix ISO C90 forbids mixed declarations and code warning

2018-04-10 Thread Tvrtko Ursulin
On 09/04/2018 18:03, Scott D Phillips wrote: Tvrtko Ursulin writes: From: Tvrtko Ursulin Back to a clean build with no warnings, at least for me. Why c90? If that's the language we mean to target then we should probably add it to the build

Re: [Intel-gfx] [PATCH 1/1] drm/i915: move audio component intialization before audio driver use it

2018-04-10 Thread Jani Nikula
On Tue, 10 Apr 2018, "Shi, Yang A" wrote: > issue: snd_soc_skl meet "failed to add i915 component master (-19)" > when platform don't connect any display output. > > i915 do initialization before than skl_probe, but if there is no > display output connect, in function

Re: [Intel-gfx] [PATCH v2] drm/i915: set minimum CD clock to twice the BCLK.

2018-04-10 Thread Jani Nikula
On Mon, 09 Apr 2018, "Kumar, Abhay" wrote: > Dynamic cdclk is disabled in BIOS/GOP hence gop makes it to highest > clock i.e 316.8. Will attach logs with drm debug enabled in bug. > I am also inclined towards 192 which will make max cdclk.. Please also attach

[Intel-gfx] [PATCH] [v2]drm/i915: move audio component initialization before audio driver use it

2018-04-10 Thread Yang
From: Yang Shi issue: snd_soc_skl meet "failed to add i915 component master (-19)" when platform don't connect any display output. i915 do initialization before than skl_probe, but if there is no display output connect, in function drm_dp_dpcd_access, there is a 32 retry

Re: [Intel-gfx] [PATCH 1/1] drm/i915: move audio component intialization before audio driver use it

2018-04-10 Thread Shi, Yang A
> -Original Message- > From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] > Sent: Thursday, March 29, 2018 7:56 PM > To: Shi, Yang A ; intel-gfx@lists.freedesktop.org > Cc: Shi, Yang A ; He, Bo > Subject: Re: [Intel-gfx]

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: move audio component initialization before audio driver use it

2018-04-10 Thread Patchwork
== Series Details == Series: drm/i915: move audio component initialization before audio driver use it URL : https://patchwork.freedesktop.org/series/41428/ State : warning == Summary == $ dim checkpatch origin/drm-tip 7a227be93975 drm/i915: move audio component initialization before audio

  1   2   >