Re: [Intel-gfx] [PATCH v5 05/40] drm/i915: wrapping all hdcp var into intel_hdcp

2018-07-09 Thread Sean Paul
On Wed, Jun 27, 2018 at 02:09:54PM +0530, Ramalingam C wrote: > Considering significant number of HDCP specific variables, it will > be clean to have separate struct for HDCP. > > New structure called intel_hdcp is added within intel_connector. > > v2: > struct hdcp statically allocated. [Sean

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Filter out both physical address swizzles

2018-07-09 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Filter out both physical address swizzles URL : https://patchwork.freedesktop.org/series/46214/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4456 -> Patchwork_9597 = == Summary - SUCCESS == No regressions found.

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Remove function details from device error messages

2018-07-09 Thread Patchwork
== Series Details == Series: drm/i915: Remove function details from device error messages URL : https://patchwork.freedesktop.org/series/46187/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4454_full -> Patchwork_9594_full = == Summary - FAILURE == Serious unknown

Re: [Intel-gfx] [PATCH v2] drm/i915: Use crtc_state->has_psr instead of CAN_PSR for pipe update

2018-07-09 Thread Dhinakaran Pandiyan
On Mon, 2018-07-09 at 12:24 -0700, Rodrigo Vivi wrote: > On Mon, Jul 09, 2018 at 11:30:00AM -0700, Dhinakaran Pandiyan wrote: > > > > On Sun, 2018-07-08 at 18:46 -0700, Tarun Vyas wrote: > > > > > > In commit "drm/i915: Wait for PSR exit before checking for vblank > > > evasion", the idea was to

Re: [Intel-gfx] [PATCH v2] drm/i915: Use crtc_state->has_psr instead of CAN_PSR for pipe update

2018-07-09 Thread Dhinakaran Pandiyan
On Mon, 2018-07-09 at 12:52 -0700, Tarun Vyas wrote: > On Mon, Jul 09, 2018 at 11:58:52AM -0700, Dhinakaran Pandiyan wrote: > > > > On Mon, 2018-07-09 at 11:16 -0700, Tarun Vyas wrote: > > > > > > On Mon, Jul 09, 2018 at 11:30:00AM -0700, Dhinakaran Pandiyan > > > wrote: > > > > > > > > > > >

Re: [Intel-gfx] [PATCH v5 10/40] drm/i915: Pullout the bksv read and validation

2018-07-09 Thread Sean Paul
On Wed, Jun 27, 2018 at 02:09:59PM +0530, Ramalingam C wrote: > For reusability purpose, this patch implements the hdcp1.4 bksv's > read and validation as a functions. > > For detecting the HDMI panel's HDCP capability this fucntions will be > used. > > v2: > Rebased. > v3: > No Changes. >

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [01/11] drm/i915/selftests: Prevent background reaping of active objects

2018-07-09 Thread Patchwork
== Series Details == Series: series starting with [01/11] drm/i915/selftests: Prevent background reaping of active objects URL : https://patchwork.freedesktop.org/series/46176/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4454_full -> Patchwork_9591_full = == Summary -

Re: [Intel-gfx] [PATCH v5 02/40] drm: HDMI and DP specific HDCP2.2 defines

2018-07-09 Thread Sean Paul
On Wed, Jun 27, 2018 at 02:09:51PM +0530, Ramalingam C wrote: > This patch adds HDCP register definitions for HDMI and DP HDCP > adaptations. > > HDMI specific HDCP2.2 register definitions are added into drm_hdcp.h, > where as HDCP2.2 register offsets in DPCD offsets are defined at >

Re: [Intel-gfx] [PATCH v5 09/40] drm/i915: Schedule hdcp_check_link in _intel_hdcp_enable

2018-07-09 Thread Sean Paul
On Wed, Jun 27, 2018 at 02:09:58PM +0530, Ramalingam C wrote: > As a preparation for making the intel_hdcp_enable as common function > for both HDCP1.4 and HDCP2.2, HDCP1.4 check_link scheduling is moved > into _intel_hdcp_enable() function. > > v3: > No Changes. > v4: > Style fix. > v5: >

Re: [Intel-gfx] [PATCH v5 11/40] drm/i915: Enable superior HDCP ver that is capable

2018-07-09 Thread Sean Paul
On Wed, Jun 27, 2018 at 02:10:00PM +0530, Ramalingam C wrote: > Considering that HDCP2.2 is more secure than HDCP1.4, When a setup > supports HDCP2.2 and HDCP1.4, HDCP2.2 will be enabled. > > v2: > Included few optimization suggestions [Chris Wilson] > Commit message is updated as per the

Re: [Intel-gfx] [PATCH v5 12/40] drm/i915: Enable HDCP1.4 incase of HDCP2.2 failure

2018-07-09 Thread Sean Paul
On Wed, Jun 27, 2018 at 02:10:01PM +0530, Ramalingam C wrote: > When HDCP2.2 enabling fails and HDCP1.4 is supported, HDCP1.4 is > enabled. > Just squash this into patch 11, no need for a separate patch. > v2: > Rebased. > v3: > No Changes. > v4: > Reviewed-by is collected. > v5: > No

Re: [Intel-gfx] [PATCH v5 13/40] drm/i915: Implement HDCP2.2 Enable and Disable

2018-07-09 Thread Sean Paul
On Wed, Jun 27, 2018 at 02:10:02PM +0530, Ramalingam C wrote: > Implements a sequence of enabling and disabling the HDCP2.2 > (auth and encryption). This is really hard to review, since all I see are stubs. I'd much rather have each patch do something useful, instead of just call stubs. That

Re: [Intel-gfx] [PATCH v5 19/40] drm/i915: hdcp_check_link only on CP_IRQ

2018-07-09 Thread Sean Paul
On Wed, Jun 27, 2018 at 02:10:08PM +0530, Ramalingam C wrote: > HDCP check link is invoked only on CP_IRQ detection, instead of all > short pulses. > > v3: > No Changes. > v4: > Added sean in cc and collected the reviewed-by received. > v5: > No Change. > > Signed-off-by: Ramalingam C

Re: [Intel-gfx] [PATCH 2/2] drm/i915: use the ICL stolen memory

2018-07-09 Thread Rodrigo Vivi
On Fri, Jul 06, 2018 at 07:09:15PM -0700, Lucas De Marchi wrote: > On Fri, May 4, 2018 at 1:33 PM Paulo Zanoni wrote: > > > > Now that our stolen memory is already reserved by the x86 subsystem > > (since commit "x86/gpu: reserve ICL's graphics stolen memory"), make > > use of it. > > > > Cc:

Re: [Intel-gfx] [PATCH] drm/i915: Remove function details from device error messages

2018-07-09 Thread Chris Wilson
Quoting Rodrigo Vivi (2018-07-09 18:51:02) > On Mon, Jul 09, 2018 at 02:48:58PM +0100, Chris Wilson wrote: > > Error messages are intended to be addressed to the user; be clear, > > succinct, instructive and unambiguous. Adding the function name to > > that message does not add any information the

Re: [Intel-gfx] [PATCH v2] drm/i915: Use crtc_state->has_psr instead of CAN_PSR for pipe update

2018-07-09 Thread Tarun Vyas
On Mon, Jul 09, 2018 at 01:31:52PM -0700, Dhinakaran Pandiyan wrote: > On Mon, 2018-07-09 at 12:52 -0700, Tarun Vyas wrote: > > On Mon, Jul 09, 2018 at 11:58:52AM -0700, Dhinakaran Pandiyan wrote: > > > > > > On Mon, 2018-07-09 at 11:16 -0700, Tarun Vyas wrote: > > > > > > > > On Mon, Jul 09,

Re: [Intel-gfx] [PATCH v5 07/40] drm/i915: Define Intel HDCP2.2 registers

2018-07-09 Thread Sean Paul
On Wed, Jun 27, 2018 at 02:09:56PM +0530, Ramalingam C wrote: > Intel HDCP2.2 registers are defined with addr offsets and bit details. > > v2: > Replaced the arith calc with _PICK [Sean Paul] > v3: > No changes. > v4: > %s/HDCP2_CTR_DDI/HDCP2_CTL_DDI [Uma] > v5: > Added parentheses for

Re: [Intel-gfx] [PATCH v5 06/40] drm/i915: Define HDCP2.2 related variables

2018-07-09 Thread Sean Paul
On Wed, Jun 27, 2018 at 02:09:55PM +0530, Ramalingam C wrote: > For upcoming implementation of HDCP2.2 in I915, important variable > required for HDCP2.2 are defined. Please just introduce them when you use them. I can't provide useful review on this patch unless I can see how the variables are

Re: [Intel-gfx] [PATCH v5 20/40] drm/i915: Check HDCP 1.4 and 2.2 link on CP_IRQ

2018-07-09 Thread Sean Paul
On Wed, Jun 27, 2018 at 02:10:09PM +0530, Ramalingam C wrote: > On DP HDCP1.4 and 2.2, when CP_IRQ is received, start the link > integrity check for the HDCP version that is enabled. > > v2: > Rebased. Function name is changed. > v3: > No Changes. > v4: > No Changes. > v5: > No Changes. >

Re: [Intel-gfx] [PATCH 4/8] drm/i915: Nuke dev_priv->irq_port[]

2018-07-09 Thread Rodrigo Vivi
On Thu, Jul 05, 2018 at 07:43:53PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Instead of looping over ports and hpd_pins, let's loop over > the encoders when doing hotplug processing. And instead of > depending on dev_priv->irq_port[] to tell us whether the > encoder has the

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Use crtc_state->has_psr instead of CAN_PSR for pipe update (rev3)

2018-07-09 Thread Patchwork
== Series Details == Series: drm/i915: Use crtc_state->has_psr instead of CAN_PSR for pipe update (rev3) URL : https://patchwork.freedesktop.org/series/46104/ State : warning == Summary == $ dim checkpatch origin/drm-tip fc0aabf8423b drm/i915: Use crtc_state->has_psr instead of CAN_PSR for

Re: [Intel-gfx] [PATCH 10/12] pci: use for_each_if

2018-07-09 Thread Bjorn Helgaas
On Mon, Jul 09, 2018 at 10:36:48AM +0200, Daniel Vetter wrote: > Avoids the inverted condition compared to the open-coded version. > > Signed-off-by: Daniel Vetter > Cc: Bjorn Helgaas > Cc: linux-...@vger.kernel.org Acked-by: Bjorn Helgaas I assume you'll merge this with the rest of the

Re: [Intel-gfx] [PATCH 2/2] drm/i915: use the ICL stolen memory

2018-07-09 Thread Paulo Zanoni
Em Sex, 2018-07-06 às 19:09 -0700, Lucas De Marchi escreveu: > On Fri, May 4, 2018 at 1:33 PM Paulo Zanoni > wrote: > > > > Now that our stolen memory is already reserved by the x86 subsystem > > (since commit "x86/gpu: reserve ICL's graphics stolen memory"), > > make > > use of it. > > > > Cc:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Use crtc_state->has_psr instead of CAN_PSR for pipe update (rev3)

2018-07-09 Thread Patchwork
== Series Details == Series: drm/i915: Use crtc_state->has_psr instead of CAN_PSR for pipe update (rev3) URL : https://patchwork.freedesktop.org/series/46104/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4456 -> Patchwork_9598 = == Summary - SUCCESS == No regressions

Re: [Intel-gfx] [PATCH v3] drm/i915: Use crtc_state->has_psr instead of CAN_PSR for pipe update

2018-07-09 Thread Dhinakaran Pandiyan
On Mon, 2018-07-09 at 14:28 -0700, Tarun Vyas wrote: > In commit "drm/i915: Wait for PSR exit before checking for vblank > evasion", the idea was to limit the PSR IDLE checks when PSR is > actually supported. While CAN_PSR does do that check, it doesn't > applies on a per-crtc basis.

Re: [Intel-gfx] [PATCH] kernel.h: Add for_each_if()

2018-07-09 Thread Andrew Morton
On Mon, 9 Jul 2018 18:25:09 +0200 Daniel Vetter wrote: > To avoid compilers complainig about ambigious else blocks when putting > an if condition into a for_each macro one needs to invert the > condition and add a dummy else. We have a nice little convenience > macro for that in drm headers,

Re: [Intel-gfx] [PATCH 5/8] drm/i915: s/int i/enum hpd_pin pin/

2018-07-09 Thread Rodrigo Vivi
On Thu, Jul 05, 2018 at 07:43:54PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Use the enum hpd_pin type when talking about HPD pins, and rename the > variable from a very nondescript 'i' to 'pin', a name we already > use in other parts of the code. > > Signed-off-by: Ville Syrjälä

[Intel-gfx] [PATCH v3] drm/i915: Use crtc_state->has_psr instead of CAN_PSR for pipe update

2018-07-09 Thread Tarun Vyas
In commit "drm/i915: Wait for PSR exit before checking for vblank evasion", the idea was to limit the PSR IDLE checks when PSR is actually supported. While CAN_PSR does do that check, it doesn't applies on a per-crtc basis. crtc_state->has_psr is a more granular check that only applies to pipe(s)

Re: [Intel-gfx] [PATCH] cpufreq: use for_each_if

2018-07-09 Thread Rafael J. Wysocki
On Mon, Jul 9, 2018 at 6:11 PM, Daniel Vetter wrote: > Avoids the inverted condition compared to the open coded version. > > Signed-off-by: Daniel Vetter > Cc: "Rafael J. Wysocki" > Cc: Viresh Kumar > Cc: linux...@vger.kernel.org > Cc: Eric Engestrom > -- > v2: Fix the logic fumble in the 2nd

Re: [Intel-gfx] [PATCH] drm/i915: Remove function details from device error messages

2018-07-09 Thread Rodrigo Vivi
On Mon, Jul 09, 2018 at 09:14:05PM +0100, Chris Wilson wrote: > Quoting Rodrigo Vivi (2018-07-09 18:51:02) > > On Mon, Jul 09, 2018 at 02:48:58PM +0100, Chris Wilson wrote: > > > Error messages are intended to be addressed to the user; be clear, > > > succinct, instructive and unambiguous. Adding

Re: [Intel-gfx] [PATCH v2] drm/i915: Use crtc_state->has_psr instead of CAN_PSR for pipe update

2018-07-09 Thread Rodrigo Vivi
On Mon, Jul 09, 2018 at 11:30:00AM -0700, Dhinakaran Pandiyan wrote: > On Sun, 2018-07-08 at 18:46 -0700, Tarun Vyas wrote: > > In commit "drm/i915: Wait for PSR exit before checking for vblank > > evasion", the idea was to limit the PSR IDLE checks when PSR is > > actually supported. While

Re: [Intel-gfx] [PATCH v2] drm/i915: Use crtc_state->has_psr instead of CAN_PSR for pipe update

2018-07-09 Thread Tarun Vyas
On Mon, Jul 09, 2018 at 11:58:52AM -0700, Dhinakaran Pandiyan wrote: > On Mon, 2018-07-09 at 11:16 -0700, Tarun Vyas wrote: > > On Mon, Jul 09, 2018 at 11:30:00AM -0700, Dhinakaran Pandiyan wrote: > > > > > > On Sun, 2018-07-08 at 18:46 -0700, Tarun Vyas wrote: > > > > > > > > In commit

Re: [Intel-gfx] [PATCH v5 01/40] drm: hdcp2.2 authentication msg definitions

2018-07-09 Thread Sean Paul
On Wed, Jun 27, 2018 at 02:09:50PM +0530, Ramalingam C wrote: > This patch defines the hdcp2.2 protocol messages for authentication. > > v2: > bit_fields are removed. Instead bitmasking used. [Tomas and Jani] > prefix HDCP_2_2_ is added to the macros. [Tomas] > v3: > No Changes. > v4: >

Re: [Intel-gfx] [PATCH] kernel.h: Add for_each_if()

2018-07-09 Thread Andy Shevchenko
On Mon, 2018-07-09 at 18:25 +0200, Daniel Vetter wrote: > v2: Explain a bit better what this is good for, after the discussion > with Peter Z. Since I have not been Cc'ed to your discussion there is another weirdness which this macro prohibits, i.e. for_each_blah() { } else { ...blahblah... }

Re: [Intel-gfx] [PATCH v2] drm/i915: Use crtc_state->has_psr instead of CAN_PSR for pipe update

2018-07-09 Thread Dhinakaran Pandiyan
On Mon, 2018-07-09 at 11:16 -0700, Tarun Vyas wrote: > On Mon, Jul 09, 2018 at 11:30:00AM -0700, Dhinakaran Pandiyan wrote: > > > > On Sun, 2018-07-08 at 18:46 -0700, Tarun Vyas wrote: > > > > > > In commit "drm/i915: Wait for PSR exit before checking for vblank > > > evasion", the idea was to

Re: [Intel-gfx] [PATCH v2] drm/i915: Use crtc_state->has_psr instead of CAN_PSR for pipe update

2018-07-09 Thread Rodrigo Vivi
On Mon, Jul 09, 2018 at 12:58:28PM -0700, Dhinakaran Pandiyan wrote: > On Mon, 2018-07-09 at 12:24 -0700, Rodrigo Vivi wrote: > > On Mon, Jul 09, 2018 at 11:30:00AM -0700, Dhinakaran Pandiyan wrote: > > > > > > On Sun, 2018-07-08 at 18:46 -0700, Tarun Vyas wrote: > > > > > > > > In commit

[Intel-gfx] [PATCH] drm/i915/selftests: Filter out both physical address swizzles

2018-07-09 Thread Chris Wilson
In our swizzling selftests, we cannot predict the physical address of the target page (at least not simply!) and so skip bit17 swizzles. However, there are two bit17 swizzle modes and we only skipped on, with the second being observed on the lab gdg causing the test to fail, as soon as we hit a

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Add Exec param to control data port coherency. (rev5)

2018-07-09 Thread Patchwork
== Series Details == Series: drm/i915: Add Exec param to control data port coherency. (rev5) URL : https://patchwork.freedesktop.org/series/40181/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4454_full -> Patchwork_9592_full = == Summary - FAILURE == Serious unknown

[Intel-gfx] ✓ Fi.CI.BAT: success for Kill resource streamer

2018-07-09 Thread Patchwork
== Series Details == Series: Kill resource streamer URL : https://patchwork.freedesktop.org/series/46224/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4458 -> Patchwork_9599 = == Summary - SUCCESS == No regressions found. External URL:

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: remove confusing GPIO vs PCH_GPIO

2018-07-09 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: remove confusing GPIO vs PCH_GPIO URL : https://patchwork.freedesktop.org/series/46200/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4455_full -> Patchwork_9595_full = == Summary - WARNING == Minor

[Intel-gfx] [PATCH 2/2] drm/i915: kill resource streamer

2018-07-09 Thread Lucas De Marchi
After disabling resource streamer on ICL (due to it actually not existing there), I got feedback that there have been some experimental patches for mesa to use it, but nothing ever landed nor shipped. This is a tentative to remove it from kernel keeping the uapi defines around for compatibility.

[Intel-gfx] [PATCH 1/2] drm/i915/icl: move has_resource_streamer to GEN11_FEATURES

2018-07-09 Thread Lucas De Marchi
Resource streamer has been removed on GEN11 so move it to the FEATURES macro. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 2 +- drivers/gpu/drm/i915/i915_pci.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git

[Intel-gfx] [PATCH 0/2] Kill resource streamer

2018-07-09 Thread Lucas De Marchi
First patch is makes sense for ICL since it doesn't have resource streamer. It has been a feature that was never properly tested/used so also kill it on second patch - this is a tentative/rfc: see commit message. Lucas De Marchi (2): drm/i915/icl: move has_resource_streamer to GEN11_FEATURES

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Kill resource streamer

2018-07-09 Thread Patchwork
== Series Details == Series: Kill resource streamer URL : https://patchwork.freedesktop.org/series/46224/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915/icl: move has_resource_streamer to GEN11_FEATURES Okay! Commit: drm/i915: kill resource streamer

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Use crtc_state->has_psr instead of CAN_PSR for pipe update (rev4)

2018-07-09 Thread Patchwork
== Series Details == Series: drm/i915: Use crtc_state->has_psr instead of CAN_PSR for pipe update (rev4) URL : https://patchwork.freedesktop.org/series/46104/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4458 -> Patchwork_9600 = == Summary - SUCCESS == No regressions

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with kernel.h: Add for_each_if() (rev3)

2018-07-09 Thread Patchwork
== Series Details == Series: series starting with kernel.h: Add for_each_if() (rev3) URL : https://patchwork.freedesktop.org/series/46158/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4455_full -> Patchwork_9596_full = == Summary - WARNING == Minor unknown changes

[Intel-gfx] [PATCH v4] drm/i915: Use crtc_state->has_psr instead of CAN_PSR for pipe update

2018-07-09 Thread Tarun Vyas
In commit "drm/i915: Wait for PSR exit before checking for vblank evasion", the idea was to limit the PSR IDLE checks when PSR is actually supported. While CAN_PSR does do that check, it doesn't applies on a per-crtc basis. crtc_state->has_psr is a more granular check that only applies to pipe(s)

Re: [Intel-gfx] [PATCH v4] drm/i915/gvt: declare gvt as i915's soft dependency

2018-07-09 Thread Zhenyu Wang
On 2018.07.09 18:24:10 +0800, intel-gvt-dev-boun...@lists.freedesktop.org wrote: > From: Hang Yuan > > This helps initramfs builder and other tools to know the full dependencies > of i915 and have gvt module loaded with i915. > > v2: add condition and change to pre-dependency (Chris) > v3:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Provide a timeout to i915_gem_wait_for_idle()

2018-07-09 Thread Patchwork
== Series Details == Series: drm/i915: Provide a timeout to i915_gem_wait_for_idle() URL : https://patchwork.freedesktop.org/series/46161/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4451 -> Patchwork_9587 = == Summary - SUCCESS == No regressions found. External

[Intel-gfx] [PATCH 2/3] drm/i915: Provide a timeout to i915_gem_wait_for_idle() on setup

2018-07-09 Thread Chris Wilson
With a broken GPU we expect it to fail during the initial GPU setup where do a couple of context switches to record the defaults. This is a task that takes a few milliseconds even on the slowest of devices, but we may have to wait 60s for hangcheck to give in and declare the machine inoperable. In

[Intel-gfx] [PATCH 1/3] drm/i915: Provide a timeout to i915_gem_wait_for_idle()

2018-07-09 Thread Chris Wilson
Usually we have no idea about the upper bound we need to wait to catch up with userspace when idling the device, but in a few situations we know the system was idle beforehand and can provide a short timeout in order to very quickly catch a failure, long before hangcheck kicks in. In the

[Intel-gfx] [PATCH 3/3] drm/i915/selftests: Replace wait-on-timeout with explicit timeout

2018-07-09 Thread Chris Wilson
In igt_flush_test() we install a background timer in order to ensure that the wait completes within a certain time. We can now tell the wait that it has to complete within a timeout, and so no longer need the background timer. Signed-off-by: Chris Wilson Cc: Joonas Lahtinen Cc: Mika Kuoppala

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [01/12] kernel.h: Add for_each_if()

2018-07-09 Thread Patchwork
== Series Details == Series: series starting with [01/12] kernel.h: Add for_each_if() URL : https://patchwork.freedesktop.org/series/46158/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4451 -> Patchwork_9586 = == Summary - FAILURE == Serious unknown changes coming with

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Magic numbers for old Y-tiling

2018-07-09 Thread Chris Wilson
Quoting Mika Kuoppala (2018-07-09 10:57:19) > Chris Wilson writes: > > > i915g has a slightly different tiling layout, and so requires a > > different reference swizzle pattern. > > > > Testcase: igt/drv_selftests/live_objects #gdg > > Signed-off-by: Chris Wilson > > Acked-by: Mika Kuoppala

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Provide a timeout to i915_gem_wait_for_idle()

2018-07-09 Thread Patchwork
== Series Details == Series: drm/i915: Provide a timeout to i915_gem_wait_for_idle() URL : https://patchwork.freedesktop.org/series/46161/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4451_full -> Patchwork_9587_full = == Summary - WARNING == Minor unknown changes

[Intel-gfx] [PATCH i-g-t] igt/gem_render_copy: Check for GEM before running

2018-07-09 Thread Chris Wilson
gem_render_copy requires a working GPU so check first. Signed-off-by: Chris Wilson --- tests/gem_render_copy.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/gem_render_copy.c b/tests/gem_render_copy.c index 8373cd738..238e70e97 100644 --- a/tests/gem_render_copy.c +++

Re: [Intel-gfx] [PATCH 11/12] sched: use for_each_if in topology.h

2018-07-09 Thread Peter Zijlstra
On Mon, Jul 09, 2018 at 10:36:49AM +0200, Daniel Vetter wrote: > Avoids complaints from gcc about ambiguous else clauses. Is that a new thing? I'm fairly sure I've never seen it do that, > Signed-off-by: Daniel Vetter > Cc: Andrew Morton > Cc: Peter Zijlstra > --- > include/linux/topology.h

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gvt: declare gvt as i915's soft dependency (rev2)

2018-07-09 Thread Patchwork
== Series Details == Series: drm/i915/gvt: declare gvt as i915's soft dependency (rev2) URL : https://patchwork.freedesktop.org/series/45875/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4453 -> Patchwork_9588 = == Summary - SUCCESS == No regressions found. External

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Magic numbers for old Y-tiling

2018-07-09 Thread Mika Kuoppala
Chris Wilson writes: > i915g has a slightly different tiling layout, and so requires a > different reference swizzle pattern. > > Testcase: igt/drv_selftests/live_objects #gdg > Signed-off-by: Chris Wilson Acked-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/selftests/i915_gem_object.c | 11

[Intel-gfx] [PATCH v4] drm/i915/gvt: declare gvt as i915's soft dependency

2018-07-09 Thread hang . yuan
From: Hang Yuan This helps initramfs builder and other tools to know the full dependencies of i915 and have gvt module loaded with i915. v2: add condition and change to pre-dependency (Chris) v3: move declaration to gvt.c. (Chris) v4: remove xengt (Zhenyu) Signed-off-by: Hang Yuan

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Provide a timeout to i915_gem_wait_for_idle()

2018-07-09 Thread Mika Kuoppala
Chris Wilson writes: > Usually we have no idea about the upper bound we need to wait to catch > up with userspace when idling the device, but in a few situations we > know the system was idle beforehand and can provide a short timeout in > order to very quickly catch a failure, long before

Re: [Intel-gfx] [PATCH 04/12] cpufreq: use for_each_if

2018-07-09 Thread Eric Engestrom
On Monday, 2018-07-09 10:36:42 +0200, Daniel Vetter wrote: > Avoids the inverted condition compared to the open coded version. > > Signed-off-by: Daniel Vetter > Cc: "Rafael J. Wysocki" > Cc: Viresh Kumar > Cc: linux...@vger.kernel.org > --- > include/linux/cpufreq.h | 8 ++-- > 1 file

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Prevent background reaping of active objects (rev2)

2018-07-09 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Prevent background reaping of active objects (rev2) URL : https://patchwork.freedesktop.org/series/46124/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4451_full -> Patchwork_9585_full = == Summary - WARNING == Minor

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Provide a timeout to i915_gem_wait_for_idle()

2018-07-09 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Provide a timeout to i915_gem_wait_for_idle() URL : https://patchwork.freedesktop.org/series/46170/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4453 -> Patchwork_9589 = == Summary - SUCCESS == No

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Provide a timeout to i915_gem_wait_for_idle()

2018-07-09 Thread Chris Wilson
Quoting Mika Kuoppala (2018-07-09 12:38:10) > Chris Wilson writes: > > -int i915_gem_wait_for_idle(struct drm_i915_private *i915, unsigned int > > flags) > > +int i915_gem_wait_for_idle(struct drm_i915_private *i915, > > +unsigned int flags, long timeout) > > { > >

[Intel-gfx] [PATCH] drm/i915/selftests: Prevent background reaping of active objects

2018-07-09 Thread Chris Wilson
igt_mmap_offset_exhaustion() wants to test what happens when the mmap space is filled with zombie objects, objects discarded by userspace but still active on the GPU. As they are only protected by the active reference, we have to be certain that active reference is kept while we peek into our

[Intel-gfx] [PATCH] drm/i915: Provide a timeout to i915_gem_wait_for_idle()

2018-07-09 Thread Chris Wilson
Usually we have no idea about the upper bound we need to wait to catch up with userspace when idling the device, but in a few situations we know the system was idle beforehand and can provide a short timeout in order to very quickly catch a failure, long before hangcheck kicks in. In particular,

[Intel-gfx] [PATCH 11/12] sched: use for_each_if in topology.h

2018-07-09 Thread Daniel Vetter
Avoids complaints from gcc about ambiguous else clauses. Signed-off-by: Daniel Vetter Cc: Andrew Morton Cc: Peter Zijlstra --- include/linux/topology.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/topology.h b/include/linux/topology.h index

[Intel-gfx] [PATCH 06/12] mm: use for_each_if

2018-07-09 Thread Daniel Vetter
Avoids the inverted condition of the open-coded version. Signed-off-by: Daniel Vetter Cc: Andrew Morton Cc: Michal Hocko Cc: Vlastimil Babka Cc: Mel Gorman Cc: David Rientjes Cc: Kemi Wang Cc: Pavel Tatashin Cc: Petr Tesarik Cc: YASUAKI ISHIMATSU Cc: Andrey Ryabinin Cc: Nikolay Borisov

[Intel-gfx] [PATCH 08/12] netdev: use for_each_if

2018-07-09 Thread Daniel Vetter
Avoids complaints from gcc about ambiguous else clauses. Signed-off-by: Daniel Vetter Cc: "David S. Miller" Cc: net...@vger.kernel.org --- include/linux/netdevice.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h index

[Intel-gfx] [PATCH 10/12] pci: use for_each_if

2018-07-09 Thread Daniel Vetter
Avoids the inverted condition compared to the open-coded version. Signed-off-by: Daniel Vetter Cc: Bjorn Helgaas Cc: linux-...@vger.kernel.org --- include/linux/pci.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/pci.h b/include/linux/pci.h index

[Intel-gfx] [PATCH 01/12] kernel.h: Add for_each_if()

2018-07-09 Thread Daniel Vetter
To avoid compilers complainig about ambigious else blocks when putting an if condition into a for_each macro one needs to invert the condition and add a dummy else. We have a nice little convenience macro for that in drm headers, let's move it out. Subsequent patches will roll it out to other

[Intel-gfx] [PATCH 05/12] dmar: Use for_each_If

2018-07-09 Thread Daniel Vetter
Avoids the inverted conditions compared to the open coded version. Signed-off-by: Daniel Vetter Cc: Joerg Roedel --- include/linux/dmar.h | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/include/linux/dmar.h b/include/linux/dmar.h index e2433bc50210..99397504e75e

[Intel-gfx] [PATCH 09/12] nubus: use for_each_if

2018-07-09 Thread Daniel Vetter
Avoids the inverted check compared to the open-coded version. Signed-off-by: Daniel Vetter Cc: Finn Thain Cc: linux-m...@lists.linux-m68k.org --- include/linux/nubus.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/nubus.h b/include/linux/nubus.h index

[Intel-gfx] [PATCH 12/12] usb: use for_each_if

2018-07-09 Thread Daniel Vetter
Avoids the inverted condition compared to the open-coded version. Signed-off-by: Daniel Vetter Cc: Greg Kroah-Hartman Cc: linux-...@vger.kernel.org --- include/linux/usb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/usb.h b/include/linux/usb.h index

[Intel-gfx] [PATCH 04/12] cpufreq: use for_each_if

2018-07-09 Thread Daniel Vetter
Avoids the inverted condition compared to the open coded version. Signed-off-by: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Viresh Kumar Cc: linux...@vger.kernel.org --- include/linux/cpufreq.h | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/include/linux/cpufreq.h

[Intel-gfx] [PATCH 07/12] ide: use for_each_if

2018-07-09 Thread Daniel Vetter
Avoids complaints from gcc about ambigious else clauses. Not that any of those are likely to show up in ide ... Signed-off-by: Daniel Vetter Cc: "David S. Miller" Cc: linux-...@vger.kernel.org --- include/linux/ide.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Prevent background reaping of active objects (rev2)

2018-07-09 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Prevent background reaping of active objects (rev2) URL : https://patchwork.freedesktop.org/series/46124/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4451 -> Patchwork_9585 = == Summary - SUCCESS == No regressions

[Intel-gfx] [PATCH 02/12] blk: use for_each_if

2018-07-09 Thread Daniel Vetter
Makes the macros resilient against if {} else {} blocks right afterwards. Signed-off-by: Daniel Vetter Cc: Tejun Heo Cc: Jens Axboe Cc: Shaohua Li Cc: Kate Stewart Cc: Greg Kroah-Hartman Cc: Joseph Qi Cc: Daniel Vetter Cc: Arnd Bergmann --- include/linux/blk-cgroup.h | 4 ++-- 1 file

[Intel-gfx] [PATCH 03/12] cgroup: use for_each_if

2018-07-09 Thread Daniel Vetter
Avoids the need to invert the condition instead of the open-coded version. Signed-off-by: Daniel Vetter Cc: Tejun Heo Cc: Li Zefan Cc: Johannes Weiner Cc: cgro...@vger.kernel.org --- include/linux/cgroup.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/12] kernel.h: Add for_each_if()

2018-07-09 Thread Patchwork
== Series Details == Series: series starting with [01/12] kernel.h: Add for_each_if() URL : https://patchwork.freedesktop.org/series/46158/ State : warning == Summary == $ dim checkpatch origin/drm-tip c4210eba974e kernel.h: Add for_each_if() -:6: WARNING:TYPO_SPELLING: 'ambigious' may be

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Prevent background reaping of active objects (rev2)

2018-07-09 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Prevent background reaping of active objects (rev2) URL : https://patchwork.freedesktop.org/series/46124/ State : warning == Summary == $ dim checkpatch origin/drm-tip de95eb144288 drm/i915/selftests: Prevent background reaping of active

[Intel-gfx] [PATCH] cpufreq: use for_each_if

2018-07-09 Thread Daniel Vetter
Avoids the inverted condition compared to the open coded version. Signed-off-by: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Viresh Kumar Cc: linux...@vger.kernel.org Cc: Eric Engestrom -- v2: Fix the logic fumble in the 2nd hunk, spotted by Eric. --- include/linux/cpufreq.h | 8 ++-- 1

[Intel-gfx] [PATCH 2/2] drm/i915: remove PCH_GMBUS defines

2018-07-09 Thread Lucas De Marchi
Now they are the same as GMBUS*, but without considering the different address bases. In order to use GMBUS* we just need access to dev_priv in a few places so this has been added. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/gvt/edid.c | 42 +

[Intel-gfx] [PATCH 1/2] drm/i915: remove confusing GPIO vs PCH_GPIO

2018-07-09 Thread Lucas De Marchi
Instead of defining all registers twice, define just a PCH_GPIO_BASE that has the same address as PCH_GPIO_A and use that to calculate all the others. This also brings VLV and !HAS_GMCH_DISPLAY in line, doing the same thing. This also rewrites the GMBUS[05] registers since they depend on

[Intel-gfx] [PATCH] kernel.h: Add for_each_if()

2018-07-09 Thread Daniel Vetter
To avoid compilers complainig about ambigious else blocks when putting an if condition into a for_each macro one needs to invert the condition and add a dummy else. We have a nice little convenience macro for that in drm headers, let's move it out. Subsequent patches will roll it out to other

Re: [Intel-gfx] [PATCH v4] drm/i915: Add IOCTL Param to control data port coherency.

2018-07-09 Thread Tvrtko Ursulin
On 09/07/2018 14:20, Tomasz Lis wrote: The patch adds a parameter to control the data port coherency functionality on a per-context level. When the IOCTL is called, a command to switch data port coherency state is added to the ordered list. All prior requests are executed on old coherency

Re: [Intel-gfx] [PATCH 11/12] sched: use for_each_if in topology.h

2018-07-09 Thread Peter Zijlstra
On Mon, Jul 09, 2018 at 05:52:04PM +0200, Daniel Vetter wrote: > for_each_something(foo) > if (foo->bla) > call_bla(foo); > else > call_default(foo); Note that the kernel coding style 'discourages' this style and would like you to write:

Re: [Intel-gfx] [PATCH 3/3] drm/i915/selftests: Replace wait-on-timeout with explicit timeout

2018-07-09 Thread Mika Kuoppala
Chris Wilson writes: > In igt_flush_test() we install a background timer in order to ensure > that the wait completes within a certain time. We can now tell the wait > that it has to complete within a timeout, and so no longer need the > background timer. > > Signed-off-by: Chris Wilson > Cc:

[Intel-gfx] [PATCH 07/11] drm/i915: Tidy i915_gem_suspend()

2018-07-09 Thread Chris Wilson
In the next patch, we will make a fairly minor change to flush outstanding resets before suspend. In order to keep churn to a minimum in that functional patch, we fix up the comments and coding style now. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem.c | 50

[Intel-gfx] [PATCH 11/11] drm/i915: Remove GPU reset dependence on struct_mutex

2018-07-09 Thread Chris Wilson
Now that the submission backends are controlled via their own spinlocks, with a wave of a magic wand we can lift the struct_mutex requirement around GPU reset. That is we allow the submission frontend (userspace) to keep on submitting while we process the GPU reset as we can suspend the backend

[Intel-gfx] [PATCH 03/11] drm/i915: Stop tracking MRU activity on VMA

2018-07-09 Thread Chris Wilson
Our goal is to remove struct_mutex and replace it with fine grained locking. One of the thorny issues is our eviction logic for reclaiming space for an execbuffer (or GTT mmaping, among a few other examples). While eviction itself is easy to move under a per-VM mutex, performing the activity

[Intel-gfx] [PATCH 08/11] drm/i915: Move fence-reg interface to i915_gem_fence_reg.h

2018-07-09 Thread Chris Wilson
Since we have a header file for i915_gem_fence_reg, let's use it for the interface prototypes currently hidden away in the huge i915_drv.h Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_drv.h | 15 --- drivers/gpu/drm/i915/i915_gem_fence_reg.h | 16

[Intel-gfx] [PATCH 02/11] drm/i915: Only reset hangcheck at the start of an activity cycle

2018-07-09 Thread Chris Wilson
Across a reset, the seqno (and thus hangcheck) should restart and the hangcheck naturally progress, for when it does not, we want to declare an emergency. Currently, we only detect if reset and reinit fails, but we do not detect if the call to reinit succeeds but the HW is fried - as we are

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gvt: declare gvt as i915's soft dependency (rev2)

2018-07-09 Thread Patchwork
== Series Details == Series: drm/i915/gvt: declare gvt as i915's soft dependency (rev2) URL : https://patchwork.freedesktop.org/series/45875/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4453_full -> Patchwork_9588_full = == Summary - WARNING == Minor unknown changes

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 03/11] trace.pl: Scale timeline for better precision

2018-07-09 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-07-09 14:19:56) > From: Tvrtko Ursulin > > vis library has a limited precision compared to our trace data which > prevents zooming into the timeline and seeing the fine detail. > > Scale the HTML view by a thousand to work around it. Shouldn't there be some clue in

[Intel-gfx] [RFC COMP I/F] drm/i915: Initialize HDCP2.2 and its MEI interface

2018-07-09 Thread Ramalingam C
Initialize HDCP2.2 support. This includes the mei interface initialization along with required component registration. v2: mei interface handle is protected with mutex. [Chris Wilson] v3: Notifiers are used for the mei interface state. v4: Poll for mei client device state Error msg for

Re: [Intel-gfx] [PATCH v4] drm/i915: Add IOCTL Param to control data port coherency.

2018-07-09 Thread Lionel Landwerlin
On 09/07/18 14:20, Tomasz Lis wrote: The patch adds a parameter to control the data port coherency functionality on a per-context level. When the IOCTL is called, a command to switch data port coherency state is added to the ordered list. All prior requests are executed on old coherency

Re: [Intel-gfx] [PATCH 01/12] kernel.h: Add for_each_if()

2018-07-09 Thread Andy Shevchenko
On Mon, 2018-07-09 at 10:36 +0200, Daniel Vetter wrote: > To avoid compilers complainig about ambigious else blocks when putting > an if condition into a for_each macro one needs to invert the > condition and add a dummy else. We have a nice little convenience > macro for that in drm headers,

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] igt/gem_render_copy: Check for GEM before running

2018-07-09 Thread Ville Syrjälä
On Mon, Jul 09, 2018 at 11:28:47AM +0100, Chris Wilson wrote: > gem_render_copy requires a working GPU so check first. > > Signed-off-by: Chris Wilson > --- > tests/gem_render_copy.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/gem_render_copy.c b/tests/gem_render_copy.c >

  1   2   >