Re: [Intel-gfx] [PATCH] drm/i915/psr: Add missing check for I915_PSR_DEBUG_IRQ bit

2018-08-12 Thread kbuild test robot
://github.com/0day-ci/linux/commits/Dhinakaran-Pandiyan/drm-i915-psr-Add-missing-check-for-I915_PSR_DEBUG_IRQ-bit/20180812-143531 base: git://anongit.freedesktop.org/drm-intel for-linux-next config: x86_64-randconfig-s1-08121632 (attached as .config) compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026

[Intel-gfx] [PATCH 02/14] drm/i915: Restrict gen6_reset_rps_interrupts to gen6+

2018-08-12 Thread Chris Wilson
Do not call gen6_reset_rps_interrupts() when we know the registers do not exist. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_pm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index

[Intel-gfx] [PATCH 03/14] drm/i915: Disable runtime-pm using lowlevel functions if !HAS_RC6

2018-08-12 Thread Chris Wilson
If we cannot setup rc6, we cannot let the GPU suspend itself as it cannot save its state (to a powercontext). As such, we must disable runtime-pm, but we should do so using the low-level pm-runtime function which leaves our own debugging functions intact (and continue to detect errors in our

[Intel-gfx] [PATCH 06/14] drm/i915: Attach the pci match data to the device upon creation

2018-08-12 Thread Chris Wilson
Attach our device_info to the our i915 private on creation so that it is always available for inspection. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_drv.c | 66 +++-- 1 file changed, 38 insertions(+), 28 deletions(-) diff --git

[Intel-gfx] [PATCH 13/14] drm/i915: Complain if hsw_get_pipe_config acquires the same power well twice

2018-08-12 Thread Chris Wilson
As we only release each power well once, we assume that each transcoder maps to a different domain. Complain if this is not so. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_display.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c

[Intel-gfx] [PATCH 04/14] drm/i915: Only skip connector output for disable_display

2018-08-12 Thread Chris Wilson
We want to add no connectors, encoders or crtcs if the display is disabled, but we still need to hook up any existing HW so that we can power it down. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_display.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[Intel-gfx] [PATCH 05/14] drm/i915: Explicitly take the init-power domain

2018-08-12 Thread Chris Wilson
Ensure that our power domain wakerefs are balanced across initialisation, so that we do not leak the powerwells on error or if the display is disabled. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_drv.c | 4 drivers/gpu/drm/i915/intel_display.c | 7 --- 2 files

[Intel-gfx] [PATCH 08/14] drm/i915: Track all held rpm wakerefs

2018-08-12 Thread Chris Wilson
Everytime we take a wakeref, record the stack trace of where it was taken; clearing the set if we ever drop back to no owners. For debugging a rpm leak, we can look at all the current wakerefs and check if they have a matching rpm_put. Signed-off-by: Chris Wilson ---

[Intel-gfx] [PATCH 14/14] drm/i915: Enable runtime-pm debugging by default for CI

2018-08-12 Thread Chris Wilson
Select the runtime-pm kconfig option if the general i915 debug option is selected so that anyone using CI/IGT should be co-opted into enabling the extra debug tracking. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/Kconfig.debug | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

[Intel-gfx] [PATCH 12/14] drm/i915/dp: Markup pps lock power well

2018-08-12 Thread Chris Wilson
Track where and when we acquire and release the power well for pps access along the dp aux link, with a view to detecting if we leak any wakerefs. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_dp.c | 226 +--- 1 file changed, 117 insertions(+), 109

[Intel-gfx] [PATCH 10/14] drm/i915: Syntatic sugar for using intel_runtime_pm

2018-08-12 Thread Chris Wilson
Frequently, we use intel_runtime_pm_get/_put around a small block. Formalise that usage by providing a macro to define such a block with an automatic closure to scope the intel_runtime_pm wakeref to that block, i.e. macro abuse smelling of python. Signed-off-by: Chris Wilson ---

[Intel-gfx] [PATCH 09/14] drm/i915: Markup paired operations on wakerefs

2018-08-12 Thread Chris Wilson
The majority of runtime-pm operations are bounded and scoped within a function; these are easy to verify that the wakeref are handled correctly. We can employ the compiler to help us, and reduce the number of wakerefs tracked when debugging, by passing around cookies provided by the various

[Intel-gfx] [PATCH 01/14] drm/i915: Cleanup gt powerstate from gem

2018-08-12 Thread Chris Wilson
Since the gt powerstate is allocated by i915_gem_init, clean it from i915_gem_fini for symmetry and to correct the imbalance on error. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem.c | 3 +++ drivers/gpu/drm/i915/intel_display.c | 4 2 files changed, 3 insertions(+), 4

[Intel-gfx] [PATCH 07/14] drm/i915: Introduce intel_runtime_pm_disable to pair intel_runtime_pm_enable

2018-08-12 Thread Chris Wilson
Currently, we cancel the extra wakeref we have for !runtime-pm devices inside power_wells_fini_hw. However, this is not strictly paired with the acquisition of that wakeref in runtime_pm_enable (as the fini_hw may be called on errors paths before we even call runtime_pm_enable). Make the symmetry

[Intel-gfx] [PATCH 11/14] drm/i915: Markup paired operations on display power domains

2018-08-12 Thread Chris Wilson
The majority of runtime-pm operations are bounded and scoped within a function; these are easy to verify that the wakeref are handled correctly. We can employ the compiler to help us, and reduce the number of wakerefs tracked when debugging, by passing around cookies provided by the various

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/14] drm/i915: Cleanup gt powerstate from gem

2018-08-12 Thread Patchwork
== Series Details == Series: series starting with [01/14] drm/i915: Cleanup gt powerstate from gem URL : https://patchwork.freedesktop.org/series/48093/ State : warning == Summary == $ dim checkpatch origin/drm-tip 9997a35e7674 drm/i915: Cleanup gt powerstate from gem acc6293cb5d5 drm/i915:

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [01/14] drm/i915: Cleanup gt powerstate from gem

2018-08-12 Thread Patchwork
== Series Details == Series: series starting with [01/14] drm/i915: Cleanup gt powerstate from gem URL : https://patchwork.freedesktop.org/series/48093/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915: Cleanup gt powerstate from gem Okay! Commit: drm/i915: Restrict

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [01/14] drm/i915: Cleanup gt powerstate from gem

2018-08-12 Thread Patchwork
== Series Details == Series: series starting with [01/14] drm/i915: Cleanup gt powerstate from gem URL : https://patchwork.freedesktop.org/series/48093/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4658 -> Patchwork_9925 = == Summary - SUCCESS == No regressions found.

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [01/14] drm/i915: Cleanup gt powerstate from gem

2018-08-12 Thread Patchwork
== Series Details == Series: series starting with [01/14] drm/i915: Cleanup gt powerstate from gem URL : https://patchwork.freedesktop.org/series/48093/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4658_full -> Patchwork_9925_full = == Summary - SUCCESS == No

Re: [Intel-gfx] [PATCH] drm/i915/psr: Add missing check for I915_PSR_DEBUG_IRQ bit

2018-08-12 Thread kbuild test robot
://github.com/0day-ci/linux/commits/Dhinakaran-Pandiyan/drm-i915-psr-Add-missing-check-for-I915_PSR_DEBUG_IRQ-bit/20180812-143531 base: git://anongit.freedesktop.org/drm-intel for-linux-next config: x86_64-randconfig-x018-201832 (attached as .config) compiler: gcc-7 (Debian 7.3.0-16) 7.3.0 reproduce