On 11/8/18 4:06 PM, Imre Deak wrote:
On Thu, Nov 08, 2018 at 03:34:39PM -0800, Lucas De Marchi wrote:
These are the only places that assume ports A and B are the ones with
combo phy. Let's use intel_port_is_combophy() there to make sure
it check for combo phy ports the same way everywhere.
On Tue, 13 Nov 2018 09:04:37 +0800
Chris Chiu wrote:
> Gentle ping. Just want to know if you have time for this so far.
> Thanks
>
> Chris
Actually I'm still working on it right now with
DRM_MODE_CONNECTOR_HDMIA/HDMIB, recommended by James, I'm able to
differentiate the HDMI or DP even the
== Series Details ==
Series: series starting with [v2,1/2] drm/i915/icl: replace check for combo phy
URL : https://patchwork.freedesktop.org/series/52400/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
6b83938535de drm/i915/icl: replace check for combo phy
-:22:
I think I'm probably the one who argued in favor of having separate
implementations for both PCHs, but the calculations are actually the
same, the clocks are the same and the only difference is that on ICP
we write the numerator to the register.
I have previously suggested to kill cnp_rawclk()
Although CNP names this field "Counter Fraction", what we write to the
register is really the denominator for the fractional part of the
divider, not the fractional part (and the field description even says
that). The ICP spec renamed the field to "Counter Fraction
Denominator", which makes a lot
BSpec was updated and now there's no more "subtract 1" to the
Microsecond Counter Divider field.
It seems this should help fixing some GMBUS issues. I'm not aware of
any specific open bug that could be solved by this patch.
Cc: Ville Syrjälä
Cc: Rodrigo Vivi
Reviewed-by: Ville Syrjälä
These are the only places that assume ports A and B are the ones with
combo phy. Let's use intel_port_is_combophy() there to make sure
it checks for combo phy ports the same way everywhere.
v2: define for_each_combo_port() helper to check the ports
Signed-off-by: Lucas De Marchi
---
v2 of
Bspec 21257 says "DDIA PHY is the comp master, so it must
not be un-initialized if other combo PHYs are in use". Here
we are shutting down all phys, so it's not strictly required.
However let's be consistent on deinitializing things in the
reversed order we initialized them.
Signed-off-by: Lucas
== Series Details ==
Series: series starting with [v2,1/2] drm/i915/icl: replace check for combo phy
URL : https://patchwork.freedesktop.org/series/52400/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5127 -> Patchwork_10810 =
== Summary - SUCCESS ==
No regressions
== Series Details ==
Series: series starting with [v2,1/2] drm/i915/icl: replace check for combo phy
URL : https://patchwork.freedesktop.org/series/52400/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5127_full -> Patchwork_10810_full =
== Summary - SUCCESS ==
No
Gentle ping. Just want to know if you have time for this so far. Thanks
Chris
On Tue, Oct 30, 2018 at 1:24 AM Guang Bai wrote:
> On Tue, 23 Oct 2018 17:14:34 +0800
> Chris Chiu wrote:
>
> > On Thu, Oct 11, 2018 at 2:04 AM Guang Bai wrote:
> >
> > > On Mon, 8 Oct 2018 08:56:20 -0700
> > >
== Series Details ==
Series: series starting with [CI,1/3] drm/i915/cnp+: update to the new
RAWCLK_FREQ recommendations
URL : https://patchwork.freedesktop.org/series/52397/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5127 -> Patchwork_10809 =
== Summary - SUCCESS ==
Op 09-11-18 om 21:20 schreef José Roberto de Souza:
> If panel supports DRRS and PSR and if driver is loaded without PSR
> enabled, driver will enable DRRS as expected but if PSR is enabled by
> debugfs latter it will keep PSR and DRRS enabled causing possible
> problems as DRRS will lower the
Am 10.11.18 um 15:56 schrieb Noralf Trønnes:
> This patchset adds a GEM object function table and makes use of it in
> the CMA helper.
>
> This was originally part of a shmem helper series[1] that didn't make
> it. Daniel and Christian showed interest in the vtable part so I have
> hooked it up to
sna/gen9+: Added AYUV format support for textured and sprite video adapters.
Split out wm_kernel from the sna_composite_op flags
Stanislav Lisovskiy (2):
sna/gen9+: Split out wm_kernel from the sna_composite_op flags
sna: Added AYUV format support for textured and sprite video adapters.
With the extra video kernels we already ran out of bits in
the flags. To tackle that let's just split out the
wm_kernel to its own thing.
Signed-off-by: Stanislav Lisovskiy
---
src/sna/gen9_render.c | 35 ++-
src/sna/sna_render.h | 1 +
2 files changed, 23
v2: Renamed DRM_FORMAT_XYUV to DRM_FORMAT_XYUV.
Added comment about AYUV byte ordering in Gstreamer.
v3: Removed sna_composite_op flags related change to the separate patch.
v4: Fixed review comments, done code refactoring
v5: Fixed following review comments:
- Fixed comment in
From: Ville Syrjälä
In my haste to remove irq_port[] I accidentally changed the
way we deal with hpd pins that are shared by multiple encoders
(DP and HDMI for pre-DDI platforms). Previously we would only
handle such pins via ->hpd_pulse(), but now we queue up the
hotplug work for the HDMI
The following patches with Fixes: do not cleanly apply
to drm-intel-fixes:
- 5a3aeca97af1 ("drm/i915: Fix hpd handling for pins with two encoders")
Please provide a backported patch ASAP, if they are relevant to be
backported. If they should not be included in drm-intel-fixes,
please confirm
== Series Details ==
Series: drm/i915: Fix hpd handling for pins with two encoders (rev2)
URL : https://patchwork.freedesktop.org/series/52256/
State : failure
== Summary ==
Applying: drm/i915: Fix hpd handling for pins with two encoders
Using index info to reconstruct a base tree...
M
subslice_mask is an array indexed by slice, not subslice.
Signed-off-by: Lionel Landwerlin
Fixes: 8cc7669355136f ("drm/i915: store all subslice masks")
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108712
---
drivers/gpu/drm/i915/intel_device_info.c | 2 +-
1 file changed, 1
== Series Details ==
Series: drm/i915: fix broadwell EU computation
URL : https://patchwork.freedesktop.org/series/52355/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5121 -> Patchwork_10802 =
== Summary - SUCCESS ==
No regressions found.
External URL:
We already have __drm_atomic_helper_connector_reset() and
__drm_atomic_helper_plane_reset(), extend this to crtc as well.
Most drivers already have a gpu reset hook, correct it.
Nouveau already implemented its own __drm_atomic_helper_crtc_reset(),
convert it to the common one.
Signed-off-by:
__drm_atomic_helper_crtc_destroy_state does not free memory, it only
cleans it up. Fix this by calling the functions own destroy function.
Fixes: 6d6e50039187 ("drm/vc4: Allocate the right amount of space for boot-time
CRTC state.")
Cc: Eric Anholt
Cc: # v4.6+
Signed-off-by: Maarten Lankhorst
We need to include the revert of commit 783195ec1cad ("drm/syncobj:
disable the timeline UAPI for now v2") along with undoing the change to
drm/i915.
Fixes: 131280a162e7 ("drm: Revert syncobj timeline changes.")
Signed-off-by: Chris Wilson
Cc: Christian König
Cc: Daniel Vetter
---
Quoting Lionel Landwerlin (2018-11-12 12:39:31)
> subslice_mask is an array indexed by slice, not subslice.
>
> Signed-off-by: Lionel Landwerlin
> Fixes: 8cc7669355136f ("drm/i915: store all subslice masks")
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108712
> ---
>
On Mon, Nov 12, 2018 at 04:01:14PM +0100, Maarten Lankhorst wrote:
> We already have __drm_atomic_helper_connector_reset() and
> __drm_atomic_helper_plane_reset(), extend this to crtc as well.
>
> Most drivers already have a gpu reset hook, correct it.
> Nouveau already implemented its own
On Mon, Nov 12, 2018 at 04:01:14PM +0100, Maarten Lankhorst wrote:
> We already have __drm_atomic_helper_connector_reset() and
> __drm_atomic_helper_plane_reset(), extend this to crtc as well.
>
> Most drivers already have a gpu reset hook, correct it.
> Nouveau already implemented its own
On Fri, Nov 09, 2018 at 04:23:50PM -0800, Paulo Zanoni wrote:
> I think I'm probably the one who argued in favor of having separate
> implementations for both PCHs, but the calculations are actually the
> same, the clocks are the same and the only difference is that on ICP
> we write the numerator
Thanks for a quick backport, applied this now.
Regards, Joonas
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Mon, 12 Nov 2018 16:01:14 +0100
Maarten Lankhorst wrote:
> We already have __drm_atomic_helper_connector_reset() and
> __drm_atomic_helper_plane_reset(), extend this to crtc as well.
>
> Most drivers already have a gpu reset hook, correct it.
> Nouveau already implemented its own
On 2018-11-12 10:01 AM, Maarten Lankhorst wrote:
> We already have __drm_atomic_helper_connector_reset() and
> __drm_atomic_helper_plane_reset(), extend this to crtc as well.
>
> Most drivers already have a gpu reset hook, correct it.
> Nouveau already implemented its own
== Series Details ==
Series: drm/syncobj: Fix compilation following partial revert
URL : https://patchwork.freedesktop.org/series/52369/
State : failure
== Summary ==
CALLscripts/checksyscalls.sh
DESCEND objtool
CHK include/generated/compile.h
CC [M]
On 2018-11-12 10:01 a.m., Maarten Lankhorst wrote:
> We already have __drm_atomic_helper_connector_reset() and
> __drm_atomic_helper_plane_reset(), extend this to crtc as well.
>
> Most drivers already have a gpu reset hook, correct it.
> Nouveau already implemented its own
On Mon, Nov 12, 2018 at 03:21:30PM +, Chris Wilson wrote:
> We need to include the revert of commit 783195ec1cad ("drm/syncobj:
> disable the timeline UAPI for now v2") along with undoing the change to
> drm/i915.
>
> Fixes: 131280a162e7 ("drm: Revert syncobj timeline changes.")
>
== Series Details ==
Series: series starting with [1/2] drm/vc4: Fix memory leak during gpu reset.
URL : https://patchwork.freedesktop.org/series/52362/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
e909a75380cb drm/vc4: Fix memory leak during gpu reset.
2ef96f23b0dd
== Series Details ==
Series: series starting with [1/2] drm/vc4: Fix memory leak during gpu reset.
URL : https://patchwork.freedesktop.org/series/52362/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/vc4: Fix memory leak during gpu reset.
Okay!
== Series Details ==
Series: drm/i915: fix broadwell EU computation
URL : https://patchwork.freedesktop.org/series/52355/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5121_full -> Patchwork_10802_full =
== Summary - WARNING ==
Minor unknown changes coming with
Am 12.11.18 um 16:21 schrieb Chris Wilson:
We need to include the revert of commit 783195ec1cad ("drm/syncobj:
disable the timeline UAPI for now v2") along with undoing the change to
drm/i915.
Fixes: 131280a162e7 ("drm: Revert syncobj timeline changes.")
Signed-off-by: Chris Wilson
Cc:
Am Montag, 12. November 2018, 16:01:14 CET schrieb Maarten Lankhorst:
> We already have __drm_atomic_helper_connector_reset() and
> __drm_atomic_helper_plane_reset(), extend this to crtc as well.
>
> Most drivers already have a gpu reset hook, correct it.
> Nouveau already implemented its own
== Series Details ==
Series: series starting with [1/2] drm/vc4: Fix memory leak during gpu reset.
URL : https://patchwork.freedesktop.org/series/52362/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5121 -> Patchwork_10804 =
== Summary - SUCCESS ==
No regressions found.
On 12/11/2018 12:39, Lionel Landwerlin wrote:
subslice_mask is an array indexed by slice, not subslice.
Signed-off-by: Lionel Landwerlin
Fixes: 8cc7669355136f ("drm/i915: store all subslice masks")
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=108712
---
On Mon, Nov 12, 2018 at 04:01:14PM +0100, Maarten Lankhorst wrote:
> We already have __drm_atomic_helper_connector_reset() and
> __drm_atomic_helper_plane_reset(), extend this to crtc as well.
>
> Most drivers already have a gpu reset hook, correct it.
> Nouveau already implemented its own
I think I'm probably the one who argued in favor of having separate
implementations for both PCHs, but the calculations are actually the
same, the clocks are the same and the only difference is that on ICP
we write the numerator to the register.
I have previously suggested to kill cnp_rawclk()
Quoting Tvrtko Ursulin (2018-11-12 17:12:39)
> From: Tvrtko Ursulin
>
> Now that we are down to one caller, which does not even modify copied
> device info, we can remove the mkwrite_device_info helper and convert the
> device info pointer itself to be a pointer to static table instead of a
>
== Series Details ==
Series: series starting with [1/2] drm/vc4: Fix memory leak during gpu reset.
URL : https://patchwork.freedesktop.org/series/52362/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5121_full -> Patchwork_10804_full =
== Summary - SUCCESS ==
No
On Mon, Nov 12, 2018 at 05:12:36PM +, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> It is only initialized to zero once so does not need an explicit
> initializer.
>
> Signed-off-by: Tvrtko Ursulin
> Cc: Chris Wilson
> Cc: Jani Nikula
> ---
> drivers/gpu/drm/i915/i915_pci.c | 1 -
>
Quoting Tvrtko Ursulin (2018-11-12 17:12:41)
> diff --git a/drivers/gpu/drm/i915/intel_device_info.c
> b/drivers/gpu/drm/i915/intel_device_info.c
> index 00758d11047b..b9d08428f35b 100644
> --- a/drivers/gpu/drm/i915/intel_device_info.c
> +++ b/drivers/gpu/drm/i915/intel_device_info.c
> @@ -118,6
== Series Details ==
Series: mkwrite_device_info removal
URL : https://patchwork.freedesktop.org/series/52381/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
5d13c3c4a414 drm/i915: Remove has_pooled_eu static initializer
fb31d94b767b drm/i915: Introduce runtime device info
Op 12-11-18 om 17:11 schreef Sean Paul:
> On Mon, Nov 12, 2018 at 04:01:14PM +0100, Maarten Lankhorst wrote:
>> We already have __drm_atomic_helper_connector_reset() and
>> __drm_atomic_helper_plane_reset(), extend this to crtc as well.
>>
>> Most drivers already have a gpu reset hook, correct it.
== Series Details ==
Series: mkwrite_device_info removal
URL : https://patchwork.freedesktop.org/series/52381/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/i915: Remove has_pooled_eu static initializer
Okay!
Commit: drm/i915: Introduce runtime
== Series Details ==
Series: mkwrite_device_info removal
URL : https://patchwork.freedesktop.org/series/52381/
State : failure
== Summary ==
= CI Bug Log - changes from CI_DRM_5126 -> Patchwork_10807 =
== Summary - FAILURE ==
Serious unknown changes coming with Patchwork_10807 absolutely
Em Seg, 2018-11-12 às 16:54 +0200, Ville Syrjälä escreveu:
> On Fri, Nov 09, 2018 at 04:23:50PM -0800, Paulo Zanoni wrote:
> > I think I'm probably the one who argued in favor of having separate
> > implementations for both PCHs, but the calculations are actually
> > the
> > same, the clocks are
From: Tvrtko Ursulin
Now that we are down to one caller, which does not even modify copied
device info, we can remove the mkwrite_device_info helper and convert the
device info pointer itself to be a pointer to static table instead of a
copy.
Only unfortnate thing is that we need to convert all
From: Tvrtko Ursulin
Idea of runtime device info is to contain all fields from the existing
device info which are modified at runtime.
Initially we move there fields which are never set from the static
tables ie.: num_rings, num_sprites, num_scalers,
cs_timestamp_frequency_khz, sseu and
From: Tvrtko Ursulin
After the previous change which cleared the static tables from effectively
unused storage, we now replicate entries which have defaults set from
there, but can be overriden at runtime.
For this class of variables all accessor macros and call sites are changed
to use the
From: Tvrtko Ursulin
Now that the device info data is truly const and all call sites have been
converted we can rely on read-only protection to notify us of any
mistakes.
Signed-off-by: Tvrtko Ursulin
Cc: Chris Wilson
Cc: Jani Nikula
---
Or it may be a good idea to leave the double
From: Tvrtko Ursulin
Introduce subplatform mask to eliminate throughout the code devid checking
sprinkle, mostly courtesy of IS_*_UL[TX] macros.
Subplatform mask initialization is done at runtime device info init.
v2: Fixed IS_SUBPLATFORM. Updated commit msg.
v3: Chris was right, there is an
On Mon, Nov 12, 2018 at 05:12:37PM +, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> Idea of runtime device info is to contain all fields from the existing
> device info which are modified at runtime.
>
> Initially we move there fields which are never set from the static
> tables ie.:
From: Ville Syrjälä
The oversample clock is always supposed to be either 108 MHz
or 148.5 MHz. Make it so.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_tv.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_tv.c
From: Ville Syrjälä
Fix the calculation of the vertical active period for interlaced
TV modes.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_tv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_tv.c b/drivers/gpu/drm/i915/intel_tv.c
From: Ville Syrjälä
On i965gm the hardware frame counter does not work when
the TV encoder is active. So let's not try to consult
the hardware frame counter in that case. Instead we'll
fall back to the timestamp based guesstimation method
used on gen2.
Note that the pipe timings generated by
From: Ville Syrjälä
No point in storing the mode names in the array. drm_mode_set_name()
will give us the same names without wasting space for these string
constants.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_tv.c | 21 +++--
1 file changed, 11 insertions(+),
From: Ville Syrjälä
The current code insists on picking a new TV mode when
switching between component and non-component cables.
That's super annoying. Let's just keep the current TV
mode unless the new cable type actually disagrees with it.
Signed-off-by: Ville Syrjälä
---
From: Ville Syrjälä
Remove the silly reported_modes[] array. I suppse once upon a time
this actually had something to do with modes we reported to userspace.
Now it is just the placeholder for the mode we use for load detection.
We don't need it even for that, and instead we can just rely on
the
From: Ville Syrjälä
'component_only' is a bool. Initialize it like a bool.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_tv.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_tv.c
From: Ville Syrjälä
On i965gm we need to adjust max_vblank_count dynamically
depending on whether the TV encoder is used or not. To
that end add a per-crtc max_vblank_count that takes
precedence over its device wide counterpart. The driver
can now call drm_crtc_set_max_vblank_count() to
From: Ville Syrjälä
Our TV encoder support isn't in the best shape. This series fixes
it up quite a bit.
The most important part is fixing the issues resulting from the
lack of frame counter on i965gm which causes nasty flip_done
timeouts when we attempt to do anything with the TV encoder
From: Ville Syrjälä
Store the oversampling factor as a number in the TV modes. We
shall want to arithmetic with this which is easier if it's
a number we can use directly.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_tv.c | 42 ++---
1 file changed,
From: Ville Syrjälä
Just assign the margin values directly to xpos/ypos instead
of first initializing to zero and then adding the values.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_tv.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
From: Ville Syrjälä
Just assign the margin values directly to xpos/ypos instead
of first initializing to zero and then adding the values.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_tv.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
From: Tvrtko Ursulin
It is more space efficient to store these two at the runtime copy since
both are trivially derived from the static data.
Signed-off-by: Tvrtko Ursulin
Cc: Chris Wilson
Cc: Jani Nikula
---
drivers/gpu/drm/i915/i915_drv.c | 15 +
On Fri, Nov 09, 2018 at 04:58:21PM +0200, Imre Deak wrote:
> We can just use a proper true/false initializer even for bitfields,
> which is more descriptive.
>
> Cc: Ramalingam C
> Cc: Daniel Vetter
> Cc: Ville Syrjälä
> Signed-off-by: Imre Deak
Reviewed-by: Ville Syrjälä
> ---
>
From: Tvrtko Ursulin
It is only initialized to zero once so does not need an explicit
initializer.
Signed-off-by: Tvrtko Ursulin
Cc: Chris Wilson
Cc: Jani Nikula
---
drivers/gpu/drm/i915/i915_pci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_pci.c
From: Tvrtko Ursulin
Some time ago we discussed the long term goal or removing the
mkwrite_device_info hack in favour of splitting device info to a truly read-only
and runtime halfves. This series attempts to do that.
Approach taken is to identify three classes of device info members:
1.
== Series Details ==
Series: drm/i915: Fix TV encoder support
URL : https://patchwork.freedesktop.org/series/52378/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5126 -> Patchwork_10806 =
== Summary - SUCCESS ==
No regressions found.
External URL:
== Series Details ==
Series: drm/i915: Fix TV encoder support
URL : https://patchwork.freedesktop.org/series/52378/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_5126_full -> Patchwork_10806_full =
== Summary - WARNING ==
Minor unknown changes coming with
On Mon, Nov 12, 2018 at 04:01:14PM +0100, Maarten Lankhorst wrote:
> We already have __drm_atomic_helper_connector_reset() and
> __drm_atomic_helper_plane_reset(), extend this to crtc as well.
>
> Most drivers already have a gpu reset hook, correct it.
> Nouveau already implemented its own
== Series Details ==
Series: drm/i915/cnp+: update to the new RAWCLK_FREQ recommendations
URL : https://patchwork.freedesktop.org/series/50893/
State : failure
== Summary ==
Applying: drm/i915/cnp+: update to the new RAWCLK_FREQ recommendations
Applying: drm/i915: add ICP support to
On Mon, Nov 12, 2018 at 05:12:38PM +, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin
>
> After the previous change which cleared the static tables from effectively
> unused storage, we now replicate entries which have defaults set from
> there, but can be overriden at runtime.
>
> For this
From: Ville Syrjälä
On gen3 we must disable the TV encoder vertical filter for >1024
pixel wide sources. Once that's done all we can is try to center
the image on the screen. Naturally the TV mode vertical resolution
must be equal or larger than the user mode vertical resolution
or else we'd
From: Ville Syrjälä
To make vblank timestamps work better with the TV encoder let's
scale the pipe timings such that the relationship between the
TV active and TV blanking periods is mirrored in the
corresponding pipe timings.
Note that in reality the pipe runs at a faster speed during the
TV
From: Ville Syrjälä
Rewrite the preferred mode selection to just check
whether the TV modes is HD or SD. For SD TV modes we
favor 480 line modes, for 720p we prefer 720 line modes,
and for 1080i/p we prefer 1080 line modes.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_tv.c | 50
From: Ville Syrjälä
Add the missing 1080p TV modes. On gen4 all of them work just fine,
whereas on gen3 only the 30Hz mode actually works correctly.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_tv.c | 90 +++--
1 file changed, 86 insertions(+), 4
From: Ville Syrjälä
Since gen3 can't handle >1024 wide sources with vertical scaling
let's not advertize such modes in the mode list. Less tempetation
to the user to try out things that won't work.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_tv.c | 6 ++
1 file changed, 6
== Series Details ==
Series: drm/i915: Fix TV encoder support
URL : https://patchwork.freedesktop.org/series/52378/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/vblank: Allow dynamic per-crtc max_vblank_count
Okay!
Commit: drm/i915: Don't try
On Fri, Nov 09, 2018 at 04:58:22PM +0200, Imre Deak wrote:
> Even though PW#1 and the MISC_IO power wells are managed by the
> DMC firmware (toggled dynamically if conditions allow it) from the
> driver's POV they are always on if the display core is initialized
> (always restored by DMC to the
On Fri, Nov 09, 2018 at 12:20:10PM -0800, José Roberto de Souza wrote:
> Some eDP panels do not set a valid sink count value and even for the
> ones that sets is should always be one for eDP, that is why it is not
> cached in intel_edp_init_dpcd().
>
> But intel_dp_short_pulse() compares the old
Quoting Tvrtko Ursulin (2018-11-12 17:12:38)
> struct intel_device_info {
> - u16 device_id;
> u16 gen_mask;
>
> - u8 gen;
> + u8 __gen;
> u8 gt; /* GT number, 0 if undefined */
> - intel_ring_mask_t ring_mask; /* Rings supported by the HW */
> - u8
On 12/11/2018 15:57, Tvrtko Ursulin wrote:
On 12/11/2018 12:39, Lionel Landwerlin wrote:
subslice_mask is an array indexed by slice, not subslice.
Signed-off-by: Lionel Landwerlin
Fixes: 8cc7669355136f ("drm/i915: store all subslice masks")
Bugzilla:
90 matches
Mail list logo
