From: "Yang, Dong"
The APL already fixed this bug since GT E, bug exist from
0 to D, apply WA according GT stepping.
Signed-off-by: Yang, Dong
---
drivers/gpu/drm/i915/i915_drv.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h
From: "Yang, Dong"
The APL already fixed this bug since GT E, bug exist from
0 to D, apply WA according GT stepping.
Signed-off-by: Yang, Dong
---
drivers/gpu/drm/i915/i915_drv.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h
Hi Dong,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[cannot apply to v5.3-rc4 next-20190809]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
== Series Details ==
Series: drm/i915: Remove i915 ggtt WA since GT E (rev2)
URL : https://patchwork.freedesktop.org/series/65066/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6678_full -> Patchwork_13978_full
Summary
== Series Details ==
Series: drm/i915: Remove i915 ggtt WA since GT E
URL : https://patchwork.freedesktop.org/series/65066/
State : failure
== Summary ==
CALLscripts/checksyscalls.sh
CALLscripts/atomic/check-atomics.sh
DESCEND objtool
CHK include/generated/compile.h
CC
== Series Details ==
Series: drm/i915: Remove i915 ggtt WA since GT E (rev2)
URL : https://patchwork.freedesktop.org/series/65066/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6678 -> Patchwork_13978
Summary
---
"DC3CO Off" power well inherits its power domains from
"DC Off" power well, these power domains will disallow
DC3CO when any external displays are connected and at
time of modeset and aux programming.
Renaming "DC Off" power well to "DC5 Off" power well.
v2: commit log improvement.
v3: Used
== Series Details ==
Series: DC3CO Support for TGL (rev3)
URL : https://patchwork.freedesktop.org/series/64923/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
2054d249c446 drm/i915/tgl: Add DC3CO required register and bits
4baba79d9dae drm/i915/tgl: Add DC3CO mask to
The DDI-IO power wells (PWR_WELL_CTL_DDI) are backing
the IO/PHY functionality, which doesn't need the PG3
power power well. Accordingly fixing up the list of
PG3 power domains.
v2: Removed "DDI E/F IO"power domain as well [Imre]
Cc: Imre Deak
Cc: Ville Syrjälä
Signed-off-by: Anshuman Gupta
Am 10.08.19 um 17:34 schrieb Chris Wilson:
> Allow for some users to surreptitiously insert lazy signal callbacks that
> do not depend on enabling the signaling mechanism around every fence.
> (The cost of interrupts is too darn high, to revive an old meme.)
> This means that we may have a cb_list
Hi Chris,
On Sat, Aug 10, 2019 at 10:03:28AM +0100, Chris Wilson wrote:
> Before we start upon our great GT interrupt refactor, throw out the
> cruft! In this case, it is an unloved debugfs showing the current ips
> status, a fairly meaningless bunch of numbers that we are not checking.
>
>
== Series Details ==
Series: series starting with [1/4] dma-fence: Propagate errors to
dma-fence-array container (rev3)
URL : https://patchwork.freedesktop.org/series/65027/
State : failure
== Summary ==
Applying: dma-fence: Propagate errors to dma-fence-array container
error: patch failed:
When one of the array of fences is signaled, propagate its errors to the
parent fence-array (keeping the first error to be raised).
v2: Opencode cmpxchg_local to avoid compiler freakout.
v3: Be careful not to flag an error if we race against signal-on-any
Signed-off-by: Chris Wilson
Cc: Sumit
== Series Details ==
Series: series starting with [v4] dma-fence: Propagate errors to
dma-fence-array container (rev5)
URL : https://patchwork.freedesktop.org/series/65027/
State : failure
== Summary ==
Applying: dma-fence: Propagate errors to dma-fence-array container
Applying: dma-fence:
== Series Details ==
Series: series starting with [1/2] drm/i915: Extract GT powermanagement
interrupt handling
URL : https://patchwork.freedesktop.org/series/65049/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
3b77c08c3532 drm/i915: Extract GT powermanagement interrupt
== Series Details ==
Series: series starting with [1/4] dma-fence: Propagate errors to
dma-fence-array container
URL : https://patchwork.freedesktop.org/series/65027/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6675_full -> Patchwork_13962_full
On 01/08/2019 17:16, Chris Wilson wrote:
Quoting Lionel Landwerlin (2019-08-01 15:29:34)
On 31/07/2019 23:03, Chris Wilson wrote:
Quoting Lionel Landwerlin (2019-07-31 15:07:33)
-static struct drm_syncobj **
-get_fence_array(struct drm_i915_gem_execbuffer2 *args,
- struct
Am 10.08.19 um 17:34 schrieb Chris Wilson:
> When one of the array of fences is signaled, propagate its errors to the
> parent fence-array (keeping the first error to be raised).
>
> v2: Opencode cmpxchg_local to avoid compiler freakout.
>
> Signed-off-by: Chris Wilson
> Cc: Sumit Semwal
> Cc:
== Series Details ==
Series: drm/i915/icl: Remove DDI IO power domain from PG3 power domains (rev2)
URL : https://patchwork.freedesktop.org/series/64465/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6677 -> Patchwork_13966
Quoting Christian König (2019-08-11 09:56:01)
> Be more consistent with the naming of the other DMA-buf objects.
From the tip of my fingers, \o/
> Signed-off-by: Christian König
Letting the compiler do the real work (for the bits I spot checked it
was the expected mechanical translation), and
The DDI-IO power wells (PWR_WELL_CTL_DDI) are backing
the IO/PHY functionality, which doesn't need the PG3
power power well. Accordingly fixing up the list of
PG3 power domains.
Cc: Imre Deak
Cc: Ville Syrjälä
Signed-off-by: Anshuman Gupta
---
== Series Details ==
Series: drm/i915/selftests: Prevent the timeslice expiring during suppression
tests
URL : https://patchwork.freedesktop.org/series/65032/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6675_full -> Patchwork_13964_full
From: Andi Shyti
i915_irq.c is large. It serves as the central dispatch and handler for
all of our device interrupts. Pull out the GT pm interrupt handling
(leaving the central dispatch) so that we can encapsulate the logic a
little better.
Based on a patch by Chris Wilson.
Signed-off-by: Andi
From: Andi Shyti
i915_irq.c is large. It serves as the central dispatch and handler for
all of our device interrupts. Lets break it up by pulling out the GT
interrupt handlers.
Based on a patch by Chris Wilson.
Signed-off-by: Andi Shyti
---
drivers/gpu/drm/i915/Makefile | 1 +
== Series Details ==
Series: DC3CO Support for TGL (rev3)
URL : https://patchwork.freedesktop.org/series/64923/
State : warning
== Summary ==
$ dim sparse origin/drm-tip
Sparse version: v0.5.2
Commit: drm/i915/tgl: Add DC3CO required register and bits
Okay!
Commit: drm/i915/tgl: Add DC3CO
== Series Details ==
Series: DC3CO Support for TGL (rev3)
URL : https://patchwork.freedesktop.org/series/64923/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6677 -> Patchwork_13965
Summary
---
**SUCCESS**
No
== Series Details ==
Series: series starting with [1/4] dma-fence: Propagate errors to
dma-fence-array container (rev2)
URL : https://patchwork.freedesktop.org/series/65027/
State : failure
== Summary ==
Applying: dma-fence: Propagate errors to dma-fence-array container
Applying: dma-fence:
Hi Chris,
On Sat, Aug 10, 2019 at 10:03:29AM +0100, Chris Wilson wrote:
> Check that the engine w/a persist after we performed a context switch
> and record those w/a into the default context state.
>
> Signed-off-by: Chris Wilson
> Cc: Andi Shyti
Acked-by: Andi Shyti
Thanks,
Andi
Quoting Andi Shyti (2019-08-11 10:57:44)
> Hi Chris,
>
> On Sat, Aug 10, 2019 at 10:03:29AM +0100, Chris Wilson wrote:
> > Check that the engine w/a persist after we performed a context switch
> > and record those w/a into the default context state.
> >
> > Signed-off-by: Chris Wilson
> > Cc:
Now that dma_fence_signal always takes the spinlock to flush the
cb_list, simply take the spinlock and call dma_fence_signal_locked() to
avoid code repetition.
Suggested-by: Christian König
Signed-off-by: Chris Wilson
Cc: Christian König
---
drivers/dma-buf/dma-fence.c | 32
== Series Details ==
Series: drm/i915/tgl: Fixing up list of PG3 power domains.
URL : https://patchwork.freedesktop.org/series/65041/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6677 -> Patchwork_13968
Summary
---
== Series Details ==
Series: drm/i915/blt: support copying objects
URL : https://patchwork.freedesktop.org/series/65031/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6675_full -> Patchwork_13963_full
Summary
---
Quoting Koenig, Christian (2019-08-11 09:58:31)
> Am 10.08.19 um 17:34 schrieb Chris Wilson:
> > + /*
> > + * Propagate the first error reported by any of our fences, but only
> > + * before we ourselves are signaled.
> > + */
> > + if (atomic_read(>num_pending) > 0)
> > +
When one of the array of fences is signaled, propagate its errors to the
parent fence-array (keeping the first error to be raised).
v2: Opencode cmpxchg_local to avoid compiler freakout.
v3: Be careful not to flag an error if we race against signal-on-any.
v4: Same applies to installing the
== Series Details ==
Series: series starting with [v3] dma-fence: Propagate errors to
dma-fence-array container (rev4)
URL : https://patchwork.freedesktop.org/series/65027/
State : failure
== Summary ==
Applying: dma-fence: Propagate errors to dma-fence-array container
Applying: dma-fence:
== Series Details ==
Series: drm/i915/icl: Remove DDI IO power domain from PG3 power domains (rev2)
URL : https://patchwork.freedesktop.org/series/64465/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6677_full -> Patchwork_13966_full
How about this instead:
Setting array->base.error = 1 during initialization.
Then cmpxchg(array->base.error, 1, error) whenever a fence in the array
signals.
And then finally cmpxchg(array->base.error, 1, 0) when the array itself
signals.
Christian.
Am 11.08.19 um 14:21 schrieb Chris
When one of the array of fences is signaled, propagate its errors to the
parent fence-array (keeping the first error to be raised).
v2: Opencode cmpxchg_local to avoid compiler freakout.
v3: Be careful not to flag an error if we race against signal-on-any.
v4: Same applies to installing the
== Series Details ==
Series: series starting with [1/2] drm/i915: Extract GT powermanagement
interrupt handling
URL : https://patchwork.freedesktop.org/series/65049/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6678 -> Patchwork_13972
Am 11.08.19 um 11:15 schrieb Chris Wilson:
> Now that dma_fence_signal always takes the spinlock to flush the
> cb_list, simply take the spinlock and call dma_fence_signal_locked() to
> avoid code repetition.
>
> Suggested-by: Christian König
> Signed-off-by: Chris Wilson
> Cc: Christian König
== Series Details ==
Series: DC3CO Support for TGL (rev3)
URL : https://patchwork.freedesktop.org/series/64923/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6677_full -> Patchwork_13965_full
Summary
---
**SUCCESS**
Am 11.08.19 um 18:25 schrieb Chris Wilson:
> When one of the array of fences is signaled, propagate its errors to the
> parent fence-array (keeping the first error to be raised).
>
> v2: Opencode cmpxchg_local to avoid compiler freakout.
> v3: Be careful not to flag an error if we race against
== Series Details ==
Series: series starting with [v5] dma-fence: Propagate errors to
dma-fence-array container (rev6)
URL : https://patchwork.freedesktop.org/series/65027/
State : failure
== Summary ==
Applying: dma-fence: Propagate errors to dma-fence-array container
Applying: dma-fence:
== Series Details ==
Series: drm/i915/tgl: Fixing up list of PG3 power domains.
URL : https://patchwork.freedesktop.org/series/65041/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6677_full -> Patchwork_13968_full
Summary
Since commit 6ca9a2beb54a ("drm/i915: Unwind i915_gem_init() failure")
we believed that we correctly handle all errors encountered during
GuC initialization, including special one that indicates request to
run driver with disabled GPU submission (-EIO).
Unfortunately since commit 121981fafe69
Our old messages were redundant or misleading (as loaded is
not the same as running). Keep only one message for debug.
Signed-off-by: Michal Wajdeczko
Cc: Daniele Ceraolo Spurio
Cc: Chris Wilson
---
drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c | 14 +++---
1 file changed, 3 insertions(+),
We don't want to rely on misleading WOPCM partitioning error.
Signed-off-by: Michal Wajdeczko
Cc: Daniele Ceraolo Spurio
Cc: Chris Wilson
---
drivers/gpu/drm/i915/gt/uc/intel_uc.c| 5 +
drivers/gpu/drm/i915/gt/uc/intel_uc_fw.h | 21 +
2 files changed, 26
Next portion of GuC/HuC improvements
Michal Wajdeczko (4):
drm/i915/uc: Fail early if there is no GuC fw available
drm/i915/uc: Include HuC firmware version in summary
drm/i915/uc: Update messages from fw upload step
drm/i915/uc: Use -EIO code for GuC initialization failures
After successful uC initialization we are reporting GuC
firmware version and status of GuC submission and HuC.
Add HuC fw version to this report to make it complete,
but also skip all HuC info if HuC is not supported.
Signed-off-by: Michal Wajdeczko
Cc: Daniele Ceraolo Spurio
Cc: Chris Wilson
== Series Details ==
Series: series starting with [1/2] drm/i915: Extract GT powermanagement
interrupt handling
URL : https://patchwork.freedesktop.org/series/65049/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6678_full -> Patchwork_13972_full
Quoting Michal Wajdeczko (2019-08-11 20:51:30)
> After successful uC initialization we are reporting GuC
> firmware version and status of GuC submission and HuC.
> Add HuC fw version to this report to make it complete,
> but also skip all HuC info if HuC is not supported.
>
> Signed-off-by:
From: Andi Shyti
i915_irq.c is large. It serves as the central dispatch and handler for
all of our device interrupts. Lets break it up by pulling out the GT
interrupt handlers.
Based on a patch by Chris Wilson.
Signed-off-by: Andi Shyti
---
Restore rps init; rps is not moved until the next
== Series Details ==
Series: series starting with [1/2] drm/i915: Extract GT powermanagement
interrupt handling (rev2)
URL : https://patchwork.freedesktop.org/series/65049/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6678 -> Patchwork_13975
Hi Chris,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[cannot apply to v5.3-rc3 next-20190809]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
Quoting Michal Wajdeczko (2019-08-11 20:51:29)
> We don't want to rely on misleading WOPCM partitioning error.
>
> Signed-off-by: Michal Wajdeczko
> Cc: Daniele Ceraolo Spurio
> Cc: Chris Wilson
> ---
> drivers/gpu/drm/i915/gt/uc/intel_uc.c| 5 +
>
Quoting Michal Wajdeczko (2019-08-11 20:51:31)
> Our old messages were redundant or misleading (as loaded is
> not the same as running). Keep only one message for debug.
>
> Signed-off-by: Michal Wajdeczko
> Cc: Daniele Ceraolo Spurio
> Cc: Chris Wilson
One is still one too many :)
Quoting Michal Wajdeczko (2019-08-11 20:51:32)
> Since commit 6ca9a2beb54a ("drm/i915: Unwind i915_gem_init() failure")
> we believed that we correctly handle all errors encountered during
> GuC initialization, including special one that indicates request to
> run driver with disabled GPU
== Series Details ==
Series: Use -EIO code for GuC initialization failures
URL : https://patchwork.freedesktop.org/series/65060/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_6678 -> Patchwork_13974
Summary
---
When one of the array of fences is signaled, propagate its errors to the
parent fence-array (keeping the first error to be raised).
v2: Opencode cmpxchg_local to avoid compiler freakout.
v3: Be careful not to flag an error if we race against signal-on-any.
v4: Same applies to installing the
== Series Details ==
Series: series starting with [1/2] drm/i915: Extract GT powermanagement
interrupt handling (rev2)
URL : https://patchwork.freedesktop.org/series/65049/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
f8612d8bb2ab drm/i915: Extract GT powermanagement
== Series Details ==
Series: dma-fence: Propagate errors to dma-fence-array container
URL : https://patchwork.freedesktop.org/series/65062/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6678 -> Patchwork_13976
Summary
== Series Details ==
Series: dma-fence: Propagate errors to dma-fence-array container
URL : https://patchwork.freedesktop.org/series/65062/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6678_full -> Patchwork_13976_full
62 matches
Mail list logo