[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/execlists: Lift process_csb() out of the irq-off spinlock

2019-08-16 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/execlists: Lift process_csb() out of the irq-off spinlock URL : https://patchwork.freedesktop.org/series/65294/ State : warning == Summary == $ dim checkpatch origin/drm-tip 03b058860a18 drm/i915/execlists: Lift process_csb()

Re: [Intel-gfx] [PATCH v3 2/5] drm/i915/wopcm: Check WOPCM layout separately from calculations

2019-08-16 Thread Michal Wajdeczko
On Fri, 16 Aug 2019 13:21:03 +0200, Chris Wilson wrote: Quoting Michal Wajdeczko (2019-08-16 11:54:58) +static inline bool __check_layout(struct drm_i915_private *i915, u32 wopcm_size, + u32 guc_wopcm_base, u32 guc_wopcm_size, +

Re: [Intel-gfx] [PULL] drm-misc-next

2019-08-16 Thread Chris Wilson
Quoting Maxime Ripard (2019-08-16 12:32:01) > Hi Daniel, Dave, > > Here's this week drm-misc-next PR. > > Maxime > > drm-misc-next-2019-08-16: > drm-misc-next for 5.4: > > UAPI Changes: > > Cross-subsystem Changes: > > Core Changes: > - dma-buf: add reservation_object_fences helper, relax

Re: [Intel-gfx] [PATCH] Revert "nvme-pci: use host managed power state for suspend"

2019-08-16 Thread Chris Wilson
Quoting Christoph Hellwig (2019-08-16 13:26:44) > Please, report the actual problem. Blindly reverting a patch without > even an explanation of your regressions is not the way to do it. As stated, the system doesn't suspend. If you would like to wait, you will get test results from our CI

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/buddy: tidy up i915_buddy_fini (rev2)

2019-08-16 Thread Patchwork
== Series Details == Series: drm/i915/buddy: tidy up i915_buddy_fini (rev2) URL : https://patchwork.freedesktop.org/series/65299/ State : failure == Summary == Applying: drm/i915/buddy: tidy up i915_buddy_fini error: corrupt patch at line 20 error: could not build fake ancestor hint: Use 'git

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Dynamically allocate s0ix struct for VLV

2019-08-16 Thread Jani Nikula
On Fri, 16 Aug 2019, Chris Wilson wrote: > Quoting Jani Nikula (2019-08-16 10:35:08) >> On Thu, 15 Aug 2019, Daniele Ceraolo Spurio >> wrote: >> > @@ -1622,7 +1560,7 @@ struct drm_i915_private { >> > u32 suspend_count; >> > bool power_domains_suspended; >> > struct

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Use the associated uncore for the vm

2019-08-16 Thread Patchwork
== Series Details == Series: drm/i915: Use the associated uncore for the vm URL : https://patchwork.freedesktop.org/series/65291/ State : success == Summary == CI Bug Log - changes from CI_DRM_6716 -> Patchwork_14047 Summary ---

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Markup expected timeline locks for i915_active

2019-08-16 Thread Chris Wilson
Quoting Mika Kuoppala (2019-08-16 13:02:21) > > diff --git a/drivers/gpu/drm/i915/i915_active_types.h > > b/drivers/gpu/drm/i915/i915_active_types.h > > index ae3ee441c114..d857bd12aa7e 100644 > > --- a/drivers/gpu/drm/i915/i915_active_types.h > > +++ b/drivers/gpu/drm/i915/i915_active_types.h >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Only emit the 'send bug report' once for a GPU hang

2019-08-16 Thread Patchwork
== Series Details == Series: drm/i915: Only emit the 'send bug report' once for a GPU hang URL : https://patchwork.freedesktop.org/series/65301/ State : success == Summary == CI Bug Log - changes from CI_DRM_6718 -> Patchwork_14052 Summary

[Intel-gfx] [PATCH v3 2/5] drm/i915/wopcm: Check WOPCM layout separately from calculations

2019-08-16 Thread Michal Wajdeczko
We can do WOPCM partitioning using rough estimates and limits and perform detailed check as separate step. v2: oops! s/max/min v3: consolidate overflow checks (Daniele) Signed-off-by: Michal Wajdeczko Cc: Daniele Ceraolo Spurio Cc: Chris Wilson --- drivers/gpu/drm/i915/intel_wopcm.c | 97

[Intel-gfx] [PATCH v3 4/5] drm/i915/wopcm: Update error messages

2019-08-16 Thread Michal Wajdeczko
All WOPCM error messages are device specific, so use device specific error functions. Signed-off-by: Michal Wajdeczko Cc: Chris Wilson --- drivers/gpu/drm/i915/intel_wopcm.c | 44 -- 1 file changed, 24 insertions(+), 20 deletions(-) diff --git

[Intel-gfx] [PATCH v3 0/5] More WOPCM fixes

2019-08-16 Thread Michal Wajdeczko
More WOPCM fixes v3: consolidate overflow checks (Daniele) Michal Wajdeczko (4): drm/i915/wopcm: Check WOPCM layout separately from calculations drm/i915/wopcm: Try to use already locked WOPCM layout drm/i915/wopcm: Update error messages drm/i915/wopmc: Fix SPDX tag location Michał

[Intel-gfx] [PATCH v3 3/5] drm/i915/wopcm: Try to use already locked WOPCM layout

2019-08-16 Thread Michal Wajdeczko
If WOPCM layout is already locked in HW we shouldn't continue with our own partitioning as it could be likely different and we will be unable to enforce it and fail. Instead we should try to reuse what is already programmed, maybe there will be a fit. This should enable us to reload driver with

[Intel-gfx] [PATCH v3 5/5] drm/i915/wopmc: Fix SPDX tag location

2019-08-16 Thread Michal Wajdeczko
Move SPDX tag to first line, and update year to 2019. Signed-off-by: Michal Wajdeczko Cc: Chris Wilson --- drivers/gpu/drm/i915/intel_wopcm.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_wopcm.c b/drivers/gpu/drm/i915/intel_wopcm.c index

[Intel-gfx] [PATCH v3 1/5] drm/i915/uc: Move FW size sanity check back to fetch

2019-08-16 Thread Michal Wajdeczko
From: Michał Winiarski While we need to know WOPCM size to do this sanity check, it has more to do with FW than with WOPCM. Let's move the check to fetch phase, it's not like WOPCM is going to grow in the meantime. v2: rebased v3: use __intel_uc_fw_get_upload_size (Daniele) Signed-off-by:

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/3] drm/i915/execlists: Lift process_csb() out of the irq-off spinlock

2019-08-16 Thread Chris Wilson
Quoting Patchwork (2019-08-16 12:26:55) > * igt@gem_sync@basic-store-each: > - fi-cfl-8109u: [PASS][1] -> [INCOMPLETE][2] >[1]: > https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6716/fi-cfl-8109u/igt@gem_s...@basic-store-each.html >[2]: >

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gt: Mark context->active_count as protected by timeline->mutex

2019-08-16 Thread Mika Kuoppala
Chris Wilson writes: > We use timeline->mutex to protect modifications to > context->active_count, and the associated enable/disable callbacks. > Due to complications with engine-pm barrier there is a path where we used > a "superlock" to provide serialised protect and so could not >

[Intel-gfx] [PATCH] Revert "nvme-pci: use host managed power state for suspend"

2019-08-16 Thread Chris Wilson
commit d916b1be94b6dc8d293abed2451f3062f6af7551 Author: Keith Busch Date: Thu May 23 09:27:35 2019 -0600 nvme-pci: use host managed power state for suspend Bisected as cause of suspend failure for gem_eio/suspend on multiple kbl hosts. Cc: Rafael J. Wysocki Cc: Keith Busch Cc: Sagi

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/buddy: tidy up i915_buddy_fini

2019-08-16 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/buddy: tidy up i915_buddy_fini URL : https://patchwork.freedesktop.org/series/65303/ State : success == Summary == CI Bug Log - changes from CI_DRM_6718 -> Patchwork_14053

[Intel-gfx] [PATCH 2/2] drm/i915/buddy: use kmemleak_update_trace

2019-08-16 Thread Matthew Auld
Since nodes are cached in a free-list, and potentially marked as free without actually being destroyed, thus allowing them to be opportunistically re-allocated, we should apply kmemleak_update_trace every time a node is given a new owner and marked as allocated, to aid in debugging. Suggested-by:

[Intel-gfx] [PATCH 1/2] drm/i915/buddy: tidy up i915_buddy_fini

2019-08-16 Thread Matthew Auld
If we are leaking nodes don't hide it. Also stop trying to be "defensive" and instead embrace Kasan et al. Signed-off-by: Matthew Auld Cc: Chris Wilson --- drivers/gpu/drm/i915/i915_buddy.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git

[Intel-gfx] ✓ Fi.CI.IGT: success for Revert "ALSA: hda: Add codec on bus address table lately"

2019-08-16 Thread Patchwork
== Series Details == Series: Revert "ALSA: hda: Add codec on bus address table lately" URL : https://patchwork.freedesktop.org/series/65271/ State : success == Summary == CI Bug Log - changes from CI_DRM_6712_full -> Patchwork_14036_full

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/4] drm/i915/gt: Track timeline activeness in enter/exit

2019-08-16 Thread Patchwork
== Series Details == Series: series starting with [CI,1/4] drm/i915/gt: Track timeline activeness in enter/exit URL : https://patchwork.freedesktop.org/series/65274/ State : success == Summary == CI Bug Log - changes from CI_DRM_6713_full -> Patchwork_14037_full

Re: [Intel-gfx] [PATCH] drm/i915/tgl: disable DDIC

2019-08-16 Thread Lucas De Marchi
On Fri, Aug 16, 2019 at 3:14 AM Shankar, Uma wrote: > > > > >-Original Message- > >From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf > >Of Lucas > >De Marchi > >Sent: Thursday, August 15, 2019 5:25 AM > >To: intel-gfx@lists.freedesktop.org > >Subject: [Intel-gfx]

Re: [Intel-gfx] [PATCH 1/3] drm/i915/execlists: Lift process_csb() out of the irq-off spinlock

2019-08-16 Thread Mika Kuoppala
Chris Wilson writes: > If we only call process_csb() from the tasklet, though we lose the > ability to bypass ksoftirqd interrupt processing on direct submission > paths, we can push it out of the irq-off spinlock. > > The penalty is that we then allow schedule_out to be called concurrently >

[Intel-gfx] [PATCH] drm/i915/execlists: Lift process_csb() out of the irq-off spinlock

2019-08-16 Thread Chris Wilson
If we only call process_csb() from the tasklet, though we lose the ability to bypass ksoftirqd interrupt processing on direct submission paths, we can push it out of the irq-off spinlock. The penalty is that we then allow schedule_out to be called concurrently with schedule_in requiring us to

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Markup expected timeline locks for i915_active

2019-08-16 Thread Mika Kuoppala
Chris Wilson writes: > As every i915_active_request should be serialised by a dedicated lock, > i915_active consists of a tree of locks; one for each node. Markup up > the i915_active_request with what lock is supposed to be guarding it so > that we can verify that the serialised updated are

Re: [Intel-gfx] linux-next: build warning after merge of the drm-misc tree

2019-08-16 Thread Laurent Pinchart
On Fri, Aug 16, 2019 at 12:47:15PM +0300, Laurent Pinchart wrote: > On Fri, Aug 16, 2019 at 08:23:54AM +0200, Daniel Vetter wrote: > > On Fri, Aug 16, 2019 at 6:48 AM Sam Ravnborg wrote: > > > > Hi all, > > > > > > > > After merging the drm-misc tree, today's linux-next build (x86_64 > > > >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gtt: Fold gen8 insertions into one (rev2)

2019-08-16 Thread Patchwork
== Series Details == Series: drm/i915/gtt: Fold gen8 insertions into one (rev2) URL : https://patchwork.freedesktop.org/series/65258/ State : success == Summary == CI Bug Log - changes from CI_DRM_6718 -> Patchwork_14049 Summary ---

Re: [Intel-gfx] [PATCH] Revert "nvme-pci: use host managed power state for suspend"

2019-08-16 Thread Christoph Hellwig
On Fri, Aug 16, 2019 at 01:30:29PM +0100, Chris Wilson wrote: > Quoting Christoph Hellwig (2019-08-16 13:26:44) > > Please, report the actual problem. Blindly reverting a patch without > > even an explanation of your regressions is not the way to do it. > > As stated, the system doesn't suspend.

Re: [Intel-gfx] [PATCH 1/2] drm/i915/buddy: tidy up i915_buddy_fini

2019-08-16 Thread Chris Wilson
Quoting Matthew Auld (2019-08-16 11:53:56) > If we are leaking nodes don't hide it. Also stop trying to be > "defensive" and instead embrace Kasan et al. > > Signed-off-by: Matthew Auld > Cc: Chris Wilson > --- > drivers/gpu/drm/i915/i915_buddy.c | 7 +-- > 1 file changed, 1 insertion(+),

Re: [Intel-gfx] [PATCH 2/2] drm/i915/buddy: use kmemleak_update_trace

2019-08-16 Thread Chris Wilson
Quoting Matthew Auld (2019-08-16 11:53:57) > Since nodes are cached in a free-list, and potentially marked as free > without actually being destroyed, thus allowing them to be > opportunistically re-allocated, we should apply kmemleak_update_trace > every time a node is given a new owner and

[Intel-gfx] [PULL] drm-misc-next

2019-08-16 Thread Maxime Ripard
Hi Daniel, Dave, Here's this week drm-misc-next PR. Maxime drm-misc-next-2019-08-16: drm-misc-next for 5.4: UAPI Changes: Cross-subsystem Changes: Core Changes: - dma-buf: add reservation_object_fences helper, relax reservation_object_add_shared_fence, remove

Re: [Intel-gfx] Linux Kernel 5.2.8 (uvc or i915?)

2019-08-16 Thread Jani Nikula
On Thu, 15 Aug 2019, Randy Dunlap wrote: > On 8/15/19 6:15 PM, Nathaniel Russell wrote: >> I would really like help with the kernel error with my uvcvideo driver. >> > > Hi again. > > What makes you think that the problem is related to the uvcvideo driver? > Does some previous kernel version

Re: [Intel-gfx] [PATCH] Revert "nvme-pci: use host managed power state for suspend"

2019-08-16 Thread Chris Wilson
Quoting Keith Busch (2019-08-16 13:46:41) > On Fri, Aug 16, 2019 at 6:38 AM Christoph Hellwig wrote: > > On Fri, Aug 16, 2019 at 01:30:29PM +0100, Chris Wilson wrote: > > > Quoting Christoph Hellwig (2019-08-16 13:26:44) > > > > Please, report the actual problem. Blindly reverting a patch

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/dp/dsc: Add Support for all BPCs supported by TGL (rev4)

2019-08-16 Thread Patchwork
== Series Details == Series: drm/dp/dsc: Add Support for all BPCs supported by TGL (rev4) URL : https://patchwork.freedesktop.org/series/63526/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6713_full -> Patchwork_14038_full

Re: [Intel-gfx] [PATCH v3 5/5] drm/i915/wopmc: Fix SPDX tag location

2019-08-16 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-08-16 11:55:01) > Move SPDX tag to first line, and update year to 2019. > > Signed-off-by: Michal Wajdeczko > Cc: Chris Wilson Reviewed-by: Chris Wilson Head, bury thyself in the sand. -Chris ___ Intel-gfx mailing list

Re: [Intel-gfx] [PATCH v3 4/5] drm/i915/wopcm: Update error messages

2019-08-16 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-08-16 11:55:00) > All WOPCM error messages are device specific, so use > device specific error functions. > > Signed-off-by: Michal Wajdeczko > Cc: Chris Wilson Reviewed-by: Chris Wilson -Chris ___ Intel-gfx mailing

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/3] drm/i915/execlists: Lift process_csb() out of the irq-off spinlock

2019-08-16 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/execlists: Lift process_csb() out of the irq-off spinlock URL : https://patchwork.freedesktop.org/series/65294/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6716 -> Patchwork_14048

[Intel-gfx] [CI 2/2] drm/i915: Markup expected timeline locks for i915_active

2019-08-16 Thread Chris Wilson
As every i915_active_request should be serialised by a dedicated lock, i915_active consists of a tree of locks; one for each node. Markup up the i915_active_request with what lock is supposed to be guarding it so that we can verify that the serialised updated are indeed serialised. Signed-off-by:

[Intel-gfx] [CI 1/2] drm/i915/gt: Mark context->active_count as protected by timeline->mutex

2019-08-16 Thread Chris Wilson
We use timeline->mutex to protect modifications to context->active_count, and the associated enable/disable callbacks. Due to complications with engine-pm barrier there is a path where we used a "superlock" to provide serialised protect and so could not unconditionally assert with lockdep that it

Re: [Intel-gfx] [PATCH 2/5] kernel.h: Add non_block_start/end()

2019-08-16 Thread Michal Hocko
On Fri 16-08-19 09:19:06, Jason Gunthorpe wrote: > On Fri, Aug 16, 2019 at 10:10:29AM +0200, Michal Hocko wrote: > > On Thu 15-08-19 17:13:23, Jason Gunthorpe wrote: > > > On Thu, Aug 15, 2019 at 09:35:26PM +0200, Michal Hocko wrote: > > > > > > > > The last detail is I'm still unclear what a GFP

Re: [Intel-gfx] [PATCH] Revert "nvme-pci: use host managed power state for suspend"

2019-08-16 Thread Christoph Hellwig
Please, report the actual problem. Blindly reverting a patch without even an explanation of your regressions is not the way to do it. ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 2/5] kernel.h: Add non_block_start/end()

2019-08-16 Thread Daniel Vetter
On Fri, Aug 16, 2019 at 2:12 PM Jason Gunthorpe wrote: > > On Fri, Aug 16, 2019 at 08:20:55AM +0200, Daniel Vetter wrote: > > On Fri, Aug 16, 2019 at 3:00 AM Jason Gunthorpe wrote: > > > On Thu, Aug 15, 2019 at 10:49:31PM +0200, Daniel Vetter wrote: > > > > On Thu, Aug 15, 2019 at 10:27 PM Jason

Re: [Intel-gfx] [PATCH] Revert "nvme-pci: use host managed power state for suspend"

2019-08-16 Thread Keith Busch
On Fri, Aug 16, 2019 at 07:12:11AM -0700, Chris Wilson wrote: > Quoting Keith Busch (2019-08-16 13:46:41) > > Could you please try Rafael's solution? These two commits here: > > > >

[Intel-gfx] [PATCH] drm/i915: Only emit the 'send bug report' once for a GPU hang

2019-08-16 Thread Chris Wilson
Use a locked xchg to ensure that the global log message giving instructions on how to send a bug report is emitted precisely once. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gpu_error.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

Re: [Intel-gfx] [PATCH v3 2/5] drm/i915/wopcm: Check WOPCM layout separately from calculations

2019-08-16 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-08-16 11:54:58) > +static inline bool __check_layout(struct drm_i915_private *i915, u32 > wopcm_size, > + u32 guc_wopcm_base, u32 guc_wopcm_size, > + u32 guc_fw_size, u32 huc_fw_size) > +{ > +

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Sanitize PHY state during display core uninit

2019-08-16 Thread Patchwork
== Series Details == Series: drm/i915: Sanitize PHY state during display core uninit URL : https://patchwork.freedesktop.org/series/65298/ State : success == Summary == CI Bug Log - changes from CI_DRM_6718 -> Patchwork_14050 Summary

Re: [Intel-gfx] [PATCH 2/5] kernel.h: Add non_block_start/end()

2019-08-16 Thread Jerome Glisse
On Fri, Aug 16, 2019 at 11:31:45AM -0300, Jason Gunthorpe wrote: > On Fri, Aug 16, 2019 at 02:26:25PM +0200, Michal Hocko wrote: > > On Fri 16-08-19 09:19:06, Jason Gunthorpe wrote: > > > On Fri, Aug 16, 2019 at 10:10:29AM +0200, Michal Hocko wrote: > > > > On Thu 15-08-19 17:13:23, Jason

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Dynamically allocate s0ix struct for VLV

2019-08-16 Thread Daniele Ceraolo Spurio
@@ -2229,7 +2320,7 @@ static void vlv_restore_gunit_s0ix_state(struct drm_i915_private *dev_priv) I915_WRITE(GEN7_GFX_PEND_TLB0, s->gfx_pend_tlb0); I915_WRITE(GEN7_GFX_PEND_TLB1, s->gfx_pend_tlb1); - for (i = 0; i < ARRAY_SIZE(s->lra_limits); i++) + for (i =

[Intel-gfx] ✗ Fi.CI.BAT: failure for Revert "nvme-pci: use host managed power state for suspend"

2019-08-16 Thread Patchwork
== Series Details == Series: Revert "nvme-pci: use host managed power state for suspend" URL : https://patchwork.freedesktop.org/series/65309/ State : failure == Summary == Applying: Revert "nvme-pci: use host managed power state for suspend" Using index info to reconstruct a base tree... M

[Intel-gfx] ✓ Fi.CI.IGT: success for Some more display uncore prep work

2019-08-16 Thread Patchwork
== Series Details == Series: Some more display uncore prep work URL : https://patchwork.freedesktop.org/series/65281/ State : success == Summary == CI Bug Log - changes from CI_DRM_6714_full -> Patchwork_14043_full Summary ---

[Intel-gfx] [PATCH v3] drm/i915/uc: Add explicit DISABLED state for firmware

2019-08-16 Thread Michal Wajdeczko
We really need to have separate NOT_SUPPORTED state (for lack of hardware support) and DISABLED state (to indicate user decision) as we will have to take special steps even if GuC firmware is now disabled but hardware exists and could have been previously used. v2: fix logic (Chris/CI) v3: use

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/execlists: Lift process_csb() out of the irq-off spinlock

2019-08-16 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Lift process_csb() out of the irq-off spinlock URL : https://patchwork.freedesktop.org/series/65321/ State : success == Summary == CI Bug Log - changes from CI_DRM_6720 -> Patchwork_14058

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Extract intel_frontbuffer active tracking

2019-08-16 Thread Patchwork
== Series Details == Series: drm/i915: Extract intel_frontbuffer active tracking URL : https://patchwork.freedesktop.org/series/65289/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6715_full -> Patchwork_14045_full Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Switch obj->mm.lock lockdep annotations on its head

2019-08-16 Thread Patchwork
== Series Details == Series: drm/i915: Switch obj->mm.lock lockdep annotations on its head URL : https://patchwork.freedesktop.org/series/65326/ State : warning == Summary == $ dim checkpatch origin/drm-tip d55e4cd434cc drm/i915: Switch obj->mm.lock lockdep annotations on its head -:91:

Re: [Intel-gfx] [PATCH] drm/i915: Switch obj->mm.lock lockdep annotations on its head

2019-08-16 Thread Tang, CQ
> -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] > Sent: Friday, August 16, 2019 11:24 AM > To: Intel Graphics Development > Cc: Daniel Vetter ; Chris Wilson wilson.co.uk>; Tang, CQ ; Ursulin, Tvrtko > ; Joonas Lahtinen > ; Vetter, Daniel > Subject: [PATCH]

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Introduce i915_reg_types.h

2019-08-16 Thread Daniele Ceraolo Spurio
On 8/16/19 2:40 AM, Michal Wajdeczko wrote: On Fri, 16 Aug 2019 03:23:42 +0200, Daniele Ceraolo Spurio wrote: With the introduction of display uncore, we want to categorize registers between display and non-display. To help us getting it right, it will be useful to move the display

Re: [Intel-gfx] [PATCH 2/5] kernel.h: Add non_block_start/end()

2019-08-16 Thread Daniel Vetter
On Fri, Aug 16, 2019 at 4:38 PM Jason Gunthorpe wrote: > > On Fri, Aug 16, 2019 at 04:11:34PM +0200, Daniel Vetter wrote: > > Also, aside from this patch (which is prep for the next) and some > > simple reordering conflicts they're all independent. So if there's no > > way to paint this bikeshed

[Intel-gfx] [PATCH] drm/i915/selftests: Check the context size

2019-08-16 Thread Chris Wilson
Add a redzone to our context image and check the HW does not write into after a context save, to verify that we have the correct context size. (This does vary with feature bits, so test with a live setup that should match how we run userspace.) Signed-off-by: Chris Wilson Cc: Daniele Ceraolo

Re: [Intel-gfx] [PATCH v3] drm/i915/uc: Add explicit DISABLED state for firmware

2019-08-16 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-08-16 18:51:30) > We really need to have separate NOT_SUPPORTED state (for > lack of hardware support) and DISABLED state (to indicate > user decision) as we will have to take special steps even > if GuC firmware is now disabled but hardware exists and > could have

[Intel-gfx] [PATCH] drm/i915: Switch obj->mm.lock lockdep annotations on its head

2019-08-16 Thread Daniel Vetter
The trouble with having a plain nesting flag for locks which do not naturally nest (unlike block devices and their partitions, which is the original motivation for nesting levels) is that lockdep will never spot a true deadlock if you screw up. This patch is an attempt at trying better, by

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/uc: Add explicit DISABLED state for firmware (rev3)

2019-08-16 Thread Patchwork
== Series Details == Series: drm/i915/uc: Add explicit DISABLED state for firmware (rev3) URL : https://patchwork.freedesktop.org/series/65278/ State : success == Summary == CI Bug Log - changes from CI_DRM_6720 -> Patchwork_14059 Summary

[Intel-gfx] [PATCH] drm/connector: Allow max possible encoders to attach to a connector

2019-08-16 Thread José Roberto de Souza
From: Dhinakaran Pandiyan Currently we restrict the number of encoders that can be linked to a connector to 3, increase it to match the maximum number of encoders that can be initialized(32). To more effiently do that lets switch from an array of encoder ids to bitmask. Also removing the

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/selftests: Check the context size (rev3)

2019-08-16 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Check the context size (rev3) URL : https://patchwork.freedesktop.org/series/65323/ State : warning == Summary == $ dim checkpatch origin/drm-tip 592028b70fab drm/i915/selftests: Check the context size -:26: CHECK:LINE_SPACING: Please use a

Re: [Intel-gfx] [PATCH 4/6] drm/i915: Dynamically allocate s0ix struct for VLV

2019-08-16 Thread Daniele Ceraolo Spurio
On 8/16/19 2:35 AM, Jani Nikula wrote: On Thu, 15 Aug 2019, Daniele Ceraolo Spurio wrote: This is only required for a single platform so no need to reserve the memory on all of them. This removes the last direct dependency of i915_drv.h on i915_reg.h (apart from the i915_reg_t definition).

[Intel-gfx] ✓ Fi.CI.BAT: success for More WOPCM fixes (rev3)

2019-08-16 Thread Patchwork
== Series Details == Series: More WOPCM fixes (rev3) URL : https://patchwork.freedesktop.org/series/65263/ State : success == Summary == CI Bug Log - changes from CI_DRM_6718 -> Patchwork_14054 Summary --- **SUCCESS** No

[Intel-gfx] ✓ Fi.CI.IGT: success for More WOPCM fixes (rev2)

2019-08-16 Thread Patchwork
== Series Details == Series: More WOPCM fixes (rev2) URL : https://patchwork.freedesktop.org/series/65263/ State : success == Summary == CI Bug Log - changes from CI_DRM_6714_full -> Patchwork_14039_full Summary --- **SUCCESS**

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/2] drm/i915/gt: Mark context->active_count as protected by timeline->mutex

2019-08-16 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/gt: Mark context->active_count as protected by timeline->mutex URL : https://patchwork.freedesktop.org/series/65307/ State : success == Summary == CI Bug Log - changes from CI_DRM_6719 -> Patchwork_14056

[Intel-gfx] [PATCH] drm/i915: Always wrap the ring offset before resetting

2019-08-16 Thread Chris Wilson
We were passing in an unwrapped offset into intel_ring_reset() on unpinning. Sooner or later that had to land on ring->size. <3> [314.872147] intel_ring_reset:1237 GEM_BUG_ON(!intel_ring_offset_valid(ring, tail)) <4> [314.872272] [ cut here ] <2> [314.872276] kernel BUG

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Move i915_power_well_id out of i915_reg.h

2019-08-16 Thread Daniele Ceraolo Spurio
On 8/16/19 8:27 AM, Daniele Ceraolo Spurio wrote: On 8/15/19 9:52 PM, Lucas De Marchi wrote: On Thu, Aug 15, 2019 at 6:24 PM Daniele Ceraolo Spurio wrote: It has nothing to do with registers, so move it to the more appropriate intel_display_power.h Signed-off-by: Daniele Ceraolo Spurio

Re: [Intel-gfx] [v3] drm/dp/dsc: Add Support for all BPCs supported by TGL

2019-08-16 Thread Manasi Navare
On Thu, Aug 15, 2019 at 01:54:20PM -0700, Anusha Srivatsa wrote: > DSC engine on ICL supports only 8 and 10 BPC as the input > BPC. But DSC engine in TGL supports 8, 10 and 12 BPC. > Add 12 BPC support for DSC while calculating compression > configuration. > > v2: Remove the separate define

[Intel-gfx] [PATCH v3] drm/i915/selftests: Check the context size

2019-08-16 Thread Chris Wilson
Add a redzone to our context image and check the HW does not write into after a context save, to verify that we have the correct context size. (This does vary with feature bits, so test with a live setup that should match how we run userspace.) v2: Check the redzone on every context unpin v3: Use

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Move i915_power_well_id out of i915_reg.h

2019-08-16 Thread Daniele Ceraolo Spurio
On 8/15/19 9:52 PM, Lucas De Marchi wrote: On Thu, Aug 15, 2019 at 6:24 PM Daniele Ceraolo Spurio wrote: It has nothing to do with registers, so move it to the more appropriate intel_display_power.h Signed-off-by: Daniele Ceraolo Spurio Cc: Imre Deak ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with drm/i915/execlists: Lift process_csb() out of the irq-off spinlock (rev2)

2019-08-16 Thread Patchwork
== Series Details == Series: series starting with drm/i915/execlists: Lift process_csb() out of the irq-off spinlock (rev2) URL : https://patchwork.freedesktop.org/series/65294/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6719 -> Patchwork_14055

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gen11: Add Wa_1604278689:icl,ehl

2019-08-16 Thread Chris Wilson
Quoting Matt Roper (2019-08-16 17:29:09) > On Fri, Aug 16, 2019 at 08:07:18AM +0100, Chris Wilson wrote: > > Quoting Patchwork (2019-08-16 00:52:20) > > > Possible regressions > > > > > > * igt@i915_selftest@live_hangcheck: > > > - fi-icl-u3: [PASS][1] -> [DMESG-FAIL][2]

Re: [Intel-gfx] [PATCH] Revert "nvme-pci: use host managed power state for suspend"

2019-08-16 Thread Keith Busch
On Fri, Aug 16, 2019 at 6:38 AM Christoph Hellwig wrote: > On Fri, Aug 16, 2019 at 01:30:29PM +0100, Chris Wilson wrote: > > Quoting Christoph Hellwig (2019-08-16 13:26:44) > > > Please, report the actual problem. Blindly reverting a patch without > > > even an explanation of your regressions is

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Check the context size

2019-08-16 Thread Daniele Ceraolo Spurio
On 8/16/19 10:58 AM, Chris Wilson wrote: Add a redzone to our context image and check the HW does not write into after a context save, to verify that we have the correct context size. (This does vary with feature bits, so test with a live setup that should match how we run userspace.) On

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Check the context size

2019-08-16 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Check the context size URL : https://patchwork.freedesktop.org/series/65323/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6720 -> Patchwork_14060 Summary ---

[Intel-gfx] [PATCH v2] drm/i915/selftests: Check the context size

2019-08-16 Thread Chris Wilson
Add a redzone to our context image and check the HW does not write into after a context save, to verify that we have the correct context size. (This does vary with feature bits, so test with a live setup that should match how we run userspace.) v2: Check the redzone on every context unpin

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Switch obj->mm.lock lockdep annotations on its head

2019-08-16 Thread Patchwork
== Series Details == Series: drm/i915: Switch obj->mm.lock lockdep annotations on its head URL : https://patchwork.freedesktop.org/series/65326/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6720 -> Patchwork_14061 Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with drm/i915/execlists: Lift process_csb() out of the irq-off spinlock (rev2)

2019-08-16 Thread Patchwork
== Series Details == Series: series starting with drm/i915/execlists: Lift process_csb() out of the irq-off spinlock (rev2) URL : https://patchwork.freedesktop.org/series/65294/ State : warning == Summary == $ dim checkpatch origin/drm-tip 62875a3f6df9 drm/i915/execlists: Lift process_csb()

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gen11: Add Wa_1604278689:icl,ehl

2019-08-16 Thread Matt Roper
On Fri, Aug 16, 2019 at 08:07:18AM +0100, Chris Wilson wrote: > Quoting Patchwork (2019-08-16 00:52:20) > > Possible regressions > > > > * igt@i915_selftest@live_hangcheck: > > - fi-icl-u3: [PASS][1] -> [DMESG-FAIL][2] > >[1]: > >

Re: [Intel-gfx] [PATCH] drm/i915: Switch obj->mm.lock lockdep annotations on its head

2019-08-16 Thread Chris Wilson
Quoting Daniel Vetter (2019-08-16 19:23:36) > The trouble with having a plain nesting flag for locks which do not > naturally nest (unlike block devices and their partitions, which is > the original motivation for nesting levels) is that lockdep will > never spot a true deadlock if you screw up. >

Re: [Intel-gfx] [PATCH] drm/i915/gen11: Allow usage of all GPIO pins

2019-08-16 Thread Souza, Jose
On Thu, 2019-08-15 at 15:39 -0700, Matt Roper wrote: > Our pin mapping tables for ICP and MCC currently only list the > standard > GPIO pins used for various output ports. Even through ICP's standard > pin usage only utilizes pins 1, 2, and 9-12, and MCC's standard pin > usage only uses pins 1,

[Intel-gfx] [CI] drm/i915/execlists: Lift process_csb() out of the irq-off spinlock

2019-08-16 Thread Chris Wilson
If we only call process_csb() from the tasklet, though we lose the ability to bypass ksoftirqd interrupt processing on direct submission paths, we can push it out of the irq-off spinlock. The penalty is that we then allow schedule_out to be called concurrently with schedule_in requiring us to

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Check the context size

2019-08-16 Thread Chris Wilson
Quoting Daniele Ceraolo Spurio (2019-08-16 19:43:47) > > > On 8/16/19 10:58 AM, Chris Wilson wrote: > > Add a redzone to our context image and check the HW does not write into > > after a context save, to verify that we have the correct context size. > > (This does vary with feature bits, so

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/connector: Allow max possible encoders to attach to a connector (rev2)

2019-08-16 Thread Patchwork
== Series Details == Series: drm/connector: Allow max possible encoders to attach to a connector (rev2) URL : https://patchwork.freedesktop.org/series/62743/ State : success == Summary == CI Bug Log - changes from CI_DRM_6721 -> Patchwork_14064

Re: [Intel-gfx] [PATCH] drm/i915: Switch obj->mm.lock lockdep annotations on its head

2019-08-16 Thread Daniel Vetter
On Fri, Aug 16, 2019 at 9:23 PM Tang, CQ wrote: > > > > > -Original Message- > > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] > > Sent: Friday, August 16, 2019 11:24 AM > > To: Intel Graphics Development > > Cc: Daniel Vetter ; Chris Wilson > wilson.co.uk>; Tang, CQ ; Ursulin,

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Use the associated uncore for the vm

2019-08-16 Thread Patchwork
== Series Details == Series: drm/i915: Use the associated uncore for the vm URL : https://patchwork.freedesktop.org/series/65291/ State : success == Summary == CI Bug Log - changes from CI_DRM_6716_full -> Patchwork_14047_full Summary

Re: [Intel-gfx] [PATCH v3] drm/i915/selftests: Check the context size

2019-08-16 Thread Chris Wilson
Quoting Daniele Ceraolo Spurio (2019-08-16 22:50:43) > > > On 8/16/19 12:17 PM, Chris Wilson wrote: > > +static int live_context_size(void *arg) > > +{ > > + /* > > + * Hide the old default state -- we lie about the context size > > + * and get confused when

Re: [Intel-gfx] [PATCH v3] drm/i915/selftests: Check the context size

2019-08-16 Thread Daniele Ceraolo Spurio
On 8/16/19 3:13 PM, Chris Wilson wrote: Quoting Daniele Ceraolo Spurio (2019-08-16 22:50:43) On 8/16/19 12:17 PM, Chris Wilson wrote: +static int live_context_size(void *arg) +{ + /* + * Hide the old default state -- we lie about the context size + *

Re: [Intel-gfx] [PATCH] drm/i915: Switch obj->mm.lock lockdep annotations on its head

2019-08-16 Thread Tang, CQ
> -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] > Sent: Friday, August 16, 2019 3:03 PM > To: Chris Wilson > Cc: Intel Graphics Development ; Tang, CQ > ; Ursulin, Tvrtko ; Joonas > Lahtinen ; Vetter, Daniel > > Subject: Re: [PATCH] drm/i915: Switch

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Check the context size (rev3)

2019-08-16 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Check the context size (rev3) URL : https://patchwork.freedesktop.org/series/65323/ State : success == Summary == CI Bug Log - changes from CI_DRM_6721 -> Patchwork_14062 Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Always wrap the ring offset before resetting

2019-08-16 Thread Patchwork
== Series Details == Series: drm/i915: Always wrap the ring offset before resetting URL : https://patchwork.freedesktop.org/series/65329/ State : success == Summary == CI Bug Log - changes from CI_DRM_6721 -> Patchwork_14063 Summary

Re: [Intel-gfx] [PATCH] drm/i915: Switch obj->mm.lock lockdep annotations on its head

2019-08-16 Thread Daniel Vetter
On Fri, Aug 16, 2019 at 8:46 PM Chris Wilson wrote: > > Quoting Daniel Vetter (2019-08-16 19:23:36) > > The trouble with having a plain nesting flag for locks which do not > > naturally nest (unlike block devices and their partitions, which is > > the original motivation for nesting levels) is

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gen11: Allow usage of all GPIO pins (rev3)

2019-08-16 Thread Patchwork
== Series Details == Series: drm/i915/gen11: Allow usage of all GPIO pins (rev3) URL : https://patchwork.freedesktop.org/series/65261/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6722 -> Patchwork_14066 Summary ---

Re: [Intel-gfx] Linux Kernel 5.2.8 (uvc or i915? <<<)

2019-08-16 Thread Nathaniel Russell
Kernel is the dmesg from the kernel I run on a daily basis. On 8/16/19, Laurent Pinchart wrote: > Hi Randy, > > On Thu, Aug 15, 2019 at 08:10:03PM -0700, Randy Dunlap wrote: >> [adding mailing lists etc. with Nathaniel's test info] >> >> On 8/15/19 7:21 PM, Nathaniel Russell wrote: >> > Well i

Re: [Intel-gfx] [PATCH 2/5] kernel.h: Add non_block_start/end()

2019-08-16 Thread Daniel Vetter
On Fri, Aug 16, 2019 at 3:00 AM Jason Gunthorpe wrote: > On Thu, Aug 15, 2019 at 10:49:31PM +0200, Daniel Vetter wrote: > > On Thu, Aug 15, 2019 at 10:27 PM Jason Gunthorpe wrote: > > > On Thu, Aug 15, 2019 at 10:16:43PM +0200, Daniel Vetter wrote: > > > > So if someone can explain to me how

Re: [Intel-gfx] linux-next: build warning after merge of the drm-misc tree

2019-08-16 Thread Daniel Vetter
On Fri, Aug 16, 2019 at 6:48 AM Sam Ravnborg wrote: > > Hi Stephen. > > On Fri, Aug 16, 2019 at 01:31:32PM +1000, Stephen Rothwell wrote: > > Hi all, > > > > After merging the drm-misc tree, today's linux-next build (x86_64 > > allmodconfig) produced this warning: > > > > warning: same module

  1   2   >