Re: [Intel-gfx] [PATCH v9 0/8] drm/i915/dp: Support for DP HDR outputs

2019-10-15 Thread Ville Syrjälä
On Fri, Sep 20, 2019 at 07:06:27PM +0300, Ville Syrjälä wrote: > On Thu, Sep 19, 2019 at 10:53:03PM +0300, Gwan-gyeong Mun wrote: > > Support for HDR10 video was introduced in DisplayPort 1.4. > > On GLK+ platform, in order to use DisplayPort HDR10, we need to support > > BT.2020 colorimetry and

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915_hangman: Force error capture

2019-10-15 Thread Andi Shyti
Hi Chris, On Thu, Oct 03, 2019 at 04:23:02PM +0100, Chris Wilson wrote: > For fast preempt-resets, error capture is skipped, so disable > preempt-resets before checking the error state. While thinking ahead, be > prepared for when the modparams are not accessible. > > Signed-off-by: Chris Wilson

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/7] drm/i915: Expose engine properties via sysfs

2019-10-15 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915: Expose engine properties via sysfs URL : https://patchwork.freedesktop.org/series/68022/ State : success == Summary == CI Bug Log - changes from CI_DRM_7094 -> Patchwork_14810

[Intel-gfx] [PATCH v4 2/2] drm/i915: Restrict qgv points which don't have enough bandwidth.

2019-10-15 Thread Stanislav Lisovskiy
According to BSpec 53998, we should try to restrict qgv points, which can't provide enough bandwidth for desired display configuration. Currently we are just comparing against all of those and take minimum(worst case). v2: Fixed wrong PCode reply mask, removed hardcoded values. v3: Forbid

[Intel-gfx] [PATCH v4 1/2] drm/i915: Refactor intel_can_enable_sagv

2019-10-15 Thread Stanislav Lisovskiy
Currently intel_can_enable_sagv function contains a mix of workarounds for different platforms some of them are not valid for gens >= 11 already, so lets split it into separate functions. Signed-off-by: Stanislav Lisovskiy Cc: Ville Syrjälä Cc: James Ausmus --- drivers/gpu/drm/i915/intel_pm.c

[Intel-gfx] [PATCH v4 0/2] Refactor Gen11+ SAGV support

2019-10-15 Thread Stanislav Lisovskiy
For Gen11+ platforms BSpec suggests disabling specific QGV points separately, depending on bandwidth limitations and current display configuration. Thus it required adding a new PCode request for disabling QGV points and some refactoring of already existing SAGV code. Stanislav Lisovskiy (2):

Re: [Intel-gfx] [PATCH 3/4] [v5] drm/i915/color: Extract icl_read_luts()

2019-10-15 Thread Sharma, Swati2
On 15-Oct-19 6:04 PM, Ville Syrjälä wrote: On Thu, Oct 10, 2019 at 04:20:04PM +0530, Sharma, Swati2 wrote: On 09-Oct-19 7:46 PM, Ville Syrjälä wrote: On Wed, Oct 09, 2019 at 12:25:41PM +0530, Swati Sharma wrote: For icl+, have hw read out to create hw blob of gamma lut values. icl+ platforms

Re: [Intel-gfx] [RFC 2/7] drm/i915/dsi: Configure transcoder operation for command mode.

2019-10-15 Thread Jani Nikula
On Mon, 14 Oct 2019, Vandita Kulkarni wrote: > Configure the transcoder to operate in TE GATE command mode > and take TE events from GPIO. > Also disable the periodic command mode, that GOP would have > programmed. > > Signed-off-by: Vandita Kulkarni > --- >

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Introduce Jasper Lake PCH (rev4)

2019-10-15 Thread Patchwork
== Series Details == Series: drm/i915: Introduce Jasper Lake PCH (rev4) URL : https://patchwork.freedesktop.org/series/67992/ State : warning == Summary == $ dim checkpatch origin/drm-tip af8d69d10bd5 drm/i915: Introduce Jasper Lake PCH -:30: WARNING:BAD_SIGN_OFF: Duplicate signature #30:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/icl: Wa_1607087056

2019-10-15 Thread Patchwork
== Series Details == Series: drm/i915/icl: Wa_1607087056 URL : https://patchwork.freedesktop.org/series/68036/ State : success == Summary == CI Bug Log - changes from CI_DRM_7098 -> Patchwork_14814 Summary --- **SUCCESS** No

Re: [Intel-gfx] [RFC 4/7] drm/i915/dsi: Helper to find dsi encoder in cmd mode

2019-10-15 Thread Jani Nikula
On Mon, 14 Oct 2019, Vandita Kulkarni wrote: > From: Madhav Chauhan > > This patch adds a helper function to find encoder > if DSI is operating in command mode. This function > will be used while enabling/disabling TE interrupts > for DSI. > > Signed-off-by: Madhav Chauhan > Signed-off-by:

[Intel-gfx] [PATCH v2 12/13] drm/i915: Consolidate more cdclk state handling

2019-10-15 Thread Ville Syrjala
From: Ville Syrjälä Move the initial setup of state->min_cdclk[]/min_voltage_level[] into intel_modeset_calc_cdclk() alongside the rest of the global cdclk state. And the counterparts we move into intel_cdclk_swap_state(). Signed-off-by: Ville Syrjälä ---

[Intel-gfx] [PATCH v2 13/13] drm/i915: Collect more cdclk state under the same roof

2019-10-15 Thread Ville Syrjala
From: Ville Syrjälä Move the min_cdclk[] and min_voltage_level[] arrays under the rest of the cdclk state. And while at it provide a simple helper (intel_cdclk_clear_state()) to clear the state during the ww_mutex backoff dance. Signed-off-by: Ville Syrjälä ---

[Intel-gfx] [CI 07/12] drm/i915/tgl: Wa_1409420604

2019-10-15 Thread Chris Wilson
From: Mika Kuoppala Avoid possible hang in CPSS unit. Signed-off-by: Mika Kuoppala Reviewed-by: Chris Wilson Signed-off-by: Chris Wilson Link: https://patchwork.freedesktop.org/patch/msgid/20191015154449.10338-6-mika.kuopp...@linux.intel.com --- drivers/gpu/drm/i915/gt/intel_workarounds.c

[Intel-gfx] [CI 09/12] drm/i915/tgl: Wa_1409600907

2019-10-15 Thread Chris Wilson
From: Mika Kuoppala To avoid possible hang, we need to add depth stall if we flush the depth cache. Signed-off-by: Mika Kuoppala Reviewed-by: Chris Wilson Signed-off-by: Chris Wilson Link: https://patchwork.freedesktop.org/patch/msgid/20191015154449.10338-8-mika.kuopp...@linux.intel.com ---

[Intel-gfx] [CI 02/12] drm/i915/tgl: Add IS_TGL_REVID

2019-10-15 Thread Chris Wilson
From: Mika Kuoppala We are going to need this macro on limiting the workaround scope. Signed-off-by: Mika Kuoppala Reviewed-by: Chris Wilson Signed-off-by: Chris Wilson Link: https://patchwork.freedesktop.org/patch/msgid/20191015154449.10338-1-mika.kuopp...@linux.intel.com ---

[Intel-gfx] [CI 03/12] drm/i915/tgl: Include ro parts of l3 to invalidate

2019-10-15 Thread Chris Wilson
From: Mika Kuoppala Aim for completeness and invalidate also the ro parts in l3 cache. This might allow to get rid of the preparser disable/enable workaround on invalidation path. Cc: Chris Wilson Signed-off-by: Mika Kuoppala Reviewed-by: Chris Wilson Signed-off-by: Chris Wilson Link:

[Intel-gfx] [CI 12/12] drm/i915/tgl: Wa_1607138340

2019-10-15 Thread Chris Wilson
From: Mika Kuoppala Avoid possible cs hang with semaphores by disabling lite restore. Signed-off-by: Mika Kuoppala Reviewed-by: Chris Wilson Signed-off-by: Chris Wilson Link: https://patchwork.freedesktop.org/patch/msgid/20191015154449.10338-11-mika.kuopp...@linux.intel.com ---

[Intel-gfx] [CI 08/12] drm/i915/tgl: Wa_1409170338

2019-10-15 Thread Chris Wilson
From: Mika Kuoppala Avoid possible hang in tsg,vfe units by keeping l3 clocks runnings. Signed-off-by: Mika Kuoppala Reviewed-by: Chris Wilson Signed-off-by: Chris Wilson Link: https://patchwork.freedesktop.org/patch/msgid/20191015154449.10338-7-mika.kuopp...@linux.intel.com ---

[Intel-gfx] [CI 06/12] drm/i915/tgl: Keep FF dop clock enabled for A0

2019-10-15 Thread Chris Wilson
From: Mika Kuoppala To ensure correct state data for compute workloads, we need to keep the ff dop clock enabled. References: HSDES#1606700617 Signed-off-by: Mika Kuoppala Reviewed-by: Chris Wilson Signed-off-by: Chris Wilson Link:

[Intel-gfx] [CI 05/12] drm/i915/tgl: Add extra hdc flush workaround

2019-10-15 Thread Chris Wilson
From: Mika Kuoppala In order to ensure constant caches are invalidated properly with a0, we need extra hdc flush after invalidation. v2: use IS_TGL_REVID (Chris) References: HSDES#1604544889 Signed-off-by: Mika Kuoppala Reviewed-by: Chris Wilson Signed-off-by: Chris Wilson Link:

[Intel-gfx] [CI 10/12] drm/i915/tgl: Wa_1607138336

2019-10-15 Thread Chris Wilson
From: Mika Kuoppala Avoid possible deadlock on context switch. Signed-off-by: Mika Kuoppala Reviewed-by: Chris Wilson Signed-off-by: Chris Wilson Link: https://patchwork.freedesktop.org/patch/msgid/20191015154449.10338-9-mika.kuopp...@linux.intel.com ---

[Intel-gfx] [CI 11/12] drm/i915/tgl: Wa_1607030317, Wa_1607186500, Wa_1607297627

2019-10-15 Thread Chris Wilson
From: Mika Kuoppala Disable semaphore idle messages and wait for event power downs. Signed-off-by: Mika Kuoppala Reviewed-by: Chris Wilson Signed-off-by: Chris Wilson Link: https://patchwork.freedesktop.org/patch/msgid/20191015154449.10338-10-mika.kuopp...@linux.intel.com ---

[Intel-gfx] [CI 01/12] drm/i915/icl: Wa_1607087056

2019-10-15 Thread Chris Wilson
From: Mika Kuoppala Avoid possible hang in tsg,vfe units by keeping l3 clocks runnings. Signed-off-by: Mika Kuoppala Reviewed-by: Chris Wilson Signed-off-by: Chris Wilson Link: https://patchwork.freedesktop.org/patch/msgid/20191015154411.9984-1-mika.kuopp...@linux.intel.com ---

[Intel-gfx] [CI 04/12] drm/i915/tgl: Add HDC Pipeline Flush

2019-10-15 Thread Chris Wilson
From: Mika Kuoppala Add hdc pipeline flush to ensure memory state is coherent in L3 when we are done. v2: Flush also in breadcrumbs (Chris) Cc: Chris Wilson Signed-off-by: Mika Kuoppala Reviewed-by: Chris Wilson Signed-off-by: Chris Wilson Link:

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Fix MST oops due to MSA changes

2019-10-15 Thread Patchwork
== Series Details == Series: drm/i915: Fix MST oops due to MSA changes URL : https://patchwork.freedesktop.org/series/68053/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7099 -> Patchwork_14819 Summary ---

Re: [Intel-gfx] [PATCH] kernel-doc: rename the kernel-doc directive 'functions' to 'specific'

2019-10-15 Thread Jonathan Corbet
On Sun, 13 Oct 2019 13:53:59 +0800 Changbin Du wrote: > The 'functions' directive is not only for functions, but also works for > structs/unions. So the name is misleading. This patch renames it to > 'specific', so now we have export/internal/specific directives to limit > the functions/types to

Re: [Intel-gfx] [RFC 3/7] drm/i915/dsi: Add vblank calculation for command mode

2019-10-15 Thread Jani Nikula
On Mon, 14 Oct 2019, Vandita Kulkarni wrote: > Transcoder timing calculation differ for command mode. > > Signed-off-by: Vandita Kulkarni > --- > drivers/gpu/drm/i915/display/icl_dsi.c | 56 +- > 1 file changed, 37 insertions(+), 19 deletions(-) > > diff --git

[Intel-gfx] [PATCH] drm/i915: Fix MST oops due to MSA changes

2019-10-15 Thread Ville Syrjala
From: Ville Syrjälä The MSA MISC computation now depends on the connector state, and we do it from the DDI .pre_enable() hook. All that is fine for DP SST but with MST we don't actually pass the connector state to the dig port's .pre_enable() hook which leads to an oops. Need to think more how

Re: [Intel-gfx] [RESEND PATCH v2] drm: Add getfb2 ioctl

2019-10-15 Thread Daniele Castagna
On Mon, Oct 14, 2019 at 1:51 PM Daniel Vetter wrote: > > On Mon, Oct 14, 2019 at 6:21 PM Li, Juston wrote: > > > > On Wed, 2019-10-09 at 17:50 +0200, Daniel Vetter wrote: > > > On Thu, Oct 03, 2019 at 11:31:25AM -0700, Juston Li wrote: > > > > From: Daniel Stone > > > > > > > > getfb2 allows us

Re: [Intel-gfx] [PATCH V3 0/7] mdev based hardware virtio offloading support

2019-10-15 Thread Stefan Hajnoczi
On Tue, Oct 15, 2019 at 11:37:17AM +0800, Jason Wang wrote: > > On 2019/10/15 上午1:49, Stefan Hajnoczi wrote: > > On Fri, Oct 11, 2019 at 04:15:50PM +0800, Jason Wang wrote: > > > There are hardware that can do virtio datapath offloading while having > > > its own control path. This path tries to

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Plane cdclk requirements and fp16 for gen4+ (rev2)

2019-10-15 Thread Patchwork
== Series Details == Series: drm/i915: Plane cdclk requirements and fp16 for gen4+ (rev2) URL : https://patchwork.freedesktop.org/series/63373/ State : warning == Summary == $ dim checkpatch origin/drm-tip d780d2521e9c drm/i915: Add debugs to distingiush a cd2x update from a full cdclk pll

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Plane cdclk requirements and fp16 for gen4+ (rev2)

2019-10-15 Thread Patchwork
== Series Details == Series: drm/i915: Plane cdclk requirements and fp16 for gen4+ (rev2) URL : https://patchwork.freedesktop.org/series/63373/ State : success == Summary == CI Bug Log - changes from CI_DRM_7099 -> Patchwork_14821 Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Introduce Jasper Lake PCH (rev4)

2019-10-15 Thread Patchwork
== Series Details == Series: drm/i915: Introduce Jasper Lake PCH (rev4) URL : https://patchwork.freedesktop.org/series/67992/ State : success == Summary == CI Bug Log - changes from CI_DRM_7099 -> Patchwork_14822 Summary ---

Re: [Intel-gfx] [PATCH v3 v2 4/5] drm/i915: add pipe id/name to pipe mismatch logs

2019-10-15 Thread Ville Syrjälä
On Tue, Oct 15, 2019 at 09:40:28AM -0700, Lucas De Marchi wrote: > This way it's easier to figure out what didn't match when we have > multiple pipes enabled. > > v2: pass drm_crtc and use the more common [CRTC:%d:%s] format > (Ville) > > Signed-off-by: Lucas De Marchi > --- >

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Introduce Jasper Lake PCH (rev3)

2019-10-15 Thread Patchwork
== Series Details == Series: drm/i915: Introduce Jasper Lake PCH (rev3) URL : https://patchwork.freedesktop.org/series/67992/ State : warning == Summary == $ dim checkpatch origin/drm-tip 47be6f8097ac drm/i915: Introduce Jasper Lake PCH -:30: WARNING:BAD_SIGN_OFF: Duplicate signature #30:

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/ehl: Don't forget to set TC long detect function

2019-10-15 Thread Matt Roper
On Tue, Oct 15, 2019 at 06:54:02PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/ehl: Don't forget to set TC long detect function > URL : https://patchwork.freedesktop.org/series/68038/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_7098 ->

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/execlists: Clear semaphore immediately upon ELSP promotion (rev2)

2019-10-15 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Clear semaphore immediately upon ELSP promotion (rev2) URL : https://patchwork.freedesktop.org/series/67955/ State : success == Summary == CI Bug Log - changes from CI_DRM_7093_full -> Patchwork_14807_full

[Intel-gfx] ✗ Fi.CI.BAT: failure for Small fixes before fixing MST (rev2)

2019-10-15 Thread Patchwork
== Series Details == Series: Small fixes before fixing MST (rev2) URL : https://patchwork.freedesktop.org/series/67883/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7099 -> Patchwork_14818 Summary --- **FAILURE**

[Intel-gfx] [PATCH i-g-t 1/2 v3] NOMERGE: Import drm.h up to 54ecb8f7028c

2019-10-15 Thread Juston Li
Depends on ummerged kernel code for getfb2 Rest of drm.h taken from: commit 54ecb8f7028c5eb3d740bb82b0f1d90f2df63c5c Author: Linus Torvalds Date: Mon Sep 30 10:35:40 2019 -0700 Linux 5.4-rc1 Signed-off-by: Juston Li --- include/drm-uapi/drm.h | 39

[Intel-gfx] [PATCH i-g-t 2/2 v3] tests/kms_getfb: Add getfb2 tests

2019-10-15 Thread Juston Li
From: Daniel Stone Mirroring addfb2, add tests for the new ioctl which will return us information about framebuffers containing multiple buffers, as well as modifiers. Changes since v1: - Add test that uses getfb2 output to call addfb2 as suggested by Ville Signed-off-by: Daniel Stone

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/selftests: Drop stale struct_mutex

2019-10-15 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Drop stale struct_mutex URL : https://patchwork.freedesktop.org/series/68011/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7093_full -> Patchwork_14806_full Summary ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Introduce Jasper Lake PCH (rev3)

2019-10-15 Thread Patchwork
== Series Details == Series: drm/i915: Introduce Jasper Lake PCH (rev3) URL : https://patchwork.freedesktop.org/series/67992/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7098 -> Patchwork_14817 Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/ehl: Don't forget to set TC long detect function (rev2)

2019-10-15 Thread Patchwork
== Series Details == Series: drm/i915/ehl: Don't forget to set TC long detect function (rev2) URL : https://patchwork.freedesktop.org/series/68038/ State : success == Summary == CI Bug Log - changes from CI_DRM_7099 -> Patchwork_14820

[Intel-gfx] [PATCH 03/11] drm/i915/tgl: Add HDC Pipeline Flush

2019-10-15 Thread Mika Kuoppala
Add hdc pipeline flush to ensure memory state is coherent in L3 when we are done. v2: Flush also in breadcrumbs (Chris) Cc: Chris Wilson Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/gt/intel_gpu_commands.h | 1 + drivers/gpu/drm/i915/gt/intel_lrc.c | 5 - 2 files

[Intel-gfx] [PATCH 09/11] drm/i915/tgl: Wa_1607138336

2019-10-15 Thread Mika Kuoppala
Avoid possible deadlock on context switch. Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 + drivers/gpu/drm/i915/i915_reg.h | 2 ++ 2 files changed, 7 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c

[Intel-gfx] [PATCH 10/11] drm/i915/tgl: Wa_1607030317, Wa_1607186500, Wa_1607297627

2019-10-15 Thread Mika Kuoppala
Disable semaphore idle messages and wait for event power downs. Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 8 drivers/gpu/drm/i915/i915_reg.h | 1 + 2 files changed, 9 insertions(+) diff --git

[Intel-gfx] [PATCH 01/11] drm/i915/tgl: Add IS_TGL_REVID

2019-10-15 Thread Mika Kuoppala
We are going to need this macro on limiting the workaround scope. Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/i915_drv.h | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index c46b339064c0..f6aee1e01a7f 100644

[Intel-gfx] [PATCH 07/11] drm/i915/tgl: Wa_1409170338

2019-10-15 Thread Mika Kuoppala
Avoid possible hang in tsg,vfe units by keeping l3 clocks runnings. Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Refactor Gen11+ SAGV support

2019-10-15 Thread Patchwork
== Series Details == Series: Refactor Gen11+ SAGV support URL : https://patchwork.freedesktop.org/series/68028/ State : warning == Summary == $ dim checkpatch origin/drm-tip 248cbaf741d0 drm/i915: Refactor intel_can_enable_sagv -:33: WARNING:SUSPECT_CODE_INDENT: suspect code indent for

Re: [Intel-gfx] [PATCH V3 4/7] mdev: introduce device specific ops

2019-10-15 Thread Alex Williamson
On Tue, 15 Oct 2019 20:17:01 +0800 Jason Wang wrote: > On 2019/10/15 下午6:41, Cornelia Huck wrote: > > On Fri, 11 Oct 2019 16:15:54 +0800 > > Jason Wang wrote: > > > >> Currently, except for the create and remove, the rest of > >> mdev_parent_ops is designed for vfio-mdev driver only and may

[Intel-gfx] [PATCH v2 02/13] drm/i915: Rework global state locking

2019-10-15 Thread Ville Syrjala
From: Ville Syrjälä So far we've sort of protected the global state under dev_priv with the connection_mutex. I wan to change that so that we can change the cdclk even for pure plane updates. To that end let's formalize the protection of the global state to follow what I started with the cdclk

[Intel-gfx] [PATCH v2 04/13] drm/i915: Allow planes to declare their minimum acceptable cdclk

2019-10-15 Thread Ville Syrjala
From: Ville Syrjälä Various pixel formats and plane scaling impose additional constraints on the cdclk frequency. Provide a new plane->min_cdclk() hook that will be used to compute the minimum acceptable cdclk frequency for each plane. Annoyingly on some platforms the numer of active planes

[Intel-gfx] [PATCH v2 06/13] drm/i915: Simplify skl_max_scale()

2019-10-15 Thread Ville Syrjala
From: Ville Syrjälä Now that the planes declare their minimum cdclk requirements properly we don't need to check the cdclk in skl_max_scale() anymore. Just check against the maximum downscale ratio, and move the code next to it's only caller. v2: Add a comment explaining the HQ vs. not thing

[Intel-gfx] [PATCH v2 03/13] drm/i915: Move check_digital_port_conflicts() earier

2019-10-15 Thread Ville Syrjala
From: Ville Syrjälä check_digital_port_conflicts() is done needlessly late. Move it earlier. This will be needed as later on we want to set any_ms=true a bit later for non-modesets too and we can't call this guy without the connection_mutex held. Signed-off-by: Ville Syrjälä ---

[Intel-gfx] [PATCH v2 00/13] drm/i915: Plane cdclk requirements and fp16 for gen4+

2019-10-15 Thread Ville Syrjala
From: Ville Syrjälä Several patches have been pushed, new patches have appeared at the end. I wonder if I've invented a perpetual motion patch series... The new stuff is mostly just cleaning up the cdclk state (mis)management we have going on. I also modifier the global state locking stuff a

[Intel-gfx] [PATCH v2 07/13] drm/i915: Add support for half float framebuffers for skl+

2019-10-15 Thread Ville Syrjala
From: Ville Syrjälä skl+ supports fp16 pixel formats on all universal planes. Add the necessary bits to expose that capability. The main different to icl is that we can't scale fp16, so need to add the relevant checks. v2: Rebase on top of icl fp16 Split skl+ bits into a separate patch

[Intel-gfx] [PATCH v2 10/13] drm/i915: Add support for half float framebuffers on snb sprites

2019-10-15 Thread Ville Syrjala
From: Ville Syrjälä snb supports fp16 pixel formats on the sprite planes. Expose that capability. Nothing special needs to be done, it just works. v2: Rebase on top of icl fp16 Split snb+ sprite bits into a separate patch Reviewed-by: Maarten Lankhorst Signed-off-by: Ville Syrjälä ---

[Intel-gfx] [PATCH v2 09/13] drm/i915: Add support for half float framebuffers for ivb+ sprites

2019-10-15 Thread Ville Syrjala
From: Ville Syrjälä ivb+ supports fp16 pixel formats on the sprite planes planes. Expose that capability. On ivb/hsw fp16 scanout is slightly busted. The output from the plane will have 1/4 the expected value. For the sprite plane we can fix that up with the plane gamma unit. This was fixed on

[Intel-gfx] [PATCH v2 08/13] drm/i915: Add support for half float framebuffers for gen4+ primary planes

2019-10-15 Thread Ville Syrjala
From: Ville Syrjälä gen4+ supports fp16 pixel formats on the primary planes. Add the relevant code. On ivb fp16 scanout is slightly busted. The output from the plane will have 1/4 the expected value. For the primary plane we would have to use the pipe gamma or pipe csc to correct that which

[Intel-gfx] [PATCH v2 11/13] drm/i915: Move more cdclk state handling into intel_modeset_calc_cdclk()

2019-10-15 Thread Ville Syrjala
From: Ville Syrjälä Encapsulate the cdclk state handling a bit better by performing the copy from dev_priv->cdclk into the current intel_atomic_state within the cdclk code. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_cdclk.c | 7 +++

[Intel-gfx] [PATCH v2 05/13] drm/i915: Eliminate skl_check_pipe_max_pixel_rate()

2019-10-15 Thread Ville Syrjala
From: Ville Syrjälä The normal cdclk handling now takes care of making sure the plane's pixel rate doesn't exceed the spec appointed percentage of the cdclk frequency. Thus we can nuke skl_check_pipe_max_pixel_rate(). Reviewed-by: Juha-Pekka Heikkila Signed-off-by: Ville Syrjälä ---

[Intel-gfx] [PATCH v2 01/13] drm/i915: Add debugs to distingiush a cd2x update from a full cdclk pll update

2019-10-15 Thread Ville Syrjala
From: Ville Syrjälä To make the logs a bit less confusing let's toss in some debug prints to indicate whether the cdclk reprogramming is going to happen with a single pipe active or whether we need to turn all pipes off for the duration. Signed-off-by: Ville Syrjälä ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Small fixes before fixing MST (rev2)

2019-10-15 Thread Patchwork
== Series Details == Series: Small fixes before fixing MST (rev2) URL : https://patchwork.freedesktop.org/series/67883/ State : warning == Summary == $ dim checkpatch origin/drm-tip dd2c2adfc049 drm/i915: simplify setting of ddi_io_power_domain 7d4e878c74b2 drm/i915: fix port checks for MST

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Introduce Jasper Lake PCH (rev3)

2019-10-15 Thread Matt Roper
On Tue, Oct 15, 2019 at 07:42:03PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Introduce Jasper Lake PCH (rev3) > URL : https://patchwork.freedesktop.org/series/67992/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_7098 -> Patchwork_14817 >

[Intel-gfx] ✗ Fi.CI.BUILD: failure for series starting with [01/11] drm/i915/tgl: Add IS_TGL_REVID

2019-10-15 Thread Patchwork
== Series Details == Series: series starting with [01/11] drm/i915/tgl: Add IS_TGL_REVID URL : https://patchwork.freedesktop.org/series/68037/ State : failure == Summary == CALLscripts/checksyscalls.sh CALLscripts/atomic/check-atomics.sh DESCEND objtool CHK

Re: [Intel-gfx] [PATCH v3 v2 2/5] drm/i915: fix port checks for MST support on gen >= 11

2019-10-15 Thread Ville Syrjälä
On Tue, Oct 15, 2019 at 09:40:26AM -0700, Lucas De Marchi wrote: > Both Ice Lake and Elkhart Lake (gen 11) support MST on all external > connections except DDI A. Tiger Lake (gen 12) supports on all external > connections. > > Move the check to happen inside intel_dp_mst_encoder_init() and add >

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/ehl: Don't forget to set TC long detect function

2019-10-15 Thread Patchwork
== Series Details == Series: drm/i915/ehl: Don't forget to set TC long detect function URL : https://patchwork.freedesktop.org/series/68038/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7098 -> Patchwork_14816 Summary

Re: [Intel-gfx] [PATCH] drm/i915: Flush tasklet submission before sleeping on i915_request_wait

2019-10-15 Thread Tvrtko Ursulin
On 15/10/2019 14:26, Chris Wilson wrote: If the system is being slow and userspace is racing ahead of the GPU and finds itself waiting for the GPU to catch up, before the process sleeps give the tasklet a kick, bypassing ksoftirqd. If the system is overloaded, then ksoftirqd may be delayed

Re: [Intel-gfx] [PATCH 08/11] drm/i915/tgl: Wa_1409600907

2019-10-15 Thread Chris Wilson
Quoting Mika Kuoppala (2019-10-15 16:44:46) > To avoid possible hang, we need to add depth stall if we flush the > depth cache. > > Signed-off-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/gt/intel_lrc.c | 4 > 1 file changed, 4 insertions(+) > > diff --git

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Flush tasklet submission before sleeping on i915_request_wait

2019-10-15 Thread Patchwork
== Series Details == Series: drm/i915: Flush tasklet submission before sleeping on i915_request_wait URL : https://patchwork.freedesktop.org/series/68024/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7096 -> Patchwork_14811

[Intel-gfx] [PATCH v3] drm/i915: Introduce Jasper Lake PCH

2019-10-15 Thread Matt Roper
The Jasper Lake PCH follows ICP/TGP's south display behavior and is identical to MCC graphics-wise except that it does not use the unusual (port C -> TC1) pin mapping that MCC does. Also, it turns out the extra PCH ID that we had previously thought was a form of MCC is actually a second ID for

[Intel-gfx] [PATCH v3 v2 1/5] drm/i915: simplify setting of ddi_io_power_domain

2019-10-15 Thread Lucas De Marchi
Instead of the ever growing switch, just compute the ddi io power domain based on the port number. Signed-off-by: Lucas De Marchi Reviewed-by: José Roberto de Souza Link: https://patchwork.freedesktop.org/patch/msgid/20191011010907.103309-2-lucas.demar...@intel.com ---

[Intel-gfx] [PATCH v3 v2 0/5] Small fixes before fixing MST

2019-10-15 Thread Lucas De Marchi
https://patchwork.freedesktop.org/series/67883/ v2: - remove "drm/i915: cleanup unused returns on DP-MST": we should actually care more about the error handling here - left for later - handle other comments on the series Lucas De Marchi (5): drm/i915: simplify setting of

Re: [Intel-gfx] Using Intel GPU "TearFree" option changes my detected screens / edid information

2019-10-15 Thread Chris Wilson
Quoting Seba Kerckhof (2019-10-15 15:37:50) > I was experiencing tearing on my Debian system. I read about the intel driver > "TearFree" option and configured it as explained here: https:// > wiki.archlinux.org/index.php/Intel_graphics#Tearing > > While it does seem to help with the tearing, it

[Intel-gfx] ✓ Fi.CI.BAT: success for Refactor Gen11+ SAGV support

2019-10-15 Thread Patchwork
== Series Details == Series: Refactor Gen11+ SAGV support URL : https://patchwork.freedesktop.org/series/68028/ State : success == Summary == CI Bug Log - changes from CI_DRM_7096 -> Patchwork_14812 Summary --- **SUCCESS** No

[Intel-gfx] [PATCH v3 v2 2/5] drm/i915: fix port checks for MST support on gen >= 11

2019-10-15 Thread Lucas De Marchi
Both Ice Lake and Elkhart Lake (gen 11) support MST on all external connections except DDI A. Tiger Lake (gen 12) supports on all external connections. Move the check to happen inside intel_dp_mst_encoder_init() and add specific platform checks. v2: Replace != with == checks for ports on gen <

[Intel-gfx] [PATCH v3 v2 4/5] drm/i915: add pipe id/name to pipe mismatch logs

2019-10-15 Thread Lucas De Marchi
This way it's easier to figure out what didn't match when we have multiple pipes enabled. v2: pass drm_crtc and use the more common [CRTC:%d:%s] format (Ville) Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_display.c | 34 +++- 1 file changed, 19

[Intel-gfx] [PATCH v3 v2 3/5] drm/i915: remove extra new line on pipe_config mismatch

2019-10-15 Thread Lucas De Marchi
The new line is already added by pipe_config_mismatch(), so the callers shouldn't add it. Signed-off-by: Lucas De Marchi Reviewed-by: Ville Syrjälä Link: https://patchwork.freedesktop.org/patch/msgid/20191011010907.103309-5-lucas.demar...@intel.com ---

[Intel-gfx] [PATCH v3 v2 5/5] drm/i915: prettify MST debug message

2019-10-15 Thread Lucas De Marchi
s/?/:/ so it gets correctly colored by dmesg. Signed-off-by: Lucas De Marchi Reviewed-by: Ville Syrjälä Link: https://patchwork.freedesktop.org/patch/msgid/20191011010907.103309-7-lucas.demar...@intel.com --- drivers/gpu/drm/i915/display/intel_dp.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [Intel-gfx] [PATCH v3] drm/i915: Introduce Jasper Lake PCH

2019-10-15 Thread Vivek Kasireddy
On Tue, 15 Oct 2019 09:28:54 -0700 Matt Roper wrote: > The Jasper Lake PCH follows ICP/TGP's south display behavior and is > identical to MCC graphics-wise except that it does not use the unusual > (port C -> TC1) pin mapping that MCC does. > > Also, it turns out the extra PCH ID that we had

Re: [Intel-gfx] [PATCH 3/4] [v5] drm/i915/color: Extract icl_read_luts()

2019-10-15 Thread Ville Syrjälä
On Tue, Oct 15, 2019 at 07:34:00PM +0530, Sharma, Swati2 wrote: > On 15-Oct-19 6:04 PM, Ville Syrjälä wrote: > > On Thu, Oct 10, 2019 at 04:20:04PM +0530, Sharma, Swati2 wrote: > >> On 09-Oct-19 7:46 PM, Ville Syrjälä wrote: > >>> On Wed, Oct 09, 2019 at 12:25:41PM +0530, Swati Sharma wrote: >

Re: [Intel-gfx] [PATCH] drm/i915/icl: Wa_1607087056

2019-10-15 Thread Chris Wilson
Quoting Mika Kuoppala (2019-10-15 16:44:11) > Avoid possible hang in tsg,vfe units by keeping > l3 clocks runnings. > > Signed-off-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 + > drivers/gpu/drm/i915/i915_reg.h | 2 ++ > 2 files changed, 7

Re: [Intel-gfx] [PATCH 05/11] drm/i915/tgl: Keep FF dop clock enabled for A0

2019-10-15 Thread Chris Wilson
Quoting Mika Kuoppala (2019-10-15 16:44:43) > To ensure correct state data for compute workloads, we > need to keep the ff dop clock enabled. > > References: HSDES#1606700617 > Signed-off-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/gt/intel_workarounds.c | 9 - >

Re: [Intel-gfx] [PATCH 11/11] drm/i915/tgl: Wa_1607138340

2019-10-15 Thread Chris Wilson
Quoting Mika Kuoppala (2019-10-15 16:44:49) > Avoid possible cs hang with semaphores by disabling > lite restore. > > Signed-off-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/gt/intel_lrc.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Move the cursor rotation handling into intel_cursor_check_surface()

2019-10-15 Thread Patchwork
== Series Details == Series: drm/i915: Move the cursor rotation handling into intel_cursor_check_surface() URL : https://patchwork.freedesktop.org/series/68035/ State : success == Summary == CI Bug Log - changes from CI_DRM_7098 -> Patchwork_14813

[Intel-gfx] [PATCH] drm/i915: Move the cursor rotation handling into intel_cursor_check_surface()

2019-10-15 Thread Ville Syrjala
From: Ville Syrjälä Unlike other planes the cursor currently handles 180 degree rotation adjustment during the hardware programming phase. Let's move that stuff into intel_cursor_check_surface() to match how we do things with other plane types. And while at we'll plop in the final src x/y

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Refactor Gen11+ SAGV support

2019-10-15 Thread Patchwork
== Series Details == Series: Refactor Gen11+ SAGV support URL : https://patchwork.freedesktop.org/series/68028/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.6.0 Commit: drm/i915: Refactor intel_can_enable_sagv - +drivers/gpu/drm/i915/intel_pm.c:3753:6: warning:

Re: [Intel-gfx] [PATCH 07/11] drm/i915/tgl: Wa_1409170338

2019-10-15 Thread Chris Wilson
Quoting Mika Kuoppala (2019-10-15 16:44:45) > Avoid possible hang in tsg,vfe units by keeping > l3 clocks runnings. > > Signed-off-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/gt/intel_workarounds.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git

Re: [Intel-gfx] [PATCH 06/11] drm/i915/tgl: Wa_1409420604

2019-10-15 Thread Chris Wilson
Quoting Mika Kuoppala (2019-10-15 16:44:44) > Avoid possible hang in CPSS unit. > > Signed-off-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 + > drivers/gpu/drm/i915/i915_reg.h | 3 +++ > 2 files changed, 8 insertions(+) > > diff --git

Re: [Intel-gfx] [PATCH 01/11] drm/i915/tgl: Add IS_TGL_REVID

2019-10-15 Thread Chris Wilson
Quoting Mika Kuoppala (2019-10-15 16:44:39) > We are going to need this macro on limiting > the workaround scope. > > Signed-off-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/i915_drv.h | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [PATCH] drm/i915/ehl: Don't forget to set TC long detect function

2019-10-15 Thread Matt Roper
Since EHL's MCC PCH reuses one of the TC pins we need to supply a TC long detect function when handling the interrupts. Fixes: 53448aed7b80 ("drm/i915/ehl: Port C's hotplug interrupt is associated with TC1 bits") Reported-by: kbuild test robot Reported-by: Dan Carpenter Cc: Vivek Kasireddy

Re: [Intel-gfx] [PATCH V3 1/7] mdev: class id support

2019-10-15 Thread Alex Williamson
On Fri, 11 Oct 2019 16:15:51 +0800 Jason Wang wrote: > diff --git a/drivers/vfio/mdev/mdev_core.c b/drivers/vfio/mdev/mdev_core.c > index b558d4cfd082..724e9b9841d8 100644 > --- a/drivers/vfio/mdev/mdev_core.c > +++ b/drivers/vfio/mdev/mdev_core.c > @@ -45,6 +45,12 @@ void

[Intel-gfx] Using Intel GPU "TearFree" option changes my detected screens / edid information

2019-10-15 Thread Seba Kerckhof
I was experiencing tearing on my Debian system. I read about the intel driver "TearFree" option and configured it as explained here: https://wiki.archlinux.org/index.php/Intel_graphics#Tearing While it does seem to help with the tearing, it changes my detected screens. By this I mean if I run

[Intel-gfx] [PATCH 05/11] drm/i915/tgl: Keep FF dop clock enabled for A0

2019-10-15 Thread Mika Kuoppala
To ensure correct state data for compute workloads, we need to keep the ff dop clock enabled. References: HSDES#1606700617 Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 9 - drivers/gpu/drm/i915/i915_reg.h | 1 + 2 files changed, 9

[Intel-gfx] [PATCH 08/11] drm/i915/tgl: Wa_1409600907

2019-10-15 Thread Mika Kuoppala
To avoid possible hang, we need to add depth stall if we flush the depth cache. Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/gt/intel_lrc.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c index

[Intel-gfx] [PATCH] drm/i915/icl: Wa_1607087056

2019-10-15 Thread Mika Kuoppala
Avoid possible hang in tsg,vfe units by keeping l3 clocks runnings. Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 + drivers/gpu/drm/i915/i915_reg.h | 2 ++ 2 files changed, 7 insertions(+) diff --git

[Intel-gfx] [PATCH 04/11] drm/i915/tgl: Add extra hdc flush workaround

2019-10-15 Thread Mika Kuoppala
In order to ensure constant caches are invalidated properly with a0, we need extra hdc flush after invalidation. v2: use IS_TGL_REVID (Chris) References: HSDES#1604544889 Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/gt/intel_lrc.c | 20 1 file changed, 20

[Intel-gfx] [PATCH 02/11] drm/i915/tgl: Include ro parts of l3 to invalidate

2019-10-15 Thread Mika Kuoppala
Aim for completeness and invalidate also the ro parts in l3 cache. This might allow to get rid of the preparser disable/enable workaround on invalidation path. Cc: Chris Wilson Signed-off-by: Mika Kuoppala Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/gt/intel_gpu_commands.h | 1 +

[Intel-gfx] [PATCH 06/11] drm/i915/tgl: Wa_1409420604

2019-10-15 Thread Mika Kuoppala
Avoid possible hang in CPSS unit. Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 + drivers/gpu/drm/i915/i915_reg.h | 3 +++ 2 files changed, 8 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c

  1   2   3   >