[Intel-gfx] [PATCH V6 0/6] mdev based hardware virtio offloading support

2019-10-30 Thread Jason Wang
Hi all: There are hardwares that can do virtio datapath offloading while having its own control path. This path tries to implement a mdev based unified API to support using kernel virtio driver to drive those devices. This is done by introducing a new mdev transport for virtio (virtio_mdev) and

Re: [Intel-gfx] [RFC 0/3] Display uncore

2019-10-30 Thread Jani Nikula
On Tue, 29 Oct 2019, Daniele Ceraolo Spurio wrote: > On 10/29/19 2:23 AM, Jani Nikula wrote: >> On Wed, 07 Aug 2019, Daniele Ceraolo Spurio >> wrote: >>> I've been trying to identify MMIO ranges to clearly define what belongs >>> to display_uncore to do a check on access, but there are lots of

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915/guc: Skip suspend/resume GuC action on platforms w/o GuC submission (rev2)

2019-10-30 Thread Patchwork
== Series Details == Series: drm/i915/guc: Skip suspend/resume GuC action on platforms w/o GuC submission (rev2) URL : https://patchwork.freedesktop.org/series/68685/ State : failure == Summary == Applying: drm/i915/guc: Skip suspend/resume GuC action on platforms w/o GuC submission Using

Re: [Intel-gfx] [CI 12/12] drm/i915: Complete plane hw and uapi split, v2.

2019-10-30 Thread Maarten Lankhorst
Op 29-10-2019 om 19:34 schreef Ville Syrjälä: > On Tue, Oct 29, 2019 at 08:22:29AM +0100, Maarten Lankhorst wrote: >> Splitting plane state is easier than splitting crtc_state, >> before plane check we copy the drm properties to hw so we can >> do the same in bigjoiner later on. >> >> We copy the

[Intel-gfx] Unexpected screen flicker during i915 initialization

2019-10-30 Thread Chris Chiu
Hi guys, We have 2 laptops, ASUS Z406MA and Acer TravelMate B118, both powered by the same Intel N5000 GemniLake CPU. On the Acer laptop, the panel will blink once during boot which never happens on the ASUS laptop. It caught my attention and I find the difference between them but I need help

[Intel-gfx] [PATCH] drm/i915/gt: Always track callers to intel_rps_mark_interactive()

2019-10-30 Thread Chris Wilson
During startup, we may find ourselves in an interesting position where we haven't fully enabled RPS before the display starts trying to use it. This may lead to an imbalance in our "interactive" counter: <3>[4.813326] intel_rps_mark_interactive:652 GEM_BUG_ON(!rps->power.interactive) <4>[

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: Always track callers to intel_rps_mark_interactive() (rev2)

2019-10-30 Thread Patchwork
== Series Details == Series: drm/i915/gt: Always track callers to intel_rps_mark_interactive() (rev2) URL : https://patchwork.freedesktop.org/series/68764/ State : warning == Summary == $ dim checkpatch origin/drm-tip 0802e1c1452f drm/i915/gt: Always track callers to

[Intel-gfx] [PATCH V6 5/6] virtio: introduce a mdev based transport

2019-10-30 Thread Jason Wang
This patch introduces a new mdev transport for virtio. This is used to use kernel virtio driver to drive the mediated device that is capable of populating virtqueue directly. A new virtio-mdev driver will be registered to the mdev bus, when a new virtio-mdev device is probed, it will register the

[Intel-gfx] [PATCH 3/3] drm/i915: Remove i915->kernel_context

2019-10-30 Thread Chris Wilson
Allocate only an internal intel_context for the kernel_context, forgoing a global GEM context for internal use as we only require a separate address space (for our own protection). Now having weaned GT from requiring ce->gem_context, we can stop referencing it entirely. This also means we no

[Intel-gfx] [PATCH 2/3] drm/i915: Push the use-semaphore marker onto the intel_context

2019-10-30 Thread Chris Wilson
Instead of rummaging through the intel_context to peek at the GEM context in the middle of request submission to decide whether to use semaphores, store that information on the intel_context itself. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 52

[Intel-gfx] [PATCH 1/3] drm/i915: Drop GEM context as a direct link from i915_request

2019-10-30 Thread Chris Wilson
Keep the intel_context as being the primary state for i915_request, with the GEM context a backpointer from the low level state for the rarer cases we need client information. Our goal is to remove such references to clients from the backend, and leave the HW submission agnostic to client

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Nuke 'mode' argument to intel_get_load_detect_pipe()

2019-10-30 Thread Patchwork
== Series Details == Series: drm/i915: Nuke 'mode' argument to intel_get_load_detect_pipe() URL : https://patchwork.freedesktop.org/series/68717/ State : success == Summary == CI Bug Log - changes from CI_DRM_7211_full -> Patchwork_15050_full

[Intel-gfx] [PATCH V6 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework

2019-10-30 Thread Jason Wang
This sample driver creates mdev device that simulate virtio net device over virtio mdev transport. The device is implemented through vringh and workqueue. A device specific dma ops is to make sure HVA is used directly as the IOVA. This should be sufficient for kernel virtio driver to work. Only

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Always track callers to intel_rps_mark_interactive() (rev2)

2019-10-30 Thread Patchwork
== Series Details == Series: drm/i915/gt: Always track callers to intel_rps_mark_interactive() (rev2) URL : https://patchwork.freedesktop.org/series/68764/ State : success == Summary == CI Bug Log - changes from CI_DRM_7223 -> Patchwork_15071

Re: [Intel-gfx] [PATCH] drm/i915/guc: Skip suspend/resume GuC action on platforms w/o GuC submission

2019-10-30 Thread Tomas Janousek
On Tue, Oct 29, 2019 at 01:33:22PM +0100, Michal Wajdeczko wrote: > On Mon, 28 Oct 2019 22:25:27 +0100, wrote: > > +* we do not need to suspend the GuC but we do need to disable the > > +* GuC communication on suspend. > > +*/ > > + if (!guc->submission_supported) > > Using

[Intel-gfx] ✓ Fi.CI.BAT: success for mdev based hardware virtio offloading support (rev7)

2019-10-30 Thread Patchwork
== Series Details == Series: mdev based hardware virtio offloading support (rev7) URL : https://patchwork.freedesktop.org/series/66989/ State : success == Summary == CI Bug Log - changes from CI_DRM_7222 -> Patchwork_15067 Summary ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: Always track callers to intel_rps_mark_interactive()

2019-10-30 Thread Patchwork
== Series Details == Series: drm/i915/gt: Always track callers to intel_rps_mark_interactive() URL : https://patchwork.freedesktop.org/series/68764/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7222 -> Patchwork_15069

Re: [Intel-gfx] [CI 04/12] drm/i915: Perform manual conversions for crtc uapi/hw split, v2.

2019-10-30 Thread Maarten Lankhorst
Op 29-10-2019 om 14:23 schreef Ville Syrjälä: > On Tue, Oct 29, 2019 at 08:22:21AM +0100, Maarten Lankhorst wrote: >> intel_get_load_detect_pipe() needs to set uapi active, >> uapi enable is set by the call to drm_atomic_set_mode_for_crtc(), >> so we can remove it. >> >>

Re: [Intel-gfx] Unexpected screen flicker during i915 initialization

2019-10-30 Thread Chris Chiu
On Wed, Oct 30, 2019 at 6:25 PM Chris Chiu wrote: > > Hi guys, > We have 2 laptops, ASUS Z406MA and Acer TravelMate B118, both > powered by the same Intel N5000 GemniLake CPU. On the Acer laptop, the > panel will blink once during boot which never happens on the ASUS > laptop. It caught my

[Intel-gfx] [PATCH V6 4/6] mdev: introduce virtio device and its device ops

2019-10-30 Thread Jason Wang
This patch implements basic support for mdev driver that supports virtio transport for kernel virtio driver. Signed-off-by: Jason Wang --- drivers/vfio/mdev/mdev_core.c| 20 drivers/vfio/mdev/mdev_private.h | 2 + include/linux/mdev.h | 6 ++

Re: [Intel-gfx] [PULL] topic/mst-suspend-resume-reprobe-2019-10-29-2

2019-10-30 Thread Daniel Vetter
On Tue, Oct 29, 2019 at 11:06 PM Lyude Paul wrote: > > topic/mst-suspend-resume-reprobe-2019-10-29-2: > UAPI Changes: > > Cross-subsystem Changes: > > Core Changes: > * Handle UP requests asynchronously in the DP MST helpers, fixing > hotplug notifications and allowing us to implement

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/5] drm/i915/gt: Always track callers to intel_rps_mark_interactive()

2019-10-30 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915/gt: Always track callers to intel_rps_mark_interactive() URL : https://patchwork.freedesktop.org/series/68770/ State : success == Summary == CI Bug Log - changes from CI_DRM_7223 -> Patchwork_15072

[Intel-gfx] [PATCH V6 1/6] mdev: class id support

2019-10-30 Thread Jason Wang
Mdev bus only supports vfio driver right now, so it doesn't implement match method. But in the future, we may add drivers other than vfio, the first driver could be virtio-mdev. This means we need to add device class id support in bus match method to pair the mdev device and mdev driver correctly.

[Intel-gfx] [PATCH V6 2/6] modpost: add support for mdev class id

2019-10-30 Thread Jason Wang
Add support to parse mdev class id table. Reviewed-by: Parav Pandit Signed-off-by: Jason Wang --- drivers/vfio/mdev/vfio_mdev.c | 2 ++ scripts/mod/devicetable-offsets.c | 3 +++ scripts/mod/file2alias.c | 11 +++ 3 files changed, 16 insertions(+) diff --git

[Intel-gfx] [PATCH V6 3/6] mdev: introduce device specific ops

2019-10-30 Thread Jason Wang
Currently, except for the create and remove, the rest of mdev_parent_ops is designed for vfio-mdev driver only and may not help for kernel mdev driver. With the help of class id, this patch introduces device specific callbacks inside mdev_device structure. This allows different set of callback to

Re: [Intel-gfx] [PATCH V5 4/6] mdev: introduce virtio device and its device ops

2019-10-30 Thread Zhu Lingshan
On 10/29/2019 6:42 PM, Jason Wang wrote: On 2019/10/29 下午3:42, Zhu Lingshan wrote: +    void (*set_status)(struct mdev_device *mdev, u8 status); Hi Jason Is it possible to make set_status() return an u8 or bool, because this may fail in real hardware. Without a returned code, I am not sure

Re: [Intel-gfx] [CI 01/12] drm/i915: Introduce intel_atomic_get_plane_state_after_check(), v2.

2019-10-30 Thread Maarten Lankhorst
Op 29-10-2019 om 19:35 schreef Ville Syrjälä: > On Tue, Oct 29, 2019 at 08:22:18AM +0100, Maarten Lankhorst wrote: >> Use this in all the places where we try to acquire planes after the planes >> atomic_check(). >> >> In case of intel_modeset_all_pipes() this is not yet done after atomic_check, >>

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/3] drm/i915: Drop GEM context as a direct link from i915_request

2019-10-30 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Drop GEM context as a direct link from i915_request URL : https://patchwork.freedesktop.org/series/68769/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7223 -> Patchwork_15070

Re: [Intel-gfx] [PATCH v2 2/5] drm/dsi: add missing DSI data types

2019-10-30 Thread Kulkarni, Vandita
> -Original Message- > From: Jani Nikula > Sent: Monday, October 28, 2019 8:31 PM > To: dri-de...@lists.freedesktop.org > Cc: intel-gfx@lists.freedesktop.org; Nikula, Jani ; > Kulkarni, Vandita > Subject: [PATCH v2 2/5] drm/dsi: add missing DSI data types > > Add execute queue and

[Intel-gfx] [PATCH] drm/i915/gt: Always track callers to intel_rps_mark_interactive()

2019-10-30 Thread Chris Wilson
During startup, we may find ourselves in an interesting position where we haven't fully enabled RPS before the display starts trying to use it. This may lead to an imbalance in our "interactive" counter: <3>[4.813326] intel_rps_mark_interactive:652 GEM_BUG_ON(!rps->power.interactive) <4>[

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: Always track callers to intel_rps_mark_interactive()

2019-10-30 Thread Patchwork
== Series Details == Series: drm/i915/gt: Always track callers to intel_rps_mark_interactive() URL : https://patchwork.freedesktop.org/series/68764/ State : warning == Summary == $ dim checkpatch origin/drm-tip b642c35d72bb drm/i915/gt: Always track callers to intel_rps_mark_interactive()

[Intel-gfx] [PATCH 1/5] drm/i915/gt: Always track callers to intel_rps_mark_interactive()

2019-10-30 Thread Chris Wilson
During startup, we may find ourselves in an interesting position where we haven't fully enabled RPS before the display starts trying to use it. This may lead to an imbalance in our "interactive" counter: <3>[4.813326] intel_rps_mark_interactive:652 GEM_BUG_ON(!rps->power.interactive) <4>[

[Intel-gfx] [PATCH 4/5] drm/i915/gt: Move user_forcewake application to GT

2019-10-30 Thread Chris Wilson
We already track the debugfs user_forcewake on the GT, so it is natural to pull the suspend/resume handling under gt/ as well. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gem/i915_gem_pm.c | 22 -- drivers/gpu/drm/i915/gt/intel_gt_pm.c | 22 ++

[Intel-gfx] [PATCH 5/5] drm/i915: Defer rc6 shutdown to suspend_late

2019-10-30 Thread Chris Wilson
Currently we shutdown rc6 during i915_gem_resume() but this is called during the preparation phase (i915_drm_prepare) for all suspend paths, but we only want to shutdown rc6 for S3+. Move the actual shutdown to i915_gem_suspend_late(). We then need to differentiate between suspend targets, to

[Intel-gfx] [PATCH 2/5] drm/i915/gt: Call intel_gt_sanitize() directly

2019-10-30 Thread Chris Wilson
Assume all responsibility for operating on the HW to sanitize the GT state upon load/resume in intel_gt_sanitize() itself. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gem/i915_gem_pm.c| 5 --- drivers/gpu/drm/i915/gt/intel_gt.c| 6 ++-

[Intel-gfx] [PATCH 3/5] drm/i915/gem: Leave reloading kernel context on resume to GT

2019-10-30 Thread Chris Wilson
As we already do reload the kernel context in intel_gt_resume, repeating that action inside i915_gem_resume() as well is redundant. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gem/i915_gem_pm.c | 30 -- 1 file changed, 30 deletions(-) diff --git

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm/i915/gt: Always track callers to intel_rps_mark_interactive()

2019-10-30 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915/gt: Always track callers to intel_rps_mark_interactive() URL : https://patchwork.freedesktop.org/series/68770/ State : warning == Summary == $ dim checkpatch origin/drm-tip 62347effd8e0 drm/i915/gt: Always track callers to

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/dp: Increase link status size

2019-10-30 Thread Patchwork
== Series Details == Series: drm/dp: Increase link status size URL : https://patchwork.freedesktop.org/series/68721/ State : success == Summary == CI Bug Log - changes from CI_DRM_7211_full -> Patchwork_15051_full Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for mdev based hardware virtio offloading support (rev7)

2019-10-30 Thread Patchwork
== Series Details == Series: mdev based hardware virtio offloading support (rev7) URL : https://patchwork.freedesktop.org/series/66989/ State : warning == Summary == $ dim checkpatch origin/drm-tip a54b4e12fd9e mdev: class id support 91d56ca65904 modpost: add support for mdev class id

Re: [Intel-gfx] [PATCH] drm/i915/lmem: add the fake lmem region

2019-10-30 Thread Chris Wilson
Quoting Matthew Auld (2019-10-29 16:51:34) > diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c > index 21273b516dbe..db1736d95651 100644 > --- a/drivers/gpu/drm/i915/i915_drv.c > +++ b/drivers/gpu/drm/i915/i915_drv.c > @@ -1483,6 +1483,21 @@ int

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/perf: ensure selftests select valid format

2019-10-30 Thread Patchwork
== Series Details == Series: drm/i915/perf: ensure selftests select valid format URL : https://patchwork.freedesktop.org/series/68723/ State : success == Summary == CI Bug Log - changes from CI_DRM_7213_full -> Patchwork_15052_full Summary

[Intel-gfx] [PATCH] drm/i915: Remove i915->kernel_context

2019-10-30 Thread Chris Wilson
Allocate only an internal intel_context for the kernel_context, forgoing a global GEM context for internal use as we only require a separate address space (for our own protection). Now having weaned GT from requiring ce->gem_context, we can stop referencing it entirely. This also means we no

Re: [Intel-gfx] pcm_lock deadlock

2019-10-30 Thread Takashi Iwai
On Wed, 30 Oct 2019 14:50:09 +0100, Ville Syrjälä wrote: > > On Tue, Oct 29, 2019 at 09:52:57PM +0100, Takashi Iwai wrote: > > On Tue, 29 Oct 2019 20:10:50 +0100, > > From: Takashi Iwai > > Subject: [PATCH] ALSA: hda - Fix mutex deadlock in HDMI codec driver > > > > The commit ade49db337a9

Re: [Intel-gfx] [PATCH] drm/i915: Stop frobbing crtc->base.mode

2019-10-30 Thread Maarten Lankhorst
Op 29-10-2019 om 15:55 schreef Ville Syrjala: > From: Ville Syrjälä > > The core no longer uses drm_crtc_state::mode with atomic drivers, > so let's stop frobbing it in the driver. For the user mode readout > we'll just use an on stack mode. > > Signed-off-by: Ville Syrjälä > --- >

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,01/12] drm/i915: Handle a few more cases for crtc hw/uapi split, v3.

2019-10-30 Thread Patchwork
== Series Details == Series: series starting with [CI,01/12] drm/i915: Handle a few more cases for crtc hw/uapi split, v3. URL : https://patchwork.freedesktop.org/series/68775/ State : success == Summary == CI Bug Log - changes from CI_DRM_7224 -> Patchwork_15074

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Avoid HPD poll detect triggering a new detect cycle (rev2)

2019-10-30 Thread Imre Deak
On Wed, Oct 30, 2019 at 12:06:53AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Avoid HPD poll detect triggering a new detect cycle (rev2) > URL : https://patchwork.freedesktop.org/series/68644/ > State : success Thanks for the review, pushed to -dinq. > > == Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,01/12] drm/i915: Handle a few more cases for crtc hw/uapi split, v3.

2019-10-30 Thread Patchwork
== Series Details == Series: series starting with [CI,01/12] drm/i915: Handle a few more cases for crtc hw/uapi split, v3. URL : https://patchwork.freedesktop.org/series/68775/ State : warning == Summary == $ dim checkpatch origin/drm-tip 82ecaad3eafe drm/i915: Handle a few more cases for

Re: [Intel-gfx] [CI 11/12] drm/i915: Perform automated conversions for plane uapi/hw split, base -> uapi.

2019-10-30 Thread Maarten Lankhorst
Op 29-10-2019 om 16:43 schreef Ville Syrjälä: > On Tue, Oct 29, 2019 at 08:22:28AM +0100, Maarten Lankhorst wrote: >> Split up plane_state->base to uapi. This is done using the following patch, >> ran after the previous commit that splits out any hw references: >> >> @@ >> struct intel_plane_state

Re: [Intel-gfx] [PATCH v2] drm/i915: Avoid HPD poll detect triggering a new detect cycle

2019-10-30 Thread Ville Syrjälä
On Mon, Oct 28, 2019 at 08:15:17PM +0200, Imre Deak wrote: > For the HPD interrupt functionality the HW depends on power wells in the > display core domain to be on. Accordingly when enabling these power > wells the HPD polling logic will force an HPD detection cycle to account > for hotplug

Re: [Intel-gfx] [PATCH] drm/i915: Nuke 'mode' argument to intel_get_load_detect_pipe()

2019-10-30 Thread Jani Nikula
On Tue, 29 Oct 2019, Ville Syrjala wrote: > From: Ville Syrjälä > > We always pass mode==NULL to intel_get_load_detect_pipe(). Remove > the pointless function argument. > > Signed-off-by: Ville Syrjälä Reviewed-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_crt.c | 2 +- >

Re: [Intel-gfx] [PATCH 7/9] drm/i915: Reject ckey+fp16 on skl+

2019-10-30 Thread Shankar, Uma
>> >>-Original Message- >> >>From: Intel-gfx On Behalf >> >>Of Ville Syrjala >> >>Sent: Tuesday, October 8, 2019 9:45 PM >> >>To: intel-gfx@lists.freedesktop.org >> >>Subject: [Intel-gfx] [PATCH 7/9] drm/i915: Reject ckey+fp16 on skl+ >> >> >> >>From: Ville Syrjälä >> >> >> >>According

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Stop frobbing crtc->base.mode

2019-10-30 Thread Patchwork
== Series Details == Series: drm/i915: Stop frobbing crtc->base.mode URL : https://patchwork.freedesktop.org/series/68725/ State : success == Summary == CI Bug Log - changes from CI_DRM_7215_full -> Patchwork_15054_full Summary ---

Re: [Intel-gfx] pcm_lock deadlock

2019-10-30 Thread Ville Syrjälä
On Tue, Oct 29, 2019 at 09:52:57PM +0100, Takashi Iwai wrote: > On Tue, 29 Oct 2019 20:10:50 +0100, > From: Takashi Iwai > Subject: [PATCH] ALSA: hda - Fix mutex deadlock in HDMI codec driver > > The commit ade49db337a9 ("ALSA: hda/hdmi - Allow audio component for > AMD/ATI and Nvidia HDMI")

[Intel-gfx] [CI 04/12] drm/i915: Perform automated conversions for crtc uapi/hw split, base -> hw.

2019-10-30 Thread Maarten Lankhorst
Split up crtc_state->base to hw where appropriate. This is done using the following patch: @@ struct intel_crtc_state *T; identifier x =~ "^(active|enable|degamma_lut|gamma_lut|ctm|mode|adjusted_mode)$"; @@ -T->base.x +T->hw.x @@ struct drm_crtc_state *T; identifier x =~

[Intel-gfx] [CI 07/12] drm/i915: Add aliases for uapi and hw to plane_state

2019-10-30 Thread Maarten Lankhorst
Prepare to split up hw and uapi machinally, by adding a uapi and hw alias. We will remove the base in a bit. This is a split from the original uapi/hw patch, which did it all in one go. Signed-off-by: Maarten Lankhorst --- .../gpu/drm/i915/display/intel_atomic_plane.c| 16

[Intel-gfx] [CI 09/12] drm/i915: Perform automated conversions for plane uapi/hw split, base -> hw.

2019-10-30 Thread Maarten Lankhorst
Split up plane_state->base to hw. This is done using the following patch: @@ struct intel_plane_state *T; identifier x =~ "^(crtc|fb|alpha|pixel_blend_mode|rotation|color_encoding|color_range)$"; @@ -T->base.x +T->hw.x Signed-off-by: Maarten Lankhorst Reviewed-by: Ville Syrjälä ---

[Intel-gfx] [CI 12/12] drm/i915: Remove special case slave handling during hw programming, v3.

2019-10-30 Thread Maarten Lankhorst
Now that we split plane_state which I didn't want to do yet, we can program the slave plane without requiring the master plane. This is useful for programming bigjoiner slave planes as well. We will no longer need the master's plane_state. Changes since v1: - set src/dst rectangles after

[Intel-gfx] [CI 03/12] drm/i915: Perform manual conversions for crtc uapi/hw split, v2.

2019-10-30 Thread Maarten Lankhorst
intel_get_load_detect_pipe() needs to set uapi active, uapi enable is set by the call to drm_atomic_set_mode_for_crtc(), so we can remove it. intel_pipe_config_compare() needs to look at hw state, but I didn't change spatch to look at it. It's easy enough to do manually. intel_atomic_check()

[Intel-gfx] [CI 11/12] drm/i915: Complete plane hw and uapi split, v2.

2019-10-30 Thread Maarten Lankhorst
Splitting plane state is easier than splitting crtc_state, before plane check we copy the drm properties to hw so we can do the same in bigjoiner later on. We copy the state after we did all the modeset handling, but fortunately i915 seems to be split correctly and nothing during modeset looks at

[Intel-gfx] [CI 10/12] drm/i915: Perform automated conversions for plane uapi/hw split, base -> uapi.

2019-10-30 Thread Maarten Lankhorst
Split up plane_state->base to uapi. This is done using the following patch, ran after the previous commit that splits out any hw references: @@ struct intel_plane_state *T; identifier x; @@ -T->base.x +T->uapi.x @@ struct intel_plane_state *T; @@ -T->base +T->uapi Signed-off-by: Maarten

[Intel-gfx] [CI 08/12] drm/i915: Perform manual conversions for plane uapi/hw split, v2.

2019-10-30 Thread Maarten Lankhorst
get_crtc_from_states() is called before plane_state is copied to uapi, so use the uapi state there. intel_legacy_cursor_update() could probably get away with looking at the hw state, but for clarity always look at the uapi state. Changes since v1: - Convert entirety of intel_legacy_cursor_update

[Intel-gfx] [CI 06/12] drm/i915: Complete crtc hw/uapi split, v5.

2019-10-30 Thread Maarten Lankhorst
Now that we separated everything into uapi and hw, it's time to make the split definitive. Remove the union and make a copy of the hw state on modeset and fastset. Color blobs are copied in crtc atomic_check(), right before color management is checked. Changes since v1: - Copy all blobs

Re: [Intel-gfx] [PATCH 1/5] drm/i915/gt: Always track callers to intel_rps_mark_interactive()

2019-10-30 Thread Andi Shyti
Hi Chris, On Wed, Oct 30, 2019 at 10:38:23AM +, Chris Wilson wrote: > During startup, we may find ourselves in an interesting position where > we haven't fully enabled RPS before the display starts trying to use it. > This may lead to an imbalance in our "interactive" counter: yes, makes

Re: [Intel-gfx] [PATCH i-g-t] i915/gem_exec_suspend: Measure power consumption during suspend

2019-10-30 Thread Mika Kuoppala
Chris Wilson writes: > For this test, we need a laptop running on battery power so that we can > read the battery charge level before and after suspend. And then wait > long enough for a reliable measure. > > References: https://bugs.freedesktop.org/show_bug.cgi?id=111909 > Signed-off-by: Chris

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Drop GEM context as a direct link from i915_request (rev2)

2019-10-30 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Drop GEM context as a direct link from i915_request (rev2) URL : https://patchwork.freedesktop.org/series/68769/ State : success == Summary == CI Bug Log - changes from CI_DRM_7223 -> Patchwork_15073

Re: [Intel-gfx] [CI 01/12] drm/i915: Introduce intel_atomic_get_plane_state_after_check(), v2.

2019-10-30 Thread Ville Syrjälä
On Wed, Oct 30, 2019 at 10:17:52AM +0100, Maarten Lankhorst wrote: > Op 29-10-2019 om 19:35 schreef Ville Syrjälä: > > On Tue, Oct 29, 2019 at 08:22:18AM +0100, Maarten Lankhorst wrote: > >> Use this in all the places where we try to acquire planes after the planes > >> atomic_check(). > >> > >>

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,01/12] drm/i915: Handle a few more cases for crtc hw/uapi split, v3.

2019-10-30 Thread Patchwork
== Series Details == Series: series starting with [CI,01/12] drm/i915: Handle a few more cases for crtc hw/uapi split, v3. URL : https://patchwork.freedesktop.org/series/68775/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.6.0 Commit: drm/i915: Handle a few

Re: [Intel-gfx] Unexpected screen flicker during i915 initialization

2019-10-30 Thread Jani Nikula
On Wed, 30 Oct 2019, Chris Chiu wrote: > Hi guys, > We have 2 laptops, ASUS Z406MA and Acer TravelMate B118, both > powered by the same Intel N5000 GemniLake CPU. On the Acer laptop, the > panel will blink once during boot which never happens on the ASUS > laptop. It caught my attention and I

[Intel-gfx] [PATCH i-g-t] amdgpu/amd_basic: Restrict basic compute to only run on available compute rings

2019-10-30 Thread Chris Wilson
Some time ago amdgpu changed their ABI to reject unknown compute rings, so we should query the available set prior to execution. Signed-off-by: Chris Wilson --- tests/amdgpu/amd_basic.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/tests/amdgpu/amd_basic.c

Re: [Intel-gfx] [PATCH i-g-t] i915/gem_exec_suspend: Measure power consumption during suspend

2019-10-30 Thread Chris Wilson
Quoting Mika Kuoppala (2019-10-30 12:30:47) > Chris Wilson writes: > > > For this test, we need a laptop running on battery power so that we can > > read the battery charge level before and after suspend. And then wait > > long enough for a reliable measure. > > > > References:

[Intel-gfx] [CI 01/12] drm/i915: Handle a few more cases for crtc hw/uapi split, v3.

2019-10-30 Thread Maarten Lankhorst
We are still looking at drm_crtc_state in a few places, convert those to use intel_crtc_state instead. Changes since v1: - Move to before uapi/hw split. - Add hunks for intel_pm.c as well. Changes since v2: - Incorporate Ville's feedback. Signed-off-by: Maarten Lankhorst Reviewed-by: Matt Roper

[Intel-gfx] [CI 02/12] drm/i915: Add aliases for uapi and hw to crtc_state

2019-10-30 Thread Maarten Lankhorst
Prepare to split up hw and uapi machinally, by adding a uapi and hw alias. We will remove the base in a bit. This is a split from the original uapi/hw patch, which did it all in one go. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/display/intel_atomic.c | 8 --

Re: [Intel-gfx] [CI 10/12] drm/i915: Perform automated conversions for plane uapi/hw split, base -> uapi.

2019-10-30 Thread Ville Syrjälä
On Wed, Oct 30, 2019 at 03:26:55PM +0100, Maarten Lankhorst wrote: > Split up plane_state->base to uapi. This is done using the following patch, > ran after the previous commit that splits out any hw references: > > @@ > struct intel_plane_state *T; > identifier x; > @@ > -T->base.x > +T->uapi.x

Re: [Intel-gfx] [PATCH] drm/i915: Program LUT before intel_color_commit() if LUT was not previously set v2

2019-10-30 Thread Ville Syrjälä
On Mon, Oct 28, 2019 at 07:58:51PM +0100, Hans de Goede wrote: > Since commit 051a6d8d3ca0 ("drm/i915: Move LUT programming to happen after > vblank waits"), I am seeing an ugly colored flash of the first few display > lines on 2 Cherry Trail devices when the gamma table gets set for the first >

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/lmem: add the fake lmem region (rev2)

2019-10-30 Thread Patchwork
== Series Details == Series: drm/i915/lmem: add the fake lmem region (rev2) URL : https://patchwork.freedesktop.org/series/68733/ State : warning == Summary == $ dim checkpatch origin/drm-tip bfc4292da998 drm/i915/lmem: add the fake lmem region -:109: CHECK:PARENTHESIS_ALIGNMENT: Alignment

Re: [Intel-gfx] [CI 03/12] drm/i915: Perform manual conversions for crtc uapi/hw split, v2.

2019-10-30 Thread Maarten Lankhorst
Op 30-10-2019 om 18:03 schreef Ville Syrjälä: > On Wed, Oct 30, 2019 at 03:26:48PM +0100, Maarten Lankhorst wrote: >> intel_get_load_detect_pipe() needs to set uapi active, >> uapi enable is set by the call to drm_atomic_set_mode_for_crtc(), >> so we can remove it. >> >>

Re: [Intel-gfx] [PULL] topic/mst-suspend-resume-reprobe-2019-10-29-2

2019-10-30 Thread Daniel Vetter
On Wed, Oct 30, 2019 at 7:23 PM Lyude Paul wrote: > > On Wed, 2019-10-30 at 10:21 +0100, Daniel Vetter wrote: > > On Tue, Oct 29, 2019 at 11:06 PM Lyude Paul wrote: > > > topic/mst-suspend-resume-reprobe-2019-10-29-2: > > > UAPI Changes: > > > > > > Cross-subsystem Changes: > > > > > > Core

[Intel-gfx] [PATCH] drm/i915: Preload LUTs if the hw isn't currently using them

2019-10-30 Thread Ville Syrjala
From: Ville Syrjälä The LUTs are single buffered so in order to program them without tearing we'd have to do it during vblank (actually to be 100% effective it has to happen between start of vblank and frame start). We have no proper mechanism for that at the moment so we just defer loading them

Re: [Intel-gfx] [CI 08/12] drm/i915: Perform manual conversions for plane uapi/hw split, v2.

2019-10-30 Thread Ville Syrjälä
On Wed, Oct 30, 2019 at 03:26:53PM +0100, Maarten Lankhorst wrote: > get_crtc_from_states() is called before plane_state is copied to uapi, > so use the uapi state there. > > intel_legacy_cursor_update() could probably get away with looking at > the hw state, but for clarity always look at the

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/4] drm/i915/bios: use a flag for vbt hdmi level shift presence

2019-10-30 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/bios: use a flag for vbt hdmi level shift presence URL : https://patchwork.freedesktop.org/series/68729/ State : success == Summary == CI Bug Log - changes from CI_DRM_7218_full -> Patchwork_15056_full

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/5] drm/i915: Use drm_rect to simplify plane {crtc, src}_{x, y, w, h} printing

2019-10-30 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915: Use drm_rect to simplify plane {crtc, src}_{x, y, w, h} printing URL : https://patchwork.freedesktop.org/series/68728/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7216_full -> Patchwork_15055_full

[Intel-gfx] [RFC PATCH i-g-t v3] tests/gem_exec_reloc: Don't filter out invalid addresses

2019-10-30 Thread Janusz Krzysztofik
Commit a355b2d6eb42 ("igt/gem_exec_reloc: Filter out unavailable addresses for !ppgtt") introduced filtering of addresses possibly occupied by other users of shared GTT. Unfortunately, that filtering doesn't distinguish actually occupied addresses from otherwise invalid softpin offsets. For

[Intel-gfx] [PULL] drm-misc-fixes

2019-10-30 Thread Maxime Ripard
Hi Daniel, Dave, Here is this week's round of fixes for drm-misc. Thanks! Maxime drm-misc-fixes-2019-10-30-1: - three fixes for panfrost, one to silence a warning, one to fix runtime_pm and one to prevent bogus pointer dereferences - one fix for a memleak in v3d The following changes since

[Intel-gfx] [PATCH] drm/i915: Split detaching and removing the vma

2019-10-30 Thread Chris Wilson
In order to keep the assert_bind_count() valid, we need to hold the vma page reference until after we drop the bind count. However, we must also keep the drm_mm_remove_node() as the last action of i915_vma_unbind() so that it serialises with the unlocked check inside i915_vma_destroy(). So we need

Re: [Intel-gfx] [CI 03/12] drm/i915: Perform manual conversions for crtc uapi/hw split, v2.

2019-10-30 Thread Ville Syrjälä
On Wed, Oct 30, 2019 at 03:26:48PM +0100, Maarten Lankhorst wrote: > intel_get_load_detect_pipe() needs to set uapi active, > uapi enable is set by the call to drm_atomic_set_mode_for_crtc(), > so we can remove it. > > intel_pipe_config_compare() needs to look at hw state, but I didn't > change

Re: [Intel-gfx] [CI 11/12] drm/i915: Complete plane hw and uapi split, v2.

2019-10-30 Thread Ville Syrjälä
On Wed, Oct 30, 2019 at 03:26:56PM +0100, Maarten Lankhorst wrote: > Splitting plane state is easier than splitting crtc_state, > before plane check we copy the drm properties to hw so we can > do the same in bigjoiner later on. > > We copy the state after we did all the modeset handling, but

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/lmem: add the fake lmem region (rev2)

2019-10-30 Thread Patchwork
== Series Details == Series: drm/i915/lmem: add the fake lmem region (rev2) URL : https://patchwork.freedesktop.org/series/68733/ State : success == Summary == CI Bug Log - changes from CI_DRM_7226 -> Patchwork_15075 Summary ---

Re: [Intel-gfx] [CI 06/12] drm/i915: Complete crtc hw/uapi split, v5.

2019-10-30 Thread Ville Syrjälä
On Wed, Oct 30, 2019 at 03:26:51PM +0100, Maarten Lankhorst wrote: > Now that we separated everything into uapi and hw, it's > time to make the split definitive. Remove the union and > make a copy of the hw state on modeset and fastset. > > Color blobs are copied in crtc atomic_check(), right >

Re: [Intel-gfx] [CI 12/12] drm/i915: Remove special case slave handling during hw programming, v3.

2019-10-30 Thread Ville Syrjälä
On Wed, Oct 30, 2019 at 03:26:57PM +0100, Maarten Lankhorst wrote: > Now that we split plane_state which I didn't want to do yet, we can > program the slave plane without requiring the master plane. > > This is useful for programming bigjoiner slave planes as well. We > will no longer need the

[Intel-gfx] [PATCH v2] drm/i915/lmem: add the fake lmem region

2019-10-30 Thread Matthew Auld
Intended for upstream testing so that we can still exercise the LMEM plumbing and !i915_ggtt_has_aperture paths. Smoke tested on Skull Canyon device. This works by allocating an intel_memory_region for a reserved portion of system memory, which we treat like LMEM. For the LMEMBAR we steal the

Re: [Intel-gfx] [PATCH v2] drm/i915/lmem: add the fake lmem region

2019-10-30 Thread Chris Wilson
Quoting Matthew Auld (2019-10-30 17:33:20) > Intended for upstream testing so that we can still exercise the LMEM > plumbing and !i915_ggtt_has_aperture paths. Smoke tested on Skull Canyon > device. This works by allocating an intel_memory_region for a reserved > portion of system memory, which we

Re: [Intel-gfx] [PULL] topic/mst-suspend-resume-reprobe-2019-10-29-2

2019-10-30 Thread Lyude Paul
On Wed, 2019-10-30 at 10:21 +0100, Daniel Vetter wrote: > On Tue, Oct 29, 2019 at 11:06 PM Lyude Paul wrote: > > topic/mst-suspend-resume-reprobe-2019-10-29-2: > > UAPI Changes: > > > > Cross-subsystem Changes: > > > > Core Changes: > > * Handle UP requests asynchronously in the DP MST helpers,

Re: [Intel-gfx] [PATCH 1/2] drm/i915/uc: define GuC and HuC binaries for TGL

2019-10-30 Thread Daniele Ceraolo Spurio
On 10/26/19 3:44 AM, Michal Wajdeczko wrote: On Sat, 26 Oct 2019 02:35:06 +0200, Daniele Ceraolo Spurio wrote: GuC 35.2.0 and HuC 7.0.3 are the first production releases for TGL. GuC 35.2 for gen12 is interface-compatible with 33.0 on older gens, because the differences are related to

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/tgl: add support to one DP-MST stream (rev3)

2019-10-30 Thread Patchwork
== Series Details == Series: drm/i915/tgl: add support to one DP-MST stream (rev3) URL : https://patchwork.freedesktop.org/series/68671/ State : success == Summary == CI Bug Log - changes from CI_DRM_7219_full -> Patchwork_15059_full

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Defer rc6 shutdown to suspend_late

2019-10-30 Thread Andi Shyti
Hi Chris, On Wed, Oct 30, 2019 at 10:38:27AM +, Chris Wilson wrote: > Currently we shutdown rc6 during i915_gem_resume() but this is called > during the preparation phase (i915_drm_prepare) for all suspend paths, > but we only want to shutdown rc6 for S3+. Move the actual shutdown to >

Re: [Intel-gfx] [PATCH V6 6/6] docs: sample driver to demonstrate how to implement virtio-mdev framework

2019-10-30 Thread Jason Wang
On 2019/10/31 上午5:23, Christoph Hellwig wrote: On Wed, Oct 30, 2019 at 02:44:44PM +0800, Jason Wang wrote: This sample driver creates mdev device that simulate virtio net device over virtio mdev transport. The device is implemented through vringh and workqueue. A device specific dma ops is to

[Intel-gfx] [PATCH 1/2] drm/i915: drop lrc header page

2019-10-30 Thread Daniele Ceraolo Spurio
Recent GuC binaries (including all the ones we're currently using) don't require this shared area anymore, having moved the relevant entries into the stage pool instead. i915 itself doesn't write anything into it either, so we can safely drop it. Signed-off-by: Daniele Ceraolo Spurio Cc: Chris

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: drop lrc header page

2019-10-30 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: drop lrc header page URL : https://patchwork.freedesktop.org/series/68800/ State : success == Summary == CI Bug Log - changes from CI_DRM_7228 -> Patchwork_15080 Summary

[Intel-gfx] [PATCH i-g-t] i915/gem_ctx_persistence: Sanitycheck execbuf state harder for 'queued'

2019-10-30 Thread Chris Wilson
And initialise fence to -1 to avoid closing stdin (fd:0)! Signed-off-by: Chris Wilson --- tests/i915/gem_ctx_persistence.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/tests/i915/gem_ctx_persistence.c b/tests/i915/gem_ctx_persistence.c index

[Intel-gfx] linux-next: manual merge of the drm tree with the drm-intel-fixes tree

2019-10-30 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the drm tree got a conflict in: drivers/gpu/drm/i915/i915_drv.h between commit: 59cd826fb5e7 ("drm/i915: Fix PCH reference clock for FDI on HSW/BDW") from the drm-intel-fixes tree and commit: 7d423af9bfb1 ("drm/i915: Implement a better i945gm vblank

  1   2   >