== Series Details ==
Series: drm/i915/pmu: Fix wakeref leak in PMU busyness during reset (rev3)
URL : https://patchwork.freedesktop.org/series/97635/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10970 -> Patchwork_21776
On Mon, Nov 22, 2021 at 03:04:00PM -0800, Alan Previn wrote:
> GuC log buffer regions for debug-log-events, crash-dumps and
> error-state-capture are all a single bo allocation that includes
> the guc_log_buffer_state structures.
>
> Since the error-capture region is accessed with high priority
== Series Details ==
Series: drm/i915/dg2: make GuC FW a requirement for Gen12 and beyond devices
URL : https://patchwork.freedesktop.org/series/97676/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10970 -> Patchwork_21777
Hi Ramalingam,
On Wed, Oct 27, 2021 at 5:22 PM Ramalingam C wrote:
>
> From: Matt Roper
>
> DG2 unifies render compression and media compression into a single
> format for the first time. The programming and buffer layout is
> supposed to match compression on older gen12 platforms, but the
>
From: Siva Mullati
Only hw that supports mappable aperture would hit this path
vm_fault_gtt/vm_fault_tmm, So we never hit this function
remap_io_mapping() in discrete, So skip this code for non-x86
architectures.
v2: use IS_ENABLED () instead of #if defined
v3: move function prototypes from
live_engine_busy_stats waits for busyness to start ticking before
sampling busyness for the test sample duration. The wait accesses an
MMIO register and the uncore call to read it takes up to 3 ms in the
worst case. This can result in the wait timing out since the MMIO read
itself comsumes up the
== Series Details ==
Series: Basic enabling of 64k page support
URL : https://patchwork.freedesktop.org/series/97666/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10970_full -> Patchwork_21775_full
Summary
---
Thanks for the conditional Rvb - will get that fixed on next rev.
On Tue, 2021-12-07 at 13:01 -0800, Matthew Brost wrote:
> On Mon, Nov 22, 2021 at 03:03:59PM -0800, Alan Previn wrote:
> >
> >
> > +struct intel_guc_capture_out_data_header {
> > + u32 reserved1;
> > + u32 info;
> > +
== Series Details ==
Series: Assorted fixes/tweaks to GuC support (rev4)
URL : https://patchwork.freedesktop.org/series/97514/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10970 -> Patchwork_21779
Summary
---
== Series Details ==
Series: drm/i915: Skip remap_io_mapping() for non-x86 platforms (rev5)
URL : https://patchwork.freedesktop.org/series/96855/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10970_full -> Patchwork_21774_full
== Series Details ==
Series: Assorted fixes/tweaks to GuC support (rev4)
URL : https://patchwork.freedesktop.org/series/97514/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
Hi Stanislav,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on drm-tip/drm-tip v5.16-rc4 next-20211207]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we
@Lucas Thanks for the R-b.
The BSpec is currently missing size related info, we're working on
getting it added.
Strange indeed that v2.12 was above 24kB.
@Anusha, do you recall any size related issues for v2.12?
- Madhumitha
On Mon, 2021-12-06 at 22:44 -0800, Lucas De Marchi wrote:
> On Mon,
== Series Details ==
Series: drm/i915/pmu: Wait longer for busyness data to be available from GuC
URL : https://patchwork.freedesktop.org/series/97696/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10970 -> Patchwork_21780
== Series Details ==
Series: Assorted fixes/tweaks to GuC support (rev4)
URL : https://patchwork.freedesktop.org/series/97514/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
6f890802bd4f drm/i915/uc: Allow platforms to have GuC but not HuC
-:38: ERROR:COMPLEX_MACRO: Macros with
drivers/gpu/drm/i915/intel_pm.c:5500:6: warning: symbol
'dg2_async_flip_optimization' was not declared. Should it be static?
Reported-by: kernel test robot
Signed-off-by: kernel test robot
---
intel_pm.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
On 12/7/2021 09:53, Adrian Larumbe wrote:
Beginning with DG2, all successive devices will require GuC FW to be
present and loaded at probe() time. This change alters error handling in
the FW init and load functions so that the driver's probe() function will
fail if GuC could not be loaded.
We
== Series Details ==
Series: drm/i915/guc: Request RP0 before loading firmware
URL : https://patchwork.freedesktop.org/series/97682/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10970 -> Patchwork_21778
Summary
---
On Mon, Nov 22, 2021 at 03:04:02PM -0800, Alan Previn wrote:
> Print the GuC captured error state register list (offsets
> and values) when gpu_coredump_state printout is invoked.
>
> Also, since the GuC can report multiple engine class registers in a
> single notification event, parse the
== Series Details ==
Series: drm/i915/dg2: make GuC FW a requirement for Gen12 and beyond devices
URL : https://patchwork.freedesktop.org/series/97676/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked
Thank you for the detailed review Matt. Responses and follow up questions on
some of them below (wanna
make sure i dont misunderstand).
Will fix all the rest - glad we dont have any design problems .. so far :)
...alan
On Tue, 2021-12-07 at 14:31 -0800, Matthew Brost wrote:
> On Mon, Nov 22,
== Series Details ==
Series: drm/i915: Skip remap_io_mapping() for non-x86 platforms (rev6)
URL : https://patchwork.freedesktop.org/series/96855/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
553b9bfd0d75 drm/i915: Skip remap_io_mapping() for non-x86 platforms
-:122:
On Fri, Nov 12, 2021 at 4:49 AM Vincent Whitchurch
wrote:
>
> On Thu, Nov 11, 2021 at 03:02:04PM -0700, Jim Cromie wrote:
> > Dynamic-Debug can do 2nd exceedingly well:
> >
> > A- all work is behind jump-label's NOOP, zero off cost.
> > B- exact site selectivity, precisely the useful traffic.
> >
== Series Details ==
Series: drm/i915: Skip remap_io_mapping() for non-x86 platforms (rev6)
URL : https://patchwork.freedesktop.org/series/96855/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10970 -> Patchwork_21781
Thanks again for the detailed review here.
Will fix all the rest on next rev.
One special response for this one:
On Tue, 2021-12-07 at 16:22 -0800, Matthew Brost wrote:
> On Mon, Nov 22, 2021 at 03:04:02PM -0800, Alan Previn wrote:
> > + if (datatype ==
== Series Details ==
Series: drm/i915/dg2: make GuC FW a requirement for Gen12 and beyond devices
URL : https://patchwork.freedesktop.org/series/97676/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10970_full -> Patchwork_21777_full
== Series Details ==
Series: drm/i915: Skip remap_io_mapping() for non-x86 platforms (rev7)
URL : https://patchwork.freedesktop.org/series/96855/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10970 -> Patchwork_21782
== Series Details ==
Series: drm/i915/pmu: Fix wakeref leak in PMU busyness during reset (rev3)
URL : https://patchwork.freedesktop.org/series/97635/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10970_full -> Patchwork_21776_full
== Series Details ==
Series: drm/i915: Skip remap_io_mapping() for non-x86 platforms (rev7)
URL : https://patchwork.freedesktop.org/series/96855/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
230a39d9e8bf drm/i915: Skip remap_io_mapping() for non-x86 platforms
-:122:
== Series Details ==
Series: drm/i915: Skip remap_io_mapping() for non-x86 platforms (rev7)
URL : https://patchwork.freedesktop.org/series/96855/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915: Skip remap_io_mapping() for non-x86 platforms (rev6)
URL : https://patchwork.freedesktop.org/series/96855/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
Thanks Matt for reviewing. Responses to the questions you had.
will fix the rest on next rev.
> > @@ -4013,10 +4016,11 @@ int intel_guc_error_capture_process_msg(struct
> > intel_guc *guc,
> > return -EPROTO;
> > }
> >
> > - status = msg[0];
> > -
> -Original Message-
> From: Tolakanahalli Pradeep, Madhumitha
>
> Sent: Wednesday, December 8, 2021 8:25 AM
> To: Srivatsa, Anusha ; De Marchi, Lucas
>
> Cc: intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] [PATCH] drm/i915/dmc: Change DMC FW size on ADL-
> P
>
> @Lucas
On 07/12/2021 13:10, Tvrtko Ursulin wrote:
On 18/10/2021 10:10, Matthew Auld wrote:
For cached objects we can allocate our pages directly in shmem. This
should make it possible(in a later patch) to utilise the existing
i915-gem shrinker code for such objects. For now this is still disabled.
On Mon, 6 Dec 2021 at 16:46, Patchwork
wrote:
> *Patch Details*
> *Series:* series starting with [1/4] drm/i915/migrate: don't check the
> scratch page
> *URL:* https://patchwork.freedesktop.org/series/97610/
> *State:* failure
> *Details:*
>
On Mon, 29 Nov 2021 at 13:58, Maarten Lankhorst
wrote:
>
> We are moving away from short term pinning, and need a way to evict
> objects locked by the current context. Pass the ww context to all
> eviction functions, so that they can evict objects that are already
> locked by the current ww
== Series Details ==
Series: series starting with [1/4] drm/i915: Pass plane to watermark
calculation functions
URL : https://patchwork.freedesktop.org/series/97652/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10967_full -> Patchwork_21772_full
Changes for introducing the quick test on the device memory range and
also a test of detailed validation for each addr of the range with read
and write.
Detailed testing is optionally enabled with a modparam i915.memtest=1
Chris Wilson (2):
drm/i915: Sanitycheck device iomem on probe
From: Chris Wilson
As we setup the memory regions for the device, give each a quick test to
verify that we can read and write to the full iomem range. This ensures
that our physical addressing for the device's memory is correct, and
some reassurance that the memory is functional.
Signed-off-by:
From: Chris Wilson
This extends the previous sanitychecking of device memory to read/write
all the memory on the device during the device probe, ala memtest86,
as an optional module parameter: i915.memtest=1. This is not expected to
be fast, but a reasonably thorough verfification that the
== Series Details ==
Series: Sanity Check for device memory region
URL : https://patchwork.freedesktop.org/series/97658/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
1524de208313 drm/i915: Sanitycheck device iomem on probe
-:69: WARNING:VSPRINTF_SPECIFIER_PX: Using vsprintf
== Series Details ==
Series: Sanity Check for device memory region
URL : https://patchwork.freedesktop.org/series/97658/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: Sanity Check for device memory region
URL : https://patchwork.freedesktop.org/series/97658/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10968 -> Patchwork_21773
Summary
---
**SUCCESS**
Hi Stanislav,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on drm-intel/for-linux-next]
[also build test ERROR on drm-tip/drm-tip v5.16-rc4 next-20211207]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest
Hi, John.
On 12/7/21 21:46, John Harrison wrote:
On 11/29/2021 12:22, Thomas Hellström wrote:
With asynchronous migrations, the vma state may be several migrations
ahead of the state that matches the request we're capturing.
Address that by introducing an i915_vma_snapshot structure that
can
On Mon, Nov 22, 2021 at 03:03:59PM -0800, Alan Previn wrote:
> Add GuC's error capture output structures and definitions as how
> they would appear in GuC log buffer's error capture subregion after
> an error state capture G2H event notification.
>
> Signed-off-by: Alan Previn
> ---
>
== Series Details ==
Series: Sanity Check for device memory region
URL : https://patchwork.freedesktop.org/series/97658/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10968_full -> Patchwork_21773_full
Summary
---
From: John Harrison
Fix a potential null pointer dereference, improve debug crash reports,
improve code separation.
v2: Reposting as reduced set of patches due to CI failures.
Signed-off-by: John Harrison
John Harrison (3):
drm/i915/uc: Allow platforms to have GuC but not HuC
From: John Harrison
It is possible for platforms to require GuC but not HuC firmware.
Also, the firmware versions for GuC and HuC advance independently. So
split the macros up to allow the lists to be maintained separately.
Signed-off-by: John Harrison
Reviewed-by: Lucas De Marchi
From: John Harrison
Lots of testing is done with the DEBUG_GEM config option enabled but
not the DEBUG_GUC option. That means we only get teeny-tiny GuC logs
which are not hugely useful. Enabling full DEBUG_GUC also spews lots
of other detailed output that is not generally desired. However,
From: John Harrison
If the GuC has failed to load for any reason and then the user pokes
the debugfs GuC log interface, a BUG and/or null pointer deref can
occur. Don't let that happen.
Signed-off-by: John Harrison
Reviewed-by: Lucas De Marchi
---
On 11/29/2021 12:22, Thomas Hellström wrote:
With asynchronous migrations, the vma state may be several migrations
ahead of the state that matches the request we're capturing.
Address that by introducing an i915_vma_snapshot structure that
can be used to snapshot relevant state at request
On 12/7/21 19:08, Daniel Vetter wrote:
Once more an entire week behind on mails, but this looked interesting
enough.
On Fri, Dec 03, 2021 at 03:18:01PM +0100, Thomas Hellström wrote:
On Fri, 2021-12-03 at 14:08 +0100, Christian König wrote:
Am 01.12.21 um 13:16 schrieb Thomas Hellström
On Tue, Nov 30, 2021 at 05:33:09PM +0100, Sebastian Andrzej Siewior wrote:
> On 2021-11-19 17:04:00 [+0100], Daniel Vetter wrote:
> > Yeah if we can simplify this with reverts then I'm all for this.
> >
> > Acked-by: Daniel Vetter
> >
> > I've asked drm/i915 maintainers to check
>
> Thanks.
On Mon, Dec 06, 2021 at 01:40:26PM +0530, Tejas Upadhyay wrote:
> We need a way to reset engines by their reset domains.
> This change sets up way to fetch reset domains of each
> engine globally.
>
> Changes since V1:
> - Use static reset domain array - Ville and Tvrtko
> - Use
On Tue, 7 Dec 2021 at 14:34, Ramalingam C wrote:
>
> Changes for introducing the quick test on the device memory range and
> also a test of detailed validation for each addr of the range with read
> and write.
>
> Detailed testing is optionally enabled with a modparam i915.memtest=1
Series is
From: Matthew Auld
LMEM should be allocated at 64K granularity, since 4K page support will
eventually be dropped for LMEM when using the PPGTT.
Signed-off-by: Matthew Auld
Signed-off-by: Stuart Summers
Signed-off-by: Ramalingam C
Cc: Joonas Lahtinen
Cc: Rodrigo Vivi
Reviewed-by: Lucas De
From: Matthew Auld
On some platforms the hw has dropped support for 4K GTT pages when
dealing with LMEM, and due to the design of 64K GTT pages in the hw, we
can only mark the *entire* page-table as operating in 64K GTT mode,
since the enable bit is still on the pde, and not the pte. And since
From: Matthew Auld
If the device needs 64K minimum GTT pages for device local-memory,
like on XEHPSDV, then we need to fail the allocation if we can't
meet it, instead of falling back to 4K pages, otherwise we can't
safely support the insertion of device local-memory pages for
this vm, since the
On Tue, 7 Dec 2021 at 16:04, Matthew Auld
wrote:
>
> On Tue, 7 Dec 2021 at 14:34, Ramalingam C wrote:
> >
> > Changes for introducing the quick test on the device memory range and
> > also a test of detailed validation for each addr of the range with read
> > and write.
> >
> > Detailed testing
From: Vinay Belgaumkar
By default, GT (and GuC) run at RPn. Requesting for RP0
before firmware load can speed up DMA and HuC auth as well.
In addition to writing to 0xA008, we also need to enable
swreq in 0xA024 so that Punit will pay heed to our request.
Signed-off-by: Vinay Belgaumkar
---
== Series Details ==
Series: Basic enabling of 64k page support
URL : https://patchwork.freedesktop.org/series/97666/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10970 -> Patchwork_21775
Summary
---
**SUCCESS**
Once more an entire week behind on mails, but this looked interesting
enough.
On Fri, Dec 03, 2021 at 03:18:01PM +0100, Thomas Hellström wrote:
> On Fri, 2021-12-03 at 14:08 +0100, Christian König wrote:
> > Am 01.12.21 um 13:16 schrieb Thomas Hellström (Intel):
> > >
> > > On 12/1/21 12:25,
Hi Stanislav,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on drm-tip/drm-tip v5.16-rc4 next-20211207]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we
Beginning with DG2, all successive devices will require GuC FW to be
present and loaded at probe() time. This change alters error handling in
the FW init and load functions so that the driver's probe() function will
fail if GuC could not be loaded.
Signed-off-by: Adrian Larumbe
---
On 2021-12-07 at 02:56:47 +, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/selftests: Follow up on increase timeout in
> i915_gem_contexts selftests (rev2)
> URL : https://patchwork.freedesktop.org/series/97577/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes
Preparational patches for 64k page support.
Matthew Auld (3):
drm/i915/xehpsdv: set min page-size to 64K
drm/i915/gtt/xehpsdv: move scratch page to system memory
drm/i915: enforce min page size for scratch
Stuart Summers (1):
drm/i915: Add has_64k_pages flag
From: Stuart Summers
Add a new platform flag, has_64k_pages, for platforms supporting
base page sizes of 64k.
Signed-off-by: Stuart Summers
Signed-off-by: Ramalingam C
Reviewed-by: Lucas De Marchi
---
drivers/gpu/drm/i915/i915_drv.h | 2 ++
drivers/gpu/drm/i915/i915_pci.c
On Mon, Dec 06, 2021 at 05:00:46PM +, Matthew Auld wrote:
> On Mon, 6 Dec 2021 at 15:18, Maarten Lankhorst
> wrote:
> >
> > On 06-12-2021 14:13, Matthew Auld wrote:
> > > On Mon, 29 Nov 2021 at 13:57, Maarten Lankhorst
> > > wrote:
> > >> Big delta, but boils down to moving set_pages to
== Series Details ==
Series: drm/i915/selftests: Follow up on increase timeout in i915_gem_contexts
selftests (rev2)
URL : https://patchwork.freedesktop.org/series/97577/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10965_full -> Patchwork_21767_full
== Series Details ==
Series: drm/i915: Skip remap_io_mapping() for non-x86 platforms (rev5)
URL : https://patchwork.freedesktop.org/series/96855/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915: Skip remap_io_mapping() for non-x86 platforms (rev5)
URL : https://patchwork.freedesktop.org/series/96855/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
8a3ac5e7dafa drm/i915: Skip remap_io_mapping() for non-x86 platforms
-:120:
== Series Details ==
Series: drm/i915: Skip remap_io_mapping() for non-x86 platforms (rev5)
URL : https://patchwork.freedesktop.org/series/96855/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10970 -> Patchwork_21774
On 2021-12-06 at 16:38:45 -0800, Bruce Chang wrote:
> Follow up on commit 5e076529e265 ("drm/i915/selftests: Increase timeout in
> i915_gem_contexts selftests")
>
> So we went from 200 msec to 1sec in that commit, and now we are going to
> 10sec as timeout.
Thanks for the change and review.
From: Siva Mullati
Only hw that supports mappable aperture would hit this path
vm_fault_gtt/vm_fault_tmm, So we never hit this function
remap_io_mapping() in discrete, So skip this code for non-x86
architectures.
v2: use IS_ENABLED () instead of #if defined
v3: move function prototypes from
Hi Ammar,
On Tue, Dec 07, 2021 at 10:54:59AM +0700, Ammar Faizi wrote:
> Hello,
>
> I found warnings in the stable tree.
>
> Commit: a2547651bc896f95a3680a6a0a27401e7c7a1080 ("Linux 5.15.6")
>
> There are two unique warn locations:
>
> ammarfaizi2@integral2:~$ sudo dmesg -Sr | grep -oiE
Hi Stanislav,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on drm-intel/for-linux-next]
[also build test WARNING on drm-tip/drm-tip v5.16-rc4 next-20211207]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we
== Series Details ==
Series: Basic enabling of 64k page support
URL : https://patchwork.freedesktop.org/series/97666/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
On 06-12-2021 18:10, Matthew Auld wrote:
> On Mon, 29 Nov 2021 at 13:57, Maarten Lankhorst
> wrote:
>> Big delta, but boils down to moving set_pages to i915_vma.c, and removing
>> the special handling, all callers use the defaults anyway. We only remap
>> in ggtt, so default case will fall
> -Original Message-
> From: Srivatsa, Anusha
> Sent: Monday, December 6, 2021 9:59 AM
> To: 'Tvrtko Ursulin' ; intel-
> g...@lists.freedesktop.org
> Cc: x...@kernel.org; dri-de...@lists.freedesktop.org; Ingo Molnar
> ; Borislav Petkov ; Dave Hansen
> ; Joonas Lahtinen
> ; Nikula, Jani
On Tue, 7 Dec 2021 at 10:06, Maarten Lankhorst
wrote:
>
> On 06-12-2021 18:10, Matthew Auld wrote:
> > On Mon, 29 Nov 2021 at 13:57, Maarten Lankhorst
> > wrote:
> >> Big delta, but boils down to moving set_pages to i915_vma.c, and removing
> >> the special handling, all callers use the defaults
== Series Details ==
Series: series starting with [1/4] drm/i915: Pass plane to watermark
calculation functions
URL : https://patchwork.freedesktop.org/series/97652/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be
On Mon, 29 Nov 2021 at 13:57, Maarten Lankhorst
wrote:
>
> In the next commit, we don't evict when refcount = 0.
>
> igt_vm_isolation() continuously tries to pin/unpin at same address,
> but also calls put() on the object, which means the object may not
> be unpinned in time.
>
> Instead of this,
Sometimes we might need to change the way we calculate
watermarks, based on which particular plane it is calculated
for. Thus it would be convenient to pass plane struct to those
functions.
v2: Pass plane instead of plane_id
Signed-off-by: Stanislav Lisovskiy
---
There might be various logical contructs when we might want
to enable async flip, so lets calculate those and set this
flag, so that there is no need in long conditions in other
places.
Signed-off-by: Stanislav Lisovskiy
---
drivers/gpu/drm/i915/display/intel_atomic_plane.c | 2 +-
This optimization allows to achieve higher perfomance
during async flips.
For the first async flip we have to still temporarily
switch to sync flip, in order to reprogram plane
watermarks, so this requires taking into account
old plane state's do_async_flip flag.
v2: - Removed redundant
In terms of async flip optimization we don't to allocate
extra ddb space, so lets skip it.
v2: - Extracted min ddb async flip check to separate function
(Ville Syrjälä)
- Used this function to prevent false positive WARN
to be triggered(Ville Syrjälä)
Signed-off-by: Stanislav
== Series Details ==
Series: series starting with [1/4] drm/i915: Pass plane to watermark
calculation functions
URL : https://patchwork.freedesktop.org/series/97652/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10967 -> Patchwork_21772
== Series Details ==
Series: Enable pipe color support on D13 platform (rev3)
URL : https://patchwork.freedesktop.org/series/97219/
State : failure
== Summary ==
Applying: drm/i915/xelpd: Enable Pipe color support for D13 platform
Using index info to reconstruct a base tree...
M
On Mon, 29 Nov 2021 at 13:57, Maarten Lankhorst
wrote:
>
> Now that freeing objects takes the object lock when destroying the
> backing pages, we can confidently take the object lock even for dead
> objects.
That looks to be a future patch, at least with non-TTM backend? Does
something need to
== Series Details ==
Series: series starting with [1/4] drm/i915: Pass plane to watermark
calculation functions
URL : https://patchwork.freedesktop.org/series/97652/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
a7707df23264 drm/i915: Pass plane to watermark calculation
On 18/10/2021 10:10, Matthew Auld wrote:
For cached objects we can allocate our pages directly in shmem. This
should make it possible(in a later patch) to utilise the existing
i915-gem shrinker code for such objects. For now this is still disabled.
v2(Thomas):
- Add optional
92 matches
Mail list logo
