On Fri, 6 Jun 2014 22:44:12 +0300
ville.syrj...@linux.intel.com wrote:
From: Ville Syrjälä ville.syrj...@linux.intel.com
My Fujitsu-Siemens Lifebook S6010 definitely has a VGA connector, but
the VBT says different. Ignore the VBT for 830M since it seems such
old machines would generally
Add the infrastructure to support plane properties in the intel_plane
structure. Then use that infrastructure to add a property that controls
wether gamma correction is applied to a plane.
The default value is to enable gamma correction on the planes to match the
previous behavior.
Bob Paauwe (2
definitions for sprite gamma enable/disable
v3: Rename property name to Sprite Gamma Enabled (Matt)
Signed-off-by: Bob Paauwe bob.j.paa...@intel.com
---
drivers/gpu/drm/i915/i915_drv.h | 5 +
drivers/gpu/drm/i915/intel_drv.h| 6 ++
drivers/gpu/drm/i915/intel_sprite.c | 28
Hook up the set_property function pointer to a stub function. The function
will be populated once actual plane properties are created.
Signed-off-by: Bob Paauwe bob.j.paa...@intel.com
---
drivers/gpu/drm/i915/intel_sprite.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/gpu
There isn't a 'dev' variable that can be referenced here. Use
vm-dev instead.
Signed-off-by: Bob Paauwe bob.j.paa...@intel.com
---
drivers/gpu/drm/i915/i915_trace.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_trace.h
b/drivers/gpu/drm/i915
On Wed, 13 Nov 2013 10:20:47 -0800
Jesse Barnes jbar...@virtuousgeek.org wrote:
Retrieve current framebuffer config info from the regs and create an fb
object for the buffer the BIOS or boot loader left us. This should
allow for smooth transitions to userspace apps once we finish the
initial
port port);
I'm still learning the i915 codebase but FWIW, this series looks like it
does what it's supposed to so other than the comment above, for the
series:
Reviewed-by: Bob Paauwe bob.j.paa...@intel.com
___
Intel-gfx mailing list
Intel-gfx
On Tue, 9 Sep 2014 11:53:13 +0530
shashank.sha...@intel.com wrote:
From: Shashank Sharma shashank.sha...@intel.com
Color manager is a framework which adds drm properties for
color correction in I915 driver. This framework creates DRM
properties for each color correction feature, and
On Tue, 9 Sep 2014 11:53:15 +0530
shashank.sha...@intel.com wrote:
From: Shashank Sharma shashank.sha...@intel.com
This patch adds support for CSC correction color property.
It does the following:
1. Creates a new DRM property for CSC correction. Adds this into
mode_config.
2. Attaches
On Wed, 10 Sep 2014 14:25:00 +0530
Sharma, Shashank shashank.sha...@intel.com wrote:
Thanks for your time and review.
Thanks for working on this. This is a feature that the IOTG group is
interested in.
Please find my comments inline.
Regards
Shashank
On 9/10/2014 4:21 AM, Bob Paauwe
On Wed, 10 Sep 2014 14:10:01 +0530
Sharma, Shashank shashank.sha...@intel.com wrote:
Hello Bob,
Thanks for your time and review comments.
Please find my comments inline.
Regards
Shashank
On 9/10/2014 4:21 AM, Bob Paauwe wrote:
On Tue, 9 Sep 2014 11:53:13 +0530
shashank.sha
Author: Ander Conselvan de Oliveira
ander.conselvan.de.olive...@intel.com
Date: Wed Oct 29 11:32:36 2014 +0200
drm/i915: Covert remaining platforms to choose DPLLS before
disabling CRTCs
Signed-off-by: Bob Paauwe bob.j.paa...@intel.com
CC: Ander Conselvan de Oliveira
On Mon, 10 Nov 2014 12:40:47 +0200
Ville Syrjälä ville.syrj...@linux.intel.com wrote:
On Fri, Nov 07, 2014 at 04:07:50PM -0800, Bob Paauwe wrote:
The pipe config needs to be initialized before calling crtc_compute_clock
since this will update the new_config structure DPLL values
to choose DPLLS before
disabling CRTCs
Signed-off-by: Bob Paauwe bob.j.paa...@intel.com
CC: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com
CC: Ville Syrjälä ville.syrj...@linux.intel.com
---
drivers/gpu/drm/i915/intel_display.c | 10 +-
1 file changed, 5 insertions(+), 5
to choose DPLLS before
disabling CRTCs
v2: Use intel_pipe_will_have_type() to look at new configuration - Ander
Signed-off-by: Bob Paauwe bob.j.paa...@intel.com
CC: Ander Conselvan de Oliveira ander.conselvan.de.olive...@intel.com
---
drivers/gpu/drm/i915/intel_display.c | 12 ++--
1 file
On Thu, 13 Nov 2014 10:43:21 -0800
Matt Roper matthew.d.ro...@intel.com wrote:
We'll want to call this from the type-agnostic atomic plane helper
hooks. Since it's not sprite-specific anymore, more it to
intel_display.c as well.
Signed-off-by: Matt Roper matthew.d.ro...@intel.com
---
On Thu, 13 Nov 2014 11:12:01 -0800
Matt Roper matthew.d.ro...@intel.com wrote:
On Thu, Nov 13, 2014 at 11:11:38AM -0800, Bob Paauwe wrote:
On Thu, 13 Nov 2014 10:43:21 -0800
Matt Roper matthew.d.ro...@intel.com wrote:
We'll want to call this from the type-agnostic atomic plane helper
On Thu, 13 Nov 2014 10:43:24 -0800
Matt Roper matthew.d.ro...@intel.com wrote:
Add the new driver entrypoints that will be called by the atomic plane
helpers.
This patch does not actually switch over to the new plane helpers yet,
so there should be no functional change here. Also note that
On Thu, 13 Nov 2014 10:43:20 -0800
Matt Roper matthew.d.ro...@intel.com wrote:
Signed-off-by: Matt Roper matthew.d.ro...@intel.com
Reviewed-by: Bob Paauwe bob.j.paa...@intel.com
---
drivers/gpu/drm/i915/intel_display.c | 28 ++--
drivers/gpu/drm/i915/intel_drv.h
On Thu, 13 Nov 2014 10:43:23 -0800
Matt Roper matthew.d.ro...@intel.com wrote:
We'll want to use this from the atomic plane helpers, so ensure it can
be called outside intel_display.c.
Signed-off-by: Matt Roper matthew.d.ro...@intel.com
Reviewed-by: Bob Paauwe bob.j.paa...@intel.com
is unnecessary since the plane will
already be disabled due to framebuffer destruction by the point it gets
called.
Signed-off-by: Matt Roper matthew.d.ro...@intel.com
Reviewed-by: Bob Paauwe bob.j.paa...@intel.com
---
drivers/gpu/drm/i915/intel_display.c | 12 ++--
drivers/gpu/drm/i915
typo fixed this is
Acknowledged-by: Bob Paauwe bob.j.paa...@intel.com
---
drivers/gpu/drm/i915/intel_display.c | 255
+--
drivers/gpu/drm/i915/intel_sprite.c | 122 ++---
2 files changed, 41 insertions(+), 336 deletions(-)
diff --git a/drivers
} fields in intel_plane_state. Drop them.
Signed-off-by: Matt Roper matthew.d.ro...@intel.com
Reviewed-by: Bob Paauwe bob.j.paa...@intel.com
---
drivers/gpu/drm/i915/intel_display.c | 16
drivers/gpu/drm/i915/intel_drv.h | 6 --
drivers/gpu/drm/i915/intel_sprite.c
with a specific value (0x00)
The tiled bo is filled with a different value (0xff)
If any bytes in the linear bo get written with 0xff, then the
fence allowed writing beyond the tiled bo boundry.
Signed-off-by: Bob Paauwe bob.j.paa...@intel.com
---
tests/Makefile.sources | 1 +
tests
...@ghs.com
Signed-off-by: Bob Paauwe bob.j.paa...@intel.com
---
drivers/gpu/drm/i915/i915_gem.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 67550ac..c9acbfa 100644
--- a/drivers/gpu/drm/i915/i915_gem.c
+++ b/drivers/gpu
On Thu, 18 Dec 2014 21:31:43 +0100
Daniel Vetter dan...@ffwll.ch wrote:
On Thu, Dec 18, 2014 at 09:50:27AM -0800, Bob Paauwe wrote:
When a tiled bo is allocated such that the actual size of the bo is
larger than the region covered by the tiles. For example allocating
a Y-tiled bo
Human readable name for each output type to correspond with names
used in the ACPI property tables.
Signed-off-by: Bob Paauwe bob.j.paa...@intel.com
---
drivers/gpu/drm/i915/intel_display.c | 57
drivers/gpu/drm/i915/intel_drv.h | 1 +
2 files changed
with it.
intel_config_init_component_property() will look up a
configuration property and assign the value to a drm
property of the same name. These functions are used to
initialize drm property instances to specific values.
Signed-off-by: Bob Paauwe bob.j.paa...@intel.com
---
drivers/gpu/drm/i915/Makefile | 3
Add VBT device sections with sample data to test the VBT parsing.
Signed-off-by: Bob Paauwe bob.j.paa...@intel.com
---
drivers/gpu/drm/i915/i915-properties.asl | 140 +++
drivers/gpu/drm/i915/i915-properties.hex | 622 +++
2 files changed, 533 insertions(+), 229
Set the initial value of the force audio and broadcast rgb properties
using property values found in the init-time configuration.
Signed-off-by: Bob Paauwe bob.j.paa...@intel.com
---
drivers/gpu/drm/i915/intel_modes.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git
-by: Bob Paauwe bob.j.paa...@intel.com
---
drivers/gpu/drm/i915/i915-properties.asl | 150 +++
drivers/gpu/drm/i915/i915-properties.hex | 173 +++
drivers/gpu/drm/i915/intel_config.c | 20 +++-
3 files changed, 342 insertions(+), 1 deletion
If there are ACPI table based workarounds for a platform, use those
instead of the built-in driver list when doing the workaround init.
Signed-off-by: Bob Paauwe bob.j.paa...@intel.com
---
drivers/gpu/drm/i915/intel_ringbuffer.c | 19 +++
1 file changed, 11 insertions(+), 8
Use the init-time configuration setting for scaling_mode to set the
initial value of the scaling_mode connector property.
Signed-off-by: Bob Paauwe bob.j.paa...@intel.com
---
drivers/gpu/drm/i915/intel_dp.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu
Add the various workarounds as properties in the ACPI table. How these
get processed and used is still TBD.
Added broadwell and cherrytrail workarounds as examples.
Signed-off-by: Bob Paauwe bob.j.paa...@intel.com
---
drivers/gpu/drm/i915/i915-properties.asl | 50 +
drivers/gpu/drm/i915
be useful to adjust the workaround
list for a new GPU prior to fixed support being available in the
driver.
Signed-off-by: Bob Paauwe bob.j.paa...@intel.com
---
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/i915/intel_config.c | 101 +++-
drivers/gpu/drm
We'll reduce some duplicate code if we move the list node allocation
to its own function when we start processing future config items like
workaround or vbt information.
Signed-off-by: Bob Paauwe bob.j.paa...@intel.com
---
drivers/gpu/drm/i915/intel_config.c | 49
Allow the init-time configuration to specify the bits per color value
that gets used if bits per color is not present in EDID data (or if EDID
is not present).
Signed-off-by: Bob Paauwe bob.j.paa...@intel.com
---
drivers/gpu/drm/i915/intel_display.c | 14 ++
1 file changed, 14
table.
Bob Paauwe (12):
drm/i915/config: Initial framework
drm/i915/config: Introduce intel_output_name
drm/i915/config: Add init-time configuration of bits per color.
drm/i915/config: Set dp panel fitter property based on init-time
config.
drm/i915/config: Set general connector
.
Any data found in the configuration tables will replace the driver's
vbt structure.
MIPI DSI configuration is not implmemnted at this time.
Signed-off-by: Bob Paauwe bob.j.paa...@intel.com
---
drivers/gpu/drm/i915/i915_dma.c | 2 +
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm
On Fri, 13 Feb 2015 10:08:52 +0200
Jani Nikula jani.nik...@linux.intel.com wrote:
Thanks Jani for the quick look and comments!
On Fri, 13 Feb 2015, Bob Paauwe bob.j.paa...@intel.com wrote:
Background:
This capability is targeted at deeply embedded appliance like devices
that make use
On Tue, 24 Feb 2015 14:57:48 +0100
Daniel Vetter dan...@ffwll.ch wrote:
On Thu, Feb 12, 2015 at 03:41:35PM -0800, Bob Paauwe wrote:
Add a new section with subsections to the ACPI configuration table
that mimics much of the information typically stored in the VBT/option
ROM. This allows
On Tue, 24 Feb 2015 17:17:18 +0100
Daniel Vetter dan...@ffwll.ch wrote:
On Thu, Feb 12, 2015 at 03:41:27PM -0800, Bob Paauwe wrote:
This adds an init-time configuration framework that parses configuration
data from an ACPI property table. The table is assumed to have well
defined sub
On Tue, 24 Feb 2015 14:51:31 +0100
Daniel Vetter dan...@ffwll.ch wrote:
On Thu, Feb 12, 2015 at 03:41:33PM -0800, Bob Paauwe wrote:
Add ability to parse a list of workarounds from the ACPI table.
Initially, this expects all workarounds listed to be valid and
they replace the hard coded
On Tue, 24 Feb 2015 21:52:16 +0100
Daniel Vetter dan...@ffwll.ch wrote:
On Tue, Feb 24, 2015 at 10:37:10AM -0800, Bob Paauwe wrote:
On Tue, 24 Feb 2015 14:57:48 +0100
Daniel Vetter dan...@ffwll.ch wrote:
As Jani points out we already have vbt headaches, it would be good if we
only have
Allow the init-time configuration to specify the bits per color value
that gets used if bits per color is not present in EDID data (or if EDID
is not present).
v2: Use connector-base.name for connector name (Jani)
Signed-off-by: Bob Paauwe bob.j.paa...@intel.com
---
drivers/gpu/drm/i915
(Bob)
Free allocated intel_config_info on shutdown (Bob)
Signed-off-by: Bob Paauwe bob.j.paa...@intel.com
---
drivers/gpu/drm/i915/Makefile | 3 +-
drivers/gpu/drm/i915/i915_dma.c | 4 +
drivers/gpu/drm/i915/i915_drv.h | 17 ++
drivers/gpu/drm/i915/i915_params.c | 6
Allow the configuration file to overide the various panel power
sequence delay values.
Signed-off-by: Bob Paauwe bob.j.paa...@intel.com
---
drivers/gpu/drm/i915/intel_dp.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915
This is an example of what an ACPI property table looks like.
Signed-off-by: Bob Paauwe bob.j.paa...@intel.com
---
drivers/gpu/drm/i915/i915-properties.asl | 167 +++
1 file changed, 167 insertions(+)
create mode 100644 drivers/gpu/drm/i915/i915-properties.asl
diff
Set the initial value of the force audio and broadcast rgb properties
using property values found in the init-time configuration.
v2: Use drm connector name (Jani)
Signed-off-by: Bob Paauwe bob.j.paa...@intel.com
---
drivers/gpu/drm/i915/intel_modes.c | 4 ++--
1 file changed, 2 insertions
To allow us to verify the current backlight max and level values.
Signed-off-by: Bob Paauwe bob.j.paa...@intel.com
---
drivers/gpu/drm/i915/i915_debugfs.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
b/drivers/gpu/drm/i915/i915_debugfs.c
index
Use the init-time configuration setting for scaling_mode to set the
initial value of the scaling_mode connector property.
v2: Use drm connector name (Jani)
Signed-off-by: Bob Paauwe bob.j.paa...@intel.com
---
drivers/gpu/drm/i915/intel_dp.c | 7 ---
1 file changed, 4 insertions(+), 3
So that we verify which values are currently in use.
Signed-off-by: Bob Paauwe bob.j.paa...@intel.com
---
drivers/gpu/drm/i915/i915_debugfs.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
b/drivers/gpu/drm/i915
Allow the configuration file to overide the backlight max and level
settings.
Signed-off-by: Bob Paauwe bob.j.paa...@intel.com
---
drivers/gpu/drm/i915/intel_panel.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_panel.c
b/drivers/gpu/drm/i915
for testing the code.
Bob Paauwe (10):
drm/i915/config: Initial framework
drm/i915/config: Add init-time configuration of bits per color.
drm/i915/config: Add init-time configuration of general connector
properties.
drm/i915/config: Add init-time configuration of dp panel fitter
If the sink does not provide a maximum link rate, then check the
connector configuration before defaulting to the lowest allowed
link rate.
Signed-off-by: Bob Paauwe bob.j.paa...@intel.com
---
drivers/gpu/drm/i915/intel_dp.c | 15 ---
1 file changed, 12 insertions(+), 3 deletions
there's no generic way to
do AUX transactions given just a drm_connector. However it's all pretty
straightforward to port to other drivers.
v2: Add more DPCD registers to dump.
Signed-off-by: Jani Nikula jani.nik...@intel.com
Reviewed-by: Bob Paauwe bob.j.paa...@intel.com
---
drivers/gpu
On Fri, 15 May 2015 12:39:20 +0300
Ville Syrjälä ville.syrj...@linux.intel.com wrote:
On Tue, Feb 24, 2015 at 09:52:16PM +0100, Daniel Vetter wrote:
On Tue, Feb 24, 2015 at 10:37:10AM -0800, Bob Paauwe wrote:
On Tue, 24 Feb 2015 14:57:48 +0100
Daniel Vetter dan...@ffwll.ch wrote
state (Ville)
Cc: Ville Syrjälä ville.syrj...@linux.intel.com
Cc: Imre Deak imre.d...@intel.com
Cc: Matt Roper matthew.d.ro...@intel.com
Signed-off-by: Bob Paauwe bob.j.paa...@intel.com
Signed-off-by: Matt Roper matthew.d.ro...@intel.com
---
drivers/gpu/drm/i915/intel_display.c | 31
Broxton is using a different register and different bit ordering
for rps status capabilities.
Also GT perf freqency register is different for Broxton so update
that.
Signed-off-by: Bob Paauwe bob.j.paa...@intel.com
---
drivers/gpu/drm/i915/i915_debugfs.c | 21 -
drivers/gpu
The registers and process differ from other platforms.
Signed-off-by: Bob Paauwe bob.j.paa...@intel.com
---
drivers/gpu/drm/i915/intel_display.c | 27 +++
1 file changed, 27 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915
On Thu, 21 May 2015 10:37:07 +0200
Daniel Vetter dan...@ffwll.ch wrote:
On Wed, May 20, 2015 at 10:07:58AM -0700, Bob Paauwe wrote:
On Fri, 15 May 2015 12:39:20 +0300
Ville Syrjälä ville.syrj...@linux.intel.com wrote:
On Tue, Feb 24, 2015 at 09:52:16PM +0100, Daniel Vetter wrote
When reducing a xy reflection to a 180 degree rotation, make sure
only one rotation bit is set. Also by rotating the bit left, we
can support cases where xy reflection happens with 90/270 degree
rotation.
Signed-off-by: Bob Paauwe bob.j.paa...@intel.com
---
src/sna/sna_display.c | 5 -
1
updated. Damien
Signed-off-by: Bob Paauwe bob.j.paa...@intel.com
---
drivers/gpu/drm/i915/intel_pm.c | 26 +-
1 file changed, 25 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index a1d92b7..27c3126 100644
On Thu, 16 Jul 2015 13:30:11 +0100
Damien Lespiau damien.lesp...@intel.com wrote:
On Wed, Jul 08, 2015 at 09:05:53AM -0700, Bob Paauwe wrote:
Clearing the watermarks for all pipes/planes when updating the
watermarks for a single CRTC change seems like the wrong thing to
do here
, Chandra <chandra.kond...@intel.com>
cc: Kevin Strasser <kevin.stras...@linux.intel.com>
Signed-off-by: Bob Paauwe <bob.j.paa...@intel.com>
---
drivers/gpu/drm/i915/i915_reg.h | 10 ++
drivers/gpu/drm/i915/intel_display.c | 6 ++
2 files changed, 16 inserti
f rounding down in
> freq-ratio-freq conversions.
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92768
> Testcase: igt/pm_rps/basic-api
> Tested-by: Bob Paauwe <bob.j.paa...@intel.com>
> Cc: Bob Paauwe <bob.j.paa...@intel.com>
> Signed-off-by: Imre D
On Thu, 12 Nov 2015 10:35:00 +0200
Imre Deak <imre.d...@intel.com> wrote:
> On Wed, 2015-11-11 at 13:36 -0800, Bob Paauwe wrote:
> > On Tue, 10 Nov 2015 11:04:22 +0200
> > Mika Kuoppala <mika.kuopp...@linux.intel.com> wrote:
> >
> > >
On Thu, 12 Nov 2015 11:18:11 +0200
Imre Deak <imre.d...@intel.com> wrote:
> On ke, 2015-11-11 at 13:37 -0800, Bob Paauwe wrote:
> > Since commit
> >
> > commit aed242ff7ebb697e4dff912bd4dc7ec7192f7581
> > Author: Chris Wilson <ch...@chris-wilson.co.uk>
On Tue, 10 Nov 2015 11:04:22 +0200
Mika Kuoppala <mika.kuopp...@linux.intel.com> wrote:
> Bob Paauwe <bob.j.paa...@intel.com> writes:
>
> > Signed-off-by: Bob Paauwe <bob.j.paa...@intel.com>
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=927
e user
specified minimum frequency. Update the pm_rps tests to reflect that
this is no longer considered a failure.
Signed-off-by: Bob Paauwe <bob.j.paa...@intel.com>
---
tests/pm_rps.c | 7 +++
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/tests/pm_rps.c b/tests/pm
Signed-off-by: Bob Paauwe <bob.j.paa...@intel.com>
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92768
---
drivers/gpu/drm/i915/intel_pm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
)
> + if (HAS_GMCH_DISPLAY(dev))
> intel_gmch_panel_fitting(intel_crtc, pipe_config,
>
> intel_connector->panel.fitting_mode);
> else
Reviewed-by: Bob Paauwe <bob.j.paa...@intel.com>
Tested-by: Bob Paauwe <bob.j.paa..
e recognize that're running on BXT
> where it should have been on anyway.
>
> Cc: Imre Deak <imre.d...@intel.com>
> Cc: Bob Paauwe <bob.j.paa...@intel.com>
> Signed-off-by: Matt Roper <matthew.d.ro...@intel.com>
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 13 ++
On Tue, 20 Oct 2015 19:13:19 +0300
Ville Syrjälä <ville.syrj...@linux.intel.com> wrote:
> On Tue, Oct 20, 2015 at 08:48:36AM -0700, Bob Paauwe wrote:
> > On Mon, 19 Oct 2015 10:13:58 -0700
> > Kevin Strasser <kevin.stras...@linux.intel.com> wrote:
> >
> &g
bugs.freedesktop.org/show_bug.cgi?id=89331
> Testcase: igt/kms_universal_plane/universal-plane-pipe-A-functional
> Signed-off-by: Kevin Strasser <kevin.stras...@linux.intel.com>
Reviewed-by: Bob Paauwe <bob.j.paa...@intel.com>
> ---
> drivers/gpu/drm/i915/intel_disp
On Mon, 19 Oct 2015 10:13:58 -0700
Kevin Strasser <kevin.stras...@linux.intel.com> wrote:
> On Mon, Oct 19, 2015 at 12:15:41PM +0200, Daniel Vetter wrote:
> > On Fri, Oct 16, 2015 at 03:53:22PM -0700, Bob Paauwe wrote:
> > > On Thu, 15 Oct 2015 15:41:30 +0300
> &g
gamma/csc corrected, then the disiabled case will match the
black plane case.
testcase: igt/kms_universal_plane/universal-plane-pipe-[ABC]-functional
CC: Konduru, Chandra <chandra.kond...@intel.com>
cc: Kevin Strasser <kevin.stras...@linux.intel.com>
Signed-off-by: Bob Paauw
_COLOR) that was
causing the CRC failures. And yes, it is. The PIPE_BOTTOM_COLOR also
has gamma and csc enable bits which default to off. If those are
flipped on, then the CRC's match between a disabled plane and a black
plane.
So it seems to make CRC's match we need to make sure that all
() will flag these zero'd out pipe/plane
watermarks and throw errors.
By not clearing all pipe/plane watermark values, only those that
require changes are changed and the remaining stay unchanged.
Signed-off-by: Bob Paauwe bob.j.paa...@intel.com
---
drivers/gpu/drm/i915/intel_pm.c | 2 --
1 file
on the primary plane and something displayed on a sprite
plane when the ARGB format is used.
Signed-off-by: Bob Paauwe bob.j.paa...@intel.com
---
drivers/gpu/drm/i915/intel_sprite.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/i915/intel_sprite.c
b/drivers/gpu/drm/i915
Extend this to SKL and BXT as it's needed for these platforms as well.
Signed-off-by: Bob Paauwe bob.j.paa...@intel.com
---
drivers/gpu/drm/i915/intel_display.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915
On Fri, 28 Aug 2015 15:19:04 +0100
Daniel Stone dan...@fooishbar.org wrote:
Hi Bob,
On 27 August 2015 at 21:46, Bob Paauwe bob.j.paa...@intel.com wrote:
Extend this to SKL and BXT as it's needed for these platforms as well.
Signed-off-by: Bob Paauwe bob.j.paa...@intel.com
Extend this to SKL and BXT as it's needed for these platforms as well.
v2: Change if condition to HAS_DDI() instead of listing each platform
Signed-off-by: Bob Paauwe <bob.j.paa...@intel.com>
---
drivers/gpu/drm/i915/intel_display.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Damien,
You reviewed v1 and then went on vacation for v2. Any chance you can
review v2?
Thanks,
Bob
On Tue, 21 Jul 2015 10:42:53 -0700
Bob Paauwe <bob.j.paa...@intel.com> wrote:
> Clearing the watermarks for all pipes/planes when updating the
> watermarks for a single CRTC chang
On Fri, 28 Aug 2015 17:12:12 +0100
Daniel Stone dan...@fooishbar.org wrote:
Hi,
On 28 August 2015 at 16:55, Bob Paauwe bob.j.paa...@intel.com wrote:
On Fri, 28 Aug 2015 15:19:04 +0100
Daniel Stone dan...@fooishbar.org wrote:
For both this and the previous patch, cf. the corresponding
On Fri, 4 Dec 2015 22:58:50 +0200
Imre Deak <imre.d...@intel.com> wrote:
> On Fri, 2015-12-04 at 10:37 -0800, Bob Paauwe wrote:
> > On Fri, 4 Dec 2015 17:22:11 +0200
> > Imre Deak <imre.d...@intel.com> wrote:
> > [...]
> > > > With the BIOS se
On Fri, 4 Dec 2015 17:22:11 +0200
Imre Deak <imre.d...@intel.com> wrote:
> On to, 2015-12-03 at 16:43 -0800, Bob Paauwe wrote:
> > On Tue, 1 Dec 2015 19:43:05 +0200
> > Imre Deak <imre.d...@intel.com> wrote:
> >
> > > On ti, 2015-12-01 at 09:22 -0800, Bo
e user
specified minimum frequency to the "idle" or RPn frequency. Update the
pm_rps tests to reflect that droping below the user specified minimum
is no longer considered a failure.
v2: Add check RPn <= current freq. (Me)
v3: Use RPn instead of MIN frequency in idle check (Imre)
Signed
On Tue, 1 Dec 2015 19:43:05 +0200
Imre Deak <imre.d...@intel.com> wrote:
> On ti, 2015-12-01 at 09:22 -0800, Bob Paauwe wrote:
> > On Tue, 1 Dec 2015 15:56:55 +0200
> > Imre Deak <imre.d...@intel.com> wrote:
> >
> > > On ma, 2015-11-30 at
On Tue, 1 Dec 2015 15:56:55 +0200
Imre Deak <imre.d...@intel.com> wrote:
> On ma, 2015-11-30 at 16:23 -0800, Bob Paauwe wrote:
> > Now that the frequency can drop below the user specified minimum when
> > the gpu is idle, add some checking to verify that it really does dro
On Mon, 7 Dec 2015 17:00:20 +0200
Imre Deak <imre.d...@intel.com> wrote:
> On pe, 2015-12-04 at 14:41 -0800, Bob Paauwe wrote:
> > On Fri, 4 Dec 2015 22:58:50 +0200
> > Imre Deak <imre.d...@intel.com> wrote:
> > [...]
> > So we want the policy to be that we'
.
Signed-off-by: Bob Paauwe <bob.j.paa...@intel.com>
---
tests/pm_rps.c | 4
1 file changed, 4 insertions(+)
diff --git a/tests/pm_rps.c b/tests/pm_rps.c
index 9d054fd..9f752f8 100644
--- a/tests/pm_rps.c
+++ b/tests/pm_rps.c
@@ -388,10 +388,14 @@ static void min_max_config(void (
-max-idle subtest make
use of the second check routine to verify that the frequency drops
to RPn instead of simply <= user min frequency. For all other
subtests, use the original check routines for both checks.
Signed-off-by: Bob Paauwe <bob.j.paa...@intel.com>
---
tests/pm_r
but didn't want to re-write the entire test program
to make handle these cases more elegantly. Other ideas welcome.
Bob Paauwe (2):
igt/pm_rps: current freq < user specified min is not a fail (v2)
igt/pm_rps: Add checks for freq = idle (RPn) in specific cases.
tests/pm_rps.c |
e user
specified minimum frequency to the "idle" or RPn frequency. Update the
pm_rps tests to reflect that droping below the user specified minimum
is no longer considered a failure.
v2: Add check RPn <= current freq. (Me)
Signed-off-by: Bob Paauwe <bob.j.paa...@intel.com>
m_property *drm_property_create_rgba(struct drm_device *dev,
> + int flags, const char *name);
> struct drm_property_blob *drm_property_create_blob(struct drm_device *dev,
> size_t length,
>
This only works because right now drm_rgba_t can represent black as 0,
but you're not honoring the abstraction. What if black really needed
to have alpha set or drm_rgba_t expands to more than 16 bits per color
or we just want to initialize the background color to something other
than black?
> +}
> +
> static vo
if the crtc has audio is enabled. Otherwise, when the first atomic
modeset happens it will warn when trying to drop the audio power
domain.
Signed-off-by: Bob Paauwe <bob.j.paa...@intel.com>
---
drivers/gpu/drm/i915/intel_display.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/d
version of the properties.
Until the driver is full atomic, make sure we update the non-atomic
version of the properties.
igt-testcase: kms_pipe_color / legacy-gamma-reset-pipeX
Signed-off-by: Bob Paauwe <bob.j.paa...@intel.com>
---
drivers/gpu/drm/i915/intel_display.
is out of sync with the
> values stored in the crtc object.
>
> Cc: Maarten Lankhorst <maarten.lankho...@linux.intel.com>
> Cc: Bob Paauwe <bob.j.paa...@intel.com>
> Cc: <dri-de...@lists.freedesktop.org>
> Signed-off-by: Lionel Landwerlin <lionel.g.landwer...@intel
1 - 100 of 227 matches
Mail list logo
