or cases where they have unique dma_fence_ops, and
>> > preferring to have descriptors for the whole fence context). strings do
>> > not pack as well into the ftrace ringbuffer and we would prefer to
>> > reduce the amount of indirect callbacks required for frequent tracepoin
Noralf Trønnes writes:
> Den 28.01.2019 21.57, skrev Rob Herring:
>> On Sun, Dec 2, 2018 at 9:59 AM Noralf Trønnes wrote:
>>>
>>>
>>> Den 30.11.2018 00.58, skrev Eric Anholt:
>>>> Daniel Vetter writes:
>>>>
>>>>> On Wed
Causes an oops in the current kernel.
---
tests/Makefile.am | 2 ++
tests/Makefile.sources | 1 +
tests/vc4_lookup_fail.c | 81 +
3 files changed, 84 insertions(+)
create mode 100644 tests/vc4_lookup_fail.c
diff --git a/tests/Makefile.am b
Daniel Vetter writes:
>
> Zooming out more looking at the big picture I'd say all your work in the
> past few years has enormously simplified drm for simple drivers already.
> If we can't resolve this one here right now that just means you "only"
> made drm 98% simpler instead of maybe 99%. It's s
Maarten Lankhorst writes:
> __drm_atomic_helper_crtc_destroy_state does not free memory, it only
> cleans it up. Fix this by calling the functions own destroy function.
Reviewed-by: Eric Anholt
signature.asc
Description: PGP signature
___
Int
Maarten Lankhorst writes:
> Convert vc4 to using __drm_atomic_helper_crtc_reset(), instead of
> writing its own version. Instead of open coding destroy_state(),
> call it directly for freeing the old state.
>
> Signed-off-by: Maarten Lankhorst
> Cc: Eric Anholt
> ---
&
Daniel Vetter writes:
> On Mon, Nov 26, 2018 at 04:36:21PM -0800, Eric Anholt wrote:
>> Noralf Trønnes writes:
>> > +static void drm_gem_shmem_vm_close(struct vm_area_struct *vma)
>> > +{
>> > + struct drm_gem_object *obj = vma->vm_private_data;
>
Petri Latvala writes:
> On Mon, Nov 26, 2018 at 12:46:46PM -0800, Eric Anholt wrote:
>> Petri Latvala writes:
>>
>> > On Wed, Nov 14, 2018 at 02:28:32PM -0800, Eric Anholt wrote:
>> >> These are basic non-rendering tests of the UABI.
>
Ville Syrjala writes:
> From: Ville Syrjälä
>
> Move the CEA-861 QS bit handling entirely into the edid code. No
> need to bother the drivers with this.
>
> Cc: Alex Deucher
> Cc: "Christian König"
> Cc: "David (ChunMing) Zhou"
> Cc:
Daniel Vetter writes:
> On Tue, Nov 27, 2018 at 12:38:44PM -0800, Eric Anholt wrote:
>> Daniel Vetter writes:
>>
>> > On Mon, Nov 26, 2018 at 04:36:21PM -0800, Eric Anholt wrote:
>> >> Noralf Trønnes writes:
>> >> > +static voi
Daniel Vetter writes:
> On Wed, Nov 28, 2018 at 01:52:56PM -0800, Eric Anholt wrote:
>> Daniel Vetter writes:
>>
>> > On Tue, Nov 27, 2018 at 12:38:44PM -0800, Eric Anholt wrote:
>> >> Daniel Vetter writes:
>> >>
>> >> &
Brian Starkey writes:
> Hi Matt,
>
> On Thu, Nov 15, 2018 at 02:13:45PM -0800, Matt Roper wrote:
>>Some display controllers can be programmed to present non-black colors
>>for pixels not covered by any plane (or pixels covered by the
>>transparent regions of higher planes). Compositors that want
Noralf Trønnes writes:
> drm_dev_register() initializes internal clients like bootsplash as the
> last thing it does, so all setup needs to be done at this point.
>
> Fix by calling vc4_kms_load() before registering.
> Also check the error code returned from that function.
>
great cleanup. I took a look at a lot of it.
Patch 1-2, 4-10, 41-47, 49-50, and all the gem_prime_import/export drop
patches are:
Reviewed-by: Eric Anholt
I don't currently have a plan for reading the shuffle in patch 3.
signature.asc
Description: PGP signature
__
> if (contended_lock != -1 && contended_lock >= i) {
> > bo = &exec->bo[contended_lock]->base;
> >
> > - ww_mutex_unlock(&bo->resv->lock);
> > + dma_resv_unlock(bo->resv);
> > }
> >
> > if (ret == -EDEADLK) {
> > --
> > 2.24.0
> >
Assuming they're supposed to be exactly equivalent currently,
Acked-by: Eric Anholt
but we should really just be using drm_gem_lock_reservations()
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
.. */
> > - ret =
> > ww_mutex_lock_slow_interruptible(&msm_obj->base.resv->lock,
> > - &submit->ticket);
> > + ret = dma_resv_lock_slow_interruptible(msm_obj->base.resv,
> > +&submit->ticket);
> > if (!ret) {
> > submit->bos[contended].flags |= BO_LOCKED;
> > slow_locked = contended;
> > --
> > 2.24.0
> >
Reviewed-by: Eric Anholt
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
bikeshed, so feel free to ignore.
>
> Signed-off-by: Daniel Vetter
> Cc: Eric Anholt
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
gt; different objects if there's multiple
> - compilers have an easier time too
>
> But also a bit a bikeshed, so feel free to ignore.
>
> Signed-off-by: Daniel Vetter
> Cc: Eric Anholt
a-b.
___
Intel-gfx mailing list
Intel-gfx@li
On Fri, Apr 3, 2020 at 6:58 AM Daniel Vetter wrote:
>
> Also allows us to simplify the unroll code since the drm_dev_put
> disappears.
>
> Signed-off-by: Daniel Vetter
Acked-by: Eric Anholt
___
Intel-gfx mailing list
Intel-gfx@lists.
On Fri, Apr 3, 2020 at 6:59 AM Daniel Vetter wrote:
>
> Already using devm_drm_dev_init, so very simple replacment.
>
> Signed-off-by: Daniel Vetter
Acked-by: Eric Anholt
___
Intel-gfx mailing list
Intel-gfx@lists.freedeskt
On Fri, Apr 3, 2020 at 6:58 AM Daniel Vetter wrote:
>
> And switch the helper over to container_of, which is a bunch faster
> than chasing a pointer. Plus allows gcc to see through this maze.
>
> Signed-off-by: Daniel Vetter
Acked-
"Noralf Trønnes"
> Cc: Sam Ravnborg
Acked-by: Eric Anholt
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Rob Clark writes:
> From: Rob Clark
>
> The driver should be in control of this.
>
> Signed-off-by: Rob Clark
> ---
> It is possible that this was masking bugs (ie. not setting appropriate
> pgprot) in drivers. I don't have a particularly good idea for tracking
> those down (since I don't have
Rob Clark writes:
> From: Rob Clark
>
> Since there is no real device associated with VGEM, it is impossible to
> end up with appropriate dev->dma_ops, meaning that we have no way to
> invalidate the shmem pages allocated by VGEM. So, at least on platforms
> without drm_cflush_pages(), we end u
r the setup to fix this issue.
>
> After a bit more prep in drivers and drm core v3d should be able to
> switch over to devm_drm_dev_init, which should clean this up further.
>
> Signed-off-by: Daniel Vetter
> Cc: Eric Anholt
Acked-by: Eric Anholt
_
On Fri, Feb 28, 2020 at 12:48 AM Dave Airlie wrote:
>
> On Fri, 28 Feb 2020 at 18:18, Daniel Stone wrote:
> >
> > On Fri, 28 Feb 2020 at 03:38, Dave Airlie wrote:
> > > b) we probably need to take a large step back here.
> > >
> > > Look at this from a sponsor POV, why would I give X.org/fd.o
>
Chris Wilson writes:
> Quoting Jordan Crouse (2018-04-05 23:06:53)
>> On Thu, Apr 05, 2018 at 04:00:47PM -0600, Jordan Crouse wrote:
>> > The i915 DRM driver very cleverly used ascii85 encoding for their
>> > GPU state file. Move the encode functions to a general header file to
>> > support other
' in
between.
Other than that,
Reviewed-by: Eric Anholt
Thanks!
signature.asc
Description: PGP signature
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Daniel Vetter writes:
> Noticed while I was typing docs. Entirely unused.
>
> Signed-off-by: Daniel Vetter
> ---
> include/linux/dma-fence.h | 10 --
> 1 file changed, 10 deletions(-)
>
> diff --git a/include/linux/dma-fence.h b/include/linux/dma-fence.h
> index 9d6f39bf2111..f9a6848f85
Daniel Vetter writes:
> dma_fence_default_wait is the default now, same for the trivial
> enable_signaling implementation.
>
> Signed-off-by: Daniel Vetter
Reviewed-by: Eric Anholt
signature.asc
Description: PGP signature
___
Intel
Daniel Vetter writes:
> dma_fence_default_wait is the default now, same for the trivial
> enable_signaling implementation.
>
> Signed-off-by: Daniel Vetter
Reviewed-by: Eric Anholt
signature.asc
Description: PGP signature
___
Intel
Daniel Vetter writes:
> dma_fence_default_wait is the default now, same for the trivial
> enable_signaling implementation.
Drop the mention of dma_fence_default_wait, since this one doesn't use
that? Other than that,
Reviewed-by: Eric Anholt
signature.asc
Description: PG
Daniel Vetter writes:
> dma_fence_default_wait is the default now, same for the trivial
> enable_signaling implementation.
Reviewed-by: Eric Anholt
signature.asc
Description: PGP signature
___
Intel-gfx mailing list
Intel-gfx@lists.freedeskt
Daniel Vetter writes:
> Noticed while I was typing docs. Entirely unused.
>
> v2: Remove reference in @timeline_value_str too. While at it clarify
> why timeline_value_str has a fence parameter - we don't have an
> explicit timeline structure unfortunately.
>
> Cc:
Maarten Lankhorst writes:
> Hey,
>
> Another pull request for drm-misc-next. Previous one was not applied yet,
> but only sending delta since last request:
> https://lists.freedesktop.org/archives/dri-devel/2018-May/175722.html
Note, I think this PR has a UABI regression in it:
https://patchwor
Sean Paul writes:
> On Fri, Oct 19, 2018 at 10:50:49AM +0200, Daniel Vetter wrote:
>> Hi all,
>>
>> This is just to collect feedback on this idea, and see whether the
>> overall dri-devel community stands on all this. I think the past few
>> cross-vendor uapi extensions all came with igts attach
ort the function and let drivers
> call it themselves
>
> Cc: Eric Anholt
> Cc: Dhinakaran Pandiyan
> Signed-off-by: Ville Syrjälä
> Reviewed-by: Dhinakaran Pandiyan
I don't particularly see the point in having FB creation duplicate the
validation that atomic che
long is different between 32 and 64 and should basically never be
used. Fixes compiler warning about passing the wrong type.
Signed-off-by: Eric Anholt
---
tests/kms_content_protection.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/kms_content_protection.c b
Copied from make headers_install at drm-misc-next 783195ec1cad
("drm/syncobj: disable the timeline UAPI for now v2")
Signed-off-by: Eric Anholt
---
include/drm-uapi/v3d_drm.h | 204 +
1 file changed, 204 insertions(+)
create mode 100644 includ
These are basic non-rendering tests of the UABI.
Signed-off-by: Eric Anholt
---
lib/igt_v3d.c | 4 --
tests/Makefile.am | 2 +
tests/Makefile.sources| 6 +++
tests/meson.build | 3 ++
tests/v3d_ci/README | 26 +
tests/v3d_ci/v3d.testlist
Just a few little ioctl wrappers that v3d tests will use.
Signed-off-by: Eric Anholt
---
lib/Makefile.sources | 2 +
lib/drmtest.c| 3 +
lib/drmtest.h| 1 +
lib/igt_v3d.c| 130 +++
lib/igt_v3d.h| 46
Ville Syrjälä writes:
> On Wed, Nov 14, 2018 at 02:28:29PM -0800, Eric Anholt wrote:
>> long is different between 32 and 64 and should basically never be
>> used. Fixes compiler warning about passing the wrong type.
>>
>> Signed-off-by: Eric Anholt
>> ---
&
ng the conditional dma_buf_vunmap() call in
> drm_gem_cma_free_object() safe.
>
> Signed-off-by: Noralf Trønnes
I didn't look through 1-3 much since they had acks, but 4/5 get my:
Reviewed-by: Eric Anholt
signature.asc
Description: PGP signature
___
Kenny Ho writes:
> Account for the total size of buffer object requested to amdgpu by
> buffer type on a per cgroup basis.
>
> x prefix in the control file name x.bo_requested.amd.stat signify
> experimental.
Why is a counting of the size of buffer objects ever allocated useful,
as opposed to th
Kenny Ho writes:
> Account for the number of command submitted to amdgpu by type on a per
> cgroup basis, for the purpose of profiling/monitoring applications.
For profiling other drivers, I've used perf tracepoints, which let you
get useful timelines of multiple events in the driver. Have you
Christian König writes:
> Am 20.11.18 um 21:57 schrieb Eric Anholt:
>> Kenny Ho writes:
>>
>>> Account for the number of command submitted to amdgpu by type on a per
>>> cgroup basis, for the purpose of profiling/monitoring applications.
>> For
Petri Latvala writes:
> On Wed, Nov 14, 2018 at 02:28:32PM -0800, Eric Anholt wrote:
>> These are basic non-rendering tests of the UABI.
>>
>> Signed-off-by: Eric Anholt
>> ---
>> lib/igt_v3d.c | 4 --
>> tests/Makefile.am |
Noralf Trønnes writes:
> +static void drm_gem_shmem_vm_close(struct vm_area_struct *vma)
> +{
> + struct drm_gem_object *obj = vma->vm_private_data;
> + struct drm_gem_shmem_object *shmem = to_drm_gem_shmem_obj(obj);
> +
> + drm_gem_shmem_put_pages(shmem);
> + drm_gem_vm_close(vma)
Daniel Vetter writes:
> Atomic helpers really want this instead of the hacked-up legacy
> backoff trick, which unfortunately prevents drivers from using their
> own private drm_modeset_locks.
>
> Aside: There's a few atomic drivers (nv50, vc4, soon vmwgfx) which
> don't yet use the new atomic col
This successfully catches vc4's lack of dmabuf fencing.
Signed-off-by: Eric Anholt
---
Has anyone looked into shared infrastructure for tests to do
KMS/dmabuf/etc. things with a generic "get a BO that's being rendered
to for this driver" call?
tests/Makefile.am
wayland/commit/?id=0eefe99fe0683ae409b665a8b18cc7eb648c6c0c
With the other wording nitpicks fixed,
Reviewed-by: Eric Anholt
I'm pleased to be part of a community that's working on building an
inclusive, welcoming, productive environment.
signature.asc
Description: PGP signature
Hans de Goede writes:
> HI,
>
> On 08-05-17 14:27, Chris Wilson wrote:
>> On Sun, May 07, 2017 at 11:10:56AM +0200, Hans de Goede wrote:
>>> On some (Bay Trail) devices the LCD panel is mounted upside-down.
>>>
>>> This commit uses the code to read back the initial rotation of the
>>> primary pla
Daniel Vetter writes:
> drm_plane_helper_disable is a non-atomic drivers only function, and
> will blow up (since no one passes the locking context it needs).
>
> Atomic drivers which want to quiescent their hw on unload should
> use drm_atomic_helper_shutdown() instead.
>
> v2: Rebase.
I've def
modifier yet, instead export the function and let drivers
> call it themselves
> v4: Unexport the functiona and put the format_default check back
> since this will again be called by the core, ie. undo v3 ;)
>
> Cc: Eric Anholt
> Testcase: igt/kms_addfb_basic/expe
Ville Syrjälä writes:
> On Thu, Mar 15, 2018 at 08:03:44PM +0200, Ville Syrjälä wrote:
>> On Thu, Mar 15, 2018 at 07:48:02PM +0200, Ville Syrjälä wrote:
>> > On Thu, Mar 15, 2018 at 10:42:17AM -0700, Eric Anholt wrote:
>> > > Ville Syrjala writes:
>&g
Maxime Ripard writes:
> [ Unknown signature status ]
> Hi,
>
> On Mon, Mar 05, 2018 at 03:21:26PM +0100, Maxime Ripard wrote:
>> Here is an RFC at starting to test the plane formats using the
>> Chamelium over the HDMI. This was tested using the vc4 DRM driver
>> found on the RaspberryPi.
>>
>>
if you keep the assumption that the core will check that the format
is one of plane->format_types.
>
> Cc: Eric Anholt
> References:
> https://lists.freedesktop.org/archives/dri-devel/2018-March/169782.html
> Signed-off-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/int
if your format and modifier was in drm_plane->format_types and
drm_plane->modifiers, since then you wouldn't be duplicating your tables
and you wouldn't need has_ccs either.
However, it's not my driver and it unblocks vc4's patch, so
Ville Syrjälä writes:
> On Mon, May 21, 2018 at 12:21:01PM -0700, Eric Anholt wrote:
>> Ville Syrjala writes:
>>
>> > From: Ville Syrjälä
>> >
>> > Up to now we've used the plane's modifier list as the primary
>> > source of inform
Noralf Trønnes writes:
> These are needed for pl111 to use the generic fbdev emulation.
Reviewed-by: Eric Anholt
signature.asc
Description: PGP signature
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.
Ville Syrjala writes:
> From: Ville Syrjälä
>
> We want to get rid of plane->fb/crtc on atomic drivers. Stop setting
> them.
>
> Cc: Eric Anholt
> Signed-off-by: Ville Syrjälä
> Reviewed-by: Maarten Lankhorst
> Reviewed-by: Daniel Vetter
Reviewed-by
Ville Syrjala writes:
> From: Ville Syrjälä
>
> Use drm_crtc_mask() where appropriate.
Reviewed-by: Eric Anholt
signature.asc
Description: PGP signature
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freede
Signed-off-by: Eric Anholt
---
lib/igt_vc4.c | 20
lib/igt_vc4.h | 1 +
2 files changed, 21 insertions(+)
diff --git a/lib/igt_vc4.c b/lib/igt_vc4.c
index 62e1345..15804e9 100644
--- a/lib/igt_vc4.c
+++ b/lib/igt_vc4.c
@@ -25,6 +25,7 @@
#include
#include
#include
Signed-off-by: Eric Anholt
---
lib/Makefile.sources | 2 +
lib/igt_vc4.c| 106 +++
lib/igt_vc4.h| 29 ++
3 files changed, 137 insertions(+)
create mode 100644 lib/igt_vc4.c
create mode 100644 lib/igt_vc4.h
diff
create-bo-0 fails on the current kernel, and it's something I want to
fix.
Signed-off-by: Eric Anholt
---
tests/Makefile.am | 2 ++
tests/Makefile.sources | 1 +
tests/vc4_create_bo.c | 91 ++
3 files changed, 94 insertions(+)
create
The pad subtest fails currently.
Signed-off-by: Eric Anholt
---
tests/Makefile.am | 2 ++
tests/Makefile.sources | 1 +
tests/vc4_wait_bo.c| 93 ++
3 files changed, 96 insertions(+)
create mode 100644 tests/vc4_wait_bo.c
diff --git a
These caught an unexpected bug with clear colors (we'd get the last
executed clear's color in our new BO), while failing to catch the bug
I'd been hoping to find all along.
Signed-off-by: Eric Anholt
---
tests/vc4_wait_bo.c | 41 +
1 f
Signed-off-by: Eric Anholt
---
tests/Makefile.am | 6 +
tests/Makefile.sources | 4 +++
tests/vc4_wait_seqno.c | 69 ++
3 files changed, 79 insertions(+)
create mode 100644 tests/vc4_wait_seqno.c
diff --git a/tests/Makefile.am b/tests
Signed-off-by: Eric Anholt
---
lib/drmtest.c | 16 ++--
lib/drmtest.h | 1 +
2 files changed, 15 insertions(+), 2 deletions(-)
diff --git a/lib/drmtest.c b/lib/drmtest.c
index 2896af0..7b2227f 100644
--- a/lib/drmtest.c
+++ b/lib/drmtest.c
@@ -100,6 +100,16 @@ static bool
Signed-off-by: Eric Anholt
---
lib/igt_vc4.c | 21 +++--
lib/igt_vc4.h | 1 +
tests/vc4_wait_bo.c | 10 ++
3 files changed, 18 insertions(+), 14 deletions(-)
diff --git a/lib/igt_vc4.c b/lib/igt_vc4.c
index 15804e9..0233f2b 100644
--- a/lib/igt_vc4.c
+++ b
Signed-off-by: Eric Anholt
---
configure.ac | 12
1 file changed, 12 insertions(+)
diff --git a/configure.ac b/configure.ac
index ecbfacd..cfbcbf3 100644
--- a/configure.ac
+++ b/configure.ac
@@ -149,6 +149,18 @@ if test "x$NOUVEAU" = xyes; then
fi
AM_CONDITIONAL(HA
Daniel Stone writes:
> Hi,
>
> On 3 February 2016 at 21:41, Eric Anholt wrote:
>> + ret = ioctl(fd, DRM_IOCTL_VC4_WAIT_BO, &arg);
>> + igt_assert(ret == -1 && errno == EINVAL);
>
> A couple of nitpicks: all these should
Daniel Vetter writes:
> Again since the drm core takes care of event unlinking/disarming this
> is now just needless code.
>
> v2: Fixup misplaced hunk.
>
> Cc: Eric Anholt
> Acked-by: Daniel Stone
> Reviewed-by: Alex Deucher (v1)
> Signed-off-by: Daniel Vetter
I
It's autodetected if its dependencies are present, but it doesn't
build for ARM, nor am I interested in it for now.
Signed-off-by: Eric Anholt
---
configure.ac | 15 ---
1 file changed, 12 insertions(+), 3 deletions(-)
diff --git a/configure.ac b/configure.ac
index ddfe69
Daniel has suggested that I put vc4 testing into igt, since it's got
the piglit integration and KMS coverage already. This gets the ccore
building so that I can start writing tests.
---
lib/igt_gt.c | 4
1 file changed, 4 insertions(+)
diff --git a/lib/igt_gt.c b/lib/igt_gt.c
index 149435c.
e checks back to drivers (Ville Syrjälä)
>
> v2: move fb setting to core and use new state (Eric Anholt)
Given that vc4 isn't using drm_atomic_helper_commit(), isn't this
effectively disabling async cursor updates on vc4?
signature.asc
Description: PGP signature
__
x27;t do an async update if there is an outstanding commit modifying
* the plane. This prevents our async update's changes from getting
* overridden by a previous synchronous update's state.
*/
(assuming I understand its intent correctly)
I don't understand KMS lo
Daniel Vetter writes:
> On Mon, Apr 10, 2017 at 06:24:32PM -0700, Eric Anholt wrote:
>> This successfully catches vc4's lack of dmabuf fencing.
>>
>> Signed-off-by: Eric Anholt
>> ---
>>
>> Has anyone looked into shared infrastructure for tests to
ering, so no need to test that.
Signed-off-by: Eric Anholt
---
lib/igt_vc4.c | 21
lib/igt_vc4.h | 3 ++
tests/Makefile.am | 2 +
tests/Makefile.sources | 1 +
tests/vc4_tiling.c | 137 +
5 files changed
This makes my emacs default to consistent indentation for the project.
Signed-off-by: Eric Anholt
---
.editorconfig | 9 +
1 file changed, 9 insertions(+)
create mode 100644 .editorconfig
diff --git a/.editorconfig b/.editorconfig
new file mode 100644
index ..bdfebacaf4cd
CONTRIBUTING requests that people do this, but it's a lot easier if we
just set it up by default for them.
Signed-off-by: Eric Anholt
---
I missed this step on my previous two patches, so let's just prevent
that in the future. :(
autogen.sh | 3 +++
1 file changed, 3 insertion
With this squashed in, the vc4 patch is:
Reviewed-by: Eric Anholt
Signed-off-by: Eric Anholt
---
Without this, the cursor never moved :)
drivers/gpu/drm/vc4/vc4_plane.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/vc4/vc4_plane.c b/drivers/gpu/drm/vc4/vc4_plane.c
So far this test is basically making sure that we throw appropriate
errors, and don't oops the kernel with silly inputs.
Signed-off-by: Eric Anholt
---
tests/Makefile.am | 2 ++
tests/Makefile.sources | 1 +
tests/vc4_label_bo.c
ng list first.
> + Testcase should preferrably be cross-reviewed by the same people who write
> and
> + review the kernel feature itself.
Thanks for considering my case here :)
Acked-by: Eric Anholt
signature.asc
Description: PGP signature
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Boris Brezillon writes:
> On Wed, 27 Sep 2017 13:50:30 +0100
> Chris Wilson wrote:
>
>> Quoting Boris Brezillon (2017-09-27 13:41:41)
>> > Hi Chris,
>> >
>> > On Wed, 27 Sep 2017 13:07:28 +0100
>> > Chris Wilson wrote:
>> >
>> > > Quoting Boris Brezillon (2017-09-27 12:51:18)
>> > > > +st
Boris Brezillon writes:
> Signed-off-by: Boris Brezillon
Another test we should have: Queue up a big rendering job (Copy a
2048x2048@32bpp BO?), mark the source purgeable, force the purge, wait
for rendering, make sure we correctly rendered, and maybe have some
sanity-checking of purgeable stat
It's got calls to rmb/wmb that end up not linking successfully.
Signed-off-by: Eric Anholt
---
meson.build | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index 1cc501f3062f..7a09228292fd 100644
--- a/meson.build
+++ b/meson.build
@@ -
Just stub out the features return value, and return an empty string.
Signed-off-by: Eric Anholt
---
lib/igt_x86.h | 12
lib/meson.build | 5 -
2 files changed, 16 insertions(+), 1 deletion(-)
diff --git a/lib/igt_x86.h b/lib/igt_x86.h
index 589d224bec62..d6dcfa108331 100644
Signed-off-by: Eric Anholt
---
benchmarks/prime_lookup.c | 2 +-
tests/gem_exec_reuse.c| 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/benchmarks/prime_lookup.c b/benchmarks/prime_lookup.c
index e995b766a173..d6c397299fcb 100644
--- a/benchmarks/prime_lookup.c
+++ b
Jani Nikula writes:
> drm_add_edid_modes() now fills in the ELD automatically, so the calls to
> drm_edid_to_eld() are redundant. Remove them.
>
> All the other places are obvious, but nv50 has detached
> drm_edid_to_eld() from the drm_add_edid_modes() call.
Nice! For vc4,
Sean Paul writes:
> On Wed, Nov 1, 2017 at 7:12 AM, Gustavo Padovan wrote:
>> 2017-10-31 Sean Paul :
>>
>>> On Tue, Oct 31, 2017 at 1:31 PM, Daniel Vetter wrote:
>>> > On Tue, Oct 31, 2017 at 5:14 PM, Sean Paul wrote:
>>> >> On Tue, Oct 31, 2017 at 4:27 AM, Jani Nikula
>>> >> wrote:
>>> >>>
>
. And if
> we ever encounter a HDMI 2.0+ sink with this bug that's what
> we'll probably have to do.
Should vc4 be doing anything special for HDMI2 sinks, if it's an HDMI1.4
source?
That said, as far as vc4, this patch is
Acked-by: Eric Anholt
signature.asc
Description: PG
Ville Syrjälä writes:
> On Wed, Nov 08, 2017 at 12:17:28PM -0800, Eric Anholt wrote:
>> Ville Syrjala writes:
>>
>> > From: Ville Syrjälä
>> >
>> > Apparently some sinks look at the YQ bits even when receiving RGB,
>> > and they get somehow
Daniel Vetter writes:
> On Wed, Nov 08, 2017 at 02:21:08PM -0800, Eric Anholt wrote:
>> Ville Syrjälä writes:
>>
>> > On Wed, Nov 08, 2017 at 12:17:28PM -0800, Eric Anholt wrote:
>> >> Ville Syrjala writes:
>> >>
>> >> > From: V
OCAL_* define hacks that have been proliferating in the tree)
I started on converting i915 to not use LOCAL_*, but it's more than
I'm willing to complete.
Eric Anholt (5):
headers: Import drm-next uapi headers.
tests: Convert to using the imported drm-uapi headers.
tests: Re
The autotools build retains the configure.ac option, while meson folds
vc4 into the default build since we don't have any meson_options.txt
to control parts of the build.
Signed-off-by: Eric Anholt
---
configure.ac | 12
lib/Makefile.am | 2 +-
lib/meson.build
The MMAP_V2 is replaced by just using MMAP, since the official header
has the updated struct. The gem_create_v2 and gem_get_aperture are
left as is, because they seem to not be reflected in the UABI header!
Signed-off-by: Eric Anholt
---
benchmarks/Makefile.am | 6 -
benchmarks/gem_wsim.c
Signed-off-by: Eric Anholt
---
lib/ioctl_wrappers.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c
index 7ad2b7b007c4..d98e7660a96f 100644
--- a/lib/ioctl_wrappers.c
+++ b/lib/ioctl_wrappers.c
@@ -1663,7 +1663,7 @@ void
Tested by dropping garbage in my libdrm's headers and rebuilding.
Signed-off-by: Eric Anholt
---
lib/Makefile.am | 5 -
meson.build | 2 +-
tests/Makefile.am | 1 +
3 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/lib/Makefile.am b/lib/Makefile.am
index 30ddb92
Lionel Landwerlin writes:
> On 10/11/17 21:26, Eric Anholt wrote:
>> Tested by dropping garbage in my libdrm's headers and rebuilding.
>>
>> Signed-off-by: Eric Anholt
>> ---
>> lib/Makefile.am | 5 -
>> meson.build | 2 +-
>>
1 - 100 of 662 matches
Mail list logo
