Re: [Intel-gfx] [PATCH] drm/i915: Disable RPM wakeref assertions during driver shutdown

Hi, On 1/4/21 9:39 PM, Chris Wilson wrote: > As with the regular suspend paths, also disable the wakeref assertions > as we disable the driver during shutdown. > > Reported-by: Hans de Goede > Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/2899 > Fixes: fe0f1e3bfdf

Re: [Intel-gfx] [PATCH] drm/i915/dsi: Use unconditional msleep for the panel_on_delay when there is no reset-deassert MIPI-sequence

Hi, On 11/24/20 4:49 PM, Ville Syrjälä wrote: > On Wed, Nov 18, 2020 at 01:40:58PM +0100, Hans de Goede wrote: >> Commit 25b4620ee822 ("drm/i915/dsi: Skip delays for v3 VBTs in vid-mode") >> added an intel_dsi_msleep() helper which skips sleeping if the >> MIPI-s

Re: [Intel-gfx] [PATCH v2 2/9] drm: Add privacy-screen class (v2)

-req-s to GNOME. > On Wed, 21 Apr 2021 at 21:48, Hans de Goede wrote: > >> --- /dev/null >> +++ b/drivers/gpu/drm/drm_privacy_screen.c > >> +#include "drm_internal.h" > > I think we don't need this include, do we? The drm_privacy_screen device

[Intel-gfx] [PATCH 0/8] drm + usb-type-c: Add support for out-of-band hotplug notification (v4)

es not see a whole lot of changes. So I believe it would be best to just merge the entire series through drm-misc, Assuming we can get an ack from Greg for merging the typec_displayport.c changes this way. Regards, Hans Hans de Goede (7): drm/connector: Give connector sysfs devices there own de

[Intel-gfx] [PATCH 1/8] drm/connector: Give connector sysfs devices there own device_type

: Heikki Krogerus Signed-off-by: Hans de Goede --- drivers/gpu/drm/drm_sysfs.c | 50 +++-- 1 file changed, 37 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c index 968a9560b4aa..f9d92bbb1f98 100644 --- a/drivers/gpu

[Intel-gfx] [PATCH 2/8] drm/connector: Add a fwnode pointer to drm_connector and register with ACPI (v2)

are properly matched. Changes in v2: - Make drm_connector_cleanup() call fwnode_handle_put() on connector->fwnode and document this Co-developed-by: Heikki Krogerus Signed-off-by: Heikki Krogerus Tested-by: Heikki Krogerus Signed-off-by: Hans de Goede --- drivers/gpu/drm/drm_connecto

[Intel-gfx] [PATCH 3/8] drm/connector: Add drm_connector_find_by_fwnode() function (v3)

-iter in drm_sysfs.c Changes in v3: - Add forward declaration for struct fwnode_handle to drm_crtc_internal.h (fixes warning reported by kernel test robot ) Tested-by: Heikki Krogerus Signed-off-by: Hans de Goede --- drivers/gpu/drm/drm_connector.c | 50 + drivers

[Intel-gfx] [PATCH 4/8] drm/connector: Add support for out-of-band hotplug notification (v3)

o the drm_connector_oob_hotplug_event function since it is not used atm. This can be re-added later when a use for it actually arises. Tested-by: Heikki Krogerus Signed-off-by: Hans de Goede --- drivers/gpu/drm/drm_connector.c | 27 +++ include/drm/drm_connector.h | 9 +++

[Intel-gfx] [PATCH 5/8] drm/i915: Associate ACPI connector nodes with connector entries (v2)

connector node for a connector entry straightforward (it's one-on-one mapping). Changes in v2 (Hans de goede): - Take a reference on the fwnode which we assign to the connector, for ACPI nodes this is a no-op but in the future we may see software-fwnodes assigned to connectors which are ref-co

[Intel-gfx] [PATCH 6/8] drm/i915/dp: Add support for out-of-bound hotplug events

ommit adds support for this. Together with the recent addition of DP alt-mode support to the Type-C subsystem this makes DP over Type-C work on these devices. Tested-by: Heikki Krogerus Signed-off-by: Hans de Goede --- drivers/gpu/drm/i915/display/intel_dp.c | 12 1 file changed, 12

[Intel-gfx] [PATCH 7/8] usb: typec: altmodes/displayport: Make dp_altmode_notify() more generic

Make dp_altmode_notify() handle the dp->data.conf == 0 case too, rather then having separate code-paths for this in various places which call it. Reviewed-by: Heikki Krogerus Tested-by: Heikki Krogerus Signed-off-by: Hans de Goede --- drivers/usb/typec/altmodes/displayport.c |

[Intel-gfx] [PATCH 8/8] usb: typec: altmodes/displayport: Notify drm subsys of hotplug events

Use the new drm_connector_oob_hotplug_event() functions to let drm/kms drivers know about DisplayPort over Type-C hotplug events. Reviewed-by: Heikki Krogerus Tested-by: Heikki Krogerus Signed-off-by: Hans de Goede --- Changes in v3: - Only call drm_connector_oob_hotplug_event() on hpd status

Re: [Intel-gfx] Computation of return value being discarded in get_cpu_power() in drivers/platform/x86/intel_ips.c

Hi, On 6/10/21 1:55 PM, Joonas Lahtinen wrote: > (Address for Hans was corrupt in previous message, which confused my mail > client. Sorry for duplicate message, the other is without From: field). > > + Jesse > > Quoting Colin Ian King (2021-06-09 14:50:07) >> Hi, >> >> I was reviewing some old

Re: [Intel-gfx] [PATCH 0/8] drm + usb-type-c: Add support for out-of-band hotplug notification (v4)

Hi, On 6/15/21 9:40 AM, Greg Kroah-Hartman wrote: > On Fri, Jun 04, 2021 at 09:48:32PM +0200, Hans de Goede wrote: >> Here is v3 of my patchset making DP over Type-C work on devices where the >> Type-C controller does not drive the HPD pin on the GPU, but instead >> we need

Re: [Intel-gfx] [PATCH v2 0/4] drm/dp, drm/i915: Finish basic PWM support for VESA backlight helpers

Hi, On 10/5/21 10:26 PM, Lyude Paul wrote: > On Sat, 2021-10-02 at 11:14 +0200, Hans de Goede wrote: >> Hi Lyude, >> >> On 10/2/21 12:53 AM, Lyude Paul wrote: >>> When I originally moved all of the VESA backlight code in i915 into DRM >>> helpers, one of t

Re: [Intel-gfx] [PATCH v2 0/4] drm/dp, drm/i915: Finish basic PWM support for VESA backlight helpers

Hi, On 10/7/21 11:54 AM, Hans de Goede wrote: > Hi, > > On 10/5/21 10:26 PM, Lyude Paul wrote: >> On Sat, 2021-10-02 at 11:14 +0200, Hans de Goede wrote: >>> Hi Lyude, >>> >>> On 10/2/21 12:53 AM, Lyude Paul wrote: >>>> When I originally

Re: [Intel-gfx] [PATCH 1/1] usb: typec: altmodes/displayport: reorder dp_altmode_configured()

Hi, On 10/6/21 6:32 AM, lindsey.stanp...@gmail.com wrote: > From: Cameron Nemo > > A recent commit [1] introduced an unintended behavioral change by > reordering certain function calls. The sysfs_notify call for > pin_assignment should only be invoked when the dp_altmode_notify call > returns 0,

Re: [Intel-gfx] [PATCH 1/1] drm/i915: split out vlv sideband to a separate file

Lucas De Marchi > Cc: Ville Syrjälä > Signed-off-by: Jani Nikula Thanks, patch looks good to me: Reviewed-by: Hans de Goede Feel free to keep the Reviewed-by if you do a new version with the improved commit msg suggested by Ville. Regards, Hans > --- > drivers/gpu/drm/i9

Re: [Intel-gfx] [PULL] drm-misc-next

Hi, On 10/14/21 2:04 PM, Maxime Ripard wrote: > Hi Dave, Daniel, > > Here's this week drm-misc-next PR > > Maxime > > drm-misc-next-2021-10-14: > drm-misc-next for 5.16: Ugh, this just missed the drm-privacy-screen work which I just pushed out to drm-misc-next (I was waiting for the last i915

Re: [Intel-gfx] [PULL] drm-misc-next

Hi, On 10/14/21 3:24 PM, Hans de Goede wrote: > Hi, > > On 10/14/21 2:04 PM, Maxime Ripard wrote: >> Hi Dave, Daniel, >> >> Here's this week drm-misc-next PR >> >> Maxime >> >> drm-misc-next-2021-10-14: >> drm-misc-next for 5.16:

[Intel-gfx] [PATCH] drm/i915: Add NO_VLV_DISP_PW_DPIO_CMN_BC_INIT quirk

: Tsuchiya Yuto Signed-off-by: Hans de Goede --- drivers/gpu/drm/i915/display/intel_display.c | 4 ++-- .../gpu/drm/i915/display/intel_display_power.c | 16 ++-- drivers/gpu/drm/i915/display/intel_quirks.c | 10 ++ drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [PATCH] drm/i915/vlv_dsi: Double pixelclock on read-back for dual-link panels

-link DSI panel. Note this fix was taken from icl_dsi.c which does the same in its get_config(). Cc: Tsuchiya Yuto Signed-off-by: Hans de Goede --- drivers/gpu/drm/i915/display/vlv_dsi.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/display/vlv_dsi.c b/drivers/gp

Re: [Intel-gfx] [PATCH] drm/i915: Add NO_VLV_DISP_PW_DPIO_CMN_BC_INIT quirk

Hi, On 10/25/21 10:25, Jani Nikula wrote: > On Sun, 24 Oct 2021, Hans de Goede wrote: >> Add a NO_VLV_DISP_PW_DPIO_CMN_BC_INIT quirk to fix i915 not working on >> the Xiaomi Mi Pad 2 (with CHT x5-Z8500 SoC). >> >> The Xiaomi Mi Pad 2 uses quite an unusual hardware-d

Re: [Intel-gfx] [PATCH] drm/i915: Add NO_VLV_DISP_PW_DPIO_CMN_BC_INIT quirk

Hi, On 10/27/21 15:38, Ville Syrjälä wrote: > On Sun, Oct 24, 2021 at 05:50:10PM +0200, Hans de Goede wrote: >> Add a NO_VLV_DISP_PW_DPIO_CMN_BC_INIT quirk to fix i915 not working on >> the Xiaomi Mi Pad 2 (with CHT x5-Z8500 SoC). >> >> The Xiaomi Mi Pad 2 uses quite

Re: [Intel-gfx] [GIT PULL] drm-misc + drm-intel: Add support for out-of-band hotplug notification

Hi, On 8/26/21 1:43 PM, Vivi, Rodrigo wrote: > On Thu, 2021-08-26 at 10:23 +0200, Maxime Ripard wrote: >> On Wed, Aug 25, 2021 at 04:03:43PM +, Vivi, Rodrigo wrote: >>> On Tue, 2021-08-24 at 18:48 +0200, Hans de Goede wrote: >>>> Hi, >>>> >>>

Re: [Intel-gfx] [PATCH 2/9] drm: Add privacy-screen class (v3)

Hi Lyude, Thank you very much for the review of this series. On 9/15/21 10:01 PM, Lyude Paul wrote: > On Mon, 2021-09-06 at 09:35 +0200, Hans de Goede wrote: >> On some new laptops the LCD panel has a builtin electronic privacy-screen. >> We want to export this functionality as a

Re: [Intel-gfx] [PATCH 4/9] drm/privacy-screen: Add notifier support

Hi, On 9/15/21 10:26 PM, Lyude Paul wrote: > On Mon, 2021-09-06 at 09:35 +0200, Hans de Goede wrote: >> Add support for privacy-screen consumers to register a notifier to >> be notified of external (e.g. done by the hw itself on a hotkey press) >> state changes. >> &

Re: [Intel-gfx] [PATCH 8/9] platform/x86: thinkpad_acpi: Register a privacy-screen device

Hi, On 9/15/21 10:55 PM, Lyude Paul wrote: > On Mon, 2021-09-06 at 09:35 +0200, Hans de Goede wrote: >> Register a privacy-screen device on laptops with a privacy-screen, >> this exports the PrivacyGuard features to user-space using a >> standardized vendor-agnostic sysf

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Add privacy-screen support

Hi, On 9/15/21 11:11 PM, Lyude Paul wrote: > On Mon, 2021-09-06 at 09:35 +0200, Hans de Goede wrote: >> Add support for eDP panels with a built-in privacy screen using the >> new drm_privacy_screen class. >> >> One thing which stands out here is the a

Re: [Intel-gfx] [PATCH 3/9] drm/privacy-screen: Add X86 specific arch init code

Hi, On 9/16/21 10:51 AM, Jani Nikula wrote: > On Mon, 06 Sep 2021, Hans de Goede wrote: >> Add X86 specific arch init code, which fills the privacy-screen lookup >> table by checking for various vendor specific ACPI interfaces for >> controlling the privacy-screen. >&

Re: [Intel-gfx] [PATCH 0/9] drm: Add privacy-screen class and connector properties

n this series? Regards, Hans > > On Mon, 2021-09-06 at 09:35 +0200, Hans de Goede wrote: >> Hi all, >> >> Here is the privacy-screen related code which I last posted in April 2021 >> To the best of my knowledge there is consensus about / everyone is in >>

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Add privacy-screen support

Hi, On 9/16/21 11:40 AM, Jani Nikula wrote: > > Cc: Ville for input here, see question inline. > > On Mon, 06 Sep 2021, Hans de Goede wrote: >> Add support for eDP panels with a built-in privacy screen using the >> new drm_privacy_screen class. >> >> On

Re: [Intel-gfx] [PATCH 8/8] usb: typec: altmodes/displayport: Notify drm subsys of hotplug events

Hi, On 9/16/21 5:20 AM, Stephen Boyd wrote: > Quoting Hans de Goede (2021-08-17 14:52:01) >> diff --git a/drivers/usb/typec/altmodes/displayport.c >> b/drivers/usb/typec/altmodes/displayport.c >> index aa669b9cf70e..c1d8c23baa39 100644 >> --- a/drivers/usb/typec/altm

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Add privacy-screen support

Hi, On 9/16/21 4:04 PM, Ville Syrjälä wrote: > On Thu, Sep 16, 2021 at 12:40:11PM +0300, Jani Nikula wrote: >> >> Cc: Ville for input here, see question inline. >> >> On Mon, 06 Sep 2021, Hans de Goede wrote: >>> Add support for eDP panels with a built

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Add privacy-screen support

Hi, On 9/16/21 3:45 PM, Ville Syrjälä wrote: > On Mon, Sep 06, 2021 at 09:35:19AM +0200, Hans de Goede wrote: >> Add support for eDP panels with a built-in privacy screen using the >> new drm_privacy_screen class. >> >> One thing which stands out here is the a

Re: [Intel-gfx] [PATCH 9/9] drm/i915: Add privacy-screen support

Hi, On 9/17/21 6:25 PM, Ville Syrjälä wrote: > On Fri, Sep 17, 2021 at 04:37:14PM +0200, Hans de Goede wrote: >> Hi, >> >> On 9/16/21 3:45 PM, Ville Syrjälä wrote: >>> On Mon, Sep 06, 2021 at 09:35:19AM +0200, Hans de Goede wrote: >>>> Add support for

Re: [Intel-gfx] [PATCH v2 0/4] drm/dp, drm/i915: Finish basic PWM support for VESA backlight helpers

Hi Lyude, On 10/2/21 12:53 AM, Lyude Paul wrote: > When I originally moved all of the VESA backlight code in i915 into DRM > helpers, one of the things I didn't have the hardware or time for > testing was machines that used a combination of PWM and DPCD in order to > control their backlights. This

[Intel-gfx] [PATCH 01/10] drm/connector: Add support for privacy-screen properties (v4)

From: Rajat Jain Add support for generic electronic privacy screen properties, that can be added by systems that have an integrated EPS. Changes in v2 (Hans de Goede) - Create 2 properties, "privacy-screen sw-state" and "privacy-screen hw-state", to deal with devices w

[Intel-gfx] [PATCH 00/10] drm: Add privacy-screen class and connector properties

acpi when the i915 driver is added to the initrd. Without this the loading of the i915 driver will be delayed to after the switch to real rootfs. Regards, Hans Hans de Goede (9): drm: Add privacy-screen class (v4) drm/privacy-screen: Add X86 specific arch init code drm/privacy-screen: Add

[Intel-gfx] [PATCH 02/10] drm: Add privacy-screen class (v4)

an uninitialized variable warning when CONFIG_DRM_PRIVICAY_SCREEN is not set Changes in v4: - Make drm_privacy_screen_set_sw_state() skip calling out to the hw if hw_state == new_sw_state Reviewed-by: Emil Velikov Reviewed-by: Lyude Paul Signed-off-by: Hans de Goede --- Documentation/gpu

[Intel-gfx] [PATCH 03/10] drm/privacy-screen: Add X86 specific arch init code

Velikov Reviewed-by: Lyude Paul Signed-off-by: Hans de Goede --- drivers/gpu/drm/Makefile | 2 +- drivers/gpu/drm/drm_privacy_screen_x86.c | 86 include/drm/drm_privacy_screen_machine.h | 5 ++ 3 files changed, 92 insertions(+), 1 deletion(-) create mode

[Intel-gfx] [PATCH 04/10] drm/privacy-screen: Add notifier support (v2)

another thread, which would lead to a false-positive triggering of the check Reviewed-by: Emil Velikov Reviewed-by: Lyude Paul Signed-off-by: Hans de Goede --- drivers/gpu/drm/drm_privacy_screen.c | 64 +++ include/drm/drm_privacy_screen_consumer.h | 15 ++ incl

[Intel-gfx] [PATCH 05/10] drm/connector: Add a drm_connector privacy-screen helper functions (v2)

ector_state as argument instead of a full drm_atomic_state. This allows the helper to be called by drivers when they are enabling crtcs/encoders/connectors. Reviewed-by: Emil Velikov Reviewed-by: Lyude Paul Signed-off-by: Hans de Goede --- drivers/gpu/drm/drm_connec

[Intel-gfx] [PATCH 07/10] platform/x86: thinkpad_acpi: Get privacy-screen / lcdshadow ACPI handles only once

Get the privacy-screen / lcdshadow ACPI handles once and cache them, instead of retrieving them every time we need them. Reviewed-by: Emil Velikov Reviewed-by: Lyude Paul Signed-off-by: Hans de Goede --- drivers/platform/x86/thinkpad_acpi.c | 18 -- 1 file changed, 8

[Intel-gfx] [PATCH 10/10] drm/i915: Add privacy-screen support (v2)

intel_atomic_commit_tail() - Move the probe-deferral check to the intel_modeset_probe_defer() helper Signed-off-by: Hans de Goede --- drivers/gpu/drm/i915/display/intel_atomic.c | 1 + drivers/gpu/drm/i915/display/intel_ddi.c | 3 +++ drivers/gpu/drm/i915/display/intel_display.c | 10 ++ drivers

[Intel-gfx] [PATCH 09/10] drm/i915: Add intel_modeset_probe_defer() helper

-by: Hans de Goede --- drivers/gpu/drm/i915/display/intel_display.c | 13 + drivers/gpu/drm/i915/display/intel_display.h | 1 + drivers/gpu/drm/i915/i915_pci.c | 9 ++--- 3 files changed, 16 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/display

[Intel-gfx] [PATCH 08/10] platform/x86: thinkpad_acpi: Register a privacy-screen device

Velikov Reviewed-by: Lyude Paul Signed-off-by: Hans de Goede --- Changes in v3: - On receiving a TP_HKEY_EV_PRIVACYGUARD_TOGGLE event only call drm_privacy_screen_call_notifier_chain() if the privacy-screen state has actually changed Changes in v2: - Make the new lcdshadow_set_sw_state

[Intel-gfx] [PATCH 06/10] platform/x86: thinkpad_acpi: Add hotkey_notify_extended_hotkey() helper

...). Reviewed-by: Emil Velikov Reviewed-by: Lyude Paul Signed-off-by: Hans de Goede --- drivers/platform/x86/thinkpad_acpi.c | 30 ++-- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c

Re: [Intel-gfx] [PATCH 05/10] drm/connector: Add a drm_connector privacy-screen helper functions (v2)

Hi, On 10/4/21 5:22 PM, Ville Syrjälä wrote: > On Sat, Oct 02, 2021 at 06:36:13PM +0200, Hans de Goede wrote: >> Add 2 drm_connector privacy-screen helper functions: >> >> 1. drm_connector_attach_privacy_screen_provider(), this function creates >> and attaches

Re: [Intel-gfx] [PATCH 10/10] drm/i915: Add privacy-screen support (v2)

Hi, On 10/4/21 5:37 PM, Ville Syrjälä wrote: > On Sat, Oct 02, 2021 at 06:36:18PM +0200, Hans de Goede wrote: >> Add support for eDP panels with a built-in privacy screen using the >> new drm_privacy_screen class. >> >> Changes in v2: >> - Call drm_conne

[Intel-gfx] [PATCH 00/10] drm: Add privacy-screen class and connector properties

trd generation tools will need to be updated to include thinkpad_acpi when the i915 driver is added to the initrd. Without this the loading of the i915 driver will be delayed to after the switch to real rootfs. Regards, Hans Hans de Goede (9): drm: Add privacy-screen class (v4) drm/privacy

[Intel-gfx] [PATCH 01/10] drm/connector: Add support for privacy-screen properties (v4)

From: Rajat Jain Add support for generic electronic privacy screen properties, that can be added by systems that have an integrated EPS. Changes in v2 (Hans de Goede) - Create 2 properties, "privacy-screen sw-state" and "privacy-screen hw-state", to deal with devices w

[Intel-gfx] [PATCH 02/10] drm: Add privacy-screen class (v4)

an uninitialized variable warning when CONFIG_DRM_PRIVICAY_SCREEN is not set Changes in v4: - Make drm_privacy_screen_set_sw_state() skip calling out to the hw if hw_state == new_sw_state Reviewed-by: Emil Velikov Reviewed-by: Lyude Paul Signed-off-by: Hans de Goede --- Documentation/gpu

[Intel-gfx] [PATCH 03/10] drm/privacy-screen: Add X86 specific arch init code

Velikov Reviewed-by: Lyude Paul Signed-off-by: Hans de Goede --- drivers/gpu/drm/Makefile | 2 +- drivers/gpu/drm/drm_privacy_screen_x86.c | 86 include/drm/drm_privacy_screen_machine.h | 5 ++ 3 files changed, 92 insertions(+), 1 deletion(-) create mode

[Intel-gfx] [PATCH 04/10] drm/privacy-screen: Add notifier support (v2)

another thread, which would lead to a false-positive triggering of the check Reviewed-by: Emil Velikov Reviewed-by: Lyude Paul Signed-off-by: Hans de Goede --- drivers/gpu/drm/drm_privacy_screen.c | 64 +++ include/drm/drm_privacy_screen_consumer.h | 15 ++ incl

[Intel-gfx] [PATCH 05/10] drm/connector: Add a drm_connector privacy-screen helper functions (v2)

ector_state as argument instead of a full drm_atomic_state. This allows the helper to be called by drivers when they are enabling crtcs/encoders/connectors. Reviewed-by: Emil Velikov Reviewed-by: Lyude Paul Signed-off-by: Hans de Goede --- drivers/gpu/drm/drm_connec

[Intel-gfx] [PATCH 06/10] platform/x86: thinkpad_acpi: Add hotkey_notify_extended_hotkey() helper

...). Reviewed-by: Emil Velikov Reviewed-by: Lyude Paul Signed-off-by: Hans de Goede --- drivers/platform/x86/thinkpad_acpi.c | 30 ++-- 1 file changed, 19 insertions(+), 11 deletions(-) diff --git a/drivers/platform/x86/thinkpad_acpi.c b/drivers/platform/x86/thinkpad_acpi.c

[Intel-gfx] [PATCH 07/10] platform/x86: thinkpad_acpi: Get privacy-screen / lcdshadow ACPI handles only once

Get the privacy-screen / lcdshadow ACPI handles once and cache them, instead of retrieving them every time we need them. Reviewed-by: Emil Velikov Reviewed-by: Lyude Paul Signed-off-by: Hans de Goede --- drivers/platform/x86/thinkpad_acpi.c | 18 -- 1 file changed, 8

[Intel-gfx] [PATCH 08/10] platform/x86: thinkpad_acpi: Register a privacy-screen device

Velikov Reviewed-by: Lyude Paul Signed-off-by: Hans de Goede --- Changes in v3: - On receiving a TP_HKEY_EV_PRIVACYGUARD_TOGGLE event only call drm_privacy_screen_call_notifier_chain() if the privacy-screen state has actually changed Changes in v2: - Make the new lcdshadow_set_sw_state

[Intel-gfx] [PATCH 09/10] drm/i915: Add intel_modeset_probe_defer() helper

: Ville Syrjälä Signed-off-by: Hans de Goede --- drivers/gpu/drm/i915/display/intel_display.c | 13 + drivers/gpu/drm/i915/display/intel_display.h | 1 + drivers/gpu/drm/i915/i915_pci.c | 9 ++--- 3 files changed, 16 insertions(+), 7 deletions(-) diff --git a

[Intel-gfx] [PATCH 10/10] drm/i915: Add privacy-screen support (v3)

() / intel_ddi_update_pipe_dp() instead of adding a for_each_new_connector_in_state() loop to intel_atomic_commit_tail() - Move the probe-deferral check to the intel_modeset_probe_defer() helper Signed-off-by: Hans de Goede --- drivers/gpu/drm/i915/display/intel_atomic.c | 1 + drivers/gpu/drm/i915/display/intel_ddi.c

Re: [Intel-gfx] [PATCH 5/9] drm/i915: Associate ACPI connector nodes with connector entries

Hi, On 5/4/21 9:52 AM, Andy Shevchenko wrote: > > > On Monday, May 3, 2021, Hans de Goede <mailto:hdego...@redhat.com>> wrote: > > From: Heikki Krogerus <mailto:heikki.kroge...@linux.intel.com>> > > On Intel platforms we know that the ACPI

Re: [Intel-gfx] [PATCH 5/9] drm/i915: Associate ACPI connector nodes with connector entries

Hi, On 5/5/21 11:17 AM, Andy Shevchenko wrote: > On Wed, May 5, 2021 at 12:07 PM Hans de Goede wrote: >> On 5/4/21 9:52 AM, Andy Shevchenko wrote: >>> On Monday, May 3, 2021, Hans de Goede >> <mailto:hdego...@redhat.com>> wrote: > >

Re: [Intel-gfx] [PATCH 5/9] drm/i915: Associate ACPI connector nodes with connector entries

Hi, On 5/5/21 12:02 PM, Andy Shevchenko wrote: > On Wed, May 5, 2021 at 12:28 PM Hans de Goede wrote: >> On 5/5/21 11:17 AM, Andy Shevchenko wrote: >>> On Wed, May 5, 2021 at 12:07 PM Hans de Goede wrote: >>>> On 5/4/21 9:52 AM, Andy Shevchenko wrote: >>>&

Re: [Intel-gfx] [PATCH 4/9] drm/connector: Add support for out-of-band hotplug notification (v2)

Hi, On 5/5/21 11:50 AM, Heikki Krogerus wrote: > On Tue, May 04, 2021 at 05:35:49PM +0200, Hans de Goede wrote: >> Hi, >> >> On 5/4/21 5:10 PM, Heikki Krogerus wrote: >>>> +/** >>>> + * drm_connector_oob_hotplug_event - Report out-of-band hotplug

Re: [Intel-gfx] [PATCH 8/9] usb: typec: altmodes/displayport: Notify drm subsys of hotplug events

Hi Heikki, On 5/5/21 12:17 PM, Heikki Krogerus wrote: > Hi Hans, > > On Mon, May 03, 2021 at 05:46:46PM +0200, Hans de Goede wrote: >> Use the new drm_connector_find_by_fwnode() and >> drm_connector_oob_hotplug_event() functions to let drm/kms drivers >> know ab

[Intel-gfx] [PATCH 0/8] drm + usb-type-c: Add support for out-of-band hotplug notification (v3)

pec_displayport.c, that file usually does not see a whole lot of changes. So I believe it would be best to just merge the entire series through drm-misc, Assuming we can get an ack from Greg for merging the typec_displayport.c changes this way. Regards, Hans Hans de Goede (7): drm/connector: Gi

[Intel-gfx] [PATCH 1/8] drm/connector: Give connector sysfs devices there own device_type

: Hans de Goede --- drivers/gpu/drm/drm_sysfs.c | 50 +++-- 1 file changed, 37 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c index 968a9560b4aa..f9d92bbb1f98 100644 --- a/drivers/gpu/drm/drm_sysfs.c +++ b

[Intel-gfx] [PATCH 2/8] drm/connector: Add a fwnode pointer to drm_connector and register with ACPI (v2)

are properly matched. Changes in v2: - Make drm_connector_cleanup() call fwnode_handle_put() on connector->fwnode and document this Co-developed-by: Heikki Krogerus Signed-off-by: Heikki Krogerus Signed-off-by: Hans de Goede --- drivers/gpu/drm/drm_connector.c | 2 ++ drivers/gpu/

[Intel-gfx] [PATCH 3/8] drm/connector: Add drm_connector_find_by_fwnode() function (v2)

-iter in drm_sysfs.c Signed-off-by: Hans de Goede --- drivers/gpu/drm/drm_connector.c | 50 + drivers/gpu/drm/drm_crtc_internal.h | 1 + include/drm/drm_connector.h | 8 + 3 files changed, 59 insertions(+) diff --git a/drivers/gpu/drm/drm_connector.c b

[Intel-gfx] [PATCH 5/8] drm/i915: Associate ACPI connector nodes with connector entries (v2)

connector node for a connector entry straightforward (it's one-on-one mapping). Changes in v2 (Hans de goede): - Take a reference on the fwnode which we assign to the connector, for ACPI nodes this is a no-op but in the future we may see software-fwnodes assigned to connectors which are ref-co

[Intel-gfx] [PATCH 6/8] drm/i915/dp: Add support for out-of-bound hotplug events

ommit adds support for this. Together with the recent addition of DP alt-mode support to the Type-C subsystem this makes DP over Type-C work on these devices. Signed-off-by: Hans de Goede --- drivers/gpu/drm/i915/display/intel_dp.c | 12 1 file changed, 12 insertions(+) diff --git a/d

[Intel-gfx] [PATCH 7/8] usb: typec: altmodes/displayport: Make dp_altmode_notify() more generic

Make dp_altmode_notify() handle the dp->data.conf == 0 case too, rather then having separate code-paths for this in various places which call it. Signed-off-by: Hans de Goede --- drivers/usb/typec/altmodes/displayport.c | 35 +--- 1 file changed, 13 insertions(+),

[Intel-gfx] [PATCH 8/8] usb: typec: altmodes/displayport: Notify drm subsys of hotplug events

Use the new drm_connector_oob_hotplug_event() functions to let drm/kms drivers know about DisplayPort over Type-C hotplug events. Signed-off-by: Hans de Goede --- Changes in v3: - Only call drm_connector_oob_hotplug_event() on hpd status bit change - Adjust for drm_connector_oob_hotplug_event

[Intel-gfx] [PATCH 4/8] drm/connector: Add support for out-of-band hotplug notification (v3)

o the drm_connector_oob_hotplug_event function since it is not used atm. This can be re-added later when a use for it actually arises. Signed-off-by: Hans de Goede --- drivers/gpu/drm/drm_connector.c | 27 +++ include/drm/drm_connector.h | 9 + 2 files changed, 36 inser

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm + usb-type-c: Add support for out-of-band hotplug notification (rev3)

Hi, On 5/5/21 9:14 PM, Patchwork wrote: > *Patch Details* > *Series:* drm + usb-type-c: Add support for out-of-band hotplug > notification (rev3) > *URL:*https://patchwork.freedesktop.org/series/89604/ > > *State:* failure > *Det

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm + usb-type-c: Add support for out-of-band hotplug notification (rev3)

Hi, On 5/6/21 5:31 PM, Patchwork wrote: > *Patch Details* > *Series:* drm + usb-type-c: Add support for out-of-band hotplug > notification (rev3) > *URL:*https://patchwork.freedesktop.org/series/89604/ > > *State:* failure > *Det

[Intel-gfx] 5.13 i915/PAT regression on Brasswell, adding nopat to the kernel commandline worksaround this

Hi All, I'm not sure if this is a i915 bug, or caused by changes elsewhere in the kernel, so I thought it would be best to just send out an email and then see from there. With 5.13-rc1 gdm fails to show and dmesg contains: [ 38.504613] x86/PAT: Xwayland:683 map pfn RAM range req write-combini

[Intel-gfx] i915 clear-residuals BYT + IVB rendering issue + possible fix

Hi All, We (Fedora) received a bug-report about rendering issues on BYT and IVB caused by the i915 clear-residuals work which landed in 5.10.y : The Fedora bug: https://bugzilla.redhat.com/show_bug.cgi?id=1959581 Points to these i915 bugs: https://gitlab.freedesktop.org/drm/intel/-/issues/3071 h

Re: [Intel-gfx] i915 clear-residuals BYT + IVB rendering issue + possible fix

Hi, On 5/12/21 2:18 PM, Ville Syrjälä wrote: > On Wed, May 12, 2021 at 12:06:23PM +0200, Hans de Goede wrote: >> Hi All, >> >> We (Fedora) received a bug-report about rendering issues >> on BYT and IVB caused by the i915 clear-residuals work >> which landed

Re: [Intel-gfx] 5.13 i915/PAT regression on Brasswell, adding nopat to the kernel commandline worksaround this

Hi, On 5/12/21 1:57 PM, Christoph Hellwig wrote: > On Wed, May 12, 2021 at 01:15:03PM +0200, Peter Zijlstra wrote: >> IIRC it's because of 74ffa5a3e685 ("mm: add remap_pfn_range_notrack"), >> which added a sanity check to make sure expectations were met. It turns >> out they were not. >> >> The bu

Re: [Intel-gfx] [PATCH 9/9] platform/x86/intel_cht_int33fe: Correct "displayport" fwnode reference

Hi, On 5/3/21 5:46 PM, Hans de Goede wrote: > The Type-C connector on these devices is connected to DP-2 not DP-1, > so the reference must be to the DD04 child-node of the GPU, rather > then the DD02 child-node. > > Signed-off-by: Hans de Goede Since this is pretty much indep

Re: [Intel-gfx] [PATCH 3/3] drm: Add orientation quirk for GPD Win Max

Hi, On 5/24/21 6:47 PM, Anisse Astier wrote: > Panel is 800x1280, but mounted on a laptop form factor, sideways. > > Signed-off-by: Anisse Astier Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/gpu/drm/drm_panel_orientati

[Intel-gfx] [PATCH 1/8] drm/connector: Give connector sysfs devices there own device_type

: Heikki Krogerus Signed-off-by: Hans de Goede --- drivers/gpu/drm/drm_sysfs.c | 50 +++-- 1 file changed, 37 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c index 968a9560b4aa..f9d92bbb1f98 100644 --- a/drivers/gpu

[Intel-gfx] [PATCH 0/8] drm + usb-type-c: Add support for out-of-band hotplug notification (v4 resend)

les but it also touches drivers/usb/typec/altmodes/typec_displayport.c, that file usually does not see a whole lot of changes. So I believe it would be best to just merge the entire series through drm-misc, Assuming we can get an ack from Greg for merging the typec_displayport.c changes this way. Regard

[Intel-gfx] [PATCH 2/8] drm/connector: Add a fwnode pointer to drm_connector and register with ACPI (v2)

are properly matched. Changes in v2: - Make drm_connector_cleanup() call fwnode_handle_put() on connector->fwnode and document this Co-developed-by: Heikki Krogerus Signed-off-by: Heikki Krogerus Tested-by: Heikki Krogerus Signed-off-by: Hans de Goede --- drivers/gpu/drm/drm_connecto

[Intel-gfx] [PATCH 3/8] drm/connector: Add drm_connector_find_by_fwnode() function (v3)

-iter in drm_sysfs.c Changes in v3: - Add forward declaration for struct fwnode_handle to drm_crtc_internal.h (fixes warning reported by kernel test robot ) Tested-by: Heikki Krogerus Signed-off-by: Hans de Goede --- drivers/gpu/drm/drm_connector.c | 50 + drivers

[Intel-gfx] [PATCH 4/8] drm/connector: Add support for out-of-band hotplug notification (v3)

o the drm_connector_oob_hotplug_event function since it is not used atm. This can be re-added later when a use for it actually arises. Tested-by: Heikki Krogerus Signed-off-by: Hans de Goede --- drivers/gpu/drm/drm_connector.c | 27 +++ include/drm/drm_connector.h | 9 +++

[Intel-gfx] [PATCH 5/8] drm/i915: Associate ACPI connector nodes with connector entries (v2)

connector node for a connector entry straightforward (it's one-on-one mapping). Changes in v2 (Hans de goede): - Take a reference on the fwnode which we assign to the connector, for ACPI nodes this is a no-op but in the future we may see software-fwnodes assigned to connectors which are ref-co

[Intel-gfx] [PATCH 6/8] drm/i915/dp: Add support for out-of-bound hotplug events

ommit adds support for this. Together with the recent addition of DP alt-mode support to the Type-C subsystem this makes DP over Type-C work on these devices. Tested-by: Heikki Krogerus Signed-off-by: Hans de Goede --- drivers/gpu/drm/i915/display/intel_dp.c | 12 1 file changed, 12

[Intel-gfx] [PATCH 7/8] usb: typec: altmodes/displayport: Make dp_altmode_notify() more generic

Make dp_altmode_notify() handle the dp->data.conf == 0 case too, rather then having separate code-paths for this in various places which call it. Reviewed-by: Heikki Krogerus Tested-by: Heikki Krogerus Signed-off-by: Hans de Goede --- drivers/usb/typec/altmodes/displayport.c |

[Intel-gfx] [PATCH 8/8] usb: typec: altmodes/displayport: Notify drm subsys of hotplug events

Use the new drm_connector_oob_hotplug_event() functions to let drm/kms drivers know about DisplayPort over Type-C hotplug events. Reviewed-by: Heikki Krogerus Tested-by: Heikki Krogerus Signed-off-by: Hans de Goede --- Changes in v3: - Only call drm_connector_oob_hotplug_event() on hpd status

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm + usb-type-c: Add support for out-of-band hotplug notification (v4 resend)

Hi, On 8/18/21 2:08 AM, Patchwork wrote: > *Patch Details* > *Series:* drm + usb-type-c: Add support for out-of-band hotplug > notification (v4 resend) > *URL:*https://patchwork.freedesktop.org/series/93762/ > > *State:* failure

[Intel-gfx] [GIT PULL] drm-misc + drm-intel: Add support for out-of-band hotplug notification

events (2021-08-20 12:35:59 +0200) Topic branch for drm-misc / drm-intel for OOB hotplug support for Type-C connectors -------- Hans de Goede (6): drm/connector:

Re: [Intel-gfx] [GIT PULL] drm-misc + drm-intel: Add support for out-of-band hotplug notification

Hi, On 8/24/21 10:45 AM, Jani Nikula wrote: > On Fri, 20 Aug 2021, Hans de Goede wrote: >> Hello drm-misc and drm-intel maintainers, >> >> My "Add support for out-of-band hotplug notification" patchset: >> https://patchwork.freedesktop.org/series/9376

[Intel-gfx] [PATCH 0/9] drm: Add privacy-screen class and connector properties

river is loaded. This means that initrd generation tools will need to be updated to include thinkpad_acpi when the i915 driver is added to the initrd. Without this the loading of the i915 driver will be delayed to after the switch to real rootfs. Regards, Hans Hans de Goede (8): drm: Add priva

[Intel-gfx] [PATCH 1/9] drm/connector: Add support for privacy-screen properties (v4)

From: Rajat Jain Add support for generic electronic privacy screen properties, that can be added by systems that have an integrated EPS. Changes in v2 (Hans de Goede) - Create 2 properties, "privacy-screen sw-state" and "privacy-screen hw-state", to deal with devices w

[Intel-gfx] [PATCH 2/9] drm: Add privacy-screen class (v3)

an uninitialized variable warning when CONFIG_DRM_PRIVICAY_SCREEN is not set Reviewed-by: Emil Velikov Signed-off-by: Hans de Goede --- Documentation/gpu/drm-kms-helpers.rst | 15 + MAINTAINERS | 8 + drivers/gpu/drm/Kconfig | 4

[Intel-gfx] [PATCH 3/9] drm/privacy-screen: Add X86 specific arch init code

Velikov Signed-off-by: Hans de Goede --- drivers/gpu/drm/Makefile | 2 +- drivers/gpu/drm/drm_privacy_screen_x86.c | 86 include/drm/drm_privacy_screen_machine.h | 5 ++ 3 files changed, 92 insertions(+), 1 deletion(-) create mode 100644 drivers/gpu/drm

[Intel-gfx] [PATCH 4/9] drm/privacy-screen: Add notifier support

Add support for privacy-screen consumers to register a notifier to be notified of external (e.g. done by the hw itself on a hotkey press) state changes. Reviewed-by: Emil Velikov Signed-off-by: Hans de Goede --- drivers/gpu/drm/drm_privacy_screen.c | 67 +++ include

  1   2   3   4   5   6   7   8   9   10   >