Re: [Intel-gfx] [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW

2017-12-20 Thread Jarkko Nikula
R_RW: include/linux/sysfs.h S_IWUSR: include/uapi/linux/stat.h S_IRUGO: include/linux/stat.h Jarkko Nikula ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [-next PATCH 2/4] treewide: Use DEVICE_ATTR_RW

2017-12-20 Thread Jarkko Nikula
On Wed, Dec 20, 2017 at 10:32:11AM +0100, Greg Kroah-Hartman wrote: > On Wed, Dec 20, 2017 at 01:24:44AM -0800, Joe Perches wrote: > > On Wed, 2017-12-20 at 10:34 +0200, Jarkko Nikula wrote: > > > On Tue, Dec 19, 2017 at 10:15:07AM -0800, Joe Perches wrote: > > > &g

Re: [Intel-gfx] [PATCH v4 4/5] i2c: designware-baytrail: Disallow the CPU to enter C6 or C7 while holding the punit semaphore

2016-12-13 Thread Jarkko Nikula
ut I'm okay with the contents which is more important. Reviewed-by: Andy Shevchenko No need for v5 from my side either (Andy agreed it later in the thread) Acked-by: Jarkko Nikula BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=109051 What would be good is to have comments / tags fr

Re: [Intel-gfx] [PATCH v4 5/5] i2c: designware-baytrail: Add support for cherrytrail

2016-12-13 Thread Jarkko Nikula
13 deletions(-) Acked-by: Jarkko Nikula ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v2 09/13] i2c: designware-baytrail: Acquire P-Unit access on bus acquire

2017-01-27 Thread Jarkko Nikula
--- drivers/i2c/busses/i2c-designware-baytrail.c | 4 1 file changed, 4 insertions(+) Acked-by: Jarkko Nikula ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v2 10/13] i2c: designware-baytrail: Call pmic_bus_access_notifier_chain

2017-01-27 Thread Jarkko Nikula
--- Changes in v2: -Spelling: P-Unit, PMIC --- drivers/i2c/busses/i2c-designware-baytrail.c | 4 1 file changed, 4 insertions(+) Acked-by: Jarkko Nikula ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman

Re: [Intel-gfx] [PATCH v5 5/6] i2c: designware-baytrail: Fix race when resetting the semaphore

2017-01-10 Thread Jarkko Nikula
elper holds the iosf_mbi_lock during the entire read-modify-wrtie cycle, so I don't see how there can still be any issue left. Ah, seems you are right. Reviewed-by: Andy Shevchenko Acked-by: Jarkko Nikula ___ Intel-gfx mailing list

Re: [Intel-gfx] [RFC 1/4] x86/platform/intel/iosf_mbi: Add a mutex for punit access

2017-01-13 Thread Jarkko Nikula
On 01/13/2017 11:26 AM, Ville Syrjälä wrote: It also feels quite hand wavy since the punit could do whatever at any time AFAIK. Eg. if there's some thermal event or something the punit might kick into action. So trying to protect this from the OS side might not be able to avoid these problems ent

Re: [Intel-gfx] [RFC 1/4] x86/platform/intel/iosf_mbi: Add a mutex for punit access

2017-01-13 Thread Jarkko Nikula
On 01/13/2017 12:51 PM, Ville Syrjälä wrote: On Fri, Jan 13, 2017 at 12:34:54PM +0200, Jarkko Nikula wrote: On 01/13/2017 11:26 AM, Ville Syrjälä wrote: It also feels quite hand wavy since the punit could do whatever at any time AFAIK. Eg. if there's some thermal event or something the