the newer gpiod interface(Alexandre)
v3: Remove the redundant checks and unused code (Ville)
CC: Samuel Ortiz sa...@linux.intel.com
Cc: Linus Walleij linus.wall...@linaro.org
Cc: Alexandre Courbot gnu...@gmail.com
Cc: Thierry Reding thierry.red...@gmail.com
Signed-off-by: Shobhit Kumar
On Thu, Mar 12, 2015 at 4:06 PM, Kumar, Shobhit shobhit.ku...@intel.com wrote:
On Mon, 2015-03-09 at 18:15 +0100, Linus Walleij wrote:
On Fri, Mar 6, 2015 at 5:23 PM, Kumar, Shobhit shobhit.ku...@intel.com
wrote:
There are actually two lines for Panel Power control and Backlight
enable
...@linux.intel.com
Cc: Linus Walleij linus.wall...@linaro.org
Cc: Alexandre Courbot gnu...@gmail.com
Cc: Thierry Reding thierry.red...@gmail.com
Signed-off-by: Shobhit Kumar shobhit.ku...@intel.com
NACK.
Spawn a separate MFD cell and write a fixed voltage
regulator driver for this.
@@ -39,6 +39,7
of backlight thingy. But for the Panel power control, I am at loss
for how best to program that.
Isn't it just a very simple regulator (just on/off of fixed voltage) cell?
Yours,
Linus Walleij
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
thorugh CRC PMIC
Cc: Linus Walleij linus.wall...@linaro.org
Cc: Alexandre Courbot gnu...@gmail.com
Cc: Thierry Reding thierry.red...@gmail.com
Signed-off-by: Shobhit Kumar shobhit.ku...@intel.com
This seems very unintuitive. I have a hard time believeing this:
+#define GPIOPANELCTL
horribly complicated.
Yours,
Linus Walleij
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Tue, Mar 24, 2015 at 10:50 AM, Daniel Vetter dan...@ffwll.ch wrote:
On Tue, Mar 24, 2015 at 10:35:32AM +0100, Linus Walleij wrote:
Some stuff may be needed to associate the regulator with the right
device indeed but nothing horribly complicated.
Nack, really. We've had an epic discussion
On Wed, Mar 18, 2015 at 2:27 PM, Daniel Vetter dan...@ffwll.ch wrote:
On Wed, Mar 18, 2015 at 12:50:51PM +0100, Linus Walleij wrote:
This is not a GPIO, this is a special purpose thing and IMO
it should be modeled directly as a regulator.
The idea behind reusing gpio was that we can reuse
...@linux.intel.com
Cc: Linus Walleij linus.wall...@linaro.org
Cc: Alexandre Courbot gnu...@gmail.com
Cc: Thierry Reding thierry.red...@gmail.com
Signed-off-by: Shobhit Kumar shobhit.ku...@intel.com
So as I think it is better to use a fixed voltage regulator (see code
example in the i915 patch) I
On Tue, Mar 24, 2015 at 11:53 AM, Daniel Vetter dan...@ffwll.ch wrote:
On Tue, Mar 24, 2015 at 11:16 AM, Linus Walleij
linus.wall...@linaro.org wrote:
So summary:
- Reusing the dynamic gpio lookup stuff would be nice, and might be
interesting as a new crazy use-case (or maybe
thorugh CRC PMIC
Cc: Linus Walleij linus.wall...@linaro.org
Cc: Alexandre Courbot gnu...@gmail.com
Cc: Thierry Reding thierry.red...@gmail.com
Signed-off-by: Shobhit Kumar shobhit.ku...@intel.com
Patch applied, after Daniel convinced me that this is the lesser
of several possible evils
...@linux.intel.com
Cc: Linus Walleij linus.wall...@linaro.org
Cc: Alexandre Courbot gnu...@gmail.com
Cc: Thierry Reding thierry.red...@gmail.com
Signed-off-by: Shobhit Kumar shobhit.ku...@intel.com
OK applied *this* version of the patch...
Yours,
Linus Walleij
...@linux.intel.com
Cc: Linus Walleij linus.wall...@linaro.org
Cc: Alexandre Courbot gnu...@gmail.com
Cc: Thierry Reding thierry.red...@gmail.com
Signed-off-by: Shobhit Kumar shobhit.ku...@intel.com
I have changed my mind.
Reviewed-by: Linus Walleij linus.wall...@linaro.org
Lee, please apply
On Wed, Mar 25, 2015 at 3:15 PM, Kumar, Shobhit shobhit.ku...@intel.com wrote:
On Wed, 2015-03-25 at 13:27 +0100, Linus Walleij wrote:
On Wed, Feb 18, 2015 at 1:18 PM, Shobhit Kumar shobhit.ku...@intel.com
wrote:
Export Panel BACKLIGHT_EN(offset 0x51) and PANEL_EN(offset 0x52) as two
maintainers
Cc: Samuel Ortiz sa...@linux.intel.com
Cc: Linus Walleij linus.wall...@linaro.org
Cc: Alexandre Courbot gnu...@gmail.com
Cc: Thierry Reding thierry.red...@gmail.com
Reviewed-by: Alexandre Courbot acour...@nvidia.com
Signed-off-by: Shobhit Kumar shobhit.ku...@intel.com
Reviewed-by: Linus
static (Thierry)
Remove the lookup table during driver remove (Thierry)
CC: Samuel Ortiz sa...@linux.intel.com
Cc: Linus Walleij linus.wall...@linaro.org
Cc: Alexandre Courbot gnu...@gmail.com
Cc: Thierry Reding thierry.red...@gmail.com
Signed-off-by: Shobhit Kumar shobhit.ku
static (Thierry)
Remove the lookup table during driver remove (Thierry)
CC: Samuel Ortiz sa...@linux.intel.com
Cc: Linus Walleij linus.wall...@linaro.org
Cc: Alexandre Courbot gnu...@gmail.com
Cc: Thierry Reding thierry.red...@gmail.com
Signed-off-by: Shobhit Kumar shobhit.ku
the newer gpiod interface(Alexandre)
v3: Remove the redundant checks and unused code (Ville)
CC: Samuel Ortiz sa...@linux.intel.com
Cc: Linus Walleij linus.wall...@linaro.org
Cc: Alexandre Courbot gnu...@gmail.com
Cc: Thierry Reding thierry.red...@gmail.com
Signed-off-by: Shobhit Kumar
the newer gpiod interface(Alexandre)
v3: Remove the redundant checks and unused code (Ville)
CC: Samuel Ortiz sa...@linux.intel.com
Cc: Linus Walleij linus.wall...@linaro.org
Cc: Alexandre Courbot gnu...@gmail.com
Cc: Thierry Reding thierry.red...@gmail.com
Signed-off-by: Shobhit Kumar
On Wed, May 6, 2015 at 5:09 PM, Daniel Vetter dan...@ffwll.ch wrote:
On Wed, May 06, 2015 at 04:49:36PM +0200, Linus Walleij wrote:
On Wed, Apr 29, 2015 at 3:59 PM, Shobhit Kumar shobhit.ku...@intel.com
wrote:
In case we unload and load a driver module again that is registering a
lookup
static (Thierry)
Remove the lookup table during driver remove (Thierry)
v3: Correct the subject line (Lee jones)
CC: Samuel Ortiz sa...@linux.intel.com
Cc: Linus Walleij linus.wall...@linaro.org
Cc: Alexandre Courbot gnu...@gmail.com
Cc: Thierry Reding thierry.red...@gmail.com
Acked
maintainers
v3: Correct the subject line (Lee jones)
Cc: Samuel Ortiz sa...@linux.intel.com
Cc: Linus Walleij linus.wall...@linaro.org
Cc: Alexandre Courbot gnu...@gmail.com
Cc: Thierry Reding thierry.red...@gmail.com
Reviewed-by: Alexandre Courbot acour...@nvidia.com
Reviewed-by: Linus Walleij
On Wed, Mar 16, 2016 at 2:34 PM, Daniel Vetter <dan...@ffwll.ch> wrote:
> On Wed, Mar 16, 2016 at 01:27:49PM +0100, Linus Walleij wrote:
>> - What is a HPD interrupt?
>
> hotplug interrupt, fires when you plug in a cable.
>
>> - What is a Type-C DP HPD?
>
> usb
Kumar <shobhit.ku...@intel.com>
> Cc: Samuel Ortiz <sa...@linux.intel.com>
> Cc: Linus Walleij <linus.wall...@linaro.org>
> Cc: Alexandre Courbot <gnu...@gmail.com>
> Cc: Thierry Reding <thierry.red...@gmail.com>
> Cc: Lee Jones <lee.jo...@linaro.org>
&
onboard.com>
> Cc: Manfred Schlaegl <manfred.schla...@gmx.at>
> Cc: Marek Vasut <ma...@denx.de>
> Cc: Archit Taneja <arch...@codeaurora.org>
> Cc: Andrzej Hajda <a.ha...@samsung.com>
> Cc: Alison Wang <alison.w...@freescale.com>
> Cc: Eric Anholt
On Sun, May 26, 2019 at 8:05 PM Sam Ravnborg wrote:
> The num_supplies variable is not used, delete it.
> Build tested.
>
> Signed-off-by: Sam Ravnborg
> Cc: Thierry Reding
> Cc: David Airlie
> Cc: Daniel Vetter
Reviewed-by: Linus Walleij
blocks of include files
>
> Signed-off-by: Sam Ravnborg
> Cc: Thierry Reding
> Cc: Linus Walleij
> Cc: Stefan Mavrodiev
> Cc: David Airlie
> Cc: Daniel Vetter
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
___
Intel-gfx maili
On Fri, Jun 14, 2019 at 10:36 PM Daniel Vetter wrote:
> They're the default.
>
> Aside: Would be really nice to switch the others over to
> drm_gem_object_funcs.
>
> Signed-off-by: Daniel Vetter
> Cc: Linus Walleij
Reviewed-by: Linus Walleij
When you write "Woul
On Fri, Jun 14, 2019 at 10:36 PM Daniel Vetter wrote:
> They're the default.
>
> Aside: Would be really nice to switch the others over to
> drm_gem_object_funcs.
>
> Signed-off-by: Daniel Vetter
> Cc: Linus Walleij
Reviewed-by: Linus Walleij
race down to the calls I
need and understand the small pieces I use.
Yours,
Linus Walleij
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
. So this is easy, but I wonder if we cannot
> get rid of the dupping all together ?
Maybe ... I don't know. What do you think? I suppose you could
make u300 crash if you do that.
Yours,
Linus Walleij
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
le.
>
> Since the lookup-table is attached to the i915 PCI device it really
> should be part of the i915 driver, this will also allow us to extend
> it with GPIOs from other sources when necessary.
>
> Signed-off-by: Hans de Goede
Looks OK to me
Acked-by: Linus Walleij
But Lee
s devices when booted
> with a HDMI monitor connected. This has been tested to fix this on the
> following devices:
>
> Peaq C1010
> Point of View MOBII TAB-P800W
> Point of View MOBII TAB-P1005W
> Terra Pad 1061
> Yours Y8W81
>
> Signe
where instead of the PMIC the SoC is used
> for backlight control.
>
> Signed-off-by: Hans de Goede
The kernel looks prettier after than before and it seems correct so:
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
___
Intel-gfx mailing
ue accordingly.
>
> This fixes the panel not lighting up on a Thundersoft TST168 tablet when
> booted with an external monitor connected over HDMI.
>
> Signed-off-by: Hans de Goede
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
___
e pull this in and put the other patches on top of that.
I had a bit of mess in my subsystems last kernel cycle so I
want to avoid that by strictly including all larger commits
in my trees.
Yours,
Linus Walleij
___
Intel-gfx mailing list
Intel-gfx@lists
nctrl/cirrus/pinctrl-madera-core.c: ret =
pinctrl_register_mappings(pdata->gpio_configs,
Delete __initdata from the u300 table, the other one seems
safe. Fold this into your patch.
Go with the original idea.
Yours,
Linus Walleij
___
Intel-gf
nn (v1)
> Cc: Thomas Zimmermann
> Cc: Noralf Trønnes
> Cc: Gerd Hoffmann
> Cc: Eric Anholt
> Cc: Emil Velikov
> Cc: virtualizat...@lists.linux-foundation.org
> Cc: Linus Walleij
> Signed-off-by: Daniel Vetter
Makes perfect sense.
Revi
ally complex DSI panel from drivers/gpu/drm/panel/*
though.
Yours,
Linus Walleij
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
to the other review comments where
I feel we should be spawning gpio backlight devices from
somewhere.
I understand those things may be a bit big, if the intel
pinctrl maintainers are fine with this solution I am fine
with it too, it's not like it is the biggest deal, I am just worried
that we mig
; panel-arm-versatile.c:184/versatile_panels[]: 390 vs. 1523 (.clock=62500
> .htotal=176 + 2 + 3 + 3 .vtotal=220 + 0 + 2 + 1)
The only driver drivers/gpu/drm/pl111/pl111_display.c
Uses mode->clock so just drop vrefresh.
Yours,
Linus Walleij
___
I
On Wed, Feb 26, 2020 at 12:57 PM Ville Syrjälä
wrote:
> On Tue, Feb 25, 2020 at 10:52:25PM +0100, Linus Walleij wrote:
> > I have long suspected that a whole bunch of the "simple" displays
> > are not simple but contains a display controller and memory.
> >
On Wed, Feb 26, 2020 at 3:34 PM Ville Syrjälä
wrote:
> On Wed, Feb 26, 2020 at 01:08:06PM +0100, Linus Walleij wrote:
> > On Wed, Feb 26, 2020 at 12:57 PM Ville Syrjälä
> > wrote:
> > > On Tue, Feb 25, 2020 at 10:52:25PM +0100, Linus Walleij wrote:
> >
> > &g
On Wed, Feb 19, 2020 at 11:22 AM Daniel Vetter wrote:
> Allows us to drop the drm_driver.release callback.
>
> Signed-off-by: Daniel Vetter
> Cc: Linus Walleij
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
___
Intel-gfx mailing li
tright
> losing their ->remove hook.
>
> Signed-off-by: Daniel Vetter
> Cc: Linus Walleij
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Wed, Feb 19, 2020 at 11:21 AM Daniel Vetter wrote:
> With this we can drop the final kfree from the release function.
>
> Signed-off-by: Daniel Vetter
> Cc: Linus Walleij
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
___
Intel
On Wed, Feb 19, 2020 at 9:35 PM Ville Syrjala
wrote:
> drm/exynos: Use mode->clock instead of reverse calculating it from the
> vrefresh
> drm: Nuke mode->vrefresh
I'm sure this is fine.
Acked-by: Linus Walleij
We need one: either clock or refresh settings, so it
.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git/log/?h=ib-pinctrl-unreg-mappings
And pulled that into the pinctrl "devel" branch for v5.6.
Please pull this immutable branch into the Intel DRM tree and apply
the rest of the stuff on top!
Yours,
Linus Walleij
On Wed, Apr 15, 2020 at 9:41 AM Daniel Vetter wrote:
> Already using devm_drm_dev_init, so very simple replacment.
>
> v2: Move misplaced double-assignement to next patch (Sam)
>
> Acked-by: Sam Ravnborg
> Signed-off-by: Daniel Vetter
> Cc: Linus Walleij
Reviewed-by:
On Fri, Apr 3, 2020 at 3:59 PM Daniel Vetter wrote:
> Upcasting using a container_of macro is more typesafe, faster and
> easier for the compiler to optimize.
>
> Signed-off-by: Daniel Vetter
> Cc: Linus Walleij
Nice, thanks!
Reviewed-by: Linus Walleij
Yours
On Fri, Apr 3, 2020 at 10:41 PM Ville Syrjala
wrote:
> From: Ville Syrjälä
>
> htotal*vtotal*vrefresh ~= clock. So just say "clock" when we mean it.
>
> Cc: Linus Walleij
> Cc: Sam Ravnborg
> Signed-off-by: Ville Syrjälä
Indeed :)
Reviewed-by: Linus
On Thu, Dec 10, 2020 at 8:42 PM Thomas Gleixner wrote:
> Let the core code do the fiddling with irq_desc.
>
> Signed-off-by: Thomas Gleixner
> Cc: Linus Walleij
> Cc: linux-arm-ker...@lists.infradead.org
> Cc: linux-g...@vger.kernel.org
Reviewed-by: Linus Walleij
I suppo
gt;
> Signed-off-by: Thomas Gleixner
> Cc: Linus Walleij
> Cc: Lee Jones
> Cc: linux-arm-ker...@lists.infradead.org
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Fri, May 21, 2021 at 11:10 AM Daniel Vetter wrote:
> Goes through all the drivers and deletes the default hook since it's
> the default now.
>
> Signed-off-by: Daniel Vetter
> Cc: Joel Stanley
> Cc: Andrew Jeffery
> Cc: "Noralf Trønnes"
> Cc: Linus Walle
On Thu, Jul 21, 2022 at 8:24 AM Slark Xiao wrote:
> Replace 'the the' with 'the' in the comment.
>
> Signed-off-by: Slark Xiao
Patch applied!
Yours,
Linus Walleij
55 matches
Mail list logo
