[Intel-gfx] i915: slow startup

2011-11-30 Thread Lucas De Marchi
Chipset Integrated Graphics Controller (rev 07) Subsystem: Dell Device 02bb Flags: bus master, fast devsel, latency 0 Memory at f610 (64-bit, non-prefetchable) [size=1M] Thanks Lucas De Marchi ___ Intel-gfx mailing list Intel

Re: [Intel-gfx] [PATCH v4] drm/i915: Apply Wa Display #1183 on skl, kbl, and cfl

2017-11-15 Thread Lucas De Marchi
On Wed, Nov 15, 2017 at 6:26 PM, Lucas De Marchi <lucas.demar...@intel.com> wrote: > Wa Display #1183 was recently added to workaround > "Failures when enabling DPLL0 with eDP link rate 2.16 > or 4.32 GHz and CD clock frequency 308.57 or 617.14 MHz > (CDCLK_CTL CD Frequency

Re: [Intel-gfx] [PATCH] drm/i915/cnl: WA Display #1178 to fix some type C dongles

2017-11-27 Thread Lucas De Marchi
On Thu, Nov 23, 2017 at 7:21 AM, Ville Syrjälä <ville.syrj...@linux.intel.com> wrote: > On Wed, Nov 22, 2017 at 10:55:14AM -0800, Lucas De Marchi wrote: >> WA Display #1178 is meant to fix Aux channel voltage swing too low with >> some type C dongles. Although it is for

[Intel-gfx] [PATCH 1/2] drm/i915: follow single notation for workaround number

2017-11-28 Thread Lucas De Marchi
Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Signed-off-by: Lucas De Marchi <lucas.demar...@intel.com> --- drivers/gpu/drm/i915/intel_display.c | 2 +- drivers/gpu/drm/i915/intel_hdmi.c| 2 +- drivers/gpu/drm/i915/intel_pm.c | 2 +- 3 files changed, 3 insertions(+),

[Intel-gfx] [PATCH 2/2] drm/i915: add platform tag to WA

2017-11-28 Thread Lucas De Marchi
Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Signed-off-by: Lucas De Marchi <lucas.demar...@intel.com> --- drivers/gpu/drm/i915/intel_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_hdmi.c b/drivers/gpu/drm/i915/intel_

[Intel-gfx] [PATCH] drm/i915/cnl: apply Display WA #1178 to fix type C dongles

2017-11-28 Thread Lucas De Marchi
up since they will lose the configuration when powered down. v2: Use common tag for WA Cc: Rodrigo Vivi <rodrigo.v...@intel.com> Cc: Arthur J Runyan <arthur.j.run...@intel.com> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Signed-off-by: Lucas De Marchi <lucas.demar...@in

[Intel-gfx] [PATCH] drm/i915/cnl: WA Display #1178 to fix some type C dongles

2017-11-22 Thread Lucas De Marchi
up since they will lose the configuration when powered down. Cc: Rodrigo Vivi <rodrigo.v...@intel.com> Cc: Arthur J Runyan <arthur.j.run...@intel.com> Signed-off-by: Lucas De Marchi <lucas.demar...@intel.com> --- Since this is a workaround I think it would be desirable not

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Implement WaDisableVFclkgate.

2017-12-04 Thread Lucas De Marchi
_reg.h > @@ -3875,6 +3875,9 @@ enum { > #define SARBUNIT_CLKGATE_DIS (1 << 5) > #define RCCUNIT_CLKGATE_DIS (1 << 7) > > +#define UNSLICE_UNIT_LEVEL_CLOCK _MMIO(0x9434) I think this should follow the other names (UNSLICE_UNIT_LEVEL_CL

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Implement WaDisableEarlyEOT.

2017-12-04 Thread Lucas De Marchi
Rafael Antognolli <rafael.antogno...@intel.com> Reviewed-by: Lucas De Marchi <lucas.demar...@intel.com> Lucas De Marchi > --- > drivers/gpu/drm/i915/i915_reg.h| 1 + > drivers/gpu/drm/i915/intel_engine_cs.c | 3 +++ > 2 files changed, 4 insertions(+) > > dif

[Intel-gfx] [PATCH v4] drm/i915: Apply Display WA #1183 on skl, kbl, and cfl

2017-12-04 Thread Lucas De Marchi
.@vger.kernel.org Signed-off-by: Lucas De Marchi <lucas.demar...@intel.com> --- drivers/gpu/drm/i915/i915_reg.h | 2 ++ drivers/gpu/drm/i915/intel_cdclk.c | 35 - drivers/gpu/drm/i915/intel_runtime_pm.c | 10 ++ 3 files changed, 38 inserti

[Intel-gfx] [PATCH v2 2/2] drm/i915: add platform tag to WA

2017-12-04 Thread Lucas De Marchi
v2: add more missing platform tags Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Cc: Rodrigo Vivi <rodrigo.v...@intel.com> Signed-off-by: Lucas De Marchi <lucas.demar...@intel.com> --- drivers/gpu/drm/i915/intel_hdmi.c | 2 +- drivers/gpu/drm/i915/intel_pm.c | 2 +-

[Intel-gfx] [PATCH v2 1/2] drm/i915: follow single notation for workaround number

2017-12-04 Thread Lucas De Marchi
v2: Allow to have or omit space before platform Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Cc: Rodrigo Vivi <rodrigo.v...@intel.com> Signed-off-by: Lucas De Marchi <lucas.demar...@intel.com> --- drivers/gpu/drm/i915/intel_hdmi.c | 2 +- drivers/gpu/drm/i915/intel_pm.c

Re: [Intel-gfx] [PATCH] x86/gpu: add CFL to early quirks

2017-12-12 Thread Lucas De Marchi
On Tue, Dec 12, 2017 at 1:53 AM, Joonas Lahtinen <joonas.lahti...@linux.intel.com> wrote: > + Jani, who'll continue with -fixes > > On Mon, 2017-12-11 at 13:50 -0800, Lucas De Marchi wrote: >> On Mon, Dec 11, 2017 at 2:26 AM, Joonas Lahtinen >> <joonas.lahti...@linux

Re: [Intel-gfx] [PATCH] x86/gpu: add CFL to early quirks

2017-12-13 Thread Lucas De Marchi
On Wed, Dec 13, 2017 at 2:11 AM, Jani Nikula <jani.nik...@linux.intel.com> wrote: > On Tue, 12 Dec 2017, Lucas De Marchi <lucas.de.mar...@gmail.com> wrote: >> On Tue, Dec 12, 2017 at 1:53 AM, Joonas Lahtinen >> <joonas.lahti...@linux.intel.com> wrote: >&g

[Intel-gfx] [PATCH v2] x86/gpu: add CFL to early quirks

2017-12-13 Thread Lucas De Marchi
/i915/cfl: Add Coffee Lake PCI IDs for S Skus.") Signed-off-by: Lucas De Marchi <lucas.demar...@intel.com> Cc: Rodrigo Vivi <rodrigo.v...@intel.com> Cc: Anusha Srivatsa <anusha.sriva...@intel.com> Cc: Jani Nikula <jani.nik...@linux.intel.com> Cc: Joonas Lahtinen <joona

[Intel-gfx] [PATCH] drm/i915: Fix function name in comment

2017-11-13 Thread Lucas De Marchi
Commit 78597996370c (drm/i915/bxt: Fix PPS lost state after suspend breaking eDP link training) renamed the function to intel_power_sequencer_reset() but forgot to update comment. Cc: Imre Deak <imre.d...@intel.com> Signed-off-by: Lucas De Marchi <lucas.demar...@intel.com> --- dri

[Intel-gfx] [PATCH v5] drm/i915: Apply Wa Display #1183 on skl, kbl, and cfl

2017-11-21 Thread Lucas De Marchi
t changing the frequency with small differences. This is based on previous patch by Rodrigo Vivi with suggestions from Ville Syrjälä. Cc: Arthur J Runyan <arthur.j.run...@intel.com> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Cc: Rodrigo Vivi <rodrigo.v...@intel.com> Signed-off-by:

Re: [Intel-gfx] [PATCH v3] drm/i915: Apply Wa Display #1183 on skl, kbl, and cfl

2017-11-15 Thread Lucas De Marchi
On Tue, Nov 14, 2017 at 5:10 AM, Ville Syrjälä <ville.syrj...@linux.intel.com> wrote: > On Mon, Nov 13, 2017 at 01:47:26PM -0800, Lucas De Marchi wrote: >> Hi Ville, >> >> On Thu, Nov 9, 2017 at 8:58 AM, Ville Syrjälä >> <ville.syrj...@linux.intel.com> wr

[Intel-gfx] [PATCH v4] drm/i915: Apply Wa Display #1183 on skl, kbl, and cfl

2017-11-15 Thread Lucas De Marchi
t changing the frequency with small differences. This is based on previous patch by Rodrigo Vivi with suggestions from Ville Syrjälä. Cc: Arthur J Runyan <arthur.j.run...@intel.com> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Cc: Rodrigo Vivi <rodrigo.v...@intel.com> Signed-off-by:

Re: [Intel-gfx] [PATCH v3] drm/i915: Apply Wa Display #1183 on skl, kbl, and cfl

2017-11-13 Thread Lucas De Marchi
Hi Ville, On Thu, Nov 9, 2017 at 8:58 AM, Ville Syrjälä <ville.syrj...@linux.intel.com> wrote: > On Thu, Nov 09, 2017 at 08:02:40AM -0800, Lucas De Marchi wrote: >> On Thu, Nov 9, 2017 at 5:11 AM, Ville Syrjälä >> <ville.syrj...@linux.intel.com> wrote: >> >

[Intel-gfx] [PATCH v3] drm/i915: Apply Wa Display #1183 on skl, kbl, and cfl

2017-11-09 Thread Lucas De Marchi
linux.intel.com> Cc: Rodrigo Vivi <rodrigo.v...@intel.com> Signed-off-by: Lucas De Marchi <lucas.demar...@intel.com> --- I tried to test this but both on SKL and KBL that I have the bug that requires the WA isn't triggered. drivers/gpu/drm/i915/i915_reg.h | 2 ++ drivers/gp

Re: [Intel-gfx] [PATCH v3] drm/i915: Apply Wa Display #1183 on skl, kbl, and cfl

2017-11-09 Thread Lucas De Marchi
On Thu, Nov 9, 2017 at 5:11 AM, Ville Syrjälä <ville.syrj...@linux.intel.com> wrote: > On Thu, Nov 09, 2017 at 02:58:04AM -0800, Lucas De Marchi wrote: >> Wa Display #1183 was recently added to workaround >> "Failures when enabling DPLL0 with eDP link rate 2.16 &

[Intel-gfx] [PATCH v3 1/2] drm/i915: follow single notation for workaround number

2017-12-05 Thread Lucas De Marchi
v2: Allow to have or omit space before platform Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Signed-off-by: Lucas De Marchi <lucas.demar...@intel.com> Reviewed-by: Rodrigo Vivi <rodrigo.v...@intel.com> --- drivers/gpu/drm/i915/intel_hdmi.c | 2 +- drivers/gpu/drm/i91

[Intel-gfx] [PATCH v3 2/2] drm/i915: add platform tag to WA

2017-12-05 Thread Lucas De Marchi
v2: add more missing platform tags v3: change tag to cnp rather than using gen9,gen10 Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Signed-off-by: Lucas De Marchi <lucas.demar...@intel.com> Reviewed-by: Rodrigo Vivi <rodrigo.v...@intel.com> --- drivers/gpu/drm/i91

[Intel-gfx] [PATCH] x86/gpu: add CFL to early quirks

2017-12-08 Thread Lucas De Marchi
CFL was missing from intel_early_ids[]. Cc: Ingo Molnar <mi...@kernel.org> Cc: H. Peter Anvin <h...@zytor.com> Cc: Thomas Gleixner <t...@linutronix.de> Cc: x...@kernel.org Cc: Rodrigo Vivi <rodrigo.v...@intel.com> Signed-off-by: Lucas De Marchi <lucas.demar...@intel

Re: [Intel-gfx] [PATCH] x86/gpu: add CFL to early quirks

2017-12-11 Thread Lucas De Marchi
On Mon, Dec 11, 2017 at 2:26 AM, Joonas Lahtinen <joonas.lahti...@linux.intel.com> wrote: > On Fri, 2017-12-08 at 10:47 -0800, Lucas De Marchi wrote: >> CFL was missing from intel_early_ids[]. >> >> Cc: Ingo Molnar <mi...@kernel.org> >> Cc: H. Peter Anvin <

[Intel-gfx] [PATCH i-g-t] lib/i915_pciids.h: synchronize with kernel header

2017-12-08 Thread Lucas De Marchi
there, although in future it could be more sofisticated pointing the build system to the external header. [1] https://patchwork.freedesktop.org/patch/192410/ Cc: Paulo Zanoni <paulo.r.zan...@intel.com> Signed-off-by: Lucas De Marchi <lucas.demar...@intel.com> --- lib/i915_pc

Re: [Intel-gfx] [PATCH] dim: replace pipe commands with single sed

2018-05-09 Thread Lucas De Marchi
Now CC the right mailing list. The way dim sets up the repository you can't have individual git configs, e.g. to set a different sendemail.to for dim-tools :( Lucas De Marchi On Wed, May 9, 2018 at 2:28 PM, Lucas De Marchi <lucas.demar...@intel.com> wrote: > A single sed can d

[Intel-gfx] [PATCH] dim: replace pipe commands with single sed

2018-05-09 Thread Lucas De Marchi
A single sed can do the job of taking the second line after a match and it looks simpler. Signed-off-by: Lucas De Marchi <lucas.demar...@intel.com> --- I noticed this while reviewing "[PATCH 2/4] dim: shut up sed broken pipe noise in apply-pull". dim | 2 +- 1 file changed, 1

[Intel-gfx] [PATCH] Revert "drm/i915/edp: Do not do link training fallback or prune modes on EDP"

2018-05-16 Thread Lucas De Marchi
yrjala <ville.syrj...@linux.intel.com> Cc: Dave Airlie <airl...@redhat.com> Cc: Daniel Vetter <daniel.vet...@ffwll.ch> Cc: Manasi Navare <manasi.d.nav...@intel.com> Cc: Ville Syrjala <ville.syrj...@linux.intel.com> Cc: Imre Deak <imre.d...@intel.com> Signed-off-by: Lucas

Re: [Intel-gfx] [PATCH 11/24] drm/i915/icl: Get DDI clock for ICL based on PLLs.

2018-05-22 Thread Lucas De Marchi
PLL Params and compares the set > > pll_params with the table to get the corresponding link > > clock. > > > > Cc: Rodrigo Vivi <rodrigo.v...@intel.com> > > Cc: Mika Kahola <mika.kah...@intel.com> > > Cc: Paulo Zanoni <paulo.r.zan...@intel.com> > >

[Intel-gfx] [PATCH] drm/i915/icl: fix icl_unmap/map_plls_to_ports

2018-05-25 Thread Lucas De Marchi
gt; Reviewed-by: Lucas De Marchi <lucas.demar...@intel.com> --- drivers/gpu/drm/i915/intel_ddi.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c index 3b8f12883ca7..c33b19705e39 100644 --- a/drivers/gpu/dr

Re: [Intel-gfx] [PATCH 25/24] drm/i915/icl: fix gmbus gpio pin mapping

2018-05-25 Thread Lucas De Marchi
On Fri, May 25, 2018 at 07:24:07PM +0300, Ville Syrjälä wrote: > On Thu, May 24, 2018 at 05:36:37PM -0700, Lucas De Marchi wrote: > > On Thu, May 24, 2018 at 04:42:36PM -0700, Paulo Zanoni wrote: > > > From: Mahesh Kumar <mahesh1.ku...@intel.com> > > > > >

Re: [Intel-gfx] [PATCH 07/24] drm/i915/icl: Add DDI HDMI level selection for ICL

2018-05-25 Thread Lucas De Marchi
(IS_CANNONLAKE(dev_priv)) { > + if (IS_ICELAKE(dev_priv)) { > + if (port == PORT_A || port == PORT_B) This should be using the helper you introduced in patch 3. Either a 'if (!intel_port_is_tc()' or add a 'if (intel_port_is_combo)'. With that, Reviewed-by:

Re: [Intel-gfx] [PATCH 06/24] drm/i915/ICL: Add register definition for DFLEXDPMLE

2018-05-25 Thread Lucas De Marchi
CL_PORT_COMP_DW > > 10_B) > > > > +/* ICL PHY DFLEX registers */ > > +#define ICL_PORT_TX_DFLEXDPMLE1_MMIO(0x1638C0) > > We can probably remove the ICL_ prefix since the register did not exist > before. And while at it s/ICL/icl/ in the commit me

Re: [Intel-gfx] [PATCH 25/24] drm/i915/icl: fix gmbus gpio pin mapping

2018-05-24 Thread Lucas De Marchi
& uses them in GPIO > pin mapping table. > > Cc: Anusha Srivatsa <anusha.sriva...@intel.com> > Cc: Madhav Chauhan <madhav.chau...@intel.com> > Cc: Lucas De Marchi <lucas.demar...@intel.com> > Signed-off-by: Mahesh Kumar <mahesh1.ku...@intel.com> >

Re: [Intel-gfx] [PATCH 05/24] drm/i915/icp: Add Interrupt Support

2018-05-24 Thread Lucas De Marchi
On Thu, May 24, 2018 at 05:45:43PM -0700, Dhinakaran Pandiyan wrote: > On Thu, 2018-05-24 at 16:53 -0700, Lucas De Marchi wrote: > > On Mon, May 21, 2018 at 05:25:39PM -0700, Paulo Zanoni wrote: > > > > > > From: Anusha Srivatsa <anusha.sriva...@intel.com>

Re: [Intel-gfx] [PATCH 05/24] drm/i915/icp: Add Interrupt Support

2018-05-24 Thread Lucas De Marchi
C4_HOTPLUG(1 << 27) > +#define ICP_TC3_HOTPLUG(1 << 26) > +#define ICP_TC2_HOTPLUG(1 << 25) > +#define ICP_TC1_HOTPLUG(1 << 24) > +#define ICP_GMBUS (1 << 23) > +#define ICP_DDIB_HOTPLUG

Re: [Intel-gfx] [PATCH] drm/i915/dp: Link train Fallback on eDP only if fallback link BW can fit panel's native mode

2018-05-18 Thread Lucas De Marchi
lane count. > > BR, > Jani. > > > [1] > http://patchwork.freedesktop.org/patch/msgid/20180509071321.28563-1-jani.nik...@intel.com > [2] > http://patchwork.freedesktop.org/patch/msgid/20180516080110.22770-1-jani.nik...@intel.com Tested both patches and still the same probl

[Intel-gfx] [PATCH v2] drm/i915: remove check for aux irq

2018-05-23 Thread Lucas De Marchi
This became dead code with commit 309bd8ed464f ("drm/i915: Reinstate GMBUS and AUX interrupts on gen4/g4x"). v2: Move comment about HW behavior to where decision is made to enable MSI (Ville). Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Signed-off-by: Lucas De Mar

Re: [Intel-gfx] [PATCH 07/24] drm/i915/icl: Add DDI HDMI level selection for ICL

2018-06-11 Thread Lucas De Marchi
On Fri, Jun 1, 2018 at 3:32 PM Paulo Zanoni wrote: > > Em Sex, 2018-05-25 às 09:26 -0700, Lucas De Marchi escreveu: > > On Mon, May 21, 2018 at 05:25:41PM -0700, Paulo Zanoni wrote: > > > From: Manasi Navare > > > > > > This patch adds a proper HDMI DDI e

Re: [Intel-gfx] [PATCH 0/7] drm/i915: move towards kernel types

2018-06-12 Thread Lucas De Marchi
If using kernel types is where we want to go (which I agree with), maybe it would be better to have a single conversion rather than several small ones as we are doing with dev_priv -> i915? This allows in-flight-but-not-yet-sent patches to easily keep up with the changes rather than conflicting e

Re: [Intel-gfx] [PATCH 1/4] drm/i915: fix guest virtual PCH detection on non-PCH systems

2018-06-12 Thread Lucas De Marchi
On Fri, Jun 8, 2018 at 5:34 AM Jani Nikula wrote: > > On Thu, 31 May 2018, Lucas De Marchi wrote: > > On Thu, May 31, 2018 at 02:56:21PM +0300, Jani Nikula wrote: > >> Virtualized non-PCH systems such as Broxton or Geminilake should use > >> PCH_NONE to indic

Re: [Intel-gfx] [PATCH 1/4] drm/i915: fix guest virtual PCH detection on non-PCH systems

2018-06-13 Thread Lucas De Marchi
On Wed, Jun 13, 2018 at 1:11 AM Arkadiusz Hiler wrote: > > On Wed, Jun 13, 2018 at 09:49:09AM +0300, Jani Nikula wrote: > > On Tue, 12 Jun 2018, Lucas De Marchi wrote: > > > On Fri, Jun 8, 2018 at 5:34 AM Jani Nikula wrote: > > >> > > >>

Re: [Intel-gfx] [PATCH 1/4] drm/i915: fix guest virtual PCH detection on non-PCH systems

2018-06-13 Thread Lucas De Marchi
On Wed, Jun 13, 2018 at 10:09 AM Lucas De Marchi wrote: > > On Wed, Jun 13, 2018 at 1:11 AM Arkadiusz Hiler > wrote: > > > > On Wed, Jun 13, 2018 at 09:49:09AM +0300, Jani Nikula wrote: > > > On Tue, 12 Jun 2018, Lucas De Marchi wrote: > > > >

Re: [Intel-gfx] [PATCH 04/24] drm/i915/icl: Support for TC North Display interrupts

2018-06-13 Thread Lucas De Marchi
11 && (master_ctl & GEN11_DE_HPD_IRQ)) { > + iir = I915_READ(GEN11_DE_HPD_IIR); > + if (iir) { > + I915_WRITE(GEN11_DE_HPD_IIR, iir); > + ret = IRQ_HANDLED; > + gen11_hpd_irq_handler(dev_priv,

Re: [Intel-gfx] [PATCH 10/24] drm/i915/icl: add icelake_get_ddi_pll()

2018-06-13 Thread Lucas De Marchi
On Wed, Jun 13, 2018 at 04:51:57PM -0700, Paulo Zanoni wrote: > Em Qua, 2018-06-13 às 16:15 -0700, Lucas De Marchi escreveu: > > On Mon, May 21, 2018 at 05:25:44PM -0700, Paulo Zanoni wrote: > > > Implement the hardware state readout code. > > > > > >

Re: [Intel-gfx] [PATCH 14/24] drm/i915/icl: start adding the TBT pll

2018-06-13 Thread Lucas De Marchi
On Mon, May 21, 2018 at 05:25:48PM -0700, Paulo Zanoni wrote: > This commit just adds the register addresses and the basic skeleton of > the code. The next commits will expand on more specific functions. > > Signed-off-by: Paulo Zanoni Reviewed-by: Lucas De Marchi Luc

Re: [Intel-gfx] [PATCH 05/24] drm/i915/icp: Add Interrupt Support

2018-06-13 Thread Lucas De Marchi
On Tue, May 29, 2018 at 05:04:58PM -0700, Lucas De Marchi wrote: > On Thu, May 24, 2018 at 05:43:24PM -0700, Lucas De Marchi wrote: > > On Thu, May 24, 2018 at 05:45:43PM -0700, Dhinakaran Pandiyan wrote: > > > On Thu, 2018-05-24 at 16:53 -0700, Lucas De Marchi wrote: > >

Re: [Intel-gfx] [PATCH 10/24] drm/i915/icl: add icelake_get_ddi_pll()

2018-06-13 Thread Lucas De Marchi
uld be simpler: temp = I915_READ(DPCLKA_CFGCR0_ICL) >> DPCLKA_CFGCR0_DDI_CLK_SEL_SHIFT(port); id = temp & DPCLKA_CFGCR0_DDI_CLK_SEL_MASK(0); But this ship has sailed, aka MASK above requires the port and hardcoding 0 doesn't make it better IMO. Reviewed-by: Lucas De Marchi L

Re: [Intel-gfx] [PATCH 13/24] drm/i915/icl: unconditionally init DDI for every port

2018-06-13 Thread Lucas De Marchi
Paulo Zanoni Reviewed-by: Lucas De Marchi Lucas De Marchi > --- > drivers/gpu/drm/i915/intel_display.c | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c > b/drivers/gpu/drm/i915/intel_display.c > index

Re: [Intel-gfx] [PATCH v2] drm/i915: remove check for aux irq

2018-06-15 Thread Lucas De Marchi
On Fri, Jun 15, 2018 at 08:58:28PM +0300, Ville Syrjälä wrote: > On Wed, May 23, 2018 at 11:04:35AM -0700, Lucas De Marchi wrote: > > This became dead code with commit 309bd8ed464f ("drm/i915: Reinstate > > GMBUS and AUX interrupts on gen4/g4x"). > > > &g

Re: [Intel-gfx] [PATCH 18/24] drm/i915/icl: implement icl_digital_port_connected()

2018-06-19 Thread Lucas De Marchi
gt; + if (cpu_isr & tbt_bit) > + is_tbt = true; > + > + WARN_ON(is_legacy + is_typec + is_tbt > 1); > + if (!is_legacy && !is_typec && !is_tbt) > + return false; > + > + return true; you know you could "return

Re: [Intel-gfx] [PATCH v2] drm/i915: remove check for aux irq

2018-06-19 Thread Lucas De Marchi
On Tue, Jun 19, 2018 at 7:06 AM Ville Syrjälä wrote: > > On Fri, Jun 15, 2018 at 02:51:06PM -0700, Lucas De Marchi wrote: > > On Fri, Jun 15, 2018 at 08:58:28PM +0300, Ville Syrjälä wrote: > > > On Wed, May 23, 2018 at 11:04:35AM -0700, Lucas De Marchi wrote: > >

Re: [Intel-gfx] [PATCH 16/24] drm/i915/icl: Handle hotplug interrupts for DP over TBT

2018-06-13 Thread Lucas De Marchi
te, DP over TBT, native DP > or native HDMI. > > Cc: Animesh Manna > Cc: Paulo Zanoni > Cc: Anusha Srivatsa > Cc: Manasi Navare > Signed-off-by: Dhinakaran Pandiyan > Signed-off-by: Paulo Zanoni Reviewed-by: Lucas De Marchi Lucas De Marchi > -

Re: [Intel-gfx] [PATCH 05/24] drm/i915/icp: Add Interrupt Support

2018-05-29 Thread Lucas De Marchi
On Thu, May 24, 2018 at 05:43:24PM -0700, Lucas De Marchi wrote: > On Thu, May 24, 2018 at 05:45:43PM -0700, Dhinakaran Pandiyan wrote: > > On Thu, 2018-05-24 at 16:53 -0700, Lucas De Marchi wrote: > > > On Mon, May 21, 2018 at 05:25:39PM -0700, Paulo Zanoni wrote: > > &

Re: [Intel-gfx] [PATCH 4/4] drm/i915: fix PCH_NOP setting for non-PCH platforms

2018-05-31 Thread Lucas De Marchi
break; > } > } > + > + /* > + * Use PCH_NOP (PCH but no South Display) for PCH platforms without Like I said on patch 1 I'd rather document in the enum what it is and here just a "Use PCH_NOP for PCH platforms without display" Lucas De M

Re: [Intel-gfx] [PATCH 1/4] drm/i915: fix guest virtual PCH detection on non-PCH systems

2018-05-31 Thread Lucas De Marchi
document it? - Subject: [PATCH] drm/i915: document PCH_NOP There's a difference between PCH_NONE and PCH_NOP: the former means we don't have a PCH while in the latter we do, but it doesn't have the south display. Cc: Jani Nikula Signed-off-by: Lucas De Marchi --- drivers/gpu

Re: [Intel-gfx] [PATCH] drm/i915/icp: Add Interrupt Support

2018-06-26 Thread Lucas De Marchi
ts. Confirm in the commit message that > icp_irq_postinstall() need not go to > ibx_irq_pre_postinstall() and ibx_irq_postinstall() > as in earlier platforms. (Paulo) > > Cc: Lucas De Marchi Better now. Reviewed-by: Lucas De Marchi Lucas De Marchi > Cc: Paulo Zanoni >

Re: [Intel-gfx] [PATCH 2/2] drm/i915/icl: implement icl_digital_port_connected()

2018-06-30 Thread Lucas De Marchi
uld be. > > v2: > - Change the register names, to be consistent with > the rest of the platforms. > > Cc: Animesh Manna > Cc: Lucas De Marchi > Signed-off-by: Anusha Srivatsa > Signed-off-by: Paulo Zanoni > Signed-off-by: Rodrigo Vivi My review stands for v2 as done in

Re: [Intel-gfx] [PATCH] drm/i915: remove check for aux irq

2018-04-30 Thread Lucas De Marchi
On Thu, Apr 26, 2018 at 06:50:05PM +0300, Ville Syrjälä wrote: > On Thu, Apr 26, 2018 at 08:42:54AM -0700, Lucas De Marchi wrote: > > On Thu, Apr 26, 2018 at 06:27:26PM +0300, Ville Syrjälä wrote: > > > On Thu, Apr 26, 2018 at 08:22:12AM -0700, Lucas De Marchi wrote: > >

Re: [Intel-gfx] [PATCH] drm/i915: remove check for aux irq

2018-04-26 Thread Lucas De Marchi
On Thu, Apr 26, 2018 at 04:43:38PM +0300, Ville Syrjälä wrote: > On Wed, Apr 25, 2018 at 02:55:24PM -0700, Lucas De Marchi wrote: > > This became dead code with commit 309bd8ed464f ("drm/i915: Reinstate > > GMBUS and AUX interrupts on gen4/g4x"). > > &g

Re: [Intel-gfx] [PATCH] drm/i915: remove check for aux irq

2018-04-26 Thread Lucas De Marchi
On Thu, Apr 26, 2018 at 06:27:26PM +0300, Ville Syrjälä wrote: > On Thu, Apr 26, 2018 at 08:22:12AM -0700, Lucas De Marchi wrote: > > On Thu, Apr 26, 2018 at 04:43:38PM +0300, Ville Syrjälä wrote: > > > On Wed, Apr 25, 2018 at 02:55:24PM -0700, Lucas De Marchi wrote: > > &

[Intel-gfx] [PATCH i-g-t] meson: use message() rather than warning()

2018-01-04 Thread Lucas De Marchi
own function "warning". Fixes: 865a47ca ("overlay: parse tracepoints from sysfs to figure out fields' location") Signed-off-by: Lucas De Marchi <lucas.demar...@intel.com> Cc: Rhys Kidd <rhysk...@gmail.com> Cc: Daniel Vetter <daniel.vet...@ffwll.ch> C

Re: [Intel-gfx] [PATCH 01/11] drm/i915/cnl: Add Cannonlake PCI IDs for another SKU.

2018-01-09 Thread Lucas De Marchi
patches to avoid conflicts (it's easier to bring back a small rework as dependency than keep having conflicts in the same place as we backport IDs)... so the split per se seems good so each commit does only one thing, but I'm not sure about the backport argument. Lucas De Marchi > >> &g

Re: [Intel-gfx] [PATCH] drm/i915/cnp: Properly handle VBT ddc pin out of bounds.

2018-01-25 Thread Lucas De Marchi
[DDC_BUS_DDI_D] = GMBUS_PIN_4_CNP, /* sic */ @@ -1116,7 +1117,7 @@ static const u8 cnp_ddc_pin_map[] = { static u8 map_ddc_pin(struct drm_i915_private *dev_priv, u8 vbt_pin) { if (HAS_PCH_CNP(dev_priv)) { - if (vbt_pin &

Re: [Intel-gfx] [PATCH] drm/i915/cnp: Properly handle VBT ddc pin out of bounds.

2018-01-25 Thread Lucas De Marchi
r. > > Fixes: a8e6f3888b05 ("drm/i915/cnp: Ignore VBT request for know invalid DDC > pin.") > Fixes: 9c3b2689d01f ("drm/i915/cnl: Map VBT DDC Pin to BSpec DDC Pin.") > Cc: Radhakrishna Sripada <radhakrishna.srip...@intel.com> > Cc: Jani Nikula <ja

[Intel-gfx] [PATCH i-g-t] lib/i915_pciids.h: synchronize with kernel header

2017-12-20 Thread Lucas De Marchi
Synchronize with kernel header as of c99d7832dcd7 ("drm/i915/cfl: Adding more Coffee Lake PCI IDs.") Signed-off-by: Lucas De Marchi <lucas.demar...@intel.com> --- lib/i915_pciids.h | 28 ++-- 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/l

Re: [Intel-gfx] [PATCH i-g-t] meson: Bump required version to 0.44.0

2017-12-26 Thread Lucas De Marchi
l.com> I just had this error and prepared a patch to do the other way around: use message() rather than warning(). I think we could delay raising the dependency to the latest meson version on Fedora 27 for example we have meson 0.43 available, not 0.44 (although we could install 0.44 from pypi

Re: [Intel-gfx] [PATCH v2] drm/i915: remove check for aux irq

2018-06-21 Thread Lucas De Marchi
On Tue, Jun 19, 2018 at 01:17:10PM -0700, Dhinakaran Pandiyan wrote: > On Tue, 2018-06-19 at 08:24 -0700, Lucas De Marchi wrote: > > On Tue, Jun 19, 2018 at 7:06 AM Ville Syrjälä > > wrote: > > > > > > > > > On Fri, Jun 15, 2018

Re: [Intel-gfx] [PATCH 0/7] drm/i915: move towards kernel types

2018-06-19 Thread Lucas De Marchi
On Fri, Jun 15, 2018 at 2:08 AM Jani Nikula wrote: > > On Thu, 14 Jun 2018, Rodrigo Vivi wrote: > > On Wed, Jun 13, 2018 at 09:55:38AM +0300, Jani Nikula wrote: > >> On Tue, 12 Jun 2018, Lucas De Marchi wrote: > >> > On Tue, Jun 12, 2018 at 3

Re: [Intel-gfx] [PATCH 1/4] drm/i915: fix guest virtual PCH detection on non-PCH systems

2018-06-19 Thread Lucas De Marchi
On Wed, Jun 13, 2018 at 11:57 PM Arkadiusz Hiler wrote: > > On Wed, Jun 13, 2018 at 10:16:07AM -0700, Lucas De Marchi wrote: > > On Wed, Jun 13, 2018 at 10:09 AM Lucas De Marchi > > wrote: > > > > > > On Wed, Jun 13, 2018 at 1:11 AM Arkadiusz Hiler > >

Re: [Intel-gfx] [PATCH 01/10] drm/i915/icl: Fix power well anonymous union initializers

2018-08-02 Thread Lucas De Marchi
to gcc 4.5 as minimum version? Or was it 4.6/4.8? Lucas De Marchi > > Cc: Chris Wilson > Cc: Ville Syrjala > Cc: Paulo Zanoni > Cc: Jani Nikula > Signed-off-by: Imre Deak > --- > drivers/gpu/drm/i915/intel_runtime_pm.c | 22 +++--- > 1 file changed,

[Intel-gfx] [PATCH i-g-t] docs: fix typo sharding->sharing

2018-08-02 Thread Lucas De Marchi
I was grepping for shard as the tests run on CI, but the only occurrence was this one which seems to be a typo since it's about prime tests. Fixes: 76bce773 ("docs: Update documentation generation with missing entries") Signed-off-by: Lucas De Marchi --- docs/reference/igt

Re: [Intel-gfx] [PATCH 01/10] drm/i915/icl: Fix power well anonymous union initializers

2018-08-03 Thread Lucas De Marchi
On Fri, Aug 3, 2018 at 3:24 AM Imre Deak wrote: > > On Thu, Aug 02, 2018 at 05:24:36PM -0700, Paulo Zanoni wrote: > > Em Qui, 2018-08-02 às 16:17 -0700, Lucas De Marchi escreveu: > > > On Fri, Jul 20, 2018 at 05:14:55PM +0300, Imre Deak wrote: > > > > Similarly t

[Intel-gfx] [PATCH v4 2/2] drm/i915: kill resource streamer

2018-08-03 Thread Lucas De Marchi
() is made much earlier by i915_gem_check_execbuffer() (suggested by Tvrtko) Signed-off-by: Lucas De Marchi Acked-by: Daniele Ceraolo Spurio --- drivers/gpu/drm/i915/i915_drv.c| 2 +- drivers/gpu/drm/i915/i915_drv.h| 2 -- drivers/gpu/drm/i915/i915_gem_execbuffer.c

[Intel-gfx] [PATCH v4 1/3] drm/i915: make PCH_GMBUS* definitions private to gvt

2018-07-27 Thread Lucas De Marchi
This is the only place that they are being used - the others use the GMBUS* macros that rely on dev_priv being already properly initialized. Cc: intel-gvt-...@lists.freedesktop.org Cc: Zhenyu Wang Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/gvt/reg.h | 7 +++ drivers/gpu/drm

[Intel-gfx] [PATCH v4 3/3] drm/i915: remove confusing GPIO vs PCH_GPIO

2018-07-27 Thread Lucas De Marchi
GMBUS/GPIO handling from gvt since now they have their own defines. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/i915_drv.h | 3 ++- drivers/gpu/drm/i915/i915_reg.h | 24 +--- drivers/gpu/drm/i915/intel_display.h | 16 drivers/gpu

[Intel-gfx] [PATCH v4 2/3] drm/i915/gvt: use its own define for gpio

2018-07-27 Thread Lucas De Marchi
The definition on i915_reg.h is going to change to depend on dev_priv->gpio_mmio_base being properly initialized. Define our own macros since init_generic_mmio_info() is called before than gpio_mmio_base being set. Cc: intel-gvt-...@lists.freedesktop.org Cc: Zhenyu Wang Signed-off-by: Lucas

Re: [Intel-gfx] [PATCH i-g-t] docs: fix typo sharding->sharing

2018-08-15 Thread Lucas De Marchi
On Wed, Aug 15, 2018 at 2:09 AM Daniel Vetter wrote: > > On Tue, Aug 14, 2018 at 10:29:02AM -0700, Lucas De Marchi wrote: > > On Fri, Aug 03, 2018 at 12:07:43PM +0300, Petri Latvala wrote: > > > On Thu, Aug 02, 2018 at 03:09:37PM -0700, Lucas De Marchi wrote: > > &

Re: [Intel-gfx] [PATCH i-g-t] docs: fix typo sharding->sharing

2018-08-14 Thread Lucas De Marchi
On Fri, Aug 03, 2018 at 12:07:43PM +0300, Petri Latvala wrote: > On Thu, Aug 02, 2018 at 03:09:37PM -0700, Lucas De Marchi wrote: > > I was grepping for shard as the tests run on CI, but the only occurrence > > was this one which seems to be a typo since it's about prime tests.

Re: [Intel-gfx] [PATCH v4 3/3] drm/i915: remove confusing GPIO vs PCH_GPIO

2018-08-14 Thread Lucas De Marchi
On Fri, Jul 27, 2018 at 12:36:47PM -0700, Lucas De Marchi wrote: > Instead of defining all registers twice, define just a PCH_GPIO_BASE > that has the same address as PCH_GPIO_A and use that to calculate all > the others. This also brings VLV and !HAS_GMCH_DISPLAY in line, doing > th

[Intel-gfx] [PATCH libdrm 1/4] intel: add IS_GENX() generic macro

2018-08-24 Thread Lucas De Marchi
-08m-20d-21h-41m-11s. Signed-off-by: Lucas De Marchi --- intel/i915_pciids.h | 461 ++ intel/intel_chipset.h | 20 ++ 2 files changed, 481 insertions(+) create mode 100644 intel/i915_pciids.h diff --git a/intel/i915_pciids.h b/intel/i915_pciids.h new file

[Intel-gfx] [PATCH libdrm 3/4] intel: make gen10 use generic gen macro

2018-08-24 Thread Lucas De Marchi
Signed-off-by: Lucas De Marchi --- intel/intel_chipset.h | 33 + 1 file changed, 1 insertion(+), 32 deletions(-) diff --git a/intel/intel_chipset.h b/intel/intel_chipset.h index 163fb536..82f3b5a0 100644 --- a/intel/intel_chipset.h +++ b/intel/intel_chipset.h

[Intel-gfx] [PATCH libdrm 4/4] intel: make gen9 use generic gen macro

2018-08-24 Thread Lucas De Marchi
The 2 PCI IDs that are used for the command line overrid mechanism were left defined. The rest can be gone and then we just use the kernel defines. Signed-off-by: Lucas De Marchi --- intel/intel_chipset.h | 188 +- 1 file changed, 3 insertions(+), 185

[Intel-gfx] [PATCH libdrm 2/4] intel: make gen11 use generic gen macro

2018-08-24 Thread Lucas De Marchi
Signed-off-by: Lucas De Marchi --- intel/intel_chipset.h | 26 ++ 1 file changed, 2 insertions(+), 24 deletions(-) diff --git a/intel/intel_chipset.h b/intel/intel_chipset.h index 8a0e3e76..163fb536 100644 --- a/intel/intel_chipset.h +++ b/intel/intel_chipset.h

[Intel-gfx] [PATCH libdrm 0/4] intel: rework how we add PCI IDs

2018-08-24 Thread Lucas De Marchi
@@drm_intel@sha/intel_decode.c.o Let me know what you think. Lucas De Marchi (4): intel: add IS_GENX() generic macro intel: make gen11 use generic gen macro intel: make gen10 use generic gen macro intel: make gen9 use generic gen macro intel/i915_pciids.h | 461

Re: [Intel-gfx] [PATCH libdrm 1/4] intel: add IS_GENX() generic macro

2018-08-28 Thread Lucas De Marchi
On Tue, Aug 28, 2018 at 09:38:59AM +0100, Chris Wilson wrote: > Quoting Lucas De Marchi (2018-08-28 02:00:27) > > On Sat, Aug 25, 2018 at 10:35:23AM +0100, Chris Wilson wrote: > > > Quoting Lucas De Marchi (2018-08-25 00:56:46) > > > > diff --git a/intel/intel_chi

Re: [Intel-gfx] [PATCH 2/2] drm/i915: reword documentation of possible pci_device_id struct

2018-08-28 Thread Lucas De Marchi
On Tue, Aug 28, 2018 at 07:05:46PM +0100, Chris Wilson wrote: > Quoting Lucas De Marchi (2018-08-28 18:41:46) > > Document it like a real struct for ease of copy and paste, remove > > comment of C99 compatibility and document that in some cases the first 2 > > I do recall

[Intel-gfx] [PATCH 1/2] drm/i915: make field unsigned

2018-08-28 Thread Lucas De Marchi
subvendor and subdevice are unsigned, so fix their initialization in INTEL_VGA_DEVICE. Cc: Chris Wilson Signed-off-by: Lucas De Marchi --- include/drm/i915_pciids.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h index

[Intel-gfx] [PATCH 2/2] drm/i915: reword documentation of possible pci_device_id struct

2018-08-28 Thread Lucas De Marchi
Document it like a real struct for ease of copy and paste, remove comment of C99 compatibility and document that in some cases the first 2 fields can be u16. Cc: Chris Wilson Signed-off-by: Lucas De Marchi --- include/drm/i915_pciids.h | 16 +--- 1 file changed, 9 insertions(+), 7

Re: [Intel-gfx] [PATCH 2/2] drm/i915: reword documentation of possible pci_device_id struct

2018-08-28 Thread Lucas De Marchi
On Tue, Aug 28, 2018 at 09:06:15PM +0300, Ville Syrjälä wrote: > On Tue, Aug 28, 2018 at 10:41:46AM -0700, Lucas De Marchi wrote: > > Document it like a real struct for ease of copy and paste, remove > > comment of C99 compatibility and document that in some cases the first 2 > &

[Intel-gfx] [PATCH libdrm v2 5/5] intel: get gen once for gen >= 9

2018-08-28 Thread Lucas De Marchi
We don't need to call IS_GEN() for each gen >= 9: we can rather use the new intel_is_genx() helper to iterate the pciids array once. Signed-off-by: Lucas De Marchi --- intel/intel_bufmgr_gem.c | 8 +--- intel/intel_decode.c | 8 ++-- 2 files changed, 3 insertions(+), 13 deleti

[Intel-gfx] [PATCH libdrm v2 1/5] intel: add generic functions to check PCI ID

2018-08-28 Thread Lucas De Marchi
rather than inherit the one kernel uses: we can throw away most of the fields Cc: Chris Wilson Signed-off-by: Lucas De Marchi --- intel/Makefile.sources | 1 + intel/i915_pciids.h| 461 + intel/intel_chipset.c | 77 +++ intel

[Intel-gfx] [PATCH libdrm v2 4/5] intel: make gen9 use generic gen macro

2018-08-28 Thread Lucas De Marchi
The 2 PCI IDs that are used for the command line overrid mechanism were left defined. The rest can be gone and then we just use the kernel defines. Signed-off-by: Lucas De Marchi --- intel/intel_chipset.c | 5 ++ intel/intel_chipset.h | 187 +- 2 files

[Intel-gfx] [PATCH libdrm v2 3/5] intel: make gen10 use generic gen macro

2018-08-28 Thread Lucas De Marchi
Signed-off-by: Lucas De Marchi --- intel/intel_chipset.c | 1 + intel/intel_chipset.h | 34 +- 2 files changed, 2 insertions(+), 33 deletions(-) diff --git a/intel/intel_chipset.c b/intel/intel_chipset.c index 5a549ba4..0c2ba884 100644 --- a/intel

[Intel-gfx] [PATCH libdrm v2 0/5] intel: rework how we add PCI IDs

2018-08-28 Thread Lucas De Marchi
there are some corner cases to cover and I didn't want to block the important part, i.e.: for recent gens, there's no risk of missing a PCI ID. v2: address comments from Chris by pulling it out to a separate .c Lucas De Marchi (5): intel: add generic functions to check PCI ID intel: make gen11 use

[Intel-gfx] [PATCH libdrm v2 2/5] intel: make gen11 use generic gen macro

2018-08-28 Thread Lucas De Marchi
Signed-off-by: Lucas De Marchi --- intel/intel_chipset.c | 1 + intel/intel_chipset.h | 27 ++- 2 files changed, 3 insertions(+), 25 deletions(-) diff --git a/intel/intel_chipset.c b/intel/intel_chipset.c index 8af99ad9..5a549ba4 100644 --- a/intel/intel_chipset.c +++ b

Re: [Intel-gfx] [PATCH libdrm 1/4] intel: add IS_GENX() generic macro

2018-08-27 Thread Lucas De Marchi
On Sat, Aug 25, 2018 at 10:35:23AM +0100, Chris Wilson wrote: > Quoting Lucas De Marchi (2018-08-25 00:56:46) > > diff --git a/intel/intel_chipset.h b/intel/intel_chipset.h > > index 4a34b7be..8a0e3e76 100644 > > --- a/intel/intel_chipset.h > > +++ b/intel/intel_chip

Re: [Intel-gfx] [PATCH libdrm 1/4] intel: add IS_GENX() generic macro

2018-08-27 Thread Lucas De Marchi
On Mon, Aug 27, 2018 at 10:40:28PM +0100, Chris Wilson wrote: > Quoting Lucas De Marchi (2018-08-27 22:19:54) > > On Sat, Aug 25, 2018 at 10:35:23AM +0100, Chris Wilson wrote: > > > Quoting Lucas De Marchi (2018-08-25 00:56:46) > > > That should help cut down the object

  1   2   3   4   5   6   7   8   9   >