Reviewed-by: Matthew Auld <matthew.a...@intel.com>
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
he WA is needed up to B0, but the WA db says up to A0...
I guess we should rather trust the hsd's?
Reviewed-by: Matthew Auld <matthew.a...@intel.com>
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by: Matthew Auld <matthew.a...@intel.com>
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
What about skl, this also seems to need the WA until A0?
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Well, at least for me having the global forcewake produces a kernel
warning during the suspend-resume test case.
On 9 June 2016 at 15:53, Chris Wilson <ch...@chris-wilson.co.uk> wrote:
> On Thu, Jun 09, 2016 at 03:33:47PM +0100, Matthew Auld wrote:
>> We shouldn't be holding the f
https://paste.fedoraproject.org/376691/
On 9 June 2016 at 16:22, Chris Wilson <ch...@chris-wilson.co.uk> wrote:
> On Thu, Jun 09, 2016 at 04:02:26PM +0100, Matthew Auld wrote:
>> Well, at least for me having the global forcewake produces a kernel
>> warning during the sus
Reviewed-by: Matthew Auld <matthew.a...@intel.com>
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On 4 June 2016 at 09:54, Arun Siluvery <arun.siluv...@linux.intel.com> wrote:
> On 03/06/2016 21:31, Matthew Auld wrote:
>>
>> What about skl, this also seems to need the WA until A0?
>
>
> SKL:A0 is pre-production stepping, it can
Reviewed-by: Matthew Auld <matthew.a...@intel.com>
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
We shouldn't be holding the forcewake whilst going through suspend-resume
cycle, so instead of globally holding the forcewake we reduce this to
when we actually need to read the registers.
Cc: Chris Wilson <ch...@chris-wilson.co.uk>
Signed-off-by: Matthew Auld <matthew.a...@intel.com>
Reviewed-by: Matthew Auld <matthew.a...@intel.com>
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Could you try to apply the following patch [1], hopefully this fixes
the issue for you.
[1] https://patchwork.freedesktop.org/patch/89111/
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
Reviewed-by: Matthew Auld <matthew.a...@intel.com>
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by: Matthew Auld <matthew.a...@intel.com>
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by: Matthew Auld <matthew.a...@intel.com>
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> #define KBL_REVID_A0 0x0
> #define KBL_REVID_B0 0x1
> +#define KBL_REVID_C0 0x2
> +#define KBL_REVID_D0 0x3
> +#define KBL_REVID_E0 0x3
hmm, shouldn't E0 here be 0x4?
___
Intel-gfx mailing list
Reviewed-by: Matthew Auld <matthew.a...@intel.com>
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> +#define GEN9_DEFAULT_FIXES(1<<3 | 1<<2 | 1 << 1)
Spacing seems a little off here
Reviewed-by: Matthew Auld <matthew.a...@intel.com>
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freed
Reviewed-by: Matthew Auld <matthew.a...@intel.com>
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by: Matthew Auld <matthew.a...@intel.com>
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by: Matthew Auld <matthew.a...@intel.com>
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by: Matthew Auld <matthew.a...@intel.com>
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by: Matthew Auld <matthew.a...@intel.com>
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by: Matthew Auld <matthew.a...@intel.com>
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by: Matthew Auld <matthew.a...@intel.com>
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by: Matthew Auld <matthew.a...@intel.com>
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
s/tho/though/
s/regarless/regardless/
Seems reasonable so:
Reviewed-by: Matthew Auld <matthew.a...@intel.com>
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
] SyS_ioctl+0x79/0x90
[ 378.438967] entry_SYSCALL_64_fastpath+0x1a/0xa4
Cc: dri-de...@lists.freedesktop.org
Cc: Daniel Vetter <daniel.vet...@intel.com>
Signed-off-by: Matthew Auld <matthew.a...@intel.com>
---
drivers/gpu/drm/drm_irq.c | 4 ++--
1 file changed, 2 insertions(+),
I seem to be hitting some issues with this, at least in gnome-shell
which I bisected to this commit. Somewhat hard to describe but the
background window or desktop is partiality and intermittently drawn,
almost like a flicker onto the foreground window, title-bar etc.
typically during any kind of
.uk>
Signed-off-by: Matthew Auld <matthew.a...@intel.com>
---
drivers/gpu/drm/i915/i915_gem_gtt.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.h
b/drivers/gpu/drm/i915/i915_gem_gtt.h
index 163b564..9e5228d 100644
--- a/drivers/
Reviewed-by: Matthew Auld <matthew.a...@intel.com>
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
lgtm
Reviewed-by: Matthew Auld <matthew.a...@intel.com>
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
When binding pages for a partial view we should check that the offset +
size is valid relative to the size of the gem object.
Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Signed-off-by: Matthew Auld <matthew.a...@intel.com>
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 4
> If this concerns you that, please look at the API,
and please review the outstanding patches.
Could you elaborate on this please?
What patches are you referring to?
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
> Y tiled fb will be rejected for gen < 9, should use X/linear for those.
Are you referring to the __gem_set_tiling call? Since this didn't fail
on BDW and I don't see any logic in i915_gem_set_tiling which
implements this.
> Actually using X/linear for gen >= 9 would also be interesting to
make
nen <joonas.lahti...@linux.intel.com>
Signed-off-by: Matthew Auld <matthew.a...@intel.com>
---
tests/kms_rotation_crc.c | 80
1 file changed, 80 insertions(+)
diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
index f94f8f1.
igned-off-by: Matthew Auld <matthew.a...@intel.com>
---
tests/kms_rotation_crc.c | 77
1 file changed, 77 insertions(+)
diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c
index f94f8f1..fb3e2e8 100644
--- a/tests/kms_rotation_cr
Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Signed-off-by: Matthew Auld <matthew.a...@intel.com>
---
drivers/gpu/drm/i915/i915_gem.c | 40
1 file changed, 16 insertions(+), 24 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem
No functional change, just makes the code easier to follow.
Signed-off-by: Matthew Auld <matthew.a...@intel.com>
---
drivers/gpu/drm/i915/i915_gem.c | 41 +++--
1 file changed, 11 insertions(+), 30 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_g
-by: Matthew Auld <matthew.a...@intel.com>
---
drivers/gpu/drm/i915/i915_gem.c | 52 +++--
1 file changed, 13 insertions(+), 39 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index f45856d..ffb802e 100644
--- a/drivers/g
Hi,
If we don't do any of the fence business for !i915_is_gtt, then will
this not change the following code:
if (alignment == 0)
alignment = flags & PIN_MAPPABLE ? fence_alignment : unfenced_alignment;
Or am I missing something?
Regards,
Matt
___
Add expect-to-fail tests for invalid rotations on each of the plane types.
Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Signed-off-by: Matthew Auld <matthew.a...@intel.com>
---
tests/kms_rotation_crc.c | 96
1 file changed, 9
This seems to be more in-line with what the function actually does, this
also makes it more consistent with i915_gem_obj_to_vma.
Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Cc: Chris Wilson <ch...@chris-wilson.co.uk>
Signed-off-by: Matthew Auld <matthew.a...@intel.com>
I use :autocmd FileType gitcommit setlocal spell
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Seems to be in-line with the spec, so with Chris' comment addressed
and s/idi has mask/idi hash mask/:
Reviewed-by: Matthew Auld <matthew.a...@intel.com>
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/m
Looks good, so with s/INTEL_INFO/INTEL_GEN/:
Reviewed-by: Matthew Auld <matthew.a...@intel.com>
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Much like with the equivalent gen8_alloc_va_range.
Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Signed-off-by: Matthew Auld <matthew.a...@intel.com>
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/
If we are not in FULL_48BIT_PPGTT mode then we really shouldn't
continue on with our allocations, given that the call to free_dpd would
bail early without freeing everything, thus leaking memory.
Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Signed-off-by: Matthew Auld <
Looks a little neater and ever so slightly reduces the size of the
binary.
Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Signed-off-by: Matthew Auld <matthew.a...@intel.com>
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
We need to kunmap pt_vadrr and not pt itself, otherwise we end up
mapping a bunch of pages without ever unmapping them.
Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Signed-off-by: Matthew Auld <matthew.a...@intel.com>
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 2 +-
1 fil
Remove dev local and use to_i915() in gen8_ppgtt_notify_vgt.
Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Signed-off-by: Matthew Auld <matthew.a...@intel.com>
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/dri
A call to i915_gem_alloc_object can only ever return NULL in the event
of an error.
Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Signed-off-by: Matthew Auld <matthew.a...@intel.com>
---
drivers/gpu/drm/i915/i915_gem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
There's already a patch in the works for this:
https://patchwork.freedesktop.org/patch/80078/
Regards,
Matt
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
We need to kunmap pt_vaddr and not pt itself, otherwise we end up
mapping a bunch of pages without ever unmapping them.
Cc: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Signed-off-by: Matthew Auld <matthew.a...@intel.com>
---
dr
Remove dev local and use to_i915() in gen8_ppgtt_notify_vgt.
v2: use dev_priv directly for QUESTION_MACROS (Joonas Lahtinen)
Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Signed-off-by: Matthew Auld <matthew.a...@intel.com>
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 5 +
Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Signed-off-by: Matthew Auld <matthew.a...@intel.com>
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 17 -
1 file changed, 4 insertions(+), 13 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c
b/drivers/gpu/drm/i
intel.com>
Signed-off-by: Matthew Auld <matthew.a...@intel.com>
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c
b/drivers/gpu/drm/i915/i915_gem_gtt.c
index fa583d5..6601b11 100644
--- a/dr
No functional change, just makes the code easier to follow.
v2:
- Remove local fence_size variable
(Tvrtko Ursulin)
- Remove redundant NULL ggtt_view check
- Reuse size variable
Signed-off-by: Matthew Auld <matthew.a...@intel.com>
---
drivers/gpu/drm/i915/i915_gem.
s/requite/require
s/presumaly/presumably
s/disalling/disabling
I think this makes sense so:
Reviewed-by: Matthew Auld <matthew.a...@intel.com>
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/li
dle overflow
- Less idiotic placement
- Treat as programmer error
Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Signed-off-by: Matthew Auld <matthew.a...@intel.com>
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 8
1 file changed, 8 insertions(+)
diff --git a/drive
Reviewed-by: Matthew Auld <matthew.a...@intel.com>
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
ameter
v3: Another rebase due to s/""/NULL/
v4: Rebased on drm-nightly (Matthew Auld)
v5: Fix email address (Matthew Auld)
Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com>
Reviewed-by: Matthew Auld <matthew.a...@intel.com>
---
drivers/gpu/d
Hi Chris,
Are the changes acceptable?
Regards,
Matt
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reject any rotation value which incorrectly represents multiple rotations.
Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Signed-off-by: Matthew Auld <matthew.a...@intel.com>
---
drivers/gpu/drm/i915/intel_atomic_plane.c | 5 +
1 file changed, 5 insertions(+)
diff --git a
hti...@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursu...@linux.intel.com>
Signed-off-by: Matthew Auld <matthew.a...@intel.com>
---
drivers/gpu/drm/i915/i915_gem.c | 9 ++---
drivers/gpu/drm/i915/i915_gem_gtt.c | 10 +-
2 files changed, 3 insertions(+), 16 deletions(-)
diff -
Signed-off-by: Matthew Auld <matthew.a...@intel.com>
---
drivers/gpu/drm/i915/intel_display.c | 32 +---
1 file changed, 21 insertions(+), 11 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index 74b0165..b
/""/NULL/
v4: Rebased on drm-nightly (Matthew Auld)
Signed-off-by: Ville Syrjälä
Reviewed-by: Matthew Auld <matthew.a...@intel.com>
---
drivers/gpu/drm/i915/intel_display.c | 64 ++--
drivers/gpu/drm/i915/intel_sprite.c | 34 +++
2 f
Hi Daniel,
>> I thought we do normalize this somewhere.
I did write an i-g-t test which submits such a rotation value and it
is not rejected.
>> Your patch lacks motivation
As in I haven't properly conveyed the motivation behind the patch in
the commit message?
>> Yes I can usually guess when
When unpinning a ggtt_view check vma for error, otherwise we may end up
accessing an invalid pointer.
Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Signed-off-by: Matthew Auld <matthew.a...@intel.com>
---
drivers/gpu/drm/i915/i915_gem.c | 2 +-
1 file changed, 1 insertion(+)
No point in initialising pages with obj->pages, only to overwrite it with
ggtt_view.pages later. So lets just get rid of pages altogether.
Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Signed-off-by: Matthew Auld <matthew.a...@intel.com>
---
drivers/gpu/drm/i915/i915
Okay, I'll rework the patch to use drm_rotation_simplify instead.
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
I think it would be more idiomatic to replace:
+ for (i = 0; i < display->n_outputs; i++) {
+ igt_output_t *output = >outputs[i];
with:
+ for_each_connected_output(display, output)
And:
+ for (i = 0; i < pipe->n_planes; i++) {
+ igt_plane_t *plane = >planes[i];
el.com>
Signed-off-by: Matthew Auld <matthew.a...@intel.com>
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c
b/drivers/gpu/drm/i915/i915_gem_gtt.c
index 7b8de85..596692b 100644
--- a/drivers/gpu/drm/i915
When binding pages for a partial view we should check that the offset +
size is valid relative to the size of the gem object.
v2: Don't use pages->nents to determine the page count (Tvrtko Ursulin)
Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Signed-off-by: Matthew Auld &
Reviewed-by: Matthew Auld <matthew.a...@intel.com>
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
As suggested by Ville Syrjälä, add expect-to-fail tests for X-tiled
90/270 rotations on gen >= 9
Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Signed-off-by: Matthew Auld <matthew.a...@intel.com>
---
tests/kms_rotation_crc.c | 54 +
From: Chris Wilson <ch...@chris-wilson.co.uk>
Propagate the real error from drm_gem_object_init(). Note this also
fixes some confusion in the error return from i915_gem_alloc_object...
v2:
(Matthew Auld)
- updated new users of gem_alloc_object from latest drm-nightly
- replaced occur
Remove dev local and use to_i915() in gen8_ppgtt_notify_vgt.
v2: use dev_priv directly for QUESTION_MACROS (Joonas Lahtinen)
Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Signed-off-by: Matthew Auld <matthew.a...@intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahti...@
.uk>
Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Signed-off-by: Matthew Auld <matthew.a...@intel.com>
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 13 -
1 file changed, 8 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c
b/dr
Only has one user and is nothing more than a shim on top of
i915_vma_unbind, so let's just get rid of it.
Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Suggested-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Signed-off-by: Matthew Auld <matthew.a...@intel.com>
--
Use goto teardown path and also ensure we reset any struct members which
would otherwise contain an error encoded pointer, and could be mistaken
for a valid address.
Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Signed-off-by: Matthew Auld <matthew.a...@intel.com>
---
dri
appropriate goto label name
Cc: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Signed-off-by: Matthew Auld <matthew.a...@intel.com>
Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
---
drivers/gpu/drm/i915/i915_gem_gtt
ble manipulation routines / LRC context population routines read the
address space mode from it instead of the system configuration.
v2:
(Matthew Auld)
- rebase on latest -nightly
- prefer i915_vm_to_ppgtt instead of container_of
- initialise address_space_mode _before_ we attempt to init
sc
From: "Wang, Zhi A" <zhi.a.w...@intel.com>
After the per-PPGTT address mode gets support, the LRC submission should
generate the address mode bit from PPGTT instance, instead of the
hard-coded system configuration.
v2:
(Matthew Auld)
- rebase on latest -nightly
Cc: Chris Wil
The teardown path in render_state_init leaves so->obj != NULL.
Suggested-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com>
Signed-off-by: Matthew Auld <matthew.a...@intel.com>
---
drivers/gpu/drm/i915/i915_gem_render_state.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/
com>
Signed-off-by: Matthew Auld <matthew.a...@intel.com>
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 25 -
1 file changed, 16 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c
b/drivers/gpu/drm/i915/i915_gem_gtt.c
index 0d666b3..87947ec 1006
> + bo = i915_gem_object_create(dev_priv->dev, OA_BUFFER_SIZE);
> + if (bo == NULL) {
IS_ERR()
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
From: Chris Wilson <ch...@chris-wilson.co.uk>
Propagate the real error from drm_gem_object_init(). Note this also
fixes some confusion in the error return from i915_gem_alloc_object...
v2:
(Matthew Auld)
- updated new users of gem_alloc_object from latest drm-nightly
- replaced occur
tel.com>
Signed-off-by: Matthew Auld <matthew.a...@intel.com>
---
drivers/gpu/drm/drm_irq.c | 90 +++
include/drm/drmP.h| 14 +++-
2 files changed, 17 insertions(+), 87 deletions(-)
diff --git a/drivers/gpu/drm/drm_irq.c b/drivers
There's an updated version of this patch already on the ml [1], which
I Cc'd you in on. I take it that your @tuebingen.mpg.de is in fact an
old email address?
[1] https://patchwork.freedesktop.org/patch/86354/
___
Intel-gfx mailing list
> Test drv_module_reload_basic:
> pass -> INCOMPLETE (skl-nuci5)
Machine seems to have hanged after reloading module, couldn't possibly
be related to this patch. Will create new bug report...
> Test gem_exec_create:
> Subgroup basic:
> pass ->
Reviewed-by: Matthew Auld <matthew.a...@intel.com>
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by: Matthew Auld <matthew.a...@intel.com>
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
:
- reduce the scope of the seqlock, keeping vblank_time_lock
- make the seqlock per vblank_crtc, so multiple readers aren't blocked by
the writer
Cc: Daniel Vetter <daniel.vet...@ffwll.ch>
Cc: Ville Syrjälä <ville.syrj...@linux.intel.com>
Signed-off-by: Matthew Auld <matthew
: Daniel Vetter <daniel.vet...@ffwll.ch>
Cc: Ville Syrjälä <ville.syrj...@linux.intel.com>
Signed-off-by: Matthew Auld <matthew.a...@intel.com>
---
drivers/gpu/drm/drm_irq.c | 111 +-
include/drm/drmP.h| 14 ++
2 files chan
On 5 July 2016 at 14:21, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915: remove superfluous i915_gem_object_free_mmap_offset call
> URL : https://patchwork.freedesktop.org/series/9516/
> State : failure
>
> == Summary ==
>
> Series 9516v1
> Test gem_exec_flush:
> Subgroup basic-batch-kernel-default-cmd:
> pass -> FAIL (ro-byt-n2820)
https://bugs.freedesktop.org/show_bug.cgi?id=95372
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
But in the bug report the pciid=0x5916 and rev=0x0, which makes it KBL
A0, right? So something else must be going on here. There also seems
to be a mismatch between #2226938, #2225763 and #2225601 in terms of
what the wa should be, some make reference to bit[30].
Reviewed-by: Matthew Auld <matthew.a...@intel.com>
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Reviewed-by: Matthew Auld <matthew.a...@intel.com>
Tested-by: Matthew Auld <matthew.a...@intel.com>
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
1 - 100 of 3767 matches
Mail list logo