Re: [Intel-gfx] [PATCH 20/24] drm/i915/gen9: Add WaEnableChickenDCPR

2016-06-03 Thread Matthew Auld
Reviewed-by: Matthew Auld <matthew.a...@intel.com> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 13/24] drm/i915/kbl: Add WaDisableDynamicCreditSharing

2016-06-03 Thread Matthew Auld
he WA is needed up to B0, but the WA db says up to A0... I guess we should rather trust the hsd's? Reviewed-by: Matthew Auld <matthew.a...@intel.com> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 17/24] drm/i915/kbl: Add WaForGAMHang

2016-06-03 Thread Matthew Auld
Reviewed-by: Matthew Auld <matthew.a...@intel.com> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 25/25] drm/i915/kbl: Add WaClearSlmSpaceAtContextSwitch

2016-06-03 Thread Matthew Auld
What about skl, this also seems to need the WA until A0? ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH i-g-t] tests/gem_workarounds: reduce scope of intel_register_access_init

2016-06-09 Thread Matthew Auld
Well, at least for me having the global forcewake produces a kernel warning during the suspend-resume test case. On 9 June 2016 at 15:53, Chris Wilson <ch...@chris-wilson.co.uk> wrote: > On Thu, Jun 09, 2016 at 03:33:47PM +0100, Matthew Auld wrote: >> We shouldn't be holding the f

Re: [Intel-gfx] [PATCH i-g-t] tests/gem_workarounds: reduce scope of intel_register_access_init

2016-06-09 Thread Matthew Auld
https://paste.fedoraproject.org/376691/ On 9 June 2016 at 16:22, Chris Wilson <ch...@chris-wilson.co.uk> wrote: > On Thu, Jun 09, 2016 at 04:02:26PM +0100, Matthew Auld wrote: >> Well, at least for me having the global forcewake produces a kernel >> warning during the sus

Re: [Intel-gfx] [PATCH 15/24] drm/i915/gen9: Add WaDisableSkipCaching

2016-06-07 Thread Matthew Auld
Reviewed-by: Matthew Auld <matthew.a...@intel.com> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 25/25] drm/i915/kbl: Add WaClearSlmSpaceAtContextSwitch

2016-06-06 Thread Matthew Auld
On 4 June 2016 at 09:54, Arun Siluvery <arun.siluv...@linux.intel.com> wrote: > On 03/06/2016 21:31, Matthew Auld wrote: >> >> What about skl, this also seems to need the WA until A0? > > > SKL:A0 is pre-production stepping, it can

Re: [Intel-gfx] [PATCH 10/25] drm/i915/kbl: Add WaDisableLSQCROPERFforOCL

2016-06-06 Thread Matthew Auld
Reviewed-by: Matthew Auld <matthew.a...@intel.com> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH i-g-t] tests/gem_workarounds: reduce scope of intel_register_access_init

2016-06-09 Thread Matthew Auld
We shouldn't be holding the forcewake whilst going through suspend-resume cycle, so instead of globally holding the forcewake we reduce this to when we actually need to read the registers. Cc: Chris Wilson <ch...@chris-wilson.co.uk> Signed-off-by: Matthew Auld <matthew.a...@intel.com>

Re: [Intel-gfx] [PATCH 12/24] drm/i915/kbl: Add WaDisableGamClockGating

2016-06-03 Thread Matthew Auld
Reviewed-by: Matthew Auld <matthew.a...@intel.com> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] 4.7-rc0: redshift stopped working on intel display

2016-05-29 Thread Matthew Auld
Could you try to apply the following patch [1], hopefully this fixes the issue for you. [1] https://patchwork.freedesktop.org/patch/89111/ ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org

Re: [Intel-gfx] [PATCH 07/25] drm/i915/kbl: Add WaDisableFenceDestinationToSLM for A0

2016-06-02 Thread Matthew Auld
Reviewed-by: Matthew Auld <matthew.a...@intel.com> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 08/24] drm/i915/kbl: Add WaDisableSDEUnitClockGating

2016-06-02 Thread Matthew Auld
Reviewed-by: Matthew Auld <matthew.a...@intel.com> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 09/24] drm/i915/edp: Add WaKVMNotificationOnConfigChange:bdw

2016-06-02 Thread Matthew Auld
Reviewed-by: Matthew Auld <matthew.a...@intel.com> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 10/24] drm/i915/kbl: Add WaDisableLSQCROPERFforOCL

2016-06-02 Thread Matthew Auld
> #define KBL_REVID_A0 0x0 > #define KBL_REVID_B0 0x1 > +#define KBL_REVID_C0 0x2 > +#define KBL_REVID_D0 0x3 > +#define KBL_REVID_E0 0x3 hmm, shouldn't E0 here be 0x4? ___ Intel-gfx mailing list

Re: [Intel-gfx] [PATCH 14/24] drm/i915: Add WaInsertDummyPushConstP for bxt and kbl

2016-06-02 Thread Matthew Auld
Reviewed-by: Matthew Auld <matthew.a...@intel.com> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 11/24] drm/i915/gen9: Enable must set chicken bits in config0 reg

2016-06-02 Thread Matthew Auld
> +#define GEN9_DEFAULT_FIXES(1<<3 | 1<<2 | 1 << 1) Spacing seems a little off here Reviewed-by: Matthew Auld <matthew.a...@intel.com> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freed

Re: [Intel-gfx] [PATCH 16/24] drm/i915/skl: Add WAC6entrylatency

2016-06-02 Thread Matthew Auld
Reviewed-by: Matthew Auld <matthew.a...@intel.com> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 19/24] drm/i915/kbl: Add WaDisableSbeCacheDispatchPortSharing

2016-06-02 Thread Matthew Auld
Reviewed-by: Matthew Auld <matthew.a...@intel.com> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 24/24] drm/i915/skl: Extend WaDisableChickenBitTSGBarrierAckForFFSliceCS

2016-06-02 Thread Matthew Auld
Reviewed-by: Matthew Auld <matthew.a...@intel.com> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 01/24] drm/i915/kbl: Init gen9 workarounds

2016-06-01 Thread Matthew Auld
Reviewed-by: Matthew Auld <matthew.a...@intel.com> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 06/24] drm/i915/kbl: Add WaEnableGapsTsvCreditFix

2016-06-01 Thread Matthew Auld
Reviewed-by: Matthew Auld <matthew.a...@intel.com> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 02/24] drm/i915/kbl: Add REVID macro

2016-06-01 Thread Matthew Auld
Reviewed-by: Matthew Auld <matthew.a...@intel.com> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 03/24] drm/i915/kbl: Add WaSkipStolenMemoryFirstPage for A0

2016-06-01 Thread Matthew Auld
Reviewed-by: Matthew Auld <matthew.a...@intel.com> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 04/24] drm/i915/gen9: Always apply WaForceContextSaveRestoreNonCoherent

2016-06-01 Thread Matthew Auld
Reviewed-by: Matthew Auld <matthew.a...@intel.com> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 05/24] drm/i915: Mimic skl with WaForceEnableNonCoherent

2016-06-01 Thread Matthew Auld
s/tho/though/ s/regarless/regardless/ Seems reasonable so: Reviewed-by: Matthew Auld <matthew.a...@intel.com> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] drm: fix send_vblank_event use-after-free error

2016-06-20 Thread Matthew Auld
] SyS_ioctl+0x79/0x90 [ 378.438967] entry_SYSCALL_64_fastpath+0x1a/0xa4 Cc: dri-de...@lists.freedesktop.org Cc: Daniel Vetter <daniel.vet...@intel.com> Signed-off-by: Matthew Auld <matthew.a...@intel.com> --- drivers/gpu/drm/drm_irq.c | 4 ++-- 1 file changed, 2 insertions(+),

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Use atomic commits for legacy page_flips

2016-06-20 Thread Matthew Auld
I seem to be hitting some issues with this, at least in gnome-shell which I bisected to this commit. Somewhat hard to describe but the background window or desktop is partiality and intermittently drawn, almost like a flicker onto the foreground window, title-bar etc. typically during any kind of

[Intel-gfx] [PATCH] drm/i915: fix out-of-bounds page_table access

2016-06-24 Thread Matthew Auld
.uk> Signed-off-by: Matthew Auld <matthew.a...@intel.com> --- drivers/gpu/drm/i915/i915_gem_gtt.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.h b/drivers/gpu/drm/i915/i915_gem_gtt.h index 163b564..9e5228d 100644 --- a/drivers/

Re: [Intel-gfx] [PATCH] drm/i915/gen9: Add WaDisableGatherAtSetShaderCommonSlice

2016-06-28 Thread Matthew Auld
Reviewed-by: Matthew Auld <matthew.a...@intel.com> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: tweak gen6_for_{each_pde, all_pdes} macros

2016-06-25 Thread Matthew Auld
lgtm Reviewed-by: Matthew Auld <matthew.a...@intel.com> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] drm/i915: add sanity check for partial view creation

2016-02-29 Thread Matthew Auld
When binding pages for a partial view we should check that the offset + size is valid relative to the size of the gem object. Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Matthew Auld <matthew.a...@intel.com> --- drivers/gpu/drm/i915/i915_gem_gtt.c | 4

Re: [Intel-gfx] [PATCH] drm/i915: add sanity check for partial view creation

2016-03-09 Thread Matthew Auld
> If this concerns you that, please look at the API, and please review the outstanding patches. Could you elaborate on this please? What patches are you referring to? ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org

Re: [Intel-gfx] [PATCH i-g-t] igt/kms_rotation_crc: exercise invalid rotations

2016-03-10 Thread Matthew Auld
> Y tiled fb will be rejected for gen < 9, should use X/linear for those. Are you referring to the __gem_set_tiling call? Since this didn't fail on BDW and I don't see any logic in i915_gem_set_tiling which implements this. > Actually using X/linear for gen >= 9 would also be interesting to make

[Intel-gfx] [PATCH i-g-t 1/2] tests/kms_rotation_crc: exercise invalid rotations

2016-03-18 Thread Matthew Auld
nen <joonas.lahti...@linux.intel.com> Signed-off-by: Matthew Auld <matthew.a...@intel.com> --- tests/kms_rotation_crc.c | 80 1 file changed, 80 insertions(+) diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c index f94f8f1.

[Intel-gfx] [PATCH i-g-t] tests/kms_rotation_crc: exercise invalid rotations

2016-03-14 Thread Matthew Auld
igned-off-by: Matthew Auld <matthew.a...@intel.com> --- tests/kms_rotation_crc.c | 77 1 file changed, 77 insertions(+) diff --git a/tests/kms_rotation_crc.c b/tests/kms_rotation_crc.c index f94f8f1..fb3e2e8 100644 --- a/tests/kms_rotation_cr

[Intel-gfx] [PATCH] drm/i915: unify partial/normal page insertion loops

2016-03-15 Thread Matthew Auld
Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Matthew Auld <matthew.a...@intel.com> --- drivers/gpu/drm/i915/i915_gem.c | 40 1 file changed, 16 insertions(+), 24 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem

[Intel-gfx] [PATCH] drm/i915: simplify bind_to_vm init code

2016-03-19 Thread Matthew Auld
No functional change, just makes the code easier to follow. Signed-off-by: Matthew Auld <matthew.a...@intel.com> --- drivers/gpu/drm/i915/i915_gem.c | 41 +++-- 1 file changed, 11 insertions(+), 30 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_g

[Intel-gfx] [PATCH] drm/i915: simplify bind_to_vm init code

2016-03-19 Thread Matthew Auld
-by: Matthew Auld <matthew.a...@intel.com> --- drivers/gpu/drm/i915/i915_gem.c | 52 +++-- 1 file changed, 13 insertions(+), 39 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index f45856d..ffb802e 100644 --- a/drivers/g

Re: [Intel-gfx] [PATCH] drm/i915: simplify bind_to_vm init code

2016-03-19 Thread Matthew Auld
Hi, If we don't do any of the fence business for !i915_is_gtt, then will this not change the following code: if (alignment == 0) alignment = flags & PIN_MAPPABLE ? fence_alignment : unfenced_alignment; Or am I missing something? Regards, Matt ___

[Intel-gfx] [PATCH i-g-t] igt/kms_rotation_crc: exercise invalid rotations

2016-03-09 Thread Matthew Auld
Add expect-to-fail tests for invalid rotations on each of the plane types. Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Matthew Auld <matthew.a...@intel.com> --- tests/kms_rotation_crc.c | 96 1 file changed, 9

[Intel-gfx] [RFC PATCH] drm/i915: s/i915_gem_obj_to_ggtt_view/i915_ggtt_view_to_vma/

2016-03-31 Thread Matthew Auld
This seems to be more in-line with what the function actually does, this also makes it more consistent with i915_gem_obj_to_vma. Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Cc: Chris Wilson <ch...@chris-wilson.co.uk> Signed-off-by: Matthew Auld <matthew.a...@intel.com>

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Avoid allocating a vmap arena for a single page

2016-04-05 Thread Matthew Auld
I use :autocmd FileType gitcommit setlocal spell ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Don't program eLLC IDI hash mask for gen9+

2016-04-13 Thread Matthew Auld
Seems to be in-line with the spec, so with Chris' comment addressed and s/idi has mask/idi hash mask/: Reviewed-by: Matthew Auld <matthew.a...@intel.com> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/m

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Calculate edram size

2016-04-13 Thread Matthew Auld
Looks good, so with s/INTEL_INFO/INTEL_GEN/: Reviewed-by: Matthew Auld <matthew.a...@intel.com> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 4/6] drm/i915: handle potential overflow

2016-04-08 Thread Matthew Auld
Much like with the equivalent gen8_alloc_va_range. Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Matthew Auld <matthew.a...@intel.com> --- drivers/gpu/drm/i915/i915_gem_gtt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/

[Intel-gfx] [PATCH 5/6] drm/i915: bail in alloc_pdp when !FULL_48BIT_PPGTT

2016-04-08 Thread Matthew Auld
If we are not in FULL_48BIT_PPGTT mode then we really shouldn't continue on with our allocations, given that the call to free_dpd would bail early without freeing everything, thus leaking memory. Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Matthew Auld <

[Intel-gfx] [PATCH 3/6] drm/i915: combine overflow checks

2016-04-08 Thread Matthew Auld
Looks a little neater and ever so slightly reduces the size of the binary. Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Matthew Auld <matthew.a...@intel.com> --- drivers/gpu/drm/i915/i915_gem_gtt.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-)

[Intel-gfx] [PATCH 6/6] drm/i915: call kunmap_px on pt_vaddr

2016-04-08 Thread Matthew Auld
We need to kunmap pt_vadrr and not pt itself, otherwise we end up mapping a bunch of pages without ever unmapping them. Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Matthew Auld <matthew.a...@intel.com> --- drivers/gpu/drm/i915/i915_gem_gtt.c | 2 +- 1 fil

[Intel-gfx] [PATCH 2/6] drm/i915: reference ppgtt->base.dev directly

2016-04-08 Thread Matthew Auld
Remove dev local and use to_i915() in gen8_ppgtt_notify_vgt. Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Matthew Auld <matthew.a...@intel.com> --- drivers/gpu/drm/i915/i915_gem_gtt.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/dri

[Intel-gfx] [PATCH 1/6] drm/i915: remove IS_ERR_OR_NULL check

2016-04-08 Thread Matthew Auld
A call to i915_gem_alloc_object can only ever return NULL in the event of an error. Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Matthew Auld <matthew.a...@intel.com> --- drivers/gpu/drm/i915/i915_gem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [Intel-gfx] [PATCH] fix bug in function gen8_ppgtt_clear_range, passed wrong ptr to kunmap_px.

2016-04-09 Thread Matthew Auld
There's already a patch in the works for this: https://patchwork.freedesktop.org/patch/80078/ Regards, Matt ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH 4/5] drm/i915: call kunmap_px on pt_vaddr

2016-04-12 Thread Matthew Auld
We need to kunmap pt_vaddr and not pt itself, otherwise we end up mapping a bunch of pages without ever unmapping them. Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Matthew Auld <matthew.a...@intel.com> --- dr

[Intel-gfx] [PATCH 1/5] drm/i915: use dev_priv directly in gen8_ppgtt_notify_vgt

2016-04-12 Thread Matthew Auld
Remove dev local and use to_i915() in gen8_ppgtt_notify_vgt. v2: use dev_priv directly for QUESTION_MACROS (Joonas Lahtinen) Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Matthew Auld <matthew.a...@intel.com> --- drivers/gpu/drm/i915/i915_gem_gtt.c | 5 +

[Intel-gfx] [PATCH 2/5] drm/i915: harden allocation paths in allocate_va_range

2016-04-12 Thread Matthew Auld
Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Matthew Auld <matthew.a...@intel.com> --- drivers/gpu/drm/i915/i915_gem_gtt.c | 17 - 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i

[Intel-gfx] [PATCH 3/5] drm/i915: bail in alloc_pdp when !FULL_48BIT_PPGTT

2016-04-12 Thread Matthew Auld
intel.com> Signed-off-by: Matthew Auld <matthew.a...@intel.com> --- drivers/gpu/drm/i915/i915_gem_gtt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c index fa583d5..6601b11 100644 --- a/dr

[Intel-gfx] [PATCH] drm/i915: simplify bind_to_vm init code

2016-03-19 Thread Matthew Auld
No functional change, just makes the code easier to follow. v2: - Remove local fence_size variable (Tvrtko Ursulin) - Remove redundant NULL ggtt_view check - Reuse size variable Signed-off-by: Matthew Auld <matthew.a...@intel.com> --- drivers/gpu/drm/i915/i915_gem.

Re: [Intel-gfx] [PATCH 15/21] drm/i915: Adjust obj tiling vs. fb modifier rules

2016-03-19 Thread Matthew Auld
s/requite/require s/presumaly/presumably s/disalling/disabling I think this makes sense so: Reviewed-by: Matthew Auld <matthew.a...@intel.com> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/li

[Intel-gfx] [PATCH] drm/i915: add sanity check for partial view creation

2016-03-19 Thread Matthew Auld
dle overflow - Less idiotic placement - Treat as programmer error Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Matthew Auld <matthew.a...@intel.com> --- drivers/gpu/drm/i915/i915_gem_gtt.c | 8 1 file changed, 8 insertions(+) diff --git a/drive

Re: [Intel-gfx] [PATCH 14/21] drm/i915: Use fb modifiers for display tiling decisions

2016-03-19 Thread Matthew Auld
Reviewed-by: Matthew Auld <matthew.a...@intel.com> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] drm/i915: Fix plane init failure paths

2016-03-21 Thread Matthew Auld
ameter v3: Another rebase due to s/""/NULL/ v4: Rebased on drm-nightly (Matthew Auld) v5: Fix email address (Matthew Auld) Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com> Reviewed-by: Matthew Auld <matthew.a...@intel.com> --- drivers/gpu/d

Re: [Intel-gfx] [PATCH] drm/i915: simplify bind_to_vm init code

2016-03-22 Thread Matthew Auld
Hi Chris, Are the changes acceptable? Regards, Matt ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] drm/i915: Reject non-canonical rotations

2016-03-22 Thread Matthew Auld
Reject any rotation value which incorrectly represents multiple rotations. Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Matthew Auld <matthew.a...@intel.com> --- drivers/gpu/drm/i915/intel_atomic_plane.c | 5 + 1 file changed, 5 insertions(+) diff --git a

[Intel-gfx] [PATCH] drm/i915: BUG_ON when ggtt_view is NULL

2016-03-24 Thread Matthew Auld
hti...@linux.intel.com> Cc: Tvrtko Ursulin <tvrtko.ursu...@linux.intel.com> Signed-off-by: Matthew Auld <matthew.a...@intel.com> --- drivers/gpu/drm/i915/i915_gem.c | 9 ++--- drivers/gpu/drm/i915/i915_gem_gtt.c | 10 +- 2 files changed, 3 insertions(+), 16 deletions(-) diff -

[Intel-gfx] [PATCH] drm/i915: check for drm_universal_plane_init error

2016-03-21 Thread Matthew Auld
Signed-off-by: Matthew Auld <matthew.a...@intel.com> --- drivers/gpu/drm/i915/intel_display.c | 32 +--- 1 file changed, 21 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 74b0165..b

[Intel-gfx] [PATCH] drm/i915: Fix plane init failure paths

2016-03-21 Thread Matthew Auld
/""/NULL/ v4: Rebased on drm-nightly (Matthew Auld) Signed-off-by: Ville Syrjälä Reviewed-by: Matthew Auld <matthew.a...@intel.com> --- drivers/gpu/drm/i915/intel_display.c | 64 ++-- drivers/gpu/drm/i915/intel_sprite.c | 34 +++ 2 f

Re: [Intel-gfx] [PATCH] drm/i915: Reject non-canonical rotations

2016-03-22 Thread Matthew Auld
Hi Daniel, >> I thought we do normalize this somewhere. I did write an i-g-t test which submits such a rotation value and it is not rejected. >> Your patch lacks motivation As in I haven't properly conveyed the motivation behind the patch in the commit message? >> Yes I can usually guess when

[Intel-gfx] [PATCH] drm/i915: check vma for error in ggtt_unpin_view

2016-03-23 Thread Matthew Auld
When unpinning a ggtt_view check vma for error, otherwise we may end up accessing an invalid pointer. Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Matthew Auld <matthew.a...@intel.com> --- drivers/gpu/drm/i915/i915_gem.c | 2 +- 1 file changed, 1 insertion(+)

[Intel-gfx] [PATCH] drm/i915: clean up aliasing_gtt_bind_vma

2016-03-23 Thread Matthew Auld
No point in initialising pages with obj->pages, only to overwrite it with ggtt_view.pages later. So lets just get rid of pages altogether. Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Matthew Auld <matthew.a...@intel.com> --- drivers/gpu/drm/i915/i915

Re: [Intel-gfx] [PATCH] drm/i915: Reject non-canonical rotations

2016-03-23 Thread Matthew Auld
Okay, I'll rework the patch to use drm_rotation_simplify instead. ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH i-g-t v7] lib/igt_kms: Add COMMIT_ATOMIC to igt_display_commit2()

2016-03-08 Thread Matthew Auld
I think it would be more idiomatic to replace: + for (i = 0; i < display->n_outputs; i++) { + igt_output_t *output = >outputs[i]; with: + for_each_connected_output(display, output) And: + for (i = 0; i < pipe->n_planes; i++) { + igt_plane_t *plane = >planes[i];

[Intel-gfx] [PATCH] drm/i915: add sanity check for partial view creation

2016-03-04 Thread Matthew Auld
el.com> Signed-off-by: Matthew Auld <matthew.a...@intel.com> --- drivers/gpu/drm/i915/i915_gem_gtt.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c index 7b8de85..596692b 100644 --- a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH] drm/i915: add sanity check for partial view creation

2016-03-02 Thread Matthew Auld
When binding pages for a partial view we should check that the offset + size is valid relative to the size of the gem object. v2: Don't use pages->nents to determine the page count (Tvrtko Ursulin) Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Matthew Auld &

Re: [Intel-gfx] [PATCH i-g-t] tools/intel_reg: Fix builtin register spec for gen4

2016-04-05 Thread Matthew Auld
Reviewed-by: Matthew Auld <matthew.a...@intel.com> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH i-g-t 2/2] tests/kms_rotation_crc: add 90/270 X-tiled tests

2016-03-19 Thread Matthew Auld
As suggested by Ville Syrjälä, add expect-to-fail tests for X-tiled 90/270 rotations on gen >= 9 Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Matthew Auld <matthew.a...@intel.com> --- tests/kms_rotation_crc.c | 54 +

[Intel-gfx] [PATCH] drm/i915: Propagate error from drm_gem_object_init()

2016-04-22 Thread Matthew Auld
From: Chris Wilson <ch...@chris-wilson.co.uk> Propagate the real error from drm_gem_object_init(). Note this also fixes some confusion in the error return from i915_gem_alloc_object... v2: (Matthew Auld) - updated new users of gem_alloc_object from latest drm-nightly - replaced occur

[Intel-gfx] [PATCH] drm/i915: use dev_priv directly in gen8_ppgtt_notify_vgt

2016-04-22 Thread Matthew Auld
Remove dev local and use to_i915() in gen8_ppgtt_notify_vgt. v2: use dev_priv directly for QUESTION_MACROS (Joonas Lahtinen) Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Matthew Auld <matthew.a...@intel.com> Reviewed-by: Joonas Lahtinen <joonas.lahti...@

[Intel-gfx] [PATCH 2/3] drm/i915: bail in alloc_pdp when !FULL_48BIT_PPGTT

2016-04-22 Thread Matthew Auld
.uk> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Matthew Auld <matthew.a...@intel.com> --- drivers/gpu/drm/i915/i915_gem_gtt.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/dr

[Intel-gfx] [PATCH] drm/i915: remove i915_gem_object_ggtt_unbind

2016-04-28 Thread Matthew Auld
Only has one user and is nothing more than a shim on top of i915_vma_unbind, so let's just get rid of it. Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Suggested-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Matthew Auld <matthew.a...@intel.com> --

[Intel-gfx] [PATCH] drm/i915: tidy up gen8_init_scratch

2016-04-26 Thread Matthew Auld
Use goto teardown path and also ensure we reset any struct members which would otherwise contain an error encoded pointer, and could be mistaken for a valid address. Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Matthew Auld <matthew.a...@intel.com> --- dri

[Intel-gfx] [PATCH] drm/i915: bail in alloc_pdp when !FULL_48BIT_PPGTT

2016-04-26 Thread Matthew Auld
appropriate goto label name Cc: Chris Wilson <ch...@chris-wilson.co.uk> Cc: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Matthew Auld <matthew.a...@intel.com> Reviewed-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com> --- drivers/gpu/drm/i915/i915_gem_gtt

[Intel-gfx] [PATCH 1/2] drm/i915: Support per-PPGTT address space mode

2016-04-26 Thread Matthew Auld
ble manipulation routines / LRC context population routines read the address space mode from it instead of the system configuration. v2: (Matthew Auld) - rebase on latest -nightly - prefer i915_vm_to_ppgtt instead of container_of - initialise address_space_mode _before_ we attempt to init sc

[Intel-gfx] [PATCH 2/2] drm/i915: generate address mode bit from PPGTT instance

2016-04-26 Thread Matthew Auld
From: "Wang, Zhi A" <zhi.a.w...@intel.com> After the per-PPGTT address mode gets support, the LRC submission should generate the address mode bit from PPGTT instance, instead of the hard-coded system configuration. v2: (Matthew Auld) - rebase on latest -nightly Cc: Chris Wil

[Intel-gfx] [PATCH] drm/i915: In render_state_init reset obj in teardown path

2016-04-26 Thread Matthew Auld
The teardown path in render_state_init leaves so->obj != NULL. Suggested-by: Joonas Lahtinen <joonas.lahti...@linux.intel.com> Signed-off-by: Matthew Auld <matthew.a...@intel.com> --- drivers/gpu/drm/i915/i915_gem_render_state.c | 1 + 1 file changed, 1 insertion(+) diff --git a/

[Intel-gfx] [PATCH] drm/i915: tidy up gen8_init_scratch

2016-04-27 Thread Matthew Auld
com> Signed-off-by: Matthew Auld <matthew.a...@intel.com> --- drivers/gpu/drm/i915/i915_gem_gtt.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c index 0d666b3..87947ec 1006

Re: [Intel-gfx] [PATCH v2 06/10] drm/i915: Enable i915 perf stream for Haswell OA unit

2016-04-29 Thread Matthew Auld
> + bo = i915_gem_object_create(dev_priv->dev, OA_BUFFER_SIZE); > + if (bo == NULL) { IS_ERR() ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] drm/i915: Propagate error from drm_gem_object_init()

2016-04-25 Thread Matthew Auld
From: Chris Wilson <ch...@chris-wilson.co.uk> Propagate the real error from drm_gem_object_init(). Note this also fixes some confusion in the error return from i915_gem_alloc_object... v2: (Matthew Auld) - updated new users of gem_alloc_object from latest drm-nightly - replaced occur

[Intel-gfx] [PATCH] drm: use seqlock for vblank time/count

2016-05-11 Thread Matthew Auld
tel.com> Signed-off-by: Matthew Auld <matthew.a...@intel.com> --- drivers/gpu/drm/drm_irq.c | 90 +++ include/drm/drmP.h| 14 +++- 2 files changed, 17 insertions(+), 87 deletions(-) diff --git a/drivers/gpu/drm/drm_irq.c b/drivers

Re: [Intel-gfx] [PATCH] drm: use seqlocks for vblank time/count

2016-05-18 Thread Matthew Auld
There's an updated version of this patch already on the ml [1], which I Cc'd you in on. I take it that your @tuebingen.mpg.de is in fact an old email address? [1] https://patchwork.freedesktop.org/patch/86354/ ___ Intel-gfx mailing list

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: remove i915_gem_object_ggtt_unbind

2016-05-03 Thread Matthew Auld
> Test drv_module_reload_basic: > pass -> INCOMPLETE (skl-nuci5) Machine seems to have hanged after reloading module, couldn't possibly be related to this patch. Will create new bug report... > Test gem_exec_create: > Subgroup basic: > pass ->

Re: [Intel-gfx] [PATCH 03/12] drm/i915: Move SKL hw stride calculation into a helper

2016-05-04 Thread Matthew Auld
Reviewed-by: Matthew Auld <matthew.a...@intel.com> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH] drm/i915: Unexport i915_ppgtt_init()

2016-05-05 Thread Matthew Auld
Reviewed-by: Matthew Auld <matthew.a...@intel.com> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] drm: use seqlock for vblank time/count

2016-05-10 Thread Matthew Auld
: - reduce the scope of the seqlock, keeping vblank_time_lock - make the seqlock per vblank_crtc, so multiple readers aren't blocked by the writer Cc: Daniel Vetter <daniel.vet...@ffwll.ch> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Signed-off-by: Matthew Auld <matthew

[Intel-gfx] [PATCH] drm: use seqlocks for vblank time/count

2016-05-09 Thread Matthew Auld
: Daniel Vetter <daniel.vet...@ffwll.ch> Cc: Ville Syrjälä <ville.syrj...@linux.intel.com> Signed-off-by: Matthew Auld <matthew.a...@intel.com> --- drivers/gpu/drm/drm_irq.c | 111 +- include/drm/drmP.h| 14 ++ 2 files chan

Re: [Intel-gfx] ✗ Ro.CI.BAT: failure for drm/i915: remove superfluous i915_gem_object_free_mmap_offset call

2016-07-14 Thread Matthew Auld
On 5 July 2016 at 14:21, Patchwork wrote: > == Series Details == > > Series: drm/i915: remove superfluous i915_gem_object_free_mmap_offset call > URL : https://patchwork.freedesktop.org/series/9516/ > State : failure > > == Summary == > > Series 9516v1

Re: [Intel-gfx] ✗ Ro.CI.BAT: failure for drm/i915: remove redundant fbc warnings

2016-08-02 Thread Matthew Auld
> Test gem_exec_flush: > Subgroup basic-batch-kernel-default-cmd: > pass -> FAIL (ro-byt-n2820) https://bugs.freedesktop.org/show_bug.cgi?id=95372 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org

Re: [Intel-gfx] [PATCH] drm/i915/kbl: Limit WaDisableDynamicCreditSharing to A0

2016-08-11 Thread Matthew Auld
But in the bug report the pciid=0x5916 and rev=0x0, which makes it KBL A0, right? So something else must be going on here. There also seems to be a mismatch between #2226938, #2225763 and #2225601 in terms of what the wa should be, some make reference to bit[30].

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Initialize return value for empty i915_gem_object_unbind()

2016-08-14 Thread Matthew Auld
Reviewed-by: Matthew Auld <matthew.a...@intel.com> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Unbind closed vma for i915_gem_object_unbind()

2016-08-14 Thread Matthew Auld
Reviewed-by: Matthew Auld <matthew.a...@intel.com> Tested-by: Matthew Auld <matthew.a...@intel.com> ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

  1   2   3   4   5   6   7   8   9   10   >