Re: [Intel-gfx] [PATCH 4/7] drm/i915: PSR VLV: Add single frame update.

2015-03-04 Thread Pandiyan, Dhinakaran
5:26 PM To: intel-gfx@lists.freedesktop.org Cc: Vivi, Rodrigo; Pandiyan, Dhinakaran Subject: [PATCH 4/7] drm/i915: PSR VLV: Add single frame update. According to spec: In PSR HW or SW mode, SW set this bit before writing registers for a flip. It will be self-clear when it gets to the PSR active

Re: [Intel-gfx] [PATCH 3/3] drm/i915/psr: Do not activate PSR when vblank interrupts are enabled

2016-06-14 Thread Pandiyan, Dhinakaran
On Tue, 2016-06-14 at 00:09 +, Vivi, Rodrigo wrote: > On Wed, 2016-06-08 at 18:46 -0700, Dhinakaran Pandiyan wrote: > > PSR in CHV, unlike HSW, can get activated even if vblanks interrupts > > are > > enabled. But, the pipe is not expected to generate timings signals > > when PSR is active.

Re: [Intel-gfx] [PATCH 3/3] drm/i915/psr: Do not activate PSR when vblank interrupts are enabled

2016-06-24 Thread Pandiyan, Dhinakaran
On Wed, 2016-06-15 at 21:44 +, Vivi, Rodrigo wrote: > On Wed, 2016-06-15 at 01:02 +0000, Pandiyan, Dhinakaran wrote: > > On Tue, 2016-06-14 at 00:09 +, Vivi, Rodrigo wrote: > > > On Wed, 2016-06-08 at 18:46 -0700, Dhinakaran Pandiyan wrote: > > > > PSR in CHV,

Re: [Intel-gfx] [PATCH 1/2] pciids: Add more Kabylake PCI IDs.

2016-06-24 Thread Pandiyan, Dhinakaran
On Thu, 2016-06-23 at 14:50 -0700, Rodrigo Vivi wrote: > The spec has been updated adding new PCI IDs. > > Signed-off-by: Rodrigo Vivi > --- > src/i915_pciids.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/i915_pciids.h b/src/i915_pciids.h > index

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Add more Kabylake PCI IDs.

2016-06-24 Thread Pandiyan, Dhinakaran
On Thu, 2016-06-23 at 14:50 -0700, Rodrigo Vivi wrote: > The spec has been updated adding new PCI IDs. > > Signed-off-by: Rodrigo Vivi > --- > include/drm/i915_pciids.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/drm/i915_pciids.h

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Add more Kabylake PCI IDs.

2016-06-24 Thread Pandiyan, Dhinakaran
On Fri, 2016-06-24 at 22:06 +, Pandiyan, Dhinakaran wrote: > On Thu, 2016-06-23 at 14:50 -0700, Rodrigo Vivi wrote: > > The spec has been updated adding new PCI IDs. > > > > Signed-off-by: Rodrigo Vivi <rodrigo.v...@intel.com> > > --- > > include/drm/i9

Re: [Intel-gfx] [PATCH 1/2] pciids: Add more Kabylake PCI IDs.

2016-06-24 Thread Pandiyan, Dhinakaran
On Fri, 2016-06-24 at 15:20 -0700, Dhinakaran Pandiyan wrote: > On Thu, 2016-06-23 at 14:50 -0700, Rodrigo Vivi wrote: > > The spec has been updated adding new PCI IDs. > > > > Signed-off-by: Rodrigo Vivi > > --- > > src/i915_pciids.h | 3 +++ > > 1 file changed, 3

Re: [Intel-gfx] [PATCH 1/2] intel: Add more Kabylake PCI IDs.

2016-06-24 Thread Pandiyan, Dhinakaran
On Thu, 2016-06-23 at 14:50 -0700, Rodrigo Vivi wrote: > The spec has been updated adding new PCI IDs. > > Signed-off-by: Rodrigo Vivi > --- > intel/intel_chipset.h | 14 ++ > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git

Re: [Intel-gfx] [PATCH] drm/i915: Treat cursor plane as another sprite plane for BSW

2016-03-03 Thread Pandiyan, Dhinakaran
ut another version addressing the comments along with the revert. From: Ville Syrjälä [ville.syrj...@linux.intel.com] Sent: Wednesday, March 02, 2016 6:03 AM To: Pandiyan, Dhinakaran Cc: intel-gfx@lists.freedesktop.org; Kondapally, Kalyan Subject: Re: [Intel-g

Re: [Intel-gfx] [PATCH 2/3] drm/dp/i915: Clean up clock configuration for HDMI audio

2016-08-11 Thread Pandiyan, Dhinakaran
On Thu, 2016-08-11 at 10:52 +0300, Jani Nikula wrote: > On Thu, 11 Aug 2016, Dhinakaran Pandiyan > wrote: > > No functional change, just clean up. Debug messages now print out clock > > units. Additionally, the configuration bits, which are 1:1 mapped to the > >

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Eliminate redundant local variable definition

2016-08-11 Thread Pandiyan, Dhinakaran
On Thu, 2016-08-11 at 08:09 +0100, Chris Wilson wrote: > On Wed, Aug 10, 2016 at 11:41:13PM -0700, Dhinakaran Pandiyan wrote: > > No functional change, just clean up. > > > > Signed-off-by: Dhinakaran Pandiyan > Reviewed-by: Chris Wilson

Re: [Intel-gfx] [PATCH v2] drm/i915: intel_dp_link_is_valid() should only return status of link

2016-08-11 Thread Pandiyan, Dhinakaran
On Thu, 2016-08-11 at 15:23 -0700, Manasi Navare wrote: > Intel_dp_link_is_valid() function reads the Link status registers > and returns a boolean to indicate link is valid or not. > If the link has lost lock and is not valid any more, link > training is performed outside the function else

Re: [Intel-gfx] [PATCH 1/2] A Helper function that returns available link bandwidth

2016-08-11 Thread Pandiyan, Dhinakaran
On Thu, 2016-08-11 at 16:41 -0700, Anusha Srivatsa wrote: > drm/dp/mst > > Signed-off-by: Anusha Srivatsa > > Add a function that returns the available link bandwidth for > MST port so that we can accurately determine whether a new > mode is valid for the link or not.

Re: [Intel-gfx] [PATCH 2/2] Validate modes against available link bandwidth

2016-08-11 Thread Pandiyan, Dhinakaran
On Thu, 2016-08-11 at 16:41 -0700, Anusha Srivatsa wrote: > drm/dp/mst/i915 > > Signed-off-by: Anusha Srivatsa > > Validate the modes against available link bandwidth rather than > maximum link bandwidth so that we have a better idea as to whether > a proposed mode

Re: [Intel-gfx] [PATCH v2] drm/i915/dp: DP audio API changes for MST

2016-08-10 Thread Pandiyan, Dhinakaran
On Wed, 2016-08-10 at 17:21 +0300, Ville Syrjälä wrote: > On Tue, Aug 09, 2016 at 01:58:33PM -0700, Dhinakaran Pandiyan wrote: > > DP MST provides the capability to send multiple video and audio streams > > through a single port. This requires the API's between i915 and audio > > drivers to

Re: [Intel-gfx] [PATCH] drm/i915: Fix braces in conditonal branches

2016-08-09 Thread Pandiyan, Dhinakaran
On Tue, 2016-08-09 at 23:08 +0100, Chris Wilson wrote: > On Tue, Aug 09, 2016 at 03:06:10PM -0700, Dhinakaran Pandiyan wrote: > > No functional change, just adding braces to all branches of conditional > > statement because one of them already had. > > --- > > drivers/gpu/drm/i915/intel_audio.c |

Re: [Intel-gfx] [PATCH] drm/i915/dp: DP audio API changes for MST

2016-08-03 Thread Pandiyan, Dhinakaran
On Wed, 2016-08-03 at 15:53 +0200, Takashi Iwai wrote: > On Wed, 03 Aug 2016 04:14:30 +0200, > Dhinakaran Pandiyan wrote: > > > > DP MST provides the capability to send multiple video and audio streams via > > one single port. This requires the API's between i915 and audio drivers to > >

Re: [Intel-gfx] [PATCH] drm/i915/dp: DP audio API changes for MST

2016-08-03 Thread Pandiyan, Dhinakaran
On Wed, 2016-08-03 at 22:08 +0300, Ville Syrjälä wrote: > On Tue, Aug 02, 2016 at 07:14:30PM -0700, Dhinakaran Pandiyan wrote: > > DP MST provides the capability to send multiple video and audio streams via > > one single port. This requires the API's between i915 and audio drivers to > >

Re: [Intel-gfx] [PATCH] drm/i915/dp: DP audio API changes for MST

2016-08-04 Thread Pandiyan, Dhinakaran
On Thu, 2016-08-04 at 15:49 +0300, Ville Syrjälä wrote: > On Wed, Aug 03, 2016 at 09:42:53PM +0000, Pandiyan, Dhinakaran wrote: > > On Wed, 2016-08-03 at 23:28 +0300, Ville Syrjälä wrote: > > > On Wed, Aug 03, 2016 at 07:43:06PM +, Pandiyan, Dhinakaran wrote: > > >

Re: [Intel-gfx] [PATCH v3] drm/i915/dp: DP audio API changes for MST

2016-08-12 Thread Pandiyan, Dhinakaran
On Fri, 2016-08-12 at 08:18 +0300, Ville Syrjälä wrote: > On Fri, Aug 12, 2016 at 04:28:09AM +0000, Pandiyan, Dhinakaran wrote: > > On Thu, 2016-08-11 at 10:39 +0300, Ville Syrjälä wrote: > > > On Thu, Aug 11, 2016 at 07:10:39AM +, Pandiyan, Dhinakaran wrote: > > >

Re: [Intel-gfx] [PATCH v2] drm/i915: intel_dp_link_is_valid() should only return status of link

2016-08-12 Thread Pandiyan, Dhinakaran
On Fri, 2016-08-12 at 10:56 -0700, Manasi Navare wrote: > On Thu, Aug 11, 2016 at 08:18:54PM -0700, Pandiyan, Dhinakaran wrote: > > On Thu, 2016-08-11 at 15:23 -0700, Manasi Navare wrote: > > > Intel_dp_link_is_valid() function reads the Link status registers > >

Re: [Intel-gfx] [PATCH v3] drm/i915/dp: DP audio API changes for MST

2016-08-12 Thread Pandiyan, Dhinakaran
On Sat, 2016-08-13 at 00:16 +, Pandiyan, Dhinakaran wrote: > On Fri, 2016-08-12 at 08:18 +0300, Ville Syrjälä wrote: > > On Fri, Aug 12, 2016 at 04:28:09AM +, Pandiyan, Dhinakaran wrote: > > > On Thu, 2016-08-11 at 10:39 +0300, Ville Syrjälä wrote: > > > >

Re: [Intel-gfx] drm/i915/fbc: disable FBC on FIFO underruns

2016-08-12 Thread Pandiyan, Dhinakaran
On Fri, 2016-06-10 at 22:18 -0300, Paulo Zanoni wrote: > Ever since I started working on FBC I was already aware that FBC can > really amplify the FIFO underrun symptoms. On systems where FIFO > underruns were harmless error messages, enabling FBC would cause the > underruns to give black screens.

Re: [Intel-gfx] [PATCH v3] drm/i915/dp: DP audio API changes for MST

2016-08-11 Thread Pandiyan, Dhinakaran
On Thu, 2016-08-11 at 09:26 +0300, Ville Syrjälä wrote: > On Wed, Aug 10, 2016 at 12:41:57PM -0700, Dhinakaran Pandiyan wrote: > > DP MST provides the capability to send multiple video and audio streams > > through a single port. This requires the API's between i915 and audio > > drivers to

Re: [Intel-gfx] [PATCH v3] drm/i915/dp: DP audio API changes for MST

2016-08-11 Thread Pandiyan, Dhinakaran
On Thu, 2016-08-11 at 10:39 +0300, Ville Syrjälä wrote: > On Thu, Aug 11, 2016 at 07:10:39AM +0000, Pandiyan, Dhinakaran wrote: > > On Thu, 2016-08-11 at 09:26 +0300, Ville Syrjälä wrote: > > > On Wed, Aug 10, 2016 at 12:41:57PM -0700, Dhinakaran Pandiyan wrote: >

Re: [Intel-gfx] [PATCH i-g-t 2/2] lib/intel_chipset: Removing PCI IDs that are no longer listed as Kabylake.

2016-06-28 Thread Pandiyan, Dhinakaran
On Mon, 2016-06-27 at 17:11 -0700, Rodrigo Vivi wrote: > This is unusual. Usually IDs listed on early stages of platform > definition are kept there as reserved for later use. > > However these IDs here are not listed anymore in any of steppings > and devices IDs tables for Kabylake on

Re: [Intel-gfx] [PATCH i-g-t 1/2] lib/intel_chipset: Add more Kabylake PCI IDs.

2016-06-28 Thread Pandiyan, Dhinakaran
On Mon, 2016-06-27 at 17:11 -0700, Rodrigo Vivi wrote: > The spec has been updated adding new PCI IDs. > > v2: Avoid using "H" instead of HALO to keep names uniform - DK. > > Cc: Dhinakaran Pandiyan > Signed-off-by: Rodrigo Vivi > --- >

Re: [Intel-gfx] [PATCH 2/2] intel: Removing PCI IDs that are no longer listed as Kabylake.

2016-06-28 Thread Pandiyan, Dhinakaran
On Mon, 2016-06-27 at 17:10 -0700, Rodrigo Vivi wrote: > This is unusual. Usually IDs listed on early stages of platform > definition are kept there as reserved for later use. > > However these IDs here are not listed anymore in any of steppings > and devices IDs tables for Kabylake on

Re: [Intel-gfx] [PATCH 1/2] intel: Add more Kabylake PCI IDs.

2016-06-28 Thread Pandiyan, Dhinakaran
On Mon, 2016-06-27 at 17:10 -0700, Rodrigo Vivi wrote: > The spec has been updated adding new PCI IDs. > > v2: Avoid using "H" instead of HALO to keep names uniform - DK. > > Cc: Dhinakaran Pandiyan > Signed-off-by: Rodrigo Vivi > --- >

Re: [Intel-gfx] [PATCH 2/2] lib/intel_chipset: Removing PCI IDs that are no longer listed as Kabylake.

2016-06-28 Thread Pandiyan, Dhinakaran
On Thu, 2016-06-23 at 14:50 -0700, Rodrigo Vivi wrote: > This is unusual. Usually IDs listed on early stages of platform > definition are kept there as reserved for later use. > > However these IDs here are not listed anymore in any of steppings > and devices IDs tables for Kabylake on

Re: [Intel-gfx] [PATCH 2/2] pciids: : Removing PCI IDs that are no longer listed as Kabylake.

2016-06-28 Thread Pandiyan, Dhinakaran
On Thu, 2016-06-23 at 14:50 -0700, Rodrigo Vivi wrote: > This is unusual. Usually IDs listed on early stages of platform > definition are kept there as reserved for later use. > > However these IDs here are not listed anymore in any of steppings > and devices IDs tables for Kabylake on

Re: [Intel-gfx] [PATCH 1/2] i956: Add more Kabylake PCI IDs.

2016-06-28 Thread Pandiyan, Dhinakaran
On Thu, 2016-06-23 at 14:50 -0700, Rodrigo Vivi wrote: > The spec has been updated adding new PCI IDs. > > Signed-off-by: Rodrigo Vivi > --- > include/pci_ids/i965_pci_ids.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/include/pci_ids/i965_pci_ids.h

Re: [Intel-gfx] [PATCH 2/2] i965: Removing PCI IDs that are no longer listed as Kabylake.

2016-06-28 Thread Pandiyan, Dhinakaran
On Thu, 2016-06-23 at 14:50 -0700, Rodrigo Vivi wrote: > This is unusual. Usually IDs listed on early stages of platform > definition are kept there as reserved for later use. > > However these IDs here are not listed anymore in any of steppings > and devices IDs tables for Kabylake on

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Removing PCI IDs that are no longer listed as Kabylake.

2016-06-28 Thread Pandiyan, Dhinakaran
On Thu, 2016-06-23 at 14:50 -0700, Rodrigo Vivi wrote: > - INTEL_VGA_DEVICE(0x5932, info), /* DT GT4 */ \ > - INTEL_VGA_DEVICE(0x593B, info), /* Halo GT4 */ \ > - INTEL_VGA_DEVICE(0x593A, info), /* SRV GT4 */ \ > - INTEL_VGA_DEVICE(0x593D, info) /* WKS GT4 Reviewed-by:

Re: [Intel-gfx] [PATCH] drm/i915/dp: DP audio API changes for MST

2016-08-05 Thread Pandiyan, Dhinakaran
Iwai <ti...@suse.de> > > Cc: libin.y...@linux.intel.com; intel-gfx@lists.freedesktop.org; alsa- > > de...@alsa-project.org; Pandiyan, Dhinakaran > > <dhinakaran.pandi...@intel.com> > > Subject: Re: [Intel-gfx] [PATCH] drm/i915/dp: DP audio API changes for MST > > > >

Re: [Intel-gfx] [PATCH] drm/i915/dp: DP audio API changes for MST

2016-08-05 Thread Pandiyan, Dhinakaran
On Fri, 2016-08-05 at 06:21 +, Yang, Libin wrote: > > -Original Message- > > From: Pandiyan, Dhinakaran > > Sent: Friday, August 5, 2016 1:57 PM > > To: Yang, Libin <libin.y...@intel.com> > > Cc: intel-gfx@lists.freedesktop.org; ti...@suse.de; alsa-

Re: [Intel-gfx] [PATCH] drm/i915/dp: DP audio API changes for MST

2016-08-04 Thread Pandiyan, Dhinakaran
ists.freedesktop.org > > Cc: alsa-de...@alsa-project.org; ti...@suse.de; libin.y...@linux.intel.com; > > Pandiyan, Dhinakaran <dhinakaran.pandi...@intel.com> > > Subject: [Intel-gfx] [PATCH] drm/i915/dp: DP audio API changes for MST > > > > DP MST provides the cap

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915/dp: Dump DP link status when link training stages fail

2016-08-05 Thread Pandiyan, Dhinakaran
On Fri, 2016-08-05 at 10:35 +0100, Chris Wilson wrote: > On Thu, Aug 04, 2016 at 01:48:36PM -0700, Dhinakaran Pandiyan wrote: > > A full dump of link status can be handy in debugging link training > > failures. Let's add that to the debug messages when link training fails. > > > > v2: Removing

Re: [Intel-gfx] [PATCH 1/3] drm/i915: start adding dp mst audio

2016-08-05 Thread Pandiyan, Dhinakaran
Thanks Lyude. I realized that after sending the patches, will fix that. On Thu, 2016-08-04 at 19:42 -0400, Lyude wrote: > This should be added after patch #3, since that's the one that fixes > enc_to_mst(). Otherwise: > > Reviewed-by: Lyude > > On Tue, 2016-08-02 at 18:46

Re: [Intel-gfx] [PATCH] drm/i915: Add some curly braces

2016-08-05 Thread Pandiyan, Dhinakaran
On Fri, 2016-08-05 at 18:49 +0100, Chris Wilson wrote: > On Fri, Aug 05, 2016 at 08:41:34PM +0300, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > intel_enable_pipe() looks rather confusing when one side doesn't have > > the curly braces, and

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Fix enc_to_dig_port for MST encoders

2016-08-05 Thread Pandiyan, Dhinakaran
On Thu, 2016-08-04 at 19:51 -0400, Lyude wrote: > There was some discussion that happened on the original version of this > patch: > > https://patchwork.kernel.org/patch/8960831/ > > The general consensus was while this fixed the issue, it probably isn't > the way we want to fix it. It would be

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Fix the return value of pipe crc read function.

2016-08-05 Thread Pandiyan, Dhinakaran
On Wed, 2016-08-03 at 14:44 +, Vivi, Rodrigo wrote: > On Wed, 2016-08-03 at 10:31 +0300, Ville Syrjälä wrote: > > On Tue, Aug 02, 2016 at 09:42:07PM -0700, Rodrigo Vivi wrote: > > > > > > A read(fd, buf, len) function should return the number > > > of bytes read. In our case we need to return

Re: [Intel-gfx] [PATCH] drm/i915/dp: DP audio API changes for MST

2016-08-03 Thread Pandiyan, Dhinakaran
On Wed, 2016-08-03 at 23:28 +0300, Ville Syrjälä wrote: > On Wed, Aug 03, 2016 at 07:43:06PM +0000, Pandiyan, Dhinakaran wrote: > > On Wed, 2016-08-03 at 22:08 +0300, Ville Syrjälä wrote: > > > On Tue, Aug 02, 2016 at 07:14:30PM -0700, Dhinakaran Pandiyan wrote: >

Re: [Intel-gfx] [PATCH v2] drm/i915/dp: Switch to using the DRM function for reading DP link status

2016-08-17 Thread Pandiyan, Dhinakaran
Please ignore this, I am resubmitting this as an independent patch. -DK On Thu, 2016-08-11 at 13:49 -0700, Dhinakaran Pandiyan wrote: > Since a DRM function that reads link DP link status is available, let's > use that instead of the i915 clone. > > drm_dp_dpcd_read_link_status() returns a

Re: [Intel-gfx] [PATCH v1½ 03/13] drm/i915/dp: rename rate_to_index() to intel_dp_find_rate() and reuse

2017-02-01 Thread Pandiyan, Dhinakaran
On Thu, 2017-01-26 at 21:44 +0200, Jani Nikula wrote: > Rename the function, move it at the top, and reuse in > intel_dp_link_rate_index(). If there was a reason in the past to use > reverse search order here, there isn't now. > > Cc: Manasi Navare > Cc: Ville Syrjälä

Re: [Intel-gfx] [PATCH v1½ 07/13] drm/i915/dp: cache common rates with sink rates

2017-02-01 Thread Pandiyan, Dhinakaran
On Thu, 2017-01-26 at 21:44 +0200, Jani Nikula wrote: > Now that source rates are static and sink rates are updated whenever > DPCD is updated, we can do and cache the intersection of them whenever > sink rates are updated. This reduces code complexity, as we don't have > to keep calling the

Re: [Intel-gfx] [PATCH v1½ 03/13] drm/i915/dp: rename rate_to_index() to intel_dp_find_rate() and reuse

2017-02-07 Thread Pandiyan, Dhinakaran
On Thu, 2017-02-02 at 10:44 +0200, Jani Nikula wrote: > On Wed, 01 Feb 2017, "Pandiyan, Dhinakaran" <dhinakaran.pandi...@intel.com> > wrote: > > On Thu, 2017-01-26 at 21:44 +0200, Jani Nikula wrote: > >> Rename the function, move it at the top, and r

Re: [Intel-gfx] [PATCH v1½ 00/13] drm/i915/dp: link rate and lane count refactoring

2017-02-01 Thread Pandiyan, Dhinakaran
On Thu, 2017-01-26 at 21:44 +0200, Jani Nikula wrote: > This is kind of version 1½ of [1], basically just rebased on current git Looks like this version didn't make it into patchwork. -DK > (including Manasi's test automation patches) and a couple of more > cleanups slammed on top. > > BR, >

Re: [Intel-gfx] [PATCH 4/6] drm: scrambling support in drm layer

2017-02-01 Thread Pandiyan, Dhinakaran
On Wed, 2017-02-01 at 18:14 +0530, Shashank Sharma wrote: > HDMI 2.0 spec mandates scrambling for modes with pixel clock higher > than 340Mhz. This patch adds few new functions in drm layer for > core drivers to enable/disable scrambling. > > This patch adds: > - A function to detect scrambling

Re: [Intel-gfx] [PATCH v2 7/9] drm: Connector helper function to release atomic state

2017-01-30 Thread Pandiyan, Dhinakaran
On Wed, 2017-01-25 at 07:18 +0100, Daniel Vetter wrote: > On Tue, Jan 24, 2017 at 03:49:35PM -0800, Dhinakaran Pandiyan wrote: > > Having a ->atomic_release callback is useful to release shared resources > > that get allocated in compute_config(). > > > > Suggested-by: Daniel Vetter

Re: [Intel-gfx] [PATCH v2 4/9] drm: Add driver private objects to atomic state

2017-01-25 Thread Pandiyan, Dhinakaran
On Wed, 2017-01-25 at 06:59 +0100, Daniel Vetter wrote: > On Tue, Jan 24, 2017 at 03:49:32PM -0800, Dhinakaran Pandiyan wrote: > > It is necessary to track states for objects other than connector, crtc > > and plane for atomic modesets. But adding objects like DP MST link > > bandwidth to

Re: [Intel-gfx] [PATCH v2 8/9] drm/dp: Release DP MST shared link bandwidth

2017-01-25 Thread Pandiyan, Dhinakaran
On Wed, 2017-01-25 at 07:16 +0100, Daniel Vetter wrote: > On Tue, Jan 24, 2017 at 03:49:36PM -0800, Dhinakaran Pandiyan wrote: > > Implement the ->atomic_release() callback to release the shared link > > bandwidth that was originally acquired during compute_config() > > > > Signed-off-by:

Re: [Intel-gfx] [PATCH v2 9/9] drm/dp: Track MST link bandwidth

2017-01-25 Thread Pandiyan, Dhinakaran
On Wed, 2017-01-25 at 07:15 +0100, Daniel Vetter wrote: > On Tue, Jan 24, 2017 at 03:49:37PM -0800, Dhinakaran Pandiyan wrote: > > Use the added helpers to track MST link bandwidth for atomic modesets. > > Link bw is acquired in the ->atomic_check() phase when CRTCs are being > > enabled with

Re: [Intel-gfx] [PATCH v2 7/9] drm: Connector helper function to release atomic state

2017-01-25 Thread Pandiyan, Dhinakaran
On Wed, 2017-01-25 at 07:18 +0100, Daniel Vetter wrote: > On Tue, Jan 24, 2017 at 03:49:35PM -0800, Dhinakaran Pandiyan wrote: > > Having a ->atomic_release callback is useful to release shared resources > > that get allocated in compute_config(). > > > > Suggested-by: Daniel Vetter

Re: [Intel-gfx] [PATCH v2 3/9] drm/dp: Split drm_dp_mst_allocate_vcpi

2017-01-25 Thread Pandiyan, Dhinakaran
On Wed, 2017-01-25 at 10:31 +1000, Dave Airlie wrote: > On 25 January 2017 at 09:49, Dhinakaran Pandiyan > wrote: > > drm_dp_mst_allocate_vcpi() apart from setting up the vcpi structure, > > also finds if there are enough slots available. This check is a duplicate >

Re: [Intel-gfx] [PATCH v2 2/9] drm/dp: Kill unused MST vcpi slot availability tracking

2017-01-25 Thread Pandiyan, Dhinakaran
On Wed, 2017-01-25 at 06:43 +0100, Daniel Vetter wrote: > On Tue, Jan 24, 2017 at 03:49:30PM -0800, Dhinakaran Pandiyan wrote: > > The avail_slots member in the MST topology manager is never updated to > > reflect the available vcpi slots. The check is effectively against > > total_slots. So,

Re: [Intel-gfx] [PATCH v3 4/8] drm: Add driver-private objects to atomic state

2017-02-21 Thread Pandiyan, Dhinakaran
On Fri, 2017-02-17 at 15:37 +0530, Archit Taneja wrote: > > On 02/16/2017 05:43 AM, Pandiyan, Dhinakaran wrote: > > On Wed, 2017-02-15 at 16:53 +0530, Archit Taneja wrote: > >> Hi, > >> > >> On 02/09/2017 12:08 PM, Dhinakaran Pandiyan wrote: > >>>

Re: [Intel-gfx] [PATCH v3 4/8] drm: Add driver-private objects to atomic state

2017-02-22 Thread Pandiyan, Dhinakaran
On Wed, 2017-02-22 at 09:59 +0530, Archit Taneja wrote: > > On 02/22/2017 05:31 AM, Pandiyan, Dhinakaran wrote: > > On Fri, 2017-02-17 at 15:37 +0530, Archit Taneja wrote: > >> > >> On 02/16/2017 05:43 AM, Pandiyan, Dhinakaran wrote: > >>> On Wed, 2017

Re: [Intel-gfx] [PATCH v3 7/8] drm: Connector helper function to release resources

2017-02-23 Thread Pandiyan, Dhinakaran
On Thu, 2017-02-16 at 09:09 +, Lankhorst, Maarten wrote: > Daniel Vetter schreef op di 14-02-2017 om 20:51 [+0100]: > > On Mon, Feb 13, 2017 at 10:26 PM, Pandiyan, Dhinakaran > > <dhinakaran.pandi...@intel.com> wrote: > > > On Mon, 2017-02-13 at 09:05 +

Re: [Intel-gfx] [PATCH v3 7/8] drm: Connector helper function to release resources

2017-02-13 Thread Pandiyan, Dhinakaran
On Mon, 2017-02-13 at 21:26 +, Pandiyan, Dhinakaran wrote: > On Mon, 2017-02-13 at 09:05 +, Lankhorst, Maarten wrote: > > Pandiyan, Dhinakaran schreef op do 09-02-2017 om 18:55 [+]: > > > On Thu, 2017-02-09 at 09:01 +, Lankhorst, Maarten wrote: > > > >

Re: [Intel-gfx] [PATCH v3 7/8] drm: Connector helper function to release resources

2017-02-13 Thread Pandiyan, Dhinakaran
On Mon, 2017-02-13 at 09:05 +, Lankhorst, Maarten wrote: > Pandiyan, Dhinakaran schreef op do 09-02-2017 om 18:55 [+]: > > On Thu, 2017-02-09 at 09:01 +, Lankhorst, Maarten wrote: > > > > > > Dhinakaran Pandiyan schreef op wo 08-02-2017 om 22:38 [-080

Re: [Intel-gfx] [PATCH v2] drm/dp/mst: fix kernel oops when turning off secondary monitor

2017-02-13 Thread Pandiyan, Dhinakaran
Looks like the right fix to me. Reviewed-by: Dhinakaran Pandiyan On Wed, 2017-01-25 at 16:25 -0800, Nathan Ciobanu wrote: > I tested this patch in dinq on a KBL system and it fixed the bug. The > system doesn't crash on disconnecting or powering off the second

Re: [Intel-gfx] [PATCH v3 7/8] drm: Connector helper function to release resources

2017-02-14 Thread Pandiyan, Dhinakaran
On Tue, 2017-02-14 at 20:51 +0100, Daniel Vetter wrote: > On Mon, Feb 13, 2017 at 10:26 PM, Pandiyan, Dhinakaran > <dhinakaran.pandi...@intel.com> wrote: > > On Mon, 2017-02-13 at 09:05 +, Lankhorst, Maarten wrote: > >> Pandiyan, Dhinakaran schreef op do

Re: [Intel-gfx] [PATCH v3 4/8] drm: Add driver-private objects to atomic state

2017-02-15 Thread Pandiyan, Dhinakaran
On Wed, 2017-02-15 at 16:53 +0530, Archit Taneja wrote: > Hi, > > On 02/09/2017 12:08 PM, Dhinakaran Pandiyan wrote: > > It is necessary to track states for objects other than connector, crtc > > and plane for atomic modesets. But adding objects like DP MST link > > bandwidth to drm_atomic_state

Re: [Intel-gfx] [PATCH v3 7/8] drm: Connector helper function to release resources

2017-02-09 Thread Pandiyan, Dhinakaran
On Thu, 2017-02-09 at 09:01 +, Lankhorst, Maarten wrote: > Dhinakaran Pandiyan schreef op wo 08-02-2017 om 22:38 [-0800]: > > Having a ->atomic_release callback is useful to release shared > > resources > > that get allocated in compute_config(). This function is expected to > > be > > called

Re: [Intel-gfx] [PATCH v3 4/8] drm: Add driver-private objects to atomic state

2017-02-09 Thread Pandiyan, Dhinakaran
On Thu, 2017-02-09 at 08:08 +, Chris Wilson wrote: > On Wed, Feb 08, 2017 at 10:38:07PM -0800, Dhinakaran Pandiyan wrote: > > +#define for_each_private_obj(__state, obj_funcs, obj, obj_state, __i, > > __funcs) \ > > + for ((__i) = 0; \ > >

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Add function to return port from an encoder

2016-08-19 Thread Pandiyan, Dhinakaran
On Thu, 2016-08-18 at 21:39 -0700, Rodrigo Vivi wrote: > On Mon, Aug 15, 2016 at 05:00:53PM -0700, Dhinakaran Pandiyan wrote: > > There are places in the driver where we just need the 'port' associated > > with an encoder and not 'struct intel_digital_port' that contains it. > > This basically is

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Add function to return port from an encoder

2016-08-19 Thread Pandiyan, Dhinakaran
On Fri, 2016-08-19 at 10:02 +0200, Daniel Vetter wrote: > On Mon, Aug 15, 2016 at 05:00:53PM -0700, Dhinakaran Pandiyan wrote: > > There are places in the driver where we just need the 'port' associated > > with an encoder and not 'struct intel_digital_port' that contains it. > > This basically is

Re: [Intel-gfx] [PATCH 4/4] drm/i915/dp: Dump DP link status when link training stages fails

2016-08-04 Thread Pandiyan, Dhinakaran
On Thu, 2016-08-04 at 10:46 +0300, Jani Nikula wrote: > On Thu, 04 Aug 2016, Dhinakaran Pandiyan > wrote: > > A full dump of link status can be handy in debugging link training > > failures. Let's add that to the debug messages when link training fails. > > > >

Re: [Intel-gfx] [PATCH 3/4] drm/dp: Clarify clock recovery and channel equalization failures

2016-08-04 Thread Pandiyan, Dhinakaran
On Thu, 2016-08-04 at 04:12 +0100, Chris Wilson wrote: > On Wed, Aug 03, 2016 at 08:07:40PM -0700, Dhinakaran Pandiyan wrote: > > The causes of clock recovery and channel equalization failures are not > > explicitly printed in debug messages. Help debugging link training > > failures by printing

Re: [Intel-gfx] [PATCH 1/4] drm/i915/dp: Add debug messages to print DP link training pattern

2016-08-04 Thread Pandiyan, Dhinakaran
On Thu, 2016-08-04 at 04:07 +0100, Chris Wilson wrote: > On Wed, Aug 03, 2016 at 08:07:38PM -0700, Dhinakaran Pandiyan wrote: > > @@ -2588,7 +2592,7 @@ _intel_dp_set_link_train(struct intel_dp *intel_dp, > > *DP |= DP_LINK_TRAIN_PAT_2_CPT; > > break; > >

Re: [Intel-gfx] [PATCH v3 4/8] drm: Add driver-private objects to atomic state

2017-02-27 Thread Pandiyan, Dhinakaran
On Sun, 2017-02-26 at 20:57 +0100, Daniel Vetter wrote: > On Wed, Feb 22, 2017 at 12:01:12AM +0000, Pandiyan, Dhinakaran wrote: > > On Fri, 2017-02-17 at 15:37 +0530, Archit Taneja wrote: > > > > > > On 02/16/2017 05:43 AM, Pandiyan, Dhinakaran wrote: > > >

Re: [Intel-gfx] [PATCH 09/14] drm/dp/i915: Make clock recovery in the link training compliant with DP Spec 1.2

2016-09-02 Thread Pandiyan, Dhinakaran
On Fri, 2016-09-02 at 12:16 +0300, Mika Kahola wrote: > On Thu, 2016-09-01 at 15:08 -0700, Manasi Navare wrote: > > From: Dhinakaran Pandiyan > > > > This function cleans up clock recovery loop in link training > > compliant > > tp Dp Spec 1.2. It tries the clock

Re: [Intel-gfx] [PATCH 10/14] drm/i915: Make DP link training channel equalization DP 1.2 Spec compliant

2016-09-02 Thread Pandiyan, Dhinakaran
On Fri, 2016-09-02 at 14:20 +0300, Mika Kahola wrote: > On Thu, 2016-09-01 at 15:08 -0700, Manasi Navare wrote: > > Fix the number of tries in channel euqalization link training > > sequence > > according to DP 1.2 Spec. It returns a boolean depending on channel > > equalization pass or failure. >

Re: [Intel-gfx] [PATCH v3 07/14] drm/i915/dp: Add a standalone function to obtain shared dpll for HSW/BDW/SKL/BXT

2016-09-02 Thread Pandiyan, Dhinakaran
On Thu, 2016-09-01 at 15:08 -0700, Manasi Navare wrote: > From: Jim Bride > > Add the PLL selection code for HSW/BDW/BXT/SKL into a stand-alone function > in order to allow for the implementation of a platform neutral upfront > link training function. > > v3: > * Add

Re: [Intel-gfx] [PATCH 12/14] drm/i915: Reverse the loop in intel_dp_compute_config

2016-09-02 Thread Pandiyan, Dhinakaran
On Thu, 2016-09-01 at 15:08 -0700, Manasi Navare wrote: > While configuring the pipe during modeset, it should loop > starting from max clock and max lane count reducing the > lane count and clock in each iteration until the requested mode > rate is less than or equal to available link BW. > >

Re: [Intel-gfx] [PATCH 11/14] drm/i915: Fallback to lower link rate and lane count during link training

2016-09-02 Thread Pandiyan, Dhinakaran
On Thu, 2016-09-01 at 15:08 -0700, Manasi Navare wrote: > According to the DisplayPort Spec, in case of Clock Recovery failure > the link training sequence should fall back to the lower link rate > followed by lower lane count until CR succeeds. > On CR success, the sequence proceeds with Channel

Re: [Intel-gfx] [PATCH v4] drm/i915/dp: DP audio API changes for MST

2016-09-01 Thread Pandiyan, Dhinakaran
The changes in this version are primarily in i915. I have carried over Takashi's R-B from the previous version and removed Ville's. From: Pandiyan, Dhinakaran Sent: Thursday, September 01, 2016 12:50 AM To: intel-gfx@lists.freedesktop.org Cc: libin.y

Re: [Intel-gfx] [PATCH] drm/i915/fbc: disable FBC on FIFO underruns

2016-09-01 Thread Pandiyan, Dhinakaran
On Mon, 2016-08-15 at 19:36 -0300, Paulo Zanoni wrote: > Ever since I started working on FBC I was already aware that FBC can > really amplify the FIFO underrun symptoms. On systems where FIFO > underruns were harmless error messages, enabling FBC would cause the > underruns to give black screens.

Re: [Intel-gfx] [PATCH v4 2/4] drm/i915: Switch to using port stored in intel_encoder

2016-08-29 Thread Pandiyan, Dhinakaran
Just realized this patch needs s/attached_port/port, will send out another version. On Mon, 2016-08-29 at 17:23 -0400, Lyude Paul wrote: > Looks like a much better solution then the previous one. > > Reviewed-by: Lyude > > On Wed, 2016-08-24 at 00:22 -0700, Dhinakaran

Re: [Intel-gfx] [PATCH v4 3/4] drm/i915: Move audio_connector to intel_encoder

2016-08-29 Thread Pandiyan, Dhinakaran
Confirmed on IRC, Lyude is fine with carrying over R-B from previous version. On Wed, 2016-08-24 at 00:22 -0700, Dhinakaran Pandiyan wrote: > With DP MST, a digital_port can carry more than one audio stream. Hence, > more than one audio_connector needs to be attached to intel_digital_port in >

Re: [Intel-gfx] [PATCH] drm/i915/fbc: disable FBC on FIFO underruns

2016-09-13 Thread Pandiyan, Dhinakaran
Looks good to me. Reviewed-by: Dhinakaran Pandiyan On Tue, 2016-09-13 at 10:38 -0300, Paulo Zanoni wrote: > Ever since I started working on FBC I was already aware that FBC can > really amplify the FIFO underrun symptoms. On systems where FIFO > underruns were

Re: [Intel-gfx] [PATCH v6 1/4] drm/i915: Store port enum in intel_encoder

2016-09-13 Thread Pandiyan, Dhinakaran
On Mon, 2016-09-12 at 18:00 -0700, Dhinakaran Pandiyan wrote: > Storing the port enum in intel_encoder makes it convenient to know the > port attached to an encoder. Moving the port information up from > intel_digital_port to intel_encoder avoids unecessary intel_digital_port > access and handles

Re: [Intel-gfx] [PATCH v2] drm/i915: Standardize port type for DVO encoders

2016-09-14 Thread Pandiyan, Dhinakaran
This version of the patch has been included in the series "Prep. for DP audio MST support" since the helper is used by the patch that stores port in struct intel_encoder. On Wed, 2016-09-14 at 14:03 -0700, Dhinakaran Pandiyan wrote: > Changing the return type from 'char' to 'enum port' in >

Re: [Intel-gfx] [PATCH v4 1/4] drm/i915: Store port enum in intel_encoder

2016-09-12 Thread Pandiyan, Dhinakaran
On Tue, 2016-09-06 at 15:07 +0300, Ville Syrjälä wrote: > On Wed, Aug 24, 2016 at 12:22:57AM -0700, Dhinakaran Pandiyan wrote: > > Storing the port enum in intel_encoder makes it convenient to know the > > port attached to an encoder. Moving the port information up from > > intel_digital_port to

Re: [Intel-gfx] [PATCH v2 12/14] drm/i915: Remove the link rate and lane count loop in compute config

2016-09-12 Thread Pandiyan, Dhinakaran
On Thu, 2016-09-08 at 13:02 -0700, Manasi Navare wrote: > While configuring the pipe during modeset, it should use > max clock and max lane count and reduce the bpp until > the requested mode rate is less than or equal to > available link BW. > This is required to pass DP Compliance. > > v2: > *

Re: [Intel-gfx] [PATCH 4/6] drm/i915: use NULL for NULL pointers

2016-09-15 Thread Pandiyan, Dhinakaran
Reviewed-by: Dhinakaran Pandiyan On Thu, 2016-09-15 at 16:28 +0300, Jani Nikula wrote: > Fix sparse warning: > > drivers/gpu/drm/i915/i915_cmd_parser.c:987:72: warning: Using plain > integer as NULL pointer > > Fixes: 52a42cec4b70 ("drm/i915/cmdparser: Accelerate

Re: [Intel-gfx] [PATCH 2/6] drm/i915: do not use 'false' as a NULL pointer

2016-09-15 Thread Pandiyan, Dhinakaran
Reviewed-by: Dhinakaran Pandiyan On Thu, 2016-09-15 at 16:28 +0300, Jani Nikula wrote: > Fixes sparse warning: > > drivers/gpu/drm/i915/intel_dpll_mgr.c:1712:24: warning: Using plain > integer as NULL pointer > > Fixes: a277ca7dc01d ("drm/i915: Split

Re: [Intel-gfx] [PATCH v3 5/5] drm/i915/dp/mst: Add support for upfront link training for DP MST

2016-09-15 Thread Pandiyan, Dhinakaran
On Tue, 2016-09-13 at 18:08 -0700, Manasi Navare wrote: > From: Jim Bride > > Add upfront link training to intel_dp_mst_mode_valid() so that we know > topology constraints before we validate the legality of modes to be > checked. > The patch seems to do a lot more

Re: [Intel-gfx] [PATCH v3 4/9] drm/i915: Decode system memory bandwidth

2016-09-16 Thread Pandiyan, Dhinakaran
On Fri, 2016-09-09 at 13:31 +0530, Kumar, Mahesh wrote: > From: Mahesh Kumar > > This patch adds support to decode system memory bandwidth > which will be used for arbitrated display memory percentage > calculation in GEN9 based system. > > Signed-off-by: Mahesh Kumar

Re: [Intel-gfx] [PATCH] Revert "drm/i915: start adding dp mst audio"

2016-09-29 Thread Pandiyan, Dhinakaran
gt; > >> Reported-by: Kim Lidström <k...@dxtr.im> > >> Cc: Libin Yang <libin.y...@linux.intel.com> > >> Cc: Lyude <cp...@redhat.com> > >> Cc: Jani Nikula <jani.nik...@intel.com> > > > > Pushed to drm-intel-next-queued, thanks for the

Re: [Intel-gfx] [2/9] drm/doc: Polish kerneldoc for encoders

2016-09-14 Thread Pandiyan, Dhinakaran
I guess it's too late for review now. But, I want to send this anyway. On Mon, 2016-08-29 at 10:27 +0200, Daniel Vetter wrote: > - Move missing bits into struct drm_encoder docs. > - Explain that encoders are 95% internal and only 5% uapi, and that in > general the uapi part is broken. > -

Re: [Intel-gfx] [PATCH v5] drm/i915/dp: DP audio API changes for MST

2016-09-16 Thread Pandiyan, Dhinakaran
Ville who had R-B'd the previous version of the patch, confirmed this version "looks all right" via IRC. On Fri, 2016-09-02 at 10:53 -0700, Dhinakaran Pandiyan wrote: > DP MST provides the capability to send multiple video and audio streams > through a single port. This requires the API's

Re: [Intel-gfx] [PATCH v4 1/4] drm/i915: Store port enum in intel_encoder

2016-08-26 Thread Pandiyan, Dhinakaran
IRC acked-by: Daniel Vetter On Wed, 2016-08-24 at 00:22 -0700, Dhinakaran Pandiyan wrote: > Storing the port enum in intel_encoder makes it convenient to know the > port attached to an encoder. Moving the port information up from > intel_digital_port to intel_encoder

Re: [Intel-gfx] [PATCH v3 1/4] drm/i915: Store port enum in intel_encoder

2016-08-24 Thread Pandiyan, Dhinakaran
On Wed, 2016-08-24 at 08:08 +0200, Daniel Vetter wrote: > On Tue, Aug 23, 2016 at 01:49:17PM -0700, Dhinakaran Pandiyan wrote: > > Storing the port enum in intel_encoder makes it convenient to know the > > port attached to an encoder. Moving the port information up from > > intel_digital_port to

Re: [Intel-gfx] [PATCH 4/5] drm/i915; Add a function to return index of link rate

2016-10-27 Thread Pandiyan, Dhinakaran
On Fri, 2016-10-21 at 16:45 -0700, Manasi Navare wrote: > This is required to return the index of link rate into > common_rates array. This gets used to retry the link > training at lower link rate. > > Cc: Jani Nikula > Cc: Daniel Vetter >

Re: [Intel-gfx] [PATCH v4 1/2] drm/i915/dp: Enable DP audio stall fix for gen9 platforms

2016-10-27 Thread Pandiyan, Dhinakaran
On Wed, 2016-10-26 at 12:11 +0300, Ville Syrjälä wrote: > On Tue, Oct 25, 2016 at 07:37:36PM -0700, Dhinakaran Pandiyan wrote: > > Enabling DP audio stall fix is necessary to play audio over DP HBR2. So, > > let's set this bit right before enabling the audio codec. Playing audio > > without

Re: [Intel-gfx] [PATCH v2] drm/i915/dp: Debug log MST active links explicitly

2016-10-25 Thread Pandiyan, Dhinakaran
Jim, Please let me know if the R-B is still good. -DK On Tue, 2016-10-25 at 21:37 -0700, Dhinakaran Pandiyan wrote: > From: "Pandiyan, Dhinakaran" <dhinakaran.pandi...@intel.com> > > No functional change. Just printing the number of active links without > s

Re: [Intel-gfx] [PATCH v4 1/2] drm/i915/dp: Enable DP audio stall fix for gen9 platforms

2016-10-26 Thread Pandiyan, Dhinakaran
On Wed, 2016-10-26 at 11:57 +0300, Jani Nikula wrote: > On Wed, 26 Oct 2016, Dhinakaran Pandiyan > wrote: > > Enabling DP audio stall fix is necessary to play audio over DP HBR2. So, > > let's set this bit right before enabling the audio codec. Playing audio > >

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915/dp: Enable DP audio stall fix for gen9 platforms

2016-10-26 Thread Pandiyan, Dhinakaran
On Wed, 2016-10-26 at 08:37 +0200, Daniel Vetter wrote: > On Mon, Oct 24, 2016 at 09:18:36PM -0700, Dhinakaran Pandiyan wrote: > > Enabling DP audio stall fix is necessary to play audio over DP HBR2. So, > > let's set this bit right before enabling the audio codec. Playing audio > > without

  1   2   3   4   5   6   >