Re: [Intel-gfx] the monitors with working Displayport audio

2011-11-08 Thread Takashi Iwai
At Wed, 9 Nov 2011 15:20:53 +0800, Wu Fengguang wrote: Hi Takashi, I enumerated all the DELL DisplayPort monitors in our lab and find only two of them being able to produce audible DisplayPort audio... Thanks for testing! - DELL 2408WFP - DELL 2709W - DELL 3008WFP no CEA

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-10 Thread Takashi Iwai
At Thu, 10 Nov 2011 12:00:53 +0100, Christopher White wrote: On 11/10/11 9:55 AM, Christopher White wrote: On 11/10/11 8:55 AM, Wu Fengguang wrote: On Thu, Nov 10, 2011 at 03:33:50PM +0800, Wu Fengguang wrote: Wow I reproduced the bug and got a very interesting dmesg: gfx = [

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-10 Thread Takashi Iwai
At Thu, 10 Nov 2011 12:50:11 +0100, Christopher White wrote: On 11/10/11 12:22 PM, Takashi Iwai wrote: At Thu, 10 Nov 2011 12:00:53 +0100, Christopher White wrote: On 11/10/11 9:55 AM, Christopher White wrote: On 11/10/11 8:55 AM, Wu Fengguang wrote: On Thu, Nov 10, 2011 at 03:33:50PM

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-10 Thread Takashi Iwai
At Thu, 10 Nov 2011 13:39:00 +0100, Christopher White wrote: On 11/10/11 12:53 PM, Takashi Iwai wrote: At Thu, 10 Nov 2011 12:50:11 +0100, Christopher White wrote: On 11/10/11 12:22 PM, Takashi Iwai wrote: At Thu, 10 Nov 2011 12:00:53 +0100, Christopher White wrote: On 11/10/11 9:55

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-10 Thread Takashi Iwai
At Thu, 10 Nov 2011 21:17:53 +0800, Wu Fengguang wrote: On Thu, Nov 10, 2011 at 09:01:24PM +0800, Christopher White wrote: On 11/10/11 1:56 PM, Wu Fengguang wrote: On Thu, Nov 10, 2011 at 07:50:11PM +0800, Christopher White wrote: On 11/10/11 12:22 PM, Takashi Iwai wrote: At Thu, 10

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-10 Thread Takashi Iwai
At Thu, 10 Nov 2011 21:51:50 +0800, Wu Fengguang wrote: So maybe the hardware is in some state that is unable to provide the real ELD content? That's my guess as well. I think the hardware may still be doing some form of data negotiation with the HDMI display device at that

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-10 Thread Takashi Iwai
At Fri, 11 Nov 2011 10:29:25 +0800, Wu Fengguang wrote: On Thu, Nov 10, 2011 at 10:28:19PM +0800, Takashi Iwai wrote: At Thu, 10 Nov 2011 21:51:50 +0800, Wu Fengguang wrote: So maybe the hardware is in some state that is unable to provide the real ELD content

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-11 Thread Takashi Iwai
At Fri, 11 Nov 2011 16:22:41 +0800, Wu Fengguang wrote: On Fri, Nov 11, 2011 at 03:40:37PM +0800, Takashi Iwai wrote: At Fri, 11 Nov 2011 10:29:25 +0800, Wu Fengguang wrote: On Thu, Nov 10, 2011 at 10:28:19PM +0800, Takashi Iwai wrote: At Thu, 10 Nov 2011 21:51:50 +0800, Wu

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-11 Thread Takashi Iwai
At Fri, 11 Nov 2011 17:24:21 +0800, Wu Fengguang wrote: On Fri, Nov 11, 2011 at 04:49:57PM +0800, Takashi Iwai wrote: At Fri, 11 Nov 2011 16:22:41 +0800, Wu Fengguang wrote: On Fri, Nov 11, 2011 at 03:40:37PM +0800, Takashi Iwai wrote: At Fri, 11 Nov 2011 10:29:25 +0800, Wu

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-11 Thread Takashi Iwai
At Fri, 11 Nov 2011 19:12:57 +0800, Wu Fengguang wrote: (snip) One note that we don't rely on PD bit because not all (non-Intel) hardware report it correctly. Oops. Do you imply ELDV is reliable on all platforms? ;-) Oh hell, no :) The driver tries to probe explicitly via

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-14 Thread Takashi Iwai
At Sat, 12 Nov 2011 10:27:26 +0800, Wu Fengguang wrote: (snip) And I'm not sure whether HDMI audio is played while DPMS is off. I haven't tested it. It will go silence on DPMS. I noticed this while doing long term HDMI audio playback tests. This should better be

Re: [Intel-gfx] [PATCH 1/2] hda - fix ELD memory leak

2011-11-15 Thread Takashi Iwai
At Tue, 15 Nov 2011 22:31:55 +0800, Wu Fengguang wrote: memset(eld) clears eld-proc_entry which will leak the struct snd_info_entry when unloading the module. Fix it by - remove memset(eld) - set eld-eld_valid to true _after_ all eld fields have been filled - don't access the other eld

Re: [Intel-gfx] [PATCH 1/2] hda - fix ELD memory leak

2011-11-15 Thread Takashi Iwai
At Tue, 15 Nov 2011 22:41:16 +0800, Wu Fengguang wrote: On Tue, Nov 15, 2011 at 10:35:41PM +0800, Takashi Iwai wrote: At Tue, 15 Nov 2011 22:31:55 +0800, Wu Fengguang wrote: memset(eld) clears eld-proc_entry which will leak the struct snd_info_entry when unloading the module

Re: [Intel-gfx] [PATCH 2/2 v2] hda - delayed ELD repoll

2011-11-15 Thread Takashi Iwai
At Wed, 16 Nov 2011 00:57:08 +0800, Wu Fengguang wrote: +static void hda_eld_work(struct work_struct *work) +{ + struct hdmi_eld *eld = container_of( + container_of(work, struct delayed_work, work), + struct hdmi_eld, work); Ugh,

Re: [Intel-gfx] [PATCH v4] drivers: i915: Default backlight PWM frequency

2011-11-15 Thread Takashi Iwai
At Fri, 11 Nov 2011 14:12:58 -0800, Simon Que wrote: If the firmware did not initialize the backlight PWM registers, set up a default PWM frequency of 200 Hz. This is determined using the following formula: freq = refclk / (128 * pwm_max) The PWM register allows the max PWM value to

Re: [Intel-gfx] [PATCH] i915: Fix bug where screen brightness is not restored

2011-11-15 Thread Takashi Iwai
At Tue, 15 Nov 2011 11:58:38 -0800, Kamal Mostafa wrote: [1 multipart/signed (7bit)] [1.1 text/plain; UTF-8 (quoted-printable)] On Mon, 2011-11-14 at 18:42 -0800, Alex Davis wrote: From: Alex Davisalex14...@yahoo.com This patch fixes an issue where the screen would remain dark when

Re: [Intel-gfx] [PATCH] i915: Fix bug where screen brightness is not restored

2011-11-16 Thread Takashi Iwai
At Tue, 15 Nov 2011 13:54:44 -0800, Kamal Mostafa wrote: On Tue, 2011-11-15 at 21:28 +0100, Takashi Iwai wrote: My rough guess is the inconsistency of property taken during the backlight disabled. How about the patch below (untested!) in addition to the fix in 3.2? Takashi Yes

[Intel-gfx] [PATCH] drm/i915: Fix inconsistent backlight level during disabled

2011-11-16 Thread Takashi Iwai
...@kernel.org Signed-off-by: Takashi Iwai ti...@suse.de --- drivers/gpu/drm/i915/intel_panel.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_panel.c b/drivers/gpu/drm/i915/intel_panel.c index 499d4c0..21f60b7 100644 --- a/drivers/gpu/drm/i915

Re: [Intel-gfx] [alsa-devel] [PATCH 2/2] hda - delayed ELD repoll

2011-11-16 Thread Takashi Iwai
At Wed, 16 Nov 2011 07:51:28 -0800, Stephen Warren wrote: 250mS almost sounds like it's setting ELDV in the audio HW, then going and reading the EDID, then writing the EDID to the audio HW; perhaps the graphics driver is accidentally setting PRESENT+ELDV when it's meant to be setting

Re: [Intel-gfx] [alsa-devel] [PATCH 2/2] hda - delayed ELD repoll

2011-11-16 Thread Takashi Iwai
At Wed, 16 Nov 2011 08:12:04 -0800, Stephen Warren wrote: Takashi Iwai wrote at Wednesday, November 16, 2011 8:58 AM: At Wed, 16 Nov 2011 07:51:28 -0800, Stephen Warren wrote: ... [ 424.263258] HDMI hot plug event: Codec=3 Pin=6 Presence_Detect=1 ELD_Valid=0 That line makes

[Intel-gfx] [PATCH] drm/i915: Fix invalid backpanel values for GEN3 or older chips

2011-11-16 Thread Takashi Iwai
off suddenly. This patch changes the bit-0 check by replacing with the condition of gen 4 (pineview is included in this condition, too). Reported-and-tested-by: Daniel Mack zon...@gmail.com Cc: sta...@kernel.org Signed-off-by: Takashi Iwai ti...@suse.de --- drivers/gpu/drm/i915/intel_panel.c

Re: [Intel-gfx] [PATCH] drm/i915: Fix invalid backpanel values for GEN3 or older chips

2011-11-17 Thread Takashi Iwai
At Wed, 16 Nov 2011 22:15:41 -0800, Keith Packard wrote: On Wed, 16 Nov 2011 18:14:55 +0100, Takashi Iwai ti...@suse.de wrote: While refactoring of backlight control code in commit [a95735569: drm/i915: Refactor panel backlight controls], the handling of the bit 0 of duty-cycle was gone

Re: [Intel-gfx] [PATCH] drm/i915: Fix invalid backpanel values for GEN3 or older chips

2011-11-20 Thread Takashi Iwai
At Sat, 19 Nov 2011 10:34:12 -0800, Keith Packard wrote: [1 text/plain (quoted-printable)] On Sat, 19 Nov 2011 11:05:05 +0100, Takashi Iwai ti...@suse.de wrote: Maybe it'd be better to mention that actually setting bit-0 caused a blank screen on some machines. Was that caused

Re: [Intel-gfx] [PATCH 3/3] drm/i915: hot removal notification to HDMI audio driver

2011-11-21 Thread Takashi Iwai
At Mon, 21 Nov 2011 09:58:09 +0800, Wu Fengguang wrote: On Sat, Nov 19, 2011 at 01:46:44AM +0800, Keith Packard wrote: On Fri, 18 Nov 2011 17:37:40 +0800, Wu Fengguang fengguang...@intel.com wrote: However when in X, -mode_set won't be called at all. Only -get_modes and -detect

Re: [Intel-gfx] [PATCH 0/5] Intel HDMI ELD fixes v2

2011-12-09 Thread Takashi Iwai
/gpu/drm/i915/intel_dp.c |1 drivers/gpu/drm/i915/intel_hdmi.c|8 ++ 4 files changed, 76 insertions(+), 30 deletions(-) Thanks. Feel free to add my ack to all these. Acked-by: Takashi Iwai ti...@suse.de Takashi ___ Intel-gfx

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: provide interface for audio driver to query cdclk

2014-07-04 Thread Takashi Iwai
At Fri, 4 Jul 2014 10:00:37 +0800, mengdong@intel.com wrote: From: Jani Nikula jani.nik...@intel.com For Haswell and Broadwell, if the display power well has been disabled, the display audio controller divider values EM4 M VALUE and EM5 N VALUE will have been lost. The CDCLK frequency

Re: [Intel-gfx] [PATCH] drm/i915: fix up the edp power well check

2013-05-31 Thread Takashi Iwai
commit 2124b72e6283c4e84a55e71077fee91793f4c801 Author: Paulo Zanoni paulo.r.zan...@intel.com Date: Fri Mar 22 14:07:23 2013 -0300 drm/i915: don't disable the power well yet Cc: Takashi Iwai ti...@suse.de Sorry, I have no hardware that showed the problem around here for testing now

Re: [Intel-gfx] [PATCH 1/4] ALSA: hda - Haswell converter power state D0 verify

2013-06-17 Thread Takashi Iwai
At Fri, 14 Jun 2013 23:20:26 +0800, Wang Xingchao wrote: Haswell converters maybe in wrong power state before usage. i.e. only converter 0 is in D0, converter 1/2 are in D3. When pin choose converter 1/2, there's no audio output. Signed-off-by: Wang Xingchao xingchao.w...@linux.intel.com

Re: [Intel-gfx] [PATCH] ALSA: hda - Haswell converter power state D0 verify

2013-06-18 Thread Takashi Iwai
At Tue, 18 Jun 2013 10:41:53 +0800, Wang Xingchao wrote: Haswell converters maybe in wrong power state before usage. i.e. only converter 0 is in D0, converter 1/2 are in D3. When pin choose converter 1/2, there's no audio output, this cause dependency when playing differnt stream on pins.

Re: [Intel-gfx] [PATCH] ALSA: hda - Avoid choose same converter for unused pins

2013-06-18 Thread Takashi Iwai
At Tue, 18 Jun 2013 16:32:01 +0800, Wang Xingchao wrote: For Intel Haswell HDMI codecs, the pins choose converter 0 by default. This would cause conflict when playing audio on unused pins,the pin with physical device connected would get audio data too. i.e. Pin 0/1/2 default choose converter

Re: [Intel-gfx] [PATCH V1] ALSA: hda - Avoid choose same converter for unused pins

2013-06-18 Thread Takashi Iwai
At Tue, 18 Jun 2013 21:42:14 +0800, Wang Xingchao wrote: For Intel Haswell HDMI codecs, the pins choose converter 0 by default. This would cause conflict when playing audio on unused pins,the pin with physical device connected would get audio data too. i.e. Pin 0/1/2 default choose converter

Re: [Intel-gfx] [PATCH 0/4 V7] Power-well API implementation for Haswell

2013-07-06 Thread Takashi Iwai
- manage symbols and module loading properly - remove IS_HSW macro, use flag instead - remove audio callback for gfx driver to avoid dependency - split whole patch into two pieces for easy review - more typo fixes Takashi Iwai (1): ALSA: hda - Move

Re: [Intel-gfx] [PATCH 0/4 V7] Power-well API implementation for Haswell

2013-07-08 Thread Takashi Iwai
At Sun, 7 Jul 2013 19:59:33 -0400, Wang xingchao wrote: On Sat, Jul 06, 2013 at 08:20:59AM +0200, Takashi Iwai wrote: drm-intel-next. I'll show up in the next linux-next and I'll forward it to Dave for mergin into drm-next in roughly 2 weeks. So today I

Re: [Intel-gfx] [alsa-devel] [PATCH 0/4 V7] Power-well API implementation for Haswell

2013-07-17 Thread Takashi Iwai
At Wed, 17 Jul 2013 02:52:41 +, Wang, Xingchao wrote: Hi Takashi/Paulo, would you change it to auto and test again. Runtime power save should be enabled with auto. Doesn't solve the problem. Should I open a bug report somewhere? Having the power well enabled prevents some

Re: [Intel-gfx] [alsa-devel] [PATCH 0/4 V7] Power-well API implementation for Haswell

2013-07-17 Thread Takashi Iwai
At Wed, 17 Jul 2013 08:03:38 +, Wang, Xingchao wrote: -Original Message- From: Takashi Iwai [mailto:ti...@suse.de] Sent: Wednesday, July 17, 2013 3:34 PM To: Wang, Xingchao Cc: Paulo Zanoni; alsa-de...@alsa-project.org; Daniel Vetter; daniel.vet...@ffwll.ch; intel-gfx

Re: [Intel-gfx] [alsa-devel] [PATCH 0/4 V7] Power-well API implementation for Haswell

2013-07-17 Thread Takashi Iwai
At Wed, 17 Jul 2013 10:31:26 -0300, Paulo Zanoni wrote: 2013/7/17 Wang, Xingchao xingchao.w...@intel.com: -Original Message- From: Takashi Iwai [mailto:ti...@suse.de] Sent: Wednesday, July 17, 2013 4:18 PM To: Wang, Xingchao Cc: Paulo Zanoni; alsa-de...@alsa-project.org

Re: [Intel-gfx] [alsa-devel] [PATCH 0/4 V7] Power-well API implementation for Haswell

2013-07-18 Thread Takashi Iwai
-stream event should happen only when the device is really unavailable, but never be done just for saving power. Takashi Thanks --xingchao -Original Message- From: Wang, Xingchao Sent: Thursday, July 18, 2013 7:18 AM To: 'Takashi Iwai'; David Henningsson; Paulo Zanoni Cc: alsa

Re: [Intel-gfx] [alsa-devel] [PATCH 0/4 V7] Power-well API implementation for Haswell

2013-07-18 Thread Takashi Iwai
-project.org; Daniel Vetter; intel-gfx@lists.freedesktop.org; Wang xingchao; Girdwood, Liam R; Jin, Gordon; Takashi Iwai; David Henningsson Subject: Re: [alsa-devel] [Intel-gfx] [PATCH 0/4 V7] Power-well API implementation for Haswell On Thu, Jul 18, 2013 at 01:00:07AM +, Wang

Re: [Intel-gfx] [alsa-devel] [PATCH 0/4 V7] Power-well API implementation for Haswell

2013-07-24 Thread Takashi Iwai
in general. (And it makes things complicated and fragile.) The real question is why there are two useless STOP signs there. thanks, Takashi Thanks --xingchao -Original Message- From: Takashi Iwai [mailto:ti...@suse.de] Sent: Thursday, July 18, 2013 5:35 PM To: Wang, Xingchao Cc

Re: [Intel-gfx] [alsa-devel] [PATCH 0/4 V7] Power-well API implementation for Haswell

2013-07-24 Thread Takashi Iwai
At Wed, 24 Jul 2013 13:30:16 +, Wang, Xingchao wrote: -Original Message- From: Wysocki, Rafael J Sent: Wednesday, July 24, 2013 9:15 PM To: David Henningsson Cc: Wang, Xingchao; Takashi Iwai; Paulo Zanoni; Daniel Vetter; daniel.vet...@ffwll.ch; alsa-de...@alsa

[Intel-gfx] [PATCH] drm/i915: dp: increase probe retries

2013-08-06 Thread Takashi Iwai
, increase the number of retries from 5 to 10. This seems enough for our cases. Signed-off-by: Takashi Iwai ti...@suse.de --- drivers/gpu/drm/i915/intel_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index

Re: [Intel-gfx] [PATCH] drm/i915: Cancel outstanding modeset workers before suspend

2013-08-06 Thread Takashi Iwai
raised whilst tackling a suspend issue with Takashi Iwai (http://lists.freedesktop.org/archives/intel-gfx/2012-April/016738.html) and then it was independently rediscovered by Chuanshen Lui. v2: Rebase for the lost year. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk Cc: Takashi Iwai ti

[Intel-gfx] How to work around zero-initialized BLC_PWM_PCH_CTL2?

2013-08-29 Thread Takashi Iwai
Hi, a new laptop model we've been struggling has some strange hardware configuration. BIOS turns off backlight and skips its initialization when the machine is booted with the lid closed. This leaves BLC_PWM_PCH_CTL2 and other registers uninitialized. Because a proper max brightness value

Re: [Intel-gfx] [RFC] set up an sync channel between audio and display driver (i.e. ALSA and DRM)

2014-05-20 Thread Takashi Iwai
At Tue, 20 May 2014 02:52:19 +, Lin, Mengdong wrote: This RFC is based on previous discussion to set up a generic communication channel between display and audio driver and an internal design of Intel MCG/VPG HDMI audio driver. It's still an initial draft and your advice would be

[Intel-gfx] [PATCH] drm/i915, HD-audio: Don't continue probing when nomodeset is given

2014-06-13 Thread Takashi Iwai
...@vger.kernel.org [3.15] Signed-off-by: Takashi Iwai ti...@suse.de --- The bug actually exists since 3.11, but this commit will be applicable only to recent kernels due to ALSA and i915 code changes, that's why marked with [3.15] for stable. drivers/gpu/drm/i915/intel_pm.c | 14 -- include

Re: [Intel-gfx] [PATCH] drm/i915, HD-audio: Don't continue probing when nomodeset is given

2014-06-13 Thread Takashi Iwai
At Fri, 13 Jun 2014 18:07:06 +0200, Daniel Vetter wrote: On Fri, Jun 13, 2014 at 05:56:02PM +0200, Takashi Iwai wrote: When a machine is booted with nomodeset option, i915 driver skips the whole initialization. Meanwhile, HD-audio tries to bind wth i915 just by request_symbol() without

Re: [Intel-gfx] [PATCH] drm/i915: Retry reading DPCD when bogus values are read

2013-11-25 Thread Takashi Iwai
At Mon, 25 Nov 2013 16:47:25 +0100, Daniel Vetter wrote: On Fri, Nov 22, 2013 at 09:36:09AM +0100, Takashi Iwai wrote: I got kernel WARNINGs frequently on Haswell laptops complaining about invalid max DP link bw. With drm.debug=0x0e, it turned out that the obtained DPCD is utterly bogus

Re: [Intel-gfx] [PATCH 05/19] drm/i915: add initial Runtime PM functions

2013-11-29 Thread Takashi Iwai
At Wed, 27 Nov 2013 18:10:30 -0200, Paulo Zanoni wrote: From: Paulo Zanoni paulo.r.zan...@intel.com This patch adds the initial infrastructure to allow a Runtime PM implementation that sets the device to its D3 state. The patch just adds the necessary callbacks and the initial

Re: [Intel-gfx] [PATCH] drm/i915: Retry reading DPCD when bogus values are read

2013-12-04 Thread Takashi Iwai
At Wed, 04 Dec 2013 12:17:03 +0200, Jani Nikula wrote: On Fri, 22 Nov 2013, Takashi Iwai ti...@suse.de wrote: I got kernel WARNINGs frequently on Haswell laptops complaining about invalid max DP link bw. With drm.debug=0x0e, it turned out that the obtained DPCD is utterly bogus when

Re: [Intel-gfx] [PATCH 05/19] drm/i915: add initial Runtime PM functions

2013-12-08 Thread Takashi Iwai
At Fri, 6 Dec 2013 20:31:04 -0200, Paulo Zanoni wrote: 2013/11/29 Takashi Iwai ti...@suse.de: At Wed, 27 Nov 2013 18:10:30 -0200, Paulo Zanoni wrote: From: Paulo Zanoni paulo.r.zan...@intel.com This patch adds the initial infrastructure to allow a Runtime PM implementation

Re: [Intel-gfx] Need your advice: Add a new communication inteface between HD-Audio and Gfx drivers for hotplug notification/ELD update

2014-01-22 Thread Takashi Iwai
At Wed, 22 Jan 2014 10:45:26 -0500, Rob Clark wrote: On Wed, Jan 22, 2014 at 10:20 AM, Daniel Vetter dan...@ffwll.ch wrote: On Wed, Jan 22, 2014 at 10:04:14AM -0500, Rob Clark wrote: sorry to jump into this a bit late, so maybe this was covered already earlier.. It just started, I've

Re: [Intel-gfx] Need your advice: Add a new communication inteface between HD-Audio and Gfx drivers for hotplug notification/ELD update

2014-01-22 Thread Takashi Iwai
To: Lin, Mengdong Cc: Takashi Iwai (ti...@suse.de); Barnes, Jesse; Zanoni, Paulo R; alsa-de...@alsa-project.org; intel-gfx@lists.freedesktop.org Subject: Re: Need your advice: Add a new communication inteface between HD-Audio and Gfx drivers for hotplug notification/ELD update On Tue

Re: [Intel-gfx] Need your advice: Add a new communication inteface between HD-Audio and Gfx drivers for hotplug notification/ELD update

2014-01-22 Thread Takashi Iwai
At Thu, 23 Jan 2014 06:35:12 +, Lin, Mengdong wrote: -Original Message- From: Takashi Iwai [mailto:ti...@suse.de] Sent: Thursday, January 23, 2014 1:19 AM To: Daniel Vetter Cc: Lin, Mengdong; Barnes, Jesse; Zanoni, Paulo R; alsa-de...@alsa-project.org; intel-gfx

Re: [Intel-gfx] [PATCH v4] ACPI / video: Add systems that should favour native backlight interface

2014-02-18 Thread Takashi Iwai
At Tue, 18 Feb 2014 12:34:42 +0200, Mika Westerberg wrote: On Tue, Feb 18, 2014 at 01:54:20PM +0800, Aaron Lu wrote: + { + .callback = video_set_use_native_backlight, + .ident = HP EliteBook 2013 models, + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, Hewlett-Packard),

Re: [Intel-gfx] [PATCH] drm/i915: Undo gtt scratch pte unmapping again

2014-03-27 Thread Takashi Iwai
PTEs on GEN6+ suspend Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=64841 Reported-and-Tested-by: Brad Jackson bjackson0...@gmail.com Cc: sta...@vger.kernel.org Cc: Takashi Iwai ti...@suse.de Cc: Paulo Zanoni paulo.r.zan...@intel.com Cc: Todd Previte tprev...@gmail.com Signed-off

Re: [Intel-gfx] [PATCH] drm/i915: Undo gtt scratch pte unmapping again

2014-03-27 Thread Takashi Iwai
At Thu, 27 Mar 2014 07:55:57 +0100, Daniel Vetter wrote: On Thu, Mar 27, 2014 at 7:41 AM, Takashi Iwai ti...@suse.de wrote: It apparently blows up on some machines. This functionally reverts commit 828c79087cec61eaf4c76bb32c222fbe35ac3930 Author: Ben Widawsky benjamin.widaw...@intel.com

Re: [Intel-gfx] [PATCH] drm/i915: Undo gtt scratch pte unmapping again

2014-03-27 Thread Takashi Iwai
At Thu, 27 Mar 2014 07:41:41 +0100, Takashi Iwai wrote: At Wed, 26 Mar 2014 20:10:09 +0100, Daniel Vetter wrote: It apparently blows up on some machines. This functionally reverts commit 828c79087cec61eaf4c76bb32c222fbe35ac3930 Author: Ben Widawsky benjamin.widaw...@intel.com

Re: [Intel-gfx] [PATCH v2] drm/i915: move power domain init earlier during system resume

2014-04-03 Thread Takashi Iwai
At Thu, 3 Apr 2014 17:23:10 +0200, Daniel Vetter wrote: On Wed, Apr 02, 2014 at 02:59:54PM +0200, Takashi Iwai wrote: At Tue, 1 Apr 2014 22:26:20 +0200, Daniel Vetter wrote: On Tue, Apr 01, 2014 at 09:50:43PM +0300, Imre Deak wrote: On Tue, 2014-04-01 at 19:48 +0200, Daniel

Re: [Intel-gfx] [PATCH] drm/i915: write backlight harder

2013-02-06 Thread Takashi Iwai
At Wed, 6 Feb 2013 11:24:41 +0100, Daniel Vetter wrote: 770c12312ad617172b1a65b911d3e6564fc5aca8 is the first bad commit commit 770c12312ad617172b1a65b911d3e6564fc5aca8 Author: Takashi Iwai ti...@suse.de Date: Sat Aug 11 08:56:42 2012 +0200 drm/i915: Fix blank panel at reopening

Re: [Intel-gfx] [PATCH] Build: Add --disable-tests configure flag to avoid tests build - v2

2013-02-06 Thread Takashi Iwai
and more tests. v2: wait for Ben's spacin fixes and adjusted for new space rules. /spacin/spacing/ ? Reviewed-by: Takashi Iwai ti...@suse.de Thanks! We can drop one more patch from SLE package now ;) Takashi Signed-off-by: Rodrigo Vivi rodrigo.v...@gmail.com Conflicts

Re: [Intel-gfx] [Alsa-user] intel-hda: sound via HDMI only when using interlaced modes

2013-02-11 Thread Takashi Iwai
At Sun, 10 Feb 2013 02:16:14 +0100, David Härdeman wrote: On Thu, Feb 07, 2013 at 11:00:13AM +0100, Daniel Vetter wrote: On Wed, Feb 06, 2013 at 10:35:33PM +0100, David Härdeman wrote: I'll break etiquette here and include the entire original message below (and top-post!) since I'm sending

Re: [Intel-gfx] Regression: Backlight not coming on after resume.

2013-02-28 Thread Takashi Iwai
At Thu, 28 Feb 2013 17:33:56 +0200, Jani Nikula wrote: On Thu, 28 Feb 2013, James Courtier-Dutton james.dut...@gmail.com wrote: Bisect done on tree: git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git Worked on 3.7. Broken on 3.8 Problem: Backlight not coming on

[Intel-gfx] [PATCH] Revert drm/i915: try to train DP even harder

2013-03-11 Thread Takashi Iwai
this commit recovers the framebuffer (but X is still broken by other reasons...) Cc: sta...@vger.kernel.org Signed-off-by: Takashi Iwai ti...@suse.de --- drivers/gpu/drm/i915/intel_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm

[Intel-gfx] [PATCH 2/2] drm/i915: Use the fixed pixel clock for eDP in intel_dp_set_m_n()

2013-03-12 Thread Takashi Iwai
...@vger.kernel.org Signed-off-by: Takashi Iwai ti...@suse.de --- drivers/gpu/drm/i915/intel_dp.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 7d250aa..ddbf50f 100644 --- a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 0/2] Fix eDP breakages on HP Z1 desktop

2013-03-12 Thread Takashi Iwai
Hi, this is a patch series to fix the breakages of eDP output on HP Z1 desktop machine with IvyBridge since 3.6 kernel. The first patch is identical as what I already sent yesterday, reverting a bogus check in the dp train loop. The second one is the patch I cooked today, for using the correct

[Intel-gfx] [PATCH 1/2] Revert drm/i915: try to train DP even harder

2013-03-12 Thread Takashi Iwai
check for the intended purpose of that commit, but let's revert the wrong fix at first. Cc: sta...@vger.kernel.org Signed-off-by: Takashi Iwai ti...@suse.de --- drivers/gpu/drm/i915/intel_dp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b

[Intel-gfx] Regression: HSW eDP broken on 3.9-rc[12]

2013-03-14 Thread Takashi Iwai
Hi, I noticed that a Haswell desktop machine with eDP gets only the blank screen on the latest Linus tree. It works fine with 3.8, so it's a regression since 3.9-rc1. Actually, it's not a regression. It's three regressions in a shot! (I had to do painful bisections three times...)

Re: [Intel-gfx] [PATCH] Revert drm/i915: try to train DP even harder

2013-03-18 Thread Takashi Iwai
At Sun, 17 Mar 2013 22:59:22 +0100, Daniel Vetter wrote: On Mon, Mar 11, 2013 at 06:40:16PM +0100, Takashi Iwai wrote: This reverts commit 0d71068835e2610576d369d6d4cbf90e0f802a71. Not only that the commit introduces a bogus check (voltage_tries == 5 will never meet at the inserted

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Use the fixed pixel clock for eDP in intel_dp_set_m_n()

2013-03-18 Thread Takashi Iwai
At Sun, 17 Mar 2013 23:12:03 +0100, Daniel Vetter wrote: On Tue, Mar 12, 2013 at 04:32:28PM +0100, Takashi Iwai wrote: The eDP output on HP Z1 is still broken when X is started even after fixing the infinite link-train loop. The regression was introduced in 3.6 kernel for cleaning up

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Revert backlight cargo-culting

2013-03-22 Thread Takashi Iwai
machines again with the new trick. So remove it all and start over. References: http://www.mail-archive.com/intel-gfx@lists.freedesktop.org/msg18788.html Cc: Jani Nikula jani.nik...@intel.com Cc: Takashi Iwai ti...@suse.de Signed-off-by: Daniel Vetter daniel.vet...@ffwll.ch Well, although I fully

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Revert backlight cargo-culting

2013-03-22 Thread Takashi Iwai
At Fri, 22 Mar 2013 11:22:57 +0100, Daniel Vetter wrote: On Fri, Mar 22, 2013 at 11:13 AM, Daniel Vetter daniel.vet...@ffwll.ch wrote: On Fri, Mar 22, 2013 at 11:00 AM, Takashi Iwai ti...@suse.de wrote: At Fri, 22 Mar 2013 10:53:41 +0100, Daniel Vetter wrote: This reverts

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Revert backlight cargo-culting

2013-03-22 Thread Takashi Iwai
At Fri, 22 Mar 2013 12:22:42 +0100, Daniel Vetter wrote: On Fri, Mar 22, 2013 at 11:42 AM, Takashi Iwai ti...@suse.de wrote: At Fri, 22 Mar 2013 11:22:57 +0100, Daniel Vetter wrote: On Fri, Mar 22, 2013 at 11:13 AM, Daniel Vetter daniel.vet...@ffwll.ch wrote: On Fri, Mar 22, 2013

Re: [Intel-gfx] [PATCH] Revert drm/i915: write backlight harder

2013-03-22 Thread Takashi Iwai
At Fri, 22 Mar 2013 15:44:46 +0100, Daniel Vetter wrote: This reverts commit cf0a6584aa6d382f802f2c3cacac23ccbccde0cd. Turns out that cargo-culting breaks systems. Note that we can't revert further, since commit 770c12312ad617172b1a65b911d3e6564fc5aca8 Author: Takashi Iwai ti...@suse.de

Re: [Intel-gfx] [PATCH] drm/i915: Add private api for power well usage -- alignment between graphic team and audio team

2013-04-26 Thread Takashi Iwai
R; ville.syrj...@linux.intel.com; Lin, Mengdong; Girdwood, Liam R; intel-gfx@lists.freedesktop.org; alsa-de...@alsa-project.org; Wang Xingchao; Takashi Iwai; Barnes, Jesse; Wysocki, Rafael J; Hindman, Gavin Subject: Re: [PATCH] drm/i915: Add private api for power well usage

Re: [Intel-gfx] [PATCH] drm/i915: Add private api for power well usage -- alignment between graphic team and audio team

2013-04-26 Thread Takashi Iwai
At Fri, 26 Apr 2013 17:42:07 +0200, Daniel Vetter wrote: On Fri, Apr 26, 2013 at 05:12:34PM +0200, Takashi Iwai wrote: At Fri, 26 Apr 2013 16:57:08 +0200, Daniel Vetter wrote: On Fri, Apr 26, 2013 at 07:53:41AM +, Li, Jocelyn wrote: -Original Message- From: Daniel

Re: [Intel-gfx] [PATCH] drm/i915: Add private api for power well usage -- alignment between graphic team and audio team

2013-05-03 Thread Takashi Iwai
At Mon, 29 Apr 2013 08:02:19 -0700, Jesse Barnes wrote: On Sat, 27 Apr 2013 13:35:29 +0200 Daniel Vetter dan...@ffwll.ch wrote: On Sat, Apr 27, 2013 at 09:20:39AM +, Wang, Xingchao wrote: Let me throw a basic proposal on Audio driver side, please give your comments freely.

Re: [Intel-gfx] [alsa-devel] [PATCH] drm/i915: Add private api for power well usage -- alignment between graphic team and audio team

2013-05-03 Thread Takashi Iwai
At Fri, 03 May 2013 14:02:04 +0200, David Henningsson wrote: On 05/03/2013 10:28 AM, Wang, Xingchao wrote: Hi David, Thank you very much for your draft patch. I have some more work on a new patchset, some ideas are from your patch. Thanks. Here's a brief introduction of attached

Re: [Intel-gfx] [RFC PATCH 1/3] drm/915: Add private api for power well usage

2013-05-09 Thread Takashi Iwai
At Thu, 9 May 2013 11:23:21 +0200, Daniel Vetter wrote: 2. On a quick read of the hda driver stuff I don't think the power well enable/disable places are at the right spot: We force the power well on whenever the hda codec is used, but we must only do that when we want to output audio to

Re: [Intel-gfx] [alsa-devel] [PATCH 5/5] ALSA/i915: Check power well API existense before calling

2013-05-13 Thread Takashi Iwai
At Mon, 13 May 2013 11:55:14 +, Wang, Xingchao wrote: Hi David, -Original Message- From: alsa-devel-boun...@alsa-project.org [mailto:alsa-devel-boun...@alsa-project.org] On Behalf Of David Henningsson Sent: Monday, May 13, 2013 4:29 PM To: Wang Xingchao Cc:

Re: [Intel-gfx] [alsa-devel] [PATCH 4/5] ALSA: hda - Fix module dependency with gfx i915

2013-05-13 Thread Takashi Iwai
At Mon, 13 May 2013 15:37:27 +0800, Wang Xingchao wrote: hda_i915 has dependency on i915 module, this patch check whether symbol exist before calling API there. If i915 module not loaded it will try to load before use. Signed-off-by: Wang Xingchao xingchao.w...@linux.intel.com You need to

Re: [Intel-gfx] [alsa-devel] [PATCH 5/5] ALSA/i915: Check power well API existense before calling

2013-05-13 Thread Takashi Iwai
At Mon, 13 May 2013 15:37:28 +0800, Wang Xingchao wrote: I915 module maybe loaded after snd_hda_intel, the power-well API doesnot exist in such case. This patch intended to avoid loading dependency between snd-hda-intel and i915 module. Signed-off-by: Wang Xingchao

Re: [Intel-gfx] [PATCH 2/2] ALSA: hda - Add power-welll support for haswell HDA

2013-05-14 Thread Takashi Iwai
At Tue, 14 May 2013 19:44:19 +0800, Wang Xingchao wrote: For Intel Haswell chip, HDA controller and codec have power well dependency from GPU side. This patch added support to request/release power well in audio driver. Power save feature should be enabled to get runtime power saving.

Re: [Intel-gfx] [alsa-devel] [PATCH 1/2] drm/915: Add private api for power well usage

2013-05-14 Thread Takashi Iwai
At Tue, 14 May 2013 19:44:18 +0800, Wang Xingchao wrote: Haswell Display audio depends on power well in graphic side, it should request power well before use it and release power well after use. I915 will not shutdown power well if it detects audio is using. This patch protects display audio

Re: [Intel-gfx] [PATCH 2/2] ALSA: hda - Add power-welll support for haswell HDA

2013-05-15 Thread Takashi Iwai
At Thu, 16 May 2013 03:51:16 +, Wang, Xingchao wrote: Hi Takashi, Thanks your quick feedback, please see my comments below. -Original Message- From: Takashi Iwai [mailto:ti...@suse.de] Sent: Tuesday, May 14, 2013 8:15 PM To: Wang Xingchao Cc: dan...@ffwll.ch; Girdwood

Re: [Intel-gfx] [PATCH 1/2 V4] i915/drm: Add private api for power well usage

2013-05-21 Thread Takashi Iwai
At Mon, 20 May 2013 19:26:57 +0800, Wang Xingchao wrote: Haswell Display audio depends on power well in graphic side, it should request power well before use it and release power well after use. I915 will not shutdown power well if it detects audio is using. This patch protects display audio

Re: [Intel-gfx] [PATCH 2/2 V4] ALSA: hda - Add power-welll support for haswell HDA

2013-05-21 Thread Takashi Iwai
At Mon, 20 May 2013 19:26:58 +0800, Wang Xingchao wrote: For Intel Haswell chip, HDA controller and codec have power well dependency from GPU side. This patch added support to request/release power well in audio driver. Power save feature should be enabled to get runtime power saving.

Re: [Intel-gfx] [PATCH 2/2 V4] ALSA: hda - Add power-welll support for haswell HDA

2013-05-21 Thread Takashi Iwai
At Tue, 21 May 2013 10:58:36 +, Wang, Xingchao wrote: -Original Message- From: Takashi Iwai [mailto:ti...@suse.de] Sent: Tuesday, May 21, 2013 3:19 PM To: Wang Xingchao Cc: dan...@ffwll.ch; Girdwood, Liam R; david.hennings...@canonical.com; Lin, Mengdong; Li, Jocelyn

Re: [Intel-gfx] [PATCH 3/4] ALSA: hda - Fix runtime PM check

2013-05-23 Thread Takashi Iwai
At Thu, 23 May 2013 01:04:15 +0800, Wang Xingchao wrote: The device can support runtime PM no matter whether it support signal wakeup or not. For some chips like Haswell which doesnot support PME by default, this patch let haswell Display HD-A controller enter runtime suspend, and bring more

Re: [Intel-gfx] [PATCH 4/4] ALSA: hda - Continue probe in work context to avoid request_module deadlock

2013-05-23 Thread Takashi Iwai
At Thu, 23 May 2013 01:04:16 +0800, Wang Xingchao wrote: There's deadlock when request_module(i915) in azx_probe. It looks like: device_lock(audio pci device) - azx_probe - module_request (or symbol_request) - modprobe (userspace) - i915 init - drm_pci_init - pci_register_driver -

Re: [Intel-gfx] [PATCH 4/4 V2] ALSA: hda - Continue probe in work context to avoid request_module deadlock

2013-05-23 Thread Takashi Iwai
At Thu, 23 May 2013 09:51:07 +0800, Wang Xingchao wrote: There's deadlock when request_module(i915) in azx_probe. It looks like: device_lock(audio pci device) - azx_probe - module_request (or symbol_request) - modprobe (userspace) - i915 init - drm_pci_init - pci_register_driver -

Re: [Intel-gfx] [PATCH 3/4] ALSA: hda - Fix runtime PM check

2013-05-23 Thread Takashi Iwai
At Thu, 23 May 2013 07:53:00 +, Wang, Xingchao wrote: Hi Takashi, -Original Message- From: Takashi Iwai [mailto:ti...@suse.de] Sent: Thursday, May 23, 2013 2:03 PM To: Wang Xingchao Cc: dan...@ffwll.ch; alsa-de...@alsa-project.org; intel-gfx@lists.freedesktop.org

Re: [Intel-gfx] [PATCH 4/4 V2] ALSA: hda - Continue probe in work context to avoid request_module deadlock

2013-05-23 Thread Takashi Iwai
At Thu, 23 May 2013 10:19:27 +, Wang, Xingchao wrote: Hi Takashi, -Original Message- From: Takashi Iwai [mailto:ti...@suse.de] Sent: Thursday, May 23, 2013 2:49 PM To: Wang Xingchao Cc: alsa-de...@alsa-project.org; intel-gfx@lists.freedesktop.org; david.hennings

Re: [Intel-gfx] [PATCH 1/4 V5] i915/drm: Add private api for power well usage

2013-05-23 Thread Takashi Iwai
At Thu, 23 May 2013 01:04:13 +0800, Wang Xingchao wrote: Haswell Display audio depends on power well in graphic side, it should request power well before use it and release power well after use. I915 will not shutdown power well if it detects audio is using. This patch protects display audio

Re: [Intel-gfx] [PATCH 4/4 V2] ALSA: hda - Continue probe in work context to avoid request_module deadlock

2013-05-24 Thread Takashi Iwai
At Thu, 23 May 2013 19:41:58 +0200, David Henningsson wrote: On 05/23/2013 12:29 PM, Wang, Xingchao wrote: -Original Message- From: Takashi Iwai [mailto:ti...@suse.de] Sent: Thursday, May 23, 2013 6:27 PM To: Wang, Xingchao Cc: Wang Xingchao; alsa-de...@alsa-project.org

[Intel-gfx] [PATCH] drm/i915: Use proper print format for debug prints

2013-09-09 Thread Takashi Iwai
Replace %8x with %08x. The hex number should be shown with zero stuffed instead of spaces. Signed-off-by: Takashi Iwai ti...@suse.de --- drivers/gpu/drm/i915/intel_display.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers

Re: [Intel-gfx] [PATCH 2/2] [v2] drm/i915: Disable GGTT PTEs on GEN6+ suspend

2013-10-17 Thread Takashi Iwai
At Wed, 16 Oct 2013 18:27:33 +0100, Chris Wilson wrote: On Wed, Oct 16, 2013 at 10:06:27AM -0700, Ben Widawsky wrote: On Wed, Oct 16, 2013 at 05:58:31PM +0100, Chris Wilson wrote: So clearing the valid bit should result in the GPU reporting errors for delayed accesses, but none were

Re: [Intel-gfx] [PATCH 2/2] [v2] drm/i915: Disable GGTT PTEs on GEN6+ suspend

2013-10-17 Thread Takashi Iwai
At Thu, 17 Oct 2013 10:24:07 +0100, Chris Wilson wrote: On Thu, Oct 17, 2013 at 09:41:09AM +0200, Takashi Iwai wrote: At Wed, 16 Oct 2013 18:27:33 +0100, Chris Wilson wrote: On Wed, Oct 16, 2013 at 10:06:27AM -0700, Ben Widawsky wrote: On Wed, Oct 16, 2013 at 05:58:31PM +0100

[Intel-gfx] [PATCH] drm/i915: Retry reading DPCD when bogus values are read

2013-11-22 Thread Takashi Iwai
intermittently without plug state changes and even after the first few reads succeeded. As a workaround, add a sanity check for such bogus values and retry reading if it hits. Signed-off-by: Takashi Iwai ti...@suse.de --- drivers/gpu/drm/i915/intel_dp.c | 15 ++- 1 file changed, 14 insertions

[Intel-gfx] [PATCH] drm/i915: Don't write DSPSURF for old chips

2012-02-27 Thread Takashi Iwai
It seems that writing DSPSURF in intel_flush_display_plane() causes the blank screen on some old laptops like Dell D630 with 965GM. Since this operation is needed only for ILK+, make it conditional. Cc: sta...@kernel.org [v3.1+] Signed-off-by: Takashi Iwai ti...@suse.de --- drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH] drm/i915: Don't write DSPSURF for old chips

2012-02-27 Thread Takashi Iwai
At Mon, 27 Feb 2012 12:17:57 +, Chris Wilson wrote: On Mon, 27 Feb 2012 12:39:24 +0100, Takashi Iwai ti...@suse.de wrote: It seems that writing DSPSURF in intel_flush_display_plane() causes the blank screen on some old laptops like Dell D630 with 965GM. Since this operation is needed

  1   2   3   4   5   6   >