is incompatible with it.
Signed-off-by: Tomeu Vizoso
---
drivers/gpu/drm/i915/i915_irq.c | 57 ---
drivers/gpu/drm/i915/intel_display.c | 1 +
drivers/gpu/drm/i915/intel_drv.h | 1 +
drivers/gpu/drm/i915/intel_pipe_crc.c | 17 +++
4 files changed,
In preparation to using a generic API in the DRM core for continuous CRC
generation, move the related code out of i915_debugfs.c into a new file.
Eventually, only the Intel-specific code will remain in this new file.
v2: Rebased.
Signed-off-by: Tomeu Vizoso
---
drivers/gpu/drm/i915/Makefile
for hardware that can provide frame CRCs (including eDP
panels that support self-refresh) can easily implement the new callback
and provide userspace with the CRC values.
Thanks,
Tomeu
Tomeu Vizoso (3):
drm/i915/debugfs: Move out pipe CRC code
drm: Add API for capturing frame CRCs
drm/i915
for hardware that can provide frame CRCs (including eDP
panels that support self-refresh) can easily implement the new callback
and provide userspace with the CRC values.
Thanks,
Tomeu
Tomeu Vizoso (3):
drm/i915/debugfs: Move out pipe CRC code
drm: Add API for capturing frame CRCs
drm/i915
In preparation to using a generic API in the DRM core for continuous CRC
generation, move the related code out of i915_debugfs.c into a new file.
Eventually, only the Intel-specific code will remain in this new file.
v2: Rebased.
Signed-off-by: Tomeu Vizoso
---
drivers/gpu/drm/i915/Makefile
is incompatible with it.
v3:
- Use the "cooked" vblank counter so we have a whole 32 bits.
- Make sure we don't mess with the state of the legacy CRC capture
ABI implementation.
Signed-off-by: Tomeu Vizoso
---
drivers/gpu/drm/i915/i915_irq.c | 69 --
On 3 August 2016 at 10:01, Daniel Vetter wrote:
> On Fri, Jul 22, 2016 at 04:10:45PM +0200, Tomeu Vizoso wrote:
>> The core provides now an ABI to userspace for generation of frame CRCs,
>> so implement the ->set_crc_source() callback and reuse as much code as
>> possib
On 26 December 2017 at 19:19, Matt Roper wrote:
> On Wed, Dec 20, 2017 at 10:59:57AM +0100, Daniel Vetter wrote:
>> On Tue, Dec 19, 2017 at 03:27:31PM -0800, Dongwon Kim wrote:
>> > I forgot to include this brief information about this patch series.
>> >
>> > This patch series contains the impleme
In preparation to using a generic API in the DRM core for continuous CRC
generation, move the related code out of i915_debugfs.c into a new file.
Eventually, only the Intel-specific code will remain in this new file.
v2: Rebased.
Signed-off-by: Tomeu Vizoso
---
drivers/gpu/drm/i915/Makefile
Use drm_accurate_vblank_count so we have the full 32 bit to represent
the frame counter and userspace has a simpler way of knowing when the
counter wraps around.
Signed-off-by: Tomeu Vizoso
---
drivers/gpu/drm/i915/i915_irq.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff
for hardware that can provide frame CRCs (including eDP
panels that support self-refresh) can easily implement the new callback
and provide userspace with the CRC values.
Thanks,
Tomeu
Tomeu Vizoso (4):
drm/i915/debugfs: Move out pipe CRC code
drm: Add API for capturing frame CRCs
drm/i915
ommit.
Signed-off-by: Tomeu Vizoso
---
drivers/gpu/drm/i915/i915_irq.c | 69 ---
drivers/gpu/drm/i915/intel_display.c | 1 +
drivers/gpu/drm/i915/intel_drv.h | 2 +
drivers/gpu/drm/i915/intel_pipe_crc.c | 124 --
4 files chang
ould make sense to change the series
structure only if there was a strong reason, as a few people have
already looked at the patches already.
> On 5 August 2016 at 11:45, Tomeu Vizoso wrote:
>
>> +static int do_set_crc_source(struct drm_device *dev, enum pipe pipe,
>>
for hardware that can provide frame CRCs (including eDP
panels that support self-refresh) can easily implement the new callback
and provide userspace with the CRC values.
Thanks,
Tomeu
Tomeu Vizoso (4):
drm/i915/debugfs: Move out pipe CRC code
drm: Add API for capturing frame CRCs
drm/i915
In preparation to using a generic API in the DRM core for continuous CRC
generation, move the related code out of i915_debugfs.c into a new file.
Eventually, only the Intel-specific code will remain in this new file.
v2: Rebased.
Signed-off-by: Tomeu Vizoso
---
drivers/gpu/drm/i915/Makefile
llowup commit.
v5:
- Skip first frame or two as it's known that they contain wrong
data.
- A few fixes suggested by Emil Velikov.
Signed-off-by: Tomeu Vizoso
---
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/i915/i915_irq.c | 83 +++--
Use drm_accurate_vblank_count so we have the full 32 bit to represent
the frame counter and userspace has a simpler way of knowing when the
counter wraps around.
Signed-off-by: Tomeu Vizoso
---
drivers/gpu/drm/i915/i915_irq.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff
On 5 September 2016 at 14:44, Emil Velikov wrote:
> On 5 September 2016 at 10:45, Tomeu Vizoso wrote:
>> On 2 September 2016 at 17:18, Emil Velikov wrote:
>>> Hi Tomeu,
>>>
>>> IMHO it would be better to split out the refactoring into preparatory
>>&g
In preparation to using a generic API in the DRM core for continuous CRC
generation, move the related code out of i915_debugfs.c into a new file.
Eventually, only the Intel-specific code will remain in this new file.
v2: Rebased.
v6: Rebased.
Signed-off-by: Tomeu Vizoso
---
drivers/gpu/drm
llowup commit.
v5:
- Skip first frame or two as it's known that they contain wrong
data.
- A few fixes suggested by Emil Velikov.
v6:
- Rework programming of the HW registers to preserve previous
behavior.
Signed-off-by: Tomeu Vizoso
---
drivers/gpu/drm/i915/i915_drv.h
Use drm_accurate_vblank_count so we have the full 32 bit to represent
the frame counter and userspace has a simpler way of knowing when the
counter wraps around.
Signed-off-by: Tomeu Vizoso
---
drivers/gpu/drm/i915/i915_irq.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff
for hardware that can provide frame CRCs (including eDP
panels that support self-refresh) can easily implement the new callback
and provide userspace with the CRC values.
Thanks,
Tomeu
Tomeu Vizoso (4):
drm/i915/debugfs: Move out pipe CRC code
drm: Add API for capturing frame CRCs
drm/i915
ncs->set_crc_source(crtc, NULL);
err:
spin_lock_irq(&crc->lock);
crtc_crc_cleanup(crc);
Adding Tomeu Vizoso to the cc.
Can you resend the series, and add dri-de...@lists.freedesktop.org and the
driver maintainers to the cc? You'll need to get acks from the main
So that we can add an alternative implementation for the other arches.
This is basically what the kernel does.
Signed-off-by: Tomeu Vizoso
---
tests/kms_cursor_legacy.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/tests/kms_cursor_legacy.c b/tests
for hardware that can provide frame CRCs (including eDP
panels that support self-refresh) can easily implement the new callback
and provide userspace with the CRC values.
Thanks,
Tomeu
Tomeu Vizoso (3):
drm/i915/debugfs: Move out pipe CRC code
drm: Add API for capturing frame CRCs
drm/i915
so the current
testsuite still passes.
Signed-off-by: Tomeu Vizoso
---
drivers/gpu/drm/i915/i915_debugfs.c | 8 +-
drivers/gpu/drm/i915/i915_dma.c | 2 -
drivers/gpu/drm/i915/i915_drv.h | 21 --
drivers/gpu/drm/i915/i915_irq.c | 39 +--
drivers/gpu/drm/i915/intel_displa
In preparation to using a generic API in the DRM core for continuous CRC
generation, move the related code out of i915_debugfs.c into a new file.
Eventually, only the Intel-specific code will remain in this new file.
Signed-off-by: Tomeu Vizoso
---
drivers/gpu/drm/i915/Makefile | 2
On 06/22/2016 10:12 AM, Daniel Vetter wrote:
> On Tue, Jun 21, 2016 at 02:41:29PM +0100, Emil Velikov wrote:
>> On 21 June 2016 at 13:50, Marius Vlad wrote:
>>> On Mon, Jun 20, 2016 at 03:52:35PM +0100, Emil Velikov wrote:
Hi Rob,
A couple of nitpicks and a case of missing git add :
On 22 June 2016 at 13:41, Daniel Vetter wrote:
> On Wed, Jun 22, 2016 at 12:40 PM, Tomeu Vizoso
> wrote:
>>>>>> Thinking about it... I'm not sure that the release manager will find
>>>>>> this note here :-\
>>>>>>
>>
__drm_open_driver was changed to bail out on VGEM devices unless they
are explicitly asked for (DRIVER_VGEM). But with that change we lost
support for DRIVER_ANY.
Signed-off-by: Tomeu Vizoso
Fixes: 7ce63894854d ("lib: Support opening vGEM device")
Cc: Chris Wilson
---
lib/drmtest.c |
On 27 October 2016 at 10:06, Chris Wilson wrote:
> On Thu, Oct 27, 2016 at 09:58:19AM +0200, Tomeu Vizoso wrote:
>> __drm_open_driver was changed to bail out on VGEM devices unless they
>> are explicitly asked for (DRIVER_VGEM). But with that change we lost
>> support for DRI
Hi Lyude,
I think this looks very good.
On 8 November 2016 at 01:05, Lyude wrote:
>
> - While writing this patch series, I found that quite a few of the RPC calls
>for chameleond don't work as expected. For instance, I have had absolutely
>no luck getting CRCs from any of the display ty
On 8 November 2016 at 01:05, Lyude wrote:
> For the purpose of testing things such as hotplugging and bad monitors,
> the ChromeOS team ended up designing a neat little device known as the
> Chamelium. More information on this can be found here:
>
> https://www.chromium.org/chromium-os/tes
We were passing in two places a framebuffer modifier constant instead of
a tiling constant.
Also adds igt_fb_mod_to_tiling so tests can do that by themselves.
Cc: Tvrtko Ursulin
Fixes: 8a1a38661f56 ("lib: Add igt_create_bo_with_dimensions")
Signed-off-by: Tomeu Vizoso
---
li
GEM_SET_TILING doesn't care about Yf or Ys, so just pass Y.
Signed-off-by: Tomeu Vizoso
---
lib/ioctl_wrappers.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c
index 95bc5e268bcd..eabf3ee3abe6 100644
--- a/lib/ioctl_wrappers.c
+++
Though right now modifiers are only used to specify tiling, there are
different constants for them and naming them differently should help
with not mixing them.
Signed-off-by: Tomeu Vizoso
---
lib/igt_fb.c| 83 +++--
lib/igt_fb.h
On 1 November 2016 at 16:44, Tvrtko Ursulin wrote:
>
> Hi,
>
>
>
> On 02/03/16 14:00, Tomeu Vizoso wrote:
>>
>> igt_create_bo_with_dimensions() is intended to abstract differences
>> between drivers in buffer object creation.
>>
>> The driver-spec
On 11/10/2016 05:23 PM, Tvrtko Ursulin wrote:
>
> On 10/11/2016 13:17, Tomeu Vizoso wrote:
>> On 1 November 2016 at 16:44, Tvrtko Ursulin wrote:
>>>
>>> Hi,
>>>
>>>
>>>
>>> On 02/03/16 14:00, Tomeu Vizoso wrote:
>>>
On 11 November 2016 at 12:33, Tvrtko Ursulin
wrote:
>
> On 11/11/2016 11:23, Tomeu Vizoso wrote:
>>
>> On 11/10/2016 05:23 PM, Tvrtko Ursulin wrote:
>>>
>>>
>>> On 10/11/2016 13:17, Tomeu Vizoso wrote:
>>>>
>>>> On 1 Nov
The kernel expects that BOs for framebuffers with
I915_FORMAT_MOD_Yf_TILED will have I915_TILING_NONE.
Fixes: 050c00d53f39 ("lib: Pass I915_TILING_Y to the kernel if Yf or Ys")
Cc: Tvrtko Ursulin
Signed-off-by: Tomeu Vizoso
---
lib/ioctl_wrappers.c | 3 ++-
1 file changed, 2 insert
Hi Abdiel,
here running the whole of kms_busy causes all subtests after the first
one to be skipped due to:
Test requirement not met in function __real_main164, file
../../intel-gpu-tools/tests/kms_busy.c:195:
Test requirement: gem_has_ring(display.drm_fd, e->exec_id | e->flags)
If I run the sub
On 14 November 2016 at 19:24, Abdiel Janulgue
wrote:
> A lot of igt testcases need some GPU workload to make sure a race
> window is big enough. Unfortunately having a fixed amount of
> workload leads to spurious test failures or overtly long runtimes
> on some fast/slow platforms. This library co
On 15 November 2016 at 11:59, Tomeu Vizoso wrote:
> On 14 November 2016 at 19:24, Abdiel Janulgue
> wrote:
>> A lot of igt testcases need some GPU workload to make sure a race
>> window is big enough. Unfortunately having a fixed amount of
>> workload leads to spurious
liked it mostly because we already depend on glib.
> On Wed, 2016-11-09 at 16:09 +0100, Tomeu Vizoso wrote:
>> Hi Lyude,
>>
>> I think this looks very good.
>>
>> On 8 November 2016 at 01:05, Lyude wrote:
>> >
>> >
>> > - Whi
On 15 November 2016 at 09:01, Daniel Vetter wrote:
> On Mon, Nov 14, 2016 at 06:59:16PM +0900, Gustavo Padovan wrote:
>> From: Gustavo Padovan
>>
>> Signed-off-by: Gustavo Padovan
>> ---
>> tests/kms_atomic_transition.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a
On 15 November 2016 at 22:44, Lyude Paul wrote:
> I'm fine with libsoup as well, I'll check it out and probably move all
> of the code over to using that instead.
Cool.
> On Tue, 2016-11-15 at 12:44 +0100, Tomeu Vizoso wrote:
>> On 11 November 2016 at 18:53, Lyude Paul
On 15 November 2016 at 09:27, Jani Nikula wrote:
> On Tue, 15 Nov 2016, David Weinehall wrote:
>> On Mon, Nov 14, 2016 at 12:44:25PM +0200, Jani Nikula wrote:
>>> On Thu, 06 Oct 2016, Tomeu Vizoso wrote:
>>> > diff --git a/drivers/gpu/drm/i915/intel_display.c
On 16 November 2016 at 13:58, Jani Nikula wrote:
> On Wed, 16 Nov 2016, Tomeu Vizoso wrote:
>> On 15 November 2016 at 09:27, Jani Nikula
>> wrote:
>>> On Tue, 15 Nov 2016, David Weinehall wrote:
>>>> On Mon, Nov 14, 2016 at 12:44:25PM +0200, Jani Nikula wro
Automake seems to not like variable assignments indented with tabs.
Signed-off-by: Tomeu Vizoso
Fixes: 9e5478dc4345 ("lib: Only compile igt_vc4 is we have it")
---
lib/Makefile.am | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/Makefile.am b/lib/Makefil
able to hide differences in the buffer creation API as much as possible.
Thanks,
Tomeu
Tomeu Vizoso (14):
lib: add igt_require_intel
lib: Have gem_set_tiling require intel
lib: Expose is_i915_device
lib: Have intel_get_drm_devid call igt_require_intel
lib: Call intel_get_drm_devid only
Add function that requires that the driver we are talking to is i915.
This allows us to skip subtests that are specific to that driver.
Signed-off-by: Tomeu Vizoso
---
lib/drmtest.c | 5 +
lib/drmtest.h | 2 ++
2 files changed, 7 insertions(+)
diff --git a/lib/drmtest.c b/lib/drmtest.c
It only makes sense when testing the i915 driver, so don't call it
otherwise.
Signed-off-by: Tomeu Vizoso
---
lib/igt_fb.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index 5f23136e01ac..3e76a419b3ee 100644
--- a/lib/igt
Lib and test code can use this function to avoid i915-specific behavior
when running on other drivers.
Signed-off-by: Tomeu Vizoso
---
lib/drmtest.c | 2 +-
lib/drmtest.h | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/drmtest.c b/lib/drmtest.c
index bb9ca507a922
river-specific way.
Signed-off-by: Tomeu Vizoso
---
lib/ioctl_wrappers.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c
index 5d4972931506..0221b7fef3a1 100644
--- a/lib/ioctl_wrappers.c
+++ b/lib/ioctl_wrappers.c
@@ -138,6 +138,8 @
I915_PARAM_CHIPSET_ID is a i915-only thing, so if a subtest ends up
calling it when testing another driver, let's skip it.
Signed-off-by: Tomeu Vizoso
---
lib/intel_chipset.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/intel_chipset.c b/lib/intel_chipset.c
index 0e5b016
Because determining the Intel GFX generation requires a call to
DRM_IOCTL_I915_GETPARAM, move the code that requires it to a subtest
that can be skipped on drivers other than i915.
Signed-off-by: Tomeu Vizoso
---
tests/kms_addfb_basic.c | 36 +++-
1 file changed
Because calls to gem_set_tiling will cause the subtest to be skipped on
drivers other than i915, move them to each subtest that needs them so
the other subtests aren't skipped as well.
Signed-off-by: Tomeu Vizoso
---
tests/kms_addfb_basic.c | 8
1 file changed, 4 insertions(
igt_create_bo_with_dimensions() is intended to abstract differences
between drivers in buffer object creation.
The driver-specific ioctls will be called if the driver that is being
tested can satisfy the needs of the calling subtest, or it will be
skipped otherwise.
Signed-off-by: Tomeu Vizoso
For those tests that now pass on drivers other than i915, call
drm_open_driver_master with DRIVER_ANY.
Also do so from igt_enable_connectors.
Signed-off-by: Tomeu Vizoso
---
lib/igt_kms.c | 2 +-
tests/drm_read.c| 2 +-
tests/kms_addfb_basic.c | 2 +-
tests/kms_atomic.c
So they don't cause unrelated subtests to be skipped when testing
drivers other than i915.
Signed-off-by: Tomeu Vizoso
---
tests/kms_addfb_basic.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c
index 6dfaecf
Move tests requiring tiled BOs to the end so they don't cause unrelated
subtests to be skipped when testing drivers with only dumb buffer
support.
Signed-off-by: Tomeu Vizoso
---
tests/kms_addfb_basic.c | 50 -
1 file changed, 45 insertions(
If a buffer object is dumb, call DRM_IOCTL_MODE_MAP_DUMB when mapping
it. Also, don't call DRM_IOCTL_I915_GEM_SET_DOMAIN on dumb buffers.
Signed-off-by: Tomeu Vizoso
---
lib/igt_fb.c | 20 +---
1 file changed, 17 insertions(+), 3 deletions(-)
diff --git a/lib/igt_fb.c
In order to test drivers that don't have support for proper buffer
objects, add a wrapper for creating dumb buffer objects that will be
called from the lib code for those subtests that don't need to care.
Signed-off-by: Tomeu Vizoso
---
lib/ioctl_wrapp
Many tests can do their work on drivers other than i915 and even with
just dumb buffers, so call igt_create_bo_with_dimensions instead of
gem_create which will paper out the differences and call the proper
ioctls or cause the subtest to be skipped if that's not possible.
Signed-off-by:
On 03/05/2016 01:33 PM, Daniel Vetter wrote:
> On Wed, Mar 02, 2016 at 03:00:19PM +0100, Tomeu Vizoso wrote:
>> Move tests requiring tiled BOs to the end so they don't cause unrelated
>> subtests to be skipped when testing drivers with only dumb buffer
>> support.
>
On 03/05/2016 01:30 PM, Daniel Vetter wrote:
> On Wed, Mar 02, 2016 at 03:00:15PM +0100, Tomeu Vizoso wrote:
>> igt_create_bo_with_dimensions() is intended to abstract differences
>> between drivers in buffer object creation.
>>
>> The driver-specific ioctls will be c
instead of dumb_create from
igt_create_bo_with_dimensions.
- Add missing gtkdoc to igt_create_bo_with_dimensions.
- Try to use GEM API when a stride is passed
Tomeu Vizoso (17):
lib: Rename is_intel to has_known_intel_chipset
lib: add igt_require_intel
lib: Have gem_set_tiling require
It only makes sense when testing the i915 driver, so don't call it
otherwise.
Signed-off-by: Tomeu Vizoso
---
Changes in v2: None
lib/igt_fb.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index 7b535560033d..f936961a484f 1
Just wraps drmModeDirtyFB and for now invalidates the whole FB.
Signed-off-by: Tomeu Vizoso
---
Changes in v2:
- Add igt_dirty_fb
lib/igt_fb.c | 14 ++
lib/igt_fb.h | 1 +
2 files changed, 15 insertions(+)
diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index f936961a484f..9d6cff0edd23
igt_create_bo_with_dimensions() is intended to abstract differences
between drivers in buffer object creation.
The driver-specific ioctls will be called if the driver that is being
tested can satisfy the needs of the calling subtest, or it will be
skipped otherwise.
Signed-off-by: Tomeu Vizoso
If a buffer object is dumb, call DRM_IOCTL_MODE_MAP_DUMB when mapping
it. Also, don't call DRM_IOCTL_I915_GEM_SET_DOMAIN on dumb buffers.
Signed-off-by: Tomeu Vizoso
---
Changes in v2:
- Call dirtyfb after the cairo context associated to a FB backed by a
dumb buffer is destroyed. For th
Add function that requires that the driver we are talking to is i915.
This allows us to skip subtests that are specific to that driver.
Signed-off-by: Tomeu Vizoso
---
Changes in v2:
- Rename is_intel to has_known_intel_chipset as suggested by Chris
Wilson.
lib/drmtest.c | 5 +
lib
river-specific way.
Signed-off-by: Tomeu Vizoso
---
Changes in v2: None
lib/ioctl_wrappers.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/ioctl_wrappers.c b/lib/ioctl_wrappers.c
index 5d4972931506..0221b7fef3a1 100644
--- a/lib/ioctl_wrappers.c
+++ b/lib/ioctl_wrappers.c
@@ -138,6 +
Lib and test code can use this function to avoid i915-specific behavior
when running on other drivers.
Signed-off-by: Tomeu Vizoso
---
Changes in v2: None
lib/drmtest.c | 2 +-
lib/drmtest.h | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/drmtest.c b/lib/drmtest.c
As it reflects more clearly what the function actually does.
Suggested-by: Chris Wilson
Signed-off-by: Tomeu Vizoso
---
Changes in v2: None
lib/drmtest.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/lib/drmtest.c b/lib/drmtest.c
index 7b2227fe0f6a
I915_PARAM_CHIPSET_ID is a i915-only thing, so if a subtest ends up
calling it when testing another driver, let's skip it.
Signed-off-by: Tomeu Vizoso
---
Changes in v2: None
lib/intel_chipset.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/lib/intel_chipset.c b/lib/intel_chip
In order to test drivers that don't have support for proper buffer
objects, add a wrapper for creating dumb buffer objects that will be
called from the lib code for those subtests that don't need to care.
Signed-off-by: Tomeu Vizoso
---
Changes in v2:
- Rename dumb_create to kmstest_d
Many tests can do their work on drivers other than i915 and even with
just dumb buffers, so call igt_create_bo_with_dimensions instead of
gem_create which will paper out the differences and call the proper
ioctls or cause the subtest to be skipped if that's not possible.
Signed-off-by:
Because calls to gem_set_tiling will cause the subtest to be skipped on
drivers other than i915, move them to each subtest that needs them so
the other subtests aren't skipped as well.
Signed-off-by: Tomeu Vizoso
---
Changes in v2: None
tests/kms_addfb_basic.c | 8
1 file chang
For those tests that now pass on drivers other than i915, call
drm_open_driver_master with DRIVER_ANY.
Also do so from igt_enable_connectors.
Signed-off-by: Tomeu Vizoso
---
Changes in v2: None
lib/igt_kms.c | 2 +-
tests/drm_read.c| 2 +-
tests/kms_addfb_basic.c | 2
Because determining the Intel GFX generation requires a call to
DRM_IOCTL_I915_GETPARAM, move the code that requires it to a subtest
that can be skipped on drivers other than i915.
Signed-off-by: Tomeu Vizoso
---
Changes in v2: None
tests/kms_addfb_basic.c | 36
Which basically just calls DRM_IOCTL_MODE_MAP_DUMB and is similar to
gem_mmap__gtt().
Signed-off-by: Tomeu Vizoso
---
Changes in v2:
- Add helper kmstest_dumb_map_buffer as suggested by Daniel Vetter
lib/igt_kms.c | 16
lib/igt_kms.h | 3 +++
2 files changed, 19 insertions
Move tests requiring tiled BOs to the end so they don't cause unrelated
subtests to be skipped when testing drivers with only dumb buffer
support.
Signed-off-by: Tomeu Vizoso
---
Changes in v2: None
tests/kms_addfb_basic.c | 50 -
1 file ch
So they don't cause unrelated subtests to be skipped when testing
drivers other than i915.
Signed-off-by: Tomeu Vizoso
---
Changes in v2: None
tests/kms_addfb_basic.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_ba
Instead of checking that there's a CRTC in pipe 0 with a valid mode,
check that we can get a vblank in the primary display controller.
This should be equivalent, but also works with drivers other than i915.
Signed-off-by: Tomeu Vizoso
---
tests/drm_read.c
Hi,
these two patches remove the two last uses of
DRM_IOCTL_I915_GET_PIPE_FROM_CRTC_ID, with the intention of making the
tests runnable on !i915.
I have looked in the kernel and cannot find any point where the pipe ID
didn't match the index of the CRTC as returned by GETRESOURCES, so I'm
not incr
From: Micah Fedke
This function uses an intel-specific ioctl to fetch a mapping between pipes and
crtc ids, but this technique is outdated as the crtc id is now always
equivalent to its index in the array of crtcs returned by the kernel.
Signed-off-by: Tomeu Vizoso
---
Changes in v2: None
From: Micah Fedke
the crtc id is now always equivalent to its index in the array of crtcs
returned by the kernel
Signed-off-by: Micah Fedke
[tomeu: Fixed include path and removed some dead code]
Signed-off-by: Tomeu Vizoso
---
Changes in v2:
- Fix include path as suggested by Thomas
- Remove
Use drm_accurate_vblank_count so we have the full 32 bit to represent
the frame counter and userspace has a simpler way of knowing when the
counter wraps around.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/i915/i915_irq.c | 6 +++---
1 file changed, 3 insertions
the new ABI we
skip the 1st or 2nd frames.
v9:
- Add stub for intel_crtc_set_crc_source.
v12:
- Rebased.
- Remove stub for intel_crtc_set_crc_source and instead set the
callback to NULL (Jani Nikula).
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/g
intel_display_crc_init accept a drm_i915_private instead.
v12: Rebased.
Signed-off-by: Tomeu Vizoso
Reviewed-by: Emil Velikov
---
drivers/gpu/drm/i915/Makefile | 2 +-
drivers/gpu/drm/i915/i915_debugfs.c | 882 +--
drivers/gpu/drm/i915/intel_drv.h | 5 +
drivers
Tomeu Vizoso (4):
drm/i915/debugfs: Move out pipe CRC code
drm: Move locking into drm_debugfs_crtc_crc_add
drm/i915: Use new CRC debugfs API
drm/i915: Put "cooked" vlank counters in frame CRC lines
drivers/gpu/drm/drm_debugfs_crc.c |9 +-
drivers/gpu/drm/i915/Makefile
The kernel has now a new debugfs ABI that can also allow capturing frame
CRCs for drivers other than i915.
Add alternative codepaths so the new ABI is used if the kernel is recent
enough, and fall back to the legacy ABI if not.
Signed-off-by: Tomeu Vizoso
---
Have just rebased this, and made
On 21 November 2016 at 10:25, Abdiel Janulgue
wrote:
> v7: Adapt to api rename
> v8: Restore sanitycheck wait on the recursive batch and
> avoid using C99 locals (Chris Wilson)
>
> Cc: Chris Wilson
> Cc: Daniel Vetter
> Signed-off-by: Abdiel Janulgue
> ---
> tests/gem_wait.c | 128
> -
On 21 November 2016 at 10:25, Abdiel Janulgue
wrote:
> More and more test-cases are using this.
>
> Signed-off-by: Abdiel Janulgue
> ---
> lib/igt_aux.c | 11 ---
> lib/igt_aux.h | 10 ++
> lib/igt_core.c | 3 ---
> tests/drv_hangman.c | 1 -
> 4 files changed,
efines
> Minor code cleanups.
> Rename igt_spin_batch and igt_post_spin_batch to
> igt_spin_batch_new and igt_spin_batch_free
> respectively (Tomeu Vizoso).
> Fix error in dependency relocation handling in HSW causing
> tests to fail.
> v8: Restore correct
: Daniel Vetter
> Cc: Tomeu Vizoso
> Signed-off-by: Abdiel Janulgue
> ---
> tests/gem_wait.c | 126
> ---
> 1 file changed, 7 insertions(+), 119 deletions(-)
Looks good to me.
Reviewed-by: Tomeu Vizoso
Cheers,
Tomeu
Looks good to me.
Reviewed-by: Tomeu Vizoso
Cheers,
Tomeu
On 21 November 2016 at 10:25, Abdiel Janulgue
wrote:
> v7: Adapt to api rename
> v8: Tidy up finish_fb_busy (Chris Wilson)
>
> Cc: Chris Wilson
> Cc: Daniel Vetter
> Signed-off-by: Abdiel Janulgue
> ---
>
> ---
> tests/kms_flip.c | 212
> +++
> 1 file changed, 26 insertions(+), 186 deletions(-)
Looks good to me.
Reviewed-by: Tomeu Vizoso
Cheers,
Tomeu
> diff --git a/tests/kms_flip.c b/tests/kms_flip.c
> index 2a9fe2e..437
The test currently assumes that there are two overlay planes available,
but that's not generally true and from the error that returns the
kernel, it isn't obvious what's going on.
Signed-off-by: Tomeu Vizoso
---
tests/kms_plane_scaling.c | 4
1 file changed, 4 insertions(+
1 - 100 of 206 matches
Mail list logo
