Re: [Intel-gfx] [PATCH] drm/i915: Fix misplaced '\n' in printing the GPU error's RING_HEAD

2016-10-13 Thread Mika Kuoppala 
Chris Wilson  writes:

> '\n' is supposed to be at the end of the line, not in the middle.
>
> Fixes: cdb324bde570 ("drm/i915: Show bounds of active request in the ring...")
> Signed-off-by: Chris Wilson 
> Cc: Mika Kuoppala 

Oopsie.

Reviewed-by: Mika Kuoppala 

> ---
>  drivers/gpu/drm/i915/i915_gpu_error.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c 
> b/drivers/gpu/drm/i915/i915_gpu_error.c
> index 2df4bc2af0bb..673750fc0d5b 100644
> --- a/drivers/gpu/drm/i915/i915_gpu_error.c
> +++ b/drivers/gpu/drm/i915/i915_gpu_error.c
> @@ -368,7 +368,7 @@ static void error_print_engine(struct 
> drm_i915_error_state_buf *m,
>  {
>   err_printf(m, "%s command stream:\n", engine_str(ee->engine_id));
>   err_printf(m, "  START: 0x%08x\n", ee->start);
> - err_printf(m, "  HEAD:  0x%08x\n [0x%08x]", ee->head, ee->rq_head);
> + err_printf(m, "  HEAD:  0x%08x [0x%08x]\n", ee->head, ee->rq_head);
>   err_printf(m, "  TAIL:  0x%08x [0x%08x, 0x%08x]\n",
>  ee->tail, ee->rq_post, ee->rq_tail);
>   err_printf(m, "  CTL:   0x%08x\n", ee->ctl);
> -- 
> 2.9.3
>
> ___
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[Intel-gfx] [PATCH] drm/i915: Fix misplaced '\n' in printing the GPU error's RING_HEAD

2016-10-12 Thread Chris Wilson 
'\n' is supposed to be at the end of the line, not in the middle.

Fixes: cdb324bde570 ("drm/i915: Show bounds of active request in the ring...")
Signed-off-by: Chris Wilson 
Cc: Mika Kuoppala 
---
 drivers/gpu/drm/i915/i915_gpu_error.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/i915_gpu_error.c 
b/drivers/gpu/drm/i915/i915_gpu_error.c
index 2df4bc2af0bb..673750fc0d5b 100644
--- a/drivers/gpu/drm/i915/i915_gpu_error.c
+++ b/drivers/gpu/drm/i915/i915_gpu_error.c
@@ -368,7 +368,7 @@ static void error_print_engine(struct 
drm_i915_error_state_buf *m,
 {
err_printf(m, "%s command stream:\n", engine_str(ee->engine_id));
err_printf(m, "  START: 0x%08x\n", ee->start);
-   err_printf(m, "  HEAD:  0x%08x\n [0x%08x]", ee->head, ee->rq_head);
+   err_printf(m, "  HEAD:  0x%08x [0x%08x]\n", ee->head, ee->rq_head);
err_printf(m, "  TAIL:  0x%08x [0x%08x, 0x%08x]\n",
   ee->tail, ee->rq_post, ee->rq_tail);
err_printf(m, "  CTL:   0x%08x\n", ee->ctl);
-- 
2.9.3

___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx