Re: [Intel-gfx] [PATCH] drm/i915: Nul-terminate legacy debug string
Quoting Ville Syrjälä (2018-05-17 20:06:28) > On Thu, May 17, 2018 at 04:28:24PM +0100, Chris Wilson wrote: > > Make sure that when we don't have any scheduler attributes for the > > request the string is terminated. > > > > Fixes: 247870ac8ea7 ("drm/i915: Build request info on stack before printk") > > Signed-off-by: Chris Wilson > > Cc: Joonas Lahtinen > > Reviewed-by: Ville Syrjälä Thanks for the review, pushed before I have to read any more garbage in the CI logs. -Chris ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH] drm/i915: Nul-terminate legacy debug string
On Thu, May 17, 2018 at 04:28:24PM +0100, Chris Wilson wrote: > Make sure that when we don't have any scheduler attributes for the > request the string is terminated. > > Fixes: 247870ac8ea7 ("drm/i915: Build request info on stack before printk") > Signed-off-by: Chris Wilson > Cc: Joonas Lahtinen Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/intel_engine_cs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c > b/drivers/gpu/drm/i915/intel_engine_cs.c > index d4e159ae65a6..e78c6e769e8c 100644 > --- a/drivers/gpu/drm/i915/intel_engine_cs.c > +++ b/drivers/gpu/drm/i915/intel_engine_cs.c > @@ -1143,7 +1143,7 @@ static void print_request(struct drm_printer *m, > const char *prefix) > { > const char *name = rq->fence.ops->get_timeline_name(&rq->fence); > - char buf[80]; > + char buf[80] = ""; > int x = 0; > > x = print_sched_attr(rq->i915, &rq->sched.attr, buf, x, sizeof(buf)); > -- > 2.17.0 > > ___ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Ville Syrjälä Intel ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH] drm/i915: Nul-terminate legacy debug string
Make sure that when we don't have any scheduler attributes for the request the string is terminated. Fixes: 247870ac8ea7 ("drm/i915: Build request info on stack before printk") Signed-off-by: Chris Wilson Cc: Joonas Lahtinen --- drivers/gpu/drm/i915/intel_engine_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_engine_cs.c b/drivers/gpu/drm/i915/intel_engine_cs.c index d4e159ae65a6..e78c6e769e8c 100644 --- a/drivers/gpu/drm/i915/intel_engine_cs.c +++ b/drivers/gpu/drm/i915/intel_engine_cs.c @@ -1143,7 +1143,7 @@ static void print_request(struct drm_printer *m, const char *prefix) { const char *name = rq->fence.ops->get_timeline_name(&rq->fence); - char buf[80]; + char buf[80] = ""; int x = 0; x = print_sched_attr(rq->i915, &rq->sched.attr, buf, x, sizeof(buf)); -- 2.17.0 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx