Re: [Intel-gfx] [PATCH 0/8] HuC Loading Patches
On Mon, 16 Jan 2017, Jani Nikula wrote: > On Fri, 13 Jan 2017, Anusha Srivatsa wrote: >> The patches add HuC loading support. The driver builds a frame level >> workload which is stored in the graphics memory. This workload is presented >> to HuC for processing. The driver, therefore should first determine if the >> HuC is enabled and also read the huC athentication status bit to determine >> if HuC was successfully loaded. The GuC is required to authenticate the HuC. > > Please fix your git send-email workflow to send the patches properly > threaded. Thank you. And now I finally reached the properly sent series from Saturday. Sorry for the noise. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 0/8] HuC Loading Patches
On Fri, 13 Jan 2017, Anusha Srivatsa wrote: > The patches add HuC loading support. The driver builds a frame level > workload which is stored in the graphics memory. This workload is presented > to HuC for processing. The driver, therefore should first determine if the > HuC is enabled and also read the huC athentication status bit to determine > if HuC was successfully loaded. The GuC is required to authenticate the HuC. Please fix your git send-email workflow to send the patches properly threaded. Thank you. BR, Jani. -- Jani Nikula, Intel Open Source Technology Center ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH 0/8] HuC Loading Patches
The patches add HuC loading support. The driver builds a frame level workload which is stored in the graphics memory. This workload is presented to HuC for processing. The driver, therefore should first determine if the HuC is enabled and also read the huC athentication status bit to determine if HuC was successfully loaded. The GuC is required to authenticate the HuC. The userspace patches that check for a fully loaded HuC firmware and use it can be found at: https://lists.freedesktop.org/archives/libva/2016-September/004554.html https://lists.freedesktop.org/archives/libva/2016-September/004555.html More information regarding the HuC, batch commands that configure the HuC etc can be found at- https://01.org/sites/default/files/documentation/intel-gfx-prm-osrc-skl-vol02a-commandreference-instructions-huc.pdf https://www.x.org/docs/intel/CHV/intel-gfx-prm-osrc-chv-bsw-vol10-hevc.pdf v2: rebased. Changed the code following the review comments. v3: rebased. Organize code. Move contents of intel_huc.h to intel_uc.h. Update function intel_huc_load(),intel_huc_init() and intel_uc_fw_fetch() to accept dev_priv instead of dev. v4: rebased. Remove intel_is_huc_valid() since it is called onoly once. Refactor the code to reduce redundency. Remove fiels like uc_dev which are no longer used. v5: rebased. Beautify the code- remove comments that no longer hold good, add newlines etc. v6: rebased. Remove further redundency. Correct comments. Replace wait_for with intel_wait_for_register() for optimisation purpose.Make fw_type an enum. v7: rebased. Rename intel_huc_loader() to intel_huc(). Move intel_guc_auth_huc() from intel_uc.c to intel_huc.c. Add return values to DRM_ERRORs. v8: Use DRM_INFO instead of DRM_ERROR in places that are non-erraneous. Remove invalidates that are no longer required. Anusha Srivatsa (8): drm/i915/guc: Make the GuC fw loading helper functions general drm/i915/huc: Unified css_header struct for GuC and HuC drm/i915/huc: Add HuC fw loading support drm/i915/huc: Add BXT HuC Loading Support drm/i915/HuC: Add KBL huC loading Support drm/i915/huc: Add debugfs for HuC loading status check drm/i915/huc: Support HuC authentication drm/i915/get_params: Add HuC status to getparams drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/i915_debugfs.c| 43 +++- drivers/gpu/drm/i915/i915_drv.c| 10 + drivers/gpu/drm/i915/i915_drv.h| 2 + drivers/gpu/drm/i915/i915_guc_reg.h| 6 + drivers/gpu/drm/i915/i915_guc_submission.c | 4 +- drivers/gpu/drm/i915/intel_guc_fwif.h | 24 +- drivers/gpu/drm/i915/intel_guc_loader.c| 196 + drivers/gpu/drm/i915/intel_huc.c | 342 + drivers/gpu/drm/i915/intel_uc.h| 60 +++-- include/uapi/drm/i915_drm.h| 1 + 11 files changed, 569 insertions(+), 120 deletions(-) create mode 100644 drivers/gpu/drm/i915/intel_huc.c -- 2.7.4 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH 0/8] HuC Loading Patches
The patches add HuC loading support. The driver builds a frame level workload which is stored in the graphics memory. This workload is presented to HuC for processing. The driver, therefore should first determine if the HuC is enabled and also read the huC athentication status bit to determine if HuC was successfully loaded. The GuC is required to authenticate the HuC. The userspace patches that check for a fully loaded HuC firmware and use it can be found at: https://lists.freedesktop.org/archives/libva/2016-September/004554.html https://lists.freedesktop.org/archives/libva/2016-September/004555.html More information regarding the HuC, batch commands that configure the HuC etc can be found at- https://01.org/sites/default/files/documentation/intel-gfx-prm-osrc-skl-vol02a-commandreference-instructions-huc.pdf https://www.x.org/docs/intel/CHV/intel-gfx-prm-osrc-chv-bsw-vol10-hevc.pdf v2: rebased. Changed the code following the review comments. v3: rebased. Organize code. Move contents of intel_huc.h to intel_uc.h. Update function intel_huc_load(),intel_huc_init() and intel_uc_fw_fetch() to accept dev_priv instead of dev. v4: rebased. Remove intel_is_huc_valid() since it is called onoly once. Refactor the code to reduce redundency. Remove fiels like uc_dev which are no longer used. v5: rebased. Beautify the code- remove comments that no longer hold good, add newlines etc. v6: rebased. Remove further redundency. Correct comments. Replace wait_for with intel_wait_for_register() for optimisation purpose.Make fw_type an enum. v7: rebased. Rename intel_huc_loader() to intel_huc(). Move intel_guc_auth_huc() from intel_uc.c to intel_huc.c. Add return values to DRM_ERRORs. v8: Use DRM_INFO instead of DRM_ERROR in places that are non-erraneous. Remove invalidates that are no longer required. Anusha Srivatsa (8): drm/i915/guc: Make the GuC fw loading helper functions general drm/i915/huc: Unified css_header struct for GuC and HuC drm/i915/huc: Add HuC fw loading support drm/i915/huc: Add BXT HuC Loading Support drm/i915/HuC: Add KBL huC loading Support drm/i915/huc: Add debugfs for HuC loading status check drm/i915/huc: Support HuC authentication drm/i915/get_params: Add HuC status to getparams drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/i915_debugfs.c| 43 +++- drivers/gpu/drm/i915/i915_drv.c| 10 + drivers/gpu/drm/i915/i915_drv.h| 2 + drivers/gpu/drm/i915/i915_guc_reg.h| 6 + drivers/gpu/drm/i915/i915_guc_submission.c | 4 +- drivers/gpu/drm/i915/intel_guc_fwif.h | 24 +- drivers/gpu/drm/i915/intel_guc_loader.c| 196 + drivers/gpu/drm/i915/intel_huc.c | 342 + drivers/gpu/drm/i915/intel_uc.h| 60 +++-- include/uapi/drm/i915_drm.h| 1 + 11 files changed, 569 insertions(+), 120 deletions(-) create mode 100644 drivers/gpu/drm/i915/intel_huc.c -- 2.7.4 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH 0/8] HuC Loading Patches
The patches add HuC loading support. The driver builds a frame level workload which is stored in the graphics memory. This workload is presented to HuC for processing. The driver, therefore should first determine if the HuC is enabled and also read the huC athentication status bit to determine if HuC was successfully loaded. The GuC is required to authenticate the HuC. The userspace patches that check for a fully loaded HuC firmware and use it can be found at: https://lists.freedesktop.org/archives/libva/2016-September/004554.html https://lists.freedesktop.org/archives/libva/2016-September/004555.html More information regarding the HuC, batch commands that configure the HuC etc can be found at- https://01.org/sites/default/files/documentation/intel-gfx-prm-osrc-skl-vol02a-commandreference-instructions-huc.pdf https://www.x.org/docs/intel/CHV/intel-gfx-prm-osrc-chv-bsw-vol10-hevc.pdf v2: rebased. Changed the code following the review comments. v3: rebased. Organize code. Move contents of intel_huc.h to intel_uc.h. Update function intel_huc_load(),intel_huc_init() and intel_uc_fw_fetch() to accept dev_priv instead of dev. v4: rebased. Remove intel_is_huc_valid() since it is called onoly once. Refactor the code to reduce redundency. Remove fiels like uc_dev which are no longer used. v5: rebased. Beautify the code- remove comments that no longer hold good, add newlines etc. v6: rebased. Remove further redundency. Correct comments. Replace wait_for with intel_wait_for_register() for optimisation purpose.Make fw_type an enum. v7: rebased. Rename intel_huc_loader() to intel_huc(). Move intel_guc_auth_huc() from intel_uc.c to intel_huc.c. Add return values to DRM_ERRORs. Anusha Srivatsa (8): drm/i915/guc: Make the GuC fw loading helper functions general drm/i915/huc: Unified css_header struct for GuC and HuC drm/i915/huc: Add HuC fw loading support drm/i915/huc: Add BXT HuC Loading Support drm/i915/HuC: Add KBL huC loading Support drm/i915/huc: Add debugfs for HuC loading status check drm/i915/huc: Support HuC authentication drm/i915/get_params: Add HuC status to getparams drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/i915_debugfs.c| 43 +++- drivers/gpu/drm/i915/i915_drv.c| 10 + drivers/gpu/drm/i915/i915_drv.h| 2 + drivers/gpu/drm/i915/i915_guc_reg.h| 6 + drivers/gpu/drm/i915/i915_guc_submission.c | 4 +- drivers/gpu/drm/i915/intel_guc_fwif.h | 24 +- drivers/gpu/drm/i915/intel_guc_loader.c| 196 + drivers/gpu/drm/i915/intel_huc.c | 342 + drivers/gpu/drm/i915/intel_uc.h| 60 +++-- include/uapi/drm/i915_drm.h| 1 + 11 files changed, 569 insertions(+), 120 deletions(-) create mode 100644 drivers/gpu/drm/i915/intel_huc.c -- 2.7.4 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH 0/8] HuC Loading Patches
The patches add HuC loading support. The driver builds a frame level workload which is stored in the graphics memory. This workload is presented to HuC for processing. The driver, therefore should first determine if the HuC is enabled and also read the huC athentication status bit to determine if HuC was successfully loaded. The GuC is required to authenticate the HuC. The userspace patches that check for a fully loaded HuC firmware and use it can be found at: https://lists.freedesktop.org/archives/libva/2016-September/004554.html https://lists.freedesktop.org/archives/libva/2016-September/004555.html More information regarding the HuC, batch commands that configure the HuC etc can be found at- https://01.org/sites/default/files/documentation/intel-gfx-prm-osrc-skl-vol02a-commandreference-instructions-huc.pdf https://www.x.org/docs/intel/CHV/intel-gfx-prm-osrc-chv-bsw-vol10-hevc.pdf v2: rebased. Changed the code following the review comments. v3: rebased. Organize code. Move contents of intel_huc.h to intel_uc.h. Update function intel_huc_load(),intel_huc_init() and intel_uc_fw_fetch() to accept dev_priv instead of dev. v4: rebased. Remove intel_is_huc_valid() since it is called onoly once. Refactor the code to reduce redundency. Remove fiels like uc_dev which are no longer used. v5: rebased. Beautify the code- remove comments that no longer hold good, add newlines etc. v6: rebased. Remove further redundency. Correct comments. Replace wait_for with intel_wait_for_register() for optimisation purpose.Make fw_type an enum. v7: rebased. Rename intel_huc_loader() to intel_huc(). Move intel_guc_auth_huc() from intel_uc.c to intel_huc.c. Add return values to DRM_ERRORs. Anusha Srivatsa (8): drm/i915/guc: Make the GuC fw loading helper functions general drm/i915/huc: Unified css_header struct for GuC and HuC drm/i915/huc: Add HuC fw loading support drm/i915/huc: Add BXT HuC Loading Support drm/i915/HuC: Add KBL huC loading Support drm/i915/huc: Add debugfs for HuC loading status check drm/i915/huc: Support HuC authentication drm/i915/get_params: Add HuC status to getparams drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/i915_debugfs.c| 43 +++- drivers/gpu/drm/i915/i915_drv.c| 10 + drivers/gpu/drm/i915/i915_drv.h| 2 + drivers/gpu/drm/i915/i915_guc_reg.h| 6 + drivers/gpu/drm/i915/i915_guc_submission.c | 4 +- drivers/gpu/drm/i915/intel_guc_fwif.h | 24 +- drivers/gpu/drm/i915/intel_guc_loader.c| 196 + drivers/gpu/drm/i915/intel_huc.c | 342 + drivers/gpu/drm/i915/intel_uc.h| 60 +++-- include/uapi/drm/i915_drm.h| 1 + 11 files changed, 569 insertions(+), 120 deletions(-) create mode 100644 drivers/gpu/drm/i915/intel_huc.c -- 2.7.4 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH 0/8] HuC Loading Patches
The patches add HuC loading support. The driver builds a frame level workload which is stored in the graphics memory. This workload is presented to HuC for processing. The driver, therefore should first determine if the HuC is enabled and also read the huC athentication status bit to determine if HuC was successfully loaded. The GuC is required to authenticate the HuC. The userspace patches that check for a fully loaded HuC firmware and use it can be found at: https://lists.freedesktop.org/archives/libva/2016-September/004554.html https://lists.freedesktop.org/archives/libva/2016-September/004555.html More information regarding the HuC, batch commands that configure the HuC etc can be found at- https://01.org/sites/default/files/documentation/intel-gfx-prm-osrc-skl-vol02a-commandreference-instructions-huc.pdf https://www.x.org/docs/intel/CHV/intel-gfx-prm-osrc-chv-bsw-vol10-hevc.pdf v2: rebased. Changed the code following the review comments. v3: rebased. Organize code. Move contents of intel_huc.h to intel_uc.h. Update function intel_huc_load(),intel_huc_init() and intel_uc_fw_fetch() to accept dev_priv instead of dev. v4: rebased. Remove intel_is_huc_valid() since it is called onoly once. Refactor the code to reduce redundency. Remove fiels like uc_dev which are no longer used. v5: rebased. Beautify the code- remove comments that no longer hold good, add newlines etc. v6: rebased. Remove further redundency. Correct comments. Replace wait_for with intel_wait_for_register() for optimisation purpose.Make fw_type an enum. v7: rebased. Rename intel_huc_loader() to intel_huc(). Move intel_guc_auth_huc() from intel_uc.c to intel_huc.c. Add return values to DRM_ERRORs. Anusha Srivatsa (8): drm/i915/guc: Make the GuC fw loading helper functions general drm/i915/huc: Unified css_header struct for GuC and HuC drm/i915/huc: Add HuC fw loading support drm/i915/huc: Add BXT HuC Loading Support drm/i915/HuC: Add KBL huC loading Support drm/i915/huc: Add debugfs for HuC loading status check drm/i915/huc: Support HuC authentication drm/i915/get_params: Add HuC status to getparams drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/i915_debugfs.c| 43 +++- drivers/gpu/drm/i915/i915_drv.c| 10 + drivers/gpu/drm/i915/i915_drv.h| 2 + drivers/gpu/drm/i915/i915_guc_reg.h| 6 + drivers/gpu/drm/i915/i915_guc_submission.c | 4 +- drivers/gpu/drm/i915/intel_guc_fwif.h | 24 +- drivers/gpu/drm/i915/intel_guc_loader.c| 196 + drivers/gpu/drm/i915/intel_huc.c | 342 + drivers/gpu/drm/i915/intel_uc.h| 60 +++-- include/uapi/drm/i915_drm.h| 1 + 11 files changed, 569 insertions(+), 120 deletions(-) create mode 100644 drivers/gpu/drm/i915/intel_huc.c -- 2.7.4 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH 0/8] HuC Loading Patches
These patches add HuC loading support. The driver builds a frame level workload which is stored in the graphics memory. This workload is presented to HuC for processing. The driver, therefore should first determine if the HuC is enabled and also read the huC athentication status bit to determine if HuC was successfully loaded. The GuC is required to authenticate the HuC. The userspace patches that check for a fully loaded HuC firmware and use it can be found at: https://lists.freedesktop.org/archives/libva/2016-September/004554.html https://lists.freedesktop.org/archives/libva/2016-September/004555.html More information regarding the HuC, batch commands that configure the HuC etc can be found at- https://01.org/sites/default/files/documentation/intel-gfx-prm-osrc-skl-vol02a-commandreference-instructions-huc.pdf https://www.x.org/docs/intel/CHV/intel-gfx-prm-osrc-chv-bsw-vol10-hevc.pdf v2: rebased. v3: rebased. Changed the code following the review comments. v4: Added action_lock initialization fix provided by Arek (Hiler Arkadiusz) to the first patch in the series- Make the GuC fw loading helper functions general. v5: rebased on top of drm-tip. The patch series is now in sync with GuC code reorganization efforts by Arek- https://patchwork.freedesktop.org/series/15896/ v6:rebased. Organize code. Move contents of intel_huc.h to intel_uc.h. Update function intel_huc_load(),intel_huc_init() and intel_uc_fw_fetch() to accept dev_priv instead of dev. v7: rebased. Remove intel_is_huc_valid() since it is called onoly once. Refactor the code to reduce redundency. Remove fiels like uc_dev which are no longer used. v8: rebased. Beautify the code- remove comments that no longer hold good, add newlines etc. v9: rebased. Remove further redundency. Correct comments. Replace wait_for with intel_wait_for_register() for optimisation purpose.Make fw_type an enum. Anusha Srivatsa (3): drm/i915/huc: Add HuC fw loading support drm/i915/huc: Add BXT HuC Loading Support drm/i915/HuC: Add KBL huC loading Support Peter Antoine (5): drm/i915/guc: Make the GuC fw loading helper functions general drm/i915/huc: Unified css_header struct for GuC and HuC drm/i915/huc: Add debugfs for HuC loading status check drm/i915/huc: Support HuC authentication drm/i915/get_params: Add HuC status to getparams drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/i915_debugfs.c| 43 - drivers/gpu/drm/i915/i915_drv.c| 11 +- drivers/gpu/drm/i915/i915_drv.h| 3 +- drivers/gpu/drm/i915/i915_guc_reg.h| 3 + drivers/gpu/drm/i915/i915_guc_submission.c | 4 +- drivers/gpu/drm/i915/intel_guc_fwif.h | 24 ++- drivers/gpu/drm/i915/intel_guc_loader.c| 200 ++-- drivers/gpu/drm/i915/intel_huc_loader.c| 283 + drivers/gpu/drm/i915/intel_uc.c| 68 ++- drivers/gpu/drm/i915/intel_uc.h| 64 +-- include/uapi/drm/i915_drm.h| 1 + 12 files changed, 579 insertions(+), 126 deletions(-) create mode 100644 drivers/gpu/drm/i915/intel_huc_loader.c -- 2.7.4 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH 0/8] HuC Loading Patches
These patches add HuC loading support. The driver builds a frame level workload which is stored in the graphics memory. This workload is presented to HuC for processing. The driver, therefore should first determine if the HuC is enabled and also read the huC athentication status bit to determine if HuC was successfully loaded. The GuC is required to authenticate the HuC. The userspace patches that check for a fully loaded HuC firmware and use it can be found at: https://lists.freedesktop.org/archives/libva/2016-September/004554.html https://lists.freedesktop.org/archives/libva/2016-September/004555.html More information regarding the HuC, batch commands that configure the HuC etc can be found at- https://01.org/sites/default/files/documentation/intel-gfx-prm-osrc-skl-vol02a-commandreference-instructions-huc.pdf https://www.x.org/docs/intel/CHV/intel-gfx-prm-osrc-chv-bsw-vol10-hevc.pdf v2: rebased. v3: rebased. Changed the code following the review comments. v4: Added action_lock initialization fix provided by Arek (Hiler Arkadiusz) to the first patch in the series- Make the GuC fw loading helper functions general. v5: rebased on top of drm-tip. The patch series is now in sync with GuC code reorganization efforts by Arek- https://patchwork.freedesktop.org/series/15896/ v6:rebased. Organize code. Move contents of intel_huc.h to intel_uc.h. Update function intel_huc_load(),intel_huc_init() and intel_uc_fw_fetch() to accept dev_priv instead of dev. v7: rebased. Remove intel_is_huc_valid() since it is called onoly once. Refactor the code to reduce redundency. Remove fiels like uc_dev which are no longer used. v8: rebased. Beautify the code- remove comments that no longer hold good, add newlines etc. v9: rebased. Remove further redundency. Correct comments. Replace wait_for with intel_wait_for_register() for optimisation purpose.Make fw_type an enum. Anusha Srivatsa (3): drm/i915/huc: Add HuC fw loading support drm/i915/huc: Add BXT HuC Loading Support drm/i915/HuC: Add KBL huC loading Support Peter Antoine (5): drm/i915/guc: Make the GuC fw loading helper functions general drm/i915/huc: Unified css_header struct for GuC and HuC drm/i915/huc: Add debugfs for HuC loading status check drm/i915/huc: Support HuC authentication drm/i915/get_params: Add HuC status to getparams drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/i915_debugfs.c| 43 - drivers/gpu/drm/i915/i915_drv.c| 11 +- drivers/gpu/drm/i915/i915_drv.h| 3 +- drivers/gpu/drm/i915/i915_guc_reg.h| 3 + drivers/gpu/drm/i915/i915_guc_submission.c | 4 +- drivers/gpu/drm/i915/intel_guc_fwif.h | 24 ++- drivers/gpu/drm/i915/intel_guc_loader.c| 200 ++-- drivers/gpu/drm/i915/intel_huc_loader.c| 283 + drivers/gpu/drm/i915/intel_uc.c| 68 ++- drivers/gpu/drm/i915/intel_uc.h| 64 +-- include/uapi/drm/i915_drm.h| 1 + 12 files changed, 579 insertions(+), 126 deletions(-) create mode 100644 drivers/gpu/drm/i915/intel_huc_loader.c -- 2.7.4 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH 0/8] HuC Loading Patches
These patches add HuC loading support. The driver builds a frame level workload which is stored in the graphics memory. This workload is presented to HuC for processing. The driver, therefore should first determine if the HuC is enabled and also read the huC athentication status bit to determine if HuC was successfully loaded. The GuC is required to authenticate the HuC. The userspace patches that check for a fully loaded HuC firmware and use it can be found at: https://lists.freedesktop.org/archives/libva/2016-September/004554.html https://lists.freedesktop.org/archives/libva/2016-September/004555.html More information regarding the HuC, batch commands that configure the HuC etc can be found at- https://01.org/sites/default/files/documentation/intel-gfx-prm-osrc-skl-vol02a-commandreference-instructions-huc.pdf https://www.x.org/docs/intel/CHV/intel-gfx-prm-osrc-chv-bsw-vol10-hevc.pdf v2: rebased. v3: rebased. Changed the code following the review comments. v4: Added action_lock initialization fix provided by Arek (Hiler Arkadiusz) to the first patch in the series- Make the GuC fw loading helper functions general. v5: rebased on top of drm-tip. The patch series is now in sync with GuC code reorganization efforts by Arek- https://patchwork.freedesktop.org/series/15896/ v6:rebased. Organize code. Move contents of intel_huc.h to intel_uc.h. Update function intel_huc_load(),intel_huc_init() and intel_uc_fw_fetch() to accept dev_priv instead of dev. v7: rebased. Remove intel_is_huc_valid() since it is called onoly once. Refactor the code to reduce redundency. Remove fiels like uc_dev which are no longer used. v8: rebased. Beautify the code- remove comments that no longer hold good, add newlines etc. Anusha Srivatsa (3): drm/i915/huc: Add HuC fw loading support drm/i915/huc: Add BXT HuC Loading Support drm/i915/HuC: Add KBL huC loading Support Peter Antoine (5): drm/i915/guc: Make the GuC fw loading helper functions general drm/i915/huc: Unified css_header struct for GuC and HuC drm/i915/huc: Add debugfs for HuC loading status check drm/i915/huc: Support HuC authentication drm/i915/get_params: Add HuC status to getparams drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/i915_debugfs.c| 43 - drivers/gpu/drm/i915/i915_drv.c| 11 +- drivers/gpu/drm/i915/i915_drv.h| 3 +- drivers/gpu/drm/i915/i915_guc_reg.h| 3 + drivers/gpu/drm/i915/i915_guc_submission.c | 4 +- drivers/gpu/drm/i915/intel_guc_fwif.h | 24 ++- drivers/gpu/drm/i915/intel_guc_loader.c| 200 +++- drivers/gpu/drm/i915/intel_huc_loader.c| 286 + drivers/gpu/drm/i915/intel_uc.c| 62 +++ drivers/gpu/drm/i915/intel_uc.h| 63 +-- include/uapi/drm/i915_drm.h| 1 + 12 files changed, 577 insertions(+), 124 deletions(-) create mode 100644 drivers/gpu/drm/i915/intel_huc_loader.c -- 2.7.4 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH 0/8] HuC Loading Patches
These patches add HuC loading support. The driver builds a frame level workload which is stored in the graphics memory. This workload is presented to HuC for processing. The driver, therefore should first determine if the HuC is enabled and also read the huC athentication status bit to determine if HuC was successfully loaded. The GuC is required to authenticate the HuC. The userspace patches that check for a fully loaded HuC firmware and use it can be found at: https://lists.freedesktop.org/archives/libva/2016-September/004554.html https://lists.freedesktop.org/archives/libva/2016-September/004555.html More information regarding the HuC, batch commands that configure the HuC etc can be found at- https://01.org/sites/default/files/documentation/intel-gfx-prm-osrc-skl-vol02a-commandreference-instructions-huc.pdf https://www.x.org/docs/intel/CHV/intel-gfx-prm-osrc-chv-bsw-vol10-hevc.pdf v2: rebased. v3: rebased. Changed the code following the review comments. v4: Added action_lock initialization fix provided by Arek (Hiler Arkadiusz) to the first patch in the series- Make the GuC fw loading helper functions general. v5: rebased on top of drm-tip. The patch series is now in sync with GuC code reorganization efforts by Arek- https://patchwork.freedesktop.org/series/15896/ v6:rebased. Organize code. Move contents of intel_huc.h to intel_uc.h. Update function intel_huc_load(),intel_huc_init() and intel_uc_fw_fetch() to accept dev_priv instead of dev. v7: rebased. Remove intel_is_huc_valid() since it is called onoly once. Refactor the code to reduce redundency. Remove fiels like uc_dev which are no longer used. Signed-off-by: Anusha Srivatsa Cc: Arek Cc: Jeff Mcgee BLURB HERE *** Cc: Chris Wilson Anusha Srivatsa (3): drm/i915/huc: Add HuC fw loading support drm/i915/huc: Add BXT HuC Loading Support drm/i915/HuC: Add KBL huC loading Support Peter Antoine (5): drm/i915/guc: Make the GuC fw loading helper functions general drm/i915/huc: Unified css_header struct for GuC and HuC drm/i915/huc: Add debugfs for HuC loading status check drm/i915/huc: Support HuC authentication drm/i915/get_params: Add HuC status to getparams drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/i915_debugfs.c| 43 - drivers/gpu/drm/i915/i915_drv.c| 8 +- drivers/gpu/drm/i915/i915_drv.h| 3 +- drivers/gpu/drm/i915/i915_guc_reg.h| 3 + drivers/gpu/drm/i915/i915_guc_submission.c | 4 +- drivers/gpu/drm/i915/intel_guc_fwif.h | 24 ++- drivers/gpu/drm/i915/intel_guc_loader.c| 201 +++- drivers/gpu/drm/i915/intel_huc_loader.c| 290 + drivers/gpu/drm/i915/intel_uc.c| 62 ++ drivers/gpu/drm/i915/intel_uc.h| 63 +-- include/uapi/drm/i915_drm.h| 1 + 12 files changed, 579 insertions(+), 124 deletions(-) create mode 100644 drivers/gpu/drm/i915/intel_huc_loader.c -- 2.7.4 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH 0/8]HuC Loading Patches
These patches add HuC loading support. The GuC is required to authenticate the HuC. The userspace patches that check for a fully loaded HuC firmware and use it can be found at: https://lists.freedesktop.org/archives/libva/2016-September/004554.html https://lists.freedesktop.org/archives/libva/2016-September/004555.html More information regarding the HuC, batch commands that configure the HuC etc can be found at- https://01.org/sites/default/files/documentation/intel-gfx-prm-osrc-skl-vol02a-commandreference-instructions-huc.pdf https://www.x.org/docs/intel/CHV/intel-gfx-prm-osrc-chv-bsw-vol10-hevc.pdf v2: rebased. v3: rebased. Changed the code following the review comments. v4: Added action_lock initialization fix provided by Arek (Hiler Arkadiusz) to the first patch in the series- Make the GuC fw loading helper functions general. v5: rebased on top of drm-tip. The patch series is now in sync with GuC code reorganization efforts by Arek- https://patchwork.freedesktop.org/series/15896/ v6: rebased. Organize the code-move contents of intel_huc.h to intel_uc.h. Update functions intel_huc_load(),intel_huc_init() and intel_uc_fw_fetch() to accept dev_priv instead of dev. Anusha Srivatsa (3): drm/i915/huc: Add HuC fw loading support drm/i915/huc: Add BXT HuC Loading Support drm/i915/HuC: Add KBL huC loading Support Peter Antoine (5): drm/i915/guc: Make the GuC fw loading helper functions general drm/i915/huc: Unified css_header struct for GuC and HuC drm/i915/huc: Add debugfs for HuC loading status check drm/i915/huc: Support HuC authentication drm/i915/get_params: Add HuC status to getparams drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/i915_debugfs.c| 43 +++- drivers/gpu/drm/i915/i915_drv.c| 8 +- drivers/gpu/drm/i915/i915_drv.h| 3 +- drivers/gpu/drm/i915/i915_guc_reg.h| 3 + drivers/gpu/drm/i915/i915_guc_submission.c | 4 +- drivers/gpu/drm/i915/intel_guc_fwif.h | 22 ++- drivers/gpu/drm/i915/intel_guc_loader.c| 199 ++- drivers/gpu/drm/i915/intel_huc_loader.c| 303 + drivers/gpu/drm/i915/intel_uc.c| 61 ++ drivers/gpu/drm/i915/intel_uc.h| 68 +-- include/uapi/drm/i915_drm.h| 1 + 12 files changed, 593 insertions(+), 123 deletions(-) create mode 100644 drivers/gpu/drm/i915/intel_huc_loader.c -- 2.7.4 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH 0/8] HuC Loading Patches
These patches add HuC loading support. The GuC is required to authenticate the HuC. The userspace patches that check for a fully loaded HuC firmware and use it can be found at: https://lists.freedesktop.org/archives/libva/2016-September/004554.html https://lists.freedesktop.org/archives/libva/2016-September/004555.html More information regarding the HuC, batch commands that configure the HuC etc can be found at- https://01.org/sites/default/files/documentation/intel-gfx-prm-osrc-skl-vol02a-commandreference-instructions-huc.pdf https://www.x.org/docs/intel/CHV/intel-gfx-prm-osrc-chv-bsw-vol10-hevc.pdf v2: rebased. v3: rebased. Changed the code following the review comments. v4: Added action_lock initialization fix provided by Arek (Hiler Arkadiusz) to the first patch in the series- Make the GuC fw loading helper functions general. v5: rebased on top of drm-tip. The patch series is now in sync with GuC code reorganization efforts by Arek- https://patchwork.freedesktop.org/series/15896/ Signed-off-by: Anusha Srivatsa Cc: Arek Cc: Jeff Mcgee Anusha Srivatsa (2): drm/i915/huc: Add BXT HuC Loading Support drm/i915/HuC: Add KBL huC loading Support Peter Antoine (6): drm/i915/guc: Make the GuC fw loading helper functions general drm/i915/huc: Unified css_header struct for GuC and HuC drm/i914/huc: Add HuC fw loading support drm/i915/huc: Add debugfs for HuC loading status check drm/i915/huc: Support HuC authentication drm/i915/get_params: Add HuC status to getparams drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/i915_debugfs.c| 43 +++- drivers/gpu/drm/i915/i915_drv.c| 9 +- drivers/gpu/drm/i915/i915_drv.h| 4 +- drivers/gpu/drm/i915/i915_guc_reg.h| 3 + drivers/gpu/drm/i915/i915_guc_submission.c | 67 ++- drivers/gpu/drm/i915/intel_guc_fwif.h | 22 ++- drivers/gpu/drm/i915/intel_guc_loader.c| 196 +- drivers/gpu/drm/i915/intel_huc.h | 43 drivers/gpu/drm/i915/intel_huc_loader.c| 306 + drivers/gpu/drm/i915/intel_uc.h| 47 +++-- include/uapi/drm/i915_drm.h| 1 + 12 files changed, 620 insertions(+), 122 deletions(-) create mode 100644 drivers/gpu/drm/i915/intel_huc.h create mode 100644 drivers/gpu/drm/i915/intel_huc_loader.c -- 2.7.4 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 0/8] HuC Loading Patches
On Wed, Nov 23, 2016 at 02:27:35PM -0800, Anusha Srivatsa wrote:
> These patches add HuC loading support. The userspace
> patches that check for a fully loaded HuC firmware and use
> it can be found at:
> https://lists.freedesktop.org/archives/libva/2016-September/004554.html
> https://lists.freedesktop.org/archives/libva/2016-September/004555.html
>
> v2: rebased.
> v3: rebased. Changed the code following the review comments.
> v4: Added action_lock initialization fix provided by Arick
> (Hiler Arkadiusz) to the first patch in the series- Make the
> GuC fw loading helper functions general.
>
> Signed-off-by: Anusha Srivatsa
>
> Anusha Srivatsa (2):
> drm/i915/huc: Add BXT HuC Loading Support
> drm/i915/HuC: Add KBL huC loading Support
>
> Peter Antoine (6):
> drm/i915/guc: Make the GuC fw loading helper functions general. Always
> initialize action_lock
> drm/i915/huc: Unified css_header struct for GuC and HuC
> drm/i915/huc: Add HuC fw loading support
> drm/i915/huc: Add debugfs for HuC loading status check
> drm/i915/huc: Support HuC authentication
Bolting HuC authenticaiton to the guc_submission.c is not very elegant
solution. Yes, it uses the same mechanism, but HuC can be set up having
GuC submission turned off.
This approach already caused us issues with the 'action_lock'.
I do not think that is the place for the code anyway. Instead I have
whole patch series (currently in review) that does some GuC codebase
reorganization - it evolved from the mutex_init() moving patch you've
seen.
New files, intel_uc.{c,h} are introduced - those are suitable for
renamed intel_uc_* entities from:
" drm/i915/guc: Make the GuC fw loading helper functions general"
The series also exposes intel_guc_{send,recv}() functions which you can
use for triggering the HuC authentication (rebranded host2guc_*).
Please take a look at "GuC code reorganization" series and share your
thoughs.
--
Cheers,
Arek
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH 0/8] HuC Loading Patches
These patches add HuC loading support. The userspace patches that check for a fully loaded HuC firmware and use it can be found at: https://lists.freedesktop.org/archives/libva/2016-September/004554.html https://lists.freedesktop.org/archives/libva/2016-September/004555.html v2: rebased. v3: rebased. Changed the code following the review comments. v4: Added action_lock initialization fix provided by Arick (Hiler Arkadiusz) to the first patch in the series- Make the GuC fw loading helper functions general. Signed-off-by: Anusha Srivatsa Anusha Srivatsa (2): drm/i915/huc: Add BXT HuC Loading Support drm/i915/HuC: Add KBL huC loading Support Peter Antoine (6): drm/i915/guc: Make the GuC fw loading helper functions general. Always initialize action_lock drm/i915/huc: Unified css_header struct for GuC and HuC drm/i915/huc: Add HuC fw loading support drm/i915/huc: Add debugfs for HuC loading status check drm/i915/huc: Support HuC authentication drm/i915/get_params: Add HuC status to getparams drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/i915_debugfs.c| 43 +++- drivers/gpu/drm/i915/i915_drv.c| 8 + drivers/gpu/drm/i915/i915_drv.h| 3 + drivers/gpu/drm/i915/i915_guc_reg.h| 3 + drivers/gpu/drm/i915/i915_guc_submission.c | 70 ++- drivers/gpu/drm/i915/intel_guc.h | 49 +++-- drivers/gpu/drm/i915/intel_guc_fwif.h | 22 ++- drivers/gpu/drm/i915/intel_guc_loader.c| 196 +- drivers/gpu/drm/i915/intel_huc.h | 43 drivers/gpu/drm/i915/intel_huc_loader.c| 306 + include/uapi/drm/i915_drm.h| 1 + 12 files changed, 624 insertions(+), 121 deletions(-) create mode 100644 drivers/gpu/drm/i915/intel_huc.h create mode 100644 drivers/gpu/drm/i915/intel_huc_loader.c -- 2.7.4 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 0/8] HuC Loading Patches
On Thu, Sep 29, 2016 at 11:03:57AM -0700, Anusha Srivatsa wrote: > These patches add HuC loading support. The userspace > patches that check for a fully loaded HuC firmware and use > it can be found at: > https://lists.freedesktop.org/archives/libva/2016-September/004554.html > https://lists.freedesktop.org/archives/libva/2016-September/004555.html > > Peter Antoine (8): > drm/i915/guc: Make the GuC fw loading helper functions general > drm/i915/huc: Unified css_header struct for GuC and HuC > drm/i915/huc: Add HuC fw loading support > drm/i915/huc: Add debugfs for HuC loading status check > drm/i915/huc: Support HuC authentication > drm/i915/huc: Add BXT HuC Loading Support > drm/i915/get_params: Add GuC status to getparams > drm/i915/get_params: Add HuC status to getparams So trouble with these is that both original authors (all of them) and reviewers left intel. Which means we don't have anyone anymore who understands this, and a big part of review is making sure that in the end at least two people (author+reviewer) really understand the patches in full detail. In short we need to restart the review process here again before merging :( -Daniel > > drivers/gpu/drm/i915/Makefile | 1 + > drivers/gpu/drm/i915/i915_debugfs.c| 43 - > drivers/gpu/drm/i915/i915_drv.c| 11 ++ > drivers/gpu/drm/i915/i915_drv.h| 3 + > drivers/gpu/drm/i915/i915_guc_reg.h| 3 + > drivers/gpu/drm/i915/i915_guc_submission.c | 69 ++- > drivers/gpu/drm/i915/intel_guc.h | 46 +++-- > drivers/gpu/drm/i915/intel_guc_fwif.h | 17 +- > drivers/gpu/drm/i915/intel_guc_loader.c| 215 - > drivers/gpu/drm/i915/intel_huc.h | 44 + > drivers/gpu/drm/i915/intel_huc_loader.c| 289 > + > include/uapi/drm/i915_drm.h| 2 + > 12 files changed, 623 insertions(+), 120 deletions(-) > create mode 100644 drivers/gpu/drm/i915/intel_huc.h > create mode 100644 drivers/gpu/drm/i915/intel_huc_loader.c > > -- > 2.7.4 > > ___ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Re: [Intel-gfx] [PATCH 0/8] HuC Loading Patches
On Mon, Oct 03, 2016 at 11:42:54AM -0700, Anusha Srivatsa wrote: > These patches add HuC loading support. The userspace > patches that check for a fully loaded HuC firmware and use > it can be found at: > https://lists.freedesktop.org/archives/libva/2016-September/004554.html > https://lists.freedesktop.org/archives/libva/2016-September/004555.html > > v2: rebased. When submitting patches you always have to add your signed-off-by, even when they're not yours. The chain of people who've touched a patch must be completely tracked with these signed-off-by. No ideas on the patches themselves since I'm not a huc/guc expert. -Daniel > > > Peter Antoine (8): > drm/i915/guc: Make the GuC fw loading helper functions general > drm/i915/huc: Unified css_header struct for GuC and HuC > drm/i915/huc: Add HuC fw loading support > drm/i915/huc: Add debugfs for HuC loading status check > drm/i915/huc: Support HuC authentication > drm/i915/huc: Add BXT HuC Loading Support > drm/i915/get_params: Add GuC status to getparams > drm/i915/get_params: Add HuC status to getparams > > drivers/gpu/drm/i915/Makefile | 1 + > drivers/gpu/drm/i915/i915_debugfs.c| 43 - > drivers/gpu/drm/i915/i915_drv.c| 11 ++ > drivers/gpu/drm/i915/i915_drv.h| 3 + > drivers/gpu/drm/i915/i915_guc_reg.h| 3 + > drivers/gpu/drm/i915/i915_guc_submission.c | 69 ++- > drivers/gpu/drm/i915/intel_guc.h | 48 ++--- > drivers/gpu/drm/i915/intel_guc_fwif.h | 17 +- > drivers/gpu/drm/i915/intel_guc_loader.c| 215 - > drivers/gpu/drm/i915/intel_huc.h | 44 + > drivers/gpu/drm/i915/intel_huc_loader.c| 289 > + > include/uapi/drm/i915_drm.h| 2 + > 12 files changed, 624 insertions(+), 121 deletions(-) > create mode 100644 drivers/gpu/drm/i915/intel_huc.h > create mode 100644 drivers/gpu/drm/i915/intel_huc_loader.c > > -- > 2.7.4 > > ___ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH 0/8] HuC Loading Patches
These patches add HuC loading support. The userspace patches that check for a fully loaded HuC firmware and use it can be found at: https://lists.freedesktop.org/archives/libva/2016-September/004554.html https://lists.freedesktop.org/archives/libva/2016-September/004555.html v2: rebased. Peter Antoine (8): drm/i915/guc: Make the GuC fw loading helper functions general drm/i915/huc: Unified css_header struct for GuC and HuC drm/i915/huc: Add HuC fw loading support drm/i915/huc: Add debugfs for HuC loading status check drm/i915/huc: Support HuC authentication drm/i915/huc: Add BXT HuC Loading Support drm/i915/get_params: Add GuC status to getparams drm/i915/get_params: Add HuC status to getparams drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/i915_debugfs.c| 43 - drivers/gpu/drm/i915/i915_drv.c| 11 ++ drivers/gpu/drm/i915/i915_drv.h| 3 + drivers/gpu/drm/i915/i915_guc_reg.h| 3 + drivers/gpu/drm/i915/i915_guc_submission.c | 69 ++- drivers/gpu/drm/i915/intel_guc.h | 48 ++--- drivers/gpu/drm/i915/intel_guc_fwif.h | 17 +- drivers/gpu/drm/i915/intel_guc_loader.c| 215 - drivers/gpu/drm/i915/intel_huc.h | 44 + drivers/gpu/drm/i915/intel_huc_loader.c| 289 + include/uapi/drm/i915_drm.h| 2 + 12 files changed, 624 insertions(+), 121 deletions(-) create mode 100644 drivers/gpu/drm/i915/intel_huc.h create mode 100644 drivers/gpu/drm/i915/intel_huc_loader.c -- 2.7.4 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
[Intel-gfx] [PATCH 0/8] HuC Loading Patches
These patches add HuC loading support. The userspace patches that check for a fully loaded HuC firmware and use it can be found at: https://lists.freedesktop.org/archives/libva/2016-September/004554.html https://lists.freedesktop.org/archives/libva/2016-September/004555.html Peter Antoine (8): drm/i915/guc: Make the GuC fw loading helper functions general drm/i915/huc: Unified css_header struct for GuC and HuC drm/i915/huc: Add HuC fw loading support drm/i915/huc: Add debugfs for HuC loading status check drm/i915/huc: Support HuC authentication drm/i915/huc: Add BXT HuC Loading Support drm/i915/get_params: Add GuC status to getparams drm/i915/get_params: Add HuC status to getparams drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/i915_debugfs.c| 43 - drivers/gpu/drm/i915/i915_drv.c| 11 ++ drivers/gpu/drm/i915/i915_drv.h| 3 + drivers/gpu/drm/i915/i915_guc_reg.h| 3 + drivers/gpu/drm/i915/i915_guc_submission.c | 69 ++- drivers/gpu/drm/i915/intel_guc.h | 46 +++-- drivers/gpu/drm/i915/intel_guc_fwif.h | 17 +- drivers/gpu/drm/i915/intel_guc_loader.c| 215 - drivers/gpu/drm/i915/intel_huc.h | 44 + drivers/gpu/drm/i915/intel_huc_loader.c| 289 + include/uapi/drm/i915_drm.h| 2 + 12 files changed, 623 insertions(+), 120 deletions(-) create mode 100644 drivers/gpu/drm/i915/intel_huc.h create mode 100644 drivers/gpu/drm/i915/intel_huc_loader.c -- 2.7.4 ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx
